[Koha-bugs] [Bug 18364] LOCK and UNLOCK are not transaction-safe

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18364

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
$ENV{_} =~ m|prove|;

I'd still rather see a specific environment variable. As mentioned on irc
earlier, we could set some kind of lock variable in the environment via a
shared apache file or cron file. A test would not see that var and not lock the
table.

Another option (with some more impact on the code) would be to switch from
table locking to some kind of intelligent file locking here. (We use file
locking in rebuild zebra, but it should be more refined.) Advantage would be
that we do not differentiate between calls from a unit test and from other
scripts.

And the current test does not include running a separate test file from the
command line without prove (which I normally do). Could we test on a .t suffix
too?

In conclusion, I would not favor pushing this in its current from. Other
opinions are welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.