[Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 14 11:56:43 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Passing QA on this patch set.
I am not really a fan of the resulting DBIx tric to get this working. Now each
search with localization will need an additional view and an ugly relationship
hack in the schema file. But I have no other solution too. Tested the sub with
no, one or several languages in localization and it works perfect.

Also want to mention that the unit test t/db_dependent/Koha/ItemTypes.t is much
too simplistic. Adding 2/3 English localization is not sufficient to really
prove that the sub works. You cannot test localization with only one language,
and English is a bad example in Koha :) We need to mock getlanguage and put a
few different languages in localization to really see if it works. (I did that
now manually.)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list