[Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 17 08:46:43 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Nick 

When applying your patch (in a clean up to date branch) there is a merge
conflict where you have changed the opac/opac-search.pl (see below). I fixed
that locally by keeping the contents of lines 234-237 and removing the contents
of lines 232,233 and 238.

 232 <<<<<<< HEAD
 233 =======
 234 my $itemtypes_copy = { %$itemtypes }; #Sometime itemtypes can be c    
orrupted in advanced_srch_type loop
 235                                       #Making a copy ensure it is     
clean
 236 # Load the Type stuff without search categories for facets
 237 my $itemtypes_nocategory = GetItemTypes;
 238 >>>>>>> Bug 18400 - Noisy warns in opac-search.pl during itemtype     
sorting

Then whilst testing I used the OPAC search and I got the following software
error:

Bareword "GetItemTypes" not allowed while "strict subs" in use at
/home/vagrant/kohaclone/opac/opac-search.pl line 235.
Execution of /home/vagrant/kohaclone/opac/opac-search.pl aborted due to
compilation errors.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list