[Koha-bugs] [Bug 18433] Allow to select results to export in item search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Something sounds wrong here, I'd suggest that GetCategoryByKohaField should be
replaced with Koha::AuthorisedValues->search_by_koha_field->categories, do not
you think?

Failing QA because of CamelCase for GetCategoryByKohaField and lack of tests.

Note: I did not test but I'd expect
my @items = Koha::Items->search({ itemnumber => { -in => \@itemnumbers } });

to be faster and easier to read than:

my @items;
foreach my $itemnumber (@itemnumbers) {
    my $item = Koha::Items->find($itemnumber);
    if ($item) {
        push @items, $item;
    }
}

-- 
You are receiving this mail because:
You are watching all bug changes.