[Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382

--- Comment #25 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Jonathan Druart from comment #24)
> This <UNCHANGED> stuff smells like a very bad codding pattern.
> Could not we use empty string and undef/NULL to handle empty values?

Hello Jonathan,

I don't really see how to do that. 

If you create a course item this way:

my $ci_id2 = ModCourseItem(
    itemnumber    => $itemnumber,
    itype         => '',
    ccode         => 'BOOK',
    holdingbranch => '<UNCHANGED>',
    location      => '<UNCHANGED>',
);

or this way 

my $ci_id2 = ModCourseItem(
    itemnumber    => $itemnumber,
    ccode         => 'BOOK',
    holdingbranch => '<UNCHANGED>',
    location      => '<UNCHANGED>',
);

This results to the same when getting the course with GetCourseItem: itype is
undef.
Empty or null value are retrieved the same and we are unable to know if the
value has changed or not.

-- 
You are receiving this mail because:
You are watching all bug changes.