[Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Apr 18 20:41:00 CEST 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179
Marc Véron <veron at veron.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #62304|0 |1
is obsolete| |
--- Comment #11 from Marc Véron <veron at veron.ch> ---
Created attachment 62319
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62319&action=edit
Bug 18179: Forbid list context calls for Koha::Objects->find
Reading https://perlmaven.com/how-to-return-undef-from-a-function
this sound like the more correct behaviour.
Considering:
$template->param(
stuff => Koha::Stuffs->find( $id ),
foo => 1,
);
without this patch, if the $id does not represent any rows in the DB,
stuff will be assigned to 'foo' and $foo will be undef in the template.
That can lead to very bad side-effects.
With this patch we make sure that it will never happen again.
Test plan:
prove t/db_dependent/Koha/Objects.t
should return green
Signed-off-by: Marc Véron <veron at veron.ch>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list