[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 19 04:44:20 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 62349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62349&action=edit
Bug 18438 - Implemented data-dismiss="modal" attribute on 'Confirm hold' and
'confirm' buttons so when they are cliked the modal box dissapears and any
warning messages that were hidden by the box are now visible.

The form is submitted via the js onclick function when the 'Comfirm holds'
button is clicked because the checkin needs to be triggered by clicking this
button.

However when the 'Confirm' button is displayed this means that the item
was not checked out when the user is trying to check it back in. In
which case the check in does not need to be triggered and so in this
patch the 'Confirm' button does not submt the form it simply closes the
modal box to show any warning messages behind.

Test plan:
1. Check out an item to one patron whilst having that item also being on
hold to another patron

2. Check the item back in

3. Notice a modal box appears greying out the background with three
buttons 'Confirm hold', 'Print and confirm' and 'Ignore'. Click confirm
and notice that the page refreshes and no yellow warning messages are
able to be displayed

4. Now that you have checked the item in. Try checking it in a second
time by clicking on the Checkin tab and writing in the barcode.

5. The modal box will appear again, this time with three buttons
'Confirm', 'Print and confirm' and 'Cancel hold'

6. Click the 'Confirm' button and the page refreshes again and the
yellow warning message hidden by the modal box is not properly displayed
to the user

7. Apply patch

8. Try checking in the item again, and this time after clicking the
'confirm' button on the modal box notice that the yellow warning message
is displayed telling the user the item was "Not checked out"

9. Drop the hold on the item and make sure it is not checked out.

10. Repeat steps 1 and 2 and notice after clicking the 'Confirm hold'
button the page refreshes and the item is successfully checked back in

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list