[Koha-bugs] [Bug 18453] Syspref ExportCircHistory is broken

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Apr 19 17:16:51 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18453

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 62362
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62362
[SIGNED-OFF] Bug 18453: Syspref ExportCircHistory is broken

Review of attachment 62362:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18453&attachment=62362)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +35,4 @@
>  var theme = "[% theme %]";
>  var borrowernumber = "[% borrowernumber %]";
>  var branchcode = "[% branch %]";
> +var exports_enabled = [% Koha.Preference('ExportCircHistory') %];

If the pref is empty, the generated JS will be
  var exports_enabled = ;
And will raise a syntax error.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +27,4 @@
>  <script type="text/JavaScript">
>  //<![CDATA[
>  /* Set some variable needed in circulation.js */
> +var MSG_DT_LOADING_RECORDS = _("Loading... you may continue scanning.");

You cannot scan from moremember.

@@ +36,3 @@
>  var AllowRenewalLimitOverride = [% (CAN_user_circulate_override_renewals && Koha.Preference('AllowRenewalLimitOverride') )? 1: 0 %];
> +var AllowCirculate = [% (CAN_user_circulate_circulate_remaining_permissions)? 1 : 0 %];
> +var script = "circulation";

Did you find where this script variable is used?

@@ +43,4 @@
>  
>  var MSG_EXPORT_SELECT_CHECKOUTS = _("You must select checkout(s) to export");
>  
> +columns_settings = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'issues-table', 'json' ) %]

Hum? Why that? We are on moremember, we need to keep the config for moremember.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list