[Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Apr 20 20:46:56 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #52 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Very quick code review, did not test much:

1/ QA tests fail:
 FAIL   Koha/Patron/Relationships.pm
   FAIL   pod
                *** ERROR: 
                 in file Koha/Patron/Relationships.pm
                Spurious =cut command

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
   FAIL   forbidden patterns
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 535)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 536)

2/ Can set several fathers from the interface, but when I save only one is
kept. Sounds like we should handle that from the interface and not display more
than 2 guarantors (and not more than 1 with the same relationship).

3/ In misc/cronjobs/j2a.pl
+    $dbh->{AutoCommit} = 0;
You should use ->txn_begin

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list