[Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #14 from Marc Véron <veron at veron.ch> ---
(In reply to M. Tompsett from comment #13)
> (In reply to Marc Véron from comment #12)
> > As per comment #7, this patch affects AddMember and ModMember.
> 
> Yes. :)
> 
> 
> > The test plan should be the same as comment #6.
> 
> No, the test plan is comment #10.

Sorry, I did not edit the original commit messages. I expected them to be up to
date.

> 
> TEST PLAN
> ----------
> 1) Apply first patch
> 2) Run prove -v t/db_dependent/Members.t
>    -- expecting failures
> 3) Apply second patch
> 4) Run prove -v t/db_dependent/Members.t
>    -- expecting success
> 5) run koha qa test tools
>    -- two files modified with no issues
> 
> 
> > Secondary patch with tests still to come.
> 
> Because I purposefully changed two tests, there are no additional tests. The
> initial failures are because I purposefully changed the add and mod to
> include an extra space (. q{ }) at the end in two of the tests. With the new
> code, that will not change anything, because they are filtered. :)

Not sure, is my Sign-off OK or should I do more testing?

-- 
You are receiving this mail because:
You are watching all bug changes.