[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62628|0                           |1
        is obsolete|                            |
  Attachment #62629|0                           |1
        is obsolete|                            |

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 62662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62662&action=edit
[SIGNED-OFF] Bug 18339: Remove ->opac_editable ->opac_display from
Koha::Patron::Attribute

Trying to simplify the implementation of 13757, I replaced some legacy code
in favour of a Koha::Object-based implementation for the OPAC controller
scripts.
On doing so I went too far with this methods, as what was needed was a way to
retrieve
the type of the attribute and ask it about such properties.

This patch removes those methods, its tests, and replaces them for new methods
in the
Koha::Patron::Attributes class:
- K:P:A->search_opac_displayable
- K:P:A->search_opac_editable

To test:
- Run
  $ prove t/db_dependent/Koha/Patron/Attributes.t
=> SUCCESS: Tests still pass
- Try changing the opac_editable and opac_display properties and play in the
OPAC with those attributes.
Verify that everything works as expected.
- Sign off :-D

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.