[Koha-bugs] [Bug 18433] Allow to select results to export in item search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #25)
> (In reply to Jonathan Druart from comment #24)
> > Hum, I get "Template process failed: undef error - The method biblioitem is
> > not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121."
> > when I export to CSV.
> 
> If I apply the patch on a fresh master, I don't get this error, as
> Koha::Item::biblioitem is defined. You said on bug 18459 that the patch
> isn't in master, but it is
> (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;
> h=6527b3b67506db0289997eb9bb98647fa1967a55) so a git fetch + git rebase
> should fix the problem

Hum, not sure what happened here, certainly a lack of caffeine...

> > Something else I completely missed before: if you select rows then switch to
> > another page the behaviour will not work as expected.
> 
> What are you expecting exactly ? That the hidden rows keep their 'selected'
> state ? Or that the "Export selected results to" label changes back to
> "Export all results to" because there is no visible selected rows anymore ?

I do not really know but the current behaviour is wrong.
I think the better would be to keep the selected state.
Ccing Owen to get his point of view.

-- 
You are receiving this mail because:
You are watching all bug changes.