[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #56 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Hi Kyle,

I've been playing around with this, and am happy to do so (I will upload a
patch to this effect a little later), but from my perspective I'm not a fan of
the change:

- the database tables are called stockrotationitem etc., so the dbix class
files use the non-camel cased versions.
- changing the Koha namespace entries to camel case means we now have a
separation between dbix classes and the koha object code
- when working with the unit test builder interface, you now have to remember
to use non camel case, but when using the koha objects you have to use camel
case…

Also, given that the object is called a 'stockrotationitem' for instance, to me
it seems natural that the camel case boundary would be, for instance,
StockrotationitemDeliverer.

But then maybe the last point is the result of my German background, where
ridiculously long compound nouns are not seen as problematic ;-)

WDYT?

Alex

(In reply to Kyle M Hall from comment #55)
> Can you please camel case your module names for readability ( e.g.
> Koha::StockRotationItem instead of Koha::Stockrotationitem )?
> 
> Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.