[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #58 from Alex Sassmannshausen <alex.sassmannshausen at ptfs-europe.com> ---
Finally, there is the added complication of relations and other methods that
relate to stockrotation objects:

e.g. Koha::Item, line 189 defines the relation between an item and its stock
rotation item.  That method is currently, quite naturally, called
'stockrotationitem' ("give me the stockrotationitem object associated with this
item").

Should this now be:

stockRotationItem - this seems terrible and has no precedent, so probably
ignore this.

stock_rotation_item - so now we introduce yet another name for the same object;
just in a different context.  And what if we had a method like
"stock_rotation_item_index"?  Would this be an index of Koha::Items associated
with stock rotation, or would this be an index of stockrotationitems?

stockrotationitem - leave it as is.  But this seems inconsistent with the
renaming of the modules themselves.

I hope all of this does not come across as pedantic — I guess simply don't know
what the right approach is, and I'm not clear whether Koha community has a
clear policy on this.  If there is, I'm very happy to adopt that.

If there isn't, like I say, I have a preference for the approach I've taken so
far.

Cheers,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.