[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 28 10:56:49 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #5 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 62811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62811&action=edit
Bug 18450 - Implemented check if either AllowRenewLimitOverride or
AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only
blocked if both of these sysprefs are set to 'Dont allow'

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.
2. Place a hold on an item from a patron
3. Checkout the item out to a different patron
4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning
5. Click the 'Override and renew' button and notice that you
can bypass the hold
6. Apply patch
7. Renew the item again and notice that the message does not have a
'Override and renew' button it just has the 'Ignore and continue' button
8. Go back to More->Administration->Global system preferences and set
AllowRenewalLimitOverride to 'Allow'
9. Try renewing the same item again and notice that the 'Override and
renew' button is displayed
10. In systems preferences now set the
AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and
renew' button is displayed
11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew'
button is displayed
because you will not be violating these preferences.

Note: Checking if the renewal exceeds the renewal level, if auto renew
is set up, or if renewal is to soon is checked earlier in this
conditional
if statement earlier and so the check in this patch does not need to
check the renewal level, auto renewal, if renewal is too soon.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list