From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:36:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:36:35 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #37 from M. Tompsett ---
Created attachment 65376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65376&action=edit
Bug 14385: Properly trigger all changes in C4/Search.pm
prove t/db_dependent/Search.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:40:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:40:10 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #38 from M. Tompsett ---
Created attachment 65377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65377&action=edit
Bug 14385: Fix QA Test tool failures
C4/Search.pm had some tabs.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:43:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:43:20 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64688|0 |1
is obsolete| |
--- Comment #39 from M. Tompsett ---
Created attachment 65378
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65378&action=edit
Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower
categories
Edit: Fixing merge conflicts in
- t/db_dependent/Items.t
- t/db_dependent/Search.t
- C4/Search.pm
Changes the API for calling GetHiddenItems and all the places in the code that
call it. This is to allow borrower categories to be passed in.
Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories
to be able to see items, even if they are marked hidden by OpacHiddenItems
To test:
1) Make two borrowers, one in a category that should see everything (ie Adult),
and another in a category that should only see certain things (ie Adult -
exceptions)
2) Add the borrower that can see everything (the Adult) to
OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some
records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Adult -
exception)
5) Do a search, filtered to show records which are the item type that you
specified in the OpacHiddenItems syspref. No records should show for this
borrower as this item type is hidden to them.
6) Log in as the borrower that should see everything (Adult)
7) Do the same search. There should be results from this search, as this
borrower category has been specified as an exception to the hidden items
Signed-off-by: Claire Gravely
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:43:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:43:31 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64689|0 |1
is obsolete| |
--- Comment #40 from M. Tompsett ---
Created attachment 65379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65379&action=edit
Bug 14385 Followup: C4::Borrowers not found
GetMember is in C4::Members, not C4::Borrowers
Signed-off-by: Claire Gravely
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:43:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:43:40 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64690|0 |1
is obsolete| |
--- Comment #41 from M. Tompsett ---
Created attachment 65380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65380&action=edit
Bug 14385: Followup: changes to sysprefs.sql and atomicupdate
Run updatedatabase.pl when testing
Sponsored-by: Catalyst IT
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:43:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:43:59 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64692|0 |1
is obsolete| |
--- Comment #43 from M. Tompsett ---
Created attachment 65382
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65382&action=edit
Bug 14385: Always use mocks, not set_preference
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:43:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:43:50 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64691|0 |1
is obsolete| |
--- Comment #42 from M. Tompsett ---
Created attachment 65381
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65381&action=edit
Bug 14385: Added missing GetHiddenItems parameter change case
Without this prove t had a failure.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:44:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:44:15 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65322|0 |1
is obsolete| |
--- Comment #45 from M. Tompsett ---
Created attachment 65384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65384&action=edit
Bug 14385: Tweak t/db_dependent/Items.t to fully test changes
This will test all the if structures fully in GetHiddenItemnumbers.
prove t/db_dependent/Items.t
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:44:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:44:23 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65323|0 |1
is obsolete| |
--- Comment #46 from M. Tompsett ---
Created attachment 65385
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65385&action=edit
Bug 14385: Tweak borrower category code
$borrower->{categorycode} on a Koha::Patron is not the
same as $borrower->categorycode. Fixed error.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:44:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:44:07 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64693|0 |1
is obsolete| |
--- Comment #44 from M. Tompsett ---
Created attachment 65383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65383&action=edit
Bug 14385: Tweaks so t/db_dependent/00-strict.t passes
There was a typo botcat vs borcat and borrowernumber was never
defined. Grabbing from userenv, like other code does.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:44:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:44:38 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65324|0 |1
is obsolete| |
--- Comment #47 from M. Tompsett ---
Created attachment 65386
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65386&action=edit
Bug 14385: Search was returning URLS for wrong interface
There was one search context place wrong. Changed it to $is_opac
as the logic for setting $is_opac was modified correctly.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:44:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:44:46 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65325|0 |1
is obsolete| |
--- Comment #48 from M. Tompsett ---
Created attachment 65387
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65387&action=edit
Bug 14385: Corrected issues with category code.
When a user isn't logged in, $borrower is undef and causes error
when determining category code. Added conditional check.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:44:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:44:53 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65376|0 |1
is obsolete| |
--- Comment #49 from M. Tompsett ---
Created attachment 65388
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65388&action=edit
Bug 14385: Properly trigger all changes in C4/Search.pm
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:45:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:45:04 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65377|0 |1
is obsolete| |
--- Comment #50 from M. Tompsett ---
Created attachment 65389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65389&action=edit
Bug 14385: Fix QA Test tool failures
C4/Search.pm had some tabs.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 03:50:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 01:50:09 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--- Comment #51 from M. Tompsett ---
Follow the test plan in comment #32 and add a prove t/db_dependent/Search.t to
complete it. :)
Run QA Test tools, and all should be good.
Read the code, make sure all the searchResults() and GetHiddenItemnumbers()
calls were tweaked with the new parameters.
Thanks to Aleisha Amohia for dealing with the searchResult() issues that I had
failed to handle in my previous attempt on bug 10589, which will now become
dependent on this patch, as I seek to add PatronEveryBranch (which this is),
vs. PatronSingleBranch (which will be added).
I have signed off all the code (including Catalyst's), and so if anyone else
could sign off all the code, I would consider this signed off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:19:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:19:19 +0000
Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if
multiple accounts have the same mail address
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711
--- Comment #28 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.10.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:25:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:25:28 +0000
Subject: [Koha-bugs] [Bug 18982] selenium tests needs too many prerequisites
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #14 from Katrin Fischer ---
Hm, I installed the module, but still seeing:
ok 1 # skip Selenium::Remote::Driver is needed for selenium tests
These patches have been pushed to 16.11.x and will be in 16.11.10.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:26:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:26:57 +0000
Subject: [Koha-bugs] [Bug 18918] Exporting bibs in CSV when you have no CSV
profiles created causes error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18918
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.10.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:29:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:29:02 +0000
Subject: [Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #12 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.10.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:31:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:31:06 +0000
Subject: [Koha-bugs] [Bug 18832] Missing space between icon and label in
button 'Patron lists'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18832
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #8 from Katrin Fischer ---
Patch adapted for 16.11.x (buttons are different)
This patch has been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:31:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:31:36 +0000
Subject: [Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if
multiple accounts have the same mail address
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711
--- Comment #29 from Katrin Fischer ---
Sorry, 16.11.11!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:32:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:32:07 +0000
Subject: [Koha-bugs] [Bug 18982] selenium tests needs too many prerequisites
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982
--- Comment #15 from Katrin Fischer ---
Sorry, 16.11.11!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:35:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:35:59 +0000
Subject: [Koha-bugs] [Bug 18918] Exporting bibs in CSV when you have no CSV
profiles created causes error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18918
--- Comment #7 from Katrin Fischer ---
Sorry, 16.11.11!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:36:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:36:22 +0000
Subject: [Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839
--- Comment #13 from Katrin Fischer ---
Sorry, 16.11.11!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:39:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:39:45 +0000
Subject: [Koha-bugs] [Bug 18976] Fix t/db_dependent/Auth.t cleanup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
CC| |katrin.fischer at bsz-bw.de
--- Comment #9 from Katrin Fischer ---
Patches apply, but don't work on 16.11.x:
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl
t/db_dependent/Search/History.t
1..26
Undefined subroutine &t::lib::Mocks::mock_preference called at
t/db_dependent/Search/History.t line 19.
# Looks like your test exited with 255 before it could output anything.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:41:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:41:12 +0000
Subject: [Koha-bugs] [Bug 18977] Rollback branch in
t/db_dependent/SIP/Message.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18977
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
CC| |katrin.fischer at bsz-bw.de
--- Comment #6 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:42:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:42:38 +0000
Subject: [Koha-bugs] [Bug 18965] branch transfer limits pagination save bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18965
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #9 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:44:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:44:02 +0000
Subject: [Koha-bugs] [Bug 18605] Remove TRUNCATE from C4/HoldsQueue.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18605
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:52:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:52:09 +0000
Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #18 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:52:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:52:47 +0000
Subject: [Koha-bugs] [Bug 19000] about page - Typo in closing p tag
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19000
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #4 from Katrin Fischer ---
This patch has been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:53:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:53:47 +0000
Subject: [Koha-bugs] [Bug 18987] When browsing for a patron by last name the
page processes indefinitely
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18987
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Resolution|--- |FIXED
Status|Pushed to Stable |RESOLVED
--- Comment #14 from Katrin Fischer ---
Dependency and bug are not in 16.11.x.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:55:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:55:11 +0000
Subject: [Koha-bugs] [Bug 18991] Fix cleanup in t/db_dependent/Log.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18991
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #7 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 07:56:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 05:56:42 +0000
Subject: [Koha-bugs] [Bug 18367] Fix untranslatable string from Bug 18264
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18367
--- Comment #12 from Katrin Fischer ---
These patches have been pushed to 16.11.x and will be in 16.11.11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:11:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 06:11:14 +0000
Subject: [Koha-bugs] [Bug 7443] Change the mysql commands in the INSTALL.*
files
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7443
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--- Comment #1 from Magnus Enger ---
Bug 17626 removed the INSTALL.* files, so this bug is no longer relevant.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:11:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 06:11:44 +0000
Subject: [Koha-bugs] [Bug 14809] INSTALL.debian needs to be updated for
wheezy and jessie
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14809
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |magnus at libriotech.no
Status|NEW |RESOLVED
Resolution|--- |INVALID
--- Comment #2 from Magnus Enger ---
Bug 17626 removed the INSTALL.* files, so this bug is no longer relevant.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:13:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 06:13:58 +0000
Subject: [Koha-bugs] [Bug 9400] On a multi-arch debian system,
parts of the INSTALL.debian fail
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9400
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |magnus at libriotech.no
--- Comment #2 from Magnus Enger ---
Bug 17626 removed the INSTALL.* files, so the part of this bug that relates to
INSTALL.debian is no longer relevant.
debian.packages might still need to be fixed, though?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:17:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 06:17:52 +0000
Subject: [Koha-bugs] [Bug 11830] Document disk space requirements for git
install on Ubuntu
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11830
Magnus Enger changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |INVALID
Status|In Discussion |RESOLVED
CC| |magnus at libriotech.no
--- Comment #13 from Magnus Enger ---
Bug 17626 removed the INSTALL.* files, so this bug is no longer relevant.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 10:07:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 08:07:21 +0000
Subject: [Koha-bugs] [Bug 18929] Merging records mandate 003 and 040 fields
though in framework its not mandatory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18929
Indranil Das Gupta changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |indradg at l2c2.co.in
Resolution|--- |WORKSFORME
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:20:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 11:20:18 +0000
Subject: [Koha-bugs] [Bug 18982] selenium tests needs too many prerequisites
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18982
--- Comment #16 from Jonathan Druart ---
(In reply to Katrin Fischer from comment #14)
> Hm, I installed the module, but still seeing:
> ok 1 # skip Selenium::Remote::Driver is needed for selenium tests
What returns `pmversion Selenium::Remote::Driver`?
You could also try to remove the eval in the SKIP block to know what is the
error.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:27:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 11:27:35 +0000
Subject: [Koha-bugs] [Bug 19014] New: Limit auto-renewal notice to item due
immediately. Template Toolkit change ?
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014
Bug ID: 19014
Summary: Limit auto-renewal notice to item due immediately.
Template Toolkit change?
Change sponsored?: ---
Product: Koha
Version: 17.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs at lists.koha-community.org
Reporter: r.delahunty at arts.ac.uk
QA Contact: testopia at bugs.koha-community.org
Current functionality in 17.05:
All copies of an item with auto-renewal enabled, reserved at the title level.
Due dates of copies on loan include today, and various dates into the future,
some many weeks ahead.
When the auto-renewal job runs, Koha is sending an AUTO_RENEWAL email to ALL
the users warning them ALL of renewal failure, using the [% ELSIF
checkout.auto_renew_error == 'on_reserve' %]
Desired functionality in 17.05:
When the auto-renewal job runs, Koha should only send an AUTO_RENEWAL email to
the user (or possibly users) whose copy is due back today, on the day the
auto-renewal job runs. Other people who have copies on loan but which are not
yet due back yet should not be contacted by the AUTO_RENEWAL email. Users
contacted in this way are being very puzzled and confused.
Could this be achieved by an edit to the condition in the template toolkit? So
rather this:
[% ELSIF checkout.auto_renew_error == 'on_reserve' %]
This item has been reserved by another reader.
? we have something like this:
[% ELSIF checkout.auto_renew_error == 'on_reserve' && checkout.date_due
%==today %]
This item has been reserved by another reader.
Would that work? Is a second condition permissible? How should it be worded?
Ray Delahunty
University of the Arts London
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:32:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 11:32:06 +0000
Subject: [Koha-bugs] [Bug 18976] Fix t/db_dependent/Auth.t cleanup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18976
--- Comment #10 from Jonathan Druart ---
Created attachment 65390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65390&action=edit
Bug 18976: [16.11] Add missing use statement
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 14:02:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 12:02:03 +0000
Subject: [Koha-bugs] [Bug 18949] OPAC MARC details holdings table is not
styled with
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65087|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 65391
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65391&action=edit
[SIGNED-OFF] Bug 18949: Adding thead tags to OPAC MARC details holdings table
So that it can be styled alongside other tables in the OPAC.
To test:
1) Log into staff side
2) Find OPACUserCSS syspref and add the following CSS:
th,
.table-bordered>thead>tr:first-child>th {
color: red;
}
3) Log into the OPAC
4) Go to your fines, your search history, your reading history etc -
notice all of these table's headings are styled with red text
5) Go to the detail page of an item, then the MARC view.
Notice this table's headings are now styled with red text
6) Apply patch and refresh page
7) Your holdings table should now have red headings.
(You can delete the CSS from OPACUserCSS if you'd like.)
Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 14:02:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 12:02:16 +0000
Subject: [Koha-bugs] [Bug 18949] OPAC MARC details holdings table is not
styled with
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 14:28:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 12:28:56 +0000
Subject: [Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify
search mapping modifications
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897
--- Comment #3 from Lari Taskula ---
Created attachment 65392
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65392&action=edit
Bug 17897 - (follow-up) Cleanup after tests
Adds rollback to test data in t/db_dependent/Koha/SearchEngine/ElasticSearch.t
To test:
1. prove t/db_dependent/Koha/SearchEngine/ElasticSearch.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 14:35:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 12:35:24 +0000
Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused
checkin for data corruption
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996
--- Comment #15 from Marcel de Rooy ---
Created attachment 65393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65393&action=edit
Bug 18996: Resolve an uninitialized warning from ILS/Item.pm
>From the syslog call on line 107/108. The field $item->{title} has not
been initialized. When catching the warns in a test script with Test::Warn,
I got:
Use of uninitialized value $args[1] in sprintf at
/usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423.
This simply resolves the warning. We might have a closer look to this title
field on another report though.
Test plan:
Run Message.t from the next patch without this fix. It will fail since the
additional warning makes warnings_like return false.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 14:35:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 12:35:29 +0000
Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused
checkin for data corruption
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996
--- Comment #16 from Marcel de Rooy ---
Created attachment 65394
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65394&action=edit
Bug 18996: Add checkin subtest in SIP/Message.t
Variable $branch was not used.
Promoted some global vars to our.
Shared the branchcode between all three subtests now.
The third subtest contains all six cases mentioned in the first patch.
Test plan:
Run t/db_dependent/SIP/Message.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 14:46:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 12:46:12 +0000
Subject: [Koha-bugs] [Bug 17672] Items table should have a damaged_on column
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672
--- Comment #3 from Owen Leonard ---
I haven't seen how withdrawn_on and itemlost_on behave, but I would think it
could be useful to store the date the status was changed no matter what it
changed to. Why not store the date if you're setting it to 0?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 14:53:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 12:53:14 +0000
Subject: [Koha-bugs] [Bug 19015] New: Searches fail with error Fielddata is
disabled on text fields by default for elastic search 5.3 and 5.4
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19015
Bug ID: 19015
Summary: Searches fail with error Fielddata is disabled on text
fields by default for elastic search 5.3 and 5.4
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: Linux
Status: NEW
Severity: normal
Priority: P5 - low
Component: Searching
Assignee: koha-bugs at lists.koha-community.org
Reporter: david.holoshka at ub.lu.se
QA Contact: testopia at bugs.koha-community.org
There is a work around but it would save space and trouble if this was fixed.
[illegal_argument_exception] Fielddata is disabled on text fields by default.
Set fielddata=true on [Heading.phrase] in order to load fielddata in memory by
uninverting the inverted index. Note that this can however use significant
memory. Alternatively use a keyword field instead., called from sub
Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/usr/local/share/perl/5.20.2/Catmandu/Store/ElasticSearch/Bag.pm line 168.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:03:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:03:17 +0000
Subject: [Koha-bugs] [Bug 19016] New: Add a script to fix corrupted data
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016
Bug ID: 19016
Summary: Add a script to fix corrupted data
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Command-line Utilities
Assignee: koha-bugs at lists.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
CC: robin at catalyst.net.nz
Depends on: 18966
We must provide a fix to deal with corrupted data.
For more information, see bug 18966 and
https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966
[Bug 18966] Move of checkouts - Deal with duplicate IDs at DBMS level
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:03:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:03:17 +0000
Subject: [Koha-bugs] [Bug 18966] Move of checkouts - Deal with duplicate IDs
at DBMS level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19016
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016
[Bug 19016] Add a script to fix corrupted data
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:06:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:06:48 +0000
Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always
empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:06:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:06:51 +0000
Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always
empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64682|0 |1
is obsolete| |
--- Comment #15 from Owen Leonard ---
Created attachment 65395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65395&action=edit
[SIGNED-OFF] Bug 16485: collection column in Item search is always empty
This patch fills the column 'Collection' in item search from the item values.
To test:
- Go to item search
- Reproduce issue from initial comment
- Apply patch
- Verify that the column 'Collection' is filled
Still to do, but outside of my datatable skills:
Filter by drop down in the column header does a substring search.
Example: Filter for 'Fiction" returns both 'Fiction' and 'Non-fiction' items.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:08:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:08:04 +0000
Subject: [Koha-bugs] [Bug 19017] New: Script that checks and transforms SMS
alert numbers
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017
Bug ID: 19017
Summary: Script that checks and transforms SMS alert numbers
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Notices
Assignee: koha-bugs at lists.koha-community.org
Reporter: alex.arnaud at biblibre.com
QA Contact: testopia at bugs.koha-community.org
Here is a proposal for a script that would check SMS alert number field. Our
need is to have number that are correctly formatted as expetced by the SMS
provider
(ie: 0033678240967 or +33678240967 and not 0678240967).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:08:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:08:15 +0000
Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert
numbers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017
Alex Arnaud changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:08:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:08:47 +0000
Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert
numbers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017
Alex Arnaud changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:09:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:09:09 +0000
Subject: [Koha-bugs] [Bug 16485] Collection column in Item search is always
empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16485
--- Comment #16 from Owen Leonard ---
This solution works well for me as a MARC21 user. I agree that a separate bug
is the right place for the matching issue.
Since this changes the way the search works for UNIMARC users I think it would
be good to get an additional signoff from someone who can test with UNIMARC
data.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:10:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:10:45 +0000
Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert
numbers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017
--- Comment #1 from Alex Arnaud ---
Created attachment 65396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65396&action=edit
Checks and transform SMS alert number
This patch adds a new package C4::SMSNumber::Fr (new ones could be added
for other countries)
and a scrip (misc/check_smsalertnumber.pl):
check_smsalertnumber.pl -a|--area fr [-h|--help] [-c|--confirm]
[-o|--country-option] [-l|--liste-mode]
Test plan #1:
- Create or modify patrons and add some SMS alert numbers like:
06 98 35 72 28, 0656871221, +336-01-55-83-11, 0033 6.23.54.54.00,
0126698376
- launch perl misc/check_smsalertnumber.pl -a Fr
- Transformation proposal should be like:
- 06 98 35 72 28 => 0698357228,
- 0656871221 => no proposal (number Ok),
- +336-01-55-83-11 => 0601558311,
- 0033 6.23.54.54.00 => 0623545400,
- 0126698376 => Can't find a replacement
Test plan #2:
- with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
-o +33
- Transformation proposal should be like:
- 06 98 35 72 28 => +33698357228,
- 0656871221 => +33656871221,
- +336-01-55-83-11 => +33601558311,
- 0033 6.23.54.54.00 => +33623545400,
- 0126698376 => Can't find a replacement
Test plan #3:
- with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
-o 0033
- Transformation proposal should be like:
- 06 98 35 72 28 => 0033698357228,
- 0656871221 => 0033656871221,
- +336-01-55-83-11 => 0033601558311,
- 0033 6.23.54.54.00 => 0033623545400,
- 0126698376 => Can't find a replacement
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:11:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:11:01 +0000
Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert
numbers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017
Alex Arnaud changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:18:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:18:05 +0000
Subject: [Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert
numbers
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017
Alex Arnaud changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alex.arnaud at biblibre.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:37:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:37:29 +0000
Subject: [Koha-bugs] [Bug 19018] New: Can we make XSLT_Handler a little bit
less verbose ?
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19018
Bug ID: 19018
Summary: Can we make XSLT_Handler a little bit less verbose ?
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
As reported on bug 17807, XSLT_Handler reports that a XSLT file is not found
for each record it wants to process (running oai.pl).
Additionally, we also have:
Can't locate object method "nodeType" via package "
[ And a complete MARC record dump. ]
" (perhaps you forgot to load "
[ Same MARC record dump again ]
"?) at /usr/share/perl5/HTTP/OAI/Encapsulation.pm line 68.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:40:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:40:18 +0000
Subject: [Koha-bugs] [Bug 19018] Can we make XSLT_Handler a little bit less
verbose ?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19018
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |17807
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807
[Bug 17807] Use XSLT_Handler in oai.pl
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:40:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:40:18 +0000
Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19018
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19018
[Bug 19018] Can we make XSLT_Handler a little bit less verbose ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:41:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:41:19 +0000
Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807
--- Comment #17 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #16)
> Everything seems to work fine here, however, errors are really noisy if the
> file is not found - this shouldn't be an issue really since file isn't
> configurable, but should it be a little quieter? Waiting for answer before
> PQA
File should be there obviously, but you are right. We could reduce the noise a
bit. Opened a new report for that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:47:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:47:30 +0000
Subject: [Koha-bugs] [Bug 19019] New: Patron clubs feature needs
documentation
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19019
Bug ID: 19019
Summary: Patron clubs feature needs documentation
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Documentation
Assignee: koha-bugs at lists.koha-community.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 12461
This bug is a good argument for a "no docs no pushie" rule. We should have
documentation in place for any feature in a stable release.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
[Bug 12461] Add patron clubs feature
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 15:47:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 13:47:30 +0000
Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19019
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19019
[Bug 19019] Patron clubs feature needs documentation
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:00:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:00:52 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
rental charge
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:00:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:00:55 +0000
Subject: [Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a
rental charge
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #62535|0 |1
is obsolete| |
--- Comment #24 from Owen Leonard ---
Created attachment 65397
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65397&action=edit
[SIGNED-OFF] Bug 13796: OPAC: Display rental charge for renewing
This patch displays the rental fee that will be applied for
renewing (near "Renew" link on patron's summary page)
To test:
- Apply patch
- Enable system preference 'OpacRenewalAllowed'
- Verify that you have item types with and without rental fee
for testing
- Issue items with an without rental fee to a patron
- In OPAC, display patron's summary page
- Verify in table 'Checked out', items with rental charge display an
information as
appropriate (near the link 'Renew')
Patch rewritten because of merge issues with previous patches. 2017-04-21 mv
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:12:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:12:02 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
Status|Signed Off |Failed QA
--- Comment #20 from Marcel de Rooy ---
Looks good to me, but I am wondering if we really need an additional module to
test the behavior of BorrowerRenewalPeriodBase. Does this new dependency really
bring us great benefits here?
Time::Fake is Debian packaged though.
It seems to me that testing the "now" variant could be done too with current
time. The other variant "dateexpiry" allows you to set dates so that you can
see that the end_of_month limit really works.
And if we should use it anyway, I would prefer to see the offset call just
before the code it should actually work on and an additional Time::Fake->reset
after that block.
Changing status to reflect need for feedback.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:18:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:18:15 +0000
Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused
checkin for data corruption
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--- Comment #17 from Marcel de Rooy ---
Raising Severity: SIP is fooling us.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:20:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:20:19 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #1 from Marcel de Rooy ---
Would be great imo if this fix could be used in cleanup_database somehow too.
Put the core fix in some module?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:31:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:31:54 +0000
Subject: [Koha-bugs] [Bug 18779] Translatability: Get rid of exposed tt
directives in authorities-search-results.inc (OPAC)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:31:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:31:57 +0000
Subject: [Koha-bugs] [Bug 18779] Translatability: Get rid of exposed tt
directives in authorities-search-results.inc (OPAC)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18779
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64190|0 |1
is obsolete| |
--- Comment #5 from Owen Leonard ---
Created attachment 65398
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65398&action=edit
[SIGNED-OFF] Bug 18779: Translatability: Get rid of exposed tt directives in
authorities-search-results.inc (OPAC)
The file opac-tmpl/bootstrap/en/includes/authorities-search-results.inc
exposes template directives to translation where translators should not
be confronted with.
Example:
"[%% PROCESS showreference heading=seeals.heading linkType='seealso' "
"type=seeals.type authid=seeals.authid %%] "
To test:
- Apply patch
- Verify that Authority search in OPAC works as before
- Bonus test: create a new language 'aa-AA', verify that line above
does not show up in aa-AA-opac-bootstrap.po
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:42:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:42:22 +0000
Subject: [Koha-bugs] [Bug 18652] Translatability: Get rid of tt directive in
translation for uncertainprice.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652
--- Comment #10 from Owen Leonard ---
Created attachment 65399
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65399&action=edit
[SIGNED-OFF] Bug 18652: Get rid of tt directive in translation for
uncertainprice.tt
Translation tool shows toe following for ncertainprice.tt
0; url=[% scriptname %]?booksellerid=[% booksellerid %]
This patch fixes it.
To test:
- Apply patch
- Verify that code change makes sense
- Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor]
works as before
- Additional test (for a langunage 'aa-AA')
perl translate create aa-AA
verify that line 41 no longer appears in aa-AA-staff-prog.po
Amended to switch from BLOCK to a template variable, see comment #5
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:42:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:42:47 +0000
Subject: [Koha-bugs] [Bug 18652] Translatability: Get rid of tt directive in
translation for uncertainprice.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:43:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:43:36 +0000
Subject: [Koha-bugs] [Bug 18652] Translatability: Get rid of tt directive in
translation for uncertainprice.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64151|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:45:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:45:48 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #21 from Jonathan Druart ---
Created attachment 65400
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65400&action=edit
Bug 17699: Reset time simulation
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:47:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:47:50 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #22 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #20)
> Looks good to me, but I am wondering if we really need an additional module
> to test the behavior of BorrowerRenewalPeriodBase. Does this new dependency
> really bring us great benefits here?
> Time::Fake is Debian packaged though.
It's already a Koha dependency.
> It seems to me that testing the "now" variant could be done too with current
> time. The other variant "dateexpiry" allows you to set dates so that you can
> see that the end_of_month limit really works.
I think it is less error prone to use Time::Fake
> And if we should use it anyway, I would prefer to see the offset call just
> before the code it should actually work on and an additional
> Time::Fake->reset after that block.
I added the ->reset call, but I do not understand your other remark. Where do
you want it to be moved? It sounds better to me to have it visible at the
beginning of the loop.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:57:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:57:52 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #23 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #22)
> It's already a Koha dependency.
So it is indeed. Wrong assumption..
t/Circulation/AgeRestrictionMarkers.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:59:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 14:59:55 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #24 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #22)
> I added the ->reset call, but I do not understand your other remark. Where
> do you want it to be moved? It sounds better to me to have it visible at the
> beginning of the loop.
Do you need it in the whole loop? I would say that you only need it somewhere
deeper when you calculate the new expiry date for 'now'. But adding the reset
is good enough, I suppose.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:00:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:00:10 +0000
Subject: [Koha-bugs] [Bug 18660] Translatability: Get rid of template
directives [ %% in translation for patroncards-errors.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #6 from Owen Leonard ---
I still see some problematic areas:
#. %1$s: IF ( element_id )
#. %2$s: card_element
#. %3$s: element_id
#. %4$s: END
#: intranet-tmpl/prog/en/includes/patroncards-errors.inc:30
#, c-format
msgid "An unsupported operation was attempted%s on %s %s%s. "
msgstr ""
I notice some lines where there is a placeholder which doesn't belong. I think
some simple whitespace problems?
#. %1$s: END
#: intranet-tmpl/prog/en/includes/patroncards-errors.inc:28
#, c-format
msgid "The database returned an error while attempting a delete operation%s. "
msgstr ""
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:00:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:00:13 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:02:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:02:17 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #25 from Marcel de Rooy ---
QA: Finish this one tomorrow
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:43:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:43:55 +0000
Subject: [Koha-bugs] [Bug 19020] New: No "hold available" notification when
an item on hold is transferred
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19020
Bug ID: 19020
Summary: No "hold available" notification when an item on hold
is transferred
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: sophie.meynieux at biblibre.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
When an item is returned, if it comes from a transfer for a reserve, reserve
status is changed to 'W', but not notification is sent
The function C4::Circulation::AddReturn should use ModReserveAffect() instead
of C4::Reserves::ModReserveStatus($item->{'itemnumber'}, 'W') in the part
dedicated to transfer
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:44:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:44:29 +0000
Subject: [Koha-bugs] [Bug 19020] No "hold available" notification when an
item on hold is transferred
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19020
Sophie MEYNIEUX changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P4
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:46:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:46:06 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
Category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589
--- Comment #42 from M. Tompsett ---
(In reply to M. Tompsett from comment #39)
> Oops. Missed C4::Search::searchResults. That comment is right about it being
> messy.
On a positive note, that is dealt with in bug 14385.
This further patch is simpler as a result. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:46:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:46:47 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
Category
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30806|0 |1
is obsolete| |
--- Comment #43 from M. Tompsett ---
Comment on attachment 30806
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30806
[SIGNED-OFF] Bug 10589 - Override OpacHiddenItems based on Patron Category
Going to rework based on bug 14385.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 17:59:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 15:59:18 +0000
Subject: [Koha-bugs] [Bug 18966] Move of checkouts - Deal with duplicate IDs
at DBMS level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966
--- Comment #32 from Jonathan Druart ---
Looks like the "update the fines" part should be removed (it should not hurt,
no side-effects expected);
2177 # Update the fines
2178 $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id =
?|, undef, $old_checkout->issue_id, $issue->issue_id);
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 18:02:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 16:02:27 +0000
Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused
checkin for data corruption
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996
--- Comment #18 from Colin Campbell ---
(In reply to Marcel de Rooy from comment #15)
> Created attachment 65393 [details] [review]
> Bug 18996: Resolve an uninitialized warning from ILS/Item.pm
>
> From the syslog call on line 107/108. The field $item->{title} has not
> been initialized. When catching the warns in a test script with Test::Warn,
> I got:
> Use of uninitialized value $args[1] in sprintf at
> /usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423.
>
> This simply resolves the warning. We might have a closer look to this title
> field on another report though.
>
> Test plan:
> Run Message.t from the next patch without this fix. It will fail since the
> additional warning makes warnings_like return false.
>
> Signed-off-by: Marcel de Rooy
(In reply to Marcel de Rooy from comment #16)
> Created attachment 65394 [details] [review]
> Bug 18996: Add checkin subtest in SIP/Message.t
>
> Variable $branch was not used.
> Promoted some global vars to our.
> Shared the branchcode between all three subtests now.
> The third subtest contains all six cases mentioned in the first patch.
>
> Test plan:
> Run t/db_dependent/SIP/Message.t
>
> Signed-off-by: Marcel de Rooy
unnecessarily making lexical variables package variables is potentially
introducing bugs. If you want to do it, it should not really be slipped in as
part of another patch, but have its own rationale
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 18:42:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 16:42:00 +0000
Subject: [Koha-bugs] [Bug 18978] Amazon returns 1x1 pixel image on shelf
browse, preventing the "no cover image" image from showing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18978
--- Comment #1 from Owen Leonard ---
Amazon always returns a 1x1 pixel if they don't have a cover image. That's why
we have some JavaScript which is supposed to check for them:
/koha-tmpl/opac-tmpl/bootstrap/js/amazonimages.js
This technique originated here:
http://archive.oreilly.com/pub/a/javascript/2003/10/21/amazonhacks.html
It sounds like the problem is that either the script isn't running correctly in
the shelf browser or the shelf browser is using markup which prevents the
images from being recognized by the script.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:05:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:05:15 +0000
Subject: [Koha-bugs] [Bug 18985] SQL reports 'Last edit' and 'Last run'
columns sort alphabetically, not chronologically
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18985
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
|ity.org |
Severity|enhancement |normal
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:09:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:09:07 +0000
Subject: [Koha-bugs] [Bug 16759] Make opac holdings table configurable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|make opac holdings table |Make opac holdings table
|configurable |configurable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:14:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:14:09 +0000
Subject: [Koha-bugs] [Bug 16759] Make opac holdings table configurable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:14:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:14:12 +0000
Subject: [Koha-bugs] [Bug 16759] Make opac holdings table configurable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
--- Comment #1 from Tom?s Cohen Arazi ---
Created attachment 65401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65401&action=edit
Bug 16759: Make OPAC holdings table configurable
This patch makes the holdings table in the OPAC biblio detail page
configurable using the Columns configuration tools.
This patch:
- Moves the holdingst table from plain DataTable to KohaTable
- Creates a sample yml colvis configuration for this table
containing all the currently available columns
To test:
- Visit some record's detail page in the OPAC
- Apply this patch
- Reload
=> SUCCESS: The page shows the same information
- On the staff interface, go to:
Home > Administration > Columns settings
=> SUCCESS: There's a new OPAC section containing the configuration for
holdingst.
- Choose to hide some fields (both currently displayed and currently hidden).
- Reload the OPAC detail page
=> SUCCESS:
- Required fields are hidden
- It doesn't explode because of trying to hide stuff that is not there to
start with
- Sign off :-D
Sponsored-by: DOVER
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:19:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:19:23 +0000
Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items
hidden by OpacHiddenItems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
--- Comment #3 from Owen Leonard ---
It would be great if this could be done per itemtype. That would allow you to
easily define an electronic record itemtype without having to create dummy
items.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:20:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:20:59 +0000
Subject: [Koha-bugs] [Bug 16759] Make opac holdings table configurable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
--- Comment #2 from Tom?s Cohen Arazi ---
I've attached this preliminary patch, that makes the holdings table in the OPAC
detail page easily configurable using the Columns settings configuration page.
YAY!
A few remarks for testers and other devs taking a look:
- The original request includes 'shelving location' column. The shelving
location is already displayed below the home/holding library. I'm looking
forward for opinions on this.
- Some of the currently used sysprefs controlling what's displayed could be
removed in favour of using this column configuration. For example
ShowCourseReservesHeader, OPACShowBarcode and OpacLocationBranchToDisplay. I
can implement that if required by QA. It would be a simple upgrade step setting
the right options based on the sysprefs.
- No-js, should we completely remove the columns at template level so non-js
browsers can render it properly?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:25:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:25:12 +0000
Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items
hidden by OpacHiddenItems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
--- Comment #4 from Tom?s Cohen Arazi ---
(In reply to Owen Leonard from comment #3)
> It would be great if this could be done per itemtype. That would allow you
> to easily define an electronic record itemtype without having to create
> dummy items.
I think this is already covered. The problem this bug higlights is that if all
items are marked as hidden, then the biblio is hidden.
You can safely create a biblio without items and it will be displayed
correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:25:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:25:50 +0000
Subject: [Koha-bugs] [Bug 17277] Current Location column in Holdings table
showing empty under OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |18989
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
[Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:25:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:25:50 +0000
Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items
hidden by OpacHiddenItems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |17277
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277
[Bug 17277] Current Location column in Holdings table showing empty under OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:26:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:26:10 +0000
Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items
hidden by OpacHiddenItems
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|17277 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277
[Bug 17277] Current Location column in Holdings table showing empty under OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:26:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:26:10 +0000
Subject: [Koha-bugs] [Bug 17277] Current Location column in Holdings table
showing empty under OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|18989 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
[Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:26:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:26:13 +0000
Subject: [Koha-bugs] [Bug 16759] Make opac holdings table configurable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |17277
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277
[Bug 17277] Current Location column in Holdings table showing empty under OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:26:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:26:13 +0000
Subject: [Koha-bugs] [Bug 17277] Current Location column in Holdings table
showing empty under OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17277
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |16759
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
[Bug 16759] Make opac holdings table configurable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:29:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:29:31 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016
--- Comment #2 from Jonathan Druart ---
Created attachment 65402
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65402&action=edit
Bug 19016: Add a script to fix corrupted data
This patch add two new options to the cleanup_database.pl script:
* --list-corrupted-data to list the different rows that are affected
* --fix-corrupted-data to fix and reassign an id to the corrupted rows
TO NOT USE IT IN PRODUCTION YET!
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:29:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:29:37 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016
--- Comment #3 from Jonathan Druart ---
Created attachment 65403
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65403&action=edit
Bug 19016: Update other values
Here we have a problem!
If we assign a new id to the different rows that cannot be moved
safetly, we need to modify the other tables that do not have a foreign
key (for historical or laziness reasons).
For instance:
John is borrowernumber=42 and create a suggestion
(suggestion.suggestedby=42)
Jane is borrowernumber=42 in the deletedborrowers table. She created a
suggestion (same suggestedby value).
John will get a new id and the suggestion.suggestedby will not be
replaced without this patch. But with this fix, the 2 suggestions will
be marked as suggested by him.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:31:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:31:19 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
|ity.org |ommunity.org
CC| |fridolin.somers at biblibre.co
| |m,
| |katrin.fischer at bsz-bw.de,
| |nick at bywatersolutions.com,
| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:33:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:33:55 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |ASSIGNED
--- Comment #52 from M. Tompsett ---
*sigh* found an issue. EmbedItemsInMarcBiblio.
If $opac, we should be passing borcat.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 17:42:36 +0000
Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from
Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65115|0 |1
is obsolete| |
--- Comment #93 from Tom?s Cohen Arazi ---
Created attachment 65404
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65404&action=edit
Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as
dependencies
Edit (tcohen): I've changed the version numbers to match those Mirko has
already
successfully packaged and are known to work for this patchset.
Signed-off-by: Olli-Antti Kivilahti
Signed-off-by: Josef Moravec
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:14:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 18:14:07 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
GetSoonestRenewDate should be changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |kyle at bywatersolutions.com
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #61514|0 |1
is obsolete| |
Attachment #61515|0 |1
is obsolete| |
--- Comment #14 from Kyle M Hall ---
Calls to GetSoonestRenewDate haven't been updated in opac-user.pl and
svc/checkouts at the very least.
--- Comment #15 from Jonathan Druart ---
Created attachment 65405
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65405&action=edit
Bug 16413: Change prototype of GetLatestAutoRenewDate
Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate
subroutines takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to
accept the patron, item and issue information directly to avoid
unnecessary refetches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:14:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 18:14:12 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
GetSoonestRenewDate should be changed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413
--- Comment #16 from Jonathan Druart ---
Created attachment 65406
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65406&action=edit
Bug 16413: Change prototype of GetSoonestRenewDate
Same change as previous patch for the GetSoonestRenewDate subroutine.
This is not finished, 2 other calls could not be updated (performance
issue). They may be later, when objects will be used in svc/checkouts
and opac-user.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:11:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 20:11:31 +0000
Subject: [Koha-bugs] [Bug 19019] Patron clubs feature needs documentation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19019
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Keywords| |Manual
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:26:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 20:26:05 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:49:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 20:49:14 +0000
Subject: [Koha-bugs] [Bug 18966] Move of checkouts - Deal with duplicate IDs
at DBMS level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966
--- Comment #33 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #32)
> Looks like the "update the fines" part should be removed (it should not
> hurt, no side-effects expected);
>
> 2177 # Update the fines
> 2178 $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id
> = ?|, undef, $old_checkout->issue_id, $issue->issue_id);
hm?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 00:14:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 22:14:12 +0000
Subject: [Koha-bugs] [Bug 18046] Problem with redirect on logout with CAS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046
Chris Cormack changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |chris at bigballofwax.co.nz
--- Comment #3 from Chris Cormack ---
Ah yes, because opac-main.pl looks for the existence of the logout param it
will just log them out again and again and again.
So your fix is the right fix.
I will attach a patch here soon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 00:39:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 22:39:32 +0000
Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives
starting with [ %% in translation for itemsearch.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64723|0 |1
is obsolete| |
--- Comment #8 from Alex Buckley ---
Created attachment 65407
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65407&action=edit
Bug 18654 - Translatability: Get rid of tt directives starting with [%% in
translation for itemsearch.tt
This patch removes entries like the following in translations of itemsearch.tt:
"[%% INCLUDE form_field_select name=\"homebranch\" options = branches "
"empty_option = \"All libraries\" %%] [%% INCLUDE form_field_select name="
"\"holdingbranch\" options = branches empty_option = \"All libraries\" %%] %s "
"[%% INCLUDE form_field_select name=\"location\" options = locations "
"empty_option = \"All locations\" %%] %s "
New patch on top of Bug 18633 that resolves parts of initial comment.
To test:
- Verify that in itemsearch.tt no tt directives are splitted by new lines
(search for [% INCLUDE )
- Verify that itemsearch.tt works as before
Followed test plan and verified that tt directives are not split by new
lines, the changes to the fieldset tags in comment 3 have been removed
and itemtype.tt still works correctly as before
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 00:39:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 22:39:27 +0000
Subject: [Koha-bugs] [Bug 18654] Translatability: Get rid of tt directives
starting with [ %% in translation for itemsearch.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18654
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:16:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 23:16:20 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #53 from M. Tompsett ---
Created attachment 65408
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65408&action=edit
Bug 14385: Add some commenting to make sense of logic
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:16:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 23:16:26 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #54 from M. Tompsett ---
Created attachment 65409
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65409&action=edit
Bug 14385: Refactor EmbedItemsInMarcBiblio parameters to hashref
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:16:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 23:16:32 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #55 from M. Tompsett ---
Created attachment 65410
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65410&action=edit
Bug 14385: Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
prove t/db_dependent/Items.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:16:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 23:16:39 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #56 from M. Tompsett ---
Created attachment 65411
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65411&action=edit
Bug 14385: Add missing test to trigger Koha/BiblioUtils/Iterator change
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:31:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Aug 2017 23:31:17 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419
Agnes Rivers-Moore changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arm at hanover.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 02:42:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 00:42:25 +0000
Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying
exempt borrower categories
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385
--- Comment #57 from M. Tompsett ---
The problem with this, as it stands is the GetMarcBiblio call does not receive
the patron category code, so it can't pass it to EmbedItemsInMarcBiblio which
can't then pass it to GetHiddenItemnumbers. And while I'm tempted to hack in a
user category code and branch lookup, that would defeat the niceness of the
refactored parameter passing thus far.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 07:09:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 05:09:11 +0000
Subject: [Koha-bugs] [Bug 18754] Translatability: Get rid of exposed tt
directives in opac-detail.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64178|0 |1
is obsolete| |
--- Comment #4 from Alex Buckley ---
Created attachment 65412
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65412&action=edit
Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt
The file opac-detail.tt exposes a lot of template directives to translation
where translators should not be confronted with.
Some examples from po file are:
$[% SUBFIELD.code %] [% SUBFIELD.value %]
%s [%% INCLUDE \"openlibrary-readapi.inc\" bib = { normalized_isbn => "
"normalized_isbn, lccn => lccn, normalized_oclc => normalized_oclc } %%]
See: [% IF ( nextTitle ) %][% nextTitle |html %][% ELSE %]next biblio[% END "
"%]
To test:
- Apply patch
- Do a search in OPAC that has more than 1 results
- Go to the detail page of one of the items found
- Verify that the details display as before and that you can
browse the results with Previous and Next
- In staff client, change OPACXSLTDetailsDisplay from 'default' to
empty for "no xslt" and repeat steps above
- In staff client, set HTML5MediaEnabled to 'OPAC' or 'OPAC and staff client'
- Verify that media catalogued in field 856 still work
- Create a new translation for a 'language' aa-AA (perl translate create aa-AA)
- Verify that template directives ar no longer exposed in
aa-AA-opac-bootstrap.po
Followed test plan which works as intended
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 07:09:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 05:09:07 +0000
Subject: [Koha-bugs] [Bug 18754] Translatability: Get rid of exposed tt
directives in opac-detail.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:34:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:34:32 +0000
Subject: [Koha-bugs] [Bug 19021] New: inventory column not sortable
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Bug ID: 19021
Summary: inventory column not sortable
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: fridolin.somers at biblibre.com
QA Contact: testopia at bugs.koha-community.org
In inventory result page, items are shown in a JS DataTable.
A column is not sortable for no reason.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:34:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:34:39 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column not sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
|ity.org |m
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:38:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:38:37 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column not sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:38:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:38:40 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column not sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
--- Comment #1 from Fridolin SOMERS ---
Created attachment 65413
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65413&action=edit
Bug 19021 - inventory column not sortable
In inventory result page, items are shown in a JS DataTable.
A column is not sortable for no reason.
This patch removes code that sets column not sortable, maybe some changes in
table made it obsolete.
Test plan :
- perform inventory
- look at result table
=> Without patch second column is not sortable
=> With patch all columns are sortable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:41:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:41:58 +0000
Subject: [Koha-bugs] [Bug 19022] New: inventory location and author display
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
Bug ID: 19022
Summary: inventory location and author display
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: fridolin.somers at biblibre.com
QA Contact: testopia at bugs.koha-community.org
In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:51:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:51:59 +0000
Subject: [Koha-bugs] [Bug 19022] inventory location and author display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:52:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:52:02 +0000
Subject: [Koha-bugs] [Bug 19022] inventory location and author display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
--- Comment #1 from Fridolin SOMERS ---
Created attachment 65414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65414&action=edit
Bug 19022 - inventory location and author display
In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.
This patch adds for location a span with class like in catalogue detail page,
and changes author to be on same line in order to have a more compact display
for this table that may be huge.
Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:52:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:52:13 +0000
Subject: [Koha-bugs] [Bug 19022] inventory location and author display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19021
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:52:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:52:13 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column not sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19022
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 10:54:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 08:54:57 +0000
Subject: [Koha-bugs] [Bug 19022] inventory location and author display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
--- Comment #2 from Fridolin SOMERS ---
Created attachment 65415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65415&action=edit
Screenshot with patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:12:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:12:17 +0000
Subject: [Koha-bugs] [Bug 19023] New: inventory tool performance
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Bug ID: 19023
Summary: inventory tool performance
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: fridolin.somers at biblibre.com
QA Contact: testopia at bugs.koha-community.org
Inventory tool performance seems to be worst since 16.11.
I think it is because of authorized values computing changed by Bug 17249.
For each subfield of each item, we try to get the authorized value description
with Koha::AuthorisedValues->search_by_marc_field.
But this method does not use cache like
Koha::AuthorisedValues->get_description_by_koha_field.
I propose to use Koha::AuthorisedValues->get_description_by_koha_field and also
to look for authorized value description only for item fields used in TT :
location, notforloan, itemlost, damaged, withdrawn.
I have experimented inventory time on 100 items from 5s to 1s.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:12:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:12:25 +0000
Subject: [Koha-bugs] [Bug 19023] inventory tool performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |17249
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249
[Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:12:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:12:25 +0000
Subject: [Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove
GetKohaAuthorisedValuesFromField
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19023
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
[Bug 19023] inventory tool performance
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:26:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:26:31 +0000
Subject: [Koha-bugs] [Bug 19023] inventory tool performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:26:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:26:33 +0000
Subject: [Koha-bugs] [Bug 19023] inventory tool performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
--- Comment #1 from Fridolin SOMERS ---
Created attachment 65416
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65416&action=edit
Bug 19023 - inventory tool performance
Inventory tool performance seems to be worst since 16.11.
I think it is because of authorized values computing changed by Bug 17249.
For each subfield of each item, we try to get the authorized value description
with Koha::AuthorisedValues->search_by_marc_field.
But this method does not use cache like
Koha::AuthorisedValues->get_description_by_koha_field.
I propose to use Koha::AuthorisedValues->get_description_by_koha_field and also
to look for authorized value description only for item fields used in TT :
location, notforloan, itemlost, damaged, withdrawn.
I have experimented inventory time on 100 items from 5s to 1s.
Test plan :
- Without patch
- Perform inventory with barcode file
- Check results and mesure execution time
- Apply patch
- Reperform inventory with same barcode file
- Check results is the same
- Compare execution time
- Run prove t/db_dependent/Items/GetItemsForInventory.t
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:27:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:27:51 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column not sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19023
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:27:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:27:51 +0000
Subject: [Koha-bugs] [Bug 19023] inventory tool performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19021
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:28:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:28:02 +0000
Subject: [Koha-bugs] [Bug 19022] inventory location and author display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19023
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:28:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:28:02 +0000
Subject: [Koha-bugs] [Bug 19023] inventory tool performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19022
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:45:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:45:17 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column not sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65413|0 |1
is obsolete| |
--- Comment #2 from Fridolin SOMERS ---
Created attachment 65417
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65417&action=edit
Bug 19021 - inventory column sorting
In inventory result page, items are shown in a JS DataTable.
For an inventory with barcode file second column is not sortable for no reason.
For an inventory without barcode file first column is not sortable but since it
is the default sort order the sorting icon is still displayed.
This patch corrects by setting default sort order on barcode column.
Test plan :
- perform inventory with barcode file
- look at result table
- table is sorted by barcode
=> Without patch second column is not sortable
=> With patch all columns are sortable
- perform inventory without barcode file
- look at result table
=> Without patch first column show sort icon and table is not sorted by barcode
=> With patch first column is not sortable and table is sorted by barcode
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:46:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:46:04 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column not sortable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
--- Comment #3 from Fridolin SOMERS ---
Oh I see, this JS code is usefull for inventory without barcode file.
I have correct patch and renamed bug a little
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 11:46:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 09:46:20 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column sorting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|inventory column not |inventory column sorting
|sortable |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:26:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 11:26:34 +0000
Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused
checkin for data corruption
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996
--- Comment #19 from Marcel de Rooy ---
Created attachment 65418
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65418&action=edit
Bug 18996: [QA Follow-up] Remove global variables from Message.t
As per request of Colin in comment18, this patch makes the use of global
variables in Message.t no longer needed.
The three subtests are now completely independent and could well be moved
to separate test scripts.
Note: Strictly speaking, the use of global (package) variables could
potentially introduce new bugs (e.g. if the value is modified outside the
script). This seems not to be the case here, but we are safe now.
Test plan:
Run the test again.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:27:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 11:27:13 +0000
Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused
checkin for data corruption
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996
--- Comment #20 from Marcel de Rooy ---
(In reply to Colin Campbell from comment #18)
> unnecessarily making lexical variables package variables is potentially
> introducing bugs. If you want to do it, it should not really be slipped in
> as part of another patch, but have its own rationale
Added a follow-up to address your concerns. Thx for testing.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:45:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 11:45:38 +0000
Subject: [Koha-bugs] [Bug 18636] Can not save new patron on fresh install (
Conflict between autoMemberNum and BorrowerMandatoryField)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636
Michael Kuhn changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mik at adminkuhn.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:03:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:03:35 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #26 from Marcel de Rooy ---
Just a remark:
Date::Calc's Add_Delta_YM does the same as what you are doing now with limit.
($year,$month,$day) = Add_Delta_YM($year,$month,$day, $Dy,$Dm);
>From POD:
This function does no "wrapping" into the next month if the day happens to lie
outside the valid range for the resulting year and month (after adding the year
and month offsets). Instead, it simply truncates the day to the last possible
day of the resulting month.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:04:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:04:42 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:04:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:04:45 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65370|0 |1
is obsolete| |
Attachment #65371|0 |1
is obsolete| |
Attachment #65372|0 |1
is obsolete| |
--- Comment #27 from Marcel de Rooy ---
Created attachment 65419
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65419&action=edit
Bug 17699: Add more tests to highlight the problem
Add problematic cases to highlight the problem.
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:04:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:04:50 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #28 from Marcel de Rooy ---
Created attachment 65420
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65420&action=edit
Bug 17699: Use limit as end_of_month
>From DateTime::Duration pod:
""
For positive durations, the "end_of_month" parameter defaults to wrap.
For negative durations, the default is "limit". This should match how
most people "intuitively" expect datetime math to work.
""""
We need end_of_month => limit for positive durations as well.
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:04:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:04:54 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
--- Comment #29 from Marcel de Rooy ---
Created attachment 65421
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65421&action=edit
Bug 17699: Add test descriptions
Test plan:
prove -v t/db_dependent/Koha/Patrons.t
Subtest: renew_account
1..30
ok 1 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00
ok 2 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00
ok 3 - With BorrowerLogs, Koha::Patron->renew_account should have logged
ok 4 - today + 12 months must be 2017-03-31T00:00:00
ok 5 - today + 12 months must be 2017-03-31T00:00:00
ok 6 - Without BorrowerLogs, Koha::Patron->renew_account should not have
logged
ok 7 - today + 12 months must be 2017-03-31T00:00:00
ok 8 - today + 12 months must be 2017-03-31T00:00:00
ok 9 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00
ok 10 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00
ok 11 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00
ok 12 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00
ok 13 - With BorrowerLogs, Koha::Patron->renew_account should have logged
ok 14 - today + 12 months must be 2017-11-30T00:00:00
ok 15 - today + 12 months must be 2017-11-30T00:00:00
ok 16 - Without BorrowerLogs, Koha::Patron->renew_account should not have
logged
ok 17 - today + 12 months must be 2017-11-30T00:00:00
ok 18 - today + 12 months must be 2017-11-30T00:00:00
ok 19 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00
ok 20 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00
ok 21 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00
ok 22 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00
ok 23 - With BorrowerLogs, Koha::Patron->renew_account should have logged
ok 24 - today + 12 months must be 2018-07-31T00:00:00
ok 25 - today + 12 months must be 2018-07-31T00:00:00
ok 26 - Without BorrowerLogs, Koha::Patron->renew_account should not have
logged
ok 27 - today + 12 months must be 2018-07-31T00:00:00
ok 28 - today + 12 months must be 2018-07-31T00:00:00
ok 29 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00
ok 30 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:04:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:04:58 +0000
Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly
subtracted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65400|0 |1
is obsolete| |
--- Comment #30 from Marcel de Rooy ---
Created attachment 65422
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65422&action=edit
Bug 17699: Reset time simulation
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:47:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:47:11 +0000
Subject: [Koha-bugs] [Bug 18985] SQL reports 'Last edit' and 'Last run'
columns sort alphabetically, not chronologically
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18985
--- Comment #2 from Owen Leonard ---
Created attachment 65423
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65423&action=edit
Bug 18985 - SQL reports 'Last edit' and 'Last run' columns sort alphabetically,
not chronologically
This patch alters the DataTables configuration of the SQL reports list
so that date columns are identified via class rather than position.
To test, apply the patch and go to Reports -> Use saved.
Test the re-ordering of the creation date, last edit, and last run
columns. Each should sort correctly based on the date.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:47:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 12:47:09 +0000
Subject: [Koha-bugs] [Bug 18985] SQL reports 'Last edit' and 'Last run'
columns sort alphabetically, not chronologically
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18985
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 15:20:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 13:20:14 +0000
Subject: [Koha-bugs] [Bug 19024] New: order cancelled status is reset on
basket close
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024
Bug ID: 19024
Summary: order cancelled status is reset on basket close
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs at lists.koha-community.org
Reporter: colin.campbell at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
Similar to bug 15036 orderstatus is being set to ordered when a basket is
closed including for lines which have been cancelled. In the acquisition
screens if you view the basket the lines are clearly cancelled as this uses
cancellationdate as the determiner of status. But from the staff title view the
acquisitions tab now shows ordered incorrectly.
Simple fix - need to check cancellation_date and cancelled status are not
getting out of sync elsewhere
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 15:34:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 13:34:49 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column sorting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 15:34:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 13:34:52 +0000
Subject: [Koha-bugs] [Bug 19021] inventory column sorting
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65417|0 |1
is obsolete| |
--- Comment #4 from Owen Leonard ---
Created attachment 65424
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65424&action=edit
[SIGNED-OFF] Bug 19021 - inventory column sorting
In inventory result page, items are shown in a JS DataTable.
For an inventory with barcode file second column is not sortable for no reason.
For an inventory without barcode file first column is not sortable but since it
is the default sort order the sorting icon is still displayed.
This patch corrects by setting default sort order on barcode column.
Test plan :
- perform inventory with barcode file
- look at result table
- table is sorted by barcode
=> Without patch second column is not sortable
=> With patch all columns are sortable
- perform inventory without barcode file
- look at result table
=> Without patch first column show sort icon and table is not sorted by barcode
=> With patch first column is not sortable and table is sorted by barcode
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 15:40:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 13:40:52 +0000
Subject: [Koha-bugs] [Bug 19022] inventory location and author display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 15:40:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 13:40:54 +0000
Subject: [Koha-bugs] [Bug 19022] inventory location and author display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65414|0 |1
is obsolete| |
--- Comment #3 from Owen Leonard ---
Created attachment 65425
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65425&action=edit
[SIGNED-OFF] Bug 19022 - inventory location and author display
In inventory result page :
Location is displayed after branch without any difference.
Author is displayed into a paragraph making row hight.
This patch adds for location a span with class like in catalogue detail page,
and changes author to be on same line in order to have a more compact display
for this table that may be huge.
Test plan :
- Perform inventory with a barcode file
- Look at result
=> you see localtion in a new line after library and in italic
=> you see author after title on same line with "by" separator
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:13:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:13:05 +0000
Subject: [Koha-bugs] [Bug 19023] inventory tool performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:13:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:13:08 +0000
Subject: [Koha-bugs] [Bug 19023] inventory tool performance
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65416|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 65426
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65426&action=edit
[SIGNED-OFF] Bug 19023 - inventory tool performance
Inventory tool performance seems to be worst since 16.11.
I think it is because of authorized values computing changed by Bug 17249.
For each subfield of each item, we try to get the authorized value description
with Koha::AuthorisedValues->search_by_marc_field.
But this method does not use cache like
Koha::AuthorisedValues->get_description_by_koha_field.
I propose to use Koha::AuthorisedValues->get_description_by_koha_field and also
to look for authorized value description only for item fields used in TT :
location, notforloan, itemlost, damaged, withdrawn.
I have experimented inventory time on 100 items from 5s to 1s.
Test plan :
- Without patch
- Perform inventory with barcode file
- Check results and mesure execution time
- Apply patch
- Reperform inventory with same barcode file
- Check results is the same
- Compare execution time
- Run prove t/db_dependent/Items/GetItemsForInventory.t
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:33:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:33:11 +0000
Subject: [Koha-bugs] [Bug 18660] Translatability: Get rid of template
directives [ %% in translation for patroncards-errors.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64014|0 |1
is obsolete| |
--- Comment #7 from Marc V?ron ---
Created attachment 65427
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65427&action=edit
Bug 18660: Translatability: Get rid of template directives [%% in translation
for patroncards-errors.inc
Translation for koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc
contains a lot of (partial) template directives like:
%%]%s %sLayout: [%%
This patch fixes it
To test:
- Verify that code changes make sense
- Apply patch
- Create a translation (cd misc/translator , then: perl translate create aa-AA
- Verify that in po/aa-AA-staff-prog.po contains no fragments like %%] or [%%
for patroncards-errors.inc
- Try to get an error: Try a link like
http://[YOUR
SERVER]/cgi-bin/koha/patroncards/create-pdf.pl?batch_id=1&template_id=999&layout_id=999&start_card=1
...where template_id and layout_id do not exist
(Amended for comment #2 2017-06-05 mv)
(Amended for comment #6 2017-08-02 mv)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:33:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:33:58 +0000
Subject: [Koha-bugs] [Bug 18660] Translatability: Get rid of template
directives [ %% in translation for patroncards-errors.inc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18660
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:41:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:41:47 +0000
Subject: [Koha-bugs] [Bug 16759] Make opac holdings table configurable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759
--- Comment #3 from Owen Leonard ---
This patch works well for me and I'd be ready to sign off on it.
This feature may make it more desirable to have shelving location in a separate
location, but I don't have a strong opinion about it.
I think it would be nice to transition from the system preferences, but I think
it could be handled in separate follow-up bugs.
I think that we should not use js-based column configuration to hide anything
which is sensitive information (OPACShowCheckoutName is the one that comes to
mind), and let no-js users see the full table.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:43:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:43:55 +0000
Subject: [Koha-bugs] [Bug 19025] New: Move C4::Reserves::GetReserveInfo to
Koha::Holds
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19025
Bug ID: 19025
Summary: Move C4::Reserves::GetReserveInfo to Koha::Holds
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: jonathan.druart at bugs.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
This subroutine is only used once and can be replaced with a call to
Koha::Holds->find
It will avoid unnecessary joins.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:45:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:45:35 +0000
Subject: [Koha-bugs] [Bug 19025] Move C4::Reserves::GetReserveInfo to
Koha::Holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19025
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17728
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728
[Bug 17728] Move C4::Reserves code to the Koha namespace
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:45:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:45:35 +0000
Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19025
--- Comment #3 from Jonathan Druart ---
Bug 19025 - Move C4::Reserves::GetReserveInfo to Koha::Holds
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19025
[Bug 19025] Move C4::Reserves::GetReserveInfo to Koha::Holds
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:53:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Aug 2017 14:53:02 +0000
Subject: [Koha-bugs] [Bug 19025] Move C4::Reserves::GetReserveInfo to
Koha::Holds
In-Reply-To: