[Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|Signed Off                  |Failed QA

--- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looks good to me, but I am wondering if we really need an additional module to
test the behavior of BorrowerRenewalPeriodBase. Does this new dependency really
bring us great benefits here?
Time::Fake is Debian packaged though.
It seems to me that testing the "now" variant could be done too with current
time. The other variant "dateexpiry" allows you to set dates so that you can
see that the end_of_month limit really works.

And if we should use it anyway, I would prefer to see the offset call just
before the code it should actually work on and an additional Time::Fake->reset
after that block.

Changing status to reflect need for feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.