[Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #20)
> Looks good to me, but I am wondering if we really need an additional module
> to test the behavior of BorrowerRenewalPeriodBase. Does this new dependency
> really bring us great benefits here?
> Time::Fake is Debian packaged though.

It's already a Koha dependency.

> It seems to me that testing the "now" variant could be done too with current
> time. The other variant "dateexpiry" allows you to set dates so that you can
> see that the end_of_month limit really works.

I think it is less error prone to use Time::Fake

> And if we should use it anyway, I would prefer to see the offset call just
> before the code it should actually work on and an additional
> Time::Fake->reset after that block.

I added the ->reset call, but I do not understand your other remark. Where do
you want it to be moved? It sounds better to me to have it visible at the
beginning of the loop.

-- 
You are receiving this mail because:
You are watching all bug changes.