[Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996

--- Comment #18 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #15)
> Created attachment 65393 [details] [review]
> Bug 18996: Resolve an uninitialized warning from ILS/Item.pm
> 
> From the syslog call on line 107/108. The field $item->{title} has not
> been initialized. When catching the warns in a test script with Test::Warn,
> I got:
>     Use of uninitialized value $args[1] in sprintf at
> /usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423.
> 
> This simply resolves the warning. We might have a closer look to this title
> field on another report though.
> 
> Test plan:
> Run Message.t from the next patch without this fix. It will fail since the
> additional warning makes warnings_like return false.
> 
> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

(In reply to Marcel de Rooy from comment #16)
> Created attachment 65394 [details] [review]
> Bug 18996: Add checkin subtest in SIP/Message.t
> 
> Variable $branch was not used.
> Promoted some global vars to our.
> Shared the branchcode between all three subtests now.
> The third subtest contains all six cases mentioned in the first patch.
> 
> Test plan:
> Run t/db_dependent/SIP/Message.t
> 
> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

unnecessarily making lexical variables package variables is potentially
introducing bugs. If you want to do it, it should not really be slipped in as
part of another patch, but have its own rationale

-- 
You are receiving this mail because:
You are watching all bug changes.