[Koha-bugs] [Bug 17703] Add ISSN column in serials claims table - fix

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65454|0                           |1
        is obsolete|                            |

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 65455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65455&action=edit
Bug 17703 - Add ISSN column in serials claims table - fix

Bug 11861 added ISSN column in serials claims table and a SQL query in
C4::Serials::GetLateOrMissingIssues().
But this SQL query is in a if $supplierid condition, the same change must be
done if $serialid to allow ISSN in CVS export of claims.

This patch rewrites the method to have a common SQL query with conditions only
on WHERE.
Removes the order input arg since it is never used, order in TT is managed by
DataTable and CSV export is generated with the order of selected rows.

Test plan:
- Make sure you have a subscription with some late or missing issues
- Go to Tool > CSV profils
- Create a profile :
  Profile name = Issues to claim
  Profile type = SQL
  Usage = Late serial issues claims
  Profile SQL fields =
SUPPLIER=aqbooksellers.name|TITLE=subscription.title|ISSN=subscription.issn|ISSUE
NUMBER=serial.serialseq|LATE SINCE=serial.planneddate
- Go to serials claims page : /cgi-bin/koha/serials/claims.pl
- Choose a vendor and click OK
- You see serials to claim, with ISSN column filled with subscription's ISSN
- Check all lines
- Select "Issues to claim" CSV profile
- Click on "Download selected claims"
=> With patch you have ISSN value
- Run UT t/db_dependent/Serials/Claims.t

-- 
You are receiving this mail because:
You are watching all bug changes.