[Koha-bugs] [Bug 18900] wrong number format in receiving order

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Aug 9 17:09:07 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65628|0                           |1
        is obsolete|                            |

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 65761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65761&action=edit
Bug 18900: wrong number format in receiving order

Bug 18471 added number formating in order receive.

I found a bug generated by this.
Koha::Number::Price defines methods to (un)format price depending on
CurrencyFormat syspref.
The bug is that for CurrencyFormat US, some params are not defined in this
module so there are retrieved from system locale. If system locale is not
en_US, the params will be wrong. For example fr_FR will define ',' as decimal
and so saved unit price is divided by 1000.

To recreate:
- On a server with locale 'fr_FR'
- With Plack mode
- Set CurrencyFormat on 'US'
- Open a basket
- Place an order for an item
- Close basket
- Receive order with changing 'Actual Cost' to '1,234'
- Note the 'Actual Cost' is now '1.23'
- Run unit test t/Number/Price.t without and with patch

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list