[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still trying to give this a second sign-off as I think this will make life a
lot easier. Sadly, I ran into a big problem:

AcqCreateItem is set to: on order

1) The method create_items is not covered by tests!
- Create a new basket, choose: on receive
- Add to basket by searching for an existing record in your catalog
- Click order on one of the results
=> Internal server error, translates to: The method create_items is not covered
by tests!

Can't test further from here :(

2) The test file should not be named Basket.pm, but Basket.t :)

3) Patch reintroduced a typo (not really blocking)
-#need old receivedate if we update the order, parcel.pl only shows the right
parcel this way FIXME
+#need old recievedate if we update the order, parcel.pl only shows the right
parcel this way FIXME


Tiny stuff (definitely non-blocker, maybe for later):
- Baskets created before the introduction of the feature don't show the
information about item creation on the basket summary page
- Editing a basket after inititally creating it, doesn't offer the option to
change. This makes a lot of sense, but maybe it would be good to display the
selection as information (not changeable).

-- 
You are receiving this mail because:
You are watching all bug changes.