[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 65928
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65928
Bug 19088: plugins-upload causes error log noise

Review of attachment 65928:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19088&attachment=65928)
-----------------------------------------------------------------

::: plugins/plugins-upload.pl
@@ +47,4 @@
>  
>  my $uploadfilename = $input->param('uploadfile');
>  my $uploadfile     = $input->upload('uploadfile');
> +my $op             = $input->param('op') || q{};

// is better.
if 'op' is '0', then this would set $op to ''.
|| evaluates truthy only.
// is a defined check.
http://perldoc.perl.org/perlop.html#Logical-Defined-Or

-- 
You are receiving this mail because:
You are watching all bug changes.