[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Colin Campbell from comment #7)
> (In reply to Katrin Fischer from comment #5)
> > Ok, thinking more about this, I think this is a failed QA:
> > 
> > I propose: When a basket is closed, change new to ordered, leave all other
> > status alone.
> > 
> > The workflow usually is something like:
> > 
> > new > ordered
> > then either:
> > > complete
> > or 
> > partial > complete
> > 
> > Note: The SQL in the patch has a typo and looks for completeD -
> > reintroducing an already fixed bug by reseting complete to ordered when the
> > basket is closed.
> > 
> > 
> > Reasoning: 
> > 
> > New - If the basket is closed, we want to set it to ordered.
> > 
> > Ordered - If a basket is reopened, we can reset this to new. If the basket
> > is closed again, those should be set from new to ordered.
> > 
> > Partial - Partial means a part of the order has already been received. To
> > keep that information, we should probably leave the status alone and not
> > change it when the basket is opened/closed.
> > 
> > Complete - If an item is received already and linked to an invoice, we don't
> > want to reset it to ordered or new on opening or closing the basket. The
> > only way to change the status at this point should be to undo the receive
> 
> Not sure of the reasoning behind partial. When an ordered is part-received
> it is split into two the received copies go on a new order marked complete
> the remainder stay on an order marked partial. partial is a special case of
> ordered, so I think it should probably continue to be treated like ordered
> (a reason for reopening the basket may well be to cancel the outstanding
> partial order)

It's difficult, I think partial doesn't quite fit into the process. Maybe there
should be: partial-new, partial-ordered, partial-cancelled - or partial should
be removed as a status. It's still indicated by the existance of the linked
parent order I tihnk? At the moment partial is only a special case of ordered,
as you said. I am ok with treating it one way or the other (moving it to new on
opening or not). Can we set this back to Needs Signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.