[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Aleisha Amohia from comment #3)
> (In reply to Marc Véron from comment #2)
> > What happens if a library has modified the note? - Modifications for title
> > and content would get lost with the following statement in 
> > bug_18915_-_modifying_patron_note_notice.sql 
> > 
> > UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set
> > by patron', title = 'Checkout note', content = '<<borrowers.firstname>>
> > <<borrowers.surname>> has added a note to the item <<biblio.title>> -
> > <<biblio.author>> (<<biblio.biblionumber>>).' WHERE code = 'PATRON_NOTE';
> 
> I see what you mean, but this patch is fixing the content of the note, so it
> does need to be changed. Unless you can think of another way to fix the note?

Aleisha,
Could you fix the note by just a SQL replace for the wrong field?
UPDATE table SET field = REPLACE(field ,from_str, to_str) etc etc
So look for biblio.item only and replace that by biblio.title.
If the library changed the note and fixed it already, there will be no problem.

Please adjust this entry too:
installer/data/mysql/updatedatabase.pl:        VALUES ('circulation',
'PATRON_NOTE', '', 'Patron note on item', '0', 'Patron issue note',
'<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item
<<biblio.item>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');

And do not forget to add PATRON_NOTE (or CHECKOUT_NOTE) to 
installer/data/mysql/en/mandatory/sample_notices.sql
It does not occur yet..

Thanks !

-- 
You are receiving this mail because:
You are watching all bug changes.