[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #51 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Katrin

Thanks for testing.

I have just attached a patch that fixes the issues you found. I have two
queries:

1. At the moment in the new followup patch I have implemented a conditional so
only superlibrarian users can see the acquisition onboarding tool. I tried
using the haspermission() and the get_user_subpermissions() functions from the
Auth.pm in the acqui-home.pl script however I found that when testing using
these functions with a user that had full acq permissions these functions
returned that the user did not have acq permissions and so I found myself at a
roadblock.

Can you suggest any ideas for implementing checks on the users permissions so
that users with full acq permissions and that are not superlibrarians can also
view the acq onboarder?

2. I have run the QA test tool and as the GetBudgetHighestPeriod() function POD
has now been added that passes, however I now get this error:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/onboardinginclude3.inc
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                Can't call method "config" on unblessed reference at
Koha/Database.pm line 56.

I have been researching this error however I am rather confused about how to
fix it, can you please point me in the right direction for fixing it? 

Cheers
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.