[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|18438                       |
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Katrin Fischer from comment #5)
> Retested, had totally forgotten we switched to a modal there. Read through
> the other bug too, but not totally understanding the problem yet.
> 
> What is strange: if the item is not from a transfer, the button seems to
> work correctly?

Bug 18438 does make modal dissmiss without reloading whole page, but when the
item is not transferred, the page normaly reloads and the the hold is marked
waiting. These are two different modals in returns.tt:

#hold-found1 - if the hold is already waiting - just dismissing the modal is
OK, the hold is already marked waiting

#hold-found2 - hold found, need to be marked waiting - the modal does not
dismiss when confirm button clicked, but the form is confirmed and page reloads
and mark the hold waiting. This modal is dismissed when ignore button is
clicked - so hold is not marked as waiting

When hold found and need transfer the #hold-found2 modal is used (just with
other modal-footer because different button labels)

When the hold is transferred the #hold-found1 is used, but should not, the hold
is not waiting yet!

The Waiting or Reserved status comes originally from
C4::Reserves::CheckReserves, the 'T' status is considered waiting here - which
is not true

I tried to fix it, patch is comming


I remove dependency on 18438 - it does not come from here, patch from bug 18438
just highlighted the problem


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438
[Bug 18438] Check in: Modal about holds hides important check in messages
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.