[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Aug 23 14:31:17 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

--- Comment #99 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 65107
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65107
Bug 18137: Migrate from Swagger2 to Mojolicious::Plugin::OpenAPI

Review of attachment 65107:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18137&attachment=65107)
-----------------------------------------------------------------

::: Koha/REST/V1/Auth.pm
@@ +57,5 @@
> +                json => { error => 'Something went wrong, check the logs.' }
> +            );
> +        }
> +        if ($_->isa('Koha::Exceptions::UnderMaintenance')) {
> +            return $c->render(status => 503, json => { error => $_->error });

Should these calls to render not all be 'openapi => { error => $_->error }` as
aposed to `json => { error => $_->error }`.. else none of these responses are
getting validated.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list