[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Aug 25 11:31:12 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please look at the changed code: 

 my ( $zquery, $squery ) = _build_query( $pars );
 [...]
 foreach my $server ( @servers ) {
        if(my $attributes = $server->{attributes}){
            $zquery = "$attributes $zquery";
        }
        $oConnection[$s] = _create_connection( $server );
        $oResult[$s] =
            $server->{servertype} eq 'zed'?
                $oConnection[$s]->search_pqf( $zquery ):
                $oConnection[$s]->search(new ZOOM::Query::CQL(
                    _translate_query( $server, $squery )));
        $s++;
    }

After we build zquery, you start prefixing it each time with more server
attributes. So the last server will get them all. Wrong !
Probably this was tested with one server at a time. But it might fail for a
search on multiple servers.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list