[Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Not a hard fail.

Missing License.
https://wiki.koha-community.org/wiki/Coding_Guidelines#Licence

Budget.pm is not perl tidy.
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy


> push @budgets_loop, \%$line;

Isn't this the same as $line? You already treat $line as a hash ref in the
previous line code change. Haven't tested just read it and thinking out loud.

-- 
You are receiving this mail because:
You are watching all bug changes.