From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 00:29:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 23:29:29 +0000
Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod
	preference
In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19722-70-PTtDBzK9De@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69426&action=edit
Bug 19722 - Add MaxItemsToDisplayForBatchMod systempreference

To test:
1 - Get a list of itemnumbers or barcodes
2 - Set MaxItemsToProcessForBatchMod to less than this number of items
3 - Attempt to batch edit, you arent allowed
4 - Set MaxItemsToProcessForBatchMod to some hugh number like 60000
5 - Try a list of as many items as possible 30000 was good for me (they
        should exist in your system)
6 - Try to batch edit, system will timeout on displaying these items
7 - Apply patch, update database
8 - Set MaxItemsToDisplayForBatchMod to 1000 (default)
9 - Try large file again, should not display items, but allow
modification, wait for this to finish
10 - SetMaxItemsToProcessForBatchMod to 1000 and try large file again
11 - Should be prohibited as before

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 00:29:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Nov 2017 23:29:27 +0000
Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod
	preference
In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19722-70-GEgvpvTstb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 11:55:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 10:55:35 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-IokgUKLtUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 11:55:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 10:55:38 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-1Z0tVhnNYk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69416|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69427&action=edit
Bug 19653: Move tools templates JavaScript to the footer: Additional tools

This patch modifies the staff client "Additional tools" templates so
that JavaScript is included in the footer instead of the header:

- Calendar
- CSV profiles
- Log viewer
- News
- Task scheduler
- Edit quotes for QOTD feature
- Upload

Note that the log viewer template has been modified so that the
"interface" variable (passed to the template to provide the correct path
to staff client assets) isn't overwritten by an "interface" variable
required by the log viewer.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 12:33:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 11:33:03 +0000
Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl
In-Reply-To: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18071-70-rloMPXmhTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 12:33:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 11:33:07 +0000
Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl
In-Reply-To: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18071-70-VjliWUbVFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69428&action=edit
Bug 18071: (QA follow-up) Add commit parameter, add warning

Addressing points mentioned in comment12:
[1] Commit parameter.
[2] Warning if authid does not exist for -merge.

Test plan:
[1] Run update_authorities.pl -authid X -merge -ref Y -c
    where X does not exist in your db and Y does.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 12:34:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 11:34:13 +0000
Subject: [Koha-bugs] [Bug 18071] Add new script update_authorities.pl
In-Reply-To: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18071-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18071-70-HaHIFkhdVb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #12)
> Blocker:
> 1 - There should be a commit option
> 2 - If a given record is not found we should let the user know:
> given: perl misc/maintenance/update_authorities.pl --authid 1, 2 --merge
> --reference 3 -v
> result: 1 is merged, ' 2' is not found and ignored, no error

Fixed

> Suggestions:
> Verbose should give more info:
> -when merging list the reference that was used
>  --would be nice to see the heading of the records if possible
> -when renumbering would be nice to see the values that were changed
> -when merging or deleting would be nice to get the records that were
> updated, or a count
> -when deleting a record we should let the user know if bibs are not modified
> (because of AuthorityMergeLimit syspref) - I thought things were not working
> until I dug in to code
> 
> I think all the verbosity would have to add error returns to the modules, so
> I understand if it is out of the scope of this bug, but want to put the idea
> out there at least

Thx for feedback. We should put them on a new report.

He's yours again Nick.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 13:46:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 12:46:07 +0000
Subject: [Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets
In-Reply-To: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19684-70-Q0P6WKf42o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not sure I understand the changes, how can we know it will not introduce
side-effects?
Tests are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 13:59:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 12:59:00 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-Djr8QCxHJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67231|0                           |1
        is obsolete|                            |
  Attachment #69174|0                           |1
        is obsolete|                            |

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69429&action=edit
Bug 17282 - Fix QA comments - Add a loading message, - prevent JS error when
report fails, - fix (bootstrap 3 ?) displaying problems

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 13:59:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 12:59:09 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-qzoWllgFFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69430&action=edit
Bug 17282 - Add information about the new Javascript libraries in the about
page - fix a QA warning - Move chart settings on top and make them hidden by
default - Add options to get all results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 13:59:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 12:59:39 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-XqPjqomLJ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last 2 patches fix conflict on staff-global.css

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:01:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:01:55 +0000
Subject: [Koha-bugs] [Bug 19724] New: Add timestamp to biblio_metadata and
 deletedbiblio_metadata
Message-ID: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

            Bug ID: 19724
           Summary: Add timestamp to biblio_metadata and
                    deletedbiblio_metadata
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Database
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
We need to know the last modification time of the MARC record for some
features (like OAI-PMH parameters 'from' and 'until' for instance)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:03:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:03:10 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-V6sFBe0b7k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69431&action=edit
Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
We need to know the last modification time of the MARC record for some
features (like OAI-PMH parameters 'from' and 'until' for instance)

This patch only adds the missing column in biblio_metadata and
deletedbiblio_metadata

Test plan:
1. Run updatedatabase.pl
2. Verify that both tables have the new column, its value should be the
   greatest timestamp value from the corresponding biblio and
   biblioitems table entries
   You can verify with the following SQL query:
     SELECT b.biblionumber, b.timestamp as biblio_ts,
     bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts
     FROM biblio_metadata m
     LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber)
     LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber);

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:03:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:03:26 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-e9tZ7nZiNx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:09:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:09:07 +0000
Subject: [Koha-bugs] [Bug 19725] New: OAI-PMH ListRecords and
 ListIdentifiers should use biblio_metadata.timestamp
Message-ID: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

            Bug ID: 19725
           Summary: OAI-PMH ListRecords and ListIdentifiers should use
                    biblio_metadata.timestamp
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 19724

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724
[Bug 19724] Add timestamp to biblio_metadata and deletedbiblio_metadata
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:09:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:09:07 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-w8S5GQgQqt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19725


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725
[Bug 19725] OAI-PMH ListRecords and ListIdentifiers should use
biblio_metadata.timestamp
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:27:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:27:10 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-IBuiJl6vqm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Tom?s Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:27:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:27:23 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-alXQN9NZzW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69417|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:27:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:27:32 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-ShBboynaV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 69432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69432&action=edit
Bug 19708 - Remove useless code from opac-basket

This removes a lot of useless code relating to the print function from
opac-basket.tt, opac-basket.pl and opac/basket.js.

It also fixes the CSS so that no extra blank page is printed.

To test:
0) Add an item to your cart
1) Print your basket
    Note the appearance of the page. There will be an extra blank page.
2) Apply patch
3) Reload basket
4) Print your basket
    The appearce should be identical. The extra blank page is gone.

This only affects the OPAC.

Signed-off-by: Tom?s Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Tom?s Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:28:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:28:10 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-kn16p3qlQH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:28:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:28:22 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-SRtDzzwpcV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69432|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:28:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:28:31 +0000
Subject: [Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt
In-Reply-To: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19708-70-ZGrqlMegVo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 69433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69433&action=edit
Bug 19708 - Remove useless code from opac-basket

This removes a lot of useless code relating to the print function from
opac-basket.tt, opac-basket.pl and opac/basket.js.

It also fixes the CSS so that no extra blank page is printed.

To test:
0) Add an item to your cart
1) Print your basket
    Note the appearance of the page. There will be an extra blank page.
2) Apply patch
3) Reload basket
4) Print your basket
    The appearce should be identical. The extra blank page is gone.

This only affects the OPAC.

Signed-off-by: Tom?s Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Tom?s Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 14:41:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 13:41:38 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-bBlyRUsTWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
When testing the Batch item modification, after entering barcodes and
continuing I get:

ReferenceError: $ is not defined. Batchmod.pl:861:1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:00:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:00:26 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-EFgkOFrfQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:07:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:07:24 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-z4X4vmmZCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Elias <elias.dehler at thulb.uni-jena.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:14:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:14:22 +0000
Subject: [Koha-bugs] [Bug 19726] New: Move admin templates JavaScript to the
 footer: Preferences
Message-ID: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

            Bug ID: 19726
           Summary: Move admin templates JavaScript to the footer:
                    Preferences
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for system preferences, both standard and local.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:14:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:14:22 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-aGp7fd0Xv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19726


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726
[Bug 19726] Move admin templates JavaScript to the footer: Preferences
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:18:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:18:11 +0000
Subject: [Koha-bugs] [Bug 17079] Umlauts(special chars) are displayed as One
 Latin-1 char per byte on the plugin-template
In-Reply-To: <bug-17079-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17079-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17079-70-anpvy8XEr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17079

Elias <elias.dehler at thulb.uni-jena.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:29:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:29:55 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17499-70-0AhNwWSkvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:29:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:29:59 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17499-70-u6feqR5oLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66686|0                           |1
        is obsolete|                            |

--- Comment #52 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69434&action=edit
Bug 17499: Add Koha-objects for messaging preferences

This patch adds Koha-objects for messaging preferences.

Adds simple validation for messaging preferences.

The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference

Adds a method for getting available messaging options.

Adds a method for setting default messaging preferenes.
  $patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
  ...or...
  Koha::Patron::Message::Preference->new_from_default({
    borrowernumber => 123,
    categorycode => "ABC",
    message_attribute_id => 1,
  });

Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
  $preference->message_transport_types                              (for
getting)
  $preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
  (also supports other calling conventions, see documentation for more)

Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.

Includes test coverage for basic usage.

To test:
1. prove t/db_dependent/Koha/Patron/Message/*

Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:31:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:31:29 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17499-70-JJOgn4UHHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69434|0                           |1
        is obsolete|                            |

--- Comment #53 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69435&action=edit
Bug 17499: Add Koha-objects for messaging preferences

This patch adds Koha-objects for messaging preferences.

Adds simple validation for messaging preferences.

The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference

Adds a method for getting available messaging options.

Adds a method for setting default messaging preferenes.
  $patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
  ...or...
  Koha::Patron::Message::Preference->new_from_default({
    borrowernumber => 123,
    categorycode => "ABC",
    message_attribute_id => 1,
  });

Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
  $preference->message_transport_types                              (for
getting)
  $preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
  (also supports other calling conventions, see documentation for more)

Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.

Includes test coverage for basic usage.

To test:
1. prove t/db_dependent/Koha/Patron/Message/*

Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:32:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:32:05 +0000
Subject: [Koha-bugs] [Bug 19727] New: Editing call number in bibliographic
 record don' t follow in the item record
Message-ID: <bug-19727-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19727

            Bug ID: 19727
           Summary: Editing call number in bibliographic record don't
                    follow in the item record
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi, 

When you edit field (090, 050, 02 etc.)for the call number for a bibliographic
record in koha. the new information dont`t update in the item record (0). The
call number given from the bibliographic record should be reproduced in the
item record in the field provided for this purpose when a change in the rating
in the bibliographic record. We should Make a match from the bibliographic
field to the "o" field (dimension) of the item and not vice versa. Even if
there are sometimes additions to the call number of the item and it is
necessary to open the item for it, it is the same call number essentially.
Therefore a modification of the call number in the field provided for this
purpose in the bibliographic record should lead automatically to the same
modification to the item since there must be a correspondence between these two
fields.

Patrcik,

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:35:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:35:37 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-RGpreFOYBM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:35:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:35:40 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-UNyp8pY79d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69436&action=edit
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

This patch modifies the staff client's system preferences templates so
that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
both the standard and local use system preferences:

 - WYSIWYG editor
 - Confirmation messages
 - Table sorting
 - Multiple selects (CoceProviders for example)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 15:35:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 14:35:46 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17499-70-mONAXy9SBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

--- Comment #54 from Lari Taskula <lari.taskula at jns.fi> ---
(In reply to Marcel de Rooy from comment #49)
> QA Comment:
> Looks good to me overall (see also comment47).
Fixed.

> +=head3 search
> +
> +Koha::Patron::Message::Preferences->search_with_message_name({
> +    borrowernumber => 123,
> +    message_name => 'Hold_Filled',
> +});
> Wrong POD header
Fixed.

Also cleaned commit message. I set it to Needs Signoff again as I added a new
test changed the functionality of $patron->set_default_messaging_preferences to
delete any previous preferences (this is expected behaviour; before this fix it
would throw an exception).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:12:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:12:01 +0000
Subject: [Koha-bugs] [Bug 19727] Editing call number in bibliographic record
 don' t follow in the item record
In-Reply-To: <bug-19727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19727-70-SjPsMNQWLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19727

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
To change this behavior would be an enhancement which would require the ability
to turn it on and off. My library depends on Koha working the way it does, so
it would need to be optional.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:17:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:17:02 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates to the footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-ScUnN0K7w1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19728


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728
[Bug 19728] Move template JavaScript to the footer: Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:17:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:17:02 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-lBIASU7XUq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19728


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728
[Bug 19728] Move template JavaScript to the footer: Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:17:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:17:02 +0000
Subject: [Koha-bugs] [Bug 19728] New: Move template JavaScript to the
	footer: Circulation
Message-ID: <bug-19728-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728

            Bug ID: 19728
           Summary: Move template JavaScript to the footer: Circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19641
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the main circulation page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:42:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:42:50 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-d5YE0F1gOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69437&action=edit
Bug 19725: Add failing test

Also fix tests for UNIMARC

Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it FAILS

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:42:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:42:53 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-ut0y5ko68G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69438&action=edit
Bug 19725: OAI-PMH - Use biblio_metadata.timestamp

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.

Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it SUCCEEDS

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:43:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:43:02 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-Jm0RAalYaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:47:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:47:59 +0000
Subject: [Koha-bugs] [Bug 19729] New: Lists pages in OPAC are missing an
 HTML link element in last breadcrumb
Message-ID: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

            Bug ID: 19729
           Summary: Lists pages in OPAC are missing an HTML link element
                    in last breadcrumb
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: simon.pouchol at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:50:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:50:55 +0000
Subject: [Koha-bugs] [Bug 19730] New: misc/ export_records.pl should use
 biblio_metadata.timestamp
Message-ID: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730

            Bug ID: 19730
           Summary: misc/export_records.pl should use
                    biblio_metadata.timestamp
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
        Depends on: 19724

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724
[Bug 19724] Add timestamp to biblio_metadata and deletedbiblio_metadata
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:50:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:50:55 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-WCAzxfZu2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19730


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730
[Bug 19730] misc/export_records.pl should use biblio_metadata.timestamp
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 16:59:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 15:59:39 +0000
Subject: [Koha-bugs] [Bug 17772] Allow to sort lists by date the record was
	created
In-Reply-To: <bug-17772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17772-70-tY5ZltyuUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17772

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:08:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:08:35 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-vzWlSJ5cnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

--- Comment #1 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69439&action=edit
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC

To match every other page in the OPAC and ease CSS styling, there should be
links to current page on last breadcrumbs in lists pages.

Test plan:
1-Go to /cgi-bin/koha/opac-shelves.pl
2-Notice that there are no links on the last breadcrumb in every page (my
lists, public lists, create list, individual list page)
3-Apply patch
4-Reload page, and notice there are now links, pointing to current page (#)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:09:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:09:31 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-yr9SSPXCSf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |simon.pouchol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:16:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:16:41 +0000
Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use
 biblio_metadata.timestamp
In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19730-70-2xwqFQbUUi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69440&action=edit
Bug 19730: Use biblio_metadata.timestamp in export_records.pl

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.

Test plan:
0. Do not apply patch
1. Run export DATE="$(date '+%F %T')"
2. Edit a biblio record, modify a field that is not mapped to a DB
   column, so biblio_metadata.timestamp will be modified but not
   biblioitems.timestamp
3. Run misc/export_records.pl --date="$DATE"
4. Verify that koha.mrc is empty
5. Apply patch
6. Run misc/export_records.pl --date="$DATE"
7. Verify koha.mrc contains the record you modified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:17:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:17:54 +0000
Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use
 biblio_metadata.timestamp
In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19730-70-shtZDI9Guw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:19:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:19:09 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-cGcTjwMk47@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63815|0                           |1
        is obsolete|                            |

--- Comment #36 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69441&action=edit
Bug 18595: Unit tests for Koha::Patron::Categories->default_messaging

This patch adds unit tests for Koha::Patron::Categories->default_messaging.
Tests
will help preparing for moving C4::Members::Messaging to Koha-objects.

To test:
1. Run t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:19:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:19:23 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-30iVKI5Pmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63816|0                           |1
        is obsolete|                            |

--- Comment #37 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69442&action=edit
Bug 18595: Move C4::Members::Messaging::GetMessagingOptions

This patch moves C4::Members::GetMessagingOptions to
Koha::Patron::Message::Preferences->get_options.

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

This patch also removes previously unused GetMessagingOptions in
opac-messaging.pl

To test:

Make sure you have enabled the following system preferences:
- opacuserlogin
- EnhancedMessagingPreferences
- EnhancedMessagingPreferencesOPAC

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "GetMessagingOptions"
   (grep -r 'GetMessagingOptions').
3. Observe no results in source code.

---- OPAC ----
1. Login to OPAC.
2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl).
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.

---- INTRANET ----
1. Login to intranet.
2. Go to edit patron's details and scroll down to their messaging preferences.
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.
6. Go to Administration -> Patron categories -> Edit (for any category)
7. Scroll down to observe default messaging preferences for this patron
category
8. Observe the preferences looking normal and as they should be.
9. Set any combination of messaging preferences.
10. Observe them apply as expected, repeat step 9-10 as much as you like.
11. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
12. Fill in required data, do not modify messaging preferences, click Save.
13. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:19:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:19:35 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-fxpco6t05H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63817|0                           |1
        is obsolete|                            |

--- Comment #38 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69443&action=edit
Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults

This patch moves C4::Members::SetMessagingPreferencesFromDefaults to
Koha::Patron->set_default_messaging_preferences

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of
"SetMessagingPreferencesFromDefaults"
       (grep -r 'SetMessagingPreferencesFromDefaults').
3. Observe no results in source code.

---- INTRANET ----
1. Login to intranet.
2. Go to Administration -> Patron categories -> Edit (for any category)
3. Scroll down to observe default messaging preferences for this patron
category
4. Observe the preferences, remember them for the next step.
5. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
6. Look at messaging preferences. They should be same as in step 4.
7. Fill in required data, do not modify messaging preferences, click Save.
8. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:20:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:20:33 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-4YCS8LBxmD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69443|0                           |1
        is obsolete|                            |

--- Comment #40 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69445&action=edit
Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults

This patch moves C4::Members::SetMessagingPreferencesFromDefaults to
Koha::Patron->set_default_messaging_preferences

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of
"SetMessagingPreferencesFromDefaults"
       (grep -r 'SetMessagingPreferencesFromDefaults').
3. Observe no results in source code.

---- INTRANET ----
1. Login to intranet.
2. Go to Administration -> Patron categories -> Edit (for any category)
3. Scroll down to observe default messaging preferences for this patron
category
4. Observe the preferences, remember them for the next step.
5. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
6. Look at messaging preferences. They should be same as in step 4.
7. Fill in required data, do not modify messaging preferences, click Save.
8. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:20:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:20:16 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-XsvDwCDfCa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69442|0                           |1
        is obsolete|                            |

--- Comment #39 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69444&action=edit
Bug 18595: Move C4::Members::Messaging::GetMessagingOptions

This patch moves C4::Members::GetMessagingOptions to
Koha::Patron::Message::Preferences->get_options.

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

This patch also removes previously unused GetMessagingOptions in
opac-messaging.pl

To test:

Make sure you have enabled the following system preferences:
- opacuserlogin
- EnhancedMessagingPreferences
- EnhancedMessagingPreferencesOPAC

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "GetMessagingOptions"
   (grep -r 'GetMessagingOptions').
3. Observe no results in source code.

---- OPAC ----
1. Login to OPAC.
2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl).
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.

---- INTRANET ----
1. Login to intranet.
2. Go to edit patron's details and scroll down to their messaging preferences.
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.
6. Go to Administration -> Patron categories -> Edit (for any category)
7. Scroll down to observe default messaging preferences for this patron
category
8. Observe the preferences looking normal and as they should be.
9. Set any combination of messaging preferences.
10. Observe them apply as expected, repeat step 9-10 as much as you like.
11. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
12. Fill in required data, do not modify messaging preferences, click Save.
13. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:21:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:21:03 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-eqyy39XaRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69441|0                           |1
        is obsolete|                            |

--- Comment #41 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69446&action=edit
Bug 18595: Unit tests for Koha::Patron::Categories->default_messaging

This patch adds unit tests for Koha::Patron::Categories->default_messaging.
Tests
will help preparing for moving C4::Members::Messaging to Koha-objects.

To test:
1. Run t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:21:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:21:14 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-YAks4GLjUn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69444|0                           |1
        is obsolete|                            |

--- Comment #42 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69447&action=edit
Bug 18595: Move C4::Members::Messaging::GetMessagingOptions

This patch moves C4::Members::GetMessagingOptions to
Koha::Patron::Message::Preferences->get_options.

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

This patch also removes previously unused GetMessagingOptions in
opac-messaging.pl

To test:

Make sure you have enabled the following system preferences:
- opacuserlogin
- EnhancedMessagingPreferences
- EnhancedMessagingPreferencesOPAC

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "GetMessagingOptions"
   (grep -r 'GetMessagingOptions').
3. Observe no results in source code.

---- OPAC ----
1. Login to OPAC.
2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl).
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.

---- INTRANET ----
1. Login to intranet.
2. Go to edit patron's details and scroll down to their messaging preferences.
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.
6. Go to Administration -> Patron categories -> Edit (for any category)
7. Scroll down to observe default messaging preferences for this patron
category
8. Observe the preferences looking normal and as they should be.
9. Set any combination of messaging preferences.
10. Observe them apply as expected, repeat step 9-10 as much as you like.
11. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
12. Fill in required data, do not modify messaging preferences, click Save.
13. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:21:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:21:26 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-iBd4QdREjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69445|0                           |1
        is obsolete|                            |

--- Comment #43 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69448&action=edit
Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults

This patch moves C4::Members::SetMessagingPreferencesFromDefaults to
Koha::Patron->set_default_messaging_preferences

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of
"SetMessagingPreferencesFromDefaults"
       (grep -r 'SetMessagingPreferencesFromDefaults').
3. Observe no results in source code.

---- INTRANET ----
1. Login to intranet.
2. Go to Administration -> Patron categories -> Edit (for any category)
3. Scroll down to observe default messaging preferences for this patron
category
4. Observe the preferences, remember them for the next step.
5. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
6. Look at messaging preferences. They should be same as in step 4.
7. Fill in required data, do not modify messaging preferences, click Save.
8. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:21:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:21:40 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-fqq5osWsdq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63818|0                           |1
        is obsolete|                            |

--- Comment #44 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69449&action=edit
Bug 18595: Unit tests preparing for GetMessagingPreferences move

This patch prepares removing GetMessagingPreferences by adding some useful unit
tests for subroutines that the move targets.

Reserves.t already covers print notice, but this patch adds tests for a set
transport type.

To test:
1. Run t/db_dependent/Circulation.t
2. Run t/db_dependent/Reserves.t
3. Observe test pass

Works together with followup patch
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:21:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:21:54 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-a7OrUxgy6d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63819|0                           |1
        is obsolete|                            |

--- Comment #45 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69450&action=edit
Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences

This patch moves C4::Members::Messaging::GetMessagingPreferences to
Koha::Patron::Message::Preference(s)
The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "GetMessagingPreferences"
       (grep -r 'GetMessagingPreferences').
3. Observe no results in source code.

---- UNIT TESTS ----
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Reserves.t
3. prove t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:22:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:22:06 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-g6EiYOjfuZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63827|0                           |1
        is obsolete|                            |

--- Comment #46 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69451&action=edit
Bug 18595: Move C4::Members::Messaging::SetMessagingPreference

This patch moves C4::Members::Messaging::SetMessagingPreference to
Koha::Patron::Message::Preference
The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "SetMessagingPreference"
       (grep -r 'SetMessagingPreference').
3. Observe no results in source code.

---- UNIT TESTS ----
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Reserves.t
3. prove t/db_dependent/Koha/Patron/Categories.t

Works as expected. QA tools fails with:
FAIL    C4/Members/Messaging.pm pod empty section in previous paragraph
Can be fixed in a followup.
Signed-off-by: Marc V?ron <veron at veron.ch>

QA tools pass now OK
Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:22:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:22:42 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-g8QUtOnTqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

--- Comment #48 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69453&action=edit
Bug 18595: Disable digest checkbox when forced on

To test:
1. Force a digest on via message_transports table
   (delete rows where message_attribute is 1 and is_digest is 0)
2. Go to either OPAC or staff client messaging preferences
3. Observe digest checkbox is disabled for message attribute 1
   (normally Item due row)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:22:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:22:27 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-surcnmVaif@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63828|0                           |1
        is obsolete|                            |
  Attachment #63829|0                           |1
        is obsolete|                            |

--- Comment #47 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69452&action=edit
Bug 18595: Remove references to C4::Members::Messaging

To test:
1. grep -r 'C4::Members::Messaging'
   This command should not produce any results in Koha source code after this
   patch.
2. Check the pages touched by this commit
3. Try setting and viewing patron and patron category messaging preferences

As this completes the move from C4::Members::Messaging to new Koha-objects for
messaging preferences, everything should be ready for proper testing.

Make sure you have EnhancedMessagingPreferences system preference enabled.
Then, try creating new categories and setting default messaging preferences,
as well as editing the messaging preferences of the already existing
categories.
Try adding new patrons and make sure the default patron messaging preferences
are by default the same that you set for that category. Edit already exisiting
patrons' messaging preferences and make sure changes are applied. Observe
no crash at any point, otherwise fail this patch. Don't forget to test both
intranet and OPAC.

Finally, run unit tests:
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Reserves.t
3. prove t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Marc V?ron <veron at veron.ch>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:24:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:24:07 +0000
Subject: [Koha-bugs] [Bug 19731] New: Notify when you add new item with
	reservations
Message-ID: <bug-19731-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19731

            Bug ID: 19731
           Summary: Notify when you add new item with reservations
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi,

It would be nice in Koha when you add a new item to have a notification or a
pop-uo when all the items for this record are on loan and there are
reservations for this record. That could be usefull to have this notification
for the person who has added the new item to be niticed that it should be put
on hold to satisfy reservations and not shelved with available status. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:24:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:24:18 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-YyUZL4IzPK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #49 from Lari Taskula <lari.taskula at jns.fi> ---
Rebased on updated Bug 17499 and added one more patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:43:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:43:12 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-9rH1u9ri8t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 17:52:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 16:52:23 +0000
Subject: [Koha-bugs] [Bug 19732] New: Koha does not work with latest
 versions of HTTP::OAI
Message-ID: <bug-19732-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19732

            Bug ID: 19732
           Summary: Koha does not work with latest versions of HTTP::OAI
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

With HTTP::OAI 4.x, any request to oai.pl will fail with the following error:

Can't locate object method "xslt" via package "Koha::OAI::Server::<package>" at
/home/koha/koha/Koha/OAI/Server/Repository.pm line 147.

libhttp-oai-perl 4.03 is included in Debian 9 (stretch) and Ubuntu 16.04 LTS
(xenial). It means that the OAI-PMH webservice does not work on stable
distributions (unless an older version is installed using cpan)

Koha should be updated to work with HTTP::OAI 4.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 18:45:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 17:45:57 +0000
Subject: [Koha-bugs] [Bug 17530] Don't show 'article request' link when no
 article requests are permitted
In-Reply-To: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17530-70-9UjlMOm4UX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 19:27:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 18:27:27 +0000
Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline
 circulation file, "  apply directly" option fails
In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16603-70-xi1BEz69HF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 19:27:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 18:27:30 +0000
Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline
 circulation file, "  apply directly" option fails
In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16603-70-bjKI41mpoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69454&action=edit
Bug 16603: When processing uploaded offline circulation file, "apply directly"
option fails

This patch is a temporary mitigation of whatever the real problem is.
The patch hides the "Apply directly" button so that the option isn't
available.

To test, apply the patch and generate a .koc file with some
transactions. Upload the file via Circulation -> Offline
circulation file upload. After the file is uploaded, you should see only
a "Add to offline circulation queue" button, which should work
correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 20:00:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 19:00:31 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-3g5aospvYr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 20:28:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 19:28:03 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-okTYwiuO3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 20:51:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 19:51:48 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-VdwTKkM6H0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #17 from David Bourgault <david.bourgault at inlibro.com> ---
Patch fails to apply; conflict on file mappings.yaml.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:00:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:00:03 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-fvLRJnymz3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #3 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Sorry,

prove t/db_dependent/OAI/Server.t
t/db_dependent/OAI/Server.t .. 1/29 Can't locate object method "xslt" via
package "Koha::OAI::Server::ListMetadataFormats" at
Koha/OAI/Server/Repository.pm line 147.
# Looks like your test exited with 2 just after 12.
t/db_dependent/OAI/Server.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 17/29 subtests 

Test Summary Report
-------------------
t/db_dependent/OAI/Server.t (Wstat: 512 Tests: 12 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 29 tests but ran 12.
Files=1, Tests=12, 72 wallclock secs ( 0.03 usr  0.01 sys +  1.27 cusr  0.10
csys =  1.41 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:12:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:12:20 +0000
Subject: [Koha-bugs] [Bug 8338] fines not cleared with dropbox mode
In-Reply-To: <bug-8338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8338-70-VehXSSf18P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:12:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:12:34 +0000
Subject: [Koha-bugs] [Bug 19733] New: Navigation in the pages result with
 cn_browser.pl is setting in a field
Message-ID: <bug-19733-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19733

            Bug ID: 19733
           Summary: Navigation in the pages result with cn_browser.pl is
                    setting in a field
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi, 

When cn_browser.pl is setting in a field and we edit a record for browse the
call number, we can't navigate between the pages results. It would be usefull
if this plugin could works like in the call numbers browser who we can navigate
in the pages result ass well with the arrow in the bottom of the page. Maybe we
could have this navigation arrows in the top and te bottom of the pages result. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:12:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:12:35 +0000
Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode
In-Reply-To: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13044-70-scrJWrpfF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:13:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:13:18 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-kYRKGbeaBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69404|0                           |1
        is obsolete|                            |

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69455&action=edit
Bug 19496: Fixing to_address for patron notes

This patch ensures the patron note to_address is the branch email or the
Koha Admin email, and the from_address is the patron's email.

To test:
1) Ensure syspref 'allowcheckoutnotes' is turned on
2) Go to OPAC, leave a note on a checkout
3) Confirm that the note is received (in mysql message_queue) but the
to_address is the patron's email - this is wrong
4) Apply patch and refresh OPAC
5) Leave a note on a checkout
6) Confirm that the note is received in message queue
7) Confirm that the to_address is one of:
- branch email
- branch reply to
- syspref ReplytoDefault
- syspref KohaAdminEmailAddress
8) Confirm that the from_address is one of:
- patron email
- patron emailpro
- patron B_email

Sponsored-by: Catalyst IT

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:13:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:13:16 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-AA5jBno2qz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:20:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:20:19 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-2a9yacWnp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69439|0                           |1
        is obsolete|                            |

--- Comment #2 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69456&action=edit
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC

To match every other page in the OPAC and ease CSS styling, there should be
links to current page on last breadcrumbs in lists pages.

Test plan:
1-Go to /cgi-bin/koha/opac-shelves.pl
2-Notice that there are no links on the last breadcrumb in every page (my
lists, public lists, create list, individual list page)
3-Apply patch
4-Reload page, and notice there are now links, pointing to current page (#)

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:20:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:20:32 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-d4lbFwrbvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:23:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:23:41 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-aOGTwmt9gL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:23:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:23:43 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-RKVX64aAfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69431|0                           |1
        is obsolete|                            |

--- Comment #2 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69457&action=edit
Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
We need to know the last modification time of the MARC record for some
features (like OAI-PMH parameters 'from' and 'until' for instance)

This patch only adds the missing column in biblio_metadata and
deletedbiblio_metadata

Test plan:
1. Run updatedatabase.pl
2. Verify that both tables have the new column, its value should be the
   greatest timestamp value from the corresponding biblio and
   biblioitems table entries
   You can verify with the following SQL query:
     SELECT b.biblionumber, b.timestamp as biblio_ts,
     bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts
     FROM biblio_metadata m
     LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber)
     LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber);

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:26:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:26:59 +0000
Subject: [Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios
In-Reply-To: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17387-70-6MxDCLojQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387

Tom Misilo <misilot at fit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |misilot at fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:27:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:27:58 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17499-70-tZ8enatu6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69435|0                           |1
        is obsolete|                            |

--- Comment #55 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69458&action=edit
Bug 17499: Add Koha-objects for messaging preferences

This patch adds Koha-objects for messaging preferences.

Adds simple validation for messaging preferences.

The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference

Adds a method for getting available messaging options.

Adds a method for setting default messaging preferenes.
  $patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
  ...or...
  Koha::Patron::Message::Preference->new_from_default({
    borrowernumber => 123,
    categorycode => "ABC",
    message_attribute_id => 1,
  });

Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
  $preference->message_transport_types                              (for
getting)
  $preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
  (also supports other calling conventions, see documentation for more)

Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.

Includes test coverage for basic usage.

To test:
1. prove t/db_dependent/Koha/Patron/Message/*

Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 21:28:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 20:28:13 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17499-70-RZbNiTQAVO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m
             Status|Needs Signoff               |Signed Off

--- Comment #56 from Dominic Pichette <dominic.pichette at inlibro.com> ---
prove t/db_dependent/Koha/Patron/Message/*
t/db_dependent/Koha/Patron/Message/Attributes.t ............. ok   
t/db_dependent/Koha/Patron/Message/Preferences.t ............ ok   
t/db_dependent/Koha/Patron/Message/Transport/Preferences.t .. ok   
t/db_dependent/Koha/Patron/Message/Transport/Types.t ........ ok   
t/db_dependent/Koha/Patron/Message/Transports.t ............. ok   
All tests successful.
Files=5, Tests=15,  9 wallclock secs ( 0.07 usr  0.01 sys +  5.05 cusr  0.20
csys =  5.33 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:02:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:02:56 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-IItivuKzla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69324|0                           |1
        is obsolete|                            |

--- Comment #20 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69459&action=edit
Bug 18308 - Added warning and dialog alert

Works great if you apply bug 19514 before

If an institution has a minPasswordLength which is < 8 characters then a
warning
will be set (which is visible in the intranet-error.log) and a dialog
alert div will display the warning to the user in the memberentry.pl
page in the intranet.

Test plan:
1. Ensure that your minPasswordLength is set to less than 8 characters.
This replicates the use case that a Koha instance is existing (i.e. not
a new Koha instance) and not gone through the password length step of
the onboarding tool (previous patch on this bug report) or that the
institituion is new but set a password length of less than 8 in the
onboarding tool

2. Go to the memberentry.pl page and notice that there is no warning
at the top of the page informing you that your minPasswordLength is less
than 8

3. Apply this patch

4. Refresh the memberentry.pl page and notice that there is a yellow
warning at the top of the page informing you that your minPasswordLength
syspref is less than 8

Sponsored-By: Catalyst IT
Signed-off-by: Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:03:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:03:43 +0000
Subject: [Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios
In-Reply-To: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17387-70-5m6vyF9COf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

--- Comment #1 from George Williams (NEKLS) <george at nekls.org> ---
This is a great idea.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:04:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:04:02 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-UbSvq2jWio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:09:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:09:35 +0000
Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV
	output
In-Reply-To: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19716-70-XFRsyVDqmR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:09:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:09:37 +0000
Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV
	output
In-Reply-To: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19716-70-4uNFJfRPor@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69424|0                           |1
        is obsolete|                            |

--- Comment #2 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69460&action=edit
Bug 19716 - Add option to send header line for CSV output

Currently, if outputting a CSV file using runreport.pl, you need to look at the
report used to know what each column means. It would be nice if we could
include column headers.

Test Plan:
1) Apply this patch
2) Try using runreport.pl with --format csv --csv-header

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:11:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:11:07 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-RNCMd5We0C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #2 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Could you be more specific please? Which pages should we test for? Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:24:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:24:07 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-9BI0GmLecj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69323|0                           |1
        is obsolete|                            |

--- Comment #21 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69461&action=edit
Bug 18308 - Added step to onboarding tool to set minPasswordLength

This patch increases the default minPasswordLength syspref value to 8
characters, for new installations.

The final (6th step) of the onboarding tool is now a password length
page where the default value of 8 can be altered. There is a security warning
in red recommending to the user they
keep the minimum length of the password at 8 characters or more.

This patch also removes the atomicupdate .sql file to be run in an update to
alter the default
minPasswordLength value for existing Koha installations, based on tester
feedback.

Test plan:
1. Create a patron with a password less than 3 characters in length and
notice that a red message is displayed by the input telling you that the
password must be 3 characters minimum length

2. Query the database "select value from systempreferences where
variable="minPasswordLength"; and notice the value is 3

3. Drop and recreate your database and restart memcached

4. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to create a circulation rule

5. Apply patch

6. Repeat step 3

7. Go through the web installer and onboarding tool. Noticing the last
step of the onboarding tool is to set the minimum password length, the
numerical input element has a default value of 8 and notice that it will
go below 3

8. Repeat step 2 and notice the value is 8

9. In the onboarding tool change the minimum password length value to 7
and submit the form

10. Notice the completed page of the onboarding tool is displayed with
the message that the minimum password length has been set.

11. Repeat step 2 and notice the value is now 7.

12. Try to create a patron in Intranet and OPAC with a password less
than 7 characters and notice that a red message is displayed by the
input telling you that the password must be 7 characters minimum length

Sponsored-By: Catalyst IT

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:24:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:24:11 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-pYd1BqASNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69459|0                           |1
        is obsolete|                            |

--- Comment #22 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69462&action=edit
Bug 18308 - Added warning and dialog alert

Works great if you apply bug 19514 before

If an institution has a minPasswordLength which is < 8 characters then a
warning
will be set (which is visible in the intranet-error.log) and a dialog
alert div will display the warning to the user in the memberentry.pl
page in the intranet.

Test plan:
1. Ensure that your minPasswordLength is set to less than 8 characters.
This replicates the use case that a Koha instance is existing (i.e. not
a new Koha instance) and not gone through the password length step of
the onboarding tool (previous patch on this bug report) or that the
institituion is new but set a password length of less than 8 in the
onboarding tool

2. Go to the memberentry.pl page and notice that there is no warning
at the top of the page informing you that your minPasswordLength is less
than 8

3. Apply this patch

4. Refresh the memberentry.pl page and notice that there is a yellow
warning at the top of the page informing you that your minPasswordLength
syspref is less than 8

Sponsored-By: Catalyst IT
Signed-off-by: Dominic Pichette <dominic at inlibro.com>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:50:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:50:39 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-QSvqvOHzA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

--- Comment #5 from David Bourgault <david.bourgault at inlibro.com> ---
So this fails for me.

I get failed test messages that look like this:

    #   Failed test 'exact match for JSON Pointer "/0/firstname"'
    #   at t/db_dependent/Koha/REST/Plugin/Objects.t line 168.
    #          got: 'Emmanuel'
    #     expected: 'Manuel'


But I also get this error at the beginning of the prove command:

t/db_dependent/Koha/REST/Plugin/Objects.t .. DBD::mysql::st execute failed:
Cannot delete or update a parent row: a foreign key constraint fails
(`koha_master_dev_inlibro`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE)
[for Statement "DELETE FROM `borrowers`"] at
/usr/local/share/perl/5.22.1/DBIx/Class/Storage/DBI.pm line 1836.
No method delete found for Koha::Patrons
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot delete or update a parent
row: a foreign key constraint fails (`koha_master_dev_inlibro`.`issues`,
CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES
`borrowers` (`borrowernumber`) ON UPDATE CASCADE) at
/inlibro/git/koha-master-dev-inlibro/Koha/Objects.pm line 388
 at t/db_dependent/Koha/REST/Plugin/Objects.t line 76.

Is this a patch error or could it be a DB error?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:55:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:55:41 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-zjRUyLLbRl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:55:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:55:44 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-xKolKljOMC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69315|0                           |1
        is obsolete|                            |

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69463&action=edit
Bug 19686: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:56:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:56:21 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-XcvgVShOxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69316|0                           |1
        is obsolete|                            |

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69464&action=edit
Bug 19686: Add objects.search a 'to_model' param

This patch introduces a new parameter to the objects.search Mojo helper.
The idea behind this, is that if there's any attribute name mapping
between the DB objects and the API exposed ones, we should be able to
pass it to objects.search so the filtering query params are mapped
correctly for building the DBIC query, like this example:

  my $patrons_set = Koha::Patrons->new;
  my @patrons = $c->objects->search( $patrons_set,
                                     \&to_model
                                    )->as_list;
  # and probably
  @patrons = map {to_api($_)} @patrons;

The to_model function needs to avoid autovivification, to prevent
messing with the query parameters (undef params).

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass! Params get mapped!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  1 22:58:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Dec 2017 21:58:18 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-fxbLZclFAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
My bad. I tested again with a fresh BD and it worked.

Test passed, QA tool green.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:10:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:10:00 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-cNZlqroDvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
This error is caused by a too recent version of HTTP::OAI. See bug 19732
Quick fix: sudo cpanm
https://cpan.metacpan.org/authors/id/T/TI/TIMBRODY/HTTP-OAI-3.28.tar.gz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:12:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:12:02 +0000
Subject: [Koha-bugs] [Bug 6429] Updating development team in about
In-Reply-To: <bug-6429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6429-70-TYKIzL72OX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6429

kontol <rabbitcyber2 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rabbitcyber2 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:12:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:12:12 +0000
Subject: [Koha-bugs] [Bug 19734] New: Hacked By Kuchiku Bandung Ngen7ot
	Security Team
Message-ID: <bug-19734-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19734

            Bug ID: 19734
           Summary: Hacked By Kuchiku Bandung Ngen7ot Security Team
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rabbitcyber2 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hacked By Kuchiku
Bandung Ngen7ot Security Team

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:49:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:49:57 +0000
Subject: [Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid
 'a' char in label pos.9
In-Reply-To: <bug-18152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18152-70-BJJNyrkU84@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152

Frederique Couffignal <fcouffignal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fcouffignal at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:56:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:56:37 +0000
Subject: [Koha-bugs] [Bug 19735] New: Move Perl deps definitions into a
	cpanfile
Message-ID: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

            Bug ID: 19735
           Summary: Move Perl deps definitions into a cpanfile
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

cpanfile is a format for describing CPAN dependencies for Perl applications.
It is more concise - thus easier to read and maintain - than
C4::Installer::PerlDependencies, and allows to describe requirements more
accurately (using version ranges or features for instance).
Additionally it can be read by tools such as cpanm or carton for an easy way to
install dependencies on non-Debian-based systems.

For more information on cpanfile, see
http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:58:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:58:15 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-DyTOHufTZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69465&action=edit
Bug 19735: Script to generate cpanfile (DO NOT PUSH)

For testing purposes only

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:58:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:58:18 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-pQMpqPiqAK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69466&action=edit
Bug 19735: Move Perl deps definitions into a cpanfile

cpanfile is a format for describing CPAN dependencies for Perl
applications.
It is more concise - thus easier to read and maintain - than
C4::Installer::PerlDependencies, and allows to describe requirements
more accurately (using version ranges or features for instance)
Additionally it can be read by tools such as cpanm or carton for an
easy way to install dependencies on non-Debian-based systems.

For more information on cpanfile, see
http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod

This patch replace C4::Installer::PerlDependencies by an equivalent
cpanfile and update all scripts/modules that were using PerlDependencies
It also removes dead code from C4::Installer::PerlModules (some
subroutines were not used at all, except in unit tests)

Added dependencies:
 - Module::CPANfile
 - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent
   version than the one Module::CPANfile requires)

Test plan:
  1. Go to About page, tab Perl modules and keep this browser tab open
  2. Apply patch
  3. Install Module::CPANfile and CPAN::Meta
    a. On Debian-based systems:
       # will install libcpan-meta-perl as a dependency
       sudo apt install libmodule-cpanfile-perl
    b. Others:
       # will install CPAN::Meta as a dependency
       sudo cpanm Module::CPANfile
  4. In a new browser tab, go to About page, tab Perl modules and compare
     the table with the one in the previous browser tab
     They should be identical, except for newly added dependencies
     (Module::CPANfile and CPAN::Meta)
  5. Do a 'standard' install
    a. perl Makefile.PL (select 'standard')
    b. make
    c. sudo make install
    d. Configure your database, web server, ... and go through the web
       install process
  6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which
     should be /usr/share/koha/lib)
  7. Go to the about page of this fresh install and compare it with your
     dev install
  8. Verify that debian/list-deps still works
     This takes a lot of time and it may not be necessary to wait until
     the end. If you see some Debian package names that correspond to
     modules in cpanfile, it means it still works
     (you need apt-file for this script to work)
  9. Verify that koha_perl_deps.pl still works
 10. prove t/Installer_pm.t t/Installer_PerlModules.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 09:58:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 08:58:52 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-s0jjO3fuDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 17:16:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 16:16:24 +0000
Subject: [Koha-bugs] [Bug 19736] New: Add a digest option forAUTO_RENEWALS
	Notice
Message-ID: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19736

            Bug ID: 19736
           Summary: Add a digest option forAUTO_RENEWALS Notice
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: karen at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

I'm working with a library that would like to send the auto-renewal notice as a
digest. As I understand it, a notice is sent per item that auto-renews. An
issue for this library is that they have patrons who checkout up to 50
children's books and they don't want their patron to receive 50 notices at
once. A digest option for the auto-renewals notice would be a great customer
experience enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 17:16:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 16:16:39 +0000
Subject: [Koha-bugs] [Bug 19736] Add a digest option for AUTO_RENEWALS Notice
In-Reply-To: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19736-70-Qdu0WeoIIH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19736

Karen <karen at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add a digest option         |Add a digest option for
                   |forAUTO_RENEWALS Notice     |AUTO_RENEWALS Notice

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  2 19:03:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 18:03:17 +0000
Subject: [Koha-bugs] [Bug 13644] Paging Javascript breaks links with anchor
In-Reply-To: <bug-13644-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13644-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13644-70-kQIgpTGqe6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13644

J. Kramer <gandaro at is-a-lie.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gandaro at is-a-lie.de
           Assignee|koha-bugs at lists.koha-commun |gandaro at is-a-lie.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 00:30:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 23:30:11 +0000
Subject: [Koha-bugs] [Bug 19727] Editing call number in bibliographic record
 don' t follow in the item record
In-Reply-To: <bug-19727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19727-70-nA8PGY3S6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19727

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree with Owen, this behaviour is not standard and could only be added as
optional. For example in a lot of our libraries the item callnumber is unique
per item and there is only a base callnumber in the bibliographic record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 00:38:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Dec 2017 23:38:57 +0000
Subject: [Koha-bugs] [Bug 19734] SPAM
In-Reply-To: <bug-19734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19734-70-omKyKg548q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19734

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|Hacked By Kuchiku Bandung   |SPAM
                   |Ngen7ot Security Team       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 10:26:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 09:26:14 +0000
Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for
	patrons
In-Reply-To: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18626-70-TO5wDnZBQS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63560|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69467&action=edit
Bug 18626 - Add ability to track cardnumber changes for patrons

Some libraries want to keep a history of cardnumber changes for a
patron. This is a feature that another ILS has.

Test Plan:
1) Apply this patch
2) Enable the BorrowersLog
3) Modify a patron, update his or her cardnumber
4) Notice the entry in the action log containing the old and new cardnumbers
5) Edit a patron, leave the cardnumber the same
6) Note there is no cardnumber change entry in the action logs
7) Disable BorrowersLog, modify a patron cardnumber
8) Note there is no cardnumber change entry in teh action logs

Followed test plan, works as expected
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 10:26:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 09:26:11 +0000
Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for
	patrons
In-Reply-To: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18626-70-2SsJm6nkoX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 10:27:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 09:27:25 +0000
Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for
	patrons
In-Reply-To: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18626-70-RxoZdnoEH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 11:39:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 10:39:42 +0000
Subject: [Koha-bugs] [Bug 16117] Log borrower cardnumbers and item barcodes
 which are not valid
In-Reply-To: <bug-16117-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16117-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16117-70-pmwaNxuQQ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16117

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #4)
> Just a thought:
>   Koha::Statistics->invalid_item( { item => $barcode } );
> sounds like it will return something, not it will actually write.
> 
> I would suggest to rename the method with something more meaningful.
> Waiting for another QA opinion.

I agree, something like "log_invalid_item" or similar would be better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 20:49:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 19:49:42 +0000
Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change
 tool displayed after running Koha update
In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18645-70-lZF7XdPKhD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68154|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 20:50:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 19:50:06 +0000
Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change
 tool displayed after running Koha update
In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18645-70-MTwdNLbhvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

--- Comment #15 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69470&action=edit
Bug 18645 -Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

The administrator also has the ability to skip the feature release tool on the
update
process and it will be displayed to the next superlibrarian user that
logs in. Because librarian staff are likely to be more familiar with the
system preference settings that a library would want to set than an IT
support administrator

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.120033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the
'Update database structure' page you are prompted to login and the main
page appears if you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1 and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. Notice there is also a skip button. Click the skip button and notice
you are redirected to the staff intranet login page.

8. Login with the Koha db administrator credentials and notice that the
Koha main page is displayed

9. Logout and enter superlibrarian user credentials and submit the login
form

10. Notice you are redirected to the Koha web installer login page

11. Login with the Koha db administrator credentials

12. Notice the feature release change tool is displayed

13. Alter the NumSavedReports and the
TalkingTechItivaPhoneNotification values and select the 'Save all
preferences' button

14. Query the values of these two sysprefs in the systempreferences
database table and notice they have been changed to what you submitted

15. Click the 'Log into Koha staff intranet' button

16. Notice the intranet login page appears

17. Login and the main page will be displayed

18. Repeat steps 1,2 and click the 'Continue to feature release tool'
button

19. Notice the feature release tool is displayed and repeat steps 13 and
14

20. Click the 'Log into Koha staff intranet' button, login as either
Koha db administrator or as a superlibrarian (it doesn't matter which
you log in as) and the Koha staff intranet mainpage will be displayed

21. Log out and then log back in again and notice the staff intranet is
still displayed. Note you are not redirected to the Koha web installer
login page to go through the feature release change tool because you
have already gone through it

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 21:56:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 20:56:50 +0000
Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change
 tool displayed after running Koha update
In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18645-70-2XI7lV3Xdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69470|0                           |1
        is obsolete|                            |

--- Comment #16 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69471&action=edit
Bug 18645 -Koha feature release change tool

This tool is displayed at the end of the update process to display all
the new system preferences added during the update so that the
administrator can view and modify their default values if neccessary

The administrator also has the ability to skip the feature release tool on the
update
process and it will be displayed to the next superlibrarian user that
logs in. Because librarian staff are likely to be more familiar with the
system preference settings that a library would want to set than an IT
support administrator

Test plan:
1. Go to Administrator->global system preferences->Local use

2. Set the version number to 16.120033 (Note: only 1 decimal place) and
save

3. Go through the update process and notice that after submitting the
'Update database structure' page you are prompted to login and the main
page appears if you logged in with the correct credentials

4. Apply patch

5. Repeat steps 1 and 2

6. Notice the button text on the 'Update database structure' page has
changed and now it says 'Continue to feature release tool'

7. Notice there is also a skip button. Click the skip button and notice
you are redirected to the staff intranet login page.

8. Login with the Koha db administrator credentials and notice that the
Koha main page is displayed

9. Logout and enter superlibrarian user credentials and submit the login
form

10. Notice you are redirected to the Koha web installer login page

11. Login with the Koha db administrator credentials

12. Notice the feature release change tool is displayed

13. Alter the NumSavedReports and the
TalkingTechItivaPhoneNotification values and select the 'Save all
preferences' button

14. Query the values of these two sysprefs in the systempreferences
database table and notice they have been changed to what you submitted

15. Click the 'Log into Koha staff intranet' button

16. Notice the intranet login page appears

17. Login and the main page will be displayed

18. Repeat steps 1,2 and click the 'Continue to feature release tool'
button

19. Notice the feature release tool is displayed and repeat steps 13 and
14

20. Click the 'Log into Koha staff intranet' button, login as either
Koha db administrator or as a superlibrarian (it doesn't matter which
you log in as) and the Koha staff intranet mainpage will be displayed

21. Log out and then log back in again and notice the staff intranet is
still displayed. Note you are not redirected to the Koha web installer
login page to go through the feature release change tool because you
have already gone through it

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 23:16:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 22:16:39 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-Ty1Y3HjJUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #13 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(Reply to David Bourgault in comment 12)

Yes I would have thought the serials.pref file would be the most suitable YAML
file to be updated. 

I think I was wrong in comment 10.

Can you please add a patch to add SortIgnoreArticles to serials.pref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 23:21:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 22:21:52 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-wSvaYCYmmj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As this now not only works for Serials, but for datatables in general, I think
maybe it would better fit on the 'staff client' tab? Hope I didn't
misunderstand the change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec  3 23:44:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 03 Dec 2017 22:44:52 +0000
Subject: [Koha-bugs] [Bug 17171] Add a syspref to allow currently issued
 items to be issued to a new patron without staff confirmation
In-Reply-To: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17171-70-KnfCb8rsbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |josef.moravec at gmail.com

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
The file cash_register_stats.tt is edited probably by accident - it should be
removed from this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 01:59:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 00:59:10 +0000
Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible
In-Reply-To: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7047-70-K1KD0ayvji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047

--- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69474&action=edit
Bug 7047 - Storing subscription renewal note in suggestion to be displayed on
the suggestion page.

Additionally I have added a library input field in case the librarian wants to
set a library branch whilst renewing a subscription. With the use case being
they may have ommitted to set the branchcode whilst creating the subscription.

Test plan:
1. Create a subscription (if one does not already exist)

2. Set the RenewSerialAddsSuggestion syspref to 'Add'

3. Renew the item making sure to write in a value into the note field

3. Visit the suggestions page and notice that the note is not displayed
for the newly created suggestion

4. Apply patch

5. Repeat step 3. Notice that there is now a new branchcode dropdown
box. Select one of your libraries and write in the value into the note
field

6. Visit suggestions and notice there is now a 'Suggestion note' column
in the table containing the note.

Also note that the suggestion has the correct branchcode associated with
it

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 01:59:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 00:59:21 +0000
Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible
In-Reply-To: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7047-70-UFZKIlDCFe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 02:10:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 01:10:33 +0000
Subject: [Koha-bugs] [Bug 16688] RenewSerialAddsSuggestion - suggestions not
 showing up, note not saved
In-Reply-To: <bug-16688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16688-70-wINMwdMain@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16688

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Katrin

The later part of this bug (the note information being lost) is fixed by the
patch I have just written for bug 7047.

The only workaround I found for seeing the suggestions was to log in as a
superlibrarian and set the IndependentBranches syspref to 'Yes' and then all
sysprefs were displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 02:11:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 01:11:02 +0000
Subject: [Koha-bugs] [Bug 16688] RenewSerialAddsSuggestion - suggestions not
 showing up, note not saved
In-Reply-To: <bug-16688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16688-70-ITQBEgwABE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16688

--- Comment #2 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
opps that should be all suggestions are displayed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 05:47:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 04:47:26 +0000
Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and
	renewal limits
In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18450-70-ZFwhmDxugp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #19 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69475&action=edit
Bug 18450 - Followup - Implemented 'IF A OR B OR C {stuff}" for checking what
to display

Implemented a conditional checking if the item that the patron is trying
to renew has more than 1 copy available which can be renewed. This means
the AllowRebnewalIfOtherItemsAvailable system preference is now
appropriately implemented.

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.

2. Place a hold on an item

3. Checkout the item out to a different patron

4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning

5. Click the 'Override and renew' button and notice that you
can bypass the hold

6. Apply patch

7. Try to renew an item (with item level hold on it) which belongs to a biblio
with either only one
item or a biblio with multiple items all of which have holds on them.
Notice the only button in the yellow message box displayed is
'Continue without renewing'

8. Repeat step 7 but change the hold to a 'Next available' hold rather
than an item level hold. Again notice only the 'Continue without
renewing' button is displayed

9. Try to renew an item (with item level hold on it) which belongs to a
biblio with mutliple aviable items of it in the catalogue. Notice only
the 'Continue without renewing' button is displayed

10. Repeat step 9 but change the hold to a 'Next available' hold rather
than an item level hold. Notice only the 'Continue without renewing'
button is displayed

11. Set both AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable systempreferences to 'Allow' and
repeat step 7 notice only the 'Continue without renewing' button is
displayed in the yellow message box

12. Repeat step 8 and notice only the 'Continue without renewing' button
is displayed

13. Repeat step 9 and notice only the 'Continue without renewing' button
is displayed

14. Repeat step 10 and notice the item is immediately renewed and the
yellow message box is not displayed

15. Set the AllowRenewalIfOtheritemsAvailable to 'Dont' Allow' and
repeat step 7 and notice that both the 'Override and renew' and 'Continue
without renewal' buttons are
displayed

16. Repeat step 8 and notice both buttons are displayed

17. Repeat step 9 and notice both buttons are displayed

18. Repeat step 10 and notice both buttons are displayed

19. Set AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride syspref to 'Dont' Allow' and repeat step 7 and
notice only the 'Continue without renewal' button is displayed

20. Repeat step 8 and notice only 'Continue without renewal' button is
displayed

21. Repeat step 9 and notice only the 'Continue without renewal' button
is displayed

22. Repeat step 10 and notice both buttons are displayed

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 05:47:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 04:47:58 +0000
Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and
	renewal limits
In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18450-70-SB4GyPjErR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69475|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 05:48:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 04:48:12 +0000
Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and
	renewal limits
In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18450-70-YFWLYN8RWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #20 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69476&action=edit
Bug 18450 - Followup -  Implemented a conditional checking if the item that the
patron is trying to renew has more than 1 copy available which can be renewed.
This means the AllowRebnewalIfOtherItemsAvailable system preference is now
appropriately impleme

In order to make the conditional statement work correctly checking three
conditions each time (two system preferences and the value of the
can_renew variable I had to implement a elsif statement. I spent a large
amount of time trying to get a single IF statement to check the three
conditions in three different combinations but it ignored the value of
the can_renew variable each time and so I was forced to split it out
into an If and ELSIF

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.

2. Place a hold on an item

3. Checkout the item out to a different patron

4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning

5. Click the 'Override and renew' button and notice that you
can bypass the hold

6. Apply patch

7. Try to renew an item (with item level hold on it) which belongs to a biblio
with either only one
item or a biblio with multiple items all of which have holds on them.
Notice the only button in the yellow message box displayed is
'Continue without renewing'

8. Repeat step 7 but change the hold to a 'Next available' hold rather
than an item level hold. Again notice only the 'Continue without
renewing' button is displayed

9. Try to renew an item (with item level hold on it) which belongs to a
biblio with mutliple aviable items of it in the catalogue. Notice only
the 'Continue without renewing' button is displayed

10. Repeat step 9 but change the hold to a 'Next available' hold rather
than an item level hold. Notice only the 'Continue without renewing'
button is displayed

11. Set both AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable systempreferences to 'Allow' and
repeat step 7 notice only the 'Continue without renewing' button is
displayed in the yellow message box

12. Repeat step 8 and notice only the 'Continue without renewing' button
is displayed

13. Repeat step 9 and notice only the 'Continue without renewing' button
is displayed

14. Repeat step 10 and notice the item is immediately renewed and the
yellow message box is not displayed

15. Set the AllowRenewalIfOtheritemsAvailable to 'Dont' Allow' and
repeat step 7 and notice that both the 'Override and renew' and 'Continue
without renewal' buttons are
displayed

16. Repeat step 8 and notice both buttons are displayed

17. Repeat step 9 and notice both buttons are displayed

18. Repeat step 10 and notice both buttons are displayed

19. Set AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride syspref to 'Dont' Allow' and repeat step 7 and
notice only the 'Continue without renewal' button is displayed

20. Repeat step 8 and notice only 'Continue without renewal' button is
displayed

21. Repeat step 9 and notice only the 'Continue without renewal' button
is displayed

22. Repeat step 10 and notice both buttons are displayed

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 05:48:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 04:48:24 +0000
Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and
	renewal limits
In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18450-70-YNwGv2NobF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 08:54:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 07:54:42 +0000
Subject: [Koha-bugs] [Bug 19688] OpacHiddenItems itype problems
In-Reply-To: <bug-19688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19688-70-DhPLnmwgzC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19688

DEVINIM <kohadevinim at devinim.com.tr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
           Priority|P5 - low                    |P2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 09:08:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 08:08:54 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-4Vye3SYJk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
*** Bug 19555 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 09:08:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 08:08:54 +0000
Subject: [Koha-bugs] [Bug 19555] Some changes to records are not reflected
	in OAI-PMH
In-Reply-To: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19555-70-seGJhcYu5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19555

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #8 from Magnus Enger <magnus at libriotech.no> ---


*** This bug has been marked as a duplicate of bug 19724 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 09:59:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 08:59:16 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-lAQg10FwdZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Be careful that TT cache should not be enabled with Plack.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:03:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:03:14 +0000
Subject: [Koha-bugs] [Bug 19739] New: Add default ES configuration to
	koha-conf.xml
Message-ID: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739

            Bug ID: 19739
           Summary: Add default ES configuration to koha-conf.xml
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Bug 18571 added default ES configuration for packaging config.
Add it also to dev install in koha-conf.xml.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:03:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:03:23 +0000
Subject: [Koha-bugs] [Bug 19739] Add default ES configuration to
	koha-conf.xml
In-Reply-To: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19739-70-ZVFcVQda2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18571
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571
[Bug 18571] koha-conf.xml should include ES entry
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:03:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:03:34 +0000
Subject: [Koha-bugs] [Bug 19739] Add default ES configuration to
	koha-conf.xml
In-Reply-To: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19739-70-yHoLwrLnMK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:03:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:03:23 +0000
Subject: [Koha-bugs] [Bug 18571] koha-conf.xml should include ES entry
In-Reply-To: <bug-18571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18571-70-lO44QcIt9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18571

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19739


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739
[Bug 19739] Add default ES configuration to koha-conf.xml
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:14:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:14:22 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-Te1TUmORFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Fridolin SOMERS from comment #15)
> Be careful that TT cache should not be enabled with Plack.

See IRC discussion.
If possible, please report specific problems on using both. At this time its
use is still recommended..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:15:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:15:05 +0000
Subject: [Koha-bugs] [Bug 19739] Add default ES configuration to
	koha-conf.xml
In-Reply-To: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19739-70-HkSI9YX35M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:15:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:15:07 +0000
Subject: [Koha-bugs] [Bug 19739] Add default ES configuration to
	koha-conf.xml
In-Reply-To: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19739-70-pUKULOyzoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 69477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69477&action=edit
Bug 19739: Add default ES configuration to koha-conf.xml

Bug 18571 added default ES configuration for packaging config.

This patch adds it to dev install in koha-conf.xml.
Database name is used in index_name to allow multiple installs.

Test plan :
- Run dev install
- Install ElasticSearch server and Koha deps
- Enable ElasticSearch in Koha
- Check indexing and searching works directly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 10:34:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 09:34:23 +0000
Subject: [Koha-bugs] [Bug 19740] New: Self checks calculating wrong due
 dates / configuration changes go unnoticed
Message-ID: <bug-19740-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19740

            Bug ID: 19740
           Summary: Self checks calculating wrong due dates  /
                    configuration changes go unnoticed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

When using a self check via SIP2 a calendar change will take no effect
resulting in due dates being calculated differently for self checks than on the
circulation desk. The calculation will remain false until the SIP server is
restarted. 

This also seems to apply to system preference changes, which happen less often.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 11:18:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 10:18:14 +0000
Subject: [Koha-bugs] [Bug 19732] Koha does not work with latest versions of
	HTTP::OAI
In-Reply-To: <bug-19732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19732-70-6voXDakzOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19732

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it
           Priority|P5 - low                    |P1 - high
           Severity|normal                      |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 11:32:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 10:32:09 +0000
Subject: [Koha-bugs] [Bug 17624] Add Staff Collection status for items in
	C4::XSLT
In-Reply-To: <bug-17624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17624-70-Bo2vB0CQJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 11:32:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 10:32:22 +0000
Subject: [Koha-bugs] [Bug 17624] Add Staff Collection status for items in
	C4::XSLT
In-Reply-To: <bug-17624-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17624-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17624-70-LHu2dnyHYl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17624

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 11:58:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 10:58:19 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-bQRj3m2kXv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69457|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69478&action=edit
Bug 19724: Add timestamp to biblio_metadata and deletedbiblio_metadata

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
We need to know the last modification time of the MARC record for some
features (like OAI-PMH parameters 'from' and 'until' for instance)

This patch only adds the missing column in biblio_metadata and
deletedbiblio_metadata

Test plan:
1. Run updatedatabase.pl
2. Verify that both tables have the new column, its value should be the
   greatest timestamp value from the corresponding biblio and
   biblioitems table entries
   You can verify with the following SQL query:
     SELECT b.biblionumber, b.timestamp as biblio_ts,
     bi.timestamp as biblioitems_ts, m.timestamp as biblio_metadata_ts
     FROM biblio_metadata m
     LEFT JOIN biblioitems bi ON (bi.biblionumber = m.biblionumber)
     LEFT JOIN biblio b ON (b.biblionumber = m.biblionumber);

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 11:58:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 10:58:16 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-6xR89SUi9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 11:59:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 10:59:48 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-EKPNrslQ2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 12:02:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 11:02:19 +0000
Subject: [Koha-bugs] [Bug 19739] Add default ES configuration to
	koha-conf.xml
In-Reply-To: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19739-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19739-70-AWI3BQtAtv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19739

claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 12:08:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 11:08:13 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-J8sJkHt5Ah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
QA Comment: the function GREATEST is not "standard" but is widely implemented,
so no problem here in my opinion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 13:56:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 12:56:34 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-jWh4TEiohv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69314|0                           |1
        is obsolete|                            |

--- Comment #18 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69479&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:13:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:13:09 +0000
Subject: [Koha-bugs] [Bug 18188] Should we rename items.booksellerid to
	items.acqsource ?
In-Reply-To: <bug-18188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18188-70-XBHYqaYRXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188
Bug 18188 depends on bug 18187, which changed state.

Bug 18187 Summary: finishreceive.pl: Save bookseller name into items acquisition source field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:13:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:13:09 +0000
Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into
 items acquisition source field
In-Reply-To: <bug-18187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18187-70-UBEsbzOjqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:13:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:13:20 +0000
Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into
 items acquisition source field
In-Reply-To: <bug-18187-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18187-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18187-70-SDc6eLlWNB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:18:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:18:06 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-JvQpwUhwdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #19 from David Gustafsson <glasklas at gmail.com> ---
Ok! Rebased against master. There was a commit in between setting the "sort"
for serveral fields, those changes should now be merged in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:20:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:20:13 +0000
Subject: [Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio
In-Reply-To: <bug-18923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18923-70-3oSH6BbkLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Not backported?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:22:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:22:45 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-Dx7lRWTqzA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #20 from David Gustafsson <glasklas at gmail.com> ---
Reviewing the commit-diff once again, I think I made an error in the merge.
Will upload again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:50:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:50:55 +0000
Subject: [Koha-bugs] [Bug 18937] Limit the number of entries to print for
	larger lists
In-Reply-To: <bug-18937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18937-70-n63IGWtuW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:51:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:51:03 +0000
Subject: [Koha-bugs] [Bug 18937] Limit the number of entries to print for
	larger lists
In-Reply-To: <bug-18937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18937-70-wwDeua0mWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:51:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:51:59 +0000
Subject: [Koha-bugs] [Bug 18937] Limit the number of entries to print for
	larger lists
In-Reply-To: <bug-18937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18937-70-RwntqFm0Nw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18937

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65533|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:52:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:52:04 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-6KoYjMwHjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69479|0                           |1
        is obsolete|                            |

--- Comment #21 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69480&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:53:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:53:49 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-CzlY613DBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #22 from David Gustafsson <glasklas at gmail.com> ---
Think git auto-merged some stuff incorrectly, but this should now be sorted
out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 14:59:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 13:59:19 +0000
Subject: [Koha-bugs] [Bug 19741] New: parcel.pl only shows holds on items in
 received orders, we should (also) count holds on the title
Message-ID: <bug-19741-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19741

            Bug ID: 19741
           Summary: parcel.pl only shows holds on items in received
                    orders, we should (also) count holds on the title
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On parcel.pl we show a count of holds on a bib for pending orders, however,
after receiving an order we show a count of holds on the order items
specifically. I think we should show both number, something like:

0(3)

or

0 (3 on title)

or 

0 on order items (3 on title)

depending on recommended verbosity/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 15:01:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 14:01:54 +0000
Subject: [Koha-bugs] [Bug 19190] Silly calculation of average time in
	touch_all scripts
In-Reply-To: <bug-19190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19190-70-wKKdDAYlBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Backport ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 15:40:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 14:40:12 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-IP7AZ66yuX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move                        |Move
                   |C4::Reserves::OPACItemHolds |C4::Reserves::OPACItemHolds
                   |Allowed to the code         |Allowed to the Koha
                   |namespace                   |namespace

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 15:40:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 14:40:17 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-rEDiSf3dtL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move                        |Move
                   |C4::Reserves::OnShelfHoldsA |C4::Reserves::OnShelfHoldsA
                   |llowed to the code          |llowed to the Koha
                   |namespace                   |namespace

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 15:46:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 14:46:35 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-Nln1g1b6zu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55147|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 15:47:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 14:47:00 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-m0pBK4MdDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56667|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 15:46:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 14:46:47 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-dBR0y4myWP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56666|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 15:47:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 14:47:16 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-7QILlae23K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56668|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 16:19:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 15:19:07 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-A4XC1vveRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel,
It is good to see test for the 2 subroutines you add to Koha::MSS, but I am not
sure we should add them to the module. As we need them to be executed only once
during the update DB process, we should have these changes moved to the
updatedatabase.pl script (or to a separate script). Do not you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 16:54:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 15:54:17 +0000
Subject: [Koha-bugs] [Bug 19742] New: Differentiate renew' s permissions at
 the OPAC from those at the Intranet
Message-ID: <bug-19742-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19742

            Bug ID: 19742
           Summary: Differentiate renew's permissions at the OPAC from
                    those at the Intranet
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi, 

It would be great to differentiate the user permissions to renews documents at
the OPAC from those at the Intranet. For exemple, The user who can renew their
documents 3 times in all, could be only able to renew 1 or 2 time their
documents at the OPAC but for the last time they should have to go to the
library. Actually, the number of renewals allowed in fine rules counts for both
intranet and opac. the user could be notified to go to the library for the last
renew for their documents. 

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:08:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:08:51 +0000
Subject: [Koha-bugs] [Bug 19743] New: Header and Footer should be updated on
 each item for checkin / checkout / renewal notices
Message-ID: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743

            Bug ID: 19743
           Summary: Header and Footer should be updated on each item for
                    checkin / checkout / renewal notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When generating the checkout notice for a patron we only update the section in
between the '---' tags

For template toolkit purposes it means we cannot affect the content based on
more than a single item. For instance, we want to add the total cost of all
items checked out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:09:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:09:06 +0000
Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each
 item for checkin / checkout / renewal notices
In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19743-70-h5ZQs105BQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:10:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:10:38 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: <bug-16239-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16239-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16239-70-5wWrl0MUHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19634


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19634
[Bug 19634] Advanced editor - Rancor - error in display of macro editor in
firefox
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:10:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:10:38 +0000
Subject: [Koha-bugs] [Bug 19634] Advanced editor - Rancor - error in display
 of macro editor in firefox
In-Reply-To: <bug-19634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19634-70-RX1qqIfus7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19634

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16239

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
The bug appears to stem from Bug 16239, but I haven't been able to figure out
exactly what's going on.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
[Bug 16239] Upgrade Bootstrap in the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:14:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:14:02 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-ASNrW3Mtu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69395|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69481&action=edit
Bug 19700: Move template JavaScript to the footer: Some circulation pages

This patch modifies some staff client circulation templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Article requests (enable ArticleRequests system preference, have at
  least one outstanding article request)
  - Request article (Bibliographic detail page -> Request article).
- Item circulation statistics (Bibliographic detail page -> Items ->
  View item's checkout history).
- On-site checkouts (enable OnSiteCheckouts system preference; Check out
  some items as on-site checkouts; Go to Circulation ->
  Pending on-site checkouts
- Overdues report (Circulation -> Overdues).
- Holds to pull (Circulation -> Holds to pull).
- Renew
- Holds ratios (Circulation -> Holds ratios).
- Check in
- Transfers to receive (Circulation -> Transfers to receive).
- Holds queue (Circulation -> Holds queue).
- Holds awaiting pickup (Circulation -> Holds awaiting pickup).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:19:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:19:58 +0000
Subject: [Koha-bugs] [Bug 17593] Extend circulation rules to include
	shelving location
In-Reply-To: <bug-17593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17593-70-vQ3lurRa09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17593

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:22:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:22:17 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the
	footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-UGEayNmP4O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move patron templates to    |Move patron templates
                   |the footer                  |JavaScript to the footer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:24:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:24:24 +0000
Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each
 item for checkin / checkout / renewal notices
In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19743-70-TGuBdrdW5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:24:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:24:24 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-iPn3cbE2L9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19744


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744
[Bug 19744] Move template JavaScript to the footer: Offline circulation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:24:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:24:26 +0000
Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each
 item for checkin / checkout / renewal notices
In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19743-70-93CqNJ2Esl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69482&action=edit
Bug 19743 - Header and Footer should be updated on each item for checkin /
checkout / renewal notices

When generating the checkout notice for a patron we only update the
section in between the '---' tags

For template toolkit purposes it means we cannot affect the content
based on more than a single item. For instance, we want to add the total
cost of all items checked out.

Test Plan:
1) Add "Thank you for visiting <<branches.branchname>>." to the bottom of the
checkout notice. Below the second '----'.
2) Check out an item to a patron to generate that notice
3) Note the branch name in the notice
4) Update the branch name in the branches editor, change it to something else
5) Check out a 2nd item to that patron
6) Notice the items list updated, but the branch name did not
7) Apply this patch
8) Check out a 3rd item to that patron
9) Notice the branch name updated this time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:24:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:24:24 +0000
Subject: [Koha-bugs] [Bug 19744] New: Move template JavaScript to the
 footer: Offline circulation
Message-ID: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

            Bug ID: 19744
           Summary: Move template JavaScript to the footer: Offline
                    circulation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: jonathan.druart at bugs.koha-community.org,
                    nick at bywatersolutions.com, simon.pouchol at biblibre.com,
                    testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for offline circulation templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:41:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:41:02 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-8tCvQmvddi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:41:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:41:04 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-FEFDJBjrlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69483&action=edit
Bug 19744: Move template JavaScript to the footer: Offline circulation

This patch modifies the staff client offline circulation templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Circulation -> Built-in offline circulation interface
  -> Synchronize
   -> Download records
  -> Check out
  -> Check in
    -> Synchronize
      -> Upload transactions
  -> Pending offline circulations
    -> Check all, uncheck all
    -> Delete
    -> Process

Circulation -> Upload offline circulation data
  -> Upload .koc file (gerated by the Koha Offline Circulation program,
     for instance).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 17:52:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 16:52:27 +0000
Subject: [Koha-bugs] [Bug 19745] New: Add Edit button for all the boards in
 circulation and fines rules
Message-ID: <bug-19745-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19745

            Bug ID: 19745
           Summary: Add Edit button for all the boards in circulation and
                    fines rules
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi, 

It would be usefull to have an "edit" button for all the boards in the
circulation and fines rules. At this moment, the four last boards don't have an
edit button and its not pratical. For those boards, we have to delet a rule to
add a new one and now edit the rule. It would be great if there was a button
all the same. Especially for a question of standardization with the rules of
the first block.

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 18:13:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 17:13:38 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-OwW6vpJiRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 18:15:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 17:15:09 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-gUylFZUSax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

--- Comment #3 from rkuiper at roundrocktexas.gov ---
Hi, any progress on this bug?  Round Rock is eagerly looking forward to this
function!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 18:22:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 17:22:08 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-ztXRWypo9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
As far as I can tell, JavaScript regular expressions will not recognize
non-ascii "word" characters as such, and thus client-side validation can't work
here unless we restrict the options quite a bit.

I appreciate that this limitation with my patch has bee pointed out because I
don't think it's okay that we make it so strict if we don't have to.

Is it a limitation of branches.pl that it fails to accept a string like this?

/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=???&??

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 18:39:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 17:39:14 +0000
Subject: [Koha-bugs] [Bug 19525] Bulk-add patrons to a list
In-Reply-To: <bug-19525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19525-70-GMjk7Z3B3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19525

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 18:51:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 17:51:43 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-7x79WbMpfU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 18:56:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 17:56:41 +0000
Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each
 item for checkin / checkout / renewal notices
In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19743-70-Ks17aPQr7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69484&action=edit
Bug 19743 - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:26:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:26:24 +0000
Subject: [Koha-bugs] [Bug 18447] Datepicker only shows -10/+10 years for
	date of birth
In-Reply-To: <bug-18447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18447-70-bK8WBFoDzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18447
Bug 18447 depends on bug 12342, which changed state.

Bug 12342 Summary: Patron registration datepicker dropdown shows only 10 years
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:26:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:26:23 +0000
Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown
 shows only 10 years
In-Reply-To: <bug-12342-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12342-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12342-70-FnIKjntOkX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:30:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:30:29 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-Jkhej7CzDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61529|0                           |1
        is obsolete|                            |
  Attachment #61530|0                           |1
        is obsolete|                            |
  Attachment #64747|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69485&action=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:30:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:30:35 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-dnfz5I4UZT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69486&action=edit
Bug 18235: ES - Facets configurable

This patch adds a new section 'Facet order' in the Biblio tab of the
'Search engine configuration' admin page of the Elastic mappings.
The idea is to let the librarians define the facet to display and order
them as their needs.

The ergonomic is not perfect and I am open to any suggestions.

Test plan:
Move up and down the field list to order the facets
Hide/show some facets
At the OPAC and the staff interface you should see the changes on the
search result page.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:30:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:30:40 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18235-70-DinIoEqSyy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69487&action=edit
Bug 18235: DBIx schema changes

Fresh changes for SearchField, facet_order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:32:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:32:42 +0000
Subject: [Koha-bugs] [Bug 19662] koha previous year data uploading
In-Reply-To: <bug-19662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19662-70-KTyWTGwM6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19662

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|Koha security               |
           Assignee|chris at bigballofwax.co.nz    |koha-bugs at lists.koha-commun
                   |                            |ity.org
          Component|Koha                        |Architecture, internals,
                   |                            |and plumbing
            Product|Koha security               |Koha
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:42:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:42:35 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-BWlHSlGSob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:42:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:42:39 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-96R2lwWZVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69488&action=edit
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Bug 17898 tries to help users identify reports affected by the move of
marcxml to the biblio_metadata table, however, the auth_header table
still uses the column name 'marcxml' and so reports as needing updated
though it doesn't.

C4::Reports::Guided::convert_sql only converts if the sql query contain
biblioitems and marcxml.
We should use the same regexp in the controler script.

Test plan:
Use a sql report that use auth_header.marcxml (see
https://wiki.koha-community.org/wiki/SQL_Reports_Library)
After the this the report should not be longer marked as obsolete on the
report list view

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:44:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:44:18 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-bic9fLHt9g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:58:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:58:56 +0000
Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and
	renewal limits
In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18450-70-2NjPQSKJ6v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69476|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 19:59:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 18:59:23 +0000
Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and
	renewal limits
In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18450-70-BPWJb6LQZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #21 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69489&action=edit
Bug 18450 - Followup -  Implemented a conditional checking if the item that the
patron is trying to renew has more than 1 copy available which can be renewed.
This means the AllowRebnewalIfOtherItemsAvailable system preference is now
appropriately impleme

In order to make the conditional statement work correctly checking three
conditions each time (two system preferences and the value of the
can_renew variable I had to implement a elsif statement. I spent a large
amount of time trying to get a single IF statement to check the three
conditions in three different combinations but it ignored the value of
the can_renew variable each time and so I was forced to split it out
into an If and ELSIF

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.

2. Place a hold on an item

3. Checkout the item out to a different patron

4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning

5. Click the 'Override and renew' button and notice that you
can bypass the hold

6. Apply patch

7. Try to renew an item (with item level hold on it) which belongs to a biblio
with either only one
item or a biblio with multiple items all of which have holds on them.
Notice the only button in the yellow message box displayed is
'Continue without renewing'

8. Repeat step 7 but change the hold to a 'Next available' hold rather
than an item level hold. Again notice only the 'Continue without
renewing' button is displayed

9. Try to renew an item (with item level hold on it) which belongs to a
biblio with mutliple aviable items of it in the catalogue. Notice only
the 'Continue without renewing' button is displayed

10. Repeat step 9 but change the hold to a 'Next available' hold rather
than an item level hold. Notice only the 'Continue without renewing'
button is displayed

11. Set both AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable systempreferences to 'Allow' and
repeat step 7 notice only the 'Continue without renewing' button is
displayed in the yellow message box

12. Repeat step 8 and notice only the 'Continue without renewing' button
is displayed

13. Repeat step 9 and notice only the 'Continue without renewing' button
is displayed

14. Repeat step 10 and notice the item is immediately renewed and the
yellow message box is not displayed

15. Set the AllowRenewalIfOtheritemsAvailable to 'Dont' Allow' and
repeat step 7 and notice that both the 'Override and renew' and 'Continue
without renewal' buttons are
displayed

16. Repeat step 8 and notice both buttons are displayed

17. Repeat step 9 and notice both buttons are displayed

18. Repeat step 10 and notice both buttons are displayed

19. Set AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride syspref to 'Dont' Allow' and repeat step 7 and
notice only the 'Continue without renewal' button is displayed

20. Repeat step 8 and notice only 'Continue without renewal' button is
displayed

21. Repeat step 9 and notice only the 'Continue without renewal' button
is displayed

22. Repeat step 10 and notice both buttons are displayed

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:03:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:03:19 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-fQ5EWFUWVt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69423|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69490&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:03:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:03:53 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-MI2I7haCge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #12)
> Is it a limitation of branches.pl that it fails to accept a string like this?
> 
> /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=???&??

Fixed with the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:07:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:07:43 +0000
Subject: [Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from
	checkin screen
In-Reply-To: <bug-14464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14464-70-zOjulxeAYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19746


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746
[Bug 19746] Debug statements are left in returns.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:07:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:07:43 +0000
Subject: [Koha-bugs] [Bug 19746] New: Debug statements are left in returns.pl
Message-ID: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

            Bug ID: 19746
           Summary: Debug statements are left in returns.pl
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 14464

>From bug commit bb6277ffcc593685554112d770ac273c9efeda33
Bug 14464: Add ability to cancel waiting holds from checkin screen

+use Carp 'verbose';
+$SIG{ __DIE__ } = sub { Carp::confess( @_ ) };

See also
http://lists.koha-community.org/pipermail/koha-devel/2017-November/044168.html


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464
[Bug 14464] Add ability to cancel waiting holds from checkin screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:09:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:09:04 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-Hpghutcn7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:09:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:09:08 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-CtnV4OUN0j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69491&action=edit
Bug 19746: Remove debug statements in returns.pl

>From bug commit bb6277ffcc593685554112d770ac273c9efeda33
Bug 14464: Add ability to cancel waiting holds from checkin screen

+use Carp 'verbose';
+$SIG{ __DIE__ } = sub { Carp::confess( @_ ) };

See also
http://lists.koha-community.org/pipermail/koha-devel/2017-November/044168.html

Test plan:
Read the changes and make sure they make sense

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:13:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:13:36 +0000
Subject: [Koha-bugs] [Bug 19106] Pop up MARC preview window appears when
 searching in Chrome, cannot be closed
In-Reply-To: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19106-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19106-70-haDf0dwJWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I'm guessing this was an upgrade issue related to the browser cache. If anyone
finds that this bug still exists please re-open.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:14:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:14:30 +0000
Subject: [Koha-bugs] [Bug 7047] renewing serials note not visible
In-Reply-To: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7047-70-WcRrDKiQPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|colin.campbell at ptfs-europe. |alexbuckley at catalyst.net.nz
                   |com                         |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:15:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:15:25 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-Ah4RL9zwya@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|colin.campbell at ptfs-europe. |alexbuckley at catalyst.net.nz
                   |com                         |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:23:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:23:48 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-g9uL4K8qwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:23:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:23:51 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-zuiaJZmo6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:26:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:26:45 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-oegtfhCVOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19721

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:26:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:26:45 +0000
Subject: [Koha-bugs] [Bug 19721] Tabulation in the description of a patron
 category breaks the patron search. Cause : tabs must be escaped in JSON
In-Reply-To: <bug-19721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19721-70-TEJHFCWVtY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19721

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19655

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 20:43:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 19:43:56 +0000
Subject: [Koha-bugs] [Bug 10190] notices based on item type
In-Reply-To: <bug-10190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10190-70-uq6ogV4X8G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190

Amy Voorhees <voorheesa at kent-school.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |voorheesa at kent-school.edu

--- Comment #3 from Amy Voorhees <voorheesa at kent-school.edu> ---
Here in 2017 still wishing for greater flexibility for overdue notices based on
Item Type, not only Patron Category -- in our case (school library) for better
communication about items on Reserve (in our case loan period is 2 hours).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 21:50:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 20:50:11 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-tbKjydVOQ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dependency
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 21:50:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 20:50:27 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-TwSFG5NoUE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 21:50:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 20:50:30 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-XvAg49b2ll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67986|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69492&action=edit
Bug 19450: Fixed WebService::ILS bug upsteram

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 21:51:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 20:51:06 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-YaZb1Hxg5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 22:46:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 21:46:32 +0000
Subject: [Koha-bugs] [Bug 19747] New: Clicking 'Help' on request-article.pl
 yields no help page.
Message-ID: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19747

            Bug ID: 19747
           Summary: Clicking 'Help' on request-article.pl yields no help
                    page.
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Here's what I get:

Online help
Sorry, there is no help available for this topic, please refer to the Koha
17.05 manual (online).
?Add help

The Koha 17.05 manual link does not take me to the help page for article
requests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 22:56:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 21:56:10 +0000
Subject: [Koha-bugs] [Bug 19747] Clicking 'Help' on request-article.pl
 yields no help page.
In-Reply-To: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19747-70-Z7CTVQ5yjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19747

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 23:00:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 22:00:55 +0000
Subject: [Koha-bugs] [Bug 11181] Koha geolocalization of OPAC users for
 better sort results
In-Reply-To: <bug-11181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11181-70-X5dJtBwvu0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11181

--- Comment #2 from Pablo AB <pablo.bianchi at gmail.com> ---
Now that branches table have a geolocation column would be great to sort
results depending on user location (based on HTML5 geolocation, IP or user
address).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 23:28:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 22:28:23 +0000
Subject: [Koha-bugs] [Bug 19742] Differentiate renew' s permissions at the
 OPAC from those at the Intranet
In-Reply-To: <bug-19742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19742-70-f8g1BDEHVv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As a workaround: staff can overwrite renewal limits if
AllowRenewalLimitOverride is set to allow and the staff patron has the
permission. So you can set the lower value for the OPAC and staff can
overwrite. 

But I agree that the described behaviour would be a nice improvement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec  4 23:30:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 22:30:05 +0000
Subject: [Koha-bugs] [Bug 19742] Differentiate possible number of renewals
 at the OPAC from those at the Intranet
In-Reply-To: <bug-19742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19742-70-7DJrGvV3pp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Differentiate renew's       |Differentiate possible
                   |permissions at the OPAC     |number of renewals at the
                   |from those at the Intranet  |OPAC from those at the
                   |                            |Intranet

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 00:08:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 04 Dec 2017 23:08:14 +0000
Subject: [Koha-bugs] [Bug 13802] Renewals ignore hard due dates
In-Reply-To: <bug-13802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13802-70-BPlsm1JPXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13802

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
This bug appears to be fixed on master now (version 17.12.00.000)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 05:14:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 04:14:21 +0000
Subject: [Koha-bugs] [Bug 19610] koha-common.logrotate should use
	copytruncate
In-Reply-To: <bug-19610-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19610-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19610-70-ADNyjJoHEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19610

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 05:49:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 04:49:31 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-73MaK4c6kl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 05:49:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 04:49:35 +0000
Subject: [Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
In-Reply-To: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17282-70-6rXmpKqu2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69430|0                           |1
        is obsolete|                            |

--- Comment #44 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69493&action=edit
Bug 17282 - Add information about the new Javascript libraries in the about
page - fix a QA warning - Move chart settings on top and make them hidden by
default - Add options to get all results

Patch applies and functions as expected when following test plan.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 06:36:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 05:36:33 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-TMYEManeCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 06:36:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 05:36:37 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-SgZuGjRGxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69488|0                           |1
        is obsolete|                            |

--- Comment #2 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69494&action=edit
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Replicated bug with the following SQL:
        select marcxml from auth_header;

Patch applied correctly and functioned as expected.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:03:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:03:42 +0000
Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual
In-Reply-To: <bug-11115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11115-70-Rpw8V65O7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:33:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:33:47 +0000
Subject: [Koha-bugs] [Bug 19247] Feature release change tool
In-Reply-To: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19247-70-IV31CTrgb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Alex, check the system preference editor - I just noticed I still had your
patch from before applied and it seemed to break the pull downs in the editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:39:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:39:04 +0000
Subject: [Koha-bugs] [Bug 19247] Feature release change tool
In-Reply-To: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19247-70-nVOx8Afn5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just took a look at the last patch, what is display_choices supposed to do?

display_choices="Don't show|Show" WHERE
variable="IntranetCatalogSearchPulldown";

On first glance, this looks like a translatability issue - why have them in the
database and in the translatable yaml file?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:46:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:46:20 +0000
Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory
 patron data differently between OPAC registration and modification
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-UHVnBgwQ9q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Mandatory fields are wrong  |Make it possible to
                   |in patron personal details  |configure mandatory patron
                   |page                        |data differently between
                   |                            |OPAC registration and
                   |                            |modification

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah, I think I got it now. So we should differentiate between modification and
registration for the mandatory fields as well:

PatronSelfRegistrationBorrowerUnwantedField
PatronSelfModificationBorrowerUnwantedField

PatronSelfRegistrationBorrowerMandatoryField
TODO: PatronSelfModificationBorrowerMandatoryField

Just wondering: why ask for it as mandatory on registration when it is not
needed later on?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:48:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:48:52 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-W7HrFyHMt8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's waiting for the patch author to fix the problems pointed out in testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:53:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:53:38 +0000
Subject: [Koha-bugs] [Bug 16872] You should not be allowed to delete a
 record with open orders attached
In-Reply-To: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16872-70-N2WBIAjXYi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16872

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it's ok to block users from deleting and ask them to cancel the orders
first. Maybe with a link to the order in acq if they have the right permission? 

Separate problem, but related to deleting the records: Once you deleted the
record the cancelled order remains visible, but has no title anymore. That's
not helpful and we can't delete cancelled orders either. The whole topic of how
to handle deletes is something we should tackle.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:54:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:54:21 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-wCHRubG7FM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 07:59:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 06:59:13 +0000
Subject: [Koha-bugs] [Bug 19516] Can't save changes on notices if letter is
 already created
In-Reply-To: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19516-70-slK95efRnf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19516

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|can't save changes on       |Can't save changes on
                   |notices if letter is        |notices if letter is
                   |already created             |already created

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Hugo and Stefan, 
could this be a duplicate to bug 19675? 
Don't forget to change status to 'needs sign-off' after posting a patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 08:04:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 07:04:19 +0000
Subject: [Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
In-Reply-To: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19617-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19617-70-Huuyrdnw1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Development - Allow partial |Allow 'writeoff of
                   |writeoff                    |selected'
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Changed title to differentiate between this bug and bug 11210.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 08:21:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 07:21:52 +0000
Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2
	subfields
In-Reply-To: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9156-70-Nx4VBW0bAi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |z.tajoli at cineca.it

--- Comment #4 from Zeno Tajoli <z.tajoli at cineca.it> ---
To fix the probblrm we need to work on line 149 - 160 of
../cataloguing/additem.pl.
The lines are:

 149         my $pref_itemcallnumber =
C4::Context->preference('itemcallnumber');
 150         if (!$value && $subfieldlib->{kohafield} eq 'items.itemcallnumber'
&& $pref_itemcallnumber) {
 151             my $CNtag       = substr($pref_itemcallnumber, 0, 3);
 152             my $CNsubfield  = substr($pref_itemcallnumber, 3, 1);
 153             my $CNsubfield2 = substr($pref_itemcallnumber, 4, 1);
 154             my $temp2 = $temp->field($CNtag);
 155             if ($temp2) {
 156                 $value = ($temp2->subfield($CNsubfield)).'
'.($temp2->subfield($CNsubfield2));
 157                 #remove any trailing space incase one subfield is used
 158                 $value =~ s/^\s+|\s+$//g;
 159             }
 160         }

It is clear that first and second subfields are user.
Inside '$temp' you find bibliographic record data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 08:23:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 07:23:16 +0000
Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2
	subfields
In-Reply-To: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9156-70-nx2ezaKA4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|z.tajoli at cineca.it          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 08:57:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 07:57:42 +0000
Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus.
 ( make it work for existing instances)
In-Reply-To: <bug-16662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16662-70-pDHBjLC61Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 09:07:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 08:07:43 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-J1dRKViclB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 09:07:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 08:07:47 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-tHs1TLE7LW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69494|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69495&action=edit
Bug 19638: Remove false positive obsolete reports (auth_header.marcxml)

Bug 17898 tries to help users identify reports affected by the move of marcxml
to the biblio_metadata table, however, the auth_header table still uses the
column name 'marcxml' and so reports as needing updated though it doesn't.

C4::Reports::Guided::convert_sql only converts if the sql query contain
biblioitems and marcxml.
We should use the same regexp in the controler script.

Test plan:
Use a sql report that use auth_header.marcxml (see
https://wiki.koha-community.org/wiki/SQL_Reports_Library)
After the this the report should not be longer marked as obsolete on the report
list view

Replicated bug with the following SQL:
        select marcxml from auth_header;

Patch applied correctly and functioned as expected.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 09:08:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 08:08:28 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-VuvgCmhZ05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
   Patch complexity|---                         |Trivial patch
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 09:33:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 08:33:22 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-aNfvF5QkGS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Dilan Johnpull? from comment #7)
> Created attachment 69408 [details] [review]
> Bug 7046 - Implemented dropdown sub length element
> 
> Patch applies and functions as expected in line with test plan.
> Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Dilan, please do not remove the original commit message when you are
sign-offing. We need it in git for better understanding of commit
content/funcionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 09:58:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 08:58:23 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-Z54UMb90sA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 69408
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69408
Bug 7046 - Implemented dropdown sub length element

Review of attachment 69408:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7046&attachment=69408)
-----------------------------------------------------------------

::: C4/Serials.pm
@@ +1509,5 @@
> +          $subtype eq 'issues' ? $length : 0,
> +          $subtype eq 'weeks'   ? $length : 0,
> +          $subtype eq 'months'  ? $length : 0,
> +    );
> +}

Now it is not internal subroutine so the name should not start with
underscores.

Tests are needed for new subroutines in modules.

Some refactoring using objects would be nice, but it is out of the scope of
this bug report IMO, so no blocker.

::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
@@ +32,4 @@
>              </li>
>  		<li><fieldset>
>  		<legend>Subscription length:</legend>
> +		<select name="subtype" id="subtype">

Here are tabs at beginning, need to be removed

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 09:59:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 08:59:00 +0000
Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull
	down
In-Reply-To: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7046-70-wkrWFLK5Tq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
         QA Contact|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 10:12:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 09:12:45 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-sgoj7JFGgs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
IMO the escaping is better solution - we need it anyway for prevent XSS and it
is enough to solve this issue - so no reason to restrict the letters in
branchcode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 10:33:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 09:33:14 +0000
Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory
 patron data differently between OPAC registration and modification
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-paB1wAcX98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #7 from Ola Andersson <ola.andersson at ltu.se> ---
Hi Katrin!

We would like to enable self registration to our employees only and they are
required to enter their department in Address field 2.

However in the OPAC we have enabled self modification for all patrons and here
address field 2 can be empty for patrons such as students.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 10:44:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 09:44:59 +0000
Subject: [Koha-bugs] [Bug 19516] Can't save changes on notices if letter is
 already created
In-Reply-To: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19516-70-GdqFEnuGfN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19516

--- Comment #3 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> ---
(In reply to Katrin Fischer from comment #2)
> Hi Hugo and Stefan, 
> could this be a duplicate to bug 19675? 
> Don't forget to change status to 'needs sign-off' after posting a patch!

Yes, 19675 is the same fix. It will solve the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 11:08:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 10:08:50 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-nkFvc3wHgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com

--- Comment #13 from Claire Gravely <claire_gravely at hotmail.com> ---
Tested patch, seems to work as expected :)

One comment: when I turned the syspref on to "Block" the renew column in the
list of checkouts (circulation.pl) it shows 

auto_account_expired 
(5 of 5 renewals remaining)

do we want to show that wording? Would just 'Account expired' be more user
friendly?

Otherwise happy to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 11:29:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 10:29:03 +0000
Subject: [Koha-bugs] [Bug 19516] Can't save changes on notices if letter is
 already created
In-Reply-To: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19516-70-g39aKIxoqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19516

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 19675 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 11:29:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 10:29:03 +0000
Subject: [Koha-bugs] [Bug 19675] Cannot save notices when setting the
 TranslateNotices preference
In-Reply-To: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19675-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19675-70-fgQ4Y9xIlq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19516 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 11:29:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 10:29:49 +0000
Subject: [Koha-bugs] [Bug 13188] Make it possible to configure mandatory
 patron data differently between OPAC registration and modification
In-Reply-To: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13188-70-V9Q28NcCpj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Ola, thx for explaining the use case!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 11:42:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 10:42:40 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-sGhaVi2pP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69049|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69496&action=edit
Bug 19594: Move admin templates JavaScript to the footer: MARC-related

This patch modifies the staff client MARC-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 11:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 10:42:36 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-HW4kHJDEAE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 11:46:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 10:46:37 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-rOhxUy7Mae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Comment for RM: After this patch the bold emphasizing of some items in admin
menu will be broken until these bugs are pushed:
bug 19600 
bug 19601
bug 19607
bug 19608
bug 19603

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:00:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:00:20 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-SUgEjjE0Wi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:00:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:00:23 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-h4IVc8lo1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69068|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69497&action=edit
Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:00:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:00:26 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-LfmeW4FRpT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69498&action=edit
Bug 19600: (QA followup) Apply css to menu item for item_search_field page

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:00:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:00:56 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-wlfvCMZaeF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:12:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:12:06 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-0Ke0Vz57d1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:12:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:12:09 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-0zeXdLI5cA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69078|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69499&action=edit
Bug 19601: Move admin templates JavaScript to the footer: Additional parameters

This patch modifies the staff client "additional parameters"
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:12:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:12:44 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-LASNJyr7qB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:14:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:14:37 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-dfuPZvjUcc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 12:14:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 11:14:39 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-IIxEQH24Wl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69436|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69500&action=edit
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

This patch modifies the staff client's system preferences templates so
that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
both the standard and local use system preferences:

 - WYSIWYG editor
 - Confirmation messages
 - Table sorting
 - Multiple selects (CoceProviders for example)

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 13:19:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 12:19:48 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
	OneClickdigital/Recorded Books API
In-Reply-To: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17602-70-DQ1mMHR36k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #71 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #64)
> (In reply to Srdjan Jankovic from comment #63)
> > (In reply to Jonathan Druart from comment #61)
> > > Some additional remarks:
> > > 1. At some point I got the following error:
> > > {"error":"Checkout item already exists"}Status: 200 OK
> > 
> > I have to let Nick decide on that one
> 
> Nick?
> 
I was not able to recreate the error, a spinner would be nice here to indicate
action is being performed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 13:44:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 12:44:56 +0000
Subject: [Koha-bugs] [Bug 19748] New: 3M Cloud library integration
Message-ID: <bug-19748-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19748

            Bug ID: 19748
           Summary: 3M Cloud library integration
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 13:55:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 12:55:36 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-EmpO4TyYmV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 13:55:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 12:55:39 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-RiurpCbAp3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69290|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69501&action=edit
Bug 19680: Move JS to the footer: Patron and circulation tools

This patch modifies more staff client patrons and circulation tools
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Batch patron deletion/anonymization
  - Overdue notice/status triggers
  - Batch patron modification

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:07:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:07:52 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-JdPYXoF3lV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #16 from Owen Leonard <oleonard at myacpl.org> ---
Should we still reject brachcodes with whitespace characters?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:24:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:24:05 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-aWhYh9Ekzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69502&action=edit
Bug 19444: Display error message for auto_account_expired

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:24:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:24:50 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-IBIFTSf8sE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #16)
> Should we still reject brachcodes with whitespace characters?

Yes I think so (for command line scripts)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:25:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:25:38 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-Lxjs1LjFia@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Claire Gravely from comment #13)
> do we want to show that wording? Would just 'Account expired' be more user
> friendly?

Thanks for testing Claire!
Yes you are right, the last patch display a human friendly message for this
error code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:31:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:31:54 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-pGWzVLPTiL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:34:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:34:49 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-GkOAjwHOxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19656                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656
[Bug 19656] Move rotating collections templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:34:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:34:49 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-FIdsNRLRVa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19656


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656
[Bug 19656] Move rotating collections templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:34:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:34:49 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-mO5OeT3fFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19627                       |19647


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627
[Bug 19627] Move patron clubs templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:34:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:34:59 +0000
Subject: [Koha-bugs] [Bug 19748] 3M Cloud library integration
In-Reply-To: <bug-19748-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19748-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19748-70-AL9mYkf6tr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19748

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:49:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:49:50 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-tnM4EjEoU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #16 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69503&action=edit
[SIGNED-OFF] Bug 19444: Do not auto renew if patron is expired and
BlockExpiredPatronOpacActions is set

If the patron's account has expired and BlockExpiredPatronOpacActions is set,
we expect auto renewal to be rejected.

Test plan:
Use the automatic_renewals.pl cronjob script to auto renew a checkout

Before this patch, if the patron's account has expired the auto renew was done.
With this patch, it will only be auto renewed if BlockExpiredPatronOpacActions
is not set.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:49:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:49:53 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-UdcS0YG0eY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #17 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69504&action=edit
[SIGNED-OFF] Bug 19444: Display error message for auto_account_expired

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:49:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:49:46 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-4wZgbYd57t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:53:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:53:51 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-QzgWhlqGxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:58:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:58:02 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-9rxF10CC0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19689


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689
[Bug 19689] Koha Offline Circulation Firefox plugin sends entries with wrong
branchcode without error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:58:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:58:02 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-LAaL3MHEEh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16497


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497
[Bug 16497] Add routes to list libraries
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:59:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:59:19 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-BtSYSq0Udc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68633|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 14:59:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 13:59:40 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-zGA8skuQpk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69502|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 15:02:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 14:02:11 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-sBalueasNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 15:02:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 14:02:14 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-4etnaT7BJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69237|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69505&action=edit
Bug 19656: Move rotating collections templates JS to the footer

This patch modifies the staff client's rotating collections templates so
that JavaScript is included in the footer instead of the header.

The patch moves JavaScript from each template and the rotating
collections toolbar into a single external JavaScript file.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 15:09:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 14:09:12 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-BwBxvkBcPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 15:14:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 14:14:01 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-vPIGEKtegu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69491|0                           |1
        is obsolete|                            |

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69506&action=edit
Bug 19746: Remove debug statements in returns.pl

>From bug commit bb6277ffcc593685554112d770ac273c9efeda33
Bug 14464: Add ability to cancel waiting holds from checkin screen

+use Carp 'verbose';
+$SIG{ __DIE__ } = sub { Carp::confess( @_ ) };

See also
http://lists.koha-community.org/pipermail/koha-devel/2017-November/044168.html

Test plan:
Read the changes and make sure they make sense

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 15:13:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 14:13:57 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-Qi91ENeMML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 15:34:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 14:34:34 +0000
Subject: [Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude
 period as splitting character in autotruncation
In-Reply-To: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19580-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19580-70-NupqKgg3os@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---
Looks good! Have also tested the patch and everything works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 15:37:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 14:37:20 +0000
Subject: [Koha-bugs] [Bug 19749] New: Report who show all the reservations
Message-ID: <bug-19749-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19749

            Bug ID: 19749
           Summary: Report who show all the reservations
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi, 

The report "Holds queue" don't show all the reservations. It show only the list
of reservations made on the "next available items". It would be great to have
in the circulation section a report who give the list of all the reservations
for itmes on loan. It could be useful for librarys to have acces to a report
who show all the reservations in the circulation's module. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:06:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:06:17 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-x4TFdBp96p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69480|0                           |1
        is obsolete|                            |

--- Comment #23 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69507&action=edit
Bug 19575: Use canonical field names and resolve aliased fields

Adjust elastic search mappings to more closely match Zebra equivalents
resolving serveral issues with coded Zebra searches in templates, and
sorting of search results in UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:07:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:07:09 +0000
Subject: [Koha-bugs] [Bug 17500] Use Elasticsearch to search for patrons
In-Reply-To: <bug-17500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17500-70-bvwWjMyqXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17500

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #7)
> - we will need to rethink the existing code as we would need to index/search
> something else than bibliographic records. And the code is too bib-centric
> at the moment

I think this can be done - I think is a good opportunity to consider accessing
ElasticSearch via perl modules from ES and not through catmandu

> - the patron attributes are not indexed and so not searchable

Yup

> - the index is not maintained when a patron record is updated

Yup

> - it makes ES mandatory as it removes the existing MySQL search. We will
> need to let the ability to choose/switch between both (at least for a given
> period).

If it replicates close enough I think this is a good opportunity to turn ES on
by default, then search testing is possible for all

> 
> It highlights the fact that we need to abstract our Elasticsearch code to
> make it more powerful and extensive.
> Moreover there is something hard to fix: at the moment it's possible to sort
> the table by library name or patron category name. But as we only index the
> code it is possible to order the results by these 2 fields, and it won't be
> possible unless we index them.
> But ofc if we index them, we will have to reindex everything if the
> description is updated in the admin config. Note that we will have this
> problematic for bibliographic records very soon as well and we will have to
> decide what to do.

I think the descriptions don't change very often - a warning that things need
to be reindexed I think suffices.  Bug 18950 proposed allowing user to reindex,
however, I think safer is to allow user to request reindex, then handle on
server by it staff to check if reindex requested and schedule.

Bug 18948 also serves to ease reindexing by doing it in the background and
preserving searching while done. Paves the way for allowing changes to
mappings/descriptions etc and only committing on reindex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:09:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:09:10 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-bzrDK8GlyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #24 from David Gustafsson <glasklas at gmail.com> ---
Field name 'Date/time-last-modified' does not work with elastic since "/" will
create subfields, koha will also not tokanize this correctly, changed this
(back) to 'Date-time-last-modified'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:11:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:11:21 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-zCM0E70r7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

--- Comment #30 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69508&action=edit
Bug 16497 - Add POD in Koha/REST/V1/Library.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:11:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:11:57 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-2O9TFCy7M7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:23:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:23:21 +0000
Subject: [Koha-bugs] [Bug 19750] New: Overdues without a fine rule add
	warnings to log
Message-ID: <bug-19750-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750

            Bug ID: 19750
           Summary: Overdues without a fine rule add warnings to log
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When running fines.pl, any overdue items that have no corresponding circulation
rule will generate the following warning in the log files:

Use of uninitialized value $amount in numeric gt (>) at
/usr/share/koha/bin/cronjobs/fines.pl line 133.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:23:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:23:35 +0000
Subject: [Koha-bugs] [Bug 19374] CircSidebar overlapping transferred items
	table
In-Reply-To: <bug-19374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19374-70-lIdr8FBOlf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:23:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:23:29 +0000
Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings
	to log
In-Reply-To: <bug-19750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19750-70-k47EanHVMR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:25:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:25:53 +0000
Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings
	to log
In-Reply-To: <bug-19750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19750-70-qmVHCPODkB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69509&action=edit
Bug 19750 - Overdues without a fine rule add warnings to log

When running fines.pl, any overdue items that have no corresponding circulation
rule will generate the following warning:

Use of uninitialized value $amount in numeric gt (>) at
/usr/share/koha/bin/cronjobs/fines.pl line 133.

Test Plan:
1) Create a single circ rule
2) Backdate a checkout so it is overdue
3) Delete the circ rule
4) Run fines.pl, note the warning
5) Apply this patch
6) Run fines.pl, note the warning is gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:25:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:25:51 +0000
Subject: [Koha-bugs] [Bug 19750] Overdues without a fine rule add warnings
	to log
In-Reply-To: <bug-19750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19750-70-bzEY66Dwih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19750

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:26:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:26:28 +0000
Subject: [Koha-bugs] [Bug 19751] New: Holds awaiting pickup report should
 not be fixed-width
Message-ID: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

            Bug ID: 19751
           Summary: Holds awaiting pickup report should not be fixed-width
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/circ/waitingreserves.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 19700

The holds awaiting pickup report should not be fixed-width. The table can be
very wide, especially with the width of "Cancel and return to..." buttons with
long branch names.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700
[Bug 19700] Move template JavaScript to the footer: Some circulation pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:26:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:26:28 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-csdH9UZVjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19751


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751
[Bug 19751] Holds awaiting pickup report should not be fixed-width
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:29:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:29:15 +0000
Subject: [Koha-bugs] [Bug 17704] OAI-PMH compatiblity with Ubuntu Xenial and
 Debian Stretch
In-Reply-To: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17704-70-XP5JQtLhqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
*** Bug 19732 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:29:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:29:15 +0000
Subject: [Koha-bugs] [Bug 19732] Koha does not work with latest versions of
	HTTP::OAI
In-Reply-To: <bug-19732-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19732-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19732-70-oztD2hqO06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19732

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---


*** This bug has been marked as a duplicate of bug 17704 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:31:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:31:57 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-mET8ahAsGf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69510&action=edit
Bug 19751: Holds awaiting pickup report should not be fixed-width

This patch changes the grid used for the holds awaiting pickup report so
that the results are full page and fluid instead of fixed-width.

To test, apply this patch and the patch for Bug 19700 if necessary.

View the holds awaiting pickup report. The report should fluidly fill
the page width.

Test with the CircSidebar system preference enabled and disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:31:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:31:55 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-4bsUmqqFkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:33:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:33:52 +0000
Subject: [Koha-bugs] [Bug 19752] New: Improve authentication response in
 offline_circ/ service.pl
Message-ID: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752

            Bug ID: 19752
           Summary: Improve authentication response in
                    offline_circ/service.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: alex.arnaud at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

offline_circ/service.pl currently returns a "200 OK" HTTP status with a
"Authentication failed" string. We need a valid status code in this case (401).

We also need a nocookie option in this script. We added a test button in Koct
FF extention that check if the entered login/password are correct. But if the
user is currently authenticated on Koha, the script will use the cookie
authentication which can be misleading. With nocookie parameter set to true,
only the login/password will be checked.

Patch is coming

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:34:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:34:00 +0000
Subject: [Koha-bugs] [Bug 19752] Improve authentication response in
 offline_circ/service.pl
In-Reply-To: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19752-70-16nmwoYS8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:41:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:41:12 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-1wzKbbeOD5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19752


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752
[Bug 19752] Improve authentication response in offline_circ/service.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:41:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:41:12 +0000
Subject: [Koha-bugs] [Bug 19752] Improve authentication response in
 offline_circ/service.pl
In-Reply-To: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19752-70-93Zuu9se2q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19689


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689
[Bug 19689] Koha Offline Circulation Firefox plugin sends entries with wrong
branchcode without error
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:41:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:41:47 +0000
Subject: [Koha-bugs] [Bug 19752] Improve authentication response in
 offline_circ/service.pl
In-Reply-To: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19752-70-Ul0bAeikOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752

--- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69511&action=edit
offline_circ/service.pl return HTTP status 401 when authentication failed and
add option nocookie.

test plan:

- Apply this patch,
- log in to Koha,
- go to cgi-bin/koha/offline_circ/service.pl with no valid user
  and password as parameters and nocookie set to 1. i.e:
  cgi-bin/koha/offline_circ/service.pl?user=alex&password=wrongpass&nocookie=1,
- auth should fail
- check that the response code is 401

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:42:36 +0000
Subject: [Koha-bugs] [Bug 19752] Improve authentication response in
 offline_circ/service.pl
In-Reply-To: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19752-70-J7qxFM77ce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:52:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:52:13 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-BzLSIVHTdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

ByWaterSandboxes at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ByWaterSandboxes at gmail.com
             Status|Needs Signoff               |Signed Off

--- Comment #2 from ByWaterSandboxes at gmail.com ---
Patch tested with a sandbox, by George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:52:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:52:27 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-2VFCerHz2Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

--- Comment #3 from ByWaterSandboxes at gmail.com ---
Created attachment 69512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69512&action=edit
Bug 19751: Holds awaiting pickup report should not be fixed-width

This patch changes the grid used for the holds awaiting pickup report so
that the results are full page and fluid instead of fixed-width.

To test, apply this patch and the patch for Bug 19700 if necessary.

View the holds awaiting pickup report. The report should fluidly fill
the page width.

Test with the CircSidebar system preference enabled and disabled.

Signed-off-by: George Williams <george at nekls.org>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 16:52:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 15:52:22 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-XMcMZNcMie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

ByWaterSandboxes at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69510|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:18:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:18:20 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-YJlp9qoePp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

--- Comment #4 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
The KOCT firefox plugin will add a dropdown list with valid branches and have
better configuration errors handling when the related bugs will be available in
Koha (16497 and 19752)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:30:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:30:32 +0000
Subject: [Koha-bugs] [Bug 19741] parcel.pl only shows holds on items in
 received orders, we should (also) count holds on the title
In-Reply-To: <bug-19741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19741-70-1cMDPmm4Xr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19741

Sandre Cunha <cunha at monterey.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cunha at monterey.org

--- Comment #1 from Sandre Cunha <cunha at monterey.org> ---
Although not impossible, in our workflow it would be rare for an on order item
to have an item-level hold. We do not assign barcodes until items are received
and catalogued. 

For us, the main purpose of being able to see the holds at the time an item is
received is to know whether or not to give it priority processsing. For this
purpose, it doesn't matter whether the holds are bib- or item-level. The total
number of holds is sometimes also useful for prioritizing. What is not useful
is when the total number of holds is mulitplied by the item number.

Any of the suggested ways of showing the holds would work. The first is most
succinct, and as long as everyone knows the difference between the number in
and outside of the parentheses, that's fine. The second option is short, and
perhaps less open to misinterpretation, so that is the one I would choose.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:33:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:33:31 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-j2aqWFejJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19753


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753
[Bug 19753] Move template JavaScript to the footer: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:33:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:33:31 +0000
Subject: [Koha-bugs] [Bug 19753] New: Move template JavaScript to the
 footer: Acquisitions
Message-ID: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

            Bug ID: 19753
           Summary: Move template JavaScript to the footer: Acquisitions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for some of the acquisitions templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:43:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:43:10 +0000
Subject: [Koha-bugs] [Bug 19749] Report who show all the reservations
In-Reply-To: <bug-19749-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19749-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19749-70-CtqqHC6vn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19749

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Does the "Holds to pull" report (circ/pendingreserves.pl) not satisfy this
request?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:48:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:48:21 +0000
Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does
 not update last seen date for check-ins
In-Reply-To: <bug-15751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15751-70-K5jIJTGLE2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com

--- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> ---
It's clear for me that the problem exists on Koha side. It seems that
ProcessOfflineReturn use MarkIssueReturned and not AddReturn (which do the
ModDateLastSeen). I wonder why there is 2 subs handling checkin and not one...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:58:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:58:58 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-ilcKfL4zGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65666|0                           |1
        is obsolete|                            |
  Attachment #65667|0                           |1
        is obsolete|                            |
  Attachment #65668|0                           |1
        is obsolete|                            |
  Attachment #65669|0                           |1
        is obsolete|                            |
  Attachment #65670|0                           |1
        is obsolete|                            |
  Attachment #65671|0                           |1
        is obsolete|                            |
  Attachment #65672|0                           |1
        is obsolete|                            |
  Attachment #65673|0                           |1
        is obsolete|                            |
  Attachment #65674|0                           |1
        is obsolete|                            |
  Attachment #65675|0                           |1
        is obsolete|                            |
  Attachment #65676|0                           |1
        is obsolete|                            |
  Attachment #65677|0                           |1
        is obsolete|                            |
  Attachment #65678|0                           |1
        is obsolete|                            |
  Attachment #65679|0                           |1
        is obsolete|                            |
  Attachment #65680|0                           |1
        is obsolete|                            |
  Attachment #65681|0                           |1
        is obsolete|                            |

--- Comment #189 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69514&action=edit
Bug 15707 - Update DB

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:05 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-BBzc90owOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #190 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69515&action=edit
Bug 15707 - Add new modules

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:11 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-SFYJwzsol7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #191 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69516&action=edit
Bug 15707 - Add editor

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:18 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-WBfIgmzSNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #192 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69517&action=edit
Bug 15707 - Unit Tests

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:24 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-Q9QcDeBzgY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #193 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69518&action=edit
Bug 15707: Fix conflict with bug 15446 (type vs _type)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:30 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-eJb4VPxiGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #194 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69519&action=edit
Bug 15707 [QA Followup] - Switch to treetable which Koha already uses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:36 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-Qa6TvgMu0w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #195 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69520&action=edit
Bug 15707: QA follow-up - Drop table if exists

1/ DROP table if exists
2/ FAIL   spelling
    decendents  ==> descendants

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:44 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-Ic03cMDRmq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #196 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69521&action=edit
Bug 15707 [QA Followup] - Fix UI issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:50 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-NToZBxZDmR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #197 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69522&action=edit
Bug 15707 [QA Followup] - Remove class for treegrid

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 17:59:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 16:59:56 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-EZHdQ51aju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #198 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69523&action=edit
Bug 15707 [QA Followup] - Allow object names to be styled without impeding
translation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:00:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:00:08 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-DROO8RpwTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #200 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69525&action=edit
Bug 15707 - Switch datetimes to timestamps

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:00:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:00:02 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-YaDpvoSiPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #199 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69524&action=edit
Bug 15707: Followup - use cat-search instead of cities-search in header

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:00:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:00:15 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-PJyv4G9QYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #201 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69526&action=edit
Bug 15707 - Add UNIQUE constraint to library groups table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:00:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:00:21 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-QwiJiUm1nG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #202 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69527&action=edit
Bug 15707 - Updates for Bootstrap 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:00:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:00:27 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-fcyWxI5FQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #203 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69528&action=edit
Bug 15707 - Display error if group title is already used

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:05:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:05:46 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-20amRIqmwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #204 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69529&action=edit
Bug 15707: DBIC Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:06:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:06:24 +0000
Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template
 for marcxml and marc21 metadata prefixes in OAI server
In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19353-70-N9lIxVyfTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:06:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:06:33 +0000
Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template
 for marcxml and marc21 metadata prefixes in OAI server
In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19353-70-PsH4IFaU71@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69530&action=edit
Bug 19353: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:06:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:06:36 +0000
Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template
 for marcxml and marc21 metadata prefixes in OAI server
In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19353-70-yJ6wM2zep8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69531&action=edit
Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes
in OAI provider

Test plan:
0) apply the patchset
1) setup oai server with oaiconf file defining xsl_file for metadata
format marcxml or marc21
2) play with your oai and confirm that records are transformed as
expected
3) prove t/db_dependent/OAI/Server.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:06:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:06:58 +0000
Subject: [Koha-bugs] [Bug 19353] Make possible to have custom XSL template
 for marcxml and marc21 metadata prefixes in OAI server
In-Reply-To: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19353-70-L2ZhY6W7Nx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:10:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:10:27 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-AOZv33uoxp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:10:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:10:30 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-pWsckclGA6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69532&action=edit
Bug 19753: Move template JavaScript to the footer: Acquisitions

This patch modifies some staff client acquisitions templates so that
JavaScript is included in the footer instead of the header.

This patch adds a JavaScript file, acquisitions-menu.js, which controls
the highlighting of the current page in the sidebar. Highlighting will
be temporarily broken for pages which have not been modified to include
this file

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Acquisitions home page
  - Datatable, Inactive budget controls
- Vendor search results
  - Acquisitions -> Vendor search
    - Datatables, "Show all" links
- Basket
  - Acquisitions -> Vendor -> Basket
    - Datatables, button controls, add managing user
- Add to basket from a staged file
  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - Datatables, tabs, selection controls
- Edit basket
  - Acquisitions -> Vendor -> Edit basket
    - Form validation
- EDIFACT messages
  - Acquisitions -> EDIFACT messages
    - Datatables, message preview
- Orders search
  - Acquisitions -> Order search
    - Full orders search form
      - Patron autocomplete in "Basket created by" field
      - Datepickers
    - Orders search results
      - Datatables, column visibility
- Invoices
  - Acquisitions -> Vendor -> Invoices -> Invoice
    - Form validation, datepickers, datatables
  - Invoice files (enable AcqEnableFiles preference)
    - Manage invoice files
      - File list datatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:13:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:13:46 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-wxvbWhuRex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65658|0                           |1
        is obsolete|                            |
  Attachment #65659|0                           |1
        is obsolete|                            |
  Attachment #65660|0                           |1
        is obsolete|                            |
  Attachment #65661|0                           |1
        is obsolete|                            |
  Attachment #65662|0                           |1
        is obsolete|                            |
  Attachment #65663|0                           |1
        is obsolete|                            |
  Attachment #65664|0                           |1
        is obsolete|                            |
  Attachment #65665|0                           |1
        is obsolete|                            |

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69533&action=edit
Bug 16735 - Remove modules no longer needed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:13:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:13:52 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-Url0NZna3q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69534&action=edit
Bug 16735 - Remove tables no longer needed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:13:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:13:57 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-KImlwXFddo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69535&action=edit
Bug 16735 - Clean up sample data

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:14:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:14:04 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-JMwliYkLFW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69536&action=edit
Bug 16735 - Replace existing library search groups functionality with the new
hierarchical groups system

Test Plan:
1) Apply this patch set
2) Note your existing search groups have been ported over to the new
   __SEARCH_GROUPS__ group if you had any
3) Create the group __SEARCH_GROUPS__ if one does not already exist
4) Add some first level subgroups to this group, add libraries to those groups
5) Search the library group searching in the intranet and opac
6) Note you get the same results as pre-patch

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:14:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:14:09 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-jmUGzMkS2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69537&action=edit
Bug 16735 - Don't use objects for database update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:14:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:14:14 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-36D41eFoNe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69538&action=edit
Bug 16735 - Remove use of get_categories

Feature using it is completely undocumented as far as my research has
shown.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:14:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:14:19 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-XEJQGLD994@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69539&action=edit
Bug 16735 - Filter individual libraries from search group pulldown

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:14:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:14:25 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-1tVom7L1Zr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69540&action=edit
Bug 16735: DBIC Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:14:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:14:30 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-89UaMNqo4f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #65 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69541&action=edit
Bug 16735 - Use libraries in all subgroups, not just immediate children

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:18:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:18:09 +0000
Subject: [Koha-bugs] [Bug 19754] New: Move template JavaScript to the
 footer: Acquisitions, part 2
Message-ID: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754

            Bug ID: 19754
           Summary: Move template JavaScript to the footer: Acquisitions,
                    part 2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19753
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for more of the acquisitions templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753
[Bug 19753] Move template JavaScript to the footer: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:18:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:18:09 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-KtSHHN5rlN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19754


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754
[Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:18:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:18:09 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-photNDEgoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19754


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754
[Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:35:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:35:05 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-tLeP8FgzEZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456
[Bug 19456] Some pages title tag contains html
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:35:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:35:05 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-zbbQLVrzMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403
[Bug 18403] Hide patron information if not part of the logged in user library
group
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:35:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:35:14 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-jU23D5cMBq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #205 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patches have been rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:35:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:35:35 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-T4udV7i2zB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #66 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patches have been rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:36:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:36:49 +0000
Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the
 logged in user library group
In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18403-70-PXb3A2aAQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The remote branch has been rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:46:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:46:06 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-7jdBcBmb7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not recreate, the format must be "json", unless you have javascript
disabled.
Can you confirm you did not disable javascript?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:56:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:56:58 +0000
Subject: [Koha-bugs] [Bug 19755] New: Move template JavaScript to the
 footer: Acquisitions, part 3
Message-ID: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755

            Bug ID: 19755
           Summary: Move template JavaScript to the footer: Acquisitions,
                    part 3
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19753
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for even more of the acquisitions templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753
[Bug 19753] Move template JavaScript to the footer: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:56:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:56:58 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-Rhyz0gKnCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755
[Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 18:56:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 17:56:58 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-DxiPjFAnYp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755
[Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 19:13:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 18:13:04 +0000
Subject: [Koha-bugs] [Bug 19519] Ability to bind the rotating collection
 with branch during creating
In-Reply-To: <bug-19519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19519-70-zxqST4DWgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 19:13:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 18:13:07 +0000
Subject: [Koha-bugs] [Bug 19519] Ability to bind the rotating collection
 with branch during creating
In-Reply-To: <bug-19519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19519-70-tCn2V6XTIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69542&action=edit
Bug 19519: Add ability to bind rotating collectino with library during creation

Test plan:
0) Apply the patch
1) Go to rotating collections tool
2) Try to create and edit collections, note there is new field
"library", try to set and unset it
3) try to transfer a collection, the library saved by creating/editing
collection should be preselected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 19:23:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 18:23:25 +0000
Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer:
 Acquisitions, part 2
In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19754-70-B4EcgY9UFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 19:23:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 18:23:27 +0000
Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer:
 Acquisitions, part 2
In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19754-70-kcOkrvcjcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69543&action=edit
Bug 19754: Move template JavaScript to the footer: Acquisitions, part 2

This patch modifies some staff client acquisitions templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Acquisitions -> Invoices
  - Datepickers
  - Search for invoices
    - Datatable
- Acquisitions -> Late orders
  - Datepickers, datatables, selection controls (when searching by
    vendor)
- Acquisitions -> Vendor -> Basket -> Add to basket -> From an existing
  record -> Search
  - Datatables, View MARC modal
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a new
  (empty) record
  - Form validation, inactive fund control, add users to notify on
    receiving.
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a
  subscription -> Search
  - Datatables, show only renewed, show/hide search form
- Acquisitions -> Vendor -> Basket -> Add to basket -> From a suggestion
  - Datatables, "Show" controls
- Acquisitions
  - "Ordered" link in table of funds
    - Datatables
- Acquisitions -> Vendor -> Receive shipment -> Invoice -> Receive
  - Datepickers, item add form plugins (test with AcqCreateItem set to
    'receiving an order.'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 19:38:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 18:38:30 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-PoSAxTemr4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69310|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69544&action=edit
Bug 18731: OpenAPI definitions

This patch introduces the OpenAPI definitions required for the orders
endpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 19:43:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 18:43:13 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-AQucCFEqyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #38 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69545&action=edit
Bug 19410: (followup) Add reserved params definitions

This patch re-adds some parameters I left out during some rebasing tasks
and ended up on a separate patchset (bug 18731).

The introduced parameters definitions are only used on endpoint definitions
that implement (at least) pagination. No need to test them here but easier
adding them here than on a patch implementing a new enpoint, which would become
a dependency for other endpoints.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:44:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:44:59 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-jPDhize34R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63649|0                           |1
        is obsolete|                            |

--- Comment #53 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69546&action=edit
Bug 16330: REST API: add routes to add, update and delete patrons

This patch adds support for add, edit and delete patrons via REST API.

GET  /api/v1/patrons                   Get patron list from params
GET  /api/v1/patrons/<borrowernumber>  Get single patron
POST /api/v1/patrons                   Create a new patron
PUT  /api/v1/patrons/<borrowernumber>  Update data about patron
DEL  /api/v1/patrons/<borrowernumber>  Delete a patron

Revised Test plan:
1) Apply this patch
2) Run tests perl t/db_dependent/api/v1/patrons.t
3) Add a user with proper rights to use the REST API
4) play with your favourite REST client (curl/httpie, etc.):
   Authenticate with the user created above and get a CGISESSION id.
   Use the CGISESSION to add, edit and delete patrons via the API.
5) Use PUT /patrons/<borrowernumber> for a patron without borrowers
   flag. This should go into pending patron modification status and
   needs to be accepted by a librarian.

Please note there is no validation of body input in PUT/POST other
than branchcode,category,userid,cardnumber.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:45:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:45:14 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-3hHSUeifkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63650|0                           |1
        is obsolete|                            |

--- Comment #54 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69547&action=edit
Bug 16330: Spot unchanged modification-request in Koha::Patron::Modification

Throw Koha::Exceptions::NoChanges if attempting to create a modification
request
without changing anything.

This exception is caught in Patron REST API controller.

Also, validate changes via Koha::Patron->_validate

To test:
1. prove t/db_dependent/Koha/Patron/Modifications.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:45:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:45:26 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-ELe2fdZzlR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #55 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69548&action=edit
Bug 16330: Move patches to OpenAPI

This patch refactors the original work so it implements the controllers
and the spec using Mojolicious::Plugin::OpenAPI, and OpenAPI for the
specification.

It removes the ability for patrons without permissions to edit their own data
or their
guarantee's. This will be moved to a patron modification requests endpoint for
simplicity.

It makes use of bugs 19410 and 19686 and their dependencies to deal with
parameters handling,
query building and pagination.

Tests are adapted.

To test:
- Apply this patches and the dependencies
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:45:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:45:42 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-zZWsL6qnn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #56 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69549&action=edit
Bug 16330: (QA followup) fix spelling in comment

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:45:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:45:53 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-vmvUxZRads@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #57 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69550&action=edit
Bug 16330: (QA followup) Add missing POD for exceptions

This patch adds POD to the exceptions files introduced by this patchset.

Note: the qa scripts give false positives on Exceptions. But the patchset
was missing them anyway.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:46:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:46:06 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-51XDP4ucHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #58 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69551&action=edit
Bug 16330: (QA followup) Repect guidelines on plurals Patron > Patrons

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:51:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:51:57 +0000
Subject: [Koha-bugs] [Bug 7999] send test notice
In-Reply-To: <bug-7999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7999-70-edkfW4dCeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7999

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:55:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:55:19 +0000
Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
In-Reply-To: <bug-16846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16846-70-EIU37Y4mS4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16330                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:55:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:55:19 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-Je1vkW7juc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
   Patch complexity|Small patch                 |Medium patch
         QA Contact|                            |tomascohen at gmail.com
         Depends on|16846                       |19410
           Severity|enhancement                 |new feature

--- Comment #59 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I've rebased the previous work, and moved the code so it uses OpenAPI.

As the commit message ('Move patches to OpenAPI' patch) explains. I removed the
portion that dealt with patron modification requests.

I also make use of the helper functions introduced by bug 19410, bug 19686 and
their dependencies.

Benjamin, Lari and everyone involved. Please test the changes I made (big
changes) and please add your signatures to the patchset. Once you (or others)
test it, we can move forward with the QA process.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
[Bug 16846] Move patron related code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Add a helper function for generating object searches for the API
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 20:55:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 19:55:19 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-GIgc9P5fgm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 21:02:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 20:02:58 +0000
Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly
 decrements accrued overdue fines
In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14591-70-pgyxXdfjuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec  5 23:04:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 05 Dec 2017 22:04:11 +0000
Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly
 decrements accrued overdue fines
In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14591-70-1eNalgP4gS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure if this is still valid, certainly should be retested after over 2
years and changes made to fine calculations.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 02:04:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 01:04:17 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-h6xgVdUY6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #143 from David Cook <dcook at prosentient.com.au> ---
Recently, I've been working on a different Linked Data system, and it's got me
thinking that I actually want to save the incoming RDFXML in Koha's MySQL
database. 

The reason for this is simply to keep the source data on-hand in the event that
we need to rebuild the triplestore. 

While reading about Fuseki TDB database corruption, there is talk about
rebuilding from the original source data and the only realistic way of doing
that with RDFXML harvested by OAI-PMH is to have that RDFXML stored as blobs
locally outside the triplestore too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 02:19:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 01:19:49 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-SMMVkj8PoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

Laura <ljohnson at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|ljohnson at roseville.ca.us    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 02:40:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 01:40:29 +0000
Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change
 tool displayed after running Koha update
In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18645-70-1vvIpraf0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 07:52:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 06:52:36 +0000
Subject: [Koha-bugs] [Bug 19689] Koha Offline Circulation Firefox plugin
 sends entries with wrong branchcode without error
In-Reply-To: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19689-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19689-70-SbF9TThdbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
yay!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 12:41:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 11:41:34 +0000
Subject: [Koha-bugs] [Bug 19756] New: Strange upgrade message from
	updatedatabase.pl
Message-ID: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

            Bug ID: 19756
           Summary: Strange upgrade message from updatedatabase.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: veron at veron.ch
        QA Contact: testopia at bugs.koha-community.org

Created attachment 69552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69552&action=edit
Strange message while upgrading to 17.12.00.000

Upgrading to current master (17.12.00.0000) displays a strange message (seems
to be encoding problem).
See screenshot from Firefox ESR 45.3.0

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:01:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:01:32 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-m9wtCNFE3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69207|0                           |1
        is obsolete|                            |

--- Comment #28 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69553&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:01:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:01:52 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-cCRrGjjuKo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:02:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:02:41 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-mnqNUuIxB3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #29 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Hello Olivier,

Please re-try with this patch (just a typo in the previous).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:07:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:07:36 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-fA56v1fPrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |simon.pouchol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:07:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:07:20 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-CkTZJcjwM4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69481|0                           |1
        is obsolete|                            |

--- Comment #4 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69554&action=edit
Bug 19700: Move template JavaScript to the footer: Some circulation pages

This patch modifies some staff client circulation templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Article requests (enable ArticleRequests system preference, have at
  least one outstanding article request)
  - Request article (Bibliographic detail page -> Request article).
- Item circulation statistics (Bibliographic detail page -> Items ->
  View item's checkout history).
- On-site checkouts (enable OnSiteCheckouts system preference; Check out
  some items as on-site checkouts; Go to Circulation ->
  Pending on-site checkouts
- Overdues report (Circulation -> Overdues).
- Holds to pull (Circulation -> Holds to pull).
- Renew
- Holds ratios (Circulation -> Holds ratios).
- Check in
- Transfers to receive (Circulation -> Transfers to receive).
- Holds queue (Circulation -> Holds queue).
- Holds awaiting pickup (Circulation -> Holds awaiting pickup).

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:12:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:12:24 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-1psiWFcghr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|18230                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230
[Bug 18230] Generate Koha::Patron::Modification verification_token in ->new
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:12:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:12:24 +0000
Subject: [Koha-bugs] [Bug 18230] Generate Koha::Patron::Modification
 verification_token in -> new
In-Reply-To: <bug-18230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18230-70-FhKCYVY5IK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18230

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|16330                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:13:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:13:15 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-SudENjMw2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 14:54:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 13:54:06 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-mIZGuM0NZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:26:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:26:01 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-eiJ8oBDO3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
           Assignee|mail at jkozlovsky.cz          |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:29:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:29:38 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-1n6ciIJF57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Severity|enhancement                 |minor
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:29:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:29:47 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-nRZOWCc9CR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
            Version|unspecified                 |master
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:31:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:31:59 +0000
Subject: [Koha-bugs] [Bug 16825] Add API route for getting an item
In-Reply-To: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16825-70-83huLbh0pH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REST API: Add API route for |Add API route for getting
                   |getting an item             |an item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:42:36 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-8FEU4fouJj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:42:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:42:43 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-cOGWRsPLUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69048|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69555&action=edit
Bug 19592: Move admin templates JavaScript to the footer: Acquisitions

This patch modifies the staff client acquisitions-related adminisration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:43:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:43:22 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-e1U4CtEnbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:48:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:48:58 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-SwRT76JyLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:49:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:49:02 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-M44WOq6wKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69211|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69556&action=edit
Bug 19647: Move patron lists templates JS to the footer

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

This patch adds a new JS file, tools-menu.js, which will be added to
each template which has the Tools sidebar menu. Highlighting of the
current page in the sidebar menu will be broken for pages which have not
been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.
resolved the issue, sorry about that, everything is working fine!Signed-off-by:
Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:52:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:52:33 +0000
Subject: [Koha-bugs] [Bug 19757] Add routes to handle vendor contacts
In-Reply-To: <bug-19757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19757-70-8vYeVwLQda@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19757

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:52:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:52:21 +0000
Subject: [Koha-bugs] [Bug 19757] New: Add routes to handle vendor contacts
Message-ID: <bug-19757-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19757

            Bug ID: 19757
           Summary: Add routes to handle vendor contacts
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

We should have routes to handle vendor contacts

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:52:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:52:56 +0000
Subject: [Koha-bugs] [Bug 19757] Add routes to handle vendor contacts
In-Reply-To: <bug-19757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19757-70-1nRoq8lKpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19757

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19686, 19250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686
[Bug 19686] objects.search helper needs a to_model param
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:52:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:52:56 +0000
Subject: [Koha-bugs] [Bug 19250] Add pagination to /acquisitions/vendors
In-Reply-To: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19250-70-rg7ncK4X2M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19757
[Bug 19757] Add routes to handle vendor contacts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:52:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:52:56 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-5q1enEfg0K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19757
[Bug 19757] Add routes to handle vendor contacts
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 15:53:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 14:53:02 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-QxyyZVMFcq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:22:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:22:50 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-tsPRn4fCNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:22:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:22:54 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-5pgE2SlIZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69557&action=edit
Bug 19647: Move patron lists templates JS to the footer

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

This patch adds a new JS file, tools-menu.js, which will be added to
each template which has the Tools sidebar menu. Highlighting of the
current page in the sidebar menu will be broken for pages which have not
been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.
resolved the issue, sorry about that, everything is working fine!Signed-off-by:
Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:25:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:25:29 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-lsZf60obiD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69427|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69558&action=edit
Bug 19653: Move tools templates JavaScript to the footer: Additional tools

This patch modifies the staff client "Additional tools" templates so
that JavaScript is included in the footer instead of the header:

- Calendar
- CSV profiles
- Log viewer
- News
- Task scheduler
- Edit quotes for QOTD feature
- Upload

Note that the log viewer template has been modified so that the
"interface" variable (passed to the template to provide the correct path
to staff client assets) isn't overwritten by an "interface" variable
required by the log viewer.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:25:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:25:32 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-byIUXQhdCR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69559&action=edit
Bug 19653: (QA followup) - Add bold style to quotes menu item on quotes-upload
page

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:25:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:25:50 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-sETciL3r6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
  Attachment #69557|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:26:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:26:16 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-qdWbiZs7nD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:27:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:27:15 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-Pnk4jyBzg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
           Assignee|josef.moravec at gmail.com     |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:29:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:29:33 +0000
Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer:
 Acquisitions, part 3
In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19755-70-HMfxkA8I7G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:29:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:29:36 +0000
Subject: [Koha-bugs] [Bug 19755] Move template JavaScript to the footer:
 Acquisitions, part 3
In-Reply-To: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19755-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19755-70-Y6bvlk8HVT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69560&action=edit
Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3

This patch modifies even more staff client acquisitions templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Acquisitions -> Vendor -> Vendor details
  - Contracts datatable
  - Edit vendor
    - Add contacts, form validation
- Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt"
  - Datatables, MARC and Card previews
    - Transfer
      - Confirmation of transfer, window closes
- Acquisitions -> Vendor -> Receive shipments
  - Datatables, date pickers
- Acquisitions -> Available funds table -> Spent report
  - Datatables
- Acquisitions -> Vendor -> Uncertain prices
  - Datatables, form validation
- Acquisitions -> Vendor -> Basket -> Add to basket from external source
  - Select and clear all on search form
  - Search results
    - Datatables, MARC and Card previews, in-table pop-up controls
      (click any table cell)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:30:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:30:59 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-QYNIZIMROy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:41:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:41:24 +0000
Subject: [Koha-bugs] [Bug 19758] New: Move template JavaScript to the
 footer: Serials, part 1
Message-ID: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

            Bug ID: 19758
           Summary: Move template JavaScript to the footer: Serials, part
                    1
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 19754

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for some of the serials templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754
[Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:41:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:41:24 +0000
Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer:
 Acquisitions, part 2
In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19754-70-TU4Bx6IoCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19758


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758
[Bug 19758] Move template JavaScript to the footer: Serials, part 1
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:42:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:42:28 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-BZjIovuCe9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19754                       |17858


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754
[Bug 19754] Move template JavaScript to the footer: Acquisitions, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:42:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:42:28 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-oHQg1WPNax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19758


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758
[Bug 19758] Move template JavaScript to the footer: Serials, part 1
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:42:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:42:28 +0000
Subject: [Koha-bugs] [Bug 19754] Move template JavaScript to the footer:
 Acquisitions, part 2
In-Reply-To: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19754-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19754-70-4OyaWOtLcJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19754

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19758                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758
[Bug 19758] Move template JavaScript to the footer: Serials, part 1
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 16:53:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 15:53:41 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-a77wtVe80B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Ok, so let's say we go with a new pref "UpdateItemWhenLost".
It will get used when an item is marked as lost. It will work for notforloan
and other values, but for "itemlost" the behaviour will be weird:
If you mark an item as lost from the batch item tool or the item list view, you
will select a value for itemlost already.

So we could restrict the pref to the "Holds awaiting pickup" page (pref
UpdateItemWhenMarkedLostFromHoldsAwaitingPickup ??)

Another idea/remark?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:06:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:06:56 +0000
Subject: [Koha-bugs] [Bug 19759] New: TestBuilder generates too many
	decimals for float
Message-ID: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

            Bug ID: 19759
           Summary: TestBuilder generates too many decimals for float
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

For instance items.replacementprice is decimal(8,2) but more than 2 decimals
are generated.

It leads to issues when we compare expected objects:

    #          got: '135623.866142537'
    #     expected: '135623.87'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:07:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:07:41 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-KhuOaOLBZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:07:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:07:43 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-13ipvu6L3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69421|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69561&action=edit
Bug 19710: Move plugins templates javascript to the footer

This patch modifies the staff client plugins template so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
the modified template:

- The plugins link should be bold in the sidebar menu.
- Choosing "Uninstall" for an installed plugin should trigger a
  confirmation alert.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:08:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:08:04 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-8tNY71aLRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:09:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:09:24 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-0XeuUlwjO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:09:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:09:28 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-h5lAOKSyaS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69562&action=edit
Bug 19759: Make TestBuilder generates only 2 decimals for float

For instance items.replacementprice is decimal(8,2) but more than 2 decimals
are generated.

It leads to issues when we compare expected objects:

    #          got: '135623.866142537'
    #     expected: '135623.87'

Test plan:
  prove t/db_dependent/TestBuilder.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:09:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:09:52 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-nUiZ6x5Ner@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19759


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759
[Bug 19759] TestBuilder generates too many decimals for float
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:09:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:09:52 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-RPj8zzjZJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19287


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287
[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup'
list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:17:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:17:40 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-RfVBpSZslU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69505|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69563&action=edit
Bug 19656: Move rotating collections templates JS to the footer

This patch modifies the staff client's rotating collections templates so
that JavaScript is included in the footer instead of the header.

The patch moves JavaScript from each template and the rotating
collections toolbar into a single external JavaScript file.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:17:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:17:43 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-1e5zrUqqRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69564&action=edit
Bug 19656: (QA followup) Add bold style to rotating colections menu item

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:18:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:18:15 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-RcnBZmy9rt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Nice work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:25:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:25:21 +0000
Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files
	after upgrade
In-Reply-To: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12904-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12904-70-TrTpts2BbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:39:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:39:21 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-9miJXQLqQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:39:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:39:24 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-mLbzwrzX8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69266|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69565&action=edit
Bug 19672: Move tools templates JavaScript to the footer: More MARC tools

This patch modifies some staff client templates from the "Tools"
section so that JavaScript is included in the footer instead of the
header.

- Automatic item modifications by age
- MARC modification templates
- Stage MARC records for import
- Staged MARC record management

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:41:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:41:28 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-WKLUd73ufO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, still not quite understanding it :)

Why the holds awaiting pickup list? That would mean, you got the book for the
patron, you checked it in, you sent the email notice to the patron and THEN you
notice it's actually not there... ? Wouldn't it make more sense to this from
the holds queue or holds to pull pages that you use when looking for the item?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:42:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:42:02 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-jeyHO4OI0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:44:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:44:53 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-6SYZE7JsXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69562|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69566&action=edit
Bug 19759: Make TestBuilder generates only 2 decimals for float

For instance items.replacementprice is decimal(8,2) but more than 2 decimals
are generated.

It leads to issues when we compare expected objects:

    #          got: '135623.866142537'
    #     expected: '135623.87'

Test plan:
  prove t/db_dependent/TestBuilder.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:54:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:54:25 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-vA3jVuhyD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:54:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:54:28 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-Ff3dkk7TCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69312|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69567&action=edit
Bug 19679: Move templates JavaScript to the footer: More tools templates

This patch modifies more staff client tools templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  Export data
  Inventory
  Notices & slips
  Upload local cover image

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:54:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:54:44 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-9epotsk9H3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:58:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:58:00 +0000
Subject: [Koha-bugs] [Bug 19760] New: Die instead of warn if koha-conf is
	not accessible
Message-ID: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

            Bug ID: 19760
           Summary: Die instead of warn if koha-conf is not accessible
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

We got a lot of support questions because scripts are executed without the
correct environment/user.
We could die and provide more useful information

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:58:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:58:45 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-9V11viO8j5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 17:58:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 16:58:49 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-e04rnndhdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69568&action=edit
Bug 19760: Die if koha-conf is not accessible

We got a lot of support questions because scripts are executed without
the correct environment/user.
We could die and provide more useful information

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:00:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:00:44 +0000
Subject: [Koha-bugs] [Bug 8214] Create a bound with function
In-Reply-To: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8214-70-d6RcUu53Ou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #7 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I'm looking at some of the old reopened bug reports in Koha.  I wonder if this
one could be thought of as similar to Bug 11175, which is talking about
searching "host" records and showing their "child" component parts? That sounds
terribly similar to searching for the bound USGS volume (the "host" record) and
showing details of bulletins 12 and 13 inside it (the "child" records).

If 11175 is covering the same ground as this patch, could we mark this one as a
duplicate, as 11175 seems to be further along and has patches (although the
code will need rebasing if it is to get into master)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:03:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:03:04 +0000
Subject: [Koha-bugs] [Bug 5364] Limit the number of author displayed on OPAC
In-Reply-To: <bug-5364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5364-70-fEtoZUhgic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5364

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Do you have a MARC record that I could use to look at this issue?  The two
links in the case have both suffered from "bit rot" and lead to 404 not found
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:07:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:07:05 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-9IyyOcUs0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:07:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:07:07 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-oc3AfNyphr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69501|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69569&action=edit
Bug 19680: Move JS to the footer: Patron and circulation tools

This patch modifies more staff client patrons and circulation tools
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Batch patron deletion/anonymization
  - Overdue notice/status triggers
  - Batch patron modification

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:07:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:07:24 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-b6A25buRwV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:08:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:08:26 +0000
Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout
In-Reply-To: <bug-15464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15464-70-O4ewANp68r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #24 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Can we assume this bug is fixed as there hasn't been any response on it for
over a year now?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:14:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:14:12 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-5j4mzqXm1l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #18 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Owen Leonard from comment #16)
> > Should we still reject brachcodes with whitespace characters?
> 
> Yes I think so (for command line scripts)

I agree

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:27:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:27:22 +0000
Subject: [Koha-bugs] [Bug 5364] Limit the number of author displayed on OPAC
In-Reply-To: <bug-5364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5364-70-wCKmEQAuWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5364

Zachary Spalding <spalding at senylrc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:27:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:27:42 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-IxMGr8l9fR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

J Schmidt <jschmidt at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:31:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:31:52 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-rjT6NpQDgz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:31:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:31:55 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-y4p2g4kIDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69570&action=edit
Bug 19758: Move template JavaScript to the footer: Serials, part 1

This patch modifies some staff client serials templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Serials -> New subscription
  - Search for a vendor
    - "Choose" link and "Cancel" button should work correctly
  - Search for record
    - "Choose" link and "Cancel" button should word correctly
- Serials -> Add subscription fields
  - Datatable, delete confirmation
  - Edit
    - Form validation (submit both authorised value and MARC field)
- Serials -> Check expiration
  - Date picker in search form
  - Search
    - Renew button triggers popup
- Serials -> Claims -> Search results
  - Date picker, datatable, form validation
  - Select all/none; Download claims

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:32:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:32:22 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-AKLBEXUOv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19761


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761
[Bug 19761] Move template JavaScript to the footer: Serials, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:32:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:32:22 +0000
Subject: [Koha-bugs] [Bug 19761] New: Move template JavaScript to the
 footer: Serials, part 2
Message-ID: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

            Bug ID: 19761
           Summary: Move template JavaScript to the footer: Serials, part
                    2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for more of the serials templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:35:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:35:48 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-g2SUrqw9ns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jens Weber <jens.weber at phsh.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jens.weber at phsh.ch
             Status|CLOSED                      |REOPENED
         Resolution|FIXED                       |---
   Patch complexity|Trivial patch               |String patch

--- Comment #8 from Jens Weber <jens.weber at phsh.ch> ---
I agree with Nicole that this has to be changed in the preference description
just the same!
(I hope it is okay I didn't file a new bug on this ...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:55:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:55:48 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-B9QFwNKPkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10306
             Status|Passed QA                   |Patch doesn't apply

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I will need this to be based on top of bug 10306.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306
[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per
kohafield (for say 260/RDA 264)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:55:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:55:48 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-E4wIXlwn9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:59:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:59:57 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-8R3jz45LXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69568|0                           |1
        is obsolete|                            |

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69571&action=edit
Bug 19760: Die if koha-conf is not accessible

We got a lot of support questions because scripts are executed without
the correct environment/user.
We could die and provide more useful information

Tested on my kohadevbox VM by:

1) sudo chmod a-rx /etc/koha/sites/kohadev/koha-conf.xml
2) run help.pl from the command line to produce the desired die message
3) sudo chmod a+rx /etc/koha/sites/kohadev/koha-conf.xml
4) rerun help.pl successfully

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 18:59:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 17:59:54 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-MiJmpYBZrA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 19:26:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 18:26:08 +0000
Subject: [Koha-bugs] [Bug 19762] New: PREDUE notices should be not applied
 when OverdueNoticeCalendar is activate
Message-ID: <bug-19762-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762

            Bug ID: 19762
           Summary: PREDUE notices should be not applied when
                    OverdueNoticeCalendar is activate
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org

Hi, 

It would be great if the OverdueNoticeCalendar systeme preference could be set
for the PREDUE notices too. For exemple a student receive his predue notices
for document on saturday, but the library is closed for the week end, this
student should not had receive this notification on saturday because it cause
misunderstanding. It cause so many incomprehension for the user to receive this
notifications when the library is closed. So, if the OverdueNoticeCalendar
could take into consideration this notification too it would more
understandable for students. Or, it could be an option. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 19:45:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 18:45:22 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-LPkCMeMdRW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69496|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69572&action=edit
Bug 19594: Move admin templates JavaScript to the footer: MARC-related

This patch modifies the staff client MARC-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of the
cart: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 19:45:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 18:45:20 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-syAH1pJzFb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 19:53:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 18:53:35 +0000
Subject: [Koha-bugs] [Bug 17153] Logging in during a search navigates to
 account page instead of back to search results
In-Reply-To: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17153-70-AGlr8UU5bz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:03:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:03:32 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-Y4PcVrEWJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69514|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:03:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:03:50 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-rz4KkG2wn5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69518|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:03:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:03:36 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-zuVLOiXd9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69515|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:03:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:03:41 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-QroMjmweQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69516|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:03:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:03:45 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-6xCsNPv0ba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69517|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:03:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:03:58 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-thp3c1MdoI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69520|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:03:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:03:54 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-drFiZVQ2JO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69519|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:03 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-imewAOK8gF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69521|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:17 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-Qmj8P5Iqk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69523|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:25 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-mJgIpIj6nn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69524|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:30 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-2ccjySs7Y2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69525|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:10 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-9nVZPfnflD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69522|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:34 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-OFO757TzQs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69526|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:39 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-zkuEhjZZnw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69527|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:47 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-GRIzm5wajM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69529|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:04:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:04:43 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-rsAkst4MBT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69528|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:05:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:05:32 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-NOYycWbM48@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #207 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69574&action=edit
Bug 15707: Add Koha::Library::Group(s) modules

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:05:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:05:26 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-accdq4hcVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #206 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69573&action=edit
Bug 15707: Update DB

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:05:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:05:50 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-AtQng3J2Kn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #210 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69577&action=edit
Bug 15707: Fix conflict with bug 15446 (type vs _type)

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:05:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:05:44 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-fCQ0ZQjiit@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #209 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69576&action=edit
Bug 15707: Unit Tests

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:08 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-qOzLz2P8Us@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #212 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69579&action=edit
Bug 15707: (QA followup) Drop table if exists

1/ DROP table if exists
2/ FAIL   spelling
    decendents  ==> descendants

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:05:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:05:38 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-oj7g1ce4MF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #208 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69575&action=edit
Bug 15707: Add library groups editor

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:20 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-nD26v29tbi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #214 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69581&action=edit
Bug 15707: (QA followup) Remove class for treegrid

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:14 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-kqpRqTPhq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #213 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69580&action=edit
Bug 15707: (QA followup) Fix UI issues

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:05:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:05:56 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-nf5pM2ZDUW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #211 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69578&action=edit
Bug 15707: (QA followup) Switch to treetable which Koha already uses

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:26 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-Pongl3u2yg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #215 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69582&action=edit
Bug 15707: (QA followup) Allow object names to be styled without impeding
translation

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:39 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-kxH10yJjN4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #217 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69584&action=edit
Bug 15707: Switch datetimes to timestamps

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:45 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-Vozk9mSVym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #218 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69585&action=edit
Bug 15707: Add UNIQUE constraint to library groups table

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:33 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-1yiE8dy1Im@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #216 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69583&action=edit
Bug 15707: (followup) use cat-search instead of cities-search in header

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:51 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-KN63WK3yT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #219 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69586&action=edit
Bug 15707: Updates for Bootstrap 3

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:06:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:06:59 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-RomNiM1Fym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #220 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69587&action=edit
Bug 15707: Display error if group title is already used

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Edit: I added !$branchcode && to the checked condition so we can add multiple
libraries back.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:07:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:07:06 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-tymDVWjjkL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #221 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69588&action=edit
Bug 15707: DBIC Schema files

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:10:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:10:42 +0000
Subject: [Koha-bugs] [Bug 19763] New: Improve the close budget screen
Message-ID: <bug-19763-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19763

            Bug ID: 19763
           Summary: Improve the close budget screen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When closing a budget the message once orders are resolved is:
There are no unreceived orders for this budget. Back

Perhaps a message that the budget is ready to be closed, or a link to make the
budget inactive and locked would be helpful to the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:13:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:13:16 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-aYJj5i34oo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Large patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:13:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:13:23 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-upq3jo41hQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #222 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69589&action=edit
Bug 15707: (QA followup) Style buttons correctly

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:18:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:18:06 +0000
Subject: [Koha-bugs] [Bug 19764] New: possibility to sort list by decreasing
	date
Message-ID: <bug-19764-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19764

            Bug ID: 19764
           Summary: possibility to sort list by decreasing date
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi,

It would nice if in a list at the OPAC to had the possibility to sort by
decreasing date and vice versa. Actually, we can only sort by ascending
copyright date and it would be graete for the user to have the possibility to
chose ascending ou decreasing date. 

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:24:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:24:25 +0000
Subject: [Koha-bugs] [Bug 19765] New: Special library groups should have a
 'translated' title and should not be editable
Message-ID: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765

            Bug ID: 19765
           Summary: Special library groups should have a 'translated'
                    title and should not be editable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16735

Built-in library groups start and end with "__" as defined in bug 16735. We
should translate the title to something readable and prevent them from being
edited and deleted.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735
[Bug 16735] Replace existing library search groups functionality with the new
hierarchical groups system
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:24:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:24:25 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-CRTJe2rmYj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19765


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765
[Bug 19765] Special library groups should have a 'translated' title and should
not be editable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:24:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:24:31 +0000
Subject: [Koha-bugs] [Bug 19765] Special library groups should have a
 'translated' title and should not be editable
In-Reply-To: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19765-70-5GKLLlIstO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:26:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:26:31 +0000
Subject: [Koha-bugs] [Bug 19765] Special library groups should have a
 'translated' title and should not be editable
In-Reply-To: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19765-70-sbjDZrBPwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:26:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:26:33 +0000
Subject: [Koha-bugs] [Bug 19765] Special library groups should have a
 'translated' title and should not be editable
In-Reply-To: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19765-70-6xoJ2pfB0V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69590&action=edit
Bug 19765 - Special library groups should have a 'translated' title and should
not be editable

Built-in library groups start and end with "__" as defined in bug 16735. We
should translate the title to something readable and prevent them from being
edited and deleted.

Test Plan:
1) Apply this patch
2) Note you no longer see __SEARCH_GROUPS__ and __SEARCH_GROUPS_OPAC__,
   instead you see a bold emphasised group name in normal language
3) Note you can no longer delete or edit those groups

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:28:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:28:50 +0000
Subject: [Koha-bugs] [Bug 19058] Move C4::Reserves::GetReserveId to
	Koha::Holds
In-Reply-To: <bug-19058-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19058-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19058-70-EqtjTyK7PL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19766


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766
[Bug 19766] Preview routing slip is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:28:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:28:50 +0000
Subject: [Koha-bugs] [Bug 19766] New: Preview routing slip is broken
Message-ID: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

            Bug ID: 19766
           Summary: Preview routing slip is broken
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: critical
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 19058

The method reserve_id is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 859.
The method set is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.
Can't call method "store" on an undefined value at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.


This is caused by
  commit ba1f2f93ef58c8dd935add3e215facdd4a589d12
    Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058
[Bug 19058] Move C4::Reserves::GetReserveId to Koha::Holds
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:35:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:35:32 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-SK6DOfX8ls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:35:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:35:34 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-2xkIYXvE8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69591&action=edit
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip

This patch fixes the following errors:
The method reserve_id is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 859.
The method set is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.
Can't call method "store" on an undefined value at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.

This is caused by
  commit ba1f2f93ef58c8dd935add3e215facdd4a589d12
    Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

We are calling ->reserve_id on a Koha::Holds set.

Test plan:
- Serials -> Find subscription -> "Edit routing list" in the sidebar
- Add 1+ recipients
- Save -> "Save and preview routing slip"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:37:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:37:42 +0000
Subject: [Koha-bugs] [Bug 19765] Special library groups should have a
 'translated' title and should not be editable
In-Reply-To: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19765-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19765-70-hvfP2gfPWS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19765

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:40:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:40:09 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-h2MVdAPEtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:40:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:40:11 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-TENFHiF7bX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69591|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69592&action=edit
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip

This patch fixes the following errors:
The method reserve_id is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 859.
The method set is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.
Can't call method "store" on an undefined value at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.

This is caused by
  commit ba1f2f93ef58c8dd935add3e215facdd4a589d12
    Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

We are calling ->reserve_id on a Koha::Holds set.

Test plan:
- Serials -> Find subscription -> "Edit routing list" in the sidebar
- Add 1+ recipients
- Save -> "Save and preview routing slip"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:42:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:42:55 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-MLcy0igUrI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19766


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766
[Bug 19766] Preview routing slip is broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:42:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:42:55 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-8qG82VH0Hh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19761


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761
[Bug 19761] Move template JavaScript to the footer: Serials, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 20:56:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 19:56:00 +0000
Subject: [Koha-bugs] [Bug 19767] New: serial-issues.pl is unused and should
	be removed
Message-ID: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

            Bug ID: 19767
           Summary: serial-issues.pl is unused and should be removed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

serial-issues.pl is not linked to from anywhere in Koha, and should be
considered obsolete. It and its associated templates should be removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 21:00:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 20:00:53 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-0gNb7qnWyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It would be good to get a confirmation from the list

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 21:29:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 20:29:28 +0000
Subject: [Koha-bugs] [Bug 19768] New: Possibility to chose "Note" tab in
 OpacSerialDefaultTab
Message-ID: <bug-19768-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19768

            Bug ID: 19768
           Summary: Possibility to chose "Note" tab in
                    OpacSerialDefaultTab
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi, 

It would be interesting to have the possib=ility to chose the note tab for the
systeme preference OpacSerialDefaultTab. At the moment, we can only select
subscriptions tab, holdings tab and serial collections tab in this preference.
It would be nice to have the possibiliy to chose an another tab like notes tab. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 21:36:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 20:36:04 +0000
Subject: [Koha-bugs] [Bug 19768] Possibility to choose "Note" tab in
	OpacSerialDefaultTab
In-Reply-To: <bug-19768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19768-70-h3QEvZqFIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19768

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Possibility to chose "Note" |Possibility to choose
                   |tab in OpacSerialDefaultTab |"Note" tab in
                   |                            |OpacSerialDefaultTab

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 21:49:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 20:49:00 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-EZI7x0aURp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 23:08:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 22:08:01 +0000
Subject: [Koha-bugs] [Bug 19762] Add option for PREDUE notices to take
 calendar into account
In-Reply-To: <bug-19762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19762-70-0WnZEZ3YrF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|PREDUE notices should be    |Add option for PREDUE
                   |not applied when            |notices to take calendar
                   |OverdueNoticeCalendar is    |into account
                   |activate                    |
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Currently PREDUE notices are sent X calendar days before the item gets due. I
agree it would be nice if we could use days the library is open before due date
instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 23:17:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 22:17:09 +0000
Subject: [Koha-bugs] [Bug 8214] Create a bound with function
In-Reply-To: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8214-70-6hVDi8NNiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is a difference:

"Bound withs" are on item level. The library might have something twice, but
once it's bound with something else and once it's on its own. That can happen
especially in libraries with old and rare books.

bug 11175 is talking about showing relationships between bibliographic records,
so it's on a different level. For example in Germany for a multi volume work
you'd usually have a 'set record' that represents the whole work and then a
record for each volume. They are tied together using 7xx and 8xx. The goal of
bug 11175 would then be to show the volume records on the set record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 23:25:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 22:25:09 +0000
Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records
 with multiple items where 1 is not available (checked out) but others are
In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13715-70-lLRG9MOwZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

NancyK. <nkeener at washoecounty.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

--- Comment #3 from NancyK. <nkeener at washoecounty.us> ---
After waiting 2 years, we really need to fix this bug.  Its a major flaw.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec  6 23:26:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 06 Dec 2017 22:26:06 +0000
Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records
 with multiple items where 1 is not available (checked out) but others are
In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13715-70-KHWKdjilHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

--- Comment #4 from NancyK. <nkeener at washoecounty.us> ---
After waiting 2 years, we really need to fix this bug.  Its a major flaw.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 06:20:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 05:20:25 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-WNcq1NgvKb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dilan at calyx.net.au

--- Comment #60 from Dilan Johnpull? <dilan at calyx.net.au> ---
Attempted to apply the patch but ran into issues with one of the dependencies.
Attempting the test afterwards just results in a lot of ugly error messages. 

This is the output from git when attempting to apply:

vagrant at kohadevbox:kohaclone((af7d618...))$ git bz apply -s 16330

Bug 16330 Depends on bug 19410
Follow? [(y)es, (n)o] y

Bug 19410 Depends on bug 19234
Follow? [(y)es, (n)o] y
Bug 19234 - Add query parameters handling helpers

69360 - Bug 19234: Unit tests for query parameters handling helpers
69361 - Bug 19234: Add query parameters handling helpers
69362 - Bug 19234: (followup) Make Query plugin available to endpoints

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19234: Unit tests for query parameters handling helpers
Applying: Bug 19234: Add query parameters handling helpers
Applying: Bug 19234: (followup) Make Query plugin available to endpoints

Bug 19410 Depends on bug 19278
Follow? [(y)es, (n)o] y

Bug 19278 Depends on bug 19369
Follow? [(y)es, (n)o] y

Bug 19369 Depends on bug 19234
Follow? [(y)es, (n)o] y
Bug 19234 - Add query parameters handling helpers

69360 - Bug 19234: Unit tests for query parameters handling helpers
69361 - Bug 19234: Add query parameters handling helpers
69362 - Bug 19234: (followup) Make Query plugin available to endpoints

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19234: Unit tests for query parameters handling helpers
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: Bug 19234: Add query parameters handling helpers
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: Bug 19234: (followup) Make Query plugin available to endpoints
Using index info to reconstruct a base tree...
M       Koha/REST/V1.pm
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Bug 19369 - Add a helper function for translating pagination params into
SQL::Abstract

69363 - Bug 19369: Unit tests
69364 - Bug 19369: Add helper function for pagination attributes generation

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19369: Unit tests
Applying: Bug 19369: Add helper function for pagination attributes generation
Bug 19278 - Add a configurable default page size for endpoints

69365 - Bug 19278: Add RESTdefaultPageSize syspref
69366 - Bug 19278: Unit tests
69367 - Bug 19278: Make the pagination plugin use RESTdefaultPageSize
69368 - Bug 19278: Mention RESTdefaultPageSize in POD

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19278: Add RESTdefaultPageSize syspref
Applying: Bug 19278: Unit tests
Applying: Bug 19278: Make the pagination plugin use RESTdefaultPageSize
Applying: Bug 19278: Mention RESTdefaultPageSize in POD

Bug 19410 Depends on bug 19369
Follow? [(y)es, (n)o] y

Bug 19369 Depends on bug 19234
Follow? [(y)es, (n)o] y
Bug 19234 - Add query parameters handling helpers

69360 - Bug 19234: Unit tests for query parameters handling helpers
69361 - Bug 19234: Add query parameters handling helpers
69362 - Bug 19234: (followup) Make Query plugin available to endpoints

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19234: Unit tests for query parameters handling helpers
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: Bug 19234: Add query parameters handling helpers
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: Bug 19234: (followup) Make Query plugin available to endpoints
Using index info to reconstruct a base tree...
M       Koha/REST/V1.pm
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Bug 19369 - Add a helper function for translating pagination params into
SQL::Abstract

69363 - Bug 19369: Unit tests
69364 - Bug 19369: Add helper function for pagination attributes generation

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19369: Unit tests
Using index info to reconstruct a base tree...
M       t/Koha/REST/Plugin/Pagination.t
Falling back to patching base and 3-way merge...
Auto-merging t/Koha/REST/Plugin/Pagination.t
CONFLICT (content): Merge conflict in t/Koha/REST/Plugin/Pagination.t
Failed to merge in the changes.
Patch failed at 0001 Bug 19369: Unit tests
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19369-Unit-tests-aBwR2M.patch

Cannot apply cleanly patches from bug 19369. Everything will be left dirty.
git bz apply --continue will not continue the process if patches from other bug
reports need to be applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 06:49:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 05:49:43 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-sA2nnzWvNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #61 from Dilan Johnpull? <dilan at calyx.net.au> ---
Just attempted applying each dependency manually in order. Have got 16330 to
apply now and will follow test plan instructions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 07:05:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 06:05:20 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-YFGqpdPfC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #62 from Dilan Johnpull? <dilan at calyx.net.au> ---
Still getting error messages when running the test:

vagrant at kohadevbox:kohaclone((8c8b618...))$ sudo perl
t/db_dependent/api/v1/patrons.t
1..5
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
Use of uninitialized value in concatenation (.) or string at C4/Templates.pm
line 154.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
Use of uninitialized value in concatenation (.) or string at
C4/Auth_with_cas.pm line 42.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
243.
Can't call method "config" on unblessed reference at Koha/Database.pm line 56.
# Looks like your test exited with 2 before it could output anything.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:06:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:06:58 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-76QbvU5sqq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #63 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Dilan Johnpull? from comment #62)
> Still getting error messages when running the test:
...
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line

These errors should go away if you do "sudo koha-shell <dev-instance-name>" and
then run the tests from within that koha-shell. 

If you are not on kohadevbox or another gitified setup that can use koha-shell,
you need to include some environment variables in your call to prove, something
like:

$ PERL5LIB=/home/me/kohaclone KOHA_CONF=/home/me/koha-site/koha-conf.xml prove
path/to/test.t

HTH

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:17:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:17:16 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-CFrjWHcoPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:17:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:17:19 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-U2JHFrvLH7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69592|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69593&action=edit
Bug 19766: (bug 19058 follow-up) Fix Preview routing slip

This patch fixes the following errors:
The method reserve_id is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 859.
The method set is not covered by tests at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.
Can't call method "store" on an undefined value at
/home/vagrant/kohaclone/C4/Reserves.pm line 871.

This is caused by
  commit ba1f2f93ef58c8dd935add3e215facdd4a589d12
    Bug 19058: Move C4::Reserves::GetReserveId to the Koha namespace

We are calling ->reserve_id on a Koha::Holds set.

Test plan:
- Serials -> Find subscription -> "Edit routing list" in the sidebar
- Add 1+ recipients
- Save -> "Save and preview routing slip"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:31:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:31:13 +0000
Subject: [Koha-bugs] [Bug 19769] New: 'Pickup library is different' message
 does not display library branch name when placing hold
Message-ID: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

            Bug ID: 19769
           Summary: 'Pickup library is different' message does not display
                    library branch name when placing hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: claire_gravely at hotmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When placing a hold for a patron whose pickup library and home library are
different, the message displayed only shows the branch code and not the branch
name.

To reproduce:
Go to place a hold on an item for a patron whose home library is different to
that of the item. The message: 'Pickup library is different...' will be
displayed but the branch name is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:31:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:31:24 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-D6LSuXalzf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |claire_gravely at hotmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:35:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:35:18 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-48sOH115cN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19647
                 CC|                            |josef.moravec at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647
[Bug 19647] Move patron lists templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:35:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:35:18 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-aXlQLyilUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19627


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627
[Bug 19627] Move patron clubs templates JS to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:37:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:37:19 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-ihKpnxgQa6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:37:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:37:21 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-BYmvKOJAyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

--- Comment #1 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69594&action=edit
When placing a hold for a patron whose pickup library and home library are
different, the message displayed only shows the branch code and not the branch
name.

This patch displays the branch name as well as the branch code.

To test:
1. Search for an item
2. Click 'place hold'
3. Enter patron name/card number for a patron whose home library is
different to the item's
4. Note the message displayed only shows the branch code but not the
name
5. Apply Patch
6. Repeat 1-3
7. Message should not also display the branch name

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 08:38:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 07:38:29 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-fSbbIvBhZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
             Status|Signed Off                  |Failed QA

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
There should be included tools-menu.js file to have menu item styled correctly
I think.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:06:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:06:21 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-PcmOMnAg3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69270|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69595&action=edit
Bug 19628: Move course reserves templates JS to the footer

This patch modifies the staff client course reserves templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables, autocomplete, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:06:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:06:18 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-ZyoFly1JZf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:06:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:06:35 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-hpV1I9mfrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:14:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:14:03 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-XCYPe9D5a6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:14:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:14:06 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-wNYlGiA2l8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69271|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69596&action=edit
Bug 19657: Move lists templates JS to the footer

This patch modifies the staff client's lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
lists page: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:14:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:14:25 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-9eDfcMzVnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:22:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:22:24 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-NtTsHHOBcH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:22:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:22:43 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-oskLt1R1dq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:22:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:22:28 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-ZyoolB8peP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69285|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69597&action=edit
Bug 19659: Move JS to the footer: Suggestions and tags

This patch modifies the staff client's suggestions and tags templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JS file, acquisitions-menu.js, which will be added
to each template which has the Acquisitions sidebar menu (in this case,
suggestions). Highlighting of the current page in the sidebar menu will
be broken for pages which have not been modified to use this file.

To test, apply the patch and test the JavaScript-driven features of
suggestions and tags pages: All button controls, DataTables
functionality, form validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:47:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:47:21 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-m1OnKZ8qRZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Failed QA

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Owen, just a small thing:

the function Dopop in cat_issues_top.tt template should be probably removed, it
is not used if I am reading it right.

Otherwise looks good!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 09:59:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 08:59:35 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-UK6iAD5rSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #144 from Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> ---
Sounds great that work and/or thinking is being done is regards to
harvesting/handling linked data in Koha. But could any potental changes that
result from that please be added as a new patch (on top of this one?) so that
we don't get another iteration of the harvester, before this has the chance to
make it through the QA process!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:05:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:05:15 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-vFo2DjhEjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:05:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:05:31 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-6SNXBDFweB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69412|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69598&action=edit
Bug 19697: Move template JavaScript to the footer: Search results

This patch modifies the staff client catalog search results template so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the various JavaScript-driven features
of the results page: Floating toolbar, cart, lists, cover images, search
to hold, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:05:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:05:27 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-s7XcWzm7rj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:05:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:05:43 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-8Rn4qof4pe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:30:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:30:00 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-ADrHKprY03@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:30:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:30:03 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-wrZjdK9FkK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69554|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69599&action=edit
Bug 19700: Move template JavaScript to the footer: Some circulation pages

This patch modifies some staff client circulation templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Article requests (enable ArticleRequests system preference, have at
  least one outstanding article request)
  - Request article (Bibliographic detail page -> Request article).
- Item circulation statistics (Bibliographic detail page -> Items ->
  View item's checkout history).
- On-site checkouts (enable OnSiteCheckouts system preference; Check out
  some items as on-site checkouts; Go to Circulation ->
  Pending on-site checkouts
- Overdues report (Circulation -> Overdues).
- Holds to pull (Circulation -> Holds to pull).
- Renew
- Holds ratios (Circulation -> Holds ratios).
- Check in
- Transfers to receive (Circulation -> Transfers to receive).
- Holds queue (Circulation -> Holds queue).
- Holds awaiting pickup (Circulation -> Holds awaiting pickup).

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:30:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:30:37 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-LXDrM5CAGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:33:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:33:52 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-x7NIqatrId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:33:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:33:54 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-wB7Kzslaza@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69512|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69600&action=edit
Bug 19751: Holds awaiting pickup report should not be fixed-width

This patch changes the grid used for the holds awaiting pickup report so
that the results are full page and fluid instead of fixed-width.

To test, apply this patch and the patch for Bug 19700 if necessary.

View the holds awaiting pickup report. The report should fluidly fill
the page width.

Test with the CircSidebar system preference enabled and disabled.

Signed-off-by: George Williams <george at nekls.org>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:34:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:34:07 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-jbtxRGO0ce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:40:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:40:12 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-Qx35YnwK1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:40:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:40:16 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-xEuw6GVAOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69500|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69601&action=edit
Bug 19726 - Move admin templates JavaScript to the footer: Preferences

This patch modifies the staff client's system preferences templates so
that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
both the standard and local use system preferences:

 - WYSIWYG editor
 - Confirmation messages
 - Table sorting
 - Multiple selects (CoceProviders for example)

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 10:40:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 09:40:31 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-rBl9VxtkLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 11:00:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 10:00:28 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-DnMDpLWQqU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #64 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Dilan Johnpull? from comment #62)
> Still getting error messages when running the test:
> 
> vagrant at kohadevbox:kohaclone((8c8b618...))$ sudo perl
> t/db_dependent/api/v1/patrons.t
> 1..5
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> Use of uninitialized value in concatenation (.) or string at C4/Templates.pm
> line 154.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> Use of uninitialized value in concatenation (.) or string at
> C4/Auth_with_cas.pm line 42.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line
> 243.
> Can't call method "config" on unblessed reference at Koha/Database.pm line
> 56.
> # Looks like your test exited with 2 before it could output anything.

You need to get into the instance's she'll:
$ sudo koha-shell kohadev
$ cd /home/vagrant/kohaclon

and then run the tests

If your devbox was created recently try

$ kshell

Also, one of the dependencies makes it retire an upgrade, so inside kshell you
need to perform the upgrade:

$ perl installer/data/mysql/updatedatabase.pl

before running the tests. Otherwise you will get tons of 503 errors instead of
the expected results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 11:10:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 10:10:18 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-v8qiNroMET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |claire_gravely at hotmail.com

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Cannot apply when the process reaches bug 19607 (one of the dependencies)

Applying: Bug 19607: Move admin templates JavaScript to the footer: Basic
parameters
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
M       koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 12:10:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 11:10:59 +0000
Subject: [Koha-bugs] [Bug 19629] No translatable notification in overdue
	notices
In-Reply-To: <bug-19629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19629-70-7Q5NySitDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
(In reply to Jonathan Druart from comment #1)
> Will be easy to do using the TT syntax.

Is this solution implementable without a major rework of how the letter is
built?

Relevant parts of the code:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/overdue_notices.pl;h=a1b477c7317c140bd361540fc65086df6c7fb420;hb=HEAD#l687

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/overdue_notices.pl;h=a1b477c7317c140bd361540fc65086df6c7fb420;hb=HEAD#l708

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:08:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:08:51 +0000
Subject: [Koha-bugs] [Bug 19629] No translatable notification in overdue
	notices
In-Reply-To: <bug-19629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19629-70-JmLc6r8zrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Take a look at bug 17967, and then if we can access to Koha.Preference from the
notice template. I think it does not work but it can be done easily with:

@ Letters.pm:1477 @ sub _process_tt {

     my $tt_params = { %{ _get_tt_params( $tables ) }, %{ _get_tt_params(
$loops, 'is_a_loop' ) }, %$substitute };

-    $content = qq|[% USE KohaDates %]$content|;
+    $content = qq|[% USE Koha %][% USE KohaDates %]$content|;

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:38:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:38:54 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-pQmt7TLPFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch has been pushed to master for 18.05.
Congratulations Simon for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:39:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:39:34 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-FChWFwxKmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:39:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:39:41 +0000
Subject: [Koha-bugs] [Bug 18833] plugin unimarc_field_210c pagination error
In-Reply-To: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18833-70-GkoMZahq5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:39:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:39:46 +0000
Subject: [Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS
	correctly
In-Reply-To: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18990-70-luR9m54aJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:39:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:39:49 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-AMU0ppK4RC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|victor.grousset at biblibre.co |simon.pouchol at biblibre.com
                   |m                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:39:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:39:53 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-65XHfVG862@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:40:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:40:00 +0000
Subject: [Koha-bugs] [Bug 19533] Hold pulldown for itemtype is empty if hold
 placement needs override
In-Reply-To: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19533-70-wQEOv0ZLxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:40:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:40:07 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-cZJ0QpJlUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:40:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:40:14 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-a0BN6Fpgy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:40:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:40:20 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-arPa35gm9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:40:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:40:26 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-MorCUssBoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:40:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:40:32 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-pbB31veaP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:40:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:40:42 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-JzMw2x3dz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:48:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:48:43 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-7MtsA7MzRg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #380 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69602&action=edit
Bug 7143: Update about page for new dev - Simon Pouchol

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:56:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:56:01 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-JwXY9iLoDw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 13:56:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 12:56:03 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-5c3XhHKdH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69264|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69603&action=edit
Bug 19663: Move JS to the footer: Reports

This patch modifies the staff client's reports templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
reports pages: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Fix for QA: Remove unused Dopop function.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:02:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:02:07 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-SkuWMkiHXy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69570|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69604&action=edit
Bug 19758: Move template JavaScript to the footer: Serials, part 1

This patch modifies some staff client serials templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Serials -> New subscription
  - Search for a vendor
    - "Choose" link and "Cancel" button should work correctly
  - Search for record
    - "Choose" link and "Cancel" button should word correctly
- Serials -> Add subscription fields
  - Datatable, delete confirmation
  - Edit
    - Form validation (submit both authorised value and MARC field)
- Serials -> Check expiration
  - Date picker in search form
  - Search
    - Renew button triggers popup
- Serials -> Claims -> Search results
  - Date picker, datatable, form validation
  - Select all/none; Download claims

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:02:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:02:04 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-RfkUwNNKuc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:02:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:02:19 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-eF8tkW29hU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19751                       |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751
[Bug 19751] Holds awaiting pickup report should not be fixed-width
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:02:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:02:19 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-ruW2JWF0DP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19700                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700
[Bug 19700] Move template JavaScript to the footer: Some circulation pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:10:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:10:45 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-PgkdSoRyjH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:10:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:10:47 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-StOpaLwiR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69594|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69605&action=edit
Bug 19769: 'Pickup library is different' message does not display library
branch name when placing hold

When placing a hold for a patron whose pickup library and home library
are different, the message displayed only shows the branch code and not
the branch name.

This patch displays the branch name as well as the branch code.

To test:
1. Search for an item
2. Click 'place hold'
3. Enter patron name/card number for a patron whose home library is
   different to the item's
4. Note the message displayed only shows the branch code but not the
   name
5. Apply Patch
6. Repeat 1-3
7. Message should not also display the branch name

https://bugs.koha-community.org/show_bug.cgi?id=19769

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:13:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:13:16 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-SjwcauITDV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:13:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:13:19 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-589uqMace4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69455|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69606&action=edit
Bug 19496: Fixing to_address for patron notes

This patch ensures the patron note to_address is the branch email or the
Koha Admin email, and the from_address is the patron's email.

To test:
1) Ensure syspref 'allowcheckoutnotes' is turned on
2) Go to OPAC, leave a note on a checkout
3) Confirm that the note is received (in mysql message_queue) but the
to_address is the patron's email - this is wrong
4) Apply patch and refresh OPAC
5) Leave a note on a checkout
6) Confirm that the note is received in message queue
7) Confirm that the to_address is one of:
- branch email
- branch reply to
- syspref ReplytoDefault
- syspref KohaAdminEmailAddress
8) Confirm that the from_address is one of:
- patron email
- patron emailpro
- patron B_email

Sponsored-by: Catalyst IT

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:13:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:13:29 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-QKNQ7lMeDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:14:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:14:45 +0000
Subject: [Koha-bugs] [Bug 19770] New: Add cardnumber to holds awaiting
 pickup screen and add classes to borrower info
Message-ID: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

            Bug ID: 19770
           Summary: Add cardnumber to holds awaiting pickup screen and add
                    classes to borrower info
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Some libraries use a combination of borrowers surname and cardnumber on hold
slips, this seems to be a fairly common occurence.

To facilitate this it would be nice to have the cardnumber available on the
waiting holds report.

Additionally it would be nice to have classes add to the borrower information
so that they can be accessed via javascript for constructing the special code
used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:16:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:16:45 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-D6XUZ1h9di@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:16:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:16:54 +0000
Subject: [Koha-bugs] [Bug 19730] misc/export_records.pl should use
 biblio_metadata.timestamp
In-Reply-To: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19730-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19730-70-f5uaphBMlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19730

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:31:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:31:04 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-GhCuv2qhvq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:31:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:31:06 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-ylDX4C90k2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69607&action=edit
Bug 19770 - Add cardnumber to holds awaiting pickup and add classes to borrower
info

To Test:
1 - View the holds awaiting pickup report
2 - Note there is no cardnumber
3 - Apply patch
4 - Cardnumber now shows
5 - Add to IntranetUserCSS
    .borrowercardnumber { display: none; }
6 - Cardnumber does not show
7 - Verify the same works for 'Holds over' tab
8 - Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:33:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:33:32 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-SFFStcKz9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:33:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:33:35 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-aKOM3pKc3m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69608&action=edit
Bug 19627: Follow-up: Include tools-menu.js on required templates

This follow-up adds tools-menu.js to the two patron clubs templates
which include the tools sidebar menu.

The patch also modifies tools-menu.js so that the correct sidebar link
is highlighted when editing or viewing club enrollments.

To test, apply the patch and view the patron clubs main page and the
patron clubs enrollments page. The sidebar menu should have the correct
link highlighted in both cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:40:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:40:18 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-ZhzlPdG0uw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:40:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:40:20 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-oXV9VFlI4Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69605|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69609&action=edit
Bug 19769: 'Pickup library is different' message does not display library
branch name when placing hold

When placing a hold for a patron whose pickup library and home library
are different, the message displayed only shows the branch code and not
the branch name.

This patch displays the branch name as well as the branch code.

To test:
1. Search for an item
2. Click 'place hold'
3. Enter patron name/card number for a patron whose home library is
   different to the item's
4. Note the message displayed only shows the branch code but not the
   name
5. Apply Patch
6. Repeat 1-3
7. Message should now also display the branch name

https://bugs.koha-community.org/show_bug.cgi?id=19769

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:44:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:44:17 +0000
Subject: [Koha-bugs] [Bug 19771] New: Pending offline circulation actions
 page will crash on unknown barcode
Message-ID: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

            Bug ID: 19771
           Summary: Pending offline circulation actions page will crash on
                    unknown barcode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: matthias.meusburger at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Test plan:

Use the koct firefox plugin or a .koc file and make a return with an unknown
barcode.

Display the Pending offline circulation actions page: offline_circ/list.pl

=> The page crashes with a software error: Can't call method "biblio" on an
undefined value at /home/koha/src/offline_circ/list.pl line 50.

Apply the patch, repeat the test plan.

=> The page shows the list correctly. Click on process. The unknown barcode is
marked as Item not found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:46:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:46:51 +0000
Subject: [Koha-bugs] [Bug 19772] New: Wrong success message if PATRON_NOTE
	is not defined
Message-ID: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

            Bug ID: 19772
           Summary: Wrong success message if PATRON_NOTE is not defined
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: aleisha at catalyst.net.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 14224

There is no PATRON_NOTE notice template created for new installation.
If the pref (AllowCheckoutNotes) is set to on, a patron can let a note from the
OPAC and the message "Your note about $TITLE / has been saved and sent to the
library." is display to the screen.

But actually the Koha logs mention "No circulation PATRON_NOTE letter
transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 697." and no
notice is generated


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:46:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:46:51 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14224-70-qoj84OnNus@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19772


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772
[Bug 19772] Wrong success message if PATRON_NOTE is not defined
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:47:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:47:02 +0000
Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page
 will crash on unknown barcode
In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19771-70-6Xfqw9ED9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

--- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 69610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69610&action=edit
Bug 19771: Prevent Pending offline circulation actions page from crashing when
there is an unknown barcode

Test plan:
Use the koct firefox plugin or a .koc file and make a return with an unknown
barcode.
Display the Pending offline circulation actions page: offline_circ/list.pl
=> The page crashes with a software error: Can't call method "biblio" on an
undefined value at /home/koha/src/offline_circ/list.pl line 50.
Apply the patch, repeat the test plan.
=> The page shows the list correctly. Click on process. The unknown barcode is
marked as Item not found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:50:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:50:10 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-Ak49E3scuT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19709                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709
[Bug 19709] Move template JavaScript to the footer: Labels
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:50:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:50:10 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-WI5VWF2IH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19608                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:53:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:53:37 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-Y4OvZcWsGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69611&action=edit
Bug 19496: ReplytoDefault is a pref, not a C4::Context method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:55:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:55:40 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-bh3vKjT6TF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I expect that librarians will get spammed. But as soon as it fixed a major bug
I am going to push this patch.
We should generate a digest for these PATRON_NOTE notice.

See also bug 19772 I found when testing this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:58:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:58:13 +0000
Subject: [Koha-bugs] [Bug 19773] New: Illrequests.t raises a warning
Message-ID: <bug-19773-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19773

            Bug ID: 19773
           Summary: Illrequests.t raises a warning
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 7317

Use of uninitialized value $backend_dir in join or string at
/kohadevbox/koha/Koha/Illrequest.pm line 664.
[13:35:38] t/db_dependent/Illrequests.t ................................... ok 
   3376 ms


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 14:58:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 13:58:13 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-JMAUgeFdHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19773


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19773
[Bug 19773] Illrequests.t raises a warning
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:07:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:07:37 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the
	footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-31bEAGgGgf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:08:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:08:17 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the
	footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-mIjf6zG8Qe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:16:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:16:42 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-BtcOqOWstg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:16:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:16:44 +0000
Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup
 screen and add classes to borrower info
In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19770-70-VsTt2oRpZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69607|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69612&action=edit
Bug 19770 - Add cardnumber to holds awaiting pickup and add classes to borrower
info

To Test:
1 - View the holds awaiting pickup report
2 - Note there is no cardnumber
3 - Apply patch
4 - Cardnumber now shows
5 - Add to IntranetUserCSS
    .borrowercardnumber { display: none; }
6 - Cardnumber does not show
7 - Verify the same works for 'Holds over' tab
8 - Sign off

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:23:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:23:18 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-8HeUgqCiv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:24:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:24:44 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-nvijPyK6W9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:24:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:24:52 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302073
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-V2U3qMlHUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:24:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:24:58 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-0KCNTixGhS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:25:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:25:10 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-gduqII4anT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:25:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:25:04 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-2mhwWYi502@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:25:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:25:17 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-FVkzmdAlGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:25:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:25:24 +0000
Subject: [Koha-bugs] [Bug 18907] Warning "dpkg-source: warning: relation <
 is deprecated: use < < or <="
In-Reply-To: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18907-70-E5Sq78Zy9e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:25:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:25:37 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-OQiel7OPIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:26:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:26:18 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-sQf1cRIN0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch has been pushed to master for 18.05.

Congratulations Victor for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:27:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:27:31 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-s62L4Frg94@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19607                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:27:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:27:31 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-ayUy57OvWv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19594                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:29:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:29:21 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-CwcvSU4hXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #381 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69613&action=edit
Bug 7143: Update about page for new dev - Victor Grousset

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:29:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:29:49 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-q5AENj4wvj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #382 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last two patches pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:38:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:38:08 +0000
Subject: [Koha-bugs] [Bug 19015] Searches fail with error Fielddata is
 disabled on text fields by default for elastic search 5.3 and 5.4
In-Reply-To: <bug-19015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19015-70-YjnOlTYsH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19015

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
I believe this is generally related to the mappings and should be okay for now.
Any sort field or facet I think need to be 'keyword' type rather than enabling
fielddata

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:42:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:42:09 +0000
Subject: [Koha-bugs] [Bug 19425] Adding orders from order file with multiple
 budgets per record triggers error
In-Reply-To: <bug-19425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19425-70-RrifUlzfWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19425

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
16.11.x doesn't have the feature this bug is part of. Marking as resolved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:44:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:44:01 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the
	footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-GjFrGnwFW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:44:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:44:01 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-lBeH2Nc1YO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19641


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:45:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:45:20 +0000
Subject: [Koha-bugs] [Bug 18431] Import hangs when SearchEngine is set to
	ElasticSearch
In-Reply-To: <bug-18431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18431-70-Mv91MDKgra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18431

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |nick at bywatersolutions.com

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
bug 19542 adds ES config to the about page, I think this serves as the warning
error

*** This bug has been marked as a duplicate of bug 19542 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:45:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:45:20 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-rUr2XsaZnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 18431 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:46:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:46:14 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-RfefcK8vF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Failed QA

--- Comment #3 from Claire Gravely <claire_gravely at hotmail.com> ---
When creating/managing batches I had the following issues:

- clicking 'add items' without entering any barcodes opens an empty frame
- When exporting items or a batch, the 'cancel' link in the first frame doesn't
work
- After exporting, the 'done' button doesn't work


The other parts seemed to be ok!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 15:57:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 14:57:28 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14567-70-XoMGOlZmh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64779|0                           |1
        is obsolete|                            |

--- Comment #37 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69614&action=edit
Bug 14567: Add a browse interface to the OPAC

This is an interface for quick and efficient browsing through records.

It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to
enter the prefix of an author, title, or subject and it'll give you a
list of the options that match that. You can then scroll through these
and select the one you're after. Selecting it provides a list of records
that match that particular search.

To Test:
1 - Have ES running and some records in it
2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url
for your site)
3 - Test searching for author, title, and subject
4 - Verify that results are returned in expected order
5 - Experiment with fuzziness
6 - Click any result and verify specific titles are correct
7 - Click through title to record and verify it is the correct record

Signed-off-by: Sebastian Hierl <s.hierl at aarome.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:20:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:20:15 +0000
Subject: [Koha-bugs] [Bug 19774] New: Adapt existing endpoints to new naming
	guidelines
Message-ID: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774

            Bug ID: 19774
           Summary: Adapt existing endpoints to new naming guidelines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

Some changes to attribute names need to be implemented for consistency. This
was discussed here
http://lists.koha-community.org/pipermail/koha-devel/2017-March/043576.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:24:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:24:51 +0000
Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming
	guidelines
In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19774-70-cQb4dKCgeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16330
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:24:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:24:51 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-KIyRNcJBqA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774
[Bug 19774] Adapt existing endpoints to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:40:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:40:41 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-yDhDIQTE1w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:40:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:40:44 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-oFGb5udkoM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68935|0                           |1
        is obsolete|                            |
  Attachment #68936|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69615&action=edit
Bug 19542: Add a check for ES configuration health

This patch adds a new statuc function to Koha::SearchEngine::ElasticSearch
which is instended to replace most of get_elasticsearch_params. This function
reads the configuration from C4::Context->config('elasticsearch') and raises
relevant exceptions when mandatory entries are missing.

Its behaviour is covered by tests.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:40:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:40:47 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-tvDg1OSBws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69616&action=edit
Bug 19542: Add Elasticsearch information in the 'About' page

This patch adds Elasticsearch related information to the 'About' page.

The information is gathered and displayed only when the 'SearchEngine' syspref
is set to 'Elasticsearch'. It displays configured nodes, and the status:
- Running
- Not running

In case it is running, it displays the defined indices and the document count
on each.
If there are configuration problems, exceptions are catch and a convenient
warning
message is displayed.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Have ES configured in your koha-conf.xml file (by default in kohadevbox)
- Set the 'SearchEngine' syspref to 'Elasticsearch'
- Comment out pieces of the elasticsearch-specific entries (server, index_name,
  the whole elasticsearch block). Reload on each change.
=> SUCCESS: Warning messages are displayed and make sense in the context of
your changes.
----> the rest of the tests require having ES running on the dev env. This can
be easily
      achieved by creating the kohadevbox using:
        $ KOHA_ELASTICSEARCH=1 vagrant up
- Stop the 'elasticsearch' service:
  $ sudo service elasticsearch stop
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, and the status is 'not running'
- Start the 'elasticsearch' service:
  $ sudo service elasticsearch start
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, the status is 'running' and
            created indices info is displayed, along with the document count
            on each index.
- Sign off :-D

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:40:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:40:49 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-4jO2udfloW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69617&action=edit
Bug 19542 - QA Followup: Remove debug warn

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:41:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:41:25 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-KIHecIPbQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Ah, QA test tools complain of POD coverage for Exceptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 16:46:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 15:46:07 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-dbaQJzElSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:23:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:23:53 +0000
Subject: [Koha-bugs] [Bug 7901] Add batch delete borrowers script
In-Reply-To: <bug-7901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7901-70-pYu5e9b33K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901

BASE Library Consortium <baselibrary.consortium at nhs.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baselibrary.consortium at nhs.
                   |                            |net

--- Comment #10 from BASE Library Consortium <baselibrary.consortium at nhs.net> ---
Still valid (16.05), the only way to do this is batch add patrons into a
category and use cleanborrowers.pl to delete the category.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:39:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:39:13 +0000
Subject: [Koha-bugs] [Bug 19775] New: Search/History.t is failing randomly
Message-ID: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

            Bug ID: 19775
           Summary: Search/History.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

#   Failed test 'There are still 8 searches after calling delete with an
interval = 6 days'
#   at t/db_dependent/Search/History.t line 185.
#          got: '6'
#     expected: '8'

#   Failed test 'There are still 2 searches after calling delete with an
interval = 2 days'
#   at t/db_dependent/Search/History.t line 191.
#          got: '0'
#     expected: '2'
# Looks like you failed 2 tests of 27.
[15:04:12] t/db_dependent/Search/History.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:39:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:39:53 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-1oOxxBE4bj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10933


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933
[Bug 10933] Merge PurgeSearchHistory into the C4::Search::History module
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:39:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:39:53 +0000
Subject: [Koha-bugs] [Bug 10933] Merge PurgeSearchHistory into the
 C4::Search::History module
In-Reply-To: <bug-10933-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10933-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10933-70-pS8q75cdhU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19775


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775
[Bug 19775] Search/History.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:42:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:42:15 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-oTe5LV4Q5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:42:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:42:19 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-TQjH6gZSOt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69618&action=edit
Bug 19775: Try & prevent Search/History.t to fail randomly

#   Failed test 'There are still 8 searches after calling delete with an
interval = 6 days'
 #   at t/db_dependent/Search/History.t line 185.
 #          got: '6'
 #     expected: '8'

 #   Failed test 'There are still 2 searches after calling delete with an
interval = 2 days'
 #   at t/db_dependent/Search/History.t line 191.
 #          got: '0'
 #     expected: '2'
 # Looks like you failed 2 tests of 27.
[15:04:12] t/db_dependent/Search/History.t

It looks like it does not longer fail with this change (date comparaison
wrongly rounded to second in mysql?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:42:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:42:44 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-QKgRzevNol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:42:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:42:59 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-WRpnlirsa8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 17:43:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 16:43:31 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-hyYiRTu5ZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:40:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:40:48 +0000
Subject: [Koha-bugs] [Bug 19529] NoIssuesChargeGuarantees.t is failing
	randomly
In-Reply-To: <bug-19529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19529-70-gk0urpFkKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19776


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776
[Bug 19776] Test failing randomly - fix categorycode vs category_type
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:40:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:40:48 +0000
Subject: [Koha-bugs] [Bug 19776] New: Test failing randomly - fix
 categorycode vs category_type
Message-ID: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

            Bug ID: 19776
           Summary: Test failing randomly - fix categorycode vs
                    category_type
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 19529

>From CanBookBeIssued:
 726     if ( $patron->category->category_type eq 'X' && (  $item->{barcode} 
)) {

Tests are failing randomly if the category_type of the patron is 'X'.

The previous tries to fix this issue set categorycode='X' (QAers, what are you
doing?)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19529
[Bug 19529] NoIssuesChargeGuarantees.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:41:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:41:28 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-XvXs5PB6mw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19517, 19487, 19455, 19423


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423
[Bug 19423] DecreaseLoanHighHolds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455
[Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487
[Bug 19487] Internal server error when writing off lost fine for item not
checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19517
[Bug 19517] dateexpiry.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:41:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:41:28 +0000
Subject: [Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
In-Reply-To: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19423-70-P6mZYese9t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19776


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776
[Bug 19776] Test failing randomly - fix categorycode vs category_type
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:41:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:41:28 +0000
Subject: [Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is
	failing randomly
In-Reply-To: <bug-19455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19455-70-8Jip43mzoa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19776


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776
[Bug 19776] Test failing randomly - fix categorycode vs category_type
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:41:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:41:28 +0000
Subject: [Koha-bugs] [Bug 19487] Internal server error when writing off lost
 fine for item not checked out
In-Reply-To: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19487-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19487-70-WCBtONUthn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19776


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776
[Bug 19776] Test failing randomly - fix categorycode vs category_type
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:41:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:41:28 +0000
Subject: [Koha-bugs] [Bug 19517] dateexpiry.t is failing randomly
In-Reply-To: <bug-19517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19517-70-c45WlFiVBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19517

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19776


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776
[Bug 19776] Test failing randomly - fix categorycode vs category_type
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:41:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:41:38 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-oBFaokuEnB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403
[Bug 19403] Again and again, Circulation.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:41:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:41:38 +0000
Subject: [Koha-bugs] [Bug 19403] Again and again,
	Circulation.t is failing randomly
In-Reply-To: <bug-19403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19403-70-CSixnG4IPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19776


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776
[Bug 19776] Test failing randomly - fix categorycode vs category_type
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:42:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:42:34 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-8h064p1zGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:43:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:43:07 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-ng24IHYF4M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69619&action=edit
Bug 19776: Fix random failures (category_type vs categorycode='X')

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:43:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:43:30 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-et7PTwMoeh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:43:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:43:35 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-0ZgvWly1pz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:43:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:43:49 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-E6v3jtkBzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:56:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:56:03 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-YqZcxhGuKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 18:56:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 17:56:05 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-O7FVIpWDuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69620&action=edit
Bug 19761: Move template JavaScript to the footer: Serials, part 2

This patch modifies more staff client serials templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials -> Subscription detail -> Edit routing list
   - Add recipients
   - Save
     - "Save and preview routing slip" should trigger preview
       - In preview popup: Print and Close buttons should work correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 19:23:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 18:23:46 +0000
Subject: [Koha-bugs] [Bug 19777] New: Move template JavaScript to the
 footer: Serials, part 3
Message-ID: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

            Bug ID: 19777
           Summary: Move template JavaScript to the footer: Serials, part
                    3
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for even more of the serials templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 19:23:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 18:23:46 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-nYofsOPVNK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19777


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777
[Bug 19777] Move template JavaScript to the footer: Serials, part 3
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 20:25:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 19:25:10 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-NhnjeFgJWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 20:25:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 19:25:12 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-69J0qIfeXP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69621&action=edit
Bug 19777: Move template JavaScript to the footer: Serials, part 3

This patch modifies even more staff client serials templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JavaScript include, serials-toolbar.js, which is
required on pages which include serials-toolbar.inc.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials
   - Search for a subscription
     - Tabs, datatables, date pickers
     - Open a subscription for viewing
       - Tabs, toolbar buttons for delete, renew, and close.
   - Serial collection (in the sidebar menu)
     - Select all / clear all
     - Datatable
     - Print slip
     - Generate next

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 20:35:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 19:35:50 +0000
Subject: [Koha-bugs] [Bug 19778] New: Move template JavaScript to the
 footer: Serials, part 4
Message-ID: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

            Bug ID: 19778
           Summary: Move template JavaScript to the footer: Serials, part
                    4
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

+++ This bug was initially created as a clone of Bug #19777 +++

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for even more of the serials templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 20:35:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 19:35:50 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-V52d1vmzLq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19778


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778
[Bug 19778] Move template JavaScript to the footer: Serials, part 4
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 20:47:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 19:47:24 +0000
Subject: [Koha-bugs] [Bug 19779] New: Some notices not using Reply To email
	address
Message-ID: <bug-19779-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19779

            Bug ID: 19779
           Summary: Some notices not using Reply To email address
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rachel.dewar at cass.govt.nz
        QA Contact: testopia at bugs.koha-community.org

If you specify a ReplyToDefault or a Branch ReplyTo email address some notices
still do not use them. These are the ones that I have come across:
- Holds - when a hold is placed on an item
- Sharing a list - both the invitation to share a list and email confirming
that the person has accepted the inviation
- Overdue notices

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 21:24:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 20:24:13 +0000
Subject: [Koha-bugs] [Bug 10123] way to accept donations
In-Reply-To: <bug-10123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10123-70-BX8mGDLINA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10123

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 21:31:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 20:31:01 +0000
Subject: [Koha-bugs] [Bug 6879] Actual price should show correctly on order
 line and basket summary
In-Reply-To: <bug-6879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6879-70-iqlheaR5gU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexbuckley at catalyst.net.nz

--- Comment #14 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
In Koha 17.11 the actual price added on receival of items is displayed in the
order line. 

However the actual price is still not displayed in the basket summary page. 

Another bug with the ordering pricing system is as follows:
1. You accidentally input the incorrect actual value into the receival of the
order

2. You modify this actual value by clicking on the order line and writing in a
new value

3. Checking the invoices you notice that the old (incorrect) actual value
inputted in step 1 is still displayed in the invoice rather than the new actual
value inputted in step 2. 

I will be creating a new bug report for this shortly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 21:38:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 20:38:14 +0000
Subject: [Koha-bugs] [Bug 19780] New: Actual price is not updated after it
 has been amended post receiving an order
Message-ID: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

            Bug ID: 19780
           Summary: Actual price is not updated after it has been amended
                    post receiving an order
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: alexbuckley at catalyst.net.nz
          Reporter: alexbuckley at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

The steps to replicate this bug are as follows:

1. Create an order and set the actual price to 9.00

2. Receieve the order changing the actual price value to 10.00. This is to
represent the librarian accidentally entering in a different actual price value
at receival.

3. Modify the actual value by clicking on the order line. The order page will
appear and notice the actual price of 10.00 is displayed. Change this actual
price value to 9.00 and save. 

4.View invoices and notice that the actual price displayed for the order is
still 10.00 (set in step 2) when it should be 9.00

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 22:02:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 21:02:47 +0000
Subject: [Koha-bugs] [Bug 19781] New: Make a xt test that checks all themes
 for missing includes, to avoid fallback
Message-ID: <bug-19781-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19781

            Bug ID: 19781
           Summary: Make a xt test that checks all themes for missing
                    includes, to avoid fallback
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

The fallback functionality of the themes is good, but it is resource intensive
if something is really really missing from a theme.

For example, a user might make a custom theme for their OPAC, specify a TT
include, but not include it in their theme (intentionally, or accidentally).
The process of looking through all of the themes to find the fallback causes
very slow page loads for that page, we should have a test that theme creators
can run to check for this circumstance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 22:32:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 21:32:45 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-BATjlXuAkw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #145 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 23:39:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 22:39:26 +0000
Subject: [Koha-bugs] [Bug 19749] Report who show all the reservations
In-Reply-To: <bug-19749-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19749-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19749-70-bcgxblGkof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19749

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

--- Comment #2 from Lisette <lisetteslatah at gmail.com> ---
(In reply to Owen Leonard from comment #1)
> Does the "Holds to pull" report (circ/pendingreserves.pl) not satisfy this
> request?

"Holds to pull" only has items on the shelf. I think Patrick is looking for all
items on hold even when an item is on loan. 

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 23:51:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 22:51:25 +0000
Subject: [Koha-bugs] [Bug 19720] Holds not re-routing properly
In-Reply-To: <bug-19720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19720-70-Ll8rwQkhGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19720

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 23:51:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 22:51:45 +0000
Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple
 holds on the same item
In-Reply-To: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19718-70-Me3w7ymG2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec  7 23:54:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 22:54:08 +0000
Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple
 holds on the same item
In-Reply-To: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19718-70-KXgk7Fc8R4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718

--- Comment #1 from Lisette <lisetteslatah at gmail.com> ---
We also have had this problem a lot. Many of our older patrons will place a
hold and then place an additional hold a couple weeks later when it has not yet
arrived for them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 00:00:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 07 Dec 2017 23:00:17 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-Z7kGYd8hlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #146 from David Cook <dcook at prosentient.com.au> ---
(In reply to Andreas Hedstr?m Mace from comment #144)
> Sounds great that work and/or thinking is being done is regards to
> harvesting/handling linked data in Koha. But could any potental changes that
> result from that please be added as a new patch (on top of this one?) so
> that we don't get another iteration of the harvester, before this has the
> chance to make it through the QA process!

It's just thinking :).

These patches haven't even been signed off yet. I'm not sure that anyone is
even testing them. 

Honestly most of the work would probably be done on a separate bug, and then
only if that separate bug were pushed would any required changes would be added
here (as an added patch).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 02:17:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 01:17:26 +0000
Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has
 been amended post receiving an order
In-Reply-To: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19780-70-CywckBx2ov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 02:17:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 01:17:12 +0000
Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has
 been amended post receiving an order
In-Reply-To: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19780-70-U1vGmZQsZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

--- Comment #1 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69622&action=edit
Bug 19780 - Updating the invoice costs after updating of the actual value post
receiving of the order

This invoice will update the invoice values if the order actual price
value is modified after the order has been received.

Test plan:
1. Create an order with the vendor price: 10.00 and actual price of
12.00

2. Close the order and receive the shipment. Change the actual price in
the receival page to 14.00

3. View the invoices and notice that 14.00 is the value displayed

4. Go back to the order and click on the order line to modify the order.
Change the actual price to 15.00

5. View the invoice now and notice that 14.00 is still the value being
displayed

6. Apply patch

7. Repeat steps 1,2,3,4 and 5 and notice that 15.00 is the value
displayed in the invoice

8. Now repeat steps 1. View the aqorders database table and notice after
step 1 is completed the order has unitprice:12.00 and
unitprice_tax_included and unitprice_tax_excluded values of NULL

9. Now before closing the order modify it and set the actual price to
14.00

10. Check the aqorders table again and notice that the unitprice is
14.00 and the unitprice_tax_included and unitprice_tax_excluded both
equal NULL. This means the unitprice_tax_included and
unitprice_tax_excluded values are not being updated before the order has
been receieved by they are being correctly updated if the order has been
received and the actual price is changed.

Sponsored-by: Horowhenua Distircit Council

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 04:23:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 03:23:54 +0000
Subject: [Koha-bugs] [Bug 16483] Ampersand breaks search for analytics
In-Reply-To: <bug-16483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16483-70-9gj4as7ghD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16483

Feli Kramer <feli at interkatz.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |feli at interkatz.de
                 CC|                            |feli at interkatz.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 06:24:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 05:24:47 +0000
Subject: [Koha-bugs] [Bug 14250] can generate discharge for patron with fines
In-Reply-To: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14250-70-vpD24Me4BE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250

Jamsheer N P <jamsheer.np at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamsheer.np at gmail.com

--- Comment #1 from Jamsheer N P <jamsheer.np at gmail.com> ---
Generating discharge to a patron having unpaid fine is a serious problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 06:25:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 05:25:28 +0000
Subject: [Koha-bugs] [Bug 14250] can generate discharge for patron with fines
In-Reply-To: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14250-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14250-70-g9zgXs4eh4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250

--- Comment #2 from Jamsheer N P <jamsheer.np at gmail.com> ---
Generating discharge to a patron having unpaid fine is a serious problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:33:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:33:47 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-o0EJgPqFgp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68158|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69623&action=edit
Bug 19439: (Follow-up) Remove four spaces from lines 133-149

Speaks for itself. No test plan.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:33:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:33:44 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-SYsiPYxbSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:34:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:34:16 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-MWALbzeGra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68157|0                           |1
        is obsolete|                            |

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69624&action=edit
Bug 19439: Remove eval with exit statements from opac/unapi

The script contains some error responses that get lost when using them
in an eval statement. (Since exit should not be used within an eval
construction.) The eval is removed now.

Test plan:
[1] Before applying this patch, you could look at the current responses
    from unapi for the calls in the next steps. Apply the patch now.
[2] Call http(s)://[your-server]/cgi-bin/koha/unapi with only a format
    parameter.
    Check if you have a 400 status response. (In Firefox, look at Network
    tab of Developer Tools.)
    Note: Have to admit (reluctantly) that MS Edge shows the status code in
    the browser rightaway in contrast with Firefox.
[3] Call unapi with a format=marcxml&id=999
    The wrong id parameter should trigger a 404 response.
[4] Call unapi with format=marcxml&id=koha:biblionumber:[notexist]
    where notexist is a biblionumber that not exists.
    This should trigger again a 404 response.
[5] Call unapi with format=marcxmlx&id=koha:biblionumber:[exist]
    where exist should be a good biblionumber.
    The wrong format should trigger a 406 response.
[6] Bonus: The 500 response can be tested by manipulating a XSLT file.
    Create invalid xml in the file for marcxml (identity.xsl in intranet
    xslt folder).
    Call unapi with format=marcxml&id=koha:biblionumber:[exist].
    You should get a 500 response and have warnings in your logfile.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:34:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:34:35 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-9TuAzJt0OY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69623|0                           |1
        is obsolete|                            |

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69625&action=edit
Bug 19439: (Follow-up) Remove four spaces from lines 133-149

Speaks for itself. No test plan.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:34:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:34:48 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-3rHw5JkcO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:36:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:36:28 +0000
Subject: [Koha-bugs] [Bug 19782] New: QA tools does not check svc and unapi
	files
Message-ID: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19782

            Bug ID: 19782
           Summary: QA tools does not check svc and unapi files
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: QA tools
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:39:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:39:59 +0000
Subject: [Koha-bugs] [Bug 19782] QA tools does not check svc and unapi files
In-Reply-To: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19782-70-ZVic2lTlBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19782

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:40:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:40:02 +0000
Subject: [Koha-bugs] [Bug 19782] QA tools does not check svc and unapi files
In-Reply-To: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19782-70-vT4VqacoEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19782

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69626&action=edit
Bug 19782: Add svc and unapi to check for QA

Test plan:

0) Have commit which touches any file in /svc /opac/svc or /opac/unapi,
    you can use bug 19439 and bug 19496, or just create your own commit
1) Run QA tools on this commit
2) There should be report for this files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:40:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:40:13 +0000
Subject: [Koha-bugs] [Bug 19782] QA tools does not check svc and unapi files
In-Reply-To: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19782-70-BjQCUJKaQi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19782

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |josef.moravec at gmail.com
                   |ommunity.org                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 07:40:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 06:40:48 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-WjPzCdC8br@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Josef Moravec from comment #10)
> Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Thx Josef. Welcome in the QA team !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:17:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:17:18 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-96UlLERBmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:17:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:17:21 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-mropImjJW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69437|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69627&action=edit
Bug 19725: Add failing test

Also fix tests for UNIMARC

Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it FAILS

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:17:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:17:24 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-comOusOI6o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69438|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69628&action=edit
Bug 19725: OAI-PMH - Use biblio_metadata.timestamp

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.

Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it SUCCEEDS

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:32:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:32:29 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-WV9dxK9gyb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #18 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Katrin Fischer from comment #17)
> I think this is a duplicate of the older bug 5630 which is also signed off
> at the moment.

Katrin, which bug did you have in mind? This bug number is not related to
account either.


> There was some discussion about using an authorised value there and because
> we already have a list of payment types used by SIP and translatability some
> hardcoded values were added. Maybe we could make it so that the list can be
> extended by an authorised value? (... and make authorised values
> translatable for display one day...)
> 
> Can we pick one implementation?

+1 ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:42:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:42:22 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-fo8fimgaVI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #51 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69629&action=edit
Bug 19096: (QA follow-up) Move two routines out of Koha::MSS

As requested by RM, this patch moves sync_kohafield and
get_kohafield_exceptions from Koha/MarcSubfieldStructures.pm.

At this moment they are only used in a database revision; it is not clear
if they may be of use later on.

In order to keep them in a module and not remove the unit tests, this
patch adds a Koha::Util module Dbrev.pm. It is now required in the atomic
update, but could be added in a use statement in updatedatabase.pl.

Test plan:
[1] Run updatedatabase.pl
[2] Run t/db_dependent/Koha/MarcSubfieldStructures.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:42:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:42:49 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-YiW8UMfY3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #52 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
FAIL   Koha/MarcSubfieldStructures.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
=> As explained before on other reports, this is a false warning. It can be
ignored.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:50:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:50:33 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-RImrTq7En4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69162|0                           |1
        is obsolete|                            |
  Attachment #69608|0                           |1
        is obsolete|                            |

--- Comment #5 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69630&action=edit
[SIGNED-OFF] Bug 19627: Move patron clubs templates JS to the footer

This patch modifies the staff client's patron clubs templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:50:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:50:36 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-EulGH0wVpL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

--- Comment #6 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69631&action=edit
[SIGNED-OFF] Bug 19627: Follow-up: Include tools-menu.js on required templates

This follow-up adds tools-menu.js to the two patron clubs templates
which include the tools sidebar menu.

The patch also modifies tools-menu.js so that the correct sidebar link
is highlighted when editing or viewing club enrollments.

To test, apply the patch and view the patron clubs main page and the
patron clubs enrollments page. The sidebar menu should have the correct
link highlighted in both cases.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 08:50:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 07:50:30 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-9xZo8PsIOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 09:24:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 08:24:54 +0000
Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout
In-Reply-To: <bug-15464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15464-70-GqSyhSOyyw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464

Patfrat <patrick.fratczak at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #25 from Patfrat <patrick.fratczak at gmail.com> ---
Yes it can be closed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 09:38:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 08:38:55 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-yS3krKLgVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 09:38:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 08:38:57 +0000
Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore
In-Reply-To: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18585-70-9NCrMPSAxn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64253|0                           |1
        is obsolete|                            |

--- Comment #22 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69632&action=edit
Bug 18585 - Connect to RDF triplestore

This commit adds a 'triplestore' method to C4::Context. It takes
a model name as a parameter and returns a RDF::Trine::Model object
if triplestore.yaml is properly configured.

(At the moment, it just supports RDF::Trine::Store::SPARQL,
but it would be trivial to add support for RDF::Trine::Store::DBI too,
or any other RDF::Trine::Store::* backend.)

This code will provide a base from which people can use RDF::Trine
for querying and updating a RDF triplestore.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 09:45:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 08:45:30 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-sv3KFqnLz7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 09:45:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 08:45:33 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-VANHXxAzKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69633&action=edit
Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF

This patch adds methods to Koha::RDF that creates or deletes a named
graph by removing/adding RDF quads from/to a triplestore.

This patch also can create a rdfs:seeAlso relationship between
two RDF entities.

This patch includes unit tests for both of these changes.

_TEST PLAN_
1) Run "prove t/Koha/RDF.t"
2) Note that all tests have run successfully.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 09:46:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 08:46:05 +0000
Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and
 rfds:seeAlso to Koha::RDF
In-Reply-To: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18713-70-GhiiQbgV2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64020|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 10:18:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 09:18:02 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-Seia44MJAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #147 from Josef Moravec <josef.moravec at gmail.com> ---
> These patches haven't even been signed off yet. I'm not sure that anyone is
> even testing them. 

I am testing this (again) ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 10:31:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 09:31:39 +0000
Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types
In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18786-70-9Qtjafa130@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Found it - it was bug 5620!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 10:45:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 09:45:41 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-kMuSvT6hsL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Working here again now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 10:47:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 09:47:40 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-xbCIktBzhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
           Assignee|gmcharlt at gmail.com          |januszop at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 11:29:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 10:29:23 +0000
Subject: [Koha-bugs] [Bug 19422] kohastructure.sql missing DROP TABLES
In-Reply-To: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19422-70-YOSjSnmAjR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422

--- Comment #8 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Jonathan Druart from comment #7)
> Mirko,
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/kohastructure.sql does
> not exist? Where is it then?

This requires a full Koha installation, which is not expected when just
building packages. The file is only available in
$kohadev/installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 11:33:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 10:33:50 +0000
Subject: [Koha-bugs] [Bug 19422] kohastructure.sql missing DROP TABLES
In-Reply-To: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19422-70-acu0yFZRtp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422

--- Comment #9 from Mirko Tietgen <mirko at abunchofthings.net> ---
During build process there is

> cp installer/data/mysql/kohastructure.sql blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:20:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:20:25 +0000
Subject: [Koha-bugs] [Bug 19783] New: make check_kohastructure.t compatible
 to package build process
Message-ID: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

            Bug ID: 19783
           Summary: make check_kohastructure.t compatible to package build
                    process
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org

The test fails during the Debian packaging build process.
This patch is a workaround, there is probably a more elegant way to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:20:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:20:38 +0000
Subject: [Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to
 package build process
In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19783-70-jqOCIZR2Sh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |mirko at abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:20:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:20:56 +0000
Subject: [Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to
 package build process
In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19783-70-zXjbkQf8kz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19422

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:20:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:20:56 +0000
Subject: [Koha-bugs] [Bug 19422] kohastructure.sql missing DROP TABLES
In-Reply-To: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19422-70-DQwDaB7h2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19783

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:36:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:36:51 +0000
Subject: [Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to
 package build process
In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19783-70-dbSUKplbn8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 69636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69636&action=edit
Bug 19783 - make check_kohastructure.t compatible to package build process

Check if kohastructure.pl is found in the package build location and runs
the test if found. Otherwise runs as before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:46:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:46:39 +0000
Subject: [Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to
 package build process
In-Reply-To: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19783-70-ZRoNxVHF3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> ---
To test:

If you have a working packaging setup, build a debian package and verify that
check_kohastructure.t passes.

Otherwise, verify it still works in a dev installation, review the code.

The patch is used to build the 17.11.00 package.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:55:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:55:23 +0000
Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming
 guidelines OMNIBUS
In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19774-70-wIGHiHDrtD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Adapt existing endpoints to |Adapt existing endpoints to
                   |new naming guidelines       |new naming guidelines
                   |                            |OMNIBUS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:55:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:55:44 +0000
Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming
 guidelines OMNIBUS
In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19774-70-vmcmOntvgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|16330                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:55:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:55:44 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-xjdzYiMYvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19774                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774
[Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:56:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:56:21 +0000
Subject: [Koha-bugs] [Bug 19784] New: Adapt /v1/patrons to new naming
	guidelines
Message-ID: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

            Bug ID: 19784
           Summary: Adapt /v1/patrons to new naming guidelines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST api
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:56:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:56:33 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-mHQOLisUTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774
[Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:56:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:56:33 +0000
Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming
 guidelines OMNIBUS
In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19774-70-qtwRF2NRX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19784


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784
[Bug 19784] Adapt /v1/patrons to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:57:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:57:13 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-6VFstVsrwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:58:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:58:31 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-HyjDd4462j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19774                       |16330
             Blocks|                            |19774


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774
[Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:58:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:58:31 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-hZD6pxR9sN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19784


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784
[Bug 19784] Adapt /v1/patrons to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 12:58:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 11:58:31 +0000
Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming
 guidelines OMNIBUS
In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19774-70-sJ8girvYXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19784                       |
         Depends on|                            |19784


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784
[Bug 19784] Adapt /v1/patrons to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:05:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:05:16 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-O6n6VedulS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Current approach was:
$9 Controlled fields Old extra fields
The controlled fields form a block; $9 should be moved to the end.
Your approach is:
Extra-prefix Controlled block Extra-postfix $9
With our current Koha records $9 will be the first one as long as it has not
been saved with this patch. So we need to avoid $9 in this loop (amended).
Note that since $i from your 7XX example has been moved backwards, it will not
automatically move to the front anymore. But new 7XXs with $i $a will be okay.
Adding a subtest in Merge.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:05:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:05:41 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-xYTnkmPppX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:05:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:05:50 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-yjGkTk7BG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:05:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:05:49 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-riAUFlkqAc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69638&action=edit
Bug 18458 - Merging authority record incorrectly orders subfields

While doing a merge, if a subfield(s) precedes the controlled subfields
(like $i before $a in 7XX, which comes before $a -- rare but will
become more and more usual) after merging will be moved to the end.
This is not right.

The patch (with AuthorityMergeMode == loose) make merge consider the
subfields order: all subfields which originally were found before
the first controlled subfield (e.g. $i before $a in 7XX / MARC 21)
will remain in the front, the rest of not controlled subfields that
should remain in the field will come after the subfields copied
from authority rec.

As a bonus, $9 will be placed at the end.

To test:
0) Have AuthorityMergeMode == loose;
1) Have some field in bibliorecord, controlled by an authority, with
extra subfield(s) (i.e. not present in authority rec.) placed at the
beginning of the field;
2) Open (not necessarily edit) and save the connected authority;
3) See that the extra subfieds were moved to the end of the field
   (and $9 is in the front);
4) Apply the patch;
5) Reorder subfields in biblio field;
6) Open (not necessarily edit) and save the connected authority;
7) See that the order has been conserved, additionally $9 the last
   subfield in the field.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended:
Moved field creation to its original place. Changed $9 handling. Simplified the
following add_subfields for loop. Edited comments.
Restored the append_fields_ordered call (see comment6).

With this patch, the Merge.t test now passes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:05:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:05:52 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-NH68ZjqPMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69620|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69639&action=edit
Bug 19761: Move template JavaScript to the footer: Serials, part 2

This patch modifies more staff client serials templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials -> Subscription detail -> Edit routing list
   - Add recipients
   - Save
     - "Save and preview routing slip" should trigger preview
       - In preview popup: Print and Close buttons should work correctly

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:05:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:05:44 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-R61eRcc5m1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69637&action=edit
Bug 18458: (Follow-up) Add a subtest in Merge.t

This test illustrates the problem we have if you run it without the
second patch. And it serves to demonstrate that we resolved the
situation if you run it after the second patch.

Test plan:
[1] Without the second patch: The last subtest should fail.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:10:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:10:21 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-2BdF0LONBY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69345|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 14:26:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 13:26:46 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-qvVyfPJTqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

--- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Hooray :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:00:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:00:15 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-PsB91xA0wa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #30 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Bonjour Alex
It's ok now as far as keeping irregularities is concerned : the corrresponding
issues  to exclude are now automatically checked when checking the top table of
"permanent" irregularities.
But there's one problem remaining about multi-receiving weekly serials.
The excluded issues are correctly skipped when receiving issues one by one but
not when receiving through multi-receiving function.

For the others two periodicities (daily and monthly), it also works with
multi-receiving.

I tested without patch and the problem disappears.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:05:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:05:02 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-eNM9FJei3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Olivier, thx for your great testing!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:10:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:10:39 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-n1j11Gg9FL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69213|0                           |1
        is obsolete|                            |

--- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69641&action=edit
Bug 19563: Unit tests

To test:
1 - Apply first patch and this patch
2 - prove -v t/db_dependent/Koha_Elasticsearch.t
3 - New tests will fail
4 - Apply followup patch
5 - Tests shuld pass

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:10:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:10:43 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-2guwZsu8DI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69214|0                           |1
        is obsolete|                            |

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69642&action=edit
Bug 19563: Followup - Restore checking sort variable

This code seems a bit odd, $self->sort_fields()->{$name} is checking if
there is any mapping in ES for a field, so if one marc field in an index
is marked as sortable this will exists. We need to check the individual
marc field to see if it should be added to the sort index here.

If you apply the first patch, reindex, and view a record in es:
curl -XGET 'localhost:9200/koha_kohadev_biblios/data/19/?pretty' | grep
-A 10 author__sort

You will see that 245$c is included in the record without that
additional check

Apply this, reindex again, and that field should not be included

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:10:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:10:35 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-F1RZ4fDnvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69212|0                           |1
        is obsolete|                            |

--- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69640&action=edit
Bug 19563: Generation of sort_fields uses incorrect condition

Fix incorrect condition for if clause for generating <field>__sort mappings
for Elasticsearch. Also remove redundant check for same condition when
generating fixer rules.

Test plan:
1. Inspect current mappings for example by viewing:
http://<elasticsearch_host>:9200/koha_<koha_instance_name>_biblios/_mapping.
2. If using the default configuraion only "author" has a sort field
(author__sort).
4. Appy patch.
5. Reindex using rebuild_elastic_search.pl.
6. All fields except those with sort sort set to "0" should now have sort
fields, which in the default configuration is all but "author".

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:13:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:13:06 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-KhrVP6el4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:16:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:16:18 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-wz0cLLlcEm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au,
                   |                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:16:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:16:59 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-ssEWBtyEre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69643&action=edit
Bug 19784: Unit tests for /api/v1/patrons

This patch adapts the existing endpoint's tests so they expect:
- 'patron_id' for 'borrowernumber'
- 'library_id' for 'branchcode'
- 'category_id' for 'categorycode'

In the process, I tried to make the tests more robust, by creating random
data that gets deleted to make sure our tests cases can't have false
positives.

Independent subtests are wrapped inside transactions to avoid
eventual interference.

To test:
- Apply the patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: The api doesn't implement the expected behaviour and attributes
for endpoint responses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:17:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:17:07 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-1jQIMfKCba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69644&action=edit
Bug 19784: Remove reference to 'borrowernumber' param from other endpoints

This patch removes the $ref occurences for borrowernumber in not
patron-specific endpoints. 'borrowernumber' is still used on them, but as a
hardcoded parameter. The param rename will happen on a separate bug for
each endpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:17:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:17:12 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-xX3LRpfUyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69645&action=edit
Bug 19784: Adapt /v1/patrons to new naming guidelines

This patch introduces two functions to the patrons endpoint:
- _to_api
- _to_model

This are in charge of field mappings in order to comply with the
guidelines.

Koha::REST::V1:Auth is adjusted to handle 'patron_id' as well.

To test:
- Apply the patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:17:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:17:47 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-Jtl6v5Ubdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:29:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:29:48 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-xy87me1104@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69646&action=edit
Bug 19096: Use raw SQL queries instead for the update DB entry

I strongly thing we must not use C4 or Koha subroutine in the update DB
process, only sql queries.
Especially not DBIC Schema files as they will change.
For instance the update DB 17.12.00.00X is using a specific
Koha::Schema::RS::MSS
representing the current schema, but in X months/years, this schema will change
and the ->search we used may failed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:29:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:29:53 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-nol6WMUUio@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69647&action=edit
Bug 19096: Move the sql queries to the update DB entry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:30:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:30:48 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-M5fjBeUwTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel, will you agree with these 2 patches? I do not think it's a good idea to
use the DBIC schema files during the update DB upgrade.
I thought we already agreed on that, but cannot find logs...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 15:59:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 14:59:53 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-eWIxplN2Sx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #55)
> Marcel, will you agree with these 2 patches? I do not think it's a good idea
> to use the DBIC schema files during the update DB upgrade.
> I thought we already agreed on that, but cannot find logs...

Might have been a good idea to give some more direction in this regard. This
was a waste of time.
Will still have a look in detail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 16:10:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 15:10:02 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
	acquisitions searches
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-ZbSM1d2b5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69648&action=edit
Bug 17182 - Allow Keyword to MARC mapping for acquisitions searches

This patchset adds the 'subtitle' field to the results display on
acquistions search for adding an order form an existing item.

Any field mapped to 'subtitle' in 'Keyword to MARC mapping' will be
fetched and displayed in the results

To test:
1 - Perform an acquisitions search for existing record
2 - Note record subtitles are not displayed
3 - Map 245$b and 245$n to 'subtitle' in 'Keyword to MARC mapping'
4 - Note they are still not displayed ion acq results
5 - Apply patch
6 - subtitle fields should now display

Sponsored by: Round Rock Public Library
<https://www.roundrocktexas.gov/departments/library/>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 16:10:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 15:10:06 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
	acquisitions searches
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-QESw7GgNvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69649&action=edit
Bug 17182: Fix call to GetMarcBiblio (QA follow-up)

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 16:10:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 15:10:19 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
	acquisitions searches
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-MBsoYKlV3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 16:14:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 15:14:42 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-uWuVxKxMq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69506|0                           |1
        is obsolete|                            |

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69650&action=edit
Bug 19746: Remove debug statements in returns.pl

>From bug commit bb6277ffcc593685554112d770ac273c9efeda33
Bug 14464: Add ability to cancel waiting holds from checkin screen

+use Carp 'verbose';
+$SIG{ __DIE__ } = sub { Carp::confess( @_ ) };

See also
http://lists.koha-community.org/pipermail/koha-devel/2017-November/044168.html

Test plan:
Read the changes and make sure they make sense

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 16:14:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 15:14:52 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-KSj7VBAmX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 17:22:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 16:22:05 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-d3G0tSIQbV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 17:25:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 16:25:12 +0000
Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff
 client search results for lost , withdrawn, and damaged
In-Reply-To: <bug-15922-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15922-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15922-70-MdJmis82dv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 18:07:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 17:07:29 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-kXmFMkWX60@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69651&action=edit
Bug 19778: Move template JavaScript to the footer: Serials, part 4

This patch modifies more and more staff client serials templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JavaScript include, showpredictionpattern.js,
which is used by subscription-add.tt and subscription-numberpatterns.tt.
it also adds subscription-add.js, moving most of the JS embedded in
subscription-add.tt into an external file.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials -> New subscription
   - Date pickers
   - Popup search windows for vendors and bibliographic
     records
   - Next / Previous buttons
   - Form validation
   - Prediction pattern operations

   Test with new subscriptions, editing existing subscriptions, and
   duplicating subscriptions.

 - Serials -> Manage Numbering Patterns
   - Datatable
   - Delete confirmation
   -> Edit
      - Datepicker, test pattern
 - Serials -> Manage frequencies
   - Delete confirmation
   -> Edit
      - Form validation
 - Serials -> Subscription details -> Planning tab
   -> Edit history
      -> Datepicker
 - Serials -> Subscription details -> Renew
   - Datepicker

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 18:07:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 17:07:27 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-QwbdsqXDCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 19:39:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 18:39:20 +0000
Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch
 record modification /deletion tools
In-Reply-To: <bug-12759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12759-70-HsoLgWYTDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:04:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:04:06 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-HEbyPWnlFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19785


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785
[Bug 19785] Move template JavaScript to the footer: Authorities, part 1
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:04:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:04:06 +0000
Subject: [Koha-bugs] [Bug 19785] New: Move template JavaScript to the
 footer: Authorities, part 1
Message-ID: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

            Bug ID: 19785
           Summary: Move template JavaScript to the footer: Authorities,
                    part 1
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for some of the authorities templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:14:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:14:20 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-zDFKza2Cyu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose at inlibr
                   |                            |o.com

--- Comment #212 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Is there any way to make the configuration of the ILL module more user
friendly? I wish I didn't have to go in the conf file and on the server to
configure it.

Here are some suggestions

- Tab in system preferences for all ILL configurations
- Make StaffRequestComments (hide/show) a sys pref
- Make ReplyDate (hide/show) a sys pref
- Make DigitalRecipient (borrower/branch) a sys pref
- Make PartnerCode (text entry, with by default ILLLIBS entered) a sys pref
- In Tools or Administration, add a page with a form to add backends with our
own providers

So far, I've only been able to enable the ILLModule sys pref and create the
database tables, so I don't really have any suggestions for the other parts...
I will add them once I figure out the rest.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:20:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:20:37 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-HGrbgwE6K3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:20:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:20:39 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-eePni9H0eo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69662&action=edit
Bug 19785: Move template JavaScript to the footer: Authorities, part 1

This patch modifies even more staff client authorities templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Authorities
   - New from Z39.50
   -> Search
      -> Results
         - New from Z39.50
         - Deletion confirmation
         - Merge records -> Merge
           - Tabs
           - Tag selection
         -> Authority detail
            - Tabs
            - Deletion confirmation
            - New from Z39.50

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:23:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:23:20 +0000
Subject: [Koha-bugs] [Bug 19786] New: Move template JavaScript to the
 footer: Authorities, part 2
Message-ID: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

            Bug ID: 19786
           Summary: Move template JavaScript to the footer: Authorities,
                    part 2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for more of the authorities templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:23:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:23:20 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-EWsMLwAOLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19786


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786
[Bug 19786] Move template JavaScript to the footer: Authorities, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:46:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:46:38 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-AWYkqrBFd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #2 from Dominic Pichette <dominic.pichette at inlibro.com> ---
I am not able to delete an authority from the results page. The confirmation
window is shown but when I come back the authority is still there. Is there an
Ajax call that is not working here or is it a problem from my DB maybe?

Otherwise, everything works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 20:59:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 19:59:30 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-5H9Aa7dGta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69651|0                           |1
        is obsolete|                            |

--- Comment #2 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69663&action=edit
Bug 19778: Move template JavaScript to the footer: Serials, part 4

This patch modifies more and more staff client serials templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JavaScript include, showpredictionpattern.js,
which is used by subscription-add.tt and subscription-numberpatterns.tt.
it also adds subscription-add.js, moving most of the JS embedded in
subscription-add.tt into an external file.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials -> New subscription
   - Date pickers
   - Popup search windows for vendors and bibliographic
     records
   - Next / Previous buttons
   - Form validation
   - Prediction pattern operations

   Test with new subscriptions, editing existing subscriptions, and
   duplicating subscriptions.

 - Serials -> Manage Numbering Patterns
   - Datatable
   - Delete confirmation
   -> Edit
      - Datepicker, test pattern
 - Serials -> Manage frequencies
   - Delete confirmation
   -> Edit
      - Form validation
 - Serials -> Subscription details -> Planning tab
   -> Edit history
      -> Datepicker
 - Serials -> Subscription details -> Renew
   - Datepicker

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 21:00:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 20:00:15 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-PpZMZz2WtO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 21:05:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 20:05:28 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-3hHIM4Qy1a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69165|0                           |1
        is obsolete|                            |

--- Comment #9 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69664&action=edit
Bug 15492: Add the SelfCheckInModule syspref

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 21:05:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 20:05:34 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-SVWNuCKFd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69179|0                           |1
        is obsolete|                            |

--- Comment #10 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69665&action=edit
Bug 15492: Add SCI module

This patch adds the SCI module, and adapts C4::Auth to know about it.

The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
  to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link

To test:
- Apply this patches
- Make sure you upgrade:
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Click the 'Help' link
=> SUCCESS: A help text is displayed on a modal
- Sign off :-D

- Bonus points:
  $ kshell
 k$ qa -c 2 -v 2
=> SUCCESS: All tests green

[1] Adjust to your dev's OPAC setup

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 21:05:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 20:05:26 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-T4v6G8MAG0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 21:05:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 20:05:50 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-wH2cL2H1ld@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #4 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Applying: Bug 19784: Unit tests for /api/v1/patrons
fatal: sha1 information is lacking or useless
(t/db_dependent/api/v1/patrons.t).
error: could not build fake ancestor
Patch failed at 0001 Bug 19784: Unit tests for /api/v1/patrons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:11:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:11:52 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-fz4y5tnUyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69566|0                           |1
        is obsolete|                            |

--- Comment #3 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 69666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69666&action=edit
Bug 19759: Make TestBuilder generates only 2 decimals for float

For instance items.replacementprice is decimal(8,2) but more than 2 decimals
are generated.

It leads to issues when we compare expected objects:

    #          got: '135623.866142537'
    #     expected: '135623.87'

Test plan:
  prove t/db_dependent/TestBuilder.t
must return green

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:12:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:12:05 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-R0xT6zdR8j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:20 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-QgIzecv8lq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69446|0                           |1
        is obsolete|                            |

--- Comment #50 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69667&action=edit
Bug 18595: Unit tests for Koha::Patron::Categories->default_messaging

This patch adds unit tests for Koha::Patron::Categories->default_messaging.
Tests
will help preparing for moving C4::Members::Messaging to Koha-objects.

To test:
1. Run t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:23 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-cYrSLoQhGw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69447|0                           |1
        is obsolete|                            |

--- Comment #51 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69668&action=edit
Bug 18595: Move C4::Members::Messaging::GetMessagingOptions

This patch moves C4::Members::GetMessagingOptions to
Koha::Patron::Message::Preferences->get_options.

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

This patch also removes previously unused GetMessagingOptions in
opac-messaging.pl

To test:

Make sure you have enabled the following system preferences:
- opacuserlogin
- EnhancedMessagingPreferences
- EnhancedMessagingPreferencesOPAC

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "GetMessagingOptions"
   (grep -r 'GetMessagingOptions').
3. Observe no results in source code.

---- OPAC ----
1. Login to OPAC.
2. Go to "your messaging" (cgi-bin/koha/opac-messaging.pl).
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.

---- INTRANET ----
1. Login to intranet.
2. Go to edit patron's details and scroll down to their messaging preferences.
3. Observe the preferences looking normal and as they should be.
4. Set any combination of messaging preferences.
5. Observe them apply as expected, repeat step 4-5 as much as you like.
6. Go to Administration -> Patron categories -> Edit (for any category)
7. Scroll down to observe default messaging preferences for this patron
category
8. Observe the preferences looking normal and as they should be.
9. Set any combination of messaging preferences.
10. Observe them apply as expected, repeat step 9-10 as much as you like.
11. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
12. Fill in required data, do not modify messaging preferences, click Save.
13. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:26 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-8FSBfQeRog@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69448|0                           |1
        is obsolete|                            |

--- Comment #52 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69669&action=edit
Bug 18595: Move C4::Members::Messaging::SetMessagingPreferencesFromDefaults

This patch moves C4::Members::SetMessagingPreferencesFromDefaults to
Koha::Patron->set_default_messaging_preferences

The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of
"SetMessagingPreferencesFromDefaults"
       (grep -r 'SetMessagingPreferencesFromDefaults').
3. Observe no results in source code.

---- INTRANET ----
1. Login to intranet.
2. Go to Administration -> Patron categories -> Edit (for any category)
3. Scroll down to observe default messaging preferences for this patron
category
4. Observe the preferences, remember them for the next step.
5. Go to cgi-bin/koha/members/memberentry.pl?op=add&categorycode=XXX, replace
XXX
    with the categorycode you were just editing.
6. Look at messaging preferences. They should be same as in step 4.
7. Fill in required data, do not modify messaging preferences, click Save.
8. Observe a new patron with default messaging preferences.

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:29 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-L6g7hoiiHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69449|0                           |1
        is obsolete|                            |

--- Comment #53 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69670&action=edit
Bug 18595: Unit tests preparing for GetMessagingPreferences move

This patch prepares removing GetMessagingPreferences by adding some useful unit
tests for subroutines that the move targets.

Reserves.t already covers print notice, but this patch adds tests for a set
transport type.

To test:
1. Run t/db_dependent/Circulation.t
2. Run t/db_dependent/Reserves.t
3. Observe test pass

Works together with followup patch
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:33 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-KWaPFuG7Qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69450|0                           |1
        is obsolete|                            |

--- Comment #54 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69671&action=edit
Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences

This patch moves C4::Members::Messaging::GetMessagingPreferences to
Koha::Patron::Message::Preference(s)
The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "GetMessagingPreferences"
       (grep -r 'GetMessagingPreferences').
3. Observe no results in source code.

---- UNIT TESTS ----
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Reserves.t
3. prove t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:36 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-4hy8u6mBTS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69451|0                           |1
        is obsolete|                            |

--- Comment #55 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69672&action=edit
Bug 18595: Move C4::Members::Messaging::SetMessagingPreference

This patch moves C4::Members::Messaging::SetMessagingPreference to
Koha::Patron::Message::Preference
The patch makes a heavy touch on core messaging preference features,
but should not introduce any visible changes for end user. Keep this in mind
if testing. If you notice any changes in Koha, something is probably wrong!

To test:

Make sure you have enabled the following system preferences:
- EnhancedMessagingPreferences

---- GENERAL ----
1. Apply patch
2. Search Koha source code for references of "SetMessagingPreference"
       (grep -r 'SetMessagingPreference').
3. Observe no results in source code.

---- UNIT TESTS ----
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Reserves.t
3. prove t/db_dependent/Koha/Patron/Categories.t

Works as expected. QA tools fails with:
FAIL    C4/Members/Messaging.pm pod empty section in previous paragraph
Can be fixed in a followup.
Signed-off-by: Marc V?ron <veron at veron.ch>

QA tools pass now OK
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:40 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-vfw7rac7Fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69452|0                           |1
        is obsolete|                            |

--- Comment #56 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69673&action=edit
Bug 18595: Remove references to C4::Members::Messaging

To test:
1. grep -r 'C4::Members::Messaging'
   This command should not produce any results in Koha source code after this
   patch.
2. Check the pages touched by this commit
3. Try setting and viewing patron and patron category messaging preferences

As this completes the move from C4::Members::Messaging to new Koha-objects for
messaging preferences, everything should be ready for proper testing.

Make sure you have EnhancedMessagingPreferences system preference enabled.
Then, try creating new categories and setting default messaging preferences,
as well as editing the messaging preferences of the already existing
categories.
Try adding new patrons and make sure the default patron messaging preferences
are by default the same that you set for that category. Edit already exisiting
patrons' messaging preferences and make sure changes are applied. Observe
no crash at any point, otherwise fail this patch. Don't forget to test both
intranet and OPAC.

Finally, run unit tests:
1. prove t/db_dependent/Circulation.t
2. prove t/db_dependent/Reserves.t
3. prove t/db_dependent/Koha/Patron/Categories.t

Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:27:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:27:43 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-CA73aimdh0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69453|0                           |1
        is obsolete|                            |

--- Comment #57 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69674&action=edit
Bug 18595: Disable digest checkbox when forced on

To test:
1. Force a digest on via message_transports table
   (delete rows where message_attribute is 1 and is_digest is 0)
2. Go to either OPAC or staff client messaging preferences
3. Observe digest checkbox is disabled for message attribute 1
   (normally Item due row)

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:37:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:37:05 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-qeCUJcnQg5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Dominic Pichette from comment #4)
> Applying: Bug 19784: Unit tests for /api/v1/patrons
> fatal: sha1 information is lacking or useless
> (t/db_dependent/api/v1/patrons.t).
> error: could not build fake ancestor
> Patch failed at 0001 Bug 19784: Unit tests for /api/v1/patrons

Please try on top of my 'pagination' branch on github, plus 16330. Dependencies
are not easy to apply. It applies cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 22:42:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 21:42:17 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
	namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-S6n65QJkmm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.bourgault at inlibro.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec  8 23:59:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 08 Dec 2017 22:59:05 +0000
Subject: [Koha-bugs] [Bug 18322] Add facets for ccode to zebra
In-Reply-To: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18322-70-eMjh1W1YUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  9 04:37:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Dec 2017 03:37:24 +0000
Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate
 Authen/CAS/Client/ Response/Failure.pm
In-Reply-To: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17717-70-2KrGobtLxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

--- Comment #45 from Larry Baerveldt <larry at bywatersolutions.com> ---
We're getting the exact same error when trying to do a full rebuild from root
cron, using /usr/sbin/koha-rebuild-zebra. 

Koha 17.05.05, Ubuntu 16.04.3 LTS, Perl v5.22.1
Cronjob: /usr/sbin/koha-rebuild-zebra -f -v SITE

Error:
Rebuilding authority indexes.
Can't locate Koha/Exceptions/Exception.pm:   ./Koha/Exceptions/Exception.pm:
Permission denied at /usr/share/perl/5.22/base.pm line 97.
        ...propagated at /usr/share/perl/5.22/base.pm line 106.
BEGIN failed--compilation aborted at (eval 15) line 3.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Exceptions.pm
line 56.
Compilation failed in require at /usr/share/koha/lib/Koha/DateUtils.pm line 22.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/DateUtils.pm line
22.
Compilation failed in require at /usr/share/koha/lib/C4/Log.pm line 30.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Log.pm line 30.
Compilation failed in require at /usr/share/koha/lib/Koha/Config/SysPref.pm
line 26.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Config/SysPref.pm
line 26.
Compilation failed in require at /usr/share/koha/lib/C4/Context.pm line 105.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Context.pm line
105.
Compilation failed in require at
/usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 20.
BEGIN failed--compilation aborted at
/usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 20.
Something went wrong rebuilding authority indexes for library
Wed Dec  6 22:25:41 PST 2017

Rebuilding biblios indexes.
Can't locate Koha/Exceptions/Exception.pm:   ./Koha/Exceptions/Exception.pm:
Permission denied at /usr/share/perl/5.22/base.pm line 97.
        ...propagated at /usr/share/perl/5.22/base.pm line 106.
BEGIN failed--compilation aborted at (eval 15) line 3.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Exceptions.pm
line 56.
Compilation failed in require at /usr/share/koha/lib/Koha/DateUtils.pm line 22.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/DateUtils.pm line
22.
Compilation failed in require at /usr/share/koha/lib/C4/Log.pm line 30.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Log.pm line 30.
Compilation failed in require at /usr/share/koha/lib/Koha/Config/SysPref.pm
line 26.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Config/SysPref.pm
line 26.
Compilation failed in require at /usr/share/koha/lib/C4/Context.pm line 105.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Context.pm line
105.
Compilation failed in require at
/usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 20.
BEGIN failed--compilation aborted at
/usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 20.
Something went wrong rebuilding biblio indexes for library

The same work-around works:
cd /tmp && /usr/sbin/koha-rebuild-zebra -f -v SITE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec  9 15:56:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 09 Dec 2017 14:56:40 +0000
Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox
	Quantum
In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19637-70-7BPkOVHJqH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

--- Comment #4 from Marc V?ron <veron at veron.ch> ---
(In reply to Mike from comment #3)
(...) You
> can pass data through the nativeMessaging API which can do the printing for
> you, as an example.
(...)
See:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Native_messaging

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 10 22:14:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 21:14:20 +0000
Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate
 Authen/CAS/Client/ Response/Failure.pm
In-Reply-To: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17717-70-xrf4x2NVwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

--- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks like this one is not dead yet - Tomas, could you take another look as
you hunted down the problem last time?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 10 22:35:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 21:35:08 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-rWQrVK46Dq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Dominic, if you find something wrong with a patch, please switch to 'failed
QA', thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 10 22:37:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 21:37:39 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-qe0pTe3kur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #213 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Caroline Cyr La Rose from comment #212)
> Is there any way to make the configuration of the ILL module more user
> friendly? I wish I didn't have to go in the conf file and on the server to
> configure it.
> 
> Here are some suggestions
> 
> - Tab in system preferences for all ILL configurations
> - Make StaffRequestComments (hide/show) a sys pref
> - Make ReplyDate (hide/show) a sys pref
> - Make DigitalRecipient (borrower/branch) a sys pref
> - Make PartnerCode (text entry, with by default ILLLIBS entered) a sys pref
> - In Tools or Administration, add a page with a form to add backends with
> our own providers
> 
> So far, I've only been able to enable the ILLModule sys pref and create the
> database tables, so I don't really have any suggestions for the other
> parts... I will add them once I figure out the rest.

Hi Caroline, please don't hesitate to file your enhancement ideas and
suggestions as separate bugs and link them depending on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 10 22:41:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 21:41:44 +0000
Subject: [Koha-bugs] [Bug 7901] Add batch delete borrowers script
In-Reply-To: <bug-7901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7901-70-8PWOwMaB7V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just a little update on this, there is another way to batch delete patrons from
the GUI with 17.11:

1) Add patrons to a list
2) Go to the patron lists summary page
3) Actions > Batch delete patrons

Maybe adding an option to add to patron list by cardnumber list/input would
help? Similar to the batch edit/delete item tools.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 00:07:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 23:07:48 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-EsrFoFn2jb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #148 from David Cook <dcook at prosentient.com.au> ---
(In reply to Josef Moravec from comment #147)
> > These patches haven't even been signed off yet. I'm not sure that anyone is
> > even testing them. 
> 
> I am testing this (again) ;)

Hurray! You're a champion, Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 00:15:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 23:15:19 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-BjU1yV0svV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 00:15:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 23:15:09 +0000
Subject: [Koha-bugs] [Bug 19787] New: Adding system preferences to disable
 the screen messages for SIP flags in Self-Checkout
Message-ID: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

            Bug ID: 19787
           Summary: Adding system preferences to disable the screen
                    messages for SIP flags in Self-Checkout
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

These screen messages are known to confuse users, especially when they are just
informative and don't require action. I'll be creating a new system preferences
tab for SIP in Administration and adding a bunch of new system preferences to
enable whether the screen messages for each flag are displayed or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 00:18:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 23:18:10 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-Ns4G9AYtn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, can you give an example? I seem to remember that Kyle added some
mechanism to change the texts that SIP sends via the config files. Is this
similar?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 00:20:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 10 Dec 2017 23:20:03 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-DJe8ZfXqVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I found what I was thinking about: Bug 12571 - Add ability to customize SIP2
screen messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 01:07:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 00:07:25 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-r1KuyGuM6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Hi Katrin,

It's not quite the same. We've had the request from a library to build this
development, so they can choose to hide the screen messages entirely. 

For example, when checking out an item that they already have checked out, the
current behaviour is to renew the checkout and show this message: Item already
checked out to you: renewing item. We've been asked to provide a syspref so
that message doesn't show at all, no behaviour needs to be changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 07:28:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 06:28:19 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-E1wxTPwyDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #56)
> (In reply to Jonathan Druart from comment #55)
> > Marcel, will you agree with these 2 patches? I do not think it's a good idea
> > to use the DBIC schema files during the update DB upgrade.
> > I thought we already agreed on that, but cannot find logs...
> 
> Might have been a good idea to give some more direction in this regard. This
> was a waste of time.
> Will still have a look in detail.

Sorry for being a bit harsh here. You got me thinking about this thing in
general; and it sure is rather serious.. Will test a few things too.
Thx for adjusting the SQL queries. Need to run the dbrev again now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:25:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:25:24 +0000
Subject: [Koha-bugs] [Bug 19788] New: Local preference with uppercase
Message-ID: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

            Bug ID: 19788
           Summary: Local preference with uppercase
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: frederic at tamil.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In Administration > System preferences, when adding a local preference, the
'variable' name is transformed in lowercase.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:26:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:26:13 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-CUHzeveHt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:32:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:32:38 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-td7qMvVWAB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:32:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:32:41 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-pAcrfaMa3A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

--- Comment #1 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 69675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69675&action=edit
Bug 19788 Local preference with uppercase

Fix a bug tranforming new local preference variable name in lowercase.

TO TEST:

1. Admin > System preferences > Local use
2. Button New preference. Fill variable field with 'TESTfoo'. Click
   Save.
3. The new variable is named: 'testfoo'.
4. Apply the patch.
5. Button New preference. Fill variable field with 'TESTfoo2'. Click
   Save.
6. The new variable is properly named: 'TESTfoo2'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:34:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:34:07 +0000
Subject: [Koha-bugs] [Bug 19789] New: Remove some indirect DBIx calls from
	updatedatabase
Message-ID: <bug-19789-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789

            Bug ID: 19789
           Summary: Remove some indirect DBIx calls from updatedatabase
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Triggered by a comment on 19096.

What happens when DBIx schema does not match table design?
Add a field to schema file that does not exist => Koha::Object->new and store
still works, Koha::Objects->search still works but an actual fetch by calling
->next is enough to crash.
DBD::mysql::st execute failed: Unknown column 'me.iserniet' in 'field list'
Add a field to the table but not to the schema file => Seems to work still

Dubious lines in updatedatabase
L12389 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings;
This includes Koha Objects calls to Koha::SearchFields and
Koha::SearchMarcMaps.
The sub add_to_search_marc_maps in Koha::SearchField puzzles me. Does this
work, why is there no test associated with it ?
Any (future) new column in search fields or search marc maps may lead to a
crash at 3.23.00.050

L13526 and context: Koha::Number::Price->new( $order->{rrp} )->round;
Only new calls seem to be fine. But might be tricky.

L14364 and context:
Koha::Holds->search({ found => 'W', priority => 0 });
Any future change in reserves table may lead to a crash on the next statement
in 16.12.00.032.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:37:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:37:04 +0000
Subject: [Koha-bugs] [Bug 17292] Use of DBIx in updatedatabase.pl broke
 upgrade (from bug 12375 )
In-Reply-To: <bug-17292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17292-70-jiuAHeMQ5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17292

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
See also bug 19789.
We need a coding guideline for these things in general. And make developers
aware of it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:38:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:38:56 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-rpkZ35Ukf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #55)
> I do not think it's a good idea
> to use the DBIC schema files during the update DB upgrade.

Added a new report (bug 19789) to pinpoint a few calls in updatedatabase that
could lead to future problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:54:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:54:10 +0000
Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through
 regular Koha plugins
In-Reply-To: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19605-70-XWtXZ4VkLr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:54:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:54:10 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-aVWvbvHXot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19605


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
[Bug 19605] ILL backends should be pluggable through regular Koha plugins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 08:56:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 07:56:17 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-f3rpvd3ShS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #214 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Caroline Cyr La Rose from comment #212)
> - In Tools or Administration, add a page with a form to add backends with
> our own providers

There is bug 19605, which suggests making the ILL backends into regular "KPZ"
plugins. I think Tomas will be working on that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 09:04:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 08:04:28 +0000
Subject: [Koha-bugs] [Bug 19651] SIP/ILS/Item missing title
In-Reply-To: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19651-70-cRPnVpnhLN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19651

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 18276 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 09:11:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 08:11:27 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-lZNeyGkzpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15685
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 15685 which adds this line.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685
[Bug 15685] Allow creation of items (AcqCreateItem) to be customizable
per-basket
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 09:11:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 08:11:27 +0000
Subject: [Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to
 be customizable per-basket
In-Reply-To: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15685-70-4BqBZH78SG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19695


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695
[Bug 19695] Uncertain prices should not use find in list context
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 09:12:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 08:12:00 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-YnmeyGy82o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 09:12:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 08:12:02 +0000
Subject: [Koha-bugs] [Bug 19695] Uncertain prices should not use find in
	list context
In-Reply-To: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19695-70-Xq8fUwiFzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 15685 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 09:12:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 08:12:03 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-fxXRmbZY9c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69675|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69676&action=edit
Bug 19788 Local preference with uppercase

Fix a bug tranforming new local preference variable name in lowercase.

TO TEST:

1. Admin > System preferences > Local use
2. Button New preference. Fill variable field with 'TESTfoo'. Click
   Save.
3. The new variable is named: 'testfoo'.
4. Apply the patch.
5. Button New preference. Fill variable field with 'TESTfoo2'. Click
   Save.
6. The new variable is properly named: 'TESTfoo2'.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 09:24:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 08:24:54 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-NE1HJkzyB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Poushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:02:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:02:15 +0000
Subject: [Koha-bugs] [Bug 19790] New: Remove additionalauthors.author from
 installer files
Message-ID: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

            Bug ID: 19790
           Summary: Remove additionalauthors.author from installer files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:02:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:02:31 +0000
Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from
	installer files
In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19790-70-rhDb31DZof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:31:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:31:22 +0000
Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from
	installer files
In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19790-70-iLGOyyQgvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:31:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:31:25 +0000
Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from
	installer files
In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19790-70-wI1yHPY18g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69677&action=edit
Bug 19790: Remove additionalauthors.author from installer files

In the upgrade from 2.2 to 3.0 (some time ago already) the table
additionalauthors has been dropped. Unfortunately, a reference to this
table has not been removed from the MARC framework installer files.

This patch clears kohafield for 700$a or 200$g in 18 installer files.

Note: The reference to additionalauthors in field kohafield is silently
ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio,
_koha_add_biblioitem, _koha_modify_biblio and
_koha_modify_biblioitem_nonmarc simply do not use it. You can define a
Koha to MARC mapping for a biblio/biblioitem field but if the field is not
referenced in one of those routines, nothing happens..
Also note that C4::Items::_koha_modify_item does not hardcode all fields
and will respond to a new item mapping.

Test plan:
[1] Run a new install or verify somehow that the change to these sql files
    is correct.
    The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g"

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Run a new install with MARC21 and English. This includes the mandatory
file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted
correctly (without additionalauthors).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:31:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:31:30 +0000
Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from
	installer files
In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19790-70-zJqSHZZwje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69678&action=edit
Bug 19790: Add a db revision for existing installs

Since many installs will still have the additionalauthors kohafield,
this patch adds a dbrev in atomicupdate to clear it.

Test plan:
[1] Run updatedatabase. Check that you see no additionalauthors anymore
    in marc_subfield_structure.kohafield.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:36:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:36:51 +0000
Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from
	installer files
In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19790-70-90sNrF5NUV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69677|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69679&action=edit
Bug 19790: Remove additionalauthors.author from installer files

In the upgrade from 2.2 to 3.0 (some time ago already) the table
additionalauthors has been dropped. Unfortunately, a reference to this
table has not been removed from the MARC framework installer files.

This patch clears kohafield for 700$a or 200$g in 32 installer files.

Note: The reference to additionalauthors in field kohafield is silently
ignored in AddBiblio/ModBiblio since the routines _koha_add_biblio,
_koha_add_biblioitem, _koha_modify_biblio and
_koha_modify_biblioitem_nonmarc simply do not use it. You can define a
Koha to MARC mapping for a biblio/biblioitem field but if the field is not
referenced in one of those routines, nothing happens..
Also note that C4::Items::_koha_modify_item does not hardcode all fields
and will respond to a new item mapping.

Test plan:
[1] Run a new install or verify somehow that the change to these sql files
    is correct.
    The change is a result of: sed -i -e "s/'additionalauthors.author'/''/g"

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Run a new install with MARC21 and English. This includes the mandatory
file marc21_framework_DEFAULT.sql. Verified that 700$a was inserted
correctly (without additionalauthors).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:36:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:36:54 +0000
Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from
	installer files
In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19790-70-JPjW1kLF08@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69678|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69680&action=edit
Bug 19790: Add a db revision for existing installs

Since many installs may still have the additionalauthors kohafield,
this patch adds a dbrev in atomicupdate to clear it.

Test plan:
[1] Run updatedatabase. Check that you see no additionalauthors anymore
    in marc_subfield_structure.kohafield.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:43:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:43:10 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-APPUvEFz1f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19790

--- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hmm. Also added another new report (bug 19790) to clear
additionalauthors.author from kohafield and the installer files. Note that this
table was removed before 3.0 !
Somehow I changed my 700$a in an earlier test and now I noticed it when running
your dbrev.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:43:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:43:10 +0000
Subject: [Koha-bugs] [Bug 19790] Remove additionalauthors.author from
	installer files
In-Reply-To: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19790-70-5PvFqbW4Iw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19790

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19096

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:52:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:52:22 +0000
Subject: [Koha-bugs] [Bug 12331] can't save results to zotero
In-Reply-To: <bug-12331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12331-70-ZrZy2OGMRf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12331

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #5 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Looking at that Zotero thread, it appears that this was fixed successfully on
the Zotero side? We're not Zotero users here so I thought I'd ping out a check
to see if there was anything that was still needed on the Koha side before
closing this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 10:55:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 09:55:32 +0000
Subject: [Koha-bugs] [Bug 17292] Use of DBIx in updatedatabase.pl broke
 upgrade (from bug 12375 )
In-Reply-To: <bug-17292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17292-70-T1mNP5ISNd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17292

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #18)
> See also bug 19789.
> We need a coding guideline for these things in general. And make developers
> aware of it.

Hi Marcel and Jonathan, I have added it as a topic to the next developer
meeting:
https://wiki.koha-community.org/wiki/Development_IRC_meeting_13_December_2017#Agenda

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 11:35:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 10:35:31 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-oCxb1WtloF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68779|0                           |1
        is obsolete|                            |
  Attachment #69629|0                           |1
        is obsolete|                            |
  Attachment #69646|0                           |1
        is obsolete|                            |
  Attachment #69647|0                           |1
        is obsolete|                            |

--- Comment #60 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69681&action=edit
Bug 19096: Add dbrev to sync kohafield in all frameworks

Squashed the last four follow-ups into one patch. Instead of adding
two routines to Koha::MarcSubfieldStructures, and instead of moving
them to Koha::Util::Dbrev, we finally ended up with converting the
code to raw SQL queries (thx Jonathan). No need to 'pollute' the git
history with all this moving around.

As Jonathan pointed out, there is a risk in using DBIx calls (with Koha
objects) while running database revisions. See also bug 17292 and
bug 19789.

I tested the resulting db revision by adding a few fields to the Default
framework and adding deviating kohafields in other frameworks. And confirm
that it works as expected.

Please read the remainder of this commit message in the light of the above:

===

The dbrev will use two new routines in MarcSubfieldStructures:
[1] get_kohafield_exceptions is used to report deviating kohafields in
    the additional frameworks,
[2] sync_kohafield is used to reset kohafield in the other frameworks to
    the mapping in Default.

Test plan:

Unit test and database revision:
[1] Run t/db_dependent/Koha/MarcSubfieldStructures.t
[2] Verify that your Default 100a is mapped to biblio.author. Go to another
    framework and clear the mapping via mysql command line:
    UPDATE marc_subfield_structure SET kohafield=NULL WHERE
frameworkcode=[your_framework] AND tagfield='100' AND tagsubfield='a';
[3] Run the db revision. It should report that 100a was adjusted.
[4] Check in admin/marc_subfield_structure that your 100a is mapped to
    biblio.author again in that framework.

Additional interface testing (ensuring that the changes on this report do
not interfere with multiple mappings):
[5] Make two mappings for copyrightdate: 260c and 264a. And make two
    mappings for biblioitems.pages: 300a and say 300g. Toggle with some
    field values in those fields in the cataloging editor and verify the
    contents of biblio.copyrightdate and biblioitems.pages. The former
    should contain one year (due to additional logic) and the latter should
    contain A | B if both fields are filled.
    Remove the mapping for 300g.
[6] Set AcqCreateItem to ordering or placing. Verify that you can still
    add or receive an order as usual.
[7] Add a mapping for itemcallnumber to 952f (this should remove the one
    for coded_location_qualifier). This is very unusual but serves well in
    testing multiple mappings for items.
    Add or receive an order (fill 952f and 952o) with same and/or different
    values. Verify the contents of items.callnumber. (Check with regular
    item editor; see note.)
    Do a similar edit in the regular item editor.
    Note: You should expect to see A | B in both 952f and 925o if both
    fields are filled with a different value.
    Set items.coded_location_qualifier back to 952f in koha2marclinks.

    Note: When AcqCreateItem==ordering, you will not see A|B in the callno
    field when adding an item on neworderempty.pl. But when you submit
    the main form, addorder.pl is called. At that time an item is created
    and you will see that A|B is in both fields (952f and 952o).

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Bug 19096: (QA follow-up) Move two routines out of Koha::MSS

As requested by RM, this patch moves sync_kohafield and
get_kohafield_exceptions from Koha/MarcSubfieldStructures.pm.

At this moment they are only used in a database revision; it is not clear
if they may be of use later on.

In order to keep them in a module and not remove the unit tests, this
patch adds a Koha::Util module Dbrev.pm. It is now required in the atomic
update, but could be added in a use statement in updatedatabase.pl.

Test plan:
[1] Run updatedatabase.pl
[2] Run t/db_dependent/Koha/MarcSubfieldStructures.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 19096: Use raw SQL queries instead for the update DB entry

I strongly thing we must not use C4 or Koha subroutine in the update DB
process, only sql queries.
Especially not DBIC Schema files as they will change.
For instance the update DB 17.12.00.00X is using a specific
Koha::Schema::RS::MSS
representing the current schema, but in X months/years, this schema will change
and the ->search we used may failed.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Bug 19096: Move the sql queries to the update DB entry

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Print "Field 700$a" instead of "Field 700.a" in the dbrev.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 11:38:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 10:38:46 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-Aw2xaohVd2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #61 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #55)
> Marcel, will you agree with these 2 patches? I do not think it's a good idea
> to use the DBIC schema files during the update DB upgrade.

So yes, I finally did :) Thx again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 11:54:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 10:54:05 +0000
Subject: [Koha-bugs] [Bug 19791] New: patron Modification log redirects to
 circulation page ( Koha 17.11)
Message-ID: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

            Bug ID: 19791
           Summary: patron Modification log redirects to circulation page
                    (Koha 17.11)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: ayousef at kwareict.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Dear all,

- Showing patron Modification log from koha 17.11 doesn't show any system log
for the patron, Instead it redirects to 
(http://domain_name/cgi-bin/koha/circ/circulation.pl?borrowernumber=)

- Just try filling the (Librarian:) field with the borrower number instead of
the (Object:) field, And leave the (Object:)field empty, You will see what I
mean.

- Also you can test it here
(http://koha.adminkuhn.ch:8080/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=1&src=circ),
It's a demo site for koha 17.11 provided by koha community here
(https://koha-community.org/demo/)  use (demo/demo) for logging in, Then test
it for this user (Herr Demokrit Morgenstern (1)), Also the problem was not in
koha 17.05, You can test it using
Bywater demo version (koha17.05), You will see that it working fine in koha
(17.05).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 12:14:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 11:14:49 +0000
Subject: [Koha-bugs] [Bug 15308] Suggested new interface for item type
 translation process
In-Reply-To: <bug-15308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15308-70-xpwK1GNWUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15308

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 12:47:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 11:47:27 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-zFpyhlP5Yg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 12:47:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 11:47:29 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-iBFoNygosL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69621|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69682&action=edit
Bug 19777: Move template JavaScript to the footer: Serials, part 3

This patch modifies even more staff client serials templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JavaScript include, serials-toolbar.js, which is
required on pages which include serials-toolbar.inc.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials
   - Search for a subscription
     - Tabs, datatables, date pickers
     - Open a subscription for viewing
       - Tabs, toolbar buttons for delete, renew, and close.
   - Serial collection (in the sidebar menu)
     - Select all / clear all
     - Datatable
     - Print slip
     - Generate next

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 14:46:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 13:46:48 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-TZElyGZ3gA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 14:47:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 13:47:16 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-J21LhG5JdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69662|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:09:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:09:42 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-GwsB89iKEb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19784


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784
[Bug 19784] Adapt /v1/patrons to new naming guidelines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:09:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:09:42 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-YC7yWtOw6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19686

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Dominic, I'm sorry. I forgot to add one dependency.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686
[Bug 19686] objects.search helper needs a to_model param
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:11:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:11:25 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-6C2u5et2MB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:34:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:34:54 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-K1ZsvUFT5B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:04 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-tgkSkW8vKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #75 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:12 +0000
Subject: [Koha-bugs] [Bug 12227] remove demo user functionality
In-Reply-To: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12227-70-m5qe021rZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:24 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-SRxqK6EkRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:31 +0000
Subject: [Koha-bugs] [Bug 19292] Add MARC code column on libraries list
In-Reply-To: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19292-70-KDleWbOx8M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:42 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-6jHufCUzFG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:38 +0000
Subject: [Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch
 with Koha::Holds-> waiting
In-Reply-To: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19299-70-4WePg5LsF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:44 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-b5giH4L55X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:45 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-0BKojZRyj7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69683&action=edit
Bug 19785: Move template JavaScript to the footer: Authorities, part 1

This patch modifies even more staff client authorities templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Authorities
   - New from Z39.50
   -> Search
      -> Results
         - New from Z39.50
         - Deletion confirmation
         - Merge records -> Merge
           - Tabs
           - Tag selection
         -> Authority detail
            - Tabs
            - Deletion confirmation
            - New from Z39.50

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:50 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-054oy3ww5C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:35:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:35:57 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-m1fwQlvp3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:04 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-hQYeOVxCac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:11 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-yCKh95KWkw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:18 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-sqPR4rvU42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:25 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-L5uRgDkTgv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:33 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-QBMDGe0P9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:39 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-uObNkPsf1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:45 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-puovA16g4O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:36:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:36:52 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-ISZLzhJqlJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:00 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-x9Ru1BCtBq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:07 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-BPgf2aG41u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:18 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-jMIX3zls4l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:27 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-dgtRzx5LfB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:40 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-gVSSsZgO0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:34 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-KDpyzFKhfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:46 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-gTbVk0pkOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:37:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:37:52 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-hWuccZwki3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 15:42:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 14:42:30 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-UCEe6Jqtp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

--- Comment #76 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #75)
> Pushed to master for 18.05, thanks to everybody involved!

YAY!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 16:10:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 15:10:16 +0000
Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input
In-Reply-To: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12310-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12310-70-u6MdwkZJn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 16:23:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 15:23:43 +0000
Subject: [Koha-bugs] [Bug 19791] patron Modification log redirects to
 circulation page ( Koha 17.11)
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-FB1gLO6z0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |In Discussion

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
With bug 19080 we tried to redirect to the circulation home page when the
borrowernumber did not exist (anymore).

When you click on the "modification log" tab, the "object" parameter is
automatically filled with the borrowernumber of the patron you are looking at.

If you decide to empty this field or use a non-existent borrowernumber, you
will get redirected to the circulation home page.

I would suggest to:
- Disable the "object" input and force the value to borrowernumber when we come
from the circulation module and redirect to circ home page if non-existent
- Make it editable when come from the tools module and display a "no logs"
message if non-existent borrowernumber is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 16:47:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 15:47:11 +0000
Subject: [Koha-bugs] [Bug 19080] Handle non existing patrons
In-Reply-To: <bug-19080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19080-70-T4tpgnKQ49@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19791


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791
[Bug 19791] patron Modification log redirects to circulation page (Koha 17.11)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 16:47:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 15:47:11 +0000
Subject: [Koha-bugs] [Bug 19791] patron Modification log redirects to
 circulation page ( Koha 17.11)
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-eTS6N7tafd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19080


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080
[Bug 19080] Handle non existing patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 16:47:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 15:47:19 +0000
Subject: [Koha-bugs] [Bug 19791] patron Modification log redirects to
	circulation page
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-qFH8wUHHak@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|patron Modification log     |patron Modification log
                   |redirects to circulation    |redirects to circulation
                   |page (Koha 17.11)           |page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 16:49:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 15:49:39 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
	acquisitions searches
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-TB01d0owAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
  Attachment #65479|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 16:53:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 15:53:32 +0000
Subject: [Koha-bugs] [Bug 19190] Silly calculation of average time in
	touch_all scripts
In-Reply-To: <bug-19190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19190-70-y8GpSL4a1N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in 17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:06:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:06:36 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-0GKxqu9mIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:09:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:09:53 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-b1BGPTRYAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:09:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:09:57 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-ZhTIrJxKY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69536|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:00 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-PqMvco6qHd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69537|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:04 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-lura3hbJ3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69538|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:08 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-y1GTMoXxvU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69539|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:11 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-5Ib9DCFRbG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69540|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:14 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-KzSIhivUPC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69541|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:18 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-pzZhFCDJF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69533|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:25 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-lU4JnF9KZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69535|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:10:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:10:21 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-TFXqZLajjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69534|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:11:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:11:18 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-wndnHfqM5f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #67 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69684&action=edit
Bug 16735: Remove modules no longer needed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:11:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:11:32 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-NtSaEvN1nc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #69 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69686&action=edit
Bug 16735: Clean up sample data

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:11:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:11:24 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-iZtAyotoaq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #68 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69685&action=edit
Bug 16735: Remove tables no longer needed

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:11:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:11:43 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-YNvwgG2JCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #70 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69687&action=edit
Bug 16735: Migrate library search groups into the new hierarchical groups

Test Plan:
1) Apply this patch set
2) Note your existing search groups have been ported over to the new
   __SEARCH_GROUPS__ group if you had any
3) Create the group __SEARCH_GROUPS__ if one does not already exist
4) Add some first level subgroups to this group, add libraries to those groups
5) Search the library group searching in the intranet and opac
6) Note you get the same results as pre-patch

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:11:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:11:56 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-esylOORXyj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #71 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69688&action=edit
Bug 16735: Don't use objects for database update

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:12:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:12:05 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-8A6ddnL2M9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #72 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69689&action=edit
Bug 16735: Remove use of get_categories

Feature using it is completely undocumented as far as my research has
shown.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:12:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:12:14 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-G72pSY99GZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #73 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69690&action=edit
Bug 16735: Filter individual libraries from search group pulldown

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:12:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:12:25 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-uHg4SBsCiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #74 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69691&action=edit
Bug 16735: DBIC Schema files

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:12:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:12:32 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-24dqwZeHVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #75 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69692&action=edit
Bug 16735: Use libraries in all subgroups, not just immediate children

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:12:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:12:38 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-WJdm8lvPP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #76 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69693&action=edit
Bug 16735: (QA followup) POD fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:16:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:16:52 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-DuFt9gnbje@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15758
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by commit df97814f3034a3d5015546c4eca21f08ae951e37
Bug 15758: Koha::Libraries - Remove GetBranches
(certainly a bad merge conflict)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
[Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:16:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:16:52 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
 Koha::Libraries - part 4
In-Reply-To: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15758-70-5GxGtui7SA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19769


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769
[Bug 19769] 'Pickup library is different' message does not display library
branch name when placing hold
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:17:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:17:28 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-bZGvuK0tvn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:29:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:29:54 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-rg8uTrvkqc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #77 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69694&action=edit
Bug 16735: (QA followup) Fix rebase error

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:32:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:32:28 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-4CsCEmzzlT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69695&action=edit
Bug 10021: Remove notify headers from pay*.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:34:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:34:23 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-JJb6AUYthQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69695|0                           |1
        is obsolete|                            |

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69696&action=edit
Bug 10021: Remove notify headers from pay*.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:53:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:53:49 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-1K9AiRoiux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:53:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:53:52 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-KfDtx8GyNL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69697&action=edit
Bug 19767: serial-issues.pl is unused and should be removed

This patch removes three unused files:

serials/serial-issues.pl

...and its associated templates:

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt

To test, apply the patch and search the Koha codebase for references to
any of those files. None should exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 17:58:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 16:58:01 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-9XNQGKoyHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69698&action=edit
Bug 10021: Only display outstanding fines in 'Pay fines'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:14:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:14:46 +0000
Subject: [Koha-bugs] [Bug 19791] patron Modification log redirects to
	circulation page
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-sgV4sF39Cr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

--- Comment #2 from Abdou Yousuf <ayousef at kwareict.com> ---
(In reply to Jonathan Druart from comment #1)
> With bug 19080 we tried to redirect to the circulation home page when the
> borrowernumber did not exist (anymore).
> 
> When you click on the "modification log" tab, the "object" parameter is
> automatically filled with the borrowernumber of the patron you are looking
> at.
> 
> If you decide to empty this field or use a non-existent borrowernumber, you
> will get redirected to the circulation home page.
> 
> I would suggest to:
> - Disable the "object" input and force the value to borrowernumber when we
> come from the circulation module and redirect to circ home page if
> non-existent
> - Make it editable when come from the tools module and display a "no logs"
> message if non-existent borrowernumber is used.

I don't think that it's beneficial to automatically fill (Object field) with
the borrower number, On the contrary I think that the (Librarian:) field should
be automatically filled by borrower number rather than (Object field), And it
will be more beneficial, In fact I don't know why borrower number should be in
(Object field) and not (Librarian field) when selecting "modification log" tab,
What are the benefits?

Also, You said that you tried to redirect to the circulation home page when the
borrower number did not exist (anymore), How it can be? I think it's not
logical even though it can be done programmatically.

Regards.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:23:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:23:32 +0000
Subject: [Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for
	patrons
In-Reply-To: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18626-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18626-70-re36BagpIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please add tests to cover this change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:28:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:28:48 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-opmTRu1Klk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69699&action=edit
Bug 19542: Use comma to separate indices

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:31:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:31:59 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-ZgR5EKyv5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69130|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:43:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:43:56 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-0XdXMVaVjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:43:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:43:59 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-De3oAvyLvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69490|0                           |1
        is obsolete|                            |

--- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69700&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:45:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:45:20 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-Da4Isy8AYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #20 from Owen Leonard <oleonard at myacpl.org> ---
Jonathan's patch is all that is needed. I've rebased it on master and signed
off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:49:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:49:30 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
 acquisitions searches ( subtitle)
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-EAkyWTBpiR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow Keyword to MARC       |Allow Keyword to MARC
                   |mapping for acquisitions    |mapping for acquisitions
                   |searches                    |searches (subtitle)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:53:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:53:18 +0000
Subject: [Koha-bugs] [Bug 11210] Allow partial writeoff
In-Reply-To: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11210-70-kOK0YkiOiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:53:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:53:25 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
 acquisitions searches ( subtitle)
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-NqNUX63lUN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:53:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:53:32 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-6ocasRVlIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:53:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:53:36 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-m4Exq0QQBc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #46)
> Created attachment 69696 [details] [review]
> Bug 10021: Remove notify headers from pay*.tt

(In reply to Jonathan Druart from comment #47)
> Created attachment 69698 [details] [review]
> Bug 10021: Only display outstanding fines in 'Pay fines'

These last 2 patches have been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:53:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:53:38 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-QfG7Fo6ohc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:53:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:53:45 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-hourtqXAay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:53:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:53:53 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-pIgtvilxha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 18:54:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 17:54:00 +0000
Subject: [Koha-bugs] [Bug 3841] Add a Default ACQ framework
In-Reply-To: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3841-70-gYZBQEWy3Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:13:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:13:56 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-4i45tE9ukM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69700|0                           |1
        is obsolete|                            |

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69701&action=edit
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Edit: Rebased on Bug 19560

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:22:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:22:24 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-ew550UjRay@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi
                   |ity.org                     |
         QA Contact|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:29:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:29:35 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-ZYXtmxENkO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69700|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:29:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:29:56 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-UxLRqsCAsb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69701|0                           |1
        is obsolete|                            |

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
Comment on attachment 69701
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69701
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

Sorry, attached in the wrong place!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:31:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:31:45 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-7LGBOlkULI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Alex Buckley <alexbuckley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #78 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
I have tried to apply these patches as they are a dependency for the patches on
bug 19765 however I have found that the patches attached to this  bug report
(16735) not longer cleanly apply on an up to date branch. 

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16735: Remove modules no longer needed
Applying: Bug 16735: Remove tables no longer needed
Applying: Bug 16735: Clean up sample data
Applying: Bug 16735: Migrate library search groups into the new hierarchical
groups
fatal: sha1 information is lacking or useless (C4/Auth.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 16735: Migrate library search groups into the new
hierarchical groups
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-16735-Migrate-library-search-groups-into-the-n-yOLkh7.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:32:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:32:39 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-2Hfo9U6zrx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
> We did, but the reason old_issues exists, is because keeping it one massive
> table becomes really slow quite fast.

I think maybe we need to check our assumptions. We may have be running on best
practices that are out of date. I think that happens to us all from time to
time.

MySQL is capable of dealing with tens or even hundreds of millions of rows very
speedily, as long as the correct indexes are in place.

For example, I picked out a database to test with from a Koha consortium. They
have  1,456,666 old_issues rows, and 50122 issues rows.

Searching on a column with no index ( such as issuedate ) returned a single
record from almost 1.5 million records in 1.04 seconds. Not terrible, but
definitely not great. However, searching for the same row using an indexed
column took less time than mysql could measure! It reported back taking 0.00
seconds ; )

I've done some digging and it appears that many people are using mysql for
tables with tens to hundreds of millions of rows with no adverse effects.

Perhaps that was an issue during the early years of Koha, when MySQL was much
less mature, but I don't think it is anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:41:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:41:15 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-2dKMRfjfHA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #42 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Kyle M Hall from comment #41)
> > We did, but the reason old_issues exists, is because keeping it one massive
> > table becomes really slow quite fast.
> 
> I think maybe we need to check our assumptions. We may have be running on
> best practices that are out of date. I think that happens to us all from
> time to time.
> 
> MySQL is capable of dealing with tens or even hundreds of millions of rows
> very speedily, as long as the correct indexes are in place.
> 
> For example, I picked out a database to test with from a Koha consortium.
> They have  1,456,666 old_issues rows, and 50122 issues rows.
> 
> Searching on a column with no index ( such as issuedate ) returned a single
> record from almost 1.5 million records in 1.04 seconds. Not terrible, but
> definitely not great. However, searching for the same row using an indexed
> column took less time than mysql could measure! It reported back taking 0.00
> seconds ; )
> 
> I've done some digging and it appears that many people are using mysql for
> tables with tens to hundreds of millions of rows with no adverse effects.
> 
> Perhaps that was an issue during the early years of Koha, when MySQL was
> much less mature, but I don't think it is anymore.

I think this was introduced at some point to ease the use of TRUNCATE as
opposed to DELETE when wiping old data.

There are other ways to deal with fragmentation already (OPTIMIZE?), so I'd
suggest the tables are joined and a proper use of tinyint for the flags.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 19:45:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 18:45:51 +0000
Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups
 functionality with the new hierarchical groups system
In-Reply-To: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16735-70-mEfZxYPkkf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #79 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
It applies cleanly if you have the dependencies in your branch.

This is latest master. I've applied the dependent bug (15707) manually so it is
more readable:

tcohen at bibliotecas-1:koha(qa_16735)$ git reset --hard origin/master 
HEAD is now at 03dd826757 Bug 17182: (QA follow-up) Fix call to GetMarcBiblio
tcohen at bibliotecas-1:koha(qa_16735)$ git bz apply 15707
Bug 15707 - Add ability to define hierarchical groups of libraries

69573 - Bug 15707: Update DB
69574 - Bug 15707: Add Koha::Library::Group(s) modules
69575 - Bug 15707: Add library groups editor
69576 - Bug 15707: Unit Tests
69577 - Bug 15707: Fix conflict with bug 15446 (type vs _type)
69578 - Bug 15707: (QA followup) Switch to treetable which Koha already uses
69579 - Bug 15707: (QA followup) Drop table if exists
69580 - Bug 15707: (QA followup) Fix UI issues
69581 - Bug 15707: (QA followup) Remove class for treegrid
69582 - Bug 15707: (QA followup) Allow object names to be styled without
impeding translation
69583 - Bug 15707: (followup) use cat-search instead of cities-search in header
69584 - Bug 15707: Switch datetimes to timestamps
69585 - Bug 15707: Add UNIQUE constraint to library groups table
69586 - Bug 15707: Updates for Bootstrap 3
69587 - Bug 15707: Display error if group title is already used
69588 - Bug 15707: DBIC Schema files
69589 - Bug 15707: (QA followup) Style buttons correctly

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15707: Update DB
Applying: Bug 15707: Add Koha::Library::Group(s) modules
Applying: Bug 15707: Add library groups editor
Applying: Bug 15707: Unit Tests
Applying: Bug 15707: Fix conflict with bug 15446 (type vs _type)
Applying: Bug 15707: (QA followup) Switch to treetable which Koha already uses
Applying: Bug 15707: (QA followup) Drop table if exists
Applying: Bug 15707: (QA followup) Fix UI issues
Applying: Bug 15707: (QA followup) Remove class for treegrid
Applying: Bug 15707: (QA followup) Allow object names to be styled without
impeding translation
Applying: Bug 15707: (followup) use cat-search instead of cities-search in
header
Applying: Bug 15707: Switch datetimes to timestamps
Applying: Bug 15707: Add UNIQUE constraint to library groups table
Applying: Bug 15707: Updates for Bootstrap 3
Applying: Bug 15707: Display error if group title is already used
Applying: Bug 15707: DBIC Schema files
Applying: Bug 15707: (QA followup) Style buttons correctly
tcohen at bibliotecas-1:koha(qa_16735)$ git bz apply 16735

Bug 16735 Depends on bug 15707
Follow? [(y)es, (n)o] n
Bug 16735 - Replace existing library search groups functionality with the new
hierarchical groups system

69684 - Bug 16735: Remove modules no longer needed
69685 - Bug 16735: Remove tables no longer needed
69686 - Bug 16735: Clean up sample data
69687 - Bug 16735: Migrate library search groups into the new hierarchical
groups
69688 - Bug 16735: Don't use objects for database update
69689 - Bug 16735: Remove use of get_categories
69690 - Bug 16735: Filter individual libraries from search group pulldown
69691 - Bug 16735: DBIC Schema files
69692 - Bug 16735: Use libraries in all subgroups, not just immediate children
69693 - Bug 16735: (QA followup) POD fixes
69694 - Bug 16735: (QA followup) Fix rebase error

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16735: Remove modules no longer needed
Applying: Bug 16735: Remove tables no longer needed
Applying: Bug 16735: Clean up sample data
Applying: Bug 16735: Migrate library search groups into the new hierarchical
groups
Applying: Bug 16735: Don't use objects for database update
Applying: Bug 16735: Remove use of get_categories
Applying: Bug 16735: Filter individual libraries from search group pulldown
Applying: Bug 16735: DBIC Schema files
Applying: Bug 16735: Use libraries in all subgroups, not just immediate
children
Applying: Bug 16735: (QA followup) POD fixes
Applying: Bug 16735: (QA followup) Fix rebase error
tcohen at bibliotecas-1:koha(qa_16735)$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:28:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:28:15 +0000
Subject: [Koha-bugs] [Bug 19792] New: Reduce number of SQL calls in
	GetBudgetHierarchy
Message-ID: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

            Bug ID: 19792
           Summary: Reduce number of SQL calls in GetBudgetHierarchy
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: david.bourgault at inlibro.com
          Reporter: david.bourgault at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

The way GetBudgetHierarchy works right now can result in a (very) high number
of SQL calls for databases with many budgets.
This causes slow downs and performance issues for some libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:37:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:37:33 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-0H77MAS8C7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:37:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:37:35 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-rCeMl7rnrF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69702&action=edit
Bug 19792 - Perf. boost for GetBudgetHierarchy

This patches reduces the number of SQL calls by combining multiple calls to the
recursive functions GetBudgetSpent(), GetBudgetOrdered(), etc. into 4 big
queries.
It also removes duplicate function calls from acqui-home.pl

Test plan:
0) Visit Acquisition home
0) Apply patch
1) Refresh page. It shoud look identical.
2) prove t/db_dependent/budgets.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:52:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:52:46 +0000
Subject: [Koha-bugs] [Bug 19634] Advanced editor - Rancor - error in display
 of macro editor in firefox
In-Reply-To: <bug-19634-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19634-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19634-70-rrjmSHJovL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19634

--- Comment #2 from Ed Veal <eveal at mckinneytexas.org> ---
Owen, 

Yep it has something to do with the way FireFox is rendering the page, because
it is fine on Chrome. 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:54:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:54:04 +0000
Subject: [Koha-bugs] [Bug 19586] Improve budget display
In-Reply-To: <bug-19586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19586-70-CxqhoukhcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19586

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |david.bourgault at inlibro.com
         Resolution|---                         |DUPLICATE

--- Comment #1 from David Bourgault <david.bourgault at inlibro.com> ---


*** This bug has been marked as a duplicate of bug 19792 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:54:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:54:04 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-dGwrutELXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

--- Comment #2 from David Bourgault <david.bourgault at inlibro.com> ---
*** Bug 19586 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:54:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:54:58 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-tGGH2ACGjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Ed Veal <eveal at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eveal at mckinneytexas.org

--- Comment #8 from Ed Veal <eveal at mckinneytexas.org> ---
Thanks everyone, it will be nice to glean out the work around css. 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 20:55:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 19:55:00 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-nmdhkgjxJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
>From Bug 19586 (codebase is essentially the same):

> I used the followup patch with CCSR to cut the DB calls from 30000 to 5.  Display idle time went from 30+ seconds to 1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:25:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:25:36 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-fpCdkonjh1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69703&action=edit
Bug 19410: (follow-up) Move build_query_params_from_api into a helper

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:43:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:43:24 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-pOZn0OmMCu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69704&action=edit
Bug 19278: (follow-up) Make the pagination plugin use RESTdefaultPageSize

Use 20 as default for RESTdefaultPageSize (just in case)

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:47:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:47:26 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-RS8ZGbxT3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:47:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:47:31 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-wd0fApoiqm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:47:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:47:37 +0000
Subject: [Koha-bugs] [Bug 19369] Add a helper function for translating
 pagination params into SQL:: Abstract
In-Reply-To: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19369-70-Uc382MznUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:47:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:47:42 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-WHmUc5JtOp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:47:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:47:48 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-isDoHaqRFh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:51:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:51:16 +0000
Subject: [Koha-bugs] [Bug 19793] New: Add a field for email in batch patron
	modification
Message-ID: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

            Bug ID: 19793
           Summary: Add a field for email in batch patron modification
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org

Hi, 

It could be nice in batch patron modification tool's to add a new field for the
email adrress. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 21:57:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 20:57:13 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-AsMWgmjVTP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Patrick, can you explain the use case?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 22:04:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 21:04:16 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-wyWnCTi6pn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #2 from Patrick Robitaille <patrick.robitaille at collecto.ca> ---
Hi,

This would be to avoid having to export data and import them again to change
the user's email address. Because it possible to change the email adrress when
you import a patron' field in default values.

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 22:08:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 21:08:50 +0000
Subject: [Koha-bugs] [Bug 19247] Feature release change tool
In-Reply-To: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19247-70-936dEBkwC4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247

--- Comment #9 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Katrin

Sorry for not replying sooner. 

The purpose of display_choices is a way of displaying option values in the
feature Release Change Tool.

I cannot use the YAML files because they are organised by their functionality,
e.g. there is a admin.pref for all administration related system preferences. 

I want to retrieve and display the system preferences by the version they were
added in and so it would require a very complex regular expression to go
through each of the YAML files to find the system preference with a matching
name.

Whereas by having the display_choices values in the database in records
containing the version number I can both retrieve the system preference
information and display information in one go. 

So that was my rationale for the display_choices.

I hope that makes sense :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 22:08:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 21:08:47 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-2A8o8TTHOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Patrick, sorry, I was not clear. I was wondering, because with batch patron
modification you can only set to 1 value (same email for all) or empty a field
out. Wondering what the use case is where you want to do that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 22:13:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 21:13:49 +0000
Subject: [Koha-bugs] [Bug 19247] Feature release change tool
In-Reply-To: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19247-70-FN6xzgPf2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19247

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Hmm the problem with the db, is it is not translatable, which will make this
tool not useful for non English users. (which is a lot of the world)

Also they will get out of sync with the yaml files pretty fast.
Maybe look into the code that does the syspref search now, and see if you can
reuse that? It is searching over the yaml files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 22:31:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 21:31:33 +0000
Subject: [Koha-bugs] [Bug 19794] New: Rename RLIST - Routing list notice
 template as it' s not related to routing lists
Message-ID: <bug-19794-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19794

            Bug ID: 19794
           Summary: Rename RLIST - Routing list notice template as it's
                    not related to routing lists
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

The sample notice RLIST - Routing list has indeed nothing to do with routing
lists, but is a sample template for patrons subscribing to get informed by
email about newly arriving issues for their favourite serials. 

There is no connection to the routing list feature at all - so the name is
confusing to a lot of people, even if the hint in the subscription form is
correct already. I propose to rename the template (help from native speakers
welcome):

SERIAL_ALERT - New serial issue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 22:58:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 21:58:07 +0000
Subject: [Koha-bugs] [Bug 19795] New: Allow files to be uploaded and stored
 in object storage ( Swift and S3)
Message-ID: <bug-19795-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19795

            Bug ID: 19795
           Summary: Allow files to be uploaded and stored in object
                    storage (Swift and S3)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: chris at bigballofwax.co.nz
        QA Contact: testopia at bugs.koha-community.org

Currently if we enable uploading and attaching files to a biblio, we only have
the option to store the locally on the file system.

More and more Koha are being hosted in the "cloud" we should allow people to
use the object storage offerings to store their uploaded files.

This bug will add support for Openstack Swift, and Amazon S3 only, and only for
files attached to biblios. However the code should be able to be used for book
covers etc in the future if someone wants to add that feature

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:27:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:27:27 +0000
Subject: [Koha-bugs] [Bug 19796] New: [16.11] Subscription info appears
 doubled up on OPAC detail page
Message-ID: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

            Bug ID: 19796
           Summary: [16.11] Subscription info appears doubled up on OPAC
                    detail page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: chris at bigballofwax.co.nz,
                    colin.campbell at ptfs-europe.com

When bug 18754 was merged into 16.11 a little mistake crept in. The
"Subscripiton from: ..." line now appears twice on the subscription tab on the
OPAC detail page.

 823 [% END %]
 824 <p>Subscription from: [% subscription.histstartdate | $KohaDates %] to:[%
IF ( subscription.histenddate ) %] [% subscription.histenddate | $KohaDates %]
[% ELSE %] now (current)[% END %]</p>
 825 <p class="subscription_dates">Subscription from: [%
subscription.histstartdate | $KohaDates %] to:[% IF ( subscription.histenddate
) %] [% subscription.histenddate | $KohaDates %] [% ELSE %] now (current)[% END
%]</p>
 826 [% IF ( subscription.missinglist ) %]

This is where the mistake happened:
http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=b0d86d10443809f3762bdac75a59d704f1a3976b

Problem is in 16.11 only, doesn't appear in 17.05 and up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:29:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:29:19 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-WGr02SFhMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |16.11

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:29:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:29:31 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-lHDwymk634@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:31:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:31:49 +0000
Subject: [Koha-bugs] [Bug 19795] Allow files to be uploaded and stored in
 object storage ( Swift and S3)
In-Reply-To: <bug-19795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19795-70-TIgzfL6SiG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19795

--- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> ---
Actually I will make it work with tools/upload.pl but to start with only when
called by the cataloguing plugin.

It should be very simple for others to extend it

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:46:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:46:56 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-UOBIzMHkUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Hi Katrin

Upon discussion with Chris, we've decided to do something different with this
and a bit more similar to Bug 12571. Instead of having sysprefs that turn the
messages off and on, we'll have sysprefs with text areas so librarians can put
their own messages in, leave the default ones, or have them completely empty.
This will be good for translation purposes and libraries can use messages in
their own languages and means they don't need access to config files etc.

Will attach patch when ready

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:52:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:52:39 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-E6bkTHCYXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, that sounds pretty nice!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:57:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:57:56 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-vTDJkN4pPI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 11 23:57:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 22:57:59 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-aNCf0EBkao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69705&action=edit
Bug 19796 - Fix doubled up subscription info on OPAC detail page

The info "Subscription from..." is showing twice on the subscription
tab on the OPAC detail page because of a bad merge. This patch removes
the doubled up information.

To test:
- Add a subscription
- Search for the record in the OPAC
- Switch to the subscription tab
- Verify that the 'Subscription from...' line is repeated
- Apply patch
- Verify only one line remains and nothing is missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 00:20:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 23:20:36 +0000
Subject: [Koha-bugs] [Bug 19797] New: Subscribers to email notifications for
 new issues are broken
Message-ID: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

            Bug ID: 19797
           Summary: Subscribers to email notifications for new issues are
                    broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

The option to subscribe to email for newly arrived serial issues is something
that people like a lot in Koha - currently this is broken a bit in both
versions I tested.

For master:

To test:
- Add a subscription
- Make sure you set a notice template for 'notification' on the first page
- Go to the record in the OPAC
- Subscribe to email notifications from the Subscriptions tab
- Go back to the subscription detail page
- Click on the 'subscribers' link
- Verify that the list shown is empty
- Verify that the alert table in the database has the entry for the subscribed
patron
- Verify that in the OPAC it now asks you to cancel subscription

For 16.11: (I can move this to a separate bug if needed)
- Follow above test plan until "subscribe..."
- Verify that the redirect is to an empty page
- Verify that the subscriber link doesn't work
- Verify that the link doesn't change to cancel and you can subscribe mulitple
times
- Verify that the alert table will have multiple entries for your
borrowernumber and subscription id

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 00:23:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 23:23:21 +0000
Subject: [Koha-bugs] [Bug 19797] Subscribers to email notifications for new
 issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-1ahYcOBG38@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Note: 
In 16.11.x you can only subscribe form the full history, click 'more details'
at the bottom of the subscription page to go there.
Also the link will only show, when you are logged in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 00:23:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 23:23:33 +0000
Subject: [Koha-bugs] [Bug 19797] Subscribers to email notifications for new
 issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-ZDlyUu4dvh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 00:30:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 11 Dec 2017 23:30:45 +0000
Subject: [Koha-bugs] [Bug 19797] Subscribers to email notifications for new
 issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-qBFc51m7VH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it stems from this change here:

http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=27891cbfe2160a8ed72df384490430d111e6c9e8
                                 <input type="hidden" name="externalid"
value="[% externalid %]">
-                                <input type="hidden" name="alerttype"
value="issue">
-                                <input type="hidden" name="biblionumber"
value="[% biblionumber %]">
+                                <input type="hidden" name="alerttype"
value="[% alerttype %]">
+                                <input type="hidden" name="biblionumber"
value="[% biblionumber | html 

When you check the alert table the type is empty, which explains the problem
with the subscribers list display and possibly also the problems appearing in
16.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 01:27:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 00:27:33 +0000
Subject: [Koha-bugs] [Bug 19795] Allow files to be uploaded and stored in
 object storage ( Swift and S3)
In-Reply-To: <bug-19795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19795-70-rRWCjLx5oM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19795

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 69706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69706&action=edit
Bug 19795 : Add sysprefs (only Swift so far, S3 to come)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 01:27:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 00:27:44 +0000
Subject: [Koha-bugs] [Bug 19795] Allow files to be uploaded and stored in
 object storage ( Swift and S3)
In-Reply-To: <bug-19795-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19795-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19795-70-k7yiRVIsZu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19795

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 69707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69707&action=edit
Bug 19795 Have it so you can upload files, and they are stored in swift

Not ready for use in production yet

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 05:22:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 04:22:00 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-lW24ibCu3W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #65 from Dilan Johnpull? <dilan at calyx.net.au> ---
Hi Tomas, I was able to successfully run all the tests and add and delete
patrons using RESTer following your helpful advice in IRC. Unfortunately
attempting to update patrons (PUT /api/v1/patrons/<borrowernumber>) throws a
500 Internal Server Error. The Koha logs don't show anything in them related to
this and my apache logs don't show anything out of the ordinary either. 

Thanks again for the help.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 08:16:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 07:16:13 +0000
Subject: [Koha-bugs] [Bug 19797] Subscriptions to email notifications for
 new serial issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-nRwhc0TGsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Subscribers to email        |Subscriptions to email
                   |notifications for new       |notifications for new
                   |issues are broken           |serial issues are broken

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 08:29:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 07:29:03 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-APdUPPFSr1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #23 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 69700
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69700
Bug 19560: Correctly escape branchcode in admin/branches.pl

Review of attachment 69700:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19560&attachment=69700)
-----------------------------------------------------------------

Just a quick look at the code:

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
@@ +5,4 @@
>  [% ELSIF op == 'delete_confirm_category' %]
>      &rsaquo; Confirm deletion of group [% category.categorycode %]
>  [% ELSIF op == 'add_form' %]
> +    &rsaquo;[% IF library %]Modify library[% ELSE %]New library [% library.branchcode | html %][% END %]

Shouldn't it be?

&rsaquo;[% IF library %]Modify library [% library.branchcode | html %][% ELSE
%]New library[% END %]

looks like this is bug in current master...

@@ +67,4 @@
>  [% ELSIF op == 'delete_confirm_category' %]
>  &rsaquo; Confirm deletion of group [% category.categorycode %]
>  [% ELSIF op == 'add_form'  %]
> +&rsaquo; [% IF library %]Modify library[% ELSE %]New library [% library.branchcode | html %][% END %]

The same

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 08:44:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 07:44:40 +0000
Subject: [Koha-bugs] [Bug 19791] patron Modification log redirects to
	circulation page
In-Reply-To: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19791-70-BhqN9sFsgF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Abdou Yousuf from comment #2)
> (In reply to Jonathan Druart from comment #1)
> > With bug 19080 we tried to redirect to the circulation home page when the
> > borrowernumber did not exist (anymore).
> > 
> > When you click on the "modification log" tab, the "object" parameter is
> > automatically filled with the borrowernumber of the patron you are looking
> > at.
> > 
> > If you decide to empty this field or use a non-existent borrowernumber, you
> > will get redirected to the circulation home page.
> > 
> > I would suggest to:
> > - Disable the "object" input and force the value to borrowernumber when we
> > come from the circulation module and redirect to circ home page if
> > non-existent
> > - Make it editable when come from the tools module and display a "no logs"
> > message if non-existent borrowernumber is used.
> 
> I don't think that it's beneficial to automatically fill (Object field) with
> the borrower number, On the contrary I think that the (Librarian:) field
> should be automatically filled by borrower number rather than (Object
> field), And it will be more beneficial, In fact I don't know why borrower
> number should be in (Object field) and not (Librarian field) when selecting
> "modification log" tab, What are the benefits?

The tabs on patron pages are all relevant to current patron, that is the reason
why borrowernumber is in object - you want here to get information about this
patron. 

> Also, You said that you tried to redirect to the circulation home page when
> the
> borrower number did not exist (anymore), How it can be? I think it's not
> logical even though it can be done programmatically.

It could be possible - for example one librarian deletes a patron and the
second librarian wants to show some information about patron. 

> 
> Regards.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:03:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:03:04 +0000
Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through
 regular Koha plugins
In-Reply-To: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19605-70-OffSHaQiwb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:24:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:24:11 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-1hX03eWzqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 16.11.x will be in 16.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:31:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:31:58 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-xv4ihnSk6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:32:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:32:02 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-oQuC56QzwS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69178|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 69708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69708&action=edit
Bug 19593 Basketcount correction on Bookseller.pm

To test:
1/ go to /cgi-bin/koha/acqui/booksellers.pl or
/cgi-bin/koha/acqui/supplier.pl
2/ Note that it displays the delete vendor button instead of the
receive shipments button
3/ Apply patch
4/ Reload the page and notice the button is fixed

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:52:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:52:01 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-25AxD6kZpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|waiting items cannot be     |waiting and in transit
                   |reserved                    |items cannot be reserved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:54:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:54:38 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-hck3iLJIvz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68428|0                           |1
        is obsolete|                            |
  Attachment #68429|0                           |1
        is obsolete|                            |
  Attachment #68430|0                           |1
        is obsolete|                            |
  Attachment #68431|0                           |1
        is obsolete|                            |
  Attachment #68432|0                           |1
        is obsolete|                            |
  Attachment #68433|0                           |1
        is obsolete|                            |
  Attachment #68434|0                           |1
        is obsolete|                            |
  Attachment #68435|0                           |1
        is obsolete|                            |
  Attachment #68436|0                           |1
        is obsolete|                            |
  Attachment #68437|0                           |1
        is obsolete|                            |
  Attachment #68438|0                           |1
        is obsolete|                            |
  Attachment #68439|0                           |1
        is obsolete|                            |
  Attachment #68440|0                           |1
        is obsolete|                            |
  Attachment #68441|0                           |1
        is obsolete|                            |
  Attachment #68442|0                           |1
        is obsolete|                            |
  Attachment #68443|0                           |1
        is obsolete|                            |

--- Comment #90 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69709&action=edit
Bug 18606: Add RotationCollections object classes

Test plan:
1) Apply the patch
2) Update database
3) Go to tools -> Rotating collections and play with trying to break it:
    3a) Add some collections
    3b) Edit them
    3c) Add some items to collections
    3d) Remove some items
    3e) Transfer some collections
    3f) Try to remove collection without items
    3g) Try to remove collection with items
4) Go to returns and:
    4a) Try to return item from untransferred collection
    4b) Try to return item from transferred collection
5) prove t/db_dependent/Koha/RotatingCollections.t
t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t
t/db_dependent/Circulation/Returns.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:54:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:54:42 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-975qzBHYy7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #91 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69710&action=edit
Bug 18606: Easy ones - CRUD

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:54:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:54:46 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-BGKvVi20To@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #92 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69711&action=edit
Bug 18606: Database changes - Add foreign keys to collections_tracking

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:54:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:54:50 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-uiALRpyLqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #93 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69712&action=edit
Bug 18606: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:54:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:54:53 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-A5xhDpgPbo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #94 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69713&action=edit
Bug 18606: Get rid of GetItemsInCollection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:54:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:54:57 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-y4Kp4UEbUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #95 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69714&action=edit
Bug 18606: Get rid of GetCollectionItemBranches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:01 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-PY180saD4A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #96 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69715&action=edit
Bug 18606: Get rid of AddItemToCollection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:05 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-ifbxTvt2JZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #97 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69716&action=edit
Bug 18606: Get rid of RemoveItemFromCollection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:09 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-GjHmDVknxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #98 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69717&action=edit
Bug 18606: Get rid of TransferCollection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:12 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-i26Ciq1VRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #99 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69718&action=edit
Bug 18606: Get rid of isItemInThisCollection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:16 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-NlOv89tpD4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #100 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69719&action=edit
Bug 18606: Get rid of isItemInAnyCollection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:20 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-1e3ojU36sy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #101 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69720&action=edit
Bug 18606: Remove lefover of C4::RotatingCollections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:24 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-9Vmgi4jQVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #102 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69721&action=edit
Bug 18606: Rework tests for rotating collections

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:28 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-FRGlv03fxx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #103 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69722&action=edit
Bug 18606: Add test to t/db_dependent/Koha/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 09:55:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 08:55:32 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-5HllKnDEUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #104 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69723&action=edit
Bug 18606: Unify handling of success/error messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:04:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:04:18 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-pDbgSHr6ka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #60 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Marcel de Rooy from comment #56)
> It would be more consistent if we should use IsItemOnHoldAndFound in
> IsAvailableForItemLevelRequest instead of a Koha::Holds->search. We actually
> should adjust that routine. It does the same.

Are we sure IsItemOnHoldAndFound does the same than Koha::Holds->search on W
and T?
What about a F status? Is it already used?

Patch is coming for the others QA things

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:16:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:16:11 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-8TBvPyinel@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68786|0                           |1
        is obsolete|                            |

--- Comment #61 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69724&action=edit
Bug 4319 - [OPAC] allow to holds waiting items

Test plan:

 - Checkout an item
 - Place hold on this item,
 - Return the item
 - Make sure the hold is waiting (found W) and AllowOnShelfHolds is
   not to 'Allow'
 - Check that the button "Place hold" appears in opac detail page of
   the biblio

 - do the samewith items/reserves in transit

Changes on C4::Reserves::IsAvailableForItemLevelRequest

Make sure this tests pass:
  - t/db_dependent/Reserves.t
  - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

Rebased - 2017-12-12 - Alex Arnaud

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:16:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:16:23 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-bywYcg503U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #62 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69725&action=edit
Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:18:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:18:01 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-zS6ZsDvBPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:35:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:35:59 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-IskmGS0L93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Gwendal and Chris!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:39:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:39:24 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-YqB3gjZovP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Claire Gravely <claire_gravely at hotmail.com> ---
Hullo,

issue when applying dependencies: 
Applying: Bug 19560: Correctly escape branchcode in admin/branches.pl
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:47:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:47:00 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-8ZTZTsdcqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #32 from S?verine Queune <severine.queune at bulac.fr> ---
(In reply to Katrin Fischer from comment #31)
> Ok, still not quite understanding it :)
> 
> Why the holds awaiting pickup list? That would mean, you got the book for
> the patron, you checked it in, you sent the email notice to the patron and
> THEN you notice it's actually not there... ? Wouldn't it make more sense to
> this from the holds queue or holds to pull pages that you use when looking
> for the item?

You're certainly right Katrin, it would be more logic to have this option on
"Holds to pull".
We made a mistake when we though of this enhancement because we have lots of
local developments and one the consequence is that the 2 lists "Holds queue"
and "Holds to pull" are always empty.
Sorry about that Jonathan, will it be ok for you ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:58:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:58:11 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-CB1TIQF6YL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63603|0                           |1
        is obsolete|                            |

--- Comment #5 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69726&action=edit
Bug 18330: Add RFC3339 to Koha::DateUtils

To test:
1. prove t/DateUtils.t

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:58:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:58:18 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-3YYI3t6rLU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63604|0                           |1
        is obsolete|                            |

--- Comment #6 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69727&action=edit
Bug 18330: Handle date-time in Koha::Object->TO_JSON

This patch formats timestamps and datetimes to meet date-time definition
in RFC3339, as required by Swagger documentation.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 10:59:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 09:59:19 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-uyF33W1aXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
All tests pass. Good work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 11:18:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 10:18:52 +0000
Subject: [Koha-bugs] [Bug 19798] New: Returns.pl doesn't define itemnumber
 for transfer-slip.
Message-ID: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

            Bug ID: 19798
           Summary: Returns.pl doesn't define itemnumber for
                    transfer-slip.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bjorn.nylen at ub.lu.se
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Marking master as version as 17.11 isn't available to select.

It seems the itemnumber isn't set in the link/button that prints
transfer-slips.

To reproduce:
1. Check in available/not on hold item at a non owning library.
2. Press transfer-button.
3. Resulting slips says "Item not found".

"Inspect element" in browser for the button indicates that itemnumber is not
set: "transfer-slip.pl?transferitem=&branchcode=CPL&op=slip"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 11:35:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 10:35:36 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-Fm2iQhAaLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69725|0                           |1
        is obsolete|                            |

--- Comment #63 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69728&action=edit
Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 11:46:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 10:46:00 +0000
Subject: [Koha-bugs] [Bug 17860] MARC records will stage,
 but Manage for import shows '  no data in table'
In-Reply-To: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17860-70-rQSRvbE24N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

niko <schachne at th-brandenburg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |schachne at th-brandenburg.de

--- Comment #3 from niko <schachne at th-brandenburg.de> ---
Hi there,
it seems that i have exactly the same problem here.
execute failed: Field 'marcxml_old' doesn't have a default value [for Statement
"INSERT INTO import_records (import_batch_id, record_sequence, marc, marcxml, :
/usr/share/koha/intranet/cgi-bin/tools/stage-marc-import.pl, referer:
http://localhost:8080/cgi-bin/koha/tools/stage-marc-import.


I am using MariaDB and I am quite a newbie.
I am not able to locate the right file in MariaDB to add 

sql-mode="IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION"

nor I am sure it is necessary in MariaDB.
Can You give me a hint, please...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 11:50:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 10:50:12 +0000
Subject: [Koha-bugs] [Bug 17860] MARC records will stage,
 but Manage for import shows '  no data in table'
In-Reply-To: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17860-70-0j7pFauNzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

--- Comment #4 from niko <schachne at th-brandenburg.de> ---
to be more specific about my test-Installation:
Ubuntu-16.04
Koha version:   17.05.06.000
MySQL version:  mysql Ver 15.1 Distrib 10.2.11-MariaDB, for debian-linux-gnu
(x86_64) using readline 5.2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 12:07:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 11:07:43 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-vFwSUnMWnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #66 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
One thing that needs to be fixed:
PUT endpoint uses C4::ModMember (which I think is plain wrong, but thats
another issue and I understand why...) and this requires borrowernumber as
param due to some internal lookups, categorycode e.g.)

tests pass since entire patron object is passed in, but that's a false
positive, since borrowernumber shouldn't be passed in body, its already a path
param. since path param must be authoritative, I suggest just overwriting body
param in the helper method already used.

Otherwise great work!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 12:10:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 11:10:19 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-AhzSHs23Kj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
Bug 17258 depends on bug 17860, which changed state.

Bug 17860 Summary: MARC records will stage, but Manage for import shows 'no data in table'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 12:10:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 11:10:19 +0000
Subject: [Koha-bugs] [Bug 17860] MARC records will stage,
 but Manage for import shows '  no data in table'
In-Reply-To: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17860-70-Spn2HBghQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

niko <schachne at th-brandenburg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #5 from niko <schachne at th-brandenburg.de> ---
found it:
/etc/mysql/conf.d/mariadb.cnf
restarted the mysq-server.

now it works.

the documentation here implies that this problem is not present with MariaDB.
This seems to be wrong!?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 12:15:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 11:15:31 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-6kJx2iBcTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Linux                       |All
            Version|17.05                       |master
           Hardware|PC                          |All
           Severity|critical                    |major
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |nick at bywatersolutions.com
           Priority|P1 - high                   |P3

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
This appears to be an issue if there are no CCODE values defined. The column
limiting code is malformed and javascript error breaks functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 12:18:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 11:18:35 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-UN8D9OTYIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 12:18:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 11:18:38 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-q1hQ2e1Dcx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69729&action=edit
Bug 19706 - Fix bad json formed when there are no CCODE values

To test:
1 - Delete all ccode values in your system
2 - Load the item search page
3 - View the console and note a js error
4 - Try to perform an item search to screen
5 - Internal server error ("unsupported format 'html'" in logs)
6 - Apply patch
7 - Reload page
8 - Note js error is gone
9 - Perform search to screen, success!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 13:36:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 12:36:12 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-kpVwRrK1Iq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #4 from Sally Healey <sally.healey at cheshiresharedservices.gov.uk> ---
Hi Katrin,

We have this as a local customisation on our install and it's saved hours.

We use it when we receive bouncebacks; we simultaneously empty the e-mail
address field and add both circulation and OPAC messages to advise the
patron/branch staff of the failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 13:53:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 12:53:34 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-dLQP0eMFxP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #64 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jon Knight from comment #63)
> Created attachment 69728 [details] [review]
> Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit
> 
> Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Jon,
For completeness: 
Did you intentionally sign off only the latest patch?
Or is it meant as a complete signoff and did you forget to change status?

Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 13:58:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 12:58:55 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-1zM1Sf3d9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
--- a/Koha/SearchEngine/Elasticsearch.pm
+++ b/Koha/SearchEngine/Elasticsearch.pm
@@ -22,6 +22,7 @@ use base qw(Class::Accessor);
[...]
+use Search::Elasticsearch;

Hmm
Can't locate Search/Elasticsearch.pm in @INC (you may need to install the
Search::Elasticsearch module) (@INC contains: /usr/share/koha/masterclone
/usr/share/koha/rma/lib /usr/share/koha/qa-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) at
/usr/share/koha/masterclone/Koha/SearchEngine/Elasticsearch.pm line 33.
BEGIN failed--compilation aborted at
/usr/share/koha/masterclone/Koha/SearchEngine/Elasticsearch.pm line 33.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:01:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:01:55 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-C5M51oC6aT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69730&action=edit
Bug 19542: (QA follow-up) Remove module

Resolve:
Can't locate Search/Elasticsearch.pm in @INC (you may need to install the
Search::Elasticsearch module)

By removing the module Search::Elasticsearch.

Test plan:
[1] Check if module compiles now
[2] Running updatedatabase now passes

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:03:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:03:12 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-M5dvqeIldK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69730|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69731&action=edit
Bug 19542: (QA follow-up) Remove module

Resolve:
Can't locate Search/Elasticsearch.pm in @INC (you may need to install the
Search::Elasticsearch module)

By removing the module Search::Elasticsearch.

Test plan:
[1] Check if module compiles now
[2] Running updatedatabase now passes

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:03:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:03:34 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-wq0miP7UV9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

--- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Removing != commenting ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:25:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:25:45 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-BNou1APlLl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69731|0                           |1
        is obsolete|                            |

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 69731
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69731
Bug 19542: (QA follow-up) Remove module

Removing this patch, since it is not a complete fix. But I still think this
needs attention..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:27:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:27:03 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-nYCI2ffHsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Chris Cormack from comment #8)
> Pushed to 16.11.x will be in 16.11.15

This patch breaks tests:
https://jenkins.koha-community.org/job/Koha_16.11_D8/89/

#   Failed test 'No tests run for subtest "json"'
#   at t/db_dependent/Template/Plugin/To.t line 44.
Can't locate object method "build_object" via package "t::lib::TestBuilder" at
t/db_dependent/Template/Plugin/To.t line 32.
# Looks like your test exited with 255 just after 1.
[09:41:40] t/db_dependent/Template/Plugin/To.t

The build_object method of TestBuilder has been added by bug 18182, which is
not in 16.11.x
You should use ->build instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:29:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:29:55 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-WhX9THZZX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69732&action=edit
Bug 19655: Use ->build instead of build_object in 16.11.x

The build_object method of TestBuilder has been added by bug 18182,
which is not in 16.11.x

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:39:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:39:02 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-pMkNpDD28p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Josef Moravec from comment #23)
> looks like this is bug in current master...

Yes, definitely

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:45:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:45:40 +0000
Subject: [Koha-bugs] [Bug 17860] MARC records will stage,
 but Manage for import shows '  no data in table'
In-Reply-To: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17860-70-NPAqW3xxsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to niko from comment #5)
> found it:
> /etc/mysql/conf.d/mariadb.cnf
> restarted the mysq-server.
> 
> now it works.
> 
> the documentation here implies that this problem is not present with MariaDB.
> This seems to be wrong!?

Indeed, https://mariadb.com/kb/en/library/sql-mode/:
"""
Since MariaDB 10.2.4, SQL_MODE is by default set to
NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO.
In earlier versions of MariaDB 10.2, and since MariaDB 10.1.7, SQL_MODE is by
default set to NO_ENGINE_SUBSTITUTION,NO_AUTO_CREATE_USER. For earlier versions
of MariaDB 10.1, and MariaDB 10.0 and before, no default is set.
"""

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:51:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:51:47 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-rfiPwcJ4bX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69084|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69733&action=edit
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Edit: Rebased on Bug 19560

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:53:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:53:24 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-IkQvDGaOHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #65 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Ah, sorry it was a sign off from applying the bugs using git bz as normal, so
I'd not noticed it only included one.  Should be a complete sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:53:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:53:56 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-7TRX3dBuBR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #66 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Ah, sorry it was a sign off from applying the bugs using git bz as normal, so
I'd not noticed it only included one.  Should be a complete sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:54:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:54:12 +0000
Subject: [Koha-bugs] [Bug 17860] [SQL strict mode] MARC records will stage,
 but Manage for import shows 'no data in table'
In-Reply-To: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17860-70-nH3EUjIqsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
            Summary|MARC records will stage,    |[SQL strict mode] MARC
                   |but Manage for import shows |records will stage, but
                   |'no data in table'          |Manage for import shows 'no
                   |                            |data in table'
             Status|RESOLVED                    |REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:54:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:54:13 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-qe1zZaAlb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
Bug 17258 depends on bug 17860, which changed state.

Bug 17860 Summary: [SQL strict mode] MARC records will stage, but Manage for import shows 'no data in table'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:54:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:54:20 +0000
Subject: [Koha-bugs] [Bug 17860] [SQL strict mode] MARC records will stage,
 but Manage for import shows 'no data in table'
In-Reply-To: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17860-70-zFoatohp2y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:56:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:56:08 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-slN0ZgZKHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69311|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69734&action=edit
Bug 19603: Move admin templates JavaScript to the footer: Patrons and
circulation

This patch modifies the staff client patrons and circulation-related
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Edit: Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 14:56:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 13:56:27 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-4QJ4GYHxql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #67 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jon Knight from comment #66)
> Ah, sorry it was a sign off from applying the bugs using git bz as normal,
> so I'd not noticed it only included one.  Should be a complete sign off.

Thx.
@Alex: I plan to resume QA on this one soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:03:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:03:17 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-gkLSzzmBx1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #68 from Alex Arnaud <alex.arnaud at biblibre.com> ---
@Marcel: did you read my question on Comment 60 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:08:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:08:26 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-2Go3v5REGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69700|0                           |1
        is obsolete|                            |

--- Comment #25 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69735&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:10:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:10:11 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-ehS30xY5kw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69735|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:11:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:11:33 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-NjlhArrNjD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #26 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69736&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:13:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:13:10 +0000
Subject: [Koha-bugs] [Bug 19782] QA tools does not check svc and unapi files
In-Reply-To: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19782-70-hmTsHrIRId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19782

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |FIXED
             Status|Needs Signoff               |RESOLVED

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed!
Thanks Josef

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:15:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:15:42 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-Cp4tGGBBW2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I did some rebasing to other bugs this morning so I think this is ready to
test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:21:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:21:15 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-suPIDvUX9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #32 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #30)
> Bonjour Alex
> It's ok now as far as keeping irregularities is concerned : the
> corrresponding issues  to exclude are now automatically checked when
> checking the top table of "permanent" irregularities.
> But there's one problem remaining about multi-receiving weekly serials.
> The excluded issues are correctly skipped when receiving issues one by one
> but not when receiving through multi-receiving function.
> 
> For the others two periodicities (daily and monthly), it also works with
> multi-receiving.
> 
> I tested without patch and the problem disappears.
> 
> Olivier Crouzet

Hello Olivier,

Can you write a test plan for this bug? I've tried the following one and it
works for:

  - create a weekly serial from week #44 to week 50 (7 issues),
  - place irregularities on week #47 and #48, save,
  - click on Receive button on subscription detail page,
  - click on multi-receiving,
  - How many issues do you want to receive ? => 7
  - I got 5 issues generated. #47 and #48 has been skipped

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:28:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:28:11 +0000
Subject: [Koha-bugs] [Bug 19799] New: [16.11] Changing language on OPAC
 redirects back to homepage
Message-ID: <bug-19799-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19799

            Bug ID: 19799
           Summary: [16.11] Changing language on OPAC redirects back to
                    homepage
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: claire_gravely at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

Whilst looking at an item detail page on the OPAC (opac-detail.pl) you are
redirected back to the OPAC homepage instead of staying on opac-detail. The
language is successfully changed.

This is not an issue on master. We have tested it on 16.11, am not sure if it
is an issue anywhere inbetween.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:28:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:28:31 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-vTako9tZrS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69236|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:28:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:28:47 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-ASLPV8YZNB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:33:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:33:00 +0000
Subject: [Koha-bugs] [Bug 19800] New: confusion with the notification for an
 item "in transfer" during a check-in
Message-ID: <bug-19800-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19800

            Bug ID: 19800
           Summary: confusion with the notification for an item "in
                    transfer" during a check-in
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi,

When we receive a items in transfer, we have two option. We can cancel the
transfer with te fonction "Tranfers to receive" or we can do a check-in. But,
the notification the notification that appears is confusing. Indeed, in this
notification it is written taht the item is "Not Checked out.". The message is
misleading because that could be perceived as if the check-in had not worked
the first time. The message should be like "Item in transit - now available" or
"Item returned from transit - Now available". Like this, the notification would
no longer be confusing for library staff. 

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:47:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:47:03 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-c0DuVKxJsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69292|0                           |1
        is obsolete|                            |

--- Comment #4 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69737&action=edit
Bug 19682: Move JS to the footer: Two patron-related tools

This patch modifies two patron-related tools templates in the staff
client so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Import patrons
  - Upload patron images

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:47:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:47:00 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-SGvUjOY10l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:54:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:54:43 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-KuxIyhSaPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68913|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69738&action=edit
Bug 19494: Add reservedate to Holds awaiting pickup

Add reservedate to report.
Change label "Available since" to "Waiting since".

Note: The table (already) crosses the boundaries of its container. Also
the vertical spacing for the first column (already) is not the same as the
others. (Adding the second date only makes it more visible.) These minor
design issues should be solved on another report.

Test plan:
[1] Go to Circulation, Holds awaiting pickup
[2] Note the additional column for reservedate.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 15:57:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 14:57:29 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-3YcbX6DACR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Simple rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 16:14:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 15:14:14 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-DnLfJD2vqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69018|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69739&action=edit
Bug 19584: Check compare barcodes box when uploading barcodes

This patch makes two trivial changes in the inventory interface:

[1] If you have uploaded a barcode file, the compare barcodes checkbox is
automatically checked. In most cases this will be the option the user wants.
The compare will report missed items on the shelf.
[2] If the compare barcodes checkbox is checked, the Skip items on loan-
checkbox is automatically checked. This again is often desirable. If you
compare, you normally are not interested in seeing items reported missing
while they are checked out.

Test plan:
[1] Upload a barcode file on inventory. Is the compare checked?
[2] Toggle compare. Does 'skip items on loan' change accordingly?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 16:15:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 15:15:52 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-2gbA3I71nK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased for template footer moves

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 16:26:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 15:26:00 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-Tn89ekQvS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 16:25:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 15:25:45 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-5kZ6FbZzZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69740&action=edit
Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Revised: My original patch included changes to batchMod-edit.tt but
didn't take into account the MARC plugins which are loaded in the item
edit form. I have discarded those changes for now.

Tools -> Batch record modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit records for deletion
    - Page highlighting in the sidebar
    - Checkbox selection links
    - Warning when no records selected
    - Patron autocomplete in the "Check out" tab
Tools -> Batch item modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
Tools -> Batch item deletion
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit items for deletion
    - Patron autocomplete in the "Check out" tab
    - Checkbox selection links
    - Column-hiding checkboxes
    - Datatables
Tools -> Batch record modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit records for modification
      - Page highlighting in the sidebar
      - Patron autocomplete in the "Check out" tab
      - Checkbox selection links
      - Datatables
      - MARC preview
      - Warning when no records selected
      - Progress bar after submitting items for modification

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 16:58:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 15:58:10 +0000
Subject: [Koha-bugs] [Bug 3717] staffClientBaseURL and OPACBaseURL should be
	used
In-Reply-To: <bug-3717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3717-70-6B7OncRlgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3717

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #5 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Now that we've had things like Bug 16401 push to master which is most
definitely using staffClientBaseURL (and indeed including the protocol details
now) it looks like we're actively using staffClientBaseURL alot more. Its in
svc/import_bib, the CAS authentication, several test suites, and (if it gets
unblocked) bug 12027 will use it for Shibboleth too.

I guess the question at this point is where else in the Koha codebase does
staffClientBaseURL need to appear? Having a look at some pages returned by the
staff client at the moment we have a lot of "path-absolute" (in RFC 3986 terms)
URIs in there.  For example "/intranet-tmpl/prog/css/mainpage.css",
"/cgi-bin/koha/catalogue/search.pl", "/intranet-tmpl/prog/js/basket.js". Those
look to be hard coded in the templates (eg
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt), so to change them
will mean a large number of templates will need to be altered.  

One option might be to drop the leading slash on the path in these URLs the
templates and include a BASE element in the head of the HTML output that
specified the staffClientBaseURL? That would mean that people could put the
Koha staff client under any base path they liked then (which I think is the
major thrust of this bug report?).  Opinions?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:06:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:06:54 +0000
Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys
	pref
In-Reply-To: <bug-13589-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13589-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13589-70-qaqDRbpB8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 12363 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:06:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:06:54 +0000
Subject: [Koha-bugs] [Bug 12363] Marking an item as lost in koha always
 returns it, but longoverdue.pl may not
In-Reply-To: <bug-12363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12363-70-z6Pvg2WGWK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 13589 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:37:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:37:10 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-auerTYKF59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:37:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:37:13 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-Tp3ghijrYs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #4 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69741&action=edit
[SIGNED-OFF] Bug 17770: Sitemapper.t fails if date changes during test run

To compensate, DateTime->now is mocked to the current date.

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:37:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:37:16 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-VSA186JiiW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #5 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69742&action=edit
[SIGNED-OFF] [SIGNED-OFF] Bug 17770: Improve perlcritic level

before patch: perlcritic -4 noisy
after patch: perlcritic -4 ok

Signed-off-by: Your Full Name <your_email>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:37:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:37:19 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-voO4bpkIUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #6 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69743&action=edit
[SIGNED-OFF] [SIGNED-OFF] Bug 17770: Perltidy

Signed-off-by: Your Full Name <your_email>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:37:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:37:40 +0000
Subject: [Koha-bugs] [Bug 19786] Move template JavaScript to the footer:
 Authorities, part 2
In-Reply-To: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19786-70-alOfsEZBCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:37:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:37:42 +0000
Subject: [Koha-bugs] [Bug 19786] Move template JavaScript to the footer:
 Authorities, part 2
In-Reply-To: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19786-70-TJlewfrNWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69744&action=edit
Bug 19786: Move template JavaScript to the footer: Authorities, part 2

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template.

I've made one change to the JavaScript in addition to moving it: I've
made it so that the blank window which pops up briefly in this process
is 100px x 100px instead of full screen.

- Cataloging -> Add or edit bibliographic record in a framework which
  has authorities linked to a tag
  -> Click authorities plugin link
     -> Create new authority button
     -> Autocomplete on text inputs (except "Search all headings")
     -> Search
        -> Select authority record ("choose")
           -> Click authorities plugin link again
              -> Clear field

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:39:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:39:37 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-M9OksF1U1Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #7 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Hmm, I removed the duff "Signed-off-by: Your Full Name <your_email>" in all
three patches I thought... that was just signed off by me.  

Incidentally I checked this by running the given test repeatedly whilst
changing the date on the machine wildly - all tests completed successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:52:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:52:48 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-fXjpX5aeFl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69729|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69745&action=edit
Bug 19706: Fix bad json formed when there are no CCODE values

To test:
1 - Delete all ccode values in your system
2 - Load the item search page
3 - View the console and note a js error
4 - Try to perform an item search to screen
5 - Internal server error ("unsupported format 'html'" in logs)
6 - Apply patch
7 - Reload page
8 - Note js error is gone
9 - Perform search to screen, success!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 17:52:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 16:52:45 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-e3Clsr3JNu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:00:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:00:30 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-8kG1VKsE8f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68994|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:00:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:00:34 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-IoCrlgFItN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:00:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:00:43 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-n1VZVkQgja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68995|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:00:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:00:56 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-M1F7VtcS3P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68996|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:04:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:04:20 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-DUCXgEZR09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
The Your Name sign offs are usually a result of failing to set the git setting
up:
https://wiki.koha-community.org/wiki/Git_bz_configuration
https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_git#Download_the_latest_Koha_release
(Some of the things overlap, some don't. That's why I put both)

Also, you'll notice your signed off versions have [SIGNED-OFF] in the title.
That means you have to pay attention to which things you need to obsolete when
attaching, because different title means different patch. I've obsoleted the
non-signed versions. Thanks for the sign off, Jon Knight. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:20:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:20:20 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-dPqSRskcnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:21:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:21:24 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-hvWKzzsnoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68251|0                           |1
        is obsolete|                            |
  Attachment #68252|0                           |1
        is obsolete|                            |
  Attachment #68253|0                           |1
        is obsolete|                            |
  Attachment #68254|0                           |1
        is obsolete|                            |
  Attachment #68255|0                           |1
        is obsolete|                            |
  Attachment #68284|0                           |1
        is obsolete|                            |

--- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69746&action=edit
Bug 19287: Add ability to mark an item ?Lost? from ?Holds to pull? list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the ?Holds to pull? page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you
need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home ? Circulation ? Holds to pull
>From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
>From which library do we want to pick the notice? This patch use
reserves.branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:22:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:22:30 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-iBN2lnINfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #105 from Owen Leonard <oleonard at myacpl.org> ---
Testing functionality goes without any problem, but running "prove
t/db_dependent/Koha/Items.t t/db_dependent/Circu lation.t" gave this result:

t/db_dependent/Circulation.t (Wstat: 65280 Tests: 42 Failed: 1)
  Failed test:  41
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 112 tests but ran 42.

Also, running the QA tool highlighted some issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:24:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:24:04 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds awaiting pickup ' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-8nHZUONxTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19759                       |

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am not convinced by this patch, but you can try it and let me know how do you
feel about it.
There are now 2 prefs CanMarkHoldsToPullAsLost and
UpdateItemWhenLostFromHoldList.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759
[Bug 19759] TestBuilder generates too many decimals for float
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:24:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:24:04 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-Xq2UtFvEF2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19287                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287
[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup'
list
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:24:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:24:19 +0000
Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from
 'Holds to pull' list
In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19287-70-whGJOc3Voe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ability to mark an item |Add ability to mark an item
                   |'Lost' from 'Holds awaiting |'Lost' from 'Holds to pull'
                   |pickup' list                |list

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:30:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:30:25 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-s9Ojmj4WC6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:30:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:30:30 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-ZETKnUr49Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69697|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69747&action=edit
Bug 19767: serial-issues.pl is unused and should be removed

This patch removes three unused files:

serials/serial-issues.pl

...and its associated templates:

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt

To test, apply the patch and search the Koha codebase for references to
any of those files. None should exist.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:30:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:30:48 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-JUWhZEYgLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #1)
> It would be good to get a confirmation from the list

http://lists.koha-community.org/pipermail/koha-devel/2017-December/044196.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:37:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:37:51 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-jRmjSeog5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #116 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Bourgault from comment #115)
> I've been told that isn't necessary.

It depends.
If you are not confident with your rebase it may be helpful to ask for another
signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:53:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:53:00 +0000
Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket'
	without explanation
In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10032-70-Ph49QfTlPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69748&action=edit
Added disabled "Close this basket" button when uncertain prices are present.
Note that whilst this has a "title" attribute, there is no tooltip shown
because JQueryUI disabled buttons don't get DOM events.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 18:53:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 17:53:22 +0000
Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket'
	without explanation
In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10032-70-I32v55QLX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 19:24:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 18:24:09 +0000
Subject: [Koha-bugs] [Bug 19801] New: Internal note added to the detail's
	user page
Message-ID: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

            Bug ID: 19801
           Summary: Internal note added to the detail's user page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi,

When a user have a internal note in his account, this note is visible when we
consult the user's informations in the "check-out" page.We see this note too
when we do a chechk-out for this user in the circulation page. It would be
great to see this note too in the user "details" page in his account. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 19:43:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 18:43:58 +0000
Subject: [Koha-bugs] [Bug 19359] Reporting module selenium test
In-Reply-To: <bug-19359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19359-70-aWBTYBMTja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 19:43:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 18:43:58 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-VFjlrVgSSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19359


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359
[Bug 19359] Reporting module selenium test
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 20:38:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 19:38:13 +0000
Subject: [Koha-bugs] [Bug 19800] confusion with the notification for an item
 "in transfer" during a check-in
In-Reply-To: <bug-19800-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19800-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19800-70-Rykxp4eRcv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19800

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 20:39:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 19:39:40 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-TxFcq2BXxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 22:03:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 21:03:32 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-xhuWyvISZv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jason Palmer <jpalmer at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jpalmer at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 22:24:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 21:24:08 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-VZnNp0Kv6y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69726|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69749&action=edit
Bug 18330: Add RFC3339 to Koha::DateUtils

To test:
1. prove t/DateUtils.t

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 22:24:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 21:24:19 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-xes2ZhKnPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69727|0                           |1
        is obsolete|                            |

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69750&action=edit
Bug 18330: Handle date-time in Koha::Object->TO_JSON

This patch formats timestamps and datetimes to meet date-time definition
in RFC3339, as required by Swagger documentation.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 22:36:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 21:36:17 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-UX6X16zbJy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 22:36:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 21:36:21 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-CVaApSALov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69751&action=edit
Bug 18330: (follow-up) Adapt holds.t to match the new datetime format

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 22:56:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 21:56:14 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-fSTDfw2QE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #67 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69752&action=edit
Bug 16330: (QA follow-up) ModMember requires borrowernumber

This patch fixes the tests so they highlight the fact that:
- PUT only worked on the tests because borrowernumber was passed on them
- ModMember expects borrowernumber on the hash it gets passed.

It also fixes the issue.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:14:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:14:36 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-RoNPmsS56Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:14:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:14:42 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-ZfZiJODjXA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69643|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:14:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:14:48 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-d6ze7KtCOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69644|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:14:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:14:55 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-FniFynCMFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69645|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:15:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:15:02 +0000
Subject: [Koha-bugs] [Bug 19802] New: Move Selenium code to its own module
Message-ID: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

            Bug ID: 19802
           Summary: Move Selenium code to its own module
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

To make it reusable easily

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:15:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:15:38 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-jWMJ4CaSGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69754&action=edit
Bug 19784: Remove reference to 'borrowernumber' param from other endpoints

This patch removes the $ref occurences for borrowernumber in not
patron-specific endpoints. 'borrowernumber' is still used on them, but as a
hardcoded parameter. The param rename will happen on a separate bug for
each endpoint.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:15:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:15:46 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-yEFfNzl0Or@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69755&action=edit
Bug 19784: Adapt /v1/patrons to new naming guidelines

This patch introduces two functions to the patrons endpoint:
- _to_api
- _to_model

This are in charge of field mappings in order to comply with the
guidelines.

Koha::REST::V1:Auth is adjusted to handle 'patron_id' as well.

To test:
- Apply the patches
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:15:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:15:30 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-qbsddEYgaW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69753&action=edit
Bug 19784: Unit tests for /api/v1/patrons

This patch adapts the existing endpoint's tests so they expect:
- 'patron_id' for 'borrowernumber'
- 'library_id' for 'branchcode'
- 'category_id' for 'categorycode'

In the process, I tried to make the tests more robust, by creating random
data that gets deleted to make sure our tests cases can't have false
positives.

Independent subtests are wrapped inside transactions to avoid
eventual interference.

To test:
- Apply the patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: The api doesn't implement the expected behaviour and attributes
for endpoint responses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:16:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:16:49 +0000
Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module
In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19802-70-1hl7IrqOZN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:16:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:16:53 +0000
Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module
In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19802-70-SdbQlzPOQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69756&action=edit
Bug 19802: Move Selenium code to t::lib::Selenium

To make it reusable easily.

Test plan:
The basic_workflow.t tests should still pass after this change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:17:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:17:38 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-61GelQUcWX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19802


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802
[Bug 19802] Move Selenium code to its own module
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:17:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:17:38 +0000
Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module
In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19802-70-cKcYdyudNH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19243


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:18:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:18:29 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-yGTyhlt0sk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68123|0                           |1
        is obsolete|                            |
  Attachment #68124|0                           |1
        is obsolete|                            |
  Attachment #68125|0                           |1
        is obsolete|                            |
  Attachment #68832|0                           |1
        is obsolete|                            |
  Attachment #68833|0                           |1
        is obsolete|                            |

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69757&action=edit
Bug 19243: Add selenium tests for the administration module

This is just a start.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 12 23:22:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 12 Dec 2017 22:22:29 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-Nxb57oTOh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Alex,

I have tried to make your work moving forward in order to unlock all the other
bug reports linked to this one.

I would like you to take a look at the changes I made on bug 19802 and this
one.
Basically I have refactored the existing code and added new methods to help us
in writing selenium tests easily.
You will notice that I did not need to change Koha code (which is wanted).

This patch does not contain all the tests you wrote previously, it would be
good to know if you manage to rewrite them easily without impacting Koha
template code.

Let me know if you face any difficulties or if you have questions.

Cheers,
Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 01:45:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 00:45:15 +0000
Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on
 record by pickup library and/ or itemtype
In-Reply-To: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19469-70-XYHcHMX0d2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 03:18:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 02:18:40 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-B6QGSr8xTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 03:18:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 02:18:43 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-cysgd9XI2s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 69758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69758&action=edit
Bug 19801 - Display messages on user details page as well as on Check Out page

To test:

Look up a borrower, add a message (internal or opac)
Click the Details tab for that borrower
Messages should be displayed above the user information [is this the right
place? it could go below]
adding messages on this page should make them immediately available
deleting messages on this page should delete them immediately and bring you
back to the detail page.

Basically, make sure messages work from both the Check out and detail pages and
that there are no typos.

Messages should work the same as they always have from the Check Out page.

sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 03:23:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 02:23:09 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-pSfWM6wQCF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #5 from Liz Rea <liz at catalyst.net.nz> ---
Adding the ability to batch modify a bunch of borrowers email fields to null
might be useful, can see how that might be nice for librarians.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 03:23:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 02:23:48 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-dg55asIFzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #6 from Liz Rea <liz at catalyst.net.nz> ---
But I don't see much utility in allowing librarians to batch set a whole bunch
of borrowers emails to the same thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 03:59:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 02:59:32 +0000
Subject: [Koha-bugs] [Bug 19756] Strange upgrade message from
	updatedatabase.pl
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-CVmoZik5NC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
That will be some problem encoding the macrons in the update text.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 04:03:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 03:03:13 +0000
Subject: [Koha-bugs] [Bug 19731] Notify when you add new item with
	reservations
In-Reply-To: <bug-19731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19731-70-cICqnQ4vNq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19731

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Hi Patrick,

As a cheap and easy work around, you can return every item you add to see if it
triggers holds. This is how most libraries determine if a newly added item is
on reserve.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 07:16:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 06:16:34 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-FiFgsgOC58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Setting to the same might be interesting for testing, even if a rare case. I
agree emptying out would make sense in some cases. 

Thx for being patient with me :) It's often interesting to learn why people
want/need a thing and sometimes it helps to come up with an even better
solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 07:44:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 06:44:12 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-6MZUM7bGem@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

--- Comment #106 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69759&action=edit
Bug 18606: (followup) Make QA tools happy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 07:48:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 06:48:38 +0000
Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to
	Koha::Object
In-Reply-To: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18606-70-Dt8oSbukRF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #107 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Owen Leonard from comment #105)
> Testing functionality goes without any problem, but running "prove
> t/db_dependent/Koha/Items.t t/db_dependent/Circu lation.t" gave this result:
> 
> t/db_dependent/Circulation.t (Wstat: 65280 Tests: 42 Failed: 1)
>   Failed test:  41
>   Non-zero exit status: 255
>   Parse errors: Bad plan.  You planned 112 tests but ran 42.
> 
> Also, running the QA tool highlighted some issues.

Thanks for testing!

I added a followup, test are passing now and QA tools return just one "warning"
about pod coverage on Koha/RotatingCollection/Tracking.pm, but that is new file
with no added methods, so there is nothing more to add to pod IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 07:54:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 06:54:59 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-E7DaIokcX8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69747|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69760&action=edit
Bug 19767: serial-issues.pl is unused and should be removed

This patch removes three unused files:

serials/serial-issues.pl

...and its associated templates:

koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt

To test, apply the patch and search the Koha codebase for references to
any of those files. None should exist.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 07:55:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 06:55:35 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-NozCylUx7Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |josef.moravec at gmail.com

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Removing dead code is always good ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 08:34:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 07:34:39 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-cCS7LrZS34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 08:34:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 07:34:43 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-3s2yCYiF24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69708|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69761&action=edit
Bug 19593 Basketcount correction on Bookseller.pm

To test:
1/ go to /cgi-bin/koha/acqui/booksellers.pl or
/cgi-bin/koha/acqui/supplier.pl
2/ Note that it displays the delete vendor button instead of the
receive shipments button
3/ Apply patch
4/ Reload the page and notice the button is fixed

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 08:36:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 07:36:00 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-c0hzCEYUbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tested:
- vendor with no orders and subscriptions (button)
- vendor with orders (no button)
- vendor with subscriptions (no button)

Just noticed something, author line reads:
Author: KohaR2 <koha at listes.uhb.fr>

Gwendal, do you want us to adjust that to your name and personal email?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:30:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:30:32 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-KrNFlvCzbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69546|0                           |1
        is obsolete|                            |

--- Comment #68 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69762&action=edit
Bug 16330: REST API: add routes to add, update and delete patrons

This patch adds support for add, edit and delete patrons via REST API.

GET  /api/v1/patrons                   Get patron list from params
GET  /api/v1/patrons/<borrowernumber>  Get single patron
POST /api/v1/patrons                   Create a new patron
PUT  /api/v1/patrons/<borrowernumber>  Update data about patron
DEL  /api/v1/patrons/<borrowernumber>  Delete a patron

Revised Test plan:
1) Apply this patch
2) Run tests perl t/db_dependent/api/v1/patrons.t
3) Add a user with proper rights to use the REST API
4) play with your favourite REST client (curl/httpie, etc.):
   Authenticate with the user created above and get a CGISESSION id.
   Use the CGISESSION to add, edit and delete patrons via the API.
5) Use PUT /patrons/<borrowernumber> for a patron without borrowers
   flag. This should go into pending patron modification status and
   needs to be accepted by a librarian.

Please note there is no validation of body input in PUT/POST other
than branchcode,category,userid,cardnumber.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:30:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:30:39 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-VbIwyYeCpL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69547|0                           |1
        is obsolete|                            |

--- Comment #69 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69763&action=edit
Bug 16330: Spot unchanged modification-request in Koha::Patron::Modification

Throw Koha::Exceptions::NoChanges if attempting to create a modification
request
without changing anything.

This exception is caught in Patron REST API controller.

Also, validate changes via Koha::Patron->_validate

To test:
1. prove t/db_dependent/Koha/Patron/Modifications.t

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:30:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:30:48 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-TDP3NbwkK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69548|0                           |1
        is obsolete|                            |

--- Comment #70 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69764&action=edit
Bug 16330: Move patches to OpenAPI

This patch refactors the original work so it implements the controllers
and the spec using Mojolicious::Plugin::OpenAPI, and OpenAPI for the
specification.

It removes the ability for patrons without permissions to edit their own data
or their
guarantee's. This will be moved to a patron modification requests endpoint for
simplicity.

It makes use of bugs 19410 and 19686 and their dependencies to deal with
parameters handling,
query building and pagination.

Tests are adapted.

To test:
- Apply this patches and the dependencies
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:30:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:30:56 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-VuXdIOgvmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69549|0                           |1
        is obsolete|                            |

--- Comment #71 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69765&action=edit
Bug 16330: (QA followup) fix spelling in comment

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:31:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:31:04 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-iRfxp8Rn8P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69550|0                           |1
        is obsolete|                            |

--- Comment #72 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69766&action=edit
Bug 16330: (QA followup) Add missing POD for exceptions

This patch adds POD to the exceptions files introduced by this patchset.

Note: the qa scripts give false positives on Exceptions. But the patchset
was missing them anyway.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:31:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:31:10 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-x0D5wBU4f6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69551|0                           |1
        is obsolete|                            |

--- Comment #73 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69767&action=edit
Bug 16330: (QA followup) Repect guidelines on plurals Patron > Patrons

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:31:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:31:18 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-5NiNmP1tuq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69752|0                           |1
        is obsolete|                            |

--- Comment #74 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 69768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69768&action=edit
Bug 16330: (QA follow-up) ModMember requires borrowernumber

This patch fixes the tests so they highlight the fact that:
- PUT only worked on the tests because borrowernumber was passed on them
- ModMember expects borrowernumber on the hash it gets passed.

It also fixes the issue.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 09:32:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 08:32:38 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-CEZvxZrjvZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #75 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Works as expected. Tests pass, API responds appropriately.
Great work Tomas and Lari!
A good step forward on the REST api

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 10:02:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 09:02:54 +0000
Subject: [Koha-bugs] [Bug 19803] New: SQL report export can fail HTTP 414
 Request-URI Too Large
Message-ID: <bug-19803-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19803

            Bug ID: 19803
           Summary: SQL report export can fail HTTP 414 Request-URI Too
                    Large
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

After running a saved SQL report, one can download result into a file.

This uses a link with the SQL query as URL argument.
If this query is really big, the download may fail with HTTP 414 "Request-URI
Too Large".

This link should use the report id to retrieve SQL query.
There is a comment asking this in reports/guided_reports.pl :
  my $sql = $input->param('sql');  # FIXME: use sql from saved report ID#, not
new user-supplied SQL!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 10:10:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 09:10:13 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-Rtmz7QRyin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Gwendal JONCOUR <gwendal.joncour at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69761|0                           |1
        is obsolete|                            |

--- Comment #7 from Gwendal JONCOUR <gwendal.joncour at univ-rennes2.fr> ---
Created attachment 69769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69769&action=edit
Bug 19593 Basketcount correction on Bookseller.pm

Arf, default user/email on our preprod server. Here's the corrected version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 10:15:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 09:15:44 +0000
Subject: [Koha-bugs] [Bug 19804] New: Suspension calcultation doesn't honour
 ' Fine charging interval'
Message-ID: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

            Bug ID: 19804
           Summary: Suspension calcultation doesn't honour 'Fine charging
                    interval'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hagud at orex.es
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When a user is returning an item with overudue, the suspension is calculated in
days according 'suspensions in day' it doesn't calculate the 'Fine charging
interval' that I guess is used for ? fines, but doesn't apply to suspensions in
day.

Not all libraries has a relation > 1 to days and suspensions, for example now
it is not possible to define 7 days of suspension for every 14.

It should be nice if Koha also consider the 'Fine charging interval' for
suspensions in days and library could decide to change the suspension, every 1,
2 ... days

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 11:29:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 10:29:32 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-1o8RcVEbRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 11:29:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 10:29:35 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-j0DUdtLxMy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69740|0                           |1
        is obsolete|                            |

--- Comment #4 from Claire Gravely <claire_gravely at hotmail.com> ---
Created attachment 69770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69770&action=edit
Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Revised: My original patch included changes to batchMod-edit.tt but
didn't take into account the MARC plugins which are loaded in the item
edit form. I have discarded those changes for now.

Tools -> Batch record modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit records for deletion
    - Page highlighting in the sidebar
    - Checkbox selection links
    - Warning when no records selected
    - Patron autocomplete in the "Check out" tab
Tools -> Batch item modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
Tools -> Batch item deletion
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit items for deletion
    - Patron autocomplete in the "Check out" tab
    - Checkbox selection links
    - Column-hiding checkboxes
    - Datatables
Tools -> Batch record modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit records for modification
      - Page highlighting in the sidebar
      - Patron autocomplete in the "Check out" tab
      - Checkbox selection links
      - Datatables
      - MARC preview
      - Warning when no records selected
      - Progress bar after submitting items for modification

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 11:56:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 10:56:22 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-qvmeDzDLEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 11:56:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 10:56:38 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-HDfvnKlxOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69603|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69771&action=edit
Bug 19663: Move JS to the footer: Reports

This patch modifies the staff client's reports templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
reports pages: All button controls, DataTables functionality, form
validation, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Fix for QA: Remove unused Dopop function.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 11:59:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 10:59:45 +0000
Subject: [Koha-bugs] [Bug 19803] SQL report export can fail HTTP 414
 Request-URI Too Large
In-Reply-To: <bug-19803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19803-70-JIBvxUIn7A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19803

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 12:02:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 11:02:25 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-t3qV6CmeA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 12:02:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 11:02:29 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-mljpThz4Yb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69630|0                           |1
        is obsolete|                            |
  Attachment #69631|0                           |1
        is obsolete|                            |

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69772&action=edit
Bug 19627: Move patron clubs templates JS to the footer

This patch modifies the staff client's patron clubs templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 12:02:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 11:02:33 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-9kK3KxolPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69773&action=edit
Bug 19627: Follow-up: Include tools-menu.js on required templates

This follow-up adds tools-menu.js to the two patron clubs templates
which include the tools sidebar menu.

The patch also modifies tools-menu.js so that the correct sidebar link
is highlighted when editing or viewing club enrollments.

To test, apply the patch and view the patron clubs main page and the
patron clubs enrollments page. The sidebar menu should have the correct
link highlighted in both cases.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 12:40:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 11:40:36 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-M7WJJpmNs8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69770|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69774&action=edit
Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools

This patch modifies the staff client patron lists templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

Revised: My original patch included changes to batchMod-edit.tt but
didn't take into account the MARC plugins which are loaded in the item
edit form. I have discarded those changes for now.

Tools -> Batch record modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit records for deletion
    - Page highlighting in the sidebar
    - Checkbox selection links
    - Warning when no records selected
    - Patron autocomplete in the "Check out" tab
Tools -> Batch item modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
Tools -> Batch item deletion
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit items for deletion
    - Patron autocomplete in the "Check out" tab
    - Checkbox selection links
    - Column-hiding checkboxes
    - Datatables
Tools -> Batch record modification
  - Page highlighting in the sidebar
  - Patron autocomplete in the "Check out" tab
  - Submit records for modification
      - Page highlighting in the sidebar
      - Patron autocomplete in the "Check out" tab
      - Checkbox selection links
      - Datatables
      - MARC preview
      - Warning when no records selected
      - Progress bar after submitting items for modification

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 12:40:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 11:40:33 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-9GLYKbBqcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 12:48:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 11:48:20 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-KNaztFLBzu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69736|0                           |1
        is obsolete|                            |

--- Comment #27 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69775&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 12:48:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 11:48:17 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-WaaStounPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 13:30:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 12:30:27 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-Qz8eMP8Dkq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 13:30:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 12:30:41 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-RH6DkjDFBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 13:30:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 12:30:29 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-CfETFoy7pb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69733|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69776&action=edit
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Edit: Rebased on Bug 19560

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 13:38:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 12:38:23 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-QZInpGf4pX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What do we do if output_pref is called with dateformat => rfc3339 and dateonly
=> 1?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 14:38:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 13:38:45 +0000
Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP
 authentication failure mode
In-Reply-To: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18947-70-snbo42M1kv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69777&action=edit
Bug 18947 - LDAP: do not assume anonymous bind if no user or password

To test:
Ideally tested on a working ldap server with bind by auth and no
anonymous bind
1  - Define an LDAP config with bind by auth
2  - Don't define user/pass
3  - Define anonymous_bind = 0
4  - Attempt bind by auth
5  - Error is something like:
LDAP search failed to return object : XXXXXXXXX: LdapErr: XXXX-XXXXXX,
     comment: In order to perform this operation a successful bind must
     be completed on the connection., data 0, v2580 at
     /usr/share/koha/lib/C4/Auth_with_ldap.pm line 102.
6  - Define user/pass
7  - Now bind by auth should work
8  - remove user/pass
9  - Apply patch
10 - Attempt again
11 - Bind by auth shoudl succeed

prove -v t/db_dependent/Auth_with_ldap.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 14:38:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 13:38:42 +0000
Subject: [Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP
 authentication failure mode
In-Reply-To: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18947-70-JPudyKX4uh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 15:16:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 14:16:50 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-grq3RMktnI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 15:56:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 14:56:31 +0000
Subject: [Koha-bugs] [Bug 17015] New Koha Calendar
In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17015-70-gN4FvOROsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #117 from David Bourgault <david.bourgault at inlibro.com> ---
I'm very confident in my rebase, considering the corrections were pretty minor.

Patch still applies on master, QA tool still green.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 16:45:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 15:45:03 +0000
Subject: [Koha-bugs] [Bug 19805] New: Add DataTables to Koha to MARC mapping
	page
Message-ID: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

            Bug ID: 19805
           Summary: Add DataTables to Koha to MARC mapping page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/admin/koha2marclinks.pl
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I think it would be useful to have sorting and filtering on the Koha to MARC
mapping table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 16:45:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 15:45:23 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-a2ZC1SfIVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 16:45:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 15:45:25 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-XRMPrgE12u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69052|0                           |1
        is obsolete|                            |
  Attachment #69054|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69778&action=edit
Bug 19599: Execute 1 query per patron

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 16:47:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 15:47:25 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-YxFcL9fRmx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #3)
> Nick, can you compare these 2 approaches please?
> They are not dependent on each others.

The first approach is much faster on a large dataset. The second can generate a
very long query, I think one per patron works best.

Signed off and obsoleted second patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 16:52:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 15:52:19 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-sHGEjvMVI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 16:52:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 15:52:21 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-MPoLAmcfl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69779&action=edit
Bug 19805: Add DataTables to Koha to MARC mapping page

This patch adds sorting and filtering to the Koha to MARC mapping table
using DataTables.

Also changed: Font awesome icons on "Add" and "Remove" buttons; Minor
markup correction to breadcrumbs.

To test, apply the patch and go to Administration -> Koha to MARC
mapping.

- Table should be sorted by default on Koha field.
- Sorting and filtering should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:00:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:00:52 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-eS4czjb1oG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:30:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:30:48 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-2vQwDqc3yk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|LATER                       |---
             Status|RESOLVED                    |REOPENED
            Version|master                      |16.11

--- Comment #10 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Hi,

I repeat this problem on 16.11

Test plan:

- in notice HOLD (/tools/letter.pl), write text in Print tab, save
- check in table message_transports that line for HOLD are present (select *
from message_transports)
- in notice HOLD, supress text in Print tab, save
- check in table message_transport that lines for HOLD are missing and in
Patron messaging Preferences, there is a "-" where check box should appear

Regards
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:39:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:39:01 +0000
Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19474-70-xw20ZDQjkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:39:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:39:10 +0000
Subject: [Koha-bugs] [Bug 19789] Remove some indirect DBIx calls from
	updatedatabase
In-Reply-To: <bug-19789-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19789-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19789-70-pbKuKbbxrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:39:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:39:21 +0000
Subject: [Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block
 should be outside of the main <div>
In-Reply-To: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19411-70-yeoLLRooA8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69780&action=edit
Screenshot of correctly-placed OPAC credits on advanced search page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:39:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:39:45 +0000
Subject: [Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block
 should be outside of the main <div>
In-Reply-To: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19411-70-t5hupRhFMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69781&action=edit
Screenshot of correctly-placed OPAC credits on lists page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:40:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:40:09 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-PSU6RW7p2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Marjorie, the problem is we could never figure out why this happens - we
have about 20 'identical' installations with Koha, but it only happend to us
once or twice when updating. I'd recommend running the fix in comment#7 for
now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:40:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:40:16 +0000
Subject: [Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block
 should be outside of the main <div>
In-Reply-To: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19411-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19411-70-JrnqyP0Nob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
I still cannot reproduce this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:54:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:54:17 +0000
Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents
In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18975-70-83aINDuqMU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:54:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:54:50 +0000
Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents
In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18975-70-ir5Mi9uPYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 17:58:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 16:58:57 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-1hq26W5Wgu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #11)
> What do we do if output_pref is called with dateformat => rfc3339 and
> dateonly => 1?

Raise an exception because RFC doesn't cover that use case?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 18:13:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 17:13:58 +0000
Subject: [Koha-bugs] [Bug 19736] Add a digest option for AUTO_RENEWALS Notice
In-Reply-To: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19736-70-y4z8nXgeUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19736

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.05                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 18:40:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 17:40:07 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
	preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-3NQr7jGxLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |karen at bywatersolutions.com

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 19736 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 18:40:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 17:40:07 +0000
Subject: [Koha-bugs] [Bug 19736] Add a digest option for AUTO_RENEWALS Notice
In-Reply-To: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19736-70-dlmPfVVPkS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19736

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 18532 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 18:44:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 17:44:40 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-PnK3gdcHYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 20:15:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 19:15:13 +0000
Subject: [Koha-bugs] [Bug 19806] New: Add class to items.itemnotes_nonpublic
Message-ID: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

            Bug ID: 19806
           Summary: Add class to items.itemnotes_nonpublic
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Bug 13024 - Nonpublic note not appearing in the staff client added the
nonpublic note to the 
1) Checkouts (circulation.pl)
2) Checkins (returns.pl)
3) Record details ( moredetail.pl )

There is currently no class to hide on of those locations if a library wants to
hide a non public note. Can we add a class to items.itemnotes_nonpublic so
libraries have the choice to hide one of the locations listed above.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 20:35:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 19:35:51 +0000
Subject: [Koha-bugs] [Bug 19807] New: IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
Message-ID: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

            Bug ID: 19807
           Summary: IntranetCatalogSearchPulldown doesn't honor
                    IntranetNumbersPreferPhrase
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

With IntranetCatalogSearchPulldown and IntranetNumbersPreferPhrase enabled.

Doing a search in the intranet from the search pulldown for the call number
searches "callnum,wrdl: foobar".

But it should search "callnum,phr: foobar"

=== Going further ===

It's very likely to also affect the OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 20:55:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 19:55:43 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-SGZUZay0uM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

--- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 69782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69782&action=edit
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase

This patch
- fixes callnum and sn
- Removes unecessary syspref transmission to the template.
  As the template directly reads the syspref

Test plan:
1. Set sysprefs IntranetCatalogSearchPulldown and
   IntranetNumbersPreferPhrase to true
2. Go to staff:/cgi-bin/koha/catalogue/search.pl
3. "search for" ? "call number" and write anything that won't match a
   call number in the field
4. Then you should see
   ?No results match your search for 'callnum,phr: [...]?
5. Go to the staff homepage
6. Click on "Search the catalog"
7. Do the same search as previouly
8. Then you should see
   ?No results match your search for 'callnum,wrdl: [...]?
   This shows that IntranetNumbersPreferPhrase isn't honored
9. Apply this patch
10. Redo the same two searches and see that phr will now be always used.
    So IntranetNumbersPreferPhrase is honored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 20:56:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 19:56:14 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-VP87HHqxcw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |victor.grousset at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 21:30:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 20:30:54 +0000
Subject: [Koha-bugs] [Bug 19808] New: Data corruption causing an Internal
 Server Error when seeing a record' s details. Which have reviews from
 deleted borrowers.
Message-ID: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

            Bug ID: 19808
           Summary: Data corruption causing an Internal Server Error when
                    seeing a record's details. Which have reviews from
                    deleted borrowers.
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Found by Joubu.

===== Cause =====
plack-error.log:
> Can't call method "title" on an undefined value at /home/koha/src/opac/opac-detail.pl line 847.

code:
> # setting some borrower info into this hash
> $review->{title}     = $patron->title;

db:
> CONSTRAINT `reviews_ibfk_1`
> FOREIGN KEY (`borrowernumber`)
> REFERENCES `borrowers` (`borrowernumber`)
> ON DELETE SET NULL ON UPDATE CASCADE,

The reviews are kept even if the user was deleted

BZ 15839 is suspected to have introduced this bug.

===== Fix =====
The first step is to fix the 500 error.
And then study the relevance of "on delete set null".
And take care of the existing data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 21:32:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 20:32:35 +0000
Subject: [Koha-bugs] [Bug 19808] Data corruption causing an Internal Server
 Error when seeing a record' s details. Which have reviews from deleted
 borrowers.
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-Dk5GEWKA5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|oleonard at myacpl.org         |victor.grousset at biblibre.co
                   |                            |m
             Status|NEW                         |ASSIGNED

--- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
@Joubu: Is everything correct?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 21:40:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 20:40:09 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-NSp7IqK2au@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 21:43:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 20:43:39 +0000
Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple
 holds on the same item
In-Reply-To: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19718-70-CXYyqCoWOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liz at catalyst.net.nz

--- Comment #2 from Liz Rea <liz at catalyst.net.nz> ---
So maybe what you'd like is the ability to allow multiple holds per branch or
per user category, so that if someone else had allowed multiple holds, you
wouldn't be required to?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:06:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:06:14 +0000
Subject: [Koha-bugs] [Bug 19804] Suspension calcultation doesn't honour
 'Fine charging interval '
In-Reply-To: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19804-70-cpgz9ohBq8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:06:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:06:17 +0000
Subject: [Koha-bugs] [Bug 19804] Suspension calcultation doesn't honour
 'Fine charging interval '
In-Reply-To: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19804-70-IPbc7UkJEi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69783&action=edit
Bug 19804: Add new DB column issuingrules.suspension_chargeperiod

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:06:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:06:21 +0000
Subject: [Koha-bugs] [Bug 19804] Suspension calcultation doesn't honour
 'Fine charging interval '
In-Reply-To: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19804-70-cLXY06BTOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69784&action=edit
Bug 19804: DBIC Schema changes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:06:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:06:24 +0000
Subject: [Koha-bugs] [Bug 19804] Suspension calcultation doesn't honour
 'Fine charging interval '
In-Reply-To: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19804-70-tKPKd0qajA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69785&action=edit
Bug 19804: Add a 'Fine charging interval' for suspension days

We already have a chargeperiod (Fine charging interval) value which is
taken into account for fine ($) for not for the suspension period.

This patch adds a new column suspension_chargeperiod (Fine day charging
interval) to add the same behaviour when a suspension is calculated.

Test plan:
Add overdue item and play with the circulation rules (and the calendar).
The suspension period must be correctly calculated.
Please provide the different tests you made.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:06:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:06:28 +0000
Subject: [Koha-bugs] [Bug 19804] Suspension calcultation doesn't honour
 'Fine charging interval '
In-Reply-To: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19804-70-XtkcvKounT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69786&action=edit
Bug 19804: Add the new column to the circ rules interface

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:07:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:07:36 +0000
Subject: [Koha-bugs] [Bug 19808] Data corruption causing an Internal Server
 Error when seeing a record' s details. Which have reviews from deleted
 borrowers.
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-yi9oQXAj4c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:07:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:07:25 +0000
Subject: [Koha-bugs] [Bug 19808] Data corruption causing an Internal Server
 Error when seeing a record' s details. Which have reviews from deleted
 borrowers.
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-aKMCdI06HJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Victor Grousset/tuxayo from comment #1)
> @Joubu: Is everything correct?

Yep, we will only take care of the existing data if we decide to remove the
reviews from deleted patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 22:09:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 21:09:45 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explodes
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-UksYECGWlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Data corruption causing an  |Reviews from deleted
                   |Internal Server Error when  |patrons make opac-detail
                   |seeing a record's details.  |explodes
                   |Which have reviews from     |
                   |deleted borrowers.          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 23:22:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 22:22:20 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-5F1uD39Imf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Jason Palmer <jpalmer at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jpalmer at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 23:22:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 22:22:46 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-pI5LP7Hf3I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Jason Palmer <jpalmer at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 13 23:22:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 22:22:46 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-zFf6iCt9wW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Jason Palmer <jpalmer at switchinc.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jschmidt at switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 00:54:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 23:54:03 +0000
Subject: [Koha-bugs] [Bug 12093] Add css classes to item statuses in detail
	view
In-Reply-To: <bug-12093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12093-70-wnsGnHsisX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 00:55:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 23:55:56 +0000
Subject: [Koha-bugs] [Bug 15122] Allow styling the Items available for loan
 -list in OPAC search results
In-Reply-To: <bug-15122-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15122-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15122-70-DMt1FXU87D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15122

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 00:56:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 13 Dec 2017 23:56:13 +0000
Subject: [Koha-bugs] [Bug 15949] Making certain alerts stand out
In-Reply-To: <bug-15949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15949-70-60F88W7Nn1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15949

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 05:23:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 04:23:55 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-BkERgyBGvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #76 from Dilan Johnpull? <dilan at calyx.net.au> ---
Can confirm. Works as expected now in line with test plans.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 06:12:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 05:12:01 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-5MEoHoyK7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69768|0                           |1
        is obsolete|                            |

--- Comment #77 from Dilan Johnpull? <dilan at calyx.net.au> ---
Created attachment 69787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69787&action=edit
Bug 16330: (QA follow-up) ModMember requires borrowernumber

Works perfectly. Well done everyone!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 06:24:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 05:24:56 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-aX89AueSNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Dilan Johnpull? <dilan at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dilan at calyx.net.au

--- Comment #10 from Dilan Johnpull? <dilan at calyx.net.au> ---
Attempted to sign off in devbox but test failed in kshell with the following:

t/db_dependent/api/v1/patrons.t .. 1/5 DBD::mysql::st execute failed: Cannot
add or update a child row: a foreign key constraint fails
(`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN
KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON
UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`,
`debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues:
0=5841405127227230000000.000000, 1='1', 2='Manual Debit'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.

        #   Failed test 'Patron created successfully'
        #   at t/db_dependent/api/v1/patrons.t line 210.
        #          got: '500'
        #     expected: '201'

        #   Failed test 'got a patron_id'
        #   at t/db_dependent/api/v1/patrons.t line 210.

        #   Failed test 'exact match for JSON Pointer "/cardnumber"'
        #   at t/db_dependent/api/v1/patrons.t line 210.
        #          got: undef
        #     expected: 'av0WRHT1xJdZ1JDtAZ2'

        #   Failed test 'exact match for JSON Pointer "/surname"'
        #   at t/db_dependent/api/v1/patrons.t line 210.
        #          got: undef
        #     expected: 'iC24_uBTgv'

        #   Failed test 'exact match for JSON Pointer "/firstname"'
        #   at t/db_dependent/api/v1/patrons.t line 210.
        #          got: undef
        #     expected: 'sIxTOBcMXz'
        # Looks like you failed 5 tests of 18.

    #   Failed test 'librarian access tests'
    #   at t/db_dependent/api/v1/patrons.t line 224.
    # Looks like you failed 1 test of 2.
t/db_dependent/api/v1/patrons.t .. 3/5 
#   Failed test 'add() tests'
#   at t/db_dependent/api/v1/patrons.t line 225.
t/db_dependent/api/v1/patrons.t .. 5/5 # Looks like you failed 1 test of 5.
t/db_dependent/api/v1/patrons.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests 

Test Summary Report
-------------------
t/db_dependent/api/v1/patrons.t (Wstat: 256 Tests: 5 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1
Files=1, Tests=5,  5 wallclock secs ( 0.03 usr  0.02 sys +  3.20 cusr  0.86
csys =  4.11 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:30:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:30:59 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-tvPoAJ8sOp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:32:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:32:48 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-klyH5Cbht2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |josef.moravec at gmail.com

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
The item  types translation popup dialog does not work for me - it opens when I
click "Translate into other languages" but then I am redirected straight to
localization.pl as if would click on normal link... look like going to href on
that anchor is not prevented... I tried it in firefox 57 and chromium 62

Also on clone rules page the "Circulation and fines rules" menu item should be
styled in bold.

Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:37:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:37:46 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-K3OTjc5pOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:37:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:37:56 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-9XKfb7KQun@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:38:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:38:29 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-aqhuJLd6Bl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:58:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:58:28 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-FBxSMnDZFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:58:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:58:30 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-FS6CAWXlkU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69604|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69788&action=edit
Bug 19758: Move template JavaScript to the footer: Serials, part 1

This patch modifies some staff client serials templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Serials -> New subscription
  - Search for a vendor
    - "Choose" link and "Cancel" button should work correctly
  - Search for record
    - "Choose" link and "Cancel" button should word correctly
- Serials -> Add subscription fields
  - Datatable, delete confirmation
  - Edit
    - Form validation (submit both authorised value and MARC field)
- Serials -> Check expiration
  - Date picker in search form
  - Search
    - Renew button triggers popup
- Serials -> Claims -> Search results
  - Date picker, datatable, form validation
  - Select all/none; Download claims

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 08:58:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 07:58:47 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-xHIL8etSxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:03:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:03:17 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-nEFBzjDnmn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:03:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:03:20 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-sLHplUqNgD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69639|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69789&action=edit
Bug 19761: Move template JavaScript to the footer: Serials, part 2

This patch modifies more staff client serials templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials -> Subscription detail -> Edit routing list
   - Add recipients
   - Save
     - "Save and preview routing slip" should trigger preview
       - In preview popup: Print and Close buttons should work correctly

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:03:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:03:33 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-uPZLEM3GdV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:18:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:18:38 +0000
Subject: [Koha-bugs] [Bug 19809] New: Koha::Objects:: find calls do not need
 to be forbidden in list context
Message-ID: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

            Bug ID: 19809
           Summary: Koha::Objects::find calls do not need to be forbidden
                    in list context
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 18539

Bug 18539 forbade to call Koha::Objects::find in list context.
This is not necessary, we can fix the subroutine so that it can be called in
scalar and list contexts without problems.

See also discussion on ML:
http://lists.koha-community.org/pipermail/koha-devel/2017-December/044213.html


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539
[Bug 18539] Forbid Koha::Objects->find calls in list context
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:18:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:18:38 +0000
Subject: [Koha-bugs] [Bug 18539] Forbid Koha::Objects->find calls in list
	context
In-Reply-To: <bug-18539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18539-70-VDjgSyFa4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19809


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809
[Bug 19809] Koha::Objects::find calls do not need to be forbidden in list
context
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:22:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:22:42 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects:: find calls do not need to
 be forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-4eUBlTZxJb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69790&action=edit
Bug 19809: Re-allow to call Koha::Objects::find in list context

and remove 'scalar' keyword in calls where it's not needed.
Also, fix Koha::Patron::guarantor which had the same problem as find

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:25:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:25:38 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-SHpcYL2Viz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Reviews from deleted        |Reviews from deleted
                   |patrons make opac-detail    |patrons make opac-detail
                   |explodes                    |explode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:35:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:35:49 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-GiO5pdB2X8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:35:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:35:51 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-5uc1gQoULg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69682|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69791&action=edit
Bug 19777: Move template JavaScript to the footer: Serials, part 3

This patch modifies even more staff client serials templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JavaScript include, serials-toolbar.js, which is
required on pages which include serials-toolbar.inc.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials
   - Search for a subscription
     - Tabs, datatables, date pickers
     - Open a subscription for viewing
       - Tabs, toolbar buttons for delete, renew, and close.
   - Serial collection (in the sidebar menu)
     - Select all / clear all
     - Datatable
     - Print slip
     - Generate next

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:36:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:36:00 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-chKXYYhUse@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 09:38:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 08:38:05 +0000
Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS
In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19474-70-3fUz5IRAm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

Claire Gravely <claire_gravely at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire_gravely at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:03:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:03:45 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-v8pRnVDcAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:03:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:03:47 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-lMPANHdssM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69663|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69792&action=edit
Bug 19778: Move template JavaScript to the footer: Serials, part 4

This patch modifies more and more staff client serials templates so
that JavaScript is included in the footer instead of the header.

This patch adds a new JavaScript include, showpredictionpattern.js,
which is used by subscription-add.tt and subscription-numberpatterns.tt.
it also adds subscription-add.js, moving most of the JS embedded in
subscription-add.tt into an external file.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

 - Serials -> New subscription
   - Date pickers
   - Popup search windows for vendors and bibliographic
     records
   - Next / Previous buttons
   - Form validation
   - Prediction pattern operations

   Test with new subscriptions, editing existing subscriptions, and
   duplicating subscriptions.

 - Serials -> Manage Numbering Patterns
   - Datatable
   - Delete confirmation
   -> Edit
      - Datepicker, test pattern
 - Serials -> Manage frequencies
   - Delete confirmation
   -> Edit
      - Form validation
 - Serials -> Subscription details -> Planning tab
   -> Edit history
      -> Datepicker
 - Serials -> Subscription details -> Renew
   - Datepicker

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:03:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:03:57 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-4DZvLz4WCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:23:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:23:00 +0000
Subject: [Koha-bugs] [Bug 19810] New: ILL: 404 error when activating ILL on
 a package installation
Message-ID: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

            Bug ID: 19810
           Summary: ILL: 404 error when activating ILL on a package
                    installation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com,
                    magnus at libriotech.no

When activating ILL on a package installation you receive a 404 error instead
of the more helpful message to check the about page for more information. 

As we have highlighted ILL as a new feature for 17.11 it would be good if this
could be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:37:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:37:55 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-WfN1BXKJci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69779|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69793&action=edit
Bug 19805: Add DataTables to Koha to MARC mapping page

This patch adds sorting and filtering to the Koha to MARC mapping table
using DataTables.

Also changed: Font awesome icons on "Add" and "Remove" buttons; Minor
markup correction to breadcrumbs.

To test, apply the patch and go to Administration -> Koha to MARC
mapping.

- Table should be sorted by default on Koha field.
- Sorting and filtering should work correctly.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:38:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:38:08 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-oGeecACV0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |simon.pouchol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:43:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:43:12 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-4AarGFtsqH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69483|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69794&action=edit
Bug 19744: Move template JavaScript to the footer: Offline circulation

This patch modifies the staff client offline circulation templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Circulation -> Built-in offline circulation interface
  -> Synchronize
   -> Download records
  -> Check out
  -> Check in
    -> Synchronize
      -> Upload transactions
  -> Pending offline circulations
    -> Check all, uncheck all
    -> Delete
    -> Process

Circulation -> Upload offline circulation data
  -> Upload .koc file (gerated by the Koha Offline Circulation program,
     for instance).

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:43:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:43:23 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-mVHQo2qk6K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:57:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:57:24 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-gUEzMhRWYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:58:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:58:07 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-Mk0CiaCU4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69532|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69795&action=edit
Bug 19753: Move template JavaScript to the footer: Acquisitions

This patch modifies some staff client acquisitions templates so that
JavaScript is included in the footer instead of the header.

This patch adds a JavaScript file, acquisitions-menu.js, which controls
the highlighting of the current page in the sidebar. Highlighting will
be temporarily broken for pages which have not been modified to include
this file

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Acquisitions home page
  - Datatable, Inactive budget controls
- Vendor search results
  - Acquisitions -> Vendor search
    - Datatables, "Show all" links
- Basket
  - Acquisitions -> Vendor -> Basket
    - Datatables, button controls, add managing user
- Add to basket from a staged file
  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - Datatables, tabs, selection controls
- Edit basket
  - Acquisitions -> Vendor -> Edit basket
    - Form validation
- EDIFACT messages
  - Acquisitions -> EDIFACT messages
    - Datatables, message preview
- Orders search
  - Acquisitions -> Order search
    - Full orders search form
      - Patron autocomplete in "Basket created by" field
      - Datepickers
    - Orders search results
      - Datatables, column visibility
- Invoices
  - Acquisitions -> Vendor -> Invoices -> Invoice
    - Form validation, datepickers, datatables
  - Invoice files (enable AcqEnableFiles preference)
    - Manage invoice files
      - File list datatable

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:58:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:58:21 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-f7jYQQ61dI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |simon.pouchol at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 10:59:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 09:59:37 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-BywWWE9pXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:00:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:00:47 +0000
Subject: [Koha-bugs] [Bug 11858] RFID for circulation
In-Reply-To: <bug-11858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11858-70-84TXf8DhrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:24:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:24:36 +0000
Subject: [Koha-bugs] [Bug 19590] doc of Clean Patron Records tool wrong
 about deletion scope + anonymization syspref
In-Reply-To: <bug-19590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19590-70-EyZs4zRJyz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19590

--- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
My links to the source code were durable (as master moves).

Here are fixed versions:
[2]
https://github.com/Koha-Community/Koha/blob/6ae69d27815dc01ab515b6d8f0239ef5fe59251/C4/Members.pm#L1040
[3]
https://github.com/Koha-Community/Koha/blob/b4cd5faeb09b4872b5ea413e0aace3ebbaae26c5/tools/cleanborrowers.pl#L142

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:25:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:25:48 +0000
Subject: [Koha-bugs] [Bug 19590] doc of Clean Patron Records tool wrong
 about deletion scope + anonymization syspref
In-Reply-To: <bug-19590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19590-70-1uwXPdevcg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19590

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
erratum

"were durable" ? "were not durable"

...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:38:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:38:39 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-AWFRxNWijS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:38:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:38:42 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-wnBochU7Xj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69208|0                           |1
        is obsolete|                            |

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69796&action=edit
Bug 19514 - Password restrictions implemented into onboarding tool

Test plan:
1. Drop and recreate your database
2. Restart memcached
3. Go through the web installer
4. In the onboarding tool create a patron with a password of only 2 characters
in length
5. Notice the patron is successfully created and no warning message is
displayed
6. Repeat step 1,2,3 and create a patron with a password of 3 characters
none of which are a uppercase letter or number and notice the patron is
successfully created and no warning message is displayed
7. Apply patch
8. Repeat steps 1,2,3 and create a patron with a password consisting of
2 characters, notice that after submitting the form the same form is
loaded again and there is a warning message at the top of the page
informing you the patron wasn't created
9. Repeat steps 1,2,3 and create a patron with a password consisting of
3 characters (all lower case) and submit the form, notice the same form
is reloaded and a warning message at the top of the page informs you
that the patron wasn't created because the password was weak
10. Repeat steps 1,2,3 and create a patron with a password consisting of
3 characters (one lower case letter, one upper case letter and one
number) and submit the form and notice this time the next form in the
onboarding is displayed with the message at the top of the screen informing you
that the patron was successfully created

Sponsored-By: Catalyst IT

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:38:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:38:45 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-mAdThjyHhw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69209|0                           |1
        is obsolete|                            |

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69797&action=edit
Bug 19514: Add client-side check

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:40:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:40:32 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-qqxNdByYQj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:46:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:46:20 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-6nme30H0m6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69758|0                           |1
        is obsolete|                            |

--- Comment #2 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Created attachment 69798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69798&action=edit
Bug 19801 - Display messages on user details page as well as on Check Out page

To test:

Look up a borrower, add a message (internal or opac)
Click the Details tab for that borrower
Messages should be displayed above the user information [is this the right
place? it could go below]
adding messages on this page should make them immediately available
deleting messages on this page should delete them immediately and bring you
back to the detail page.

Basically, make sure messages work from both the Check out and detail pages and
that there are no typos.

Messages should work the same as they always have from the Check Out page.

sponsored-by: Catalyst IT
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 11:46:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 10:46:31 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-SdP8VHHnsy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:06:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:06:24 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-oH6hKKp3PK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

Simon Pouchol <simon.pouchol at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.pouchol at biblibre.com

--- Comment #5 from Simon Pouchol <simon.pouchol at biblibre.com> ---
There seems to be an issue with suggestions from cache (not sure how to call
them, when pressing down arrow or double-clicking on a text input to show
previously used text) on the Z39.50 search form. When double clicking on a text
field, these options immediately hide and have weird behavior overall. Might be
unrelated to this patch ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:21:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:21:14 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-gvu2fxAMwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #23 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 69461
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69461
Bug 18308 - Added step to onboarding tool to set minPasswordLength

Review of attachment 69461:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18308&attachment=69461)
-----------------------------------------------------------------

I would like to see the setting of min password length before creating the
superlibrarian user account, because now you first use the limit a then set the
limit - it is not very logical IMO

::: installer/onboarding.pl
@@ +313,1 @@
>      $template_params->{all_done} = 1;    # If step 5 is complete, we are done!

The comment should be changed too, 5 => 6

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep6.tt
@@ +2,5 @@
> +<title>Koha &rsaquo; Web installer &rsaquo;
> +    [% IF all_done %]
> +        Complete
> +    [% ELSE %]
> +        Create circulation rule

Should be "Set minPasswordLength system preference"

@@ +8,5 @@
> +</title>
> +[% INCLUDE 'installer-doc-head-close.inc' %]
> +[% INCLUDE 'validator-strings.inc' %]
> +[% INCLUDE 'installer-strings.inc' %]
> +<script type="text/javascript" src="[% interface %]/[% theme %]/js/onboarding.js"></script>

Javascript should be at the end - see bug 17418

@@ +14,5 @@
> +
> +<body id="installer" class="installer">
> +    <div class="container-fluid">
> +        <div class="row">
> +            <div id="onboarding-step5" class="installer-main col-sm-8 col-sm-offset-2 col-md-8 col-md-offset-2">

This is actually step6

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:21:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:21:44 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-Mjoe1kxsaO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:21:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:21:55 +0000
Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should
	be increased
In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18308-70-uJ6yDltoLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:28:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:28:45 +0000
Subject: [Koha-bugs] [Bug 19811] New: Preventing runaway processes bringing
	down Koha
Message-ID: <bug-19811-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19811

            Bug ID: 19811
           Summary: Preventing runaway processes bringing down Koha
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: r.delahunty at arts.ac.uk
        QA Contact: testopia at bugs.koha-community.org

We just had a complete Koha outage which we believe was caused by 150+ requests
to /cgi-bin/koha/circ/returns.pl sent simultaneously. Apparently this could
have been caused by someone on the issue desk accidentally pressing the resend
key. Our server support people have to kill the processes, presumably via the
command line. 
It would be very easy to trigger repeated calls to returns.pl (and I guess
other scripts) by accidently resting a book (or whatever) on the edge of the
keyboard, catching the Enter key. Just now I was able to bring down our test
system (both intranet and OPAC) by merely holding down the enter key (using
returns.pl) for maybe a maximum of 5-7 seconds. This a serious vulnerability,
where a momentary lapse of care with a book on a keyboard can crash the Koha
system. 

Ray Delahunty
University of the Arts London

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:42:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:42:43 +0000
Subject: [Koha-bugs] [Bug 18993] Bump libtest-simple-perl to 1.302073
In-Reply-To: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18993-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18993-70-S06LhRZv83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #28 from Nick Clemens <nick at bywatersolutions.com> ---
Skipping for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:42:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:42:44 +0000
Subject: [Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
In-Reply-To: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18055-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18055-70-hmdYMFOXWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055
Bug 18055 depends on bug 18993, which changed state.

Bug 18993 Summary: Bump libtest-simple-perl to 1.302073
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:42:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:42:44 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18979-70-mt50kpg9jp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979
Bug 18979 depends on bug 18993, which changed state.

Bug 18993 Summary: Bump libtest-simple-perl to 1.302073
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:51:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:51:31 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-U69NhUb6Ny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 69745
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69745
Bug 19706: Fix bad json formed when there are no CCODE values

Review of attachment 69745:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19706&attachment=69745)
-----------------------------------------------------------------

Sorry, does not work, if you have defined some values in CCODE category, the
select is not visible either

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt
@@ +363,4 @@
>                      { 'type': 'text' },
>                      { 'type': 'text' },
>                      { 'type': 'text' },
> +                    [% IF ccode.size %]

should be ccodes.size (plural)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 12:52:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 11:52:02 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-Rsd4QonwvG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:03:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:03:18 +0000
Subject: [Koha-bugs] [Bug 19812] New: Holds count in "Already received"
 table has confusing and unexpected values
Message-ID: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

            Bug ID: 19812
           Summary: Holds count in "Already received" table has confusing
                    and unexpected values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In acqui/parcel.pl both the "Pending orders" and "Already received" tables show
how many holds there are for the given record. However, the count of holds in
the "Pending orders" table confuses librarians because it only lists holds for
the particular items in the orderline. Due to that, the holds column may show 0
holds even if there are a dozen record level holds for that bib! This is not
what librarians seem to expect, instead it seems that the same total holds in
the "Pending orders" table would be preferred.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:03:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:03:22 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-wXtoH4FicQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:10:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:10:45 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-eNeSrCRc8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69799&action=edit
Bug 19812 - Holds count in "Already received" table has confusing and
unexpected values

In acqui/parcel.pl both the "Pending orders" and "Already received" tables show
how many holds there are for the given record. However, the count of holds in
the "Pending orders" table confuses librarians because it only lists holds for
the particular items in the orderline. Due to that, the holds column may show 0
holds even if there are a dozen record level holds for that bib! This is not
what librarians seem to expect, instead it seems that the same total holds in
the "Pending orders" table would be preferred.

Test Plan:
1) Find an invoice with an item in the "Already received" table
2) Add one or more record level holds to the record
3) Note the holds column does not count those holds
4) Apply this patch
5) Note the holds column now shows total holds and holds for just those ordered
items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:10:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:10:43 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-zJ9bhRWqsp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:29:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:29:22 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-3nUnxpqbps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:29:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:29:36 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-tVIyWNqNp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:29:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:29:51 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-ToVHMJwDYH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:30:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:30:23 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-A4HKsKFebE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:30:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:30:41 +0000
Subject: [Koha-bugs] [Bug 18833] plugin unimarc_field_210c pagination error
In-Reply-To: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18833-70-tH6cJJS9pW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:30:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:30:58 +0000
Subject: [Koha-bugs] [Bug 19533] Hold pulldown for itemtype is empty if hold
 placement needs override
In-Reply-To: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19533-70-9q9PfKBgXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:31:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:31:21 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-irmhiJlfgG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:31:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:31:36 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-tGAQ59DHEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:31:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:31:50 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-DhdJHl38GK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:32:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:32:05 +0000
Subject: [Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS
	correctly
In-Reply-To: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18990-70-03JTE0b49Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:32:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:32:30 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-GZUJ1SklD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:33:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:33:11 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-r2NfxLaKz4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #383 from Nick Clemens <nick at bywatersolutions.com> ---
Last two ushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:33:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:33:35 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-5kyXGVoRvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:34:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:34:15 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-xP119tJhl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:34:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:34:44 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-fgFWYLKWg6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:35:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:35:00 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-GVMu6pR3BI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:35:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:35:46 +0000
Subject: [Koha-bugs] [Bug 19602] Add usage statistics link to administration
	sidebar menu
In-Reply-To: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19602-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19602-70-MoPsreMXKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:36:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:36:14 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-0HYfkP7oTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:36:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:36:30 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-kd1B6FarPI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:36:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:36:45 +0000
Subject: [Koha-bugs] [Bug 18907] Warning "dpkg-source: warning: relation <
 is deprecated: use < < or <="
In-Reply-To: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18907-70-gx5BXXyMPJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:44:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:44:37 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-Rh4iabOQhZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:44:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:44:39 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-74Ji5JfXH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69800&action=edit
Bug 19706: (followup) - correct variable name 'ccodes' not 'ccode'

To test:
1 - Have some values in CCODE authorised values
2 - Ensure collection drop down on item search displays correctly
3 - Ensure item search returns results ot screen with no js errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:58:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:58:30 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-8qGilvEbhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 13:58:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 12:58:32 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-qcahuRjEKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69801&action=edit
Bug 19806 - Add classes to itemnotes in issues table

To test:
1 - Checkout an item with both public and non-public notes
2 - Note the notes display and both have circ-hlt class
3 - Apply patch
4 - Ensure display has not changed
5 - Note notes now have classes 'item-note-public' and
'item-note-nonpublic'
6 - Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 14:01:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 13:01:16 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-yY4JojEOFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 14:21:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 13:21:56 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-Oe3Q9Kz1Kw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 14:21:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 13:21:58 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-NH1qjVxeAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69802&action=edit
Bug 19608 (QA follow-up) Fix redirect on localization modal

This patch makes two minor corrections:

1. The item types localization modal redirect problem has been fixed by
   excluding the anti-clickjack code from executing in the footer.
2. The sidebar menu highlighting script has been modified to correctly
   handle the clone-rules page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 14:31:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 13:31:30 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-t63BwrGOCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Sorry Simon, I don't understand the problem you're having!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 14:37:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 13:37:03 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-0XEy7neU46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69801|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69803&action=edit
Bug 19806: Add classes to itemnotes in issues table

To test:
1 - Checkout an item with both public and non-public notes
2 - Note the notes display and both have circ-hlt class
3 - Apply patch
4 - Ensure display has not changed
5 - Note notes now have classes 'item-note-public' and
'item-note-nonpublic'
6 - Sign off

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 14:37:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 13:37:01 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-L56UF4LwUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 15:37:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 14:37:09 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-Z4uNKmd7uK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 15:41:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 14:41:12 +0000
Subject: [Koha-bugs] [Bug 19740] Self checks calculating wrong due dates /
 configuration changes go unnoticed
In-Reply-To: <bug-19740-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19740-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19740-70-gWHhMEzqBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19740

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 15:48:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 14:48:33 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-nQe6JIUqvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 15:54:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 14:54:13 +0000
Subject: [Koha-bugs] [Bug 19785] Move template JavaScript to the footer:
 Authorities, part 1
In-Reply-To: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19785-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19785-70-EbNQtqvWAq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785

--- Comment #7 from Simon Pouchol <simon.pouchol at biblibre.com> ---
Seems like it's a bug on Firefox, totally unrelated to this patch my bad.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:05:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:05:21 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-ATJIgQ6SrW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
===== Going further =====

Another bug caused by the root issue:
When a patron leaves a comment/review on a record
And this patron is deleted
Then the "Comments pending approval" page
  (staff:/cgi-bin/koha/reviews/reviewswaiting.pl)
  throws a 500 error
  ?Can't call method "surname" on an undefined value at
/home/koha/src/reviews/reviewswaiting.pl line 76.?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:29:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:29:28 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-AbwWa7ZFfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #4 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
===== Going further =====

(In reply to Victor Grousset/tuxayo from comment #3)
> ===== Going further =====
> 
> Another bug caused by the root issue:
> When a patron leaves a comment/review on a record
> And this patron is deleted
> Then the "Comments pending approval" page
>   (staff:/cgi-bin/koha/reviews/reviewswaiting.pl)
>   throws a 500 error
>   ?Can't call method "surname" on an undefined value at
> /home/koha/src/reviews/reviewswaiting.pl line 76.?


Just trying to go the approved comments
(staff:/cgi-bin/koha/reviews/reviewswaiting.pl?status=1) also triggers the same
error. This case is more likely to happen than the above.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:30:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:30:52 +0000
Subject: [Koha-bugs] [Bug 19813] New: MarcItemFieldsToOrder cannot handle a
 tag not existing
Message-ID: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

            Bug ID: 19813
           Summary: MarcItemFieldsToOrder cannot handle a tag not existing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

MarcItemFieldsToOrder defines how Koha looks at tags in order records to
generate item data.

Let's look at a simplified case:
homebranch: 955$a
holdingbranch: 956$a

So, here we are looking at 955 for the home branch, and 956 for the holding
branch. So, it should make sense that Koha requires that these fields exist in
equal number in the record. That is, for each 955, there should be a
corresponding 956.

Let's look at a different case:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a

In this case, we are using the fallback behavior. VendorA stores the branch
data in 946, and VendorB stores it in 975. This seems like it would work, but
it won't! That's because Koha is expecting there to be the same number of 946's
as there are 975's! In reality, the VendorA records will have a number of
946's, and *zero* 975's. The inverse will be true for VendorB.

Koha should be able to skip those tags that simply don't exist in the record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:31:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:31:01 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-3IbK0kyu29@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:34:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:34:01 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-G5kxySsD7r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69804&action=edit
Bug 19813 - MarcItemFieldsToOrder cannot handle a tag not existing

MarcItemFieldsToOrder defines how Koha looks at tags in order records to
generate item data.

Let's look at a simplified case:
homebranch: 955$a
holdingbranch: 956$a

So, here we are looking at 955 for the home branch, and 956 for the holding
branch. So, it should make sense that Koha requires that these fields exist in
equal number in the record. That is, for each 955, there should be a
corresponding 956.

Let's look at a different case:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a

In this case, we are using the fallback behavior. VendorA stores the branch
data in 946, and VendorB stores it in 975. This seems like it would work, but
it won't! That's because Koha is expecting there to be the same number of 946's
as there are 975's! In reality, the VendorA records will have a number of
946's, and *zero* 975's. The inverse will be true for VendorB.

Koha should be able to skip those tags that simply don't exist in the record.

Test Plan:
1) Set MarcItemFieldsToOrder to something like:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a
budget_code: 946$f|975$f
itype: 946$y|975$y
notforloan: 946$l|975$l
ccode: 946$t|975$c
quantity: 946$q|975$q
price: 946$p|975$p
itemcallnumber: 946$n|975$n
loc: 946$c|975$t
2) Create a record using only the 975 tag for item building data
3) Import the record into Koha
4) Create a basket
5) Attempt to add the record to the basket
6) Note the unequal fields error
7) Apply this patch
8) Reload the page
9) No error!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:33:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:33:59 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-NRzkArTQ3F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:49:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:49:07 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-LaU4hFDDBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:49:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:49:07 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-LFklKB51FE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19810


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810
[Bug 19810] ILL: 404 error when activating ILL on a package installation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:50:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:50:53 +0000
Subject: [Koha-bugs] [Bug 19814] New: Batch Check-in function
Message-ID: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

            Bug ID: 19814
           Summary: Batch Check-in function
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: smichaelxx at tlen.pl
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi,
in Koha exists function named "Batch Check out" but there is no "Batch Check
in". A lot of small libraries don't have self-check station. Maybe a good
solution would be adding function "Batch Check in"?

Thanks a lot
Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 16:58:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 15:58:51 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-CFzbTUGx1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 17:02:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 16:02:31 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
	modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-o1ZD3z66ds@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #8 from Patrick Robitaille <patrick.robitaille at collecto.ca> ---
Hi, 

This is for a particular demand form a library how have not acces to personal
email adress of users. This new field will be used to add the same email
address to be able to receive overdue notifications and then send them via
another email platform that uses the host institution of the library which is
actually the educational institution.

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 17:44:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 16:44:56 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-hAspPSbuw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #33 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello Alex
I tested again and realized that the problem is not bound to multi-receiving
function. I was focusing last time on verifying at each renewal wether issues
checkboxes was checked or not and I almost missed it (and my checkings were
followed by a subscription saving as a reflex).
So the remaining problem is that the irregularities are not fit to new
subscription unless you edit the subscription, run the test and save.
If you just make the renewal the irregularities(field irregularity) are not
updated.

When testing I fall again upon a bug that I have already posted for (  
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15484). It's also
tight with irregularities and it would be great to have look at it.

Olivier

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 17:45:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 16:45:53 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-66ScxDlexP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com

--- Comment #77 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Enhancement, will not be backported

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 17:45:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 16:45:55 +0000
Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha
In-Reply-To: <bug-10344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10344-70-zwPRXw9R6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344
Bug 10344 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 17:45:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 16:45:55 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-0m7VlP35If@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Bug 19096 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 17:45:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 16:45:56 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-n7BRL0UQs3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
Bug 19594 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:01:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:01:05 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-EB7DbaZvZw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com

--- Comment #63 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!

Will not be backported to 17.11, enhancement+dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:01:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:01:05 +0000
Subject: [Koha-bugs] [Bug 11046] Better handling of uncertain years for
 publicationyear/ copyrightdate
In-Reply-To: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11046-70-4vkX1rR95q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046
Bug 11046 depends on bug 19096, which changed state.

Bug 19096 Summary: Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:01:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:01:06 +0000
Subject: [Koha-bugs] [Bug 19097] Koha to MARC mappings (Part 3): Correct
 remaining GetMarcFromKohaField and TransformMarcToKoha calls
In-Reply-To: <bug-19097-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19097-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19097-70-HvsGcAX69l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19097
Bug 19097 depends on bug 19096, which changed state.

Bug 19096 Summary: Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:03:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:03:37 +0000
Subject: [Koha-bugs] [Bug 7315] Remove deprecated notifyMailsOp.pl cronjob
In-Reply-To: <bug-7315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7315-70-VZrEM7WbP3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7315
Bug 7315 depends on bug 10021, which changed state.

Bug 10021 Summary: Remove dead code related to notifys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:03:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:03:36 +0000
Subject: [Koha-bugs] [Bug 10021] Remove dead code related to notifys
In-Reply-To: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10021-70-gFSzqRaa5k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com

--- Comment #49 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all!  Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:32:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:32:30 +0000
Subject: [Koha-bugs] [Bug 19811] Preventing runaway processes bringing down
	Koha
In-Reply-To: <bug-19811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19811-70-b4wWSXnD3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19811

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:42:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:42:23 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-uFD3qZJK8w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Ed Veal <eveal at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eveal at mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:45:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:45:03 +0000
Subject: [Koha-bugs] [Bug 19299] Replace C4::Reserves::GetReservesForBranch
 with Koha::Holds-> waiting
In-Reply-To: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19299-70-WbQYitZaCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:45:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:45:03 +0000
Subject: [Koha-bugs] [Bug 17728] Move C4::Reserves code to the Koha namespace
In-Reply-To: <bug-17728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17728-70-gpXsmt219r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728
Bug 17728 depends on bug 19299, which changed state.

Bug 19299 Summary: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19299

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:46:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:46:23 +0000
Subject: [Koha-bugs] [Bug 12227] remove demo user functionality
In-Reply-To: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12227-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12227-70-gsV4llpghL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:50:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:50:34 +0000
Subject: [Koha-bugs] [Bug 19592] Move admin templates JavaScript to the
 footer: Acquisitions
In-Reply-To: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19592-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19592-70-NT95H0jFFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:50:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:50:34 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-h2KAfz6Diw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19592, which changed state.

Bug 19592 Summary: Move admin templates JavaScript to the footer: Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19592

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:50:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:50:56 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-1wy30HqjZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:50:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:50:57 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-ezxUWN8BFW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19594, which changed state.

Bug 19594 Summary: Move admin templates JavaScript to the footer: MARC-related
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:50:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:50:57 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-ErhoterDGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600
Bug 19600 depends on bug 19594, which changed state.

Bug 19594 Summary: Move admin templates JavaScript to the footer: MARC-related
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:50:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:50:57 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-0sv7vl8ir3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601
Bug 19601 depends on bug 19594, which changed state.

Bug 19594 Summary: Move admin templates JavaScript to the footer: MARC-related
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:50:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:50:58 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the
	footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-s0evSUhATT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
Bug 19641 depends on bug 19594, which changed state.

Bug 19594 Summary: Move admin templates JavaScript to the footer: MARC-related
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:13 +0000
Subject: [Koha-bugs] [Bug 19647] Move patron lists templates JS to the footer
In-Reply-To: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19647-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19647-70-m1Fz7mcUsL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:13 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-uk4ahR5925@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:14 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-zUjALRnEH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627
Bug 19627 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:14 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-Xaq3FxbRXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653
Bug 19653 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:14 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-axqysz9SE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654
Bug 19654 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:15 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-PbLlxLQnU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656
Bug 19656 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:15 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-wCrNVxfpfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672
Bug 19672 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:16 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-vJyMF8KNCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679
Bug 19679 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:16 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-jXXsCxeyTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680
Bug 19680 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:16 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-Mese2nrAC7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682
Bug 19682 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:16 +0000
Subject: [Koha-bugs] [Bug 19709] Move template JavaScript to the footer:
	Labels
In-Reply-To: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19709-70-wDwZihZSYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709
Bug 19709 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:17 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-MKpgstMmqn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710
Bug 19710 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:31 +0000
Subject: [Koha-bugs] [Bug 19600] Move admin templates JavaScript to the
 footer: Other catalog pages
In-Reply-To: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19600-70-sLUM5PIYTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:32 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-DBewxyDSNx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19600, which changed state.

Bug 19600 Summary: Move admin templates JavaScript to the footer: Other catalog pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:45 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-GJZjRnyWxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19601, which changed state.

Bug 19601 Summary: Move admin templates JavaScript to the footer: Additional parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:51:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:51:44 +0000
Subject: [Koha-bugs] [Bug 19601] Move admin templates JavaScript to the
 footer: Additional parameters
In-Reply-To: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19601-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19601-70-PJdSVUQVlE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:00 +0000
Subject: [Koha-bugs] [Bug 19628] Move course reserves templates JS to the
	footer
In-Reply-To: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19628-70-aoqlPbQm3j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:00 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-4a3MVaE1tX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19628, which changed state.

Bug 19628 Summary: Move course reserves templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19628

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:28 +0000
Subject: [Koha-bugs] [Bug 19653] Move tools templates JavaScript to the
 footer: Additional tools
In-Reply-To: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19653-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19653-70-MXlnOjIL7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:29 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-xEIAOmzGfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19653, which changed state.

Bug 19653 Summary: Move tools templates JavaScript to the footer: Additional tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:46 +0000
Subject: [Koha-bugs] [Bug 19656] Move rotating collections templates JS to
	the footer
In-Reply-To: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19656-70-CgUOt7CyX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:46 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-IlC2YgCREB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19656, which changed state.

Bug 19656 Summary: Move rotating collections templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:58 +0000
Subject: [Koha-bugs] [Bug 19657] Move lists templates JS to the footer
In-Reply-To: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19657-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19657-70-xu4TrV5K7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:52:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:52:58 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-w7eBKjcky4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19657, which changed state.

Bug 19657 Summary: Move lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19657

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:53:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:53:15 +0000
Subject: [Koha-bugs] [Bug 19659] Move JS to the footer: Suggestions and tags
In-Reply-To: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19659-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19659-70-AIGJ3brFLS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:53:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:53:16 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-rXB6Dy9sl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19659, which changed state.

Bug 19659 Summary: Move JS to the footer: Suggestions and tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19659

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:54:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:54:05 +0000
Subject: [Koha-bugs] [Bug 19672] Move tools templates JavaScript to the
 footer: More MARC tools
In-Reply-To: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19672-70-xk3UcICM13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:54:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:54:05 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-Q8aszHF025@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19672, which changed state.

Bug 19672 Summary: Move tools templates JavaScript to the footer: More MARC tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:59:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:59:09 +0000
Subject: [Koha-bugs] [Bug 19679] Move templates JavaScript to the footer:
 More tools templates
In-Reply-To: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19679-70-v5qU2c9f5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:59:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:59:10 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-b7qBEh9SzZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19679, which changed state.

Bug 19679 Summary: Move templates JavaScript to the footer: More tools templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:59:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:59:23 +0000
Subject: [Koha-bugs] [Bug 19680] Move JS to the footer: Patron and
	circulation tools
In-Reply-To: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19680-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19680-70-7FUjUpkQxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:59:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:59:23 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-PJ5vS2buA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19680, which changed state.

Bug 19680 Summary: Move JS to the footer: Patron and circulation tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:59:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:59:44 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-0shPVamQXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19697, which changed state.

Bug 19697 Summary: Move template JavaScript to the footer: Search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:00:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:00:01 +0000
Subject: [Koha-bugs] [Bug 19700] Move template JavaScript to the footer:
 Some circulation pages
In-Reply-To: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19700-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19700-70-uNicpgarhm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 18:59:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 17:59:44 +0000
Subject: [Koha-bugs] [Bug 19697] Move template JavaScript to the footer:
	Search results
In-Reply-To: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19697-70-ceEnGGd1Ws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19697

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:00:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:00:02 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-KoabIvQbYC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19700, which changed state.

Bug 19700 Summary: Move template JavaScript to the footer: Some circulation pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:00:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:00:14 +0000
Subject: [Koha-bugs] [Bug 19710] Move plugins templates javascript to the
	footer
In-Reply-To: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19710-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19710-70-2mLfBzynJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:00:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:00:14 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-9w5SBfakhf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19710, which changed state.

Bug 19710 Summary: Move plugins templates javascript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:00:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:00:33 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-KABzLRqchu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Skipping for 17.11, enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:00:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:00:33 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-PFXH1QP4bY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19726, which changed state.

Bug 19726 Summary: Move admin templates JavaScript to the footer: Preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:18:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:18:09 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-kDI76auWJu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:18:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:18:28 +0000
Subject: [Koha-bugs] [Bug 19292] Add MARC code column on libraries list
In-Reply-To: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19292-70-O5ptwV2wQR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:18:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:18:40 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-I0MIUsG0jj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:18:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:18:55 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-iHIMW4aj9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:19:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:19:24 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-f8nTt4cuow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:43:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:43:39 +0000
Subject: [Koha-bugs] [Bug 19815] New: Replace Record via Z39.50 Server give
 option to change framework
Message-ID: <bug-19815-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19815

            Bug ID: 19815
           Summary: Replace Record via Z39.50 Server give option to change
                    framework
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Z39.50 / SRU / OpenSearch Servers
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When a staff member chooses Replace record via Z39.50/SRU from the Edit
Dropdown menu in detail.pl, the current behavior replaces the record using the
existing framework on the record. It would be a nice enhancement to have an
option when replacing the record to choose if you would also like to change the
framework. For example. You have a record that was created using a Fast Add
Framework for a newly published item. You now want to replace that record with
the full record. Koha's current behavior will replace the record into the fast
add framework. Having an option to change the framework to default or books,
etc would make the workflow easier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 19:47:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 18:47:42 +0000
Subject: [Koha-bugs] [Bug 19815] Replace Record via Z39.50 Server give
 option to change framework
In-Reply-To: <bug-19815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19815-70-hgbEiRuDGB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19815

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 20:11:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 19:11:12 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-jN79ujfEdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69805&action=edit
Bug 19776: (follow-up) remove dup category_type keys

The previous patch was obviously wrong, the category_type key appeared
twice.
categories.category_type is a varchar(1) and 'P' is not 'X'.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 20:11:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 19:11:40 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-CpHMSf9YJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 20:49:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 19:49:48 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-pdICQiwZSX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19816


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816
[Bug 19816] output_pref must raised an exception if called with dateformat =>
rfc3339 and > dateonly => 1
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 20:49:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 19:49:48 +0000
Subject: [Koha-bugs] [Bug 19816] New: output_pref must raised an exception
 if called with dateformat => rfc3339 and > dateonly => 1
Message-ID: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

            Bug ID: 19816
           Summary: output_pref must raised an exception if called with
                    dateformat => rfc3339 and > dateonly => 1
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 18330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330
[Bug 18330] REST API: Date-time handling
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:16:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:16:49 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-s6YLXQV90f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:16:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:16:54 +0000
Subject: [Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool
 patron creation
In-Reply-To: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19514-70-CXTPsocQIg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:00 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-kOwFBetznv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:06 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-qY45YeA2dt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:11 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-0RlIZUAiNb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:19 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-zGigH6Qyh9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:24 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-IECYC6VPXp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:30 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-j7Swuiq1qB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:36 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-aNGAbuAwmI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:42 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-OqMw60xNp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:17:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:17:49 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-CLTxxcSSnx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 21:59:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 20:59:00 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-t3L2m2mXJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
#   Failed test 'Test::Perl::Critic for "Koha/Object.pm"'
#   at /usr/share/perl5/Test/Perl/Critic.pm line 110.
# 
# Perl::Critic found these violations in "Koha/Object.pm":
# "return" statement with explicit "undef" at line 227, column 17.  See page
199 of PBP.  (Severity: 5)
# Looks like you failed 1 test of 854.
[20:13:10] t/00-testcritic.t 

I let you deal with that one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:18:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:18:34 +0000
Subject: [Koha-bugs] [Bug 19817] New: Merge local and online documentations
Message-ID: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

            Bug ID: 19817
           Summary: Merge local and online documentations
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: new feature
          Priority: P5 - low
         Component: Documentation
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

We are currently maintaining a local (help/* files) and online
(https://koha-community.org/manual) documentations.
They must be merged to ease the maintainability and improve the relevance.
The online manual has been improved greatly the last months and the obvious
solution would be to point to it from the different Koha installations.

Here is the different steps I have in mind:
- Remove existing local documentation
- Point to the relevant pages of the online documentation
- Make the online documentation configurable to add the ability to point to a
local copy (for offline access)
- Re-add the ability to edit the manual

It would make sense to have a koha-manual package depending on sphinx and copy
the related .rst files (depending on the Koha version). Then a script will be
provided (koha-build-manual) to regenerate the manual (after an update for
instance) in different languages.

For the local edition we could imagine to add add local commits when a change
is made. Advanced users/administrators will then need to rebase and eventually
fix the conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:18:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:18:55 +0000
Subject: [Koha-bugs] [Bug 19381] Replace the built-in help files with links
 to the online manual
In-Reply-To: <bug-19381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19381-70-J3YKkuzNOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19381

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 19817 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:18:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:18:55 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-YoWbeNqC82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 19381 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:20:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:20:56 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-rQHKo96e28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz,
                   |                            |liz at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:27:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:27:05 +0000
Subject: [Koha-bugs] [Bug 19655] To.json doesn't escape newlines which can
 create invalid JSON
In-Reply-To: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19655-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19655-70-ZE429ct8QC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19655

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69732|0                           |1
        is obsolete|                            |

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 69806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69806&action=edit
Bug 19655: Use ->build instead of build_object in 16.11.x

The build_object method of TestBuilder has been added by bug 18182,
which is not in 16.11.x

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:32:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:32:48 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-dwgXBVEY0U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69807&action=edit
Bug 19817: Redirect to the online manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:32:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:32:58 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-xpgLOlbh8g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69808&action=edit
Bug 19817: Remove local help files + edit help feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 22:59:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 21:59:56 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-3y6s9gPaE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
          Component|Circulation                 |ILL

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 23:49:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 22:49:27 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-gZVPFai1vR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69809&action=edit
Bug 19787: Add sysprefs to hide SIP screen messages in self checkout

You'll need two patrons set up for testing the functionality of the
patch. I have only created messages for the check out transaction as
this was the main request. The remaining transactions can be dealt with
in follow-ups.

Test plan:
Apply patch
Update database
Create your SIP librarian user
Restart SIP server
Go to Administration -> Preferences -> SIP
Confirm that all system preferences for SIP messages are filled with
default messages

RenewItemSIPMessage
Check out an item to Patron1 using SIP and confirm the 'Item already
checked out to you: renewing item.' message shows
Change the RenewItemSIPMessage syspref to another message, or leave it
empty
Check out the item again and confirm the message has changed
appropriately, but the item is still renewed as expected.

CheckedToAnotherSIPMessage
Check out an item to Patron2 in the intranet
Check the same item out to Patron1 using SIP and confirm the 'Item
already checked out to another person.' message shows
Change the CheckedToAnotherSIPMessage syspref to another message, or
leave it empty
Check out the item again and confirm the message has changed
appropriately. The item should not be checked out Patron1, it should
stay checked out to Patron2, as expected.

ReservedSIPMessage
Reserve an item to Patron2 in the intranet
Check out the same item to Patron1 using SIP and confirm the 'Item is
reserved for another patron upon return.' message shows
Change the ReservedSIPMessage syspref to another message, or leave it
empty
Check out the item again and confirm the message has changed
appropriately. The item should not be checked out to Patron1, it should
stay reserved for Patron2, as expected.

DebtSIPMessage
Create a manual invoice for Patron1 to add some fines to their account
Check out an item to Patron1 using SIP and confirm the 'Outstanding
fines, block issue.' message shows
Change the DebtSIPMessage syspref to another message, or leave it empty
Check out the item again and confirm the message has changed
appropriately. The item should not be checked out to Patron1 and their
fines should not change.

ReservedWaitingSIPMessage
I've made this syspref but unfortunately couldn't work out where to put
it as I couldn't trigger the message. I've put it where it makes sense
to go (where all the other sysprefs are) but at this point, no message
shows when I do the following:
Reserve an item to Patron1 in the intranet
Check out the item to Patron1 using SIP - I can't see a message here.
Corresponding syspref is ReservedWaitingSIPMessage.

HighHoldsSIPMessage
Enable the decreaseLoanHighHolds syspref and any other info you need for
testing. (I had 5 days for items with more than 1 hold on the record).
Reserve an item to Patron1 on the intranet.
Reserve the same item to Patron2 on the intranet.
Check out the item to Patron1 using SIP and confirm the 'Loan period
reduced for high-demand item' message shows
Change the HighHoldsSIPMessage syspref to another message, or leave it
empty
Redo both reserves (ensure in the correct priority order) and check out
the item again. Confirm the message has changed appropriately. The item
should be checked out and the hold for that patron removed, as expected.

Sponsored-by: Whanganui District Council

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 23:49:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 22:49:23 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-rwb4GBS0qg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 14 23:49:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 22:49:51 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to disable the
 screen messages for SIP flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-2aXK7j0DVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 00:00:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 14 Dec 2017 23:00:57 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-Ql6dDidWlz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #43 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Hi all, sorry for the delay in getting back to you, I've been away.

I removed the old_recalls table and added an 'old' flag to the recalls table in
the 'Some DB fixes' patch.

I'll now get on to fixing all of the other comments.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 01:33:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 00:33:04 +0000
Subject: [Koha-bugs] [Bug 19772] Wrong success message if PATRON_NOTE is not
	defined
In-Reply-To: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19772-70-B6umUVOsSY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|ASSIGNED                    |RESOLVED

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
this will be fixed by the patch in bug 18915.

*** This bug has been marked as a duplicate of bug 18915 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 01:33:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 00:33:04 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-HhZAvTNKSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
*** Bug 19772 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 07:14:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 06:14:54 +0000
Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate
 Authen/CAS/Client/ Response/Failure.pm
In-Reply-To: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17717-70-59VOoiVDl2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

--- Comment #47 from Marco Moreno <mmoreno at pobox.com> ---
Understanding the problem is necessary to determine the best solution.

The problem is this:

- All cron jobs start in $HOME and those in /etc/cron* run as root which is
/root.
- Problems occur when using "sudo -u another_user" to demote from root to
"another_user" which does not have read access to /root.
- The @INC array is traversed when a module is to be loaded, but a recent
update to Perl 5.22 (base.pm?) now results in a fatal error when it searches a
directory that cannot be read.
- The @INC array includes the current directory ('.') which is '/root' and
unreadable by 'another_user', resulting in this error.
- This error will also occur if run from the command line in a directory which
is not readable my 'another_user'.

Normally, crons are set up in the crontab file for the user under which it
should run. 
 Since it is rather unusual for a cron to sudo to another user, this is likely
why this regression in Perl has gone largely unnoticed.

Possible solutions:

1. Fix the regression in Perl 5.22.  This is ideal and this may have already
happened in more recent versions of Perl.  However, many of us remain stuck
with the version we have and we need a solution that will with with a broken
Perl.  Not a good short-term option.

2. Avoid using "sudo -u".  While possibly ideal, it's convenient and simple for
koha-foreach to be run as a system cron and switch to the user for each
library. Therefore, this is not a good option.

3. Modify the @INC array to remove the '.' directory so that /root will never
be searched.  This could be done in a common location (e.g.
/usr/share/koha/bin/kohalib.pl) as I suggested in Comment 40.  This is risky
because it assumes that no downstream module will ever depend upon '.' having
been removed from @INC.  While this solution has worked well for me, it
probably is not ideal either.

4. Change the current directory to one that is readable by adding 'cd /tmp' to
each cron job that performs a "sudo -u".  This has become an established
workaround, but requires modifying many cron entries.  Also not an ideal
solution.

5. Change the current directory to one that is readable by modifying all code
that performs a "sudo -u".  This may be as simple as adding "cd /tmp" at the
beginning of /usr/sbin/koha-foreach and /usr/sbin/koha-rebuild-zebra.  Possibly
the best solution for now.

Option #5 seems like the best one for now.  It is a clear, one-line solution
that doesn't require modifying any crons.

Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 07:49:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 06:49:23 +0000
Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate
 Authen/CAS/Client/ Response/Failure.pm
In-Reply-To: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17717-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17717-70-xwbCs1ruZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717

--- Comment #48 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marco Moreno from comment #47)
> Understanding the problem is necessary to determine the best solution.
[...]
> 5. Change the current directory to one that is readable by modifying all
> code that performs a "sudo -u".  This may be as simple as adding "cd /tmp"
> at the beginning of /usr/sbin/koha-foreach and /usr/sbin/koha-rebuild-zebra.
> Possibly the best solution for now.
> 
> Option #5 seems like the best one for now.  It is a clear, one-line solution
> that doesn't require modifying any crons.

I would agree. Put cd /tmp very close to the sudo -u. Adding it in cron is more
confusing.
Clear argumentation imo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 09:00:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 08:00:22 +0000
Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into
	Koha::Upload
In-Reply-To: <bug-14321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14321-70-Nen6bIJUb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

jmbroust <jean-manuel.broust at univ-lyon2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust at univ-lyo
                   |                            |n2.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 09:00:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 08:00:35 +0000
Subject: [Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like
 stage-marc-import.pl) don' t work as expected
In-Reply-To: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15032-70-5CODbMXp2R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

jmbroust <jean-manuel.broust at univ-lyon2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust at univ-lyo
                   |                            |n2.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 09:17:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 08:17:06 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-CCU0NvKiog@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #69 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here again

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 09:18:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 08:18:44 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-BG9QO2mFZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com
                   |y.org                       |
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 09:32:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 08:32:58 +0000
Subject: [Koha-bugs] [Bug 19818] New: Add id into tag html from moremember.tt
Message-ID: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

            Bug ID: 19818
           Summary: Add id into tag html from moremember.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: stephane.delaye at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In this screen /cgi-bin/koha/members/moremember.pl?
I have several li tags html without id. So when I want custom the labels with
the preference system 'intranetuserjs', i can't... from the record patron
(memberentry.pl)...it is possible
....

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 09:37:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 08:37:23 +0000
Subject: [Koha-bugs] [Bug 19811] Preventing runaway processes bringing down
	Koha
In-Reply-To: <bug-19811-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19811-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19811-70-DZhxUA41EQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19811

--- Comment #1 from Ray Delahunty <r.delahunty at arts.ac.uk> ---
This may have been due in part to us having an underpowered Koha server.
Apparently there is a firewall rule that should stop more than 200 requests
from a single IP being accepted. I was running a 5,000 record import at the
same time the keyboard key was left depressed, and the suggestion is that the
load on the server from this import was high, and the c.150 simultaneous
requests (below the 200 threshold) was enough to crash the server. We are
upgrading the server within the next 24 hours, including adding a second
processor.

Ray Delahunty
University of the Arts London

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:10:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:10:48 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-JDwfWt0ZPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69810&action=edit
Bug 19444: Do not auto renew if patron is expired and
BlockExpiredPatronOpacActions is set

If the patron's account has expired and BlockExpiredPatronOpacActions is set,
we expect auto renewal to be rejected.

Test plan:
Use the automatic_renewals.pl cronjob script to auto renew a checkout

Before this patch, if the patron's account has expired the auto renew was done.
With this patch, it will only be auto renewed if BlockExpiredPatronOpacActions
is not set.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:10:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:10:56 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-DHh7rojihf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69812&action=edit
Bug 19444: (QA follow-up) Fix tests for UNIMARC

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:10:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:10:52 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-1gDRc02NKh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69811&action=edit
Bug 19444: Display error message for auto_account_expired

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:11:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:11:01 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-NjPs3gUQrL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69813&action=edit
Bug 19444: (QA follow-up) Remove repeating condition

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:11:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:11:38 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-3bhwrkHNWo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:20:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:20:28 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-lQH9vrZHUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
May I suggest to rebase this one on top of 4319 (which has taken quite some
time already) ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:20:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:20:36 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-HaBOepdvZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=4319

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:20:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:20:36 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-vnSuAqzVfn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19301

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:45:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:45:04 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-MPJ1lxYg1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69553|0                           |1
        is obsolete|                            |

--- Comment #34 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69814&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 10:46:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 09:46:52 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-oq6tndYYyE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
I tested the package before release and also activated the ILL module. I did
not get a 404 but the message to check the about page.

I don't remember if I did it in the English or German version. Which language
did you use?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:02:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:02:27 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-rEls4ihTqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19319

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:25:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:25:58 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-XDEg0bFozV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:26:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:26:02 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-NhGVs85zPv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69724|0                           |1
        is obsolete|                            |
  Attachment #69728|0                           |1
        is obsolete|                            |

--- Comment #70 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69815&action=edit
Bug 4319: [OPAC] Allow holds on waiting/transit items

Test plan:

 - Checkout an item
 - Place hold on this item,
 - Return the item
 - Make sure the hold is waiting (found W) and AllowOnShelfHolds is
   not to 'Allow'
 - Check that the button "Place hold" appears in opac detail page of
   the biblio

 - do the samewith items/reserves in transit

Changes on C4::Reserves::IsAvailableForItemLevelRequest

Make sure this tests pass:
  - t/db_dependent/Reserves.t
  - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t

Rebased - 2017-12-12 - Alex Arnaud

Bug 4319 - [QA fix] Create Koha::Biblio->hasItemswaitingOrInTransit

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:26:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:26:08 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-eEka8nPdvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #71 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69816&action=edit
Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest

[1] For consistency going back to IsItemOnHoldAndFound in this sub.
    This call is used in the on_shelf_holds == 2 case too.
    The routine will be refactored quite soon.
    Adding the else branch for on_shelf_holds == 0 for more clarity.
[2] Removing the test for found==F in reserves. In Koha F is only used
    when the hold is filled and moved to oldreserves.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:26:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:26:14 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-OjvVWYONTd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #72 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69817&action=edit
Bug 4319: (QA follow-up) Use ReservableItems in all scripts

[1] Call CountItemsIssued or hasItemswaitingOrInTransit when needed only.
[2] Add this logic to ISBD and MARC detail too, since they also use
    this include.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Confirming that Place hold now comes up if you have a waiting item and
circulation rule == If any unavailable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:26:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:26:39 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-RRzSC0mPK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #73 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Thanks Alex for your perseverance. I am addressing your question from comment60
here too.
Putting this on top of sec report 19319 which does some changes to
Koha::Biblios->find in detail scripts.

IsItemOnHoldAndFound is only used in CanBookBeRenewed and
IsAvailableForItemLevelRequest; unfortunately it is not tested specifically.
I think it should be moved to Koha::Item. And it should not call DBIx directly
but use your search. The condition != undef is in practice the same as [W,T]
since F is only used when the reserve is filled (finished) and moved to
oldreserves.
For the same reason I remove this test (using F in the reserves table does not
reflect current use).
Koha::Holds->find($hold->{reserve_id})->found('F')->store;
$is = IsAvailableForItemLevelRequest( $item3, $borrower1);
is( $is, 0, "Item is neither waiting nor in transit." );
See the followup patches.

Rename hasItemswaitingOrInTransit => hasItemsWaitingOrInTransit ? No blocker.
The POD statement is adjusted. Imo the POD should get some more attention. No
blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:28:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:28:17 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-cLGz37wche@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #74 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #73)
> QA Comment:
> The POD statement is adjusted. Imo the POD should get some more attention.
> No blocker.

This is about the POD of IsAvailableForItemLevelRequest

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:43:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:43:11 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-ncea3QOfSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69803|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69818&action=edit
Bug 19806: Add classes to itemnotes in issues table

To test:
1 - Checkout an item with both public and non-public notes
2 - Note the notes display and both have circ-hlt class
3 - Apply patch
4 - Ensure display has not changed
5 - Note notes now have classes 'item-note-public' and
'item-note-nonpublic'
6 - Sign off

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:43:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:43:08 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-Xsw9T3Bjdx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:43:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:43:23 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-mriNgXDaf3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:44:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:44:36 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-343sNB3pmk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The only thing I could say is that item-note- does not fully match the field
name itemnotes :) Which is no problem to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:48:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:48:46 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-5ucxOcteIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:48:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:48:49 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-ZbpJqTpANN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69793|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69819&action=edit
Bug 19805: Add DataTables to Koha to MARC mapping page

This patch adds sorting and filtering to the Koha to MARC mapping table
using DataTables.

Also changed: Font awesome icons on "Add" and "Remove" buttons; Minor
markup correction to breadcrumbs.

To test, apply the patch and go to Administration -> Koha to MARC
mapping.

- Table should be sorted by default on Koha field.
- Sorting and filtering should work correctly.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:49:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:49:00 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-JfuK2WKFoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:49:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:49:14 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-sN2xSjQGLM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69814|0                           |1
        is obsolete|                            |

--- Comment #35 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69820&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

Rebased - 2017-12-15 - Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:57:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:57:45 +0000
Subject: [Koha-bugs] [Bug 19819] New: C4::Context->dbh is unreasonably slow
Message-ID: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

            Bug ID: 19819
           Summary: C4::Context->dbh is unreasonably slow
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I have been profiling Koha the last day or so to try to fix some bottlenecks
increasing performance of bulk-processing of data. Discovered that
C4::Context->dbh was unexpectedly slow (Koha::Database->schema->storage->dbh is
the culprit). If it is safe to do so, performance can be greatly improved by
locally caching $dbh in a state variable. Patch will be provided shortly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:58:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:58:08 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-Q72f01Wg2K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:58:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:58:10 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-cQonZRtyIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69666|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 69821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69821&action=edit
Bug 19759: Make TestBuilder generates only 2 decimals for float

For instance items.replacementprice is decimal(8,2) but more than 2 decimals
are generated.

It leads to issues when we compare expected objects:

    #          got: '135623.866142537'
    #     expected: '135623.87'

Test plan:
  prove t/db_dependent/TestBuilder.t
must return green

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Somehow I have the feeling that we should allow more decimals sometimes
and perhaps have a number of decimals parameter or so. Think of fields
like currency or discount.
But the current issues justify this change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:58:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:58:24 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-m60XpxW53e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 11:59:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 10:59:22 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-AUTI0G213E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #4)
> like currency or discount.

currency rate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 12:03:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 11:03:05 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-MFf0iWjql0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69822&action=edit
Bug 19819: C4::Context->dbh is unreasonably slow

Locally cache Koha::Database->schema->storage->dbh in state variable in
C4::Context->dbh to get rid of retrieval overhead

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 12:05:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 11:05:41 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-8Dlikfwllv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #4)
> The only thing I could say is that item-note- does not fully match the field
> name itemnotes :) Which is no problem to me!

Ah, yes, I copied the classes I found on returns.tt, figured the same css could
be used consistently then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 12:06:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 11:06:31 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-jmC9docdrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Who can provide me some more guarantee that we do not break things with this
patch? Did you run all tests? Can you add a test?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 12:06:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 11:06:46 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-ZUswlbxOg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 12:12:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 11:12:27 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-GrupOHv3sr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
You are mocking now while there is only one call left. Why not just call
DateTime->now only once to fill $now ? First getting the complete date and then
extracting ymd later is unneeded?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 12:18:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 11:18:08 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-b4rb8LEw0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This looks like a change in behavior. When the cgi param is default, no profile
id was passed.
I guess what you wanted to do was just if( $param && $param eq ... ) ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 13:16:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 12:16:20 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-p4WpiWbuiv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 13:52:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 12:52:53 +0000
Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in
 export csv basket
In-Reply-To: <bug-8612-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8612-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8612-70-CLLyIqx7yf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Maura Stephens <maura.stephens at gmit.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maura.stephens at gmit.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:18:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:18:06 +0000
Subject: [Koha-bugs] [Bug 19820] New: Add unsafe param to
	GetMarcSubfieldStructure
Message-ID: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

            Bug ID: 19820
           Summary: Add unsafe param to GetMarcSubfieldStructure
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org

GetMarcStructure has an "unsafe" param for faster cache retrieval, I have
looked through all the instances where GetMarcSubfieldStructure is called, and
seems to me it's safe to call get_from_cache with the "unsafe" option also in
those cases. While profiling Koha I found that quite some time was actually
spent deserializing MarcSubfieldStructure-hashes (that are usually pretty big),
actually around 7% of total time while indexing biblios for example.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:24:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:24:20 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-eIIupKwI5N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 69823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69823&action=edit
Bug 19820: Add unsafe param to GetMarcSubfieldStructure

Add unsafe param to GetMarcSubfieldStructure and use this options
where it's safe to do so to increase performance

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:25:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:25:29 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-ecRA0IbtVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:28:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:28:11 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-qvBf781Emo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:28:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:28:33 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-BnCZ4Q2e9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:35:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:35:18 +0000
Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the
 Jenkins database
In-Reply-To: <bug-10273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10273-70-ivVUYSUynV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
All related bugs are closed. Can we close this one ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:50:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:50:06 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-huyCuYkwwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 14:50:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 13:50:30 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-1cOkJ0Jlra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:17:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:17:57 +0000
Subject: [Koha-bugs] [Bug 19821] New: Run tests on a separate database
Message-ID: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

            Bug ID: 19821
           Summary: Run tests on a separate database
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: julian.maurice at biblibre.com
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Running the tests on the same database as the one used for dev has some
drawbacks:
- Everybody has different data, so we cannot make any assumptions about data in
tests and it can make tests fail for non-obvious reasons.
- Tests have to clean up every change to the database using SQL transactions,
so we cannot write testable code that use transactions (AFAIK)
- Transactions in tests happen to be committed sometimes, resulting in garbage
data added to the dev database

I'll send a patch that allows to run tests in a separate database in order to
address these issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:30:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:30:28 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-iuUnLqHiR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 69824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69824&action=edit
Fix opac-detail being broken by a review from a deleted patron

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:35:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:35:59 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-iZUX2CGLQz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69825&action=edit
Bug 19821: Run tests on a separate database

Running the tests on the same database as the one used for dev has some
drawbacks:
- Everybody has different data, so we cannot make any assumptions about
data in tests and it can make tests fail for non-obvious reasons.
- Tests have to clean up every change to the database using SQL
transactions, so we cannot write testable code that use transactions
(AFAIK)
- Transactions in tests happen to be committed sometimes, resulting in
garbage data added to the dev database

This patch provides a .proverc file that will load t/lib/Bootstrap.pm
before the tests are run.
t/lib/Bootstrap.pm is responsible for recreating a fresh database and
telling the test scripts to use it.
To use it, just run prove normally from the root directory of Koha.
By default, the database is 'koha_test' and it's created using MARC21
SQL files, it can be changed by running:

    prove --norc \
    --Mt::lib::Bootstrap=database,koha_test,marcflavour,UNIMARC

Test plan:
1. mysql> GRANT ALL PRIVILEGES ON koha_test.* TO
          <your-db-user>@localhost
2. cd /path/to/koha
3. prove t/db_dependent/<pick-your-favorite-test-here>.t
4. Verify that it created the database koha_test and that the one you
   use usually was untouched (you can edit the test file and comment the
   lines related to a transaction (txn_begin, txn_rollback))

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:37:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:37:00 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-aXDNaLPpIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|ASSIGNED                    |Needs Signoff

--- Comment #6 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Thanks Julian Maurice for the help to fix all the tricky cases and clean the
code :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:44:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:44:57 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-tGGxTtfzzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> ---
Note: this patch is a proof of concept and its main purpose is to start a
discussion (should we run tests in a separate database, should we provide a
.proverc, ...?)

Please test and discuss!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:49:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:49:22 +0000
Subject: [Koha-bugs] [Bug 19822] New: Add system preferences for ILL Module
Message-ID: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822

            Bug ID: 19822
           Summary: Add system preferences for ILL Module
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        Depends on: 7317

Right now, the ILL module is only configurable through the .conf file on the
server. It would be great if we could add system preferences so that the
configuration can be done through Koha's staff interface.

- Tab in system preferences for all ILL configurations
- Make StaffRequestComments (hide/show) a sys pref
- Make ReplyDate (hide/show) a sys pref
- Make DigitalRecipient (borrower/branch) a sys pref
- Make PartnerCode (text entry, with by default ILLLIBS entered) a sys pref


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:49:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:49:22 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-Mol21SwWTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19822


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822
[Bug 19822] Add system preferences for ILL Module
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:51:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:51:52 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-45AatZJ6su@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #215 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
(In reply to Katrin Fischer from comment #213)
> (In reply to Caroline Cyr La Rose from comment #212)
> > Is there any way to make the configuration of the ILL module more user
> > friendly? I wish I didn't have to go in the conf file and on the server to
> > configure it.
> > 
> > Here are some suggestions
> > 
> > - Tab in system preferences for all ILL configurations
> > - Make StaffRequestComments (hide/show) a sys pref
> > - Make ReplyDate (hide/show) a sys pref
> > - Make DigitalRecipient (borrower/branch) a sys pref
> > - Make PartnerCode (text entry, with by default ILLLIBS entered) a sys pref
> > - In Tools or Administration, add a page with a form to add backends with
> > our own providers
> > 
> > So far, I've only been able to enable the ILLModule sys pref and create the
> > database tables, so I don't really have any suggestions for the other
> > parts... I will add them once I figure out the rest.
> 
> Hi Caroline, please don't hesitate to file your enhancement ideas and
> suggestions as separate bugs and link them depending on this one.

Done! Bug 19822

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:55:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:55:15 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-M5Ti5y2T0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19822

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:55:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:55:15 +0000
Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module
In-Reply-To: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19822-70-l2PJyyww7B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7317

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:56:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:56:01 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-DMgO5TYama@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19605

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:56:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:56:01 +0000
Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through
 regular Koha plugins
In-Reply-To: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19605-70-x1o7yyGoCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=7317

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 15:58:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 14:58:16 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-DxOzszFeEO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Failed QA

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
koha-qa complains:

 FAIL   Koha/Patron.pm
   FAIL   pod coverage
                POD is missing for old_checkouts

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:13:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:13:35 +0000
Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to
	Circulation and OPAC
In-Reply-To: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7317-70-dPSAl2eWpe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #216 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Magnus Enger from comment #214)
> (In reply to Caroline Cyr La Rose from comment #212)
> > - In Tools or Administration, add a page with a form to add backends with
> > our own providers
> 
> There is bug 19605, which suggests making the ILL backends into regular
> "KPZ" plugins. I think Tomas will be working on that.

I'm not working on this in a short term, so anyone willing to pick that please
do.

Having ILLbackends be plugins will help removing the configuration from
koha-conf.xml too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:19:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:19:40 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-SV4D9P8I7o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
I'm not sure about the message, should we recommend a tool that is only
available on Debian package installs ?

Also, there is a strange behaviour (not caused by this patch), when KOHA_CONF
is empty or does not contain a valid/existing filename, it is just defaulted to
/etc/koha/koha-conf.xml (if it exists).
So, on my dev install, I can run `KOHA_CONF=/not/existing perl help.pl` and it
uses /etc/koha/koha-conf.xml without warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:21:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:21:39 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-mbkDJptxmb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Changing status to In Discussion to get answers to comment 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:39:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:39:19 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-QUMyljvDrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68875|0                           |1
        is obsolete|                            |

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69826&action=edit
Bug 19554: The inventory table should jump to detail instead of MARCdetail

This patch just replaces the link to detail.
Detail provides item information needed in case of inventory problems.

Test plan:
Go to Tools/Inventory.
Create an inventory list without barcode file.
Check if the link goes to detail now.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:39:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:39:30 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-My9leLldi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:42:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:42:52 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-vK5RuuOVpE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19823


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823
[Bug 19823] Move template JavaScript to the footer: MARC21 editor plugins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:42:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:42:52 +0000
Subject: [Koha-bugs] [Bug 19823] New: Move template JavaScript to the
 footer: MARC21 editor plugins
Message-ID: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823

            Bug ID: 19823
           Summary: Move template JavaScript to the footer: MARC21 editor
                    plugins
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header. This patch will do so
for MARC21 editor plugins.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:52:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:52:30 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-HXF8wso6no@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> ---
The code looks weird now, as we have

my $options = '';
...
$options = '' unless ...

So this line is completely useless.

Also, the comment above is about the split option which is not used anymore,
can you update it please ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 16:58:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 15:58:52 +0000
Subject: [Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds
 extra null fields to indexes
In-Reply-To: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19581-70-bFxHss20aL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 17:07:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 16:07:17 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-lZ335H2ctU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
             Status|Signed Off                  |Patch doesn't apply

--- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> ---
Patch does not apply anymore. Can you rebase it please ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 17:08:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 16:08:10 +0000
Subject: [Koha-bugs] [Bug 19823] Move template JavaScript to the footer:
 MARC21 editor plugins
In-Reply-To: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19823-70-Y53DtMKyAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 17:08:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 16:08:13 +0000
Subject: [Koha-bugs] [Bug 19823] Move template JavaScript to the footer:
 MARC21 editor plugins
In-Reply-To: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19823-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19823-70-QMuv03d26Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19823

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69827&action=edit
Bug 19823: Move template JavaScript to the footer: MARC21 editor plugins

This patch modifies the templates for MARC21 editor plugins so that
JavaScript is included in the footer.

To test, you must link the plugins to their corresponding tag +
subfield (if they aren't already):

In a bibliographic framework:

000 -> marc21_leader.pl
006 -> marc21_field_006.pl
007 -> marc21_field_007.pl
008 -> marc21_field_008.pl
773$t -> marc21_linking_section.tt

In an authorities framework:

000 -> marc21_leader_authorities.tt
008 -> marc21_field_008_authorities.tt
    -> marc21_field_008_classifications.tt

For each field, trigger the plugin by clicking the plugin link. Test
JavaScript-driven functionality in each plugin window and confirm that
your selections are correctly saved to the editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 17:29:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 16:29:26 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-4SUHgUSxBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Marcel de Rooy from comment #9)
> You are mocking now while there is only one call left. Why not just call
> DateTime->now only once to fill $now ? First getting the complete date and
> then extracting ymd later is unneeded?

Yes, only 85 directly uses it. However, there are tests on
lines 71, 83, 97, 100, 116, 129, 145, 154, 164, 182, 185, 193, 196, and 204.

Any of these that trigger DateTime->now()->ymd on line 109 of
Koha::SiteMapper::Writer needs the mock. Otherwise the end tag won't match.

I added a nice print STDERR "TRIGGERED!\n"; just about it and determined that
the tests 4, 8, and 11 use it. This means this mock will fix not just test 12's
more typical failure, but even the rarest cases of 5 and 9.

Plus, I was implementing exactly what was suggested in comment #0 by Katrin
Fischer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 18:19:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 17:19:07 +0000
Subject: [Koha-bugs] [Bug 19741] parcel.pl only shows holds on items in
 received orders, we should (also) count holds on the title
In-Reply-To: <bug-19741-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19741-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19741-70-mqmyvtAxSe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19741

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 19812 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 18:19:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 17:19:07 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-rJRpqli58y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 19741 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 18:43:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 17:43:25 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-ECwHbgsc4H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Can't call method "title" on an undefined value at
/home/koha/src/opac/opac-detail.pl line 847.

Successfully duplicated on old-school git install (not kohadevbox).
(In reply to Victor Grousset/tuxayo from comment #3)
> ===== Going further =====
> 
> Another bug caused by the root issue:
> When a patron leaves a comment/review on a record
> And this patron is deleted
> Then the "Comments pending approval" page
>   (staff:/cgi-bin/koha/reviews/reviewswaiting.pl)
>   throws a 500 error
>   ?Can't call method "surname" on an undefined value at
> /home/koha/src/reviews/reviewswaiting.pl line 76.?

Did you bug report this? Because your patch only fixes the 847 issue in
opac-detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 19:32:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 18:32:07 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-vaaYGriR58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 19:32:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 18:32:10 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-oHsvhIR4DC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69824|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 69828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69828&action=edit
Bug 19808: Fix opac-detail breaking on a review from a deleted patron

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 19:52:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 18:52:06 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-ivtEW9WoKS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69799|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69829&action=edit
Bug 19812 - Holds count in "Already received" table has confusing and
unexpected values

In acqui/parcel.pl both the "Pending orders" and "Already received" tables show
how many holds there are for the given record. However, the count of holds in
the "Pending orders" table confuses librarians because it only lists holds for
the particular items in the orderline. Due to that, the holds column may show 0
holds even if there are a dozen record level holds for that bib! This is not
what librarians seem to expect, instead it seems that the same total holds in
the "Pending orders" table would be preferred.

Test Plan:
1) Find an invoice with an item in the "Already received" table
2) Add one or more record level holds to the record
3) Note the holds column does not count those holds
4) Apply this patch
5) Note the holds column now shows total holds and holds for just those ordered
items

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Nancy Keener <nkeener at washoecounty.us>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 19:52:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 18:52:03 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-TWRrKJ15V5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 20:12:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 19:12:08 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-s0pNDoVHR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69804|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69830&action=edit
Bug 19813 - MarcItemFieldsToOrder cannot handle a tag not existing

MarcItemFieldsToOrder defines how Koha looks at tags in order records to
generate item data.

Let's look at a simplified case:
homebranch: 955$a
holdingbranch: 956$a

So, here we are looking at 955 for the home branch, and 956 for the holding
branch. So, it should make sense that Koha requires that these fields exist in
equal number in the record. That is, for each 955, there should be a
corresponding 956.

Let's look at a different case:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a

In this case, we are using the fallback behavior. VendorA stores the branch
data in 946, and VendorB stores it in 975. This seems like it would work, but
it won't! That's because Koha is expecting there to be the same number of 946's
as there are 975's! In reality, the VendorA records will have a number of
946's, and *zero* 975's. The inverse will be true for VendorB.

Koha should be able to skip those tags that simply don't exist in the record.

Test Plan:
1) Set MarcItemFieldsToOrder to something like:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a
budget_code: 946$f|975$f
itype: 946$y|975$y
notforloan: 946$l|975$l
ccode: 946$t|975$c
quantity: 946$q|975$q
price: 946$p|975$p
itemcallnumber: 946$n|975$n
loc: 946$c|975$t
2) Create a record using only the 975 tag for item building data
3) Import the record into Koha
4) Create a basket
5) Attempt to add the record to the basket
6) Note the unequal fields error
7) Apply this patch
8) Reload the page
9) No error!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marci Chen <mchen at mckinneytexas.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 20:12:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 19:12:06 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-z2XK35WcWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 20:48:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 19:48:09 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-yFZx2GtydC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 21:22:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 20:22:03 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-pekWuNEf9C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 21:22:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 20:22:06 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-DT2GFAI3qo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69745|0                           |1
        is obsolete|                            |

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69831&action=edit
Bug 19706: Fix bad json formed when there are no CCODE values

To test:
1 - Delete all ccode values in your system
2 - Load the item search page
3 - View the console and note a js error
4 - Try to perform an item search to screen
5 - Internal server error ("unsupported format 'html'" in logs)
6 - Apply patch
7 - Reload page
8 - Note js error is gone
9 - Perform search to screen, success!

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 21:22:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 20:22:41 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-KWl2Wd7w1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69800|0                           |1
        is obsolete|                            |

--- Comment #8 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69832&action=edit
Bug 19706: (followup) - correct variable name 'ccodes' not 'ccode'

To test:
1 - Have some values in CCODE authorised values
2 - Ensure collection drop down on item search displays correctly
3 - Ensure item search returns results ot screen with no js errors

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 21:47:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 20:47:11 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-nCTsTGfZcO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david.bourgault at inlibro.com

--- Comment #11 from David Bourgault <david.bourgault at inlibro.com> ---
Patch does not apply for me on clean master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 21:59:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 20:59:19 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-46p3c9vPZ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 21:59:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 20:59:23 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-c7buB3wrT6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69243|0                           |1
        is obsolete|                            |

--- Comment #2 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 69833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69833&action=edit
Bug 19661 - REST API: Funds Endpoint

This patch adds a new route to the REST api:

api/v1/acquisitions/funds/

https://bugs.koha-community.org/show_bug.cgi?id=19661

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 22:28:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 21:28:21 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
	page
In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18889-70-TsmFWkC5Tt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david.bourgault at inlibro.com

--- Comment #2 from David Bourgault <david.bourgault at inlibro.com> ---
Patch had a minor conflict when applying.

When following test plan I got the following:

Software error:

DBIC result _type  isn't of the _type Category at members/moremember.pl line
138.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 15 22:31:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 15 Dec 2017 21:31:09 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-7ZAWA68yNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Matthias, everything looks ok. Could you please describe the enpdoint here:

https://wiki.koha-community.org/wiki/REST_api_RFCs

(You can copy and paste from
https://wiki.koha-community.org/wiki/Patrons_endpoint_RFC and adapt it).

Also, would you consider implementing it using the objects.search
implementation from Julian?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 16 05:05:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Dec 2017 04:05:03 +0000
Subject: [Koha-bugs] [Bug 19824] New: Hi
Message-ID: <bug-19824-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19824

            Bug ID: 19824
           Summary: Hi
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sumoireng1 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 69834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69834&action=edit
Hay admin

Hahahaha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 16 07:15:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Dec 2017 06:15:59 +0000
Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow
In-Reply-To: <bug-13665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13665-70-hIK2UvLa6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665

jmbroust <jean-manuel.broust at univ-lyon2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust at univ-lyo
                   |                            |n2.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 16 07:24:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Dec 2017 06:24:03 +0000
Subject: [Koha-bugs] [Bug 16821] Facets: home libraries, locations,
	item types
In-Reply-To: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16821-70-M5iWcQr8Is@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16821

jmbroust <jean-manuel.broust at univ-lyon2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust at univ-lyo
                   |                            |n2.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 16 12:34:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Dec 2017 11:34:33 +0000
Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the
 Jenkins database
In-Reply-To: <bug-10273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10273-70-tDEr4Skv9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'd say so

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 16 12:36:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Dec 2017 11:36:49 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-nEyaMXHhxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
More Tomas, I just filed it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 16 12:42:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Dec 2017 11:42:27 +0000
Subject: [Koha-bugs] [Bug 19824] SPAM
In-Reply-To: <bug-19824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19824-70-SfOZj1yz2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19824

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
            Summary|Hi                          |SPAM
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 16 13:57:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 16 Dec 2017 12:57:13 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-hPy10FDTKr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We checked our dev installation - looks good there. But some of the demo
installations show the problem. Could be something else, but what would cause
it?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 08:31:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 07:31:56 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-LdGNJTu7Ix@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69831|0                           |1
        is obsolete|                            |
  Attachment #69832|0                           |1
        is obsolete|                            |

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69835&action=edit
Bug 19706: Fix bad json formed when there are no CCODE values

To test:
1 - Delete all ccode values in your system
2 - Load the item search page
3 - View the console and note a js error
4 - Try to perform an item search to screen
5 - Internal server error ("unsupported format 'html'" in logs)
6 - Apply patch
7 - Reload page
8 - Note js error is gone
9 - Perform search to screen, success!

To test there is no regression:
1 - Have some values in CCODE authorised values
2 - Ensure collection drop down on item search displays correctly
3 - Ensure item search returns results ot screen with no js errors

Signed-off-by Owen Leonard <oleonard at myacpl.org>

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 08:32:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 07:32:01 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-dqTPD1W7Qk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69836&action=edit
Bug 19706: (QA follow-up) Hide the collection code selector if no value is
defined (for consistency)

Test plan:
0) Go to item search
1) Do have some authorized values in CCODE category -> selector of
collection is visible
2) Don't have any authorized value in CCODE category -> selector of
collection is not visible

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 08:34:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 07:34:39 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-dcCiNBICzd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
I squashed the two patches to simplify history and added follow-up to make the
item search form behave consistant - if there is no ccode value, the selector
for collection is not visible on item search form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 09:12:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 08:12:16 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-KLZCw8uWbt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |josef.moravec at gmail.com

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Are you going to address the issue on reviews/reviewswaiting.pl too? If not
please make a bug report for it. Thanks

Marking as Failed QA = waiting for answer here ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 09:32:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 08:32:18 +0000
Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page
 will crash on unknown barcode
In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19771-70-kYvclwmNuC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Is this ready for test? If so, please set the status to Need Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 09:34:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 08:34:06 +0000
Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page
 will crash on unknown barcode
In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19771-70-2xCGmsEn8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
The page crashes also when a payment is on the list - it goes through all
operations, and payment does even have no barcode...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:08:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:08:27 +0000
Subject: [Koha-bugs] [Bug 19825] New: List of pending offline operations
 does not links to biblio
Message-ID: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825

            Bug ID: 19825
           Summary: List of pending offline operations does not links to
                    biblio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Although the pending offline operations page should link to affected biblios it
does not.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:08:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:08:50 +0000
Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not
 links to biblio
In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19825-70-RajxCLaLq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:08:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:08:40 +0000
Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not
 links to biblio
In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19825-70-LZcvwnQuYe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:21:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:21:34 +0000
Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page
 will crash on unknown barcode
In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19771-70-UTDNuH41uU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69610|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69837&action=edit
Bug 19771: Fix crashing in pending offline circulation actions list

0) Do not apply the patch
1) Add some checkout / checkin actions on existing barcodes, you can use
standalone application, Firefox add-on or built-in offline circulation
client
2) Go to Circulation -> Pending offline circulation actions and you will
see you actions in the table
3) Add some actions with non-exitent barcodes or a payment
4) Go to Circulation -> Pending offline circulation actions - the page
crashes
5) Apply the patch
6) Go to Circulation -> Pending offline circulation actions - the page
is working again

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:23:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:23:18 +0000
Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page
 will crash on unknown barcode or on payment action
In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19771-70-dNxQjDpXvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
            Summary|Pending offline circulation |Pending offline circulation
                   |actions page will crash on  |actions page will crash on
                   |unknown barcode             |unknown barcode or on
                   |                            |payment action
           Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
I added a counterpatch, could you please test?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:25:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:25:42 +0000
Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not
 links to biblio
In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19825-70-dRxcliWFWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:25:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:25:45 +0000
Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not
 links to biblio
In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19825-70-ZfoXOTYyxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69838&action=edit
Bug 19825: Make links to biblios on pending offline circulation page working
again

0) Do not apply the patch
1) Have pending offline circulation operations - you can use standalone
application, Firefox add-on or built-in offline circulatin client - it
does not matter in this case
2) Go to Circulation -> pending offline circulation actions
3) You see all barcode in red and without links - even if the item and
biblio existed
4) Apply the patch
5) Repeat 1-3, now you should see the links to biblio on existing items

Note: Don't add non-existent barcodes actions and payment actions unti
bug 19771 is not fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:26:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:26:03 +0000
Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not
 links to biblio
In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19825-70-rqTIuRNlqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19771

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 10:26:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 09:26:03 +0000
Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page
 will crash on unknown barcode or on payment action
In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19771-70-eVPvVHA7SC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19825

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 12:32:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 11:32:13 +0000
Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through
 regular Koha plugins
In-Reply-To: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19605-70-kn1OfZYdX5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19822

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 12:32:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 11:32:13 +0000
Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module
In-Reply-To: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19822-70-CV3OiP0uUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19605

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 12:34:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 11:34:34 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-X1TpeKJnBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 12:35:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 11:35:50 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-pFMTGbm06Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Is this ready to test?

What should the test plan looks like?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 12:36:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 11:36:20 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-PmbfvLNM67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Is this ready to test?

What is a test plan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 18:32:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 17:32:45 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-yqRnXsXHqo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
Yes, pretty hard to write a test plan for this. But I guess I can post a script
on monday which can be run to illustrate the performance differance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 18:33:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 17:33:57 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-iimR3Sevzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
I don't know if there is a test plan that can be fit into a commit-message. But
I can post a script tomorrow that can be used to illustrate the performance
differance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 20:58:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 19:58:56 +0000
Subject: [Koha-bugs] [Bug 19500] Difference in Koha module names for notices
 linked to Holds/ Reserves
In-Reply-To: <bug-19500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19500-70-GQcd4T2hFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
That is because the module name on the summary table is not translated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 17 21:39:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 20:39:00 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-b8ZYsvZh1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #3 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I've tried the patch on my kohadevbox VM and unfortunately I get this output:

vagrant at kohadevbox:kohaclone(bug_19821)$ prove t/db_dependent/Suggestions.t 
Error reading file /tmp/koha-conf.wyAjLQ at
/home/vagrant/kohaclone/Koha/Config.pm line 51.
Error reading file /tmp/koha-conf.wyAjLQ at
/home/vagrant/kohaclone/Koha/Config.pm line 51.
Error reading file /tmp/koha-conf.wyAjLQ at
/home/vagrant/kohaclone/Koha/Config.pm line 51.
The config file (/tmp/koha-conf.wyAjLQ) has not been parsed correctly at
/home/vagrant/kohaclone/C4/Context.pm line 262.
Error reading file /tmp/koha-conf.wyAjLQ at
/home/vagrant/kohaclone/Koha/Config.pm line 51.
The config file (/tmp/koha-conf.wyAjLQ) has not been parsed correctly at
/home/vagrant/kohaclone/C4/Context.pm line 262.
Error reading file /tmp/koha-conf.wyAjLQ at
/home/vagrant/kohaclone/Koha/Config.pm line 51.
The config file (/tmp/koha-conf.wyAjLQ) has not been parsed correctly at
/home/vagrant/kohaclone/C4/Context.pm line 262.
Create test database...
Use of uninitialized value $host in concatenation (.) or string at
/home/vagrant/kohaclone/t/lib/Bootstrap.pm line 50.
Use of uninitialized value $port in concatenation (.) or string at
/home/vagrant/kohaclone/t/lib/Bootstrap.pm line 50.
Use of uninitialized value $database in concatenation (.) or string at
/home/vagrant/kohaclone/t/lib/Bootstrap.pm line 55.
DBD::mysql::db do failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near '' at line 1 at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 55.

I do have the grant applied:

GRANT ALL PRIVILEGES ON `koha_test`.* TO 'koha_kohadev'@'%'

Without the patch, the test runs OK.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 00:39:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 23:39:56 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-hYe8sxqbd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69839&action=edit
Bug 18915: Giving CHECKOUT_NOTE access to issues table

This patch allows the notice to reference the issues table so that the
checkout note itself can be added to the note if wanted, such as in
Comment 9.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 00:43:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 23:43:45 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-drEdGEgrFn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #12 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to M. Tompsett from comment #8)
> ::: installer/data/mysql/updatedatabase.pl
> @@ +14308,4 @@
> >  
> >      $dbh->do(q|
> >          INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`)
> > +        VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');
> 
> I don't think updatedatabase should be modified like this. This is already
> done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE,
> if this is correct logic.

I thought this change was necessary for fresh installs. If the atomic update is
enough then I'm happy to take this out.

> 
> ::: opac/svc/patron_notes
> @@ +82,4 @@
> >                  my $biblionumber = $issue->item->biblionumber;
> >                  my $letter = C4::Letters::GetPreparedLetter (
> >                      module => 'circulation',
> > +                    letter_code => 'CHECKOUT_NOTE',
> 
> Why even change the letter code, given that you aren't changing the svc name?

Mostly so that the name of the note is consistent with the name of the syspref
(AllowCheckoutNotes), therefore, the name of the feature. The filename should
also be changed as checkout note is more appropriate than patron note anyway -
I think this was just a missed case from the original bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 00:48:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 17 Dec 2017 23:48:23 +0000
Subject: [Koha-bugs] [Bug 18915] Creating a checkout note (patron note)
 sends an incomplete email message
In-Reply-To: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18915-70-utrCmnWFLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69840&action=edit
Bug 18915: Renaming svc/patron_notes to svc/checkout_notes

For consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 02:02:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 01:02:23 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-qhs1cAc3W5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 02:15:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 01:15:30 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-w8iRgCLaMm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
As I alluded to in comment #7 based on comment #4's observation.

(In reply to Josef Moravec from comment #9)
> Are you going to address the issue on reviews/reviewswaiting.pl too?

If so, awaiting patch.


> If not
> please make a bug report for it.

-- and add it to the See Also.


> Thanks

-- Ditto. :)


> Marking as Failed QA = waiting for answer here ;)

I'm torn. The title doesn't suggest it will be fixed here.
However, there is no link to a bug elsewhere. I'll leave the status as is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 03:10:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 02:10:37 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-FAjfrb8bI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Marcel de Rooy from comment #3)
> This looks like a change in behavior. When the cgi param is default, no
> profile id was passed.
> I guess what you wanted to do was just if( $param && $param eq ... ) ?

Hi Marcel,

there is no change in behaviour in my patch. It looks like there's originally a
bug here, because the original code says "if $query->param('csv_profile') eq
'default'", but the word 'default' is never passed through that param, based on
acqui/basket.tt. this means that when the Default option was selected, the
$query->param('csv_profile') is not actually set to 'default' so an
uninitialised value is sent to the GetBasketAsCSV method and the 'if' condition
is never true. (I hope that makes sense. If you put a warn inside the if
statement under where $query->param('csv_profile') eq default, you'll see that
it never enters here and never prints the warn.)

my patch checks if the $query->param('csv_profile') has been defined. if it
has, then it uses one of the library-made csv profiles. if it hasn't been
defined then it must be using the default profile and no ID is passed, as
intended, with no warns.

setting back to needs signoff as I believe this is still a valid patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 03:45:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 02:45:40 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-PoGVtEJbom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 16.11.x will be in 16.11.15

Thats Gwendal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 03:46:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 02:46:03 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-iJUSZpz0eI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> ---

> Thats Gwendal

That should be Thanks Gwendal :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 04:04:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 03:04:01 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-JHEpHKRESi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #44 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69841&action=edit
Bug 19532: Fixing merge conflicts etc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 06:02:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 05:02:44 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-zPSGlOapUQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 06:03:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 05:03:44 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-JSioppu31V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 06:05:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 05:05:32 +0000
Subject: [Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like
 stage-marc-import.pl) don' t work as expected
In-Reply-To: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15032-70-L4rVNTCM0g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 09:10:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 08:10:30 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-xH2J1ucbQ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 69842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69842&action=edit
Bug 19821: Close filehandle after writing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 09:12:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 08:12:23 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-VM3LovR7bz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

--- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi Jon, thanks for testing.

I cannot reproduce the same problem as you but I noticed that the temporary
file is not always written to before it's used. The last patch should fix that.
If that doesn't work for you, could you remove the 'UNLINK => 1' param from
tempfile call and inspect the content of the created temporary file after prove
?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 09:27:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 08:27:39 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-dxaqaoZ7on@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 09:27:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 08:27:41 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-HqSxIS21IG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

--- Comment #6 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69843&action=edit
[SIGNED-OFF] Bug 19821: Run tests on a separate database

Running the tests on the same database as the one used for dev has some
drawbacks:
- Everybody has different data, so we cannot make any assumptions about
data in tests and it can make tests fail for non-obvious reasons.
- Tests have to clean up every change to the database using SQL
transactions, so we cannot write testable code that use transactions
(AFAIK)
- Transactions in tests happen to be committed sometimes, resulting in
garbage data added to the dev database

This patch provides a .proverc file that will load t/lib/Bootstrap.pm
before the tests are run.
t/lib/Bootstrap.pm is responsible for recreating a fresh database and
telling the test scripts to use it.
To use it, just run prove normally from the root directory of Koha.
By default, the database is 'koha_test' and it's created using MARC21
SQL files, it can be changed by running:

    prove --norc \
    --Mt::lib::Bootstrap=database,koha_test,marcflavour,UNIMARC

Test plan:
1. mysql> GRANT ALL PRIVILEGES ON koha_test.* TO
          <your-db-user>@localhost
2. cd /path/to/koha
3. prove t/db_dependent/<pick-your-favorite-test-here>.t
4. Verify that it created the database koha_test and that the one you
   use usually was untouched (you can edit the test file and comment the
   lines related to a transaction (txn_begin, txn_rollback))

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 09:27:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 08:27:44 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-9w5aRAUchk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

--- Comment #7 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69844&action=edit
[SIGNED-OFF] Bug 19821: Close filehandle after writing

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 10:39:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 09:39:23 +0000
Subject: [Koha-bugs] [Bug 19771] Pending offline circulation actions page
 will crash on unknown barcode or on payment action
In-Reply-To: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19771-70-csiNv2b7qP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

--- Comment #6 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Your patch works well, it prevents from crashing on a unknown barcode.

However, I couldn't reproduce the crash on a payment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 11:32:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 10:32:19 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-TfIxLncdA4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Interesting.
I'm just thinking if we should not resolve the garbage data problem instead of
working around it with another database. 
I would rather not default to another database.
If you create an additional clone with db and koha-conf, you can just run
another export KOHA_CONF and run a test on the other db?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 12:12:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 11:12:49 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-KeD5o9RFbD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

--- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Marcel de Rooy from comment #8)
> Interesting.
> I'm just thinking if we should not resolve the garbage data problem instead
> of working around it with another database.
Sure we could, but
1) I think it cannot be fixed once and for all (patch writer could forget to
setup the DB transaction in tests, when you will test the patch it will alter
your database)
2) It doesn't fix the other problems (non obvious fails caused by different
data, non testable "transactions-using" code)

> I would rather not default to another database.
Can you elaborate on why you prefer to keep only one database ?

> If you create an additional clone with db and koha-conf, you can just run
> another export KOHA_CONF and run a test on the other db?
Right, but
1) It's error-prone (I know I will forget to change KOHA_CONF at some point)
2) If I'm the only one doing that, it only fixes my "garbage data" problem. 

However if everyone starts using the same database for tests, it might ease
writing and running tests. It also make testing with another marcflavour very
easy (maybe some day all tests will pass in UNIMARC... :))

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 13:55:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 12:55:38 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-R3O2HiL0zi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Regarding how to test: time this script (for example)
https://gist.github.com/gnucifer/8a9a26de02d2e344c99398a19fc8df71 in koha-shell
wihtout the patch applied:

`koha-shell kohadev -c "time perl context_dbh_text.pl`

On my machine this takes about 17.2 seconds.

Apply patch, run again. For me with patch applied time decreases to about 10.2
seconds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 13:57:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 12:57:30 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-BJbJuswimd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

--- Comment #5 from David Gustafsson <glasklas at gmail.com> ---
Command should be:
`koha-shell <koha_instance_name> -c "time perl context_dbh_text.pl"`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:07:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:07:57 +0000
Subject: [Koha-bugs] [Bug 15191] Serials display improvements
In-Reply-To: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15191-70-NqPDtXY5fs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15191

--- Comment #1 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 69845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69845&action=edit
Bug 15191 - Serials display improvements

Index the serial numbering pattern's internal counters for each Serial
so we can make super fast searches for individual Serial Numbers.

TEST PLAN:
See the Cucumber feature-file

-You can use misc/maintenance/updateSerialSeq.pl to update all pattern indexes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:11:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:11:04 +0000
Subject: [Koha-bugs] [Bug 15191] Serials display improvements
In-Reply-To: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15191-70-LY9rcaikaA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15191

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lari.taskula at jns.fi

--- Comment #2 from Lari Taskula <lari.taskula at jns.fi> ---
Rebased this Olli-Antti's (forgotten) patch on top of current master. Perhaps
some tidying is required, but it is testable for those interested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:21:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:21:48 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-bjkxyc5QFs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
`koha-shell <koha_instance_name> -c "time perl context_dbh_test.pl"`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:52:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:52:28 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-bLt4o69pO6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69503|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:52:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:52:33 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-0wmRUeK99q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69504|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:55:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:55:31 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-CT5CPBNEmv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #3)
> I'm not sure about the message, should we recommend a tool that is only
> available on Debian package installs ?

It is the common mistake people does when they use kohadevbox, so they will
have access to koha-shell.
What do you suggest?

> Also, there is a strange behaviour (not caused by this patch), when
> KOHA_CONF is empty or does not contain a valid/existing filename, it is just
> defaulted to /etc/koha/koha-conf.xml (if it exists).
> So, on my dev install, I can run `KOHA_CONF=/not/existing perl help.pl` and
> it uses /etc/koha/koha-conf.xml without warning

Yes we should add a warning instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:57:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:57:26 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-KDkSTuf1H8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69825|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 14:59:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 13:59:53 +0000
Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database
In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19821-70-J87hR9YFiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69842|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:16:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:16:51 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-W4OiJmE3av@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69847&action=edit
Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed

At this point the subroutine is not used anymore

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:16:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:16:46 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-nAcGRDfcWV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67420|0                           |1
        is obsolete|                            |
  Attachment #67421|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69846&action=edit
Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy

Following the pattern introduced by bug 19300, we are going to move the
OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy

Test plan:
Make sure the onshelfholds policy is correct when placing a hold

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:17:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:17:39 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-ugy1p9QNWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |4319

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Rebased on top of bug 4319.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
[Bug 4319] waiting and in transit items cannot be reserved
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:17:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:17:39 +0000
Subject: [Koha-bugs] [Bug 4319] waiting and in transit items cannot be
	reserved
In-Reply-To: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4319-70-276K7slqoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19301


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301
[Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:22:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:22:35 +0000
Subject: [Koha-bugs] [Bug 19826] New: Introduce Koha::Acquisition::Budget(s)
 and Koha:: Acquisition::Fund(s)
Message-ID: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

            Bug ID: 19826
           Summary: Introduce Koha::Acquisition::Budget(s) and
                    Koha::Acquisition::Fund(s)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

In order to implement budgets and funds endpoints, we need to provide a way to
get them through the Koha::Object(s) layer instead of just DBI+hashref. This
way we can take advantage of DBIC annotations, TO_JSON, helper params handling
and query builder, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:23:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:23:12 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-0PTBtFMWNi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |matthias.meusburger at biblibr
                   |                            |e.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:28:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:28:58 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-j3lbf9VjnX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:29:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:29:03 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-sniklXLr4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69848&action=edit
Bug 19826: Add K::Acq::Budget(s) and K::Acq::Fund(s)

This patch introduces Koha::Object(s)-derived classes for budgets and funds
(aqbudgetperiods and aqbudgets respectively).

C4::Budgets already uses DBIC calls on those tables so transition should be
easy on top of this.

To test:
- Check the referenced schema files are the right ones.
- QA scripts shoudl be happy.
- Sign off :-D

Note: the POD coverage report throws a false negative result on singular
classes which is trivially wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:33:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:33:41 +0000
Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data
In-Reply-To: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19016-70-SbgX8WSLKg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

--- Comment #17 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
This script doesn't update primary key auto increment after updating item
numbers which results in duplicate primary key errors when Koha tries to create
new items (until you go over items created by script).

This is not evident if you restart mysql server and have setup auto increment
fixes according to wiki, after running this script, but it would be better if
script would update auto increment after having used primary keys in first
place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:41:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:41:12 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-72Sf6BmHUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
I think it would be better to use Koha::Acquisition::Budgets and
Koha::Acquisitions::Budgets::Funds instead of having both modules be siblings.
My proposed names would indicate the actual hierarchy and relationship of
budgets and funds where funds belong to a given budget.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:42:36 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-a6z4JM594V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69848|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69849&action=edit
Bug 19826: Add K::Acq::Budget(s) and K::Acq::Budget::Fund(s)

This patch introduces Koha::Object(s)-derived classes for budgets and funds
(aqbudgetperiods and aqbudgets respectively).

C4::Budgets already uses DBIC calls on those tables so transition should be
easy on top of this.

To test:
- Check the referenced schema files are the right ones.
- QA scripts shoudl be happy.
- Sign off :-D

Note: the POD coverage report throws a false negative result on singular
classes which is trivially wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:43:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:43:10 +0000
Subject: [Koha-bugs] [Bug 19827] New: checkuniquemember is exported from
 C4:: Members but has been removed
Message-ID: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827

            Bug ID: 19827
           Summary: checkuniquemember is exported from C4::Members but has
                    been removed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 16909

C4/Members.pm:        &checkuniquemember

But bug 16909 removed this subroutine.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909
[Bug 16909] Koha::Patrons - Remove checkuniquemember
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:43:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:43:10 +0000
Subject: [Koha-bugs] [Bug 16909] Koha::Patrons - Remove checkuniquemember
In-Reply-To: <bug-16909-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16909-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16909-70-sYfKSeT9OF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19827


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827
[Bug 19827] checkuniquemember is exported from C4::Members but has been removed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:45:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:45:30 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-vO2z1grlgJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #5)
> It is the common mistake people does when they use kohadevbox, so they will
> have access to koha-shell.
> What do you suggest?
I'm not sure, I just don't like how Koha is being more and more coupled with
Debian.
I won't have time to think about another solution for the next two weeks and I
don't want to block this bug, so I'm resetting the status to Signed Off.
@QAers, feel free to take this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:45:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:45:40 +0000
Subject: [Koha-bugs] [Bug 15707] Add ability to define hierarchical groups
	of libraries
In-Reply-To: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15707-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15707-70-s0dqaqNqVp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:46:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:46:33 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-VvIvbdUvMI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Kyle M Hall from comment #2)
> I think it would be better to use Koha::Acquisition::Budgets and
> Koha::Acquisitions::Budgets::Funds instead of having both modules be
> siblings. My proposed names would indicate the actual hierarchy and
> relationship of budgets and funds where funds belong to a given budget.

I agree with indicating the relationship. I've submitted a modified version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:51:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:51:05 +0000
Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display
 in opac or staff side
In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19677-70-3ymPhHrtwB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69850&action=edit
Bug 19677 - Properly escape enumchrom/serialseq data

Some serial issues use angle brackets for denoting certain data.
Currently this is not displayed in Koha. This patch escapes the data so
that angle brackets will display.

To test:
1 - Add an enumchron field to an item containg angle brackets:
"This is a <test>"
2 - View the record in the staff and opac, not the field displays as:
"This is a"
3 - Apply patch
4 - Note full text now displays

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:51:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:51:02 +0000
Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display
 in opac or staff side
In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19677-70-krkpaxAZyF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:51:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:51:32 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-20uwWxpPWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #78 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please double check there is something wrong: Koha::Patron->store does nothing,
and ->_validate (private) is called from outside the module.

I guess it should be called, and then the expections caught from (at least)
memberentry.

Same for Koha::Patron::Modification->store, I think the exception must be
caught in our code.

And, first of all, _check_branchcode and _check_categorycode sound wrong: we
have a FK on DB level and DBIx::Class will raise an error already if something
is missing. Are we going to create these kind of check method for all the FK we
have at DB level?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 15:53:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 14:53:41 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-np9JB4KQP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #79 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Apparently I already raised that concern on comment 21 and comment 30.
Could you convince me we really want/need they _check_* methods? If they are
pushed it will become a standard and I do not think it is the way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:00:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:00:56 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-Kq3CD38GP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #80 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #78)
> Please double check there is something wrong: Koha::Patron->store does
> nothing, and ->_validate (private) is called from outside the module.

I agree, _validate doesn't prove that useful, so maybe we should get rid of it
at all.

> I guess it should be called, and then the expections caught from (at least)
> memberentry.
> 
> Same for Koha::Patron::Modification->store, I think the exception must be
> caught in our code.

This looked handy, but I actually removed the code that dealt with modification
requests on this endpoint. Would you agree we can just remove this from the
commit?

> And, first of all, _check_branchcode and _check_categorycode sound wrong: we
> have a FK on DB level and DBIx::Class will raise an error already if
> something is missing. Are we going to create these kind of check method for
> all the FK we have at DB level?

I agree with this assertion. I think ->store should just catch and parse the
DBIC exceptions and raise our own to have better control of the situation.

I don't agree we should catch the exceptions on this bug, as those exceptions
already raise (DBIC ones) and are currently uncatched. Would you accept that we
filed a new bug for better exception handling in controller scripts using
Koha::Patron->store?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:01:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:01:28 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-KSUtDdMmsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We could just add something like: If you are using a debian-based system you
can use the koha-shell command otherwise you should check your permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:13:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:13:48 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-3fbGmjGwwf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69851&action=edit
Bug 18330: Do not return undef explicitely

This patch fixes a perl critic issue, hopefully it will not break
something else.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:18:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:18:56 +0000
Subject: [Koha-bugs] [Bug 19444] Automatic renewal script should not
 auto-renew if a patron' s record has expired
In-Reply-To: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19444-70-YeAP80V5Fr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:19:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:19:03 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-5aeRCrNuq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:19:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:19:10 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-2WJpUjCv3Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:19:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:19:16 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-G7vMeJOpCL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:19:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:19:21 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-E5keZVaXaf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:19:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:19:26 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-cFj3uVwd4s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:19:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:19:32 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-4hbJ7evcMB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:19:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:19:35 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-ZuOcHsL9m7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:25:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:25:52 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-UkM0cQl3W2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
It's seems it's a little bit to hard to test on a koha-instance with only a few
biblios. I tried reloading the same biblio x number of times, but there only
was minor difference in performance. Obviously some kind of caching-mechanism
kicks in when reloading the same one, the difference is much more obvious when
loading x different biblios, so requires a database with a lot of biblios to
test. Anyway, this script can be run to demonstrate the impact of this change
on the GetMarcBiblio-function, which is where much of the work takes place when
loading a biblio with items:
https://gist.github.com/gnucifer/1bc2fa8b3f9899358074d3f6a3554948

`koha-shell <koha_instance_name> -c "time perl unsafe_test.pl"`

Will get back with timings with and without patch as I need to import a larger
database into my local development instance (which takes a while).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:38:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:38:07 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-KiF62O7UJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED
           Assignee|victor.grousset at biblibre.co |jonathan.druart at bugs.koha-c
                   |m                           |ommunity.org

--- Comment #11 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
(In reply to M. Tompsett from comment #7)
> Did you bug report this? Because your patch only fixes the 847 issue in
> opac-detail.pl

(In reply to Josef Moravec from comment #9)
> Are you going to address the issue on reviews/reviewswaiting.pl too? If not
> please make a bug report for it. Thanks

Thanks for following up on that part.

The idea was to write somewhere these findings to not forget to do something
about that.

I planned to open a separate bug for this as it's wasn't the same priority. So
I only have the time handle the first part.

After a discussion with Joubu, it's better to fix the rest in the same bug. So
here you go (changing status and assignee).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:47:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:47:13 +0000
Subject: [Koha-bugs] [Bug 15704] split up 264 index
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-EqM0UE53Ta@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:47:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:47:16 +0000
Subject: [Koha-bugs] [Bug 15704] split up 264 index
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-MByfPCadm1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 69852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69852&action=edit
Bug 15704 - Split up zebra indexing of RDA  publisher information

To test:
1 - Add a record with a unique publisher "Supercalifragilistic" in the
264 b field
2 - Search for the value
3 - Record not found
4 - Apply patch (may need ot copy the .xml file into koha install)
5 - Reindex all the things
6 - Search for the value
7 - Success!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:49:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:49:30 +0000
Subject: [Koha-bugs] [Bug 15704] split up 264 index
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-Tr5L2g9gUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com
                   |                            |,
                   |                            |kelly at bywatersolutions.com,
                   |                            |margaret at bywatersolutions.c
                   |                            |om,
                   |                            |nick at bywatersolutions.com
           Assignee|gmcharlt at gmail.com          |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:50:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:50:50 +0000
Subject: [Koha-bugs] [Bug 16821] Facets: home libraries, locations,
	item types
In-Reply-To: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16821-70-8KEpgjPzI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16821

--- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I think having Koha add a complete list of facet for some categories (this
should be an option), rather than the database building these particular
facets, would be more reliable, and maybe even faster, as the database does not
have to compile and generate them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 16:58:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 15:58:20 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-HXqQqqrNMV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

--- Comment #5 from David Gustafsson <glasklas at gmail.com> ---
My vm-disk was too small for the dump, so will not be able to run this today.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:19:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:19:17 +0000
Subject: [Koha-bugs] [Bug 19828] New: Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
Message-ID: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

            Bug ID: 19828
           Summary: Koha::Object->store should catch DBIC exceptions and
                    raise Koha::Exceptions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

DBIC exceptions are not suitable for reporting end users and API consumers the
problems we find. They need to be parsed to find out the root cause of the
problems. This could be done in Koha::Object-based classes (see bug 16330 for a
discussion on this), but it should be handled more generically, in
Koha::Object->store.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:20:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:20:03 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-kkS87ZXeLz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at kul.oslo.k
                   |                            |ommune.no,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |lari.taskula at jns.fi,
                   |                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:36:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:36:34 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-QiDAF0crVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:36:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:36:39 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-SaDe4oXH78@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69828|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69853&action=edit
Bug 19808: Handle deleted reviewers gracefully - opac-detail

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:36:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:36:44 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-scPufdd5wD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69854&action=edit
Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail

Make the tests easier to read

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:36:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:36:52 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-XgGrBiCHZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69855&action=edit
Bug 19808: Handle deleted reviewers gracefully - opac-showreview

Test plan:
- Create reviews
- Delete some reviewers
- Enable OpacShowRecentComments
- Go to opac/opac-showreviews.pl
- Go to opac-showreviews.pl?format=rss

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:36:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:36:57 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-inZRKJ7F0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69856&action=edit
Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

Test plan:
- Create reviews
- Delete some reviewers
- Go to Home ? Tools ? Comments ? Comments awaiting moderation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:45:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:45:41 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make
	opac-detail explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-G5FEr5yaYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #16 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 69856
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69856
Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

Review of attachment 69856:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19808&attachment=69856)
-----------------------------------------------------------------

::: reviews/reviewswaiting.pl
@@ +67,4 @@
>      }
>  )->unblessed;
>  
> +for my $review ( @$reviews ) {

Love the explicit $review instead of $_ code.

@@ +72,1 @@
>      # setting some borrower info into this hash

Think the comment is misplaced.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:48:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:48:48 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-husNXfodIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Reviews from deleted        |Reviews from deleted
                   |patrons make opac-detail    |patrons make few scripts to
                   |explode                     |explode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:54:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:54:04 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-sJV4RXnydE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69857&action=edit
Bug 19828: Unit tests

This patch introduces unit tests for the changes this bug introduces to
Koha::Object->store.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests should fail because the changes are not implemented on this
patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:54:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:54:09 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-7YQXUYY2bt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69858&action=edit
Bug 19828: Make Koha::Object->store translate DBIC exceptions into Koha
exceptions

This patch introduces a try/catch block in store() and parses the error
when an exceptional situation takes place.

It only deals with FK constraint violations. The rest of the DBIC exceptions
are rethrown.

To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:54:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:54:43 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-UNyeXtgXjF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:56:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:56:08 +0000
Subject: [Koha-bugs] [Bug 19166] Add the ability to add adjustments to an
	invoice
In-Reply-To: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19166-70-SvRu78jcAA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #18 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I have applied the database changes on my kohadevbox and I get this from `prove
-v t/db_dependent/Budgets.t` (first 128 tests of the 145 are OK, so looks like
test 129 is blowing up, so I won't include all the output for brevity here):

ok 127 - MoveOrders updated the budget amount with the previous unspent budget
(for budget budget_2)
ok 128 - MoveOrders updated the budget amount with the previous unspent budget
(for budget budget_21)
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO
`account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with
ParamValues: 0=173079442325239000000.000000, 1='1', 2='Manual Debit'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a
foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) at
/home/vagrant/kohaclone/Koha/Object.pm line 122
# Looks like your test exited with 255 just after 128.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 17/145 subtests 

Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 65280 Tests: 128 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 145 tests but ran 128.
Files=1, Tests=128,  5 wallclock secs ( 0.04 usr  0.02 sys +  3.98 cusr  0.44
csys =  4.48 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 17:56:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 16:56:24 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-VMjxxR0Xm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #17 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
BTW any idea why it doesn't seem to affect 16.11?
A least for the explosion part. It still shows "Your comment" + the edit button
when the patron is deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:04:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:04:28 +0000
Subject: [Koha-bugs] [Bug 16750] Redirect from selectbranchprinter.pl to
 additem.pl causes software error
In-Reply-To: <bug-16750-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16750-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16750-70-PF2kX8tou9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16750

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:10:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:10:02 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-KDphcKhrU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19808


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808
[Bug 19808] Reviews from deleted patrons make few scripts to explode
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:10:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:10:16 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-aK1SPLkT0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17829


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:10:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:10:16 +0000
Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
In-Reply-To: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17829-70-lfJH3Am9g5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19808


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808
[Bug 19808] Reviews from deleted patrons make few scripts to explode
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:10:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:10:02 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-X7FfH5ijTC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15839

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Koha::Reviews is used since bug 15839 (in 16.11.x), but the patron's info are
still retrieved from GetMember.
Since bug 17829 (17.11) they are using Koha::Patrons (which means we cannot
call a method on an undefined object)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839
[Bug 15839] Move the reviews related code to Koha::Reviews
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:16:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:16:37 +0000
Subject: [Koha-bugs] [Bug 19829] New: OPAC Search Limit by Branch bringing
 up records where the home library only has a missing copy
Message-ID: <bug-19829-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19829

            Bug ID: 19829
           Summary: OPAC Search Limit by Branch bringing up records where
                    the home library only has a missing copy
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lisetteslatah at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When doing a search and limiting by branch using the 'Home Library' section on
the left had side of the search results page, some records that belong to that
home library but are marked as lost or damaged or are staff use copies (all of
which are invisible to patrons in the opac) will still come up in the search
results even when limiting to currently available items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:29:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:29:22 +0000
Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->checkouts method
In-Reply-To: <bug-17584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17584-70-SWCPAr6LsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19830

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:29:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:29:22 +0000
Subject: [Koha-bugs] [Bug 19830] New: Add the Koha::Patron->old_checkout
	method
Message-ID: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

            Bug ID: 19830
           Summary: Add the Koha::Patron->old_checkout method
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:33:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:33:46 +0000
Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method
In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19830-70-pYU1hPI8pl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:33:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:33:51 +0000
Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method
In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19830-70-sFfwF5P22N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69859&action=edit
Bug 19830: Add the Koha::Patron->old_checkouts method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:36:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:36:09 +0000
Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method
In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19830-70-PFGAOISA0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19599


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599
[Bug 19599] anonymise_issue_history can be very slow on large systems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:36:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:36:15 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-wizMS9RXpD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69778|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69860&action=edit
Bug 19599: Speed anonymise_issue_history up

The query generated by anonymise_issue_history is unecessary complex and
can be very slow on large DB.
With this patch we will execute one query per patron instead.

See patch "Bug 19599: Simplify the query" on the bug report for an
alternative.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:36:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:36:09 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-0Q0JaHo6VB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19830


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830
[Bug 19830] Add the Koha::Patron->old_checkout method
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:36:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:36:54 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-yLK7pPVdPD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have moved the code creating Koha::Patron->old_checkouts to its own bug
report (bug 19830).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:48:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:48:30 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-0fBjQFsbZ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69861&action=edit
Bug 19759: Fix failing test in Chargelostitem.t

t/db_dependent/Circulation/Chargelostitem.t .. 1/6
 #   Failed test 'The accountline amount should be precessfee value '
 #   at t/db_dependent/Circulation/Chargelostitem.t line 71.
 #          got: '4.5968041848873e+20'
 #     expected: '459680418488730451968.00'

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 18:49:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 17:49:12 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-Cpeosd68fH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last patch pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 19:11:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 18:11:30 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-wTiRGMXPOC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This change broke 3 tests:
https://jenkins.koha-community.org/job/Koha_16.11_D8/lastCompletedBuild/testReport/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 20:36:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 19:36:07 +0000
Subject: [Koha-bugs] [Bug 16821] Facets: home libraries, locations,
	item types
In-Reply-To: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16821-70-sPhVD2Vici@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16821

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I guess you could always display, say, all item types, but we couldn't display
the number of records behind it then and also it would show item types that are
not part of the search result.

Would be interesting to get some idea how well this works with Elastic at the
moment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 22:42:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 21:42:20 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-k7Dnfr0cR2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #9 from sherryn <sherryn at catalyst.net.nz> ---
Created attachment 69862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69862&action=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 22:44:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 21:44:37 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-fRsp6LQegM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

sherryn <sherryn at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sherryn at catalyst.net.nz
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 22:44:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 21:44:50 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-fJREXsJjx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36164|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 22:49:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 21:49:25 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-sXRooChtKZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 22:49:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 21:49:30 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-cjmJ3QziPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69862|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69863&action=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 22:51:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 21:51:59 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-O4x8YeG3vj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx for your first patch Sherryn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:15:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:15:21 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-MPmUkDDHRh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

--- Comment #2 from isabel <isabel.grubi at gmail.com> ---
Created attachment 69864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69864&action=edit
Bug 18313: remove delicious link on social networks

To test:
1/ enable social networkds systems preference
2/ look at any record on the OPAC, notice it has a link to delicious
3/ apply patch
4/ refersh page on OPAC, noitce delicious link has gone

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:15:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:15:56 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-4oktHDevXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

isabel <isabel.grubi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |isabel.grubi at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:18:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:18:59 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-2scgZzF8tv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:19:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:19:03 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-dBQIOrCL8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69864|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69865&action=edit
Bug 18313: remove delicious link on social networks

To test:
1/ enable social networkds systems preference
2/ look at any record on the OPAC, notice it has a link to delicious
3/ apply patch
4/ refersh page on OPAC, noitce delicious link has gone

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:19:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:19:40 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-BSQ8UIrzqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Isabel, thx for your first patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:24:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:24:13 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-YvTQaY258M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Chris Weeks <chrisweeks at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:24:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:24:15 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-VzprAOMc0g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

--- Comment #1 from Chris Weeks <chrisweeks at catalyst.net.nz> ---
Created attachment 69866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69866&action=edit
Bug 19510: Add description for edi_manage in acquistion permissions

Test Plan:
1/ Login
2/ Select patrons
3/ Search for a patron by name or card number that exists in the system
4/ Click More -> Set permissions
5/ Expand 'acquistions' and notice that 'edi_manage' has no description
6/ Apply patch
7/ Refresh the permissions page or repeat steps 2 to 5.
8/ Notice that 'edi_manage' now has a description of 'Manage EDIFACT
transmissions'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:33:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:33:34 +0000
Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches
 for authority links on a Z39.50 server.
In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11300-70-6h2ZeklTlN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 69204
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69204
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

Review of attachment 69204:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11300&attachment=69204)
-----------------------------------------------------------------

Hi Bouzid, did you attach the most recent patch? This one is not using
Modern::Perl as you said in your last comment?

I have taken another look at the code, some are questions:

::: C4/Linker/Z3950Server.pm
@@ +1,1 @@
> +package C4::Linker::Z3950Server;

I am not sure about adding a new module to the C4 namespace at this point in
time, as we have been busy moving things into the new Koha namespace. This
might be something to check with the Release Manager. It might be ok because of
the relationship with C4::Linker.

@@ +15,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +use strict;
> +use warnings;

You should always use Modern::Perl instead of use strict; use warnings;

@@ +121,5 @@
> +  ($authid, $record, $status) = $self->getZ3950Authority($heading);
> +
> +  Do a Z39.50 search for the heading using the $conn ZOOM::Connection object and the $heading Heading.
> +  The column origincode is used to check for duplicates.
> +  FIXME: Use thesaurus in search? As of Koha 3.8, the community stopped using them.

What's this comment referring to?

@@ +167,5 @@
> +    }
> +    my $query;
> +    if ($heading->{'auth_type'} eq 'PERSO_NAME' ){
> +         $query =qq(Personal-name,do-not-truncate,ext="$heading->{'search_form'}");
> +    }elsif ($heading->{'auth_type'}  eq 'UNIF_TITLE' ) {

I am not sure if these are universal or only specific to MARC21. :(

@@ +214,5 @@
> +        my $authtypecode = C4::AuthoritiesMarc::GuessAuthTypeCode($record);
> +        my $authId;
> +
> +        # Use the control number to prevent the creation of duplicate authorities.
> +        my $controlNumber = $record->field('970')->subfield('0');

What is 970? I checked authority frameworks and bibliograpic frameworks but
it's defined in neither?

@@ +225,5 @@
> +        # Corrections and verifications before insertion
> +        my $format;
> +        my $leader='     nz  a22     o  4500';# Leader for incomplete MARC21 record
> +
> +        if (uc(C4::Context->preference('marcflavour')) eq 'UNIMARC') {

No need for uc() here I think.

@@ +238,5 @@
> +                $record->leader($leader);
> +            }
> +            if (!$record->field('003')) {
> +                $record->insert_fields_ordered(
> +                        MARC::Field->new('003',C4::Context->preference('MARCOrgCode'))

I think this needs to be adjusted - as of 17.11 the MARCOrgCode can also be set
on library level.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:35:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:35:34 +0000
Subject: [Koha-bugs] [Bug 13715] "limit to items available" hides records
 with multiple items where 1 is not available (checked out) but others are
In-Reply-To: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13715-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13715-70-ENFFUAHotD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree that the availability filter is problematic, but I am not sure someone
is willing to invest time in this, you might want to consider funding a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:37:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:37:56 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-4rlesL9u1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:37:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:37:59 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-glopl81Nfn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69866|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69867&action=edit
Bug 19510: Add description for edi_manage in acquistion permissions

Test Plan:
1/ Login
2/ Select patrons
3/ Search for a patron by name or card number that exists in the system
4/ Click More -> Set permissions
5/ Expand 'acquistions' and notice that 'edi_manage' has no description
6/ Apply patch
7/ Refresh the permissions page or repeat steps 2 to 5.
8/ Notice that 'edi_manage' now has a description of 'Manage EDIFACT
transmissions'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=19519

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:38:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:38:38 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-x5ygrKxEGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Chris! 


I really need to sleep now... :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:45:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:45:45 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-6HN8oL8zQO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

--- Comment #1 from Jessica <jessicafreeman at catalyst.net.nz> ---
Created attachment 69868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69868&action=edit
Bug: 19714 - Removing 2 occurrences of memberofinstitution To Test: 1/grep for
memberofinstitution 2/Notice it occurs in C4/UsageStats.pm and
t/db_dependent/UsageStats.t 3/grep again, notice they have been removed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:47:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:47:17 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-QSifjRBICd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

--- Comment #2 from Jessica <jessicafreeman at catalyst.net.nz> ---
Created attachment 69869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69869&action=edit
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:48:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:48:10 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-94yY39vsqF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Jessica <jessicafreeman at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jessicafreeman at catalyst.net
                   |                            |.nz
  Attachment #69868|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:48:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:48:28 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-ctshG1Icqt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Jessica <jessicafreeman at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:49:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:49:58 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-tImn0UXPjf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

--- Comment #1 from priya.patel at catalyst.net.nz ---
Created attachment 69870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69870&action=edit
Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile

To test:
1/ Grep to find OpacShowLibrariesPullDownMobile
2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm:
3/ Apply patch
4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2
files

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:50:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:50:26 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-Z55VfwsV8r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

priya.patel at catalyst.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |priya.patel at catalyst.net.nz
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:51:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:51:24 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-TyWwu2ae7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

--- Comment #1 from Bonnie Crawford <bonniecrawford at catalyst.net.nz> ---
Created attachment 69871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69871&action=edit
Bug 18819: "UNIMARC is used in Europe" text changed to "UNIMARC is used in a
few European countries"

To test
1/ run installer and notice the inaccurate text "UNIMARC is used in Europe"
2/ run the patch attached
3/ run the installer and notice that the updated text "UNIMARC is used in a few
European countries"is now present

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 18 23:51:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 22:51:58 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-4m49Lpugc2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Bonnie Crawford <bonniecrawford at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |bonniecrawford at catalyst.net
                   |                            |.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 00:13:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 23:13:32 +0000
Subject: [Koha-bugs] [Bug 19829] OPAC Search Limit by Branch bringing up
 records where the home library only has a missing copy
In-Reply-To: <bug-19829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19829-70-kvK8AZqiUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19829

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 00:36:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 18 Dec 2017 23:36:29 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-drnMox9HV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Jonathan Druart from comment #10)
> This change broke 3 tests:
> https://jenkins.koha-community.org/job/Koha_16.11_D8/lastCompletedBuild/
> testReport/

Yup, the tests are wrong so they should break. I'll fix them this afternoon ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:32:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:32:36 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-zhdFvqfM9Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69411|0                           |1
        is obsolete|                            |

--- Comment #45 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69872&action=edit
Bug 19532: Nice message if no recalls for opac recalls history

https://bugs.koha-community.org/show_bug.cgi?id=19523

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:33:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:33:31 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-jIz5u65KUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69841|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:01 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-gYJB5dz1JF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68653|0                           |1
        is obsolete|                            |

--- Comment #46 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69873&action=edit
Bug 19532: Circulation rules

Adding 3 new rules and columns to issuingrules
- recall_due_date_interval
- recall_overdue_fine
- recall_shelf_time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:07 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-zDhbB9qtkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69100|0                           |1
        is obsolete|                            |

--- Comment #47 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69874&action=edit
Bug 19532: Recall an item in OPAC

This patch:
  - adds the 'Recall' button to the item on it's detail page
  - adds ability to place a recall
  - the recall is stored in the recalls table
  - the due date for the checkout is updated to whatever has been set in
  the issuing rule under recall_due_date_interval
  - error messages for if the user isn't logged in, the user tries to
  place a recall on an item they have already recalled, or if storing
  the recall in the db fails for any reason

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:14 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-nF2DyBxTpo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69102|0                           |1
        is obsolete|                            |

--- Comment #48 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69875&action=edit
Bug 19532: Cancel recall and see recalls in OPAC

This patch adds ability for user to cancel a recall
They can also see their recalls in the user summary

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:20 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-ZfPY7uv1jk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69147|0                           |1
        is obsolete|                            |

--- Comment #49 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69876&action=edit
Bug 19532: Show recalls on intranet side

This patch
- adds Recall tab to the Check out section of member account, and to the
Details section of member account
- Functionality to cancel recalls on staff side
- Fixing cancel on OPAC side (before I was deleting the whole recall
instead of cancelling)
- Fixing validation when checking whether a recall can be placed on an
item that has been recalled by this borrower before. If the old recall
is expired or cancelled then they can make a recall again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:26 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-R9wDfwZEQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69148|0                           |1
        is obsolete|                            |

--- Comment #50 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69877&action=edit
Bug 19532: Fixing broken OPAC recalls table

Forgot to add <tr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:32 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-C1lp85PUK4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69149|0                           |1
        is obsolete|                            |

--- Comment #51 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69878&action=edit
Bug 19532: recalls history

this patch
- adds recalls history (similar to holds history) to OPAC and intranet
- edits the tables in opac-user.pl (OPAC), moremember.pl and
circulation.pl (staff) so that it only shows active recalls (recalls
that have been requested or are waiting)
- some extra datatables fixes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:38 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-noWvO9QWhH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69170|0                           |1
        is obsolete|                            |

--- Comment #52 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69879&action=edit
Bug 19532: Recalls queue

This patch adds a recalls queue page to the circulation reports

You can see all recalls made in the system, who requested them, their
status and other relevant info. you can cancel individual or multiple
recalls.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:46 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-m39psobyHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69172|0                           |1
        is obsolete|                            |

--- Comment #53 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69880&action=edit
Bug 19532: Overdue recalls report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:52 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-Ti0h4wm1P9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69221|0                           |1
        is obsolete|                            |

--- Comment #54 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69881&action=edit
Bug 19532: Recalls awaiting pickup report

this patch adds reports for all recalls awaiting pickup, and recalls
that have been waiting more than X days. a syspref,
RecallsMaxPickUpDelay, is added to give a general max shelf time for
recalls

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:44:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:44:58 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-lKMLE7yBNy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69222|0                           |1
        is obsolete|                            |

--- Comment #55 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69882&action=edit
Bug 19532: Only recall items checked out by other users

... shouldn't be able to recall items that are currently checked out by
yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:03 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-RxBdNYrocc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69223|0                           |1
        is obsolete|                            |

--- Comment #56 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69883&action=edit
Bug 19532: UseRecalls syspref

This patch adds a syspref to control the usability of the recalls
feature

Test the following:

Staff side
/includes/circ-menu.inc
/includes/circ-nav.inc
/includes/members-menu.inc
/admin/preferences/circulation.pref
/circ/circulation-home.tt
/circ/circulation.tt
/circ/recalls_overdue.tt
/circ/recalls_queue.tt
/circ/recalls_waiting.tt
/members/moremember.tt
/members/recallshistory.tt

OPAC
/includes/usermenu.inc
/opac-recall.tt
/opac-recalls.tt
/opac-user.tt
/members/recallshistory.pl
/opac/opac-detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:09 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-BgldQ53Lv8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69322|0                           |1
        is obsolete|                            |

--- Comment #57 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69884&action=edit
Bug 19532: Recall pop up when checking in an item

When checking in an item on the staff side, the staff member will see a
pop up if there is a recall attached to that item. From here, they can
confirm the recall, setting the status to 'Waiting' and updating the
waitingdate. The item will still be checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:15 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-TvYsEBVErd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69353|0                           |1
        is obsolete|                            |

--- Comment #58 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69885&action=edit
Bug 19532: Send notice to user to return a recalled item

When the recall is placed in the OPAC, a RETURN_RECALLED_ITEM notice is
sent to the user who has the item checked out, with the updated due
date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:20 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-bRA32ae6On@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69354|0                           |1
        is obsolete|                            |

--- Comment #59 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69886&action=edit
Bug 19532: Send notice to user to pickup recalled returned item

Send a PICKUP_RECALLED_ITEM notice to the user who requested a recall
when the item is checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:25 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-fSdGRBhecd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69405|0                           |1
        is obsolete|                            |

--- Comment #60 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69887&action=edit
Bug 19532: Flagging recall as 'old' when expired or cancelled

Set 'old' flag to 1 if cancelling or expiring a recall

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:30 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-H9sIZXGiie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69409|0                           |1
        is obsolete|                            |

--- Comment #61 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69888&action=edit
Bug 19532: Cronjob to check for overdue recalls

This patch adds a check to the overdue_notices cronjob, so if any of the
overdue issues are also recalls, the status will be set to O (overdue)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:36 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-fNpU2lSgvo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69410|0                           |1
        is obsolete|                            |

--- Comment #62 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69889&action=edit
Bug 19532: Tests for Koha/Recalls

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:45:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:45:44 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-5V9vUwa956@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69872|0                           |1
        is obsolete|                            |

--- Comment #63 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69890&action=edit
Bug 19532: Nice message if no recalls for opac recalls history

https://bugs.koha-community.org/show_bug.cgi?id=19523

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 02:49:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 01:49:03 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-2NKxljDjsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #64 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Sorry for the gazillions of emails! This should now apply cleanly on master.
I should've added in the original test plan to update the database and the
schema after applying patches, so make sure you do that first! Here's the test
plan again.

TEST PLAN:

0. Update database and schema
1. Enable the UseRecalls syspref
2. Go to Circulation and Fines Rules. Put some numbers in the recalls fields
(recall due date interval, recall overdue fine amount, recall pickup period)
3. Put a number in the RecallsMaxPickUpDelay syspref. This will be the default
number of days used if the recall pickup period isn't set in Step 2
4. Check out an item to a patron
5. Go to that item's detail page in the OPAC. Notice the holdings table says
'Checked out'
6. Log in to the OPAC with another patron and go back to that detail page. The
holdings table should now have a Recall link next to the 'Checked out' text
7. Click the Recall button and confirm the Recall
8. Go to the user's opac summary and confirm there is now a Recalls tab, with
the correct number of recalls (should be 1).
9. Test cancelling the recall by clicking Cancel. Confirm the recall has been
cancelled. Repeat steps 6 and 7.
10. In the left navigation, there will also be a 'recalls history' tab. Click
it. There should be a log, similar to reading history, with the cancelled
recall and the new recall in it. Confirm all information is correct
11. Again, test cancelling the recall. Repeat steps 6 and 7.
12. In the staff interface, go to the logged in user's checkouts. Confirm you
can see a new Recalls tab, with the active (not cancelled) recall in the table.
Should be the same for the details tab also.
13. Test cancelling works for both of these again, and making new recalls
again.
14. Check in the recalled item. You should see a pop up, asking to confirm the
recall as waiting. Click confirm.
15. Go to the Circulation main page. You should see 3 new reports: recalls
queue, overdue recalls and recalls awaiting pickup
16. Go to the recalls queue, confirm you can see an entire history of recalls
at your library. Confirm cancel works when selecting checkboxes and clicking
the multiple button. If you do this, you'll need to place the recall again and
check the item in again
17. Go to recalls awaiting pickup. You should see the recall under the recalls
waiting tab
18. in Mysql, set the waitingdate for your recall to be more than 'recall
pickup period' days before today's date
19. Refresh the recalls awaiting pickup page. You should see the recall under
the recalls waiting tab, and the recalls waiting more than X days tab.
20. expire the recall. confirm this is expired by checking the recalls queue
21. place another recall, but do not check it in
22. in mysql, set the date_due of the checkout (issues table) to be at least
'recall due date interval' number of days before today's date
23. run the overdue_notices.pl cronjob
24. go to the overdue recalls circ report and confirm your recall shows there
25. try cancelling the recall here also
26. in mysql, check the message_queue and confirm there have been the
appropriate number of RETURN_RECALLED_ITEM and PICKUP_RECALLED_ITEM notices
sent with the correct to and from addresses and other content
27. test t/db_dependent/Koha/Recalls.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 03:45:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 02:45:41 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-nZvW05vVxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 03:45:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 02:45:45 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-sJGhMVUZdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69849|0                           |1
        is obsolete|                            |

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69891&action=edit
[SIGNED-OFF] Bug 19826: Add K::Acq::Budget(s) and K::Acq::Budget::Fund(s)

This patch introduces Koha::Object(s)-derived classes for budgets and funds
(aqbudgetperiods and aqbudgets respectively).

C4::Budgets already uses DBIC calls on those tables so transition should be
easy on top of this.

To test:
- Check the referenced schema files are the right ones.
- QA scripts shoudl be happy.
- Sign off :-D

Note: the POD coverage report throws a false negative result on singular
classes which is trivially wrong.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 04:08:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 03:08:28 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-wYxX6N6ChU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
                 CC|                            |aleisha at catalyst.net.nz
             Status|RESOLVED                    |REOPENED

--- Comment #78 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
This commit 01fbe2be9925f8586b9a2cb4dc908fc856b672a8 (Bug 10306: Core module
changes for multiple mappings) is breaking a bunch of things for me. A few
examples:

/cgi-bin/koha/opac-user.pl - when trying to see OPAC user summary, I get
internal server error: Not an ARRAY reference at
/home/vagrant/kohaclone/C4/Biblio.pm line 1124
/cgi-bin/koha/acqui/neworderbiblio.pl - when trying to add an order to a basket
from an existing record, I get
internal server error: Not an ARRAY reference at
/home/vagrant/kohaclone/C4/Biblio.pm line 2667

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 04:08:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 03:08:31 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-vEJDaUnlba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Bug 19096 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 04:08:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 03:08:31 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-ZhPtraoiIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
Bug 19594 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 04:08:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 03:08:30 +0000
Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha
In-Reply-To: <bug-10344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10344-70-wGGOvhatLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344
Bug 10344 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 07:56:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 06:56:40 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-ymHPrzUg0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 07:56:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 06:56:44 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-FEpfYvGaeU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69871|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69892&action=edit
Bug 18819: "UNIMARC is used in Europe" text changed to "UNIMARC is used in a
few European countries"

To test
1/ run installer and notice the inaccurate text "UNIMARC is used in Europe"
2/ run the patch attached
3/ run the installer and notice that the updated text "UNIMARC is used in a few
European countries"is now present

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 07:58:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 06:58:44 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-zzCycao21Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 07:58:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 06:58:48 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-8qkRV4fDuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69870|0                           |1
        is obsolete|                            |

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69893&action=edit
Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile

To test:
1/ Grep to find OpacShowLibrariesPullDownMobile
2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm:
3/ Apply patch
4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2
files

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 07:59:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 06:59:26 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-ICVaV6UCYL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Priya!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:08:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:08:25 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-klojqOfX46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:08:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:08:28 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-x6J7DlTWEM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69869|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69894&action=edit
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:08:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:08:47 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-B1ADC45efS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you, Jessica!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:09:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:09:24 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-kvHClhvJ7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thank you, Bonnie!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:12:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:12:52 +0000
Subject: [Koha-bugs] [Bug 19831] New: Turn on EnhancedMessagingPreferences
 by default for new installations
Message-ID: <bug-19831-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19831

            Bug ID: 19831
           Summary: Turn on EnhancedMessagingPreferences by default for
                    new installations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I think we should not hide the different messaging options for new
installations and turn on EnhancedMessagingPreferences by default on
installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:15:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:15:34 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-b56cW7NeBB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marjorie Barry-Vila from comment #10)
> Hi,
> 
> I repeat this problem on 16.11
> 
> Test plan:
> 
> - in notice HOLD (/tools/letter.pl), write text in Print tab, save
> - check in table message_transports that line for HOLD are present (select *
> from message_transports)
> - in notice HOLD, supress text in Print tab, save
> - check in table message_transport that lines for HOLD are missing and in
> Patron messaging Preferences, there is a "-" where check box should appear
> 
> Regards
> Marjorie

Hi Marjorie,

I have tried to replicate the problem following your test plan, but it didn't
work for me on master. After emptying out the print section of the HOLD
template, the checkboxes still appear normally for me.
Maybe this is specific to 16.11, but can't test there right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:26:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:26:51 +0000
Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785
In-Reply-To: <bug-15437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15437-70-WVAUfYPrlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to J Schmidt from comment #7)
> -Used Sandbox1 (ByWater)
> -Koha Admin > MARC Bibliographic framework > Default framework > Actions >
> MARC Structure.
> -780 > Actions > Subfields. 
> -Found subfield i > clicked on Edit.
> -Expanded advanced constraints > checkmarked the Editor box > clicked Save
> changes. Noticed in the area that the 780$a is hidden..... Hmmm. Left it
> alone.
> -Go to 785 and repeat this same step with Save changes....
> Go to Koha Admin > MARC bibliographic framework test. Click that. System
> says test is OK.
> -Koha > Search the catalog > Didn't find any records.
> -Went to Koha > cataloging > New from z39.50 search for vogue and ISSN:
> 0042-8000. Import the record with the LCCN of 08036997. Save MARC record
> into Koha.
> add in 942-
> -Prompted me to add a new item record so I did that. Saved.
> -Went back to Edit bib record > Simple editor. Record number 439. 
> -Went to the 780 field and was able to add in and save a subfield i
> information. 
> -Saved the bib and was able to click SHOW MARC to see the subfield i
> information.
> -Went to Edit bib to repeat and fill in subfield i of the 785. Saved the bib
> again and was able to click SHOW MARC to see the subfield i information.
> 
> I would save this passes and can be signed off off.

Thx for testing! The MARC view will always work as it's generated from the
visibility settings you make for your frameworks. For this patch, you need to
take a look at the intranet detail page (normal view). 

I will try and find some examples for $i use in our union catalog.

Note: we should try and keep the existing patches, but add some to fix the OPAC
detail page as well!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 08:32:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 07:32:12 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-8OCV7ieJ7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #54 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, want to retest and try to push this through QA, can you please
rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 09:18:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 08:18:55 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-rl65Mf6ppr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
My times:

Before:
real    0m16.295s
user    0m11.076s
sys     0m1.656s

After patch:
real    0m8.858s
user    0m6.044s
sys     0m0.824s

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:04:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:04:50 +0000
Subject: [Koha-bugs] [Bug 19832] New: SIP checkout removes extra hold on
	same biblio
Message-ID: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

            Bug ID: 19832
           Summary: SIP checkout removes extra hold on same biblio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: boutrosboutrosboutros at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

C4/SIP/ILS/Transaction/Checkout.pm includes the following bit of code which
remove any hold that that matches the biblio and bilbionumber in checkout:

# Fill any reserves the patron had on the item.  
    # TODO: this logic should be pulled internal to AddIssue for all Koha. 
    $debug and warn "pending_queue: " . (@$pending) ? Dumper($pending) : '[]';
    foreach (grep {$_->{borrowernumber} eq $self->{patron}->{borrowernumber}}
@$pending) {
        $debug and warn "Filling reserve
(borrowernumber,biblionumber,reservedate): "
            .
sprintf("(%s,%s,%s)\n",$_->{borrowernumber},$_->{biblionumber},$_->{reservedate});
        ModReserveFill($_);
        # TODO: adjust representation in $self->item
    }


As far as I can tell, this code is completely unnecessary, since
C4::Circulation::AddIssue allread calls C4::Reserves::MoveReserve which
fullfills the hold. What's more, if the borrower has multiple holds on the same
biblio, all of them will be removed. This is clearly wrong.

I purpose to remove the code above, unless someone can explain why SIP checkout
should behave different than normal checkout in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:23:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:23:25 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-5Vofg0FPMJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:23:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:23:28 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-A3Uhbmk16G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69893|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69896&action=edit
Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile

To test:
1/ Grep to find OpacShowLibrariesPullDownMobile
2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm:
3/ Apply patch
4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2
files

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:23:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:23:47 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-uW8s5LzmAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:24:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:24:47 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-fnYWJw45la@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bonniecrawford at catalyst.net
                   |ity.org                     |.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:25:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:25:20 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-rHgzvSjVUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |priya.patel at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:16:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:16:19 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-0afgP0rtlR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:15:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:15:51 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-460p1WJwZO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:15:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:15:54 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-I6z9LV0tih@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69892|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69895&action=edit
Bug 18819: "UNIMARC is used in Europe" text changed to "UNIMARC is used in a
few European countries"

To test
1/ run installer and notice the inaccurate text "UNIMARC is used in Europe"
2/ run the patch attached
3/ run the installer and notice that the updated text "UNIMARC is used in a few
European countries"is now present

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:29:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:29:19 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-CN54uM51YF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:29:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:29:22 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-k5nhDM0aqE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69894|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69897&action=edit
Bug: 19714 - Removing 2 occurrences of memberofinstitution

To Test:
1/grep for memberofinstitution
2/Notice it occurs in C4/UsageStats.pm and t/db_dependent/UsageStats.t
3/grep again, notice they have been removed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:30:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:30:40 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-lWK3OAlvyB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
           Assignee|koha-bugs at lists.koha-commun |jessicafreeman at catalyst.net
                   |ity.org                     |.nz
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:35:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:35:51 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-bdWADFPmzN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:35:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:35:53 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-4CH0IWYp68@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69867|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69898&action=edit
Bug 19510: Add description for edi_manage in acquistion permissions

Test Plan:
1/ Login
2/ Select patrons
3/ Search for a patron by name or card number that exists in the system
4/ Click More -> Set permissions
5/ Expand 'acquistions' and notice that 'edi_manage' has no description
6/ Apply patch
7/ Refresh the permissions page or repeat steps 2 to 5.
8/ Notice that 'edi_manage' now has a description of 'Manage EDIFACT
transmissions'

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:36:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:36:32 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-rVAuSJViA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com
   Patch complexity|Trivial patch               |String patch
           Severity|enhancement                 |trivial
           Assignee|koha-bugs at lists.koha-commun |chrisweeks at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:40:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:40:25 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-u9YO9yVdTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:40:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:40:30 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-VHplvNj4gQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69865|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69899&action=edit
Bug 18313: remove delicious link on social networks

To test:
1/ enable social networkds systems preference
2/ look at any record on the OPAC, notice it has a link to delicious
3/ apply patch
4/ refersh page on OPAC, noitce delicious link has gone

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:40:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:40:56 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-pG0PJpS67z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
           Assignee|oleonard at myacpl.org         |isabel.grubi at gmail.com
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:48:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:48:18 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-DnKt9T0NJP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:48:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:48:22 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-q5UGKRU94G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69863|0                           |1
        is obsolete|                            |

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69900&action=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:48:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:48:54 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-xWZnhgxxqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
           Assignee|veron at veron.ch              |sherryn at catalyst.net.nz
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:53:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:53:23 +0000
Subject: [Koha-bugs] [Bug 19833] New: Kill the "biblios"
Message-ID: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833

            Bug ID: 19833
           Summary: Kill the "biblios"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org

For bibliographic record we use three string variants:
- biblio
- biblio record
- biblliographic record

According to our terminology we should always use "bibliographic record", we
should modify it in all templates.

https://wiki.koha-community.org/wiki/Terminology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:53:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:53:51 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-egj4iGLmxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19833

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 10:53:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 09:53:51 +0000
Subject: [Koha-bugs] [Bug 19833] Kill the "biblios"
In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19833-70-aBVFQs0aQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13676

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 11:02:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 10:02:33 +0000
Subject: [Koha-bugs] [Bug 19833] Kill the "biblios"
In-Reply-To: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19833-70-SJNbW4ufiY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19833

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 11:19:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 10:19:32 +0000
Subject: [Koha-bugs] [Bug 10584] Hide OPAC biblio details if all items are
	hidden.
In-Reply-To: <bug-10584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10584-70-Ta415pZo7k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584

Jens Weber <jens.weber at phsh.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Hide OPAC bibilo details if |Hide OPAC biblio details if
                   |all items are hidden.       |all items are hidden.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 11:31:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 10:31:28 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-s3l4cvpj2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tested on 16.11.13.000, still not able to confirm :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 11:45:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 10:45:22 +0000
Subject: [Koha-bugs] [Bug 19834] New: jy
Message-ID: <bug-19834-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19834

            Bug ID: 19834
           Summary: jy
 Change sponsored?: ---
           Product: Project Infrastructure
           Version: unspecified
          Hardware: Other
                OS: Mac OS
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hea
          Assignee: chris at bigballofwax.co.nz
          Reporter: maskopek4 at gmail.com
        QA Contact: jonathan.druart at bugs.koha-community.org

Created attachment 69901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69901&action=edit
for u

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 12:04:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 11:04:27 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-GsHKSWiiTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59314|0                           |1
        is obsolete|                            |
  Attachment #59315|0                           |1
        is obsolete|                            |
  Attachment #59316|0                           |1
        is obsolete|                            |
  Attachment #59317|0                           |1
        is obsolete|                            |
  Attachment #59318|0                           |1
        is obsolete|                            |

--- Comment #59 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69902&action=edit
Bug 15516: Allow to reserve first available item from a group of titles

It can be useful, for instance, if a library have the same title from
different publishers (so 1 title but several biblio records) but the
user only wants a copy of the book, regardless of the publisher.

This patch is only for staff interface.

Test plan:
0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl
1. Go to intranet search, display some results, click on some checkboxes
   and click on 'Place hold' button at the top of the results.
2. Enter a patron cardnumber and click Search
3. Check the box for 'Place a hold on the next available item' (it's
   usually hidden when placing a hold on multiple biblios)
4. Click on 'Place hold'
5. In the next screen you should see all the holds you placed with the
   additional text '(part of a reserve group)' in Details column.
6. Click on the "reserve group" link. A modal window should appear with
   the content of the reserve group (a list of holds)
7. Check in an item of one of the reserved biblios and confirm the hold
8. The hold status is changed to Waiting, and all other holds are
   deleted.

Note: the "reserve group" link is displayed in the following pages:
- reserve/request.pl
- circ/circulation.pl
- members/moremember.pl
- circ/pendingreserves.pl

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 12:04:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 11:04:33 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-vxmvcLQJ8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #60 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69903&action=edit
Bug 15516 - Holding first available item from x biblios only count 1 reserve

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 12:04:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 11:04:37 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-TwEAtHmW20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #61 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69904&action=edit
Bug 15516: Update old_reserves (reserve_group_id)

Without it, deletion of reserves will fail

Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 12:04:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 11:04:42 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-7wUl0pH7Xa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #62 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69905&action=edit
Bug 15516: Set reserve-group.pl to be executable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 12:04:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 11:04:47 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-gAvSr0jw1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #63 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 69906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69906&action=edit
Bug 15516: Reword 'reserve group' to 'hold group'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 12:09:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 11:09:41 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from
 a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-1xCz1emDNU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #64 from Josef Moravec <josef.moravec at gmail.com> ---
I did a rebase, the feature is not working now, but applies cleanly and I plan
to continue on it during Christmas I hope. Changes to C4/Reserves.pm should be
moved to objects and many more. The codebase changed too much since the patches
were uploaded, but they are still good start to work on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:01:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:01:14 +0000
Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785
In-Reply-To: <bug-15437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15437-70-lnEQwjHbvf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Some examples from one of our bigger databases. Some of these stem from the
national serials database.


  <datafield tag="780" ind1="0" ind2="0">
    <subfield code="i">2002 darin aufgeg.</subfield>
    <subfield code="a">Der Urologe</subfield>
    <subfield code="w">074754351</subfield>

  <datafield tag="780" ind1="0" ind2="0">
    <subfield code="i">Bis Erg.-Lfg. 12 (1998) u.d.T.</subfield>
    <subfield code="a">++Kommentar zur Europ?ischen Union</subfield>

  <datafield tag="780" ind1="0" ind2="0">
    <subfield code="i">1. Aufl. u.d.T.</subfield>
    <subfield code="a">Kindler, Wolfgang, 1948</subfield>
    <subfield code="t">Man muss kein Held sein - aber...!</subfield>
    <subfield code="w">253671345</subfield>
  </datafield>

  <datafield tag="780" ind1="0" ind2="0">
    <subfield code="i">1984-1985 u.d.T.</subfield>
    <subfield code="t">Arbeiten und Lernen - Die Berufsbildung</subfield>
  </datafield>

  <datafield tag="785" ind1="0" ind2="0">
    <subfield code="i">12.1978 - 15.1981</subfield>
    <subfield code="a">Social science &amp; medicine. Part C, Medical
economics</subfield>
    <subfield code="w">263809072</subfield>
  </datafield>
  <datafield tag="785" ind1="0" ind2="0">
    <subfield code="i">12.1978 -15.1981</subfield>
    <subfield code="a">Social science &amp; medicine. Part D, Medical
geography</subfield>
    <subfield code="w">263809080</subfield>
  </datafield>
  <datafield tag="785" ind1="0" ind2="0">
    <subfield code="i">15.1981</subfield>
    <subfield code="a">Social science &amp; medicine. Part E, Medical
psychology</subfield>
    <subfield code="w">263809099</subfield>
  </datafield>


It seems that $i could be almost used as a replacement for the standard label
in some of these cases as it contains additional information like the time when
something was absorbed, divided, changed etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:04:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:04:32 +0000
Subject: [Koha-bugs] [Bug 19835] New: Update MARC frameworks to Updates 24 +
 25 ( May and December 2017)
Message-ID: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

            Bug ID: 19835
           Summary: Update MARC frameworks to Updates 24 + 25 (May and
                    December 2017)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

We should update our frameworks to reflect changes made with the last 2 MARC 21
updates:

http://www.loc.gov/marc/status.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:15:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:15:00 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-PaYCc3q04S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

--- Comment #79 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Aleisha Amohia from comment #78)
> This commit 01fbe2be9925f8586b9a2cb4dc908fc856b672a8 (Bug 10306: Core module
> changes for multiple mappings) is breaking a bunch of things for me. A few
> examples:
> 
> /cgi-bin/koha/opac-user.pl - when trying to see OPAC user summary, I get
> internal server error: Not an ARRAY reference at
> /home/vagrant/kohaclone/C4/Biblio.pm line 1124
> /cgi-bin/koha/acqui/neworderbiblio.pl - when trying to add an order to a
> basket from an existing record, I get
> internal server error: Not an ARRAY reference at
> /home/vagrant/kohaclone/C4/Biblio.pm line 2667

Are you sure?
Please restart Plack and - in this case important - flush the cache. The cache
might contain some constructs that have been outdated in view of this patch. A
regular upgrade should include restarting Plack and flashing the cache too.

Note that the line number 1124 does refer to a POD line in the current module.
This may be an indication of the above.

Please report back if this resolved the problem. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:15:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:15:14 +0000
Subject: [Koha-bugs] [Bug 19834] SPAM
In-Reply-To: <bug-19834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19834-70-8QY6D6PPRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19834

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|jy                          |SPAM
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
          Component|Hea                         |Architecture, internals,
                   |                            |and plumbing
         QA Contact|jonathan.druart at bugs.koha-c |testopia at bugs.koha-communit
                   |ommunity.org                |y.org
           Assignee|chris at bigballofwax.co.nz    |koha-bugs at lists.koha-commun
                   |                            |ity.org
            Product|Project Infrastructure      |Koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:17:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:17:04 +0000
Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect
 holidays, and everybody need to know the last pickup date for reserves,
 even notices.
In-Reply-To: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12353-70-lPfWx7JBqJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:17:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:17:44 +0000
Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect
 holidays, and everybody need to know the last pickup date for reserves,
 even notices.
In-Reply-To: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12353-70-Ph8JukW3I2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think the notices are ok, as the pick-up date is in reserves.expirationdate.
But we still need to fix the problem with the calendar.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:19:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:19:06 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-LvDCKVCv7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

--- Comment #80 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Aleisha Amohia from comment #78)
> /cgi-bin/koha/opac-user.pl - when trying to see OPAC user summary, I get
> internal server error: Not an ARRAY reference at
> /home/vagrant/kohaclone/C4/Biblio.pm line 1124

Cannot reproduce btw.

> /cgi-bin/koha/acqui/neworderbiblio.pl - when trying to add an order to a
> basket from an existing record, I get
> internal server error: Not an ARRAY reference at
> /home/vagrant/kohaclone/C4/Biblio.pm line 2667

Works for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:19:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:19:47 +0000
Subject: [Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same
	biblio
In-Reply-To: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19832-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19832-70-km5YVwfvqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:20:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:20:24 +0000
Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect
 holidays, and everybody need to know the last pickup date for reserves,
 even notices.
In-Reply-To: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12353-70-OVaNZ2OyLs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12063

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe this was fixed by bug 12063?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:20:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:20:24 +0000
Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve
 expiration to skip all holidays
In-Reply-To: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12063-70-bADcrePxsa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12353

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:22:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:22:20 +0000
Subject: [Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow
 multiple mappings per kohafield (for say 260/RDA 264)
In-Reply-To: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10306-70-hdUIgYTfLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:22:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:22:21 +0000
Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha
In-Reply-To: <bug-10344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10344-70-reXN45bNKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344
Bug 10344 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:22:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:22:22 +0000
Subject: [Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make
 Default authoritative
In-Reply-To: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19096-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19096-70-5Bq0kXSwvD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096
Bug 19096 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:22:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:22:22 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-Rk8qwGISRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
Bug 19594 depends on bug 10306, which changed state.

Bug 10306 Summary: Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:34:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:34:51 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-UO4RL8rJXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69857|0                           |1
        is obsolete|                            |

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69907&action=edit
Bug 19828: Unit tests

This patch introduces unit tests for the changes this bug introduces to
Koha::Object->store.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests should fail because the changes are not implemented on this
patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:34:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:34:57 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-YGmMQc2vuy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69858|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69908&action=edit
Bug 19828: Make Koha::Object->store translate DBIC exceptions into Koha
exceptions

This patch introduces a try/catch block in store() and parses the error
when an exceptional situation takes place.

It only deals with FK constraint violations and duplicate IDs. The rest of the
DBIC exceptions
are rethrown.

To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:35:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:35:38 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-GCjA2WNt3y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I added the duplicate key use case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:37:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:37:54 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-wDyA6NleGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Isabel, you did not specify your lastname in the commit message, is it
expected?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:37:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:37:46 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-jNL8th08OM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Sherryn, you did not specify your lastname in the commit message, is it
expected?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:38:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:38:13 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-B3ILI3AzP8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Priya, you did not specify your lastname in the commit message, is it expected?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:38:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:38:37 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-v0VGsS97mB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bonnie, you did not specify your lastname in the commit message, is it
expected?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 14:56:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 13:56:04 +0000
Subject: [Koha-bugs] [Bug 19836] New: Make it possible to change the last
 pick-up date manually
Message-ID: <bug-19836-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19836

            Bug ID: 19836
           Summary: Make it possible to change the last pick-up date
                    manually
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Sometimes a customer calls or sends an email that they are not able to come to
the library within the time calculated for pick-up. In these cases it would be
nice if it was possible to change/edit the last pick-up date from the staff
interface. 

The new date would then also show in the patron's account.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:13:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:13:58 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-6TRNtqwyv9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7736
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736
[Bug 7736] Edifact QUOTE and ORDER functionality
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:13:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:13:58 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-7cHy6lyx9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19510


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510
[Bug 19510] edi_manage permission has no description
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:17:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:17:28 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-12u264oPrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to master for 18.05.

Thanks Jessica and congrats for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:17:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:17:35 +0000
Subject: [Koha-bugs] [Bug 19714] 2 occurrences of memberofinstitution have
 not been removed
In-Reply-To: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19714-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19714-70-0zzoq7KPjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:17:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:17:10 +0000
Subject: [Koha-bugs] [Bug 19510] edi_manage permission has no description
In-Reply-To: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19510-70-UefZxjAJh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19510

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to master for 18.05.

Thanks Chris and congrats for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:30:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:30:53 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-NWdLnSFpdb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #384 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69909&action=edit
Bug 7143: Update about page for new dev - Chris Weeks

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:31:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:31:12 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-bq6hHJkXam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #385 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69910&action=edit
Bug 7143: Update about page for new dev - Jessica Freeman

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:32:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:32:08 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-nIy2cGdv3i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |Pushed to Master

--- Comment #386 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last two patches pushed to master for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:36:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:36:08 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-H9CugqcTgY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:36:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:36:11 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-M2nYylRcBY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69241|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69911&action=edit
Bug 19658: Style fix for staff client lists page

Patch applies with no issues and works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Edit: Rebased for 16.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:39:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:39:24 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-l7s9yqUt5H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tests are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:41:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:41:22 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-tB0qVSDftV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com
                   |                            |, katrin.fischer at bsz-bw.de,
                   |                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tom?s Cohen Arazi from comment #4)
> (In reply to Kyle M Hall from comment #2)
> > I think it would be better to use Koha::Acquisition::Budgets and
> > Koha::Acquisitions::Budgets::Funds instead of having both modules be
> > siblings. My proposed names would indicate the actual hierarchy and
> > relationship of budgets and funds where funds belong to a given budget.
> 
> I agree with indicating the relationship. I've submitted a modified version.

I do not, CCing more QA people to get their opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:44:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:44:43 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-YzFeXlT1fn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I guess you are looking for Time::Fake here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:46:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:46:25 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-RSbtSjFdtR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Tom?s Cohen Arazi from comment #4)
> > (In reply to Kyle M Hall from comment #2)
> > > I think it would be better to use Koha::Acquisition::Budgets and
> > > Koha::Acquisitions::Budgets::Funds instead of having both modules be
> > > siblings. My proposed names would indicate the actual hierarchy and
> > > relationship of budgets and funds where funds belong to a given budget.
> > 
> > I agree with indicating the relationship. I've submitted a modified version.
> 
> I do not, CCing more QA people to get their opinions.

What about Biblio and Item ? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:56:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:56:39 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-SrW9HAEVcO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69912&action=edit
Bug 19788: Add a test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 15:57:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 14:57:41 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-gB0QsB0tCd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, can understand both sides. Bibio and Item is a good example, others I can
think of: aqbasket and aqorder.
Is there a technical reason we shoudl do one or the other?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:01:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:01:11 +0000
Subject: [Koha-bugs] [Bug 13695] Allow ISBD format export
In-Reply-To: <bug-13695-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13695-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13695-70-riWJssgMwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13695

Jens Weber <jens.weber at phsh.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jens.weber at phsh.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:02:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:02:45 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-mt2lCioiSH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This patch makes sense to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:06:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:06:26 +0000
Subject: [Koha-bugs] [Bug 19696] HoldsQueue.t is failing randomly
In-Reply-To: <bug-19696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19696-70-DZUt7alO7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19696

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
https://jenkins.koha-community.org/job/Koha_Master_D8/315/console

#   Failed test 'Holds queue filling 1st correct hold for default holds policy
'from home library''
#   at t/db_dependent/HoldsQueue.t line 295.
#          got: 'slgPPCeZVUsCvZL82wjWw'
#     expected: 'NAS1Ol9956P9q385FaDGw8OT'

#   Failed test 'Holds queue filling 2nd correct hold for default holds policy
'from home library''
#   at t/db_dependent/HoldsQueue.t line 296.
#          got: 'NAS1Ol9956P9q385FaDGw8OT'
#     expected: 'slgPPCeZVUsCvZL82wjWw'
# Looks like you failed 2 tests of 44.
[14:20:45] t/db_dependent/HoldsQueue.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:13:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:13:31 +0000
Subject: [Koha-bugs] [Bug 19837] New: Add multiple patrons to a list by
	barcode
Message-ID: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

            Bug ID: 19837
           Summary: Add multiple patrons to a list by barcode
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

I have a pretty good start on a feature to allow patrons to be added to a list
by scanning multiple barcodes. It needs better error-handling, though, so I'm
hoping a better perlmonger can pitch in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:25:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:25:04 +0000
Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by barcode
In-Reply-To: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19837-70-5qUbZerZsn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69913&action=edit
Bug 19837 - Add multiple patrons to a list by barcode

This patch adds the interface change and basic functionality for an
option to add multiple patrons to a patron list by scanning barcodes.

To test, apply the patch and go to Tools -> Patron lists.

- Create a patron list if necessary, and got to the "Add patrons"
  screen.
- Test the process for adding patrons using the "Patron search" text
  input.
- Test the process for adding patrons using the "Enter multiple card
  numbers" option.

This should really have some error-handling added to it: Onscreen
messages when a non-existing patron card number is submitted or when a
patron already exists on the list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:25:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:25:01 +0000
Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by barcode
In-Reply-To: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19837-70-mkKjaot4kS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:26:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:26:54 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-rRnYVr2km3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think it would be better to assign a $course_id variable and reuse it.
Something like:

modified: course_reserves/mod_course.pl
@ mod_course.pl:41 @ my ( $template, $loggedinuser, $cookie ) =
get_template_and_user(
 );

 my $action = $cgi->param('action') || '';
+my $course_id = $cgi->param('course_id');

 if ( $action eq 'del' ) {
-    DelCourse( $cgi->param('course_id') );
+    DelCourse( $course_id );
     print $cgi->redirect("/cgi-bin/koha/course_reserves/course-reserves.pl");
 } else {
     my %params;

-    $params{'course_id'} = $cgi->param('course_id')
-      if ( $cgi->param('course_id') );
+    $params{'course_id'} = $course_id;
     $params{'department'}     = $cgi->param('department');
     $params{'course_number'}  = $cgi->param('course_number');
     $params{'section'}        = $cgi->param('section');
@ mod_course.pl:60 @ if ( $action eq 'del' ) {
     $params{'students_count'} = $cgi->param('students_count');
     $params{'enabled'}        = ( $cgi->param('enabled') eq 'on' ) ? 'yes' :
'no';

-    my $course_id = ModCourse(%params);
+    my $new_course_id = ModCourse(%params);

     my @instructors = $cgi->multi_param('instructors');
     ModCourseInstructors(
         mode        => 'replace',
         cardnumbers => \@instructors,
-        course_id   => $course_id
+        course_id   => $new_course_id
     );
-    print
$cgi->redirect("/cgi-bin/koha/course_reserves/course-details.pl?course_id=$course_id");
+    print
$cgi->redirect("/cgi-bin/koha/course_reserves/course-details.pl?course_id=$new_course_id");
 }

Would it make more sense?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:29:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:29:08 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-mUssyslAWY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Fridolin SOMERS from comment #15)
> Be careful that TT cache should not be enabled with Plack.

Could you be more specific?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:30:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:30:03 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-sI900B9IdC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:30:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:30:16 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-lJcmJSmhZP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69911|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:36:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:36:58 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-UtYa5zmB6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69241|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:41:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:41:44 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-qbUqQgQ3RF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69241|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69914&action=edit
Bug 19658: Style fix for staff client lists page

Patch applies with no issues and works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Edit: Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:43:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:43:33 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-8IOk2s1Hms@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #36 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69915&action=edit
Bug 17656 - Update irregularities on subscription renewals

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Renew subscription from 2017-10-16
  - Check that you have the prediction pattern table on renwal page
  - Submit renewal
  - Check that irregularity and permanent_irregularity column
    have been updated.

  - Do the same for a monthly and weekly subscription

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:44:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:44:22 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-NykcWFypR7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:44:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:44:54 +0000
Subject: [Koha-bugs] [Bug 3431] Catalog by itemtype report pulling from
	holdingbranch
In-Reply-To: <bug-3431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3431-70-SHugTTOw3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3431

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19669

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:44:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:44:54 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-BxgQXl4sPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3431

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 19668 has been marked as a duplicate of this bug. ***

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 19667 has been marked as a duplicate of this bug. ***

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 19666 has been marked as a duplicate of this bug. ***

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 19665 has been marked as a duplicate of this bug. ***

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What about the other .plugin file (reports/itemtypes.plugin), see bug 3431
comment 2.
And then remove reports/manager.pl?
Is this plugin system used?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:47:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:47:36 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
 are planned only for current subscription
In-Reply-To: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17656-70-POKKqZ8shj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #37 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Hello Olivier,

The last patch add the prediction parttern table to the renewal pop-up. While
renewing, you can change irregularities or let them as they were before. I
think this is better than automatically update irregularities without asking
the user.

Please test

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:49:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:49:13 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-QXu8goKyI0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |major
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |david.bourgault at inlibro.com
                   |ity.org                     |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
David, do not forget to set the different fields of the bug report (at least
severity and assignee).
You should also start your commit messages with 'Bug XXXXX: ' instead of 'Bug
XXXXX - '

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:51:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:51:09 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-9agxsgURTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #9)
> Hm, can understand both sides. Bibio and Item is a good example, others I
> can think of: aqbasket and aqorder.
> Is there a technical reason we shoudl do one or the other?

It is mostly a matter of taste, and how devs are used to read names and infere
things from them.

In my opinion, if theres a one-to-many relationship, I is more obvious if I'm
unfamiliar with the codebase, when I read it the way I wrote the patches.

I can re-submit the original version if the RM requires it. Or if there's some
decision making deciding. Maybe worth voting on the next dev meeting. I bet it
will be 2-2 and 6/8 people saying don't care LOL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:51:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:51:19 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-i1YZt4erdE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6782

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
>From bug 6782, Marc V?ron raised this problem:
"""
    Note: Syspref PorrowerMandatoryField must not include cardnumber, otherwise
          you can not save. Maybe that should be mentioned in the comment for
          syspref autoMemberNum.
"""


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782
[Bug 6782] Move auto member cardnumber generation to occur when record is
"Saved" (avoid collisions)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:51:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:51:19 +0000
Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to
 occur when record is "Saved" (avoid collisions)
In-Reply-To: <bug-6782-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6782-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6782-70-wxuxczOWLl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19466


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466
[Bug 19466] Cardnumber auto calc is broken because field is required
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:51:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:51:34 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-Kwl2J1csfL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Marcel de Rooy from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > (In reply to Tom?s Cohen Arazi from comment #4)
> > > (In reply to Kyle M Hall from comment #2)
> > > > I think it would be better to use Koha::Acquisition::Budgets and
> > > > Koha::Acquisitions::Budgets::Funds instead of having both modules be
> > > > siblings. My proposed names would indicate the actual hierarchy and
> > > > relationship of budgets and funds where funds belong to a given budget.
> > > 
> > > I agree with indicating the relationship. I've submitted a modified version.
> > 
> > I do not, CCing more QA people to get their opinions.
> 
> What about Biblio and Item ? :)

That's a good rename too :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:52:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:52:03 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-mBzBk0ixrN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> Tests are missing.

Is use_ok() enough? I can submit a followup for each class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:57:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:57:01 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-06YxAMr5GS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19229
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by commit f55af2fc078a7d6a05238232bc276e6924307179
Bug 19229: Return to course when cancelling out of edit form


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229
[Bug 19229] Clicking Cancel when editing course doesn't take you back to the
course
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:57:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:57:01 +0000
Subject: [Koha-bugs] [Bug 19229] Clicking Cancel when editing course doesn'
 t take you back to the course
In-Reply-To: <bug-19229-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19229-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19229-70-zeBa26C4bD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19229

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19678


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678
[Bug 19678] Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:57:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:57:37 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-6nM8o2aJRN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 16:57:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 15:57:41 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-JDClZgic7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69281|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69916&action=edit
Bug 19678: Clicking Cancel when adding New Course to course reserves shows
message Invalid Course!

Clicking on the cancel link when adding a new course to course reserves
displays the message 'Invalid Course!'. It would be better if it
redirected back to the main Course Reserves page.

This patch redirects the user back to the main course reserves page.

To Test:

1. Go to Course Reserves

2. Click '+ New Course'

3. Cancel the process

4. You are shown 'Invalid Course!'

5. Apply patch and repeat steps 1-3

6. You are redirected back to the main course reserves page

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:02:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:02:10 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-794H6lwtn8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69195|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69917&action=edit
Bug 19636: Hold priority changes incorrectly via dropdown select

This patch sorts holds in UI after priority is changed via "Priority"
dropdown.

It fixes confusion where the form is posted and each row is individually
processed one by one - and due to conflict in priority value, the latter
row always gets the chosen value instead of what the user actually might
have wanted to change.

To reproduce:
1. Place 3 holds on a record
2. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX)
3. By using the dropdown menu under "Priority" column, change the first
   hold's priority to last (3). Do not touch other priorities.
4. Click Update hold(s)
5. Observe the hold did not get your selected priority 3, but 2 instead.

To test:
1. Apply patch
2. Place 3 holds on a record
3. See existing holds (cgi-bin/koha/reserve/request.pl?biblionumber=XXX)
4. By using the dropdown menu under "Priority" column, change the first
   hold's priority to last (3). Do not touch other priorities.
5. Observe this hold was automatically moved to the last row in the user
   interface.
6. Click Update hold(s)
7. Observe the hold has your selected priority 3.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:02:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:02:06 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-kNRYjxqQ9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:02:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:02:44 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-gIWgUkl9hE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #12)
> I guess you are looking for Time::Fake here.

No, when the server lags, the time expected doesn't match the time generated.
We need a mock, not a Time::Fake. Time::Fake does relative shifts in time. This
is a matter of holding time still.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:03:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:03:06 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-W4AtGMUwQZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69891|0                           |1
        is obsolete|                            |

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69918&action=edit
Bug 19826: Add K::Acq::Budget(s) and K::Acq::Budget::Fund(s)

This patch introduces Koha::Object(s)-derived classes for budgets and funds
(aqbudgetperiods and aqbudgets respectively).

C4::Budgets already uses DBIC calls on those tables so transition should be
easy on top of this.

To test:
- Check the referenced schema files are the right ones.
- QA scripts shoudl be happy.
- Sign off :-D

Note: the POD coverage report throws a false negative result on singular
classes which is trivially wrong.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:03:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:03:14 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-DXgiempsMw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69919&action=edit
Bug 19826: Unit test files

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:03:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:03:29 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-dmm0tqAybJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:03:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:03:20 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-qWYYTpKPSs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:03:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:03:44 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-GdwKMBxNIy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:06:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:06:08 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-7VZ8uzM4DC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
Since I was unable to find a representative benchmark that can be run with only
a few bib-posts, I created a more artificial one instead, just to illustrate
the slowness of the deserialization. In a real life example the impact is not
huge, but think it was about 5% of time spent during indexing for example (and
most accumulated time of all functions), so not insignificant.

https://gist.github.com/gnucifer/5b8c2cf0a63362d95322c6f91dd7411e

Without patch:
real    0m14.540s
user    0m13.144s
sys     0m0.168s


With patch:
real    0m0.689s
user    0m0.576s
sys     0m0.084s

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:06:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:06:21 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-tbHlelI4XX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Gustafsson from comment #22)
> Think git auto-merged some stuff incorrectly, but this should now be sorted
> out.

So, ready to be signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:09:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:09:39 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-HU8PSQGr8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #26 from David Gustafsson <glasklas at gmail.com> ---
Yes should be ready for sign off, have discovered no more issues since the most
recent patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:11:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:11:09 +0000
Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt
 (sentence splitting)
In-Reply-To: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16621-70-Gh8DZWXx4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12509

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:11:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:11:09 +0000
Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by
	overdues process"
In-Reply-To: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12509-70-BUHh2UpoT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16621

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:16:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:16:14 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-DeZjvh2kHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

jmbroust <jean-manuel.broust at univ-lyon2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust at univ-lyo
                   |                            |n2.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:16:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:16:43 +0000
Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report
 results to batch modification
In-Reply-To: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19233-70-YqL4tv5Xud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67805|0                           |1
        is obsolete|                            |

--- Comment #11 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69920&action=edit
Bug 19233 - Add ability to send itemnumbers in report results to batch
modification

To test:
1 - Apply patch
2 - Run a report with an itemnumber column
3 - Note there is a linked '^' after column title
4 - Hover over the '^'
5 - You should see a tooltip 'Send visible items to batch modification'
6 - Click the '^'
7 - You should be sent to batch item modification with itemnumbers that
were visible in report

Signed-off-by: George <george at nekls.org>
Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:16:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:16:46 +0000
Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report
 results to batch modification
In-Reply-To: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19233-70-JWJTDODgLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67806|0                           |1
        is obsolete|                            |

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69921&action=edit
Bug 19233: (follow-up) Send itemnumbers in report results to batch modification

This patch changes the obscure "^" symbol to a styled link with the text
"Batch modify." I think the only disadvantage of this is that it takes
up more space, but it is outweighed by the improved clarity.

This patch also makes minor indentation corrections to new lines of
HTML.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:17:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:17:37 +0000
Subject: [Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report
 results to batch modification
In-Reply-To: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19233-70-lqZoj9kztd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Patches have been rebased on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:23:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:23:43 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-hiajhCetoX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tom?s Cohen Arazi from comment #12)
> (In reply to Jonathan Druart from comment #6)
> > Tests are missing.
> 
> Is use_ok() enough? I can submit a followup for each class.

I usually reuse and adapt Cities.t, it introduces a base for next tests.

(In reply to Tom?s Cohen Arazi from comment #10)
> In my opinion, if theres a one-to-many relationship, I is more obvious if
> I'm unfamiliar with the codebase, when I read it the way I wrote the patches.

Hum, so Koha::Acquisition::Vendor::Basket::Order? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:26:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:26:20 +0000
Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice
	previews
In-Reply-To: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18007-70-BOU41qBHns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:30:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:30:59 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-Yc71oYZnug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Sorry, I did not get the problem.
Actually we have a lot of tests that would fail if run at midnight.
I would suggest to sleep at that time and run the test suite in the next
morning.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:32:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:32:30 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-J9nK9inVvW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to David Gustafsson from comment #26)
> Yes should be ready for sign off, have discovered no more issues since the
> most recent patch.

The good way to tell other people that your patch is ready to be tested is to
change the status of the bug report from "Patch doesn't apply" to "Needs
Signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:34:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:34:14 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-4NQxwuaa9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #28 from David Gustafsson <glasklas at gmail.com> ---
Aha, I looked for a status drop down but manage to miss it since it wasn't a
drop down. :) Will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:34:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:34:37 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-EtNekbsjk8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:35:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:35:52 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-vfgRta8xl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #29 from David Gustafsson <glasklas at gmail.com> ---
And, now I saw there was a dropdown, but below the comment area.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:37:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:37:12 +0000
Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow
In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19819-70-lPuKoptSoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 17:37:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 16:37:28 +0000
Subject: [Koha-bugs] [Bug 19820] Add unsafe param to GetMarcSubfieldStructure
In-Reply-To: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19820-70-foa8ePMDEd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 18:17:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 17:17:09 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-6mnr83fMaJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 18:20:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 17:20:38 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-Mdh84oIaqc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #15 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #14)
> Actually we have a lot of tests that would fail if run at midnight.
> I would suggest to sleep at that time and run the test suite in the next
> morning.

Counter-patch coming...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 18:31:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 17:31:46 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-7sEV9meJp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Tom?s Cohen Arazi from comment #10)
> > In my opinion, if theres a one-to-many relationship, I is more obvious if
> > I'm unfamiliar with the codebase, when I read it the way I wrote the patches.
> 
> Hum, so Koha::Acquisition::Vendor::Basket::Order? :)

I'm not sure, I think there is a 1-1 relationship between baskets and orders?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 18:36:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 17:36:51 +0000
Subject: [Koha-bugs] [Bug 18679] Patron Attributes in Self Registration
In-Reply-To: <bug-18679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18679-70-Q1qbStyGPI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18679

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The feature is available since 17.05 (bug 13757).
I am marking this as a duplicate.

*** This bug has been marked as a duplicate of bug 13757 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 18:36:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 17:36:51 +0000
Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac
 if set to ' editable in OPAC'
In-Reply-To: <bug-13757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13757-70-OBTL9YGwdP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apurbajyoti at gmail.com

--- Comment #130 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18679 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 18:45:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 17:45:16 +0000
Subject: [Koha-bugs] [Bug 19838] New: Add system preference for adding text
 to self registration form
Message-ID: <bug-19838-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19838

            Bug ID: 19838
           Summary: Add system preference for adding text to self
                    registration form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Some libraries would like to add some explanations to the self registration
form. At the moment there is only a system preference for the page that shows
after submitting the registration form. It would be helpful to have another
that shows on the self registration form itself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 18:51:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 17:51:04 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-fGEh5pAAPf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You can have several orders by basket, so it's 1-n

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:12:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:12:34 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-vZZUAPP4Ha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:12:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:12:47 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-muJWbyaNQK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:12:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:12:37 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-ARXXGFG1xB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69922&action=edit
Bug 19694: Force scalar context for output_pref called with billingdate

If no string is passed to output_pref, it needs to be called in scalar
context (to avoid a shift in the hash elements).
Here we have billingdate that is not defined yet (NULL)

Test plan:
- Search for an existing invoice
- Show details
- Changing shipping cost
- Save
- Verify the new amount is shown

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:14:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:14:40 +0000
Subject: [Koha-bugs] [Bug 19839] New: invoice.pl warns about bad variable
	scope
Message-ID: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839

            Bug ID: 19839
           Summary: invoice.pl warns about bad variable scope
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Variable "$template" is not available at
/home/vagrant/kohaclone/acqui/invoice.pl line 204.

204         $template->param( uncertainprices => 1 );

uncertainprices is not used in the template (this code has been c/p from
basket.pl). We can remove this line to remove the warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:15:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:15:01 +0000
Subject: [Koha-bugs] [Bug 19839] invoice.pl warns about bad variable scope
In-Reply-To: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19839-70-2m9Dcd1ESl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
             Status|ASSIGNED                    |NEW
           Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun
                   |ommunity.org                |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:18:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:18:07 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-uRDk6Z1Vq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
And it has the side-effect to set billingdate to 0000-00-00

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:18:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:18:38 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-MkGOT4DRVc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The logs displayed:
Odd number of elements in hash assignment at
/home/vagrant/kohaclone/C4/Acquisition.pm line 2773.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:42:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:42:33 +0000
Subject: [Koha-bugs] [Bug 19840] New: Patron note is not displayed on checkin
Message-ID: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

            Bug ID: 19840
           Summary: Patron note is not displayed on checkin
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 14224

If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to
be displayed when checked in


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:42:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:42:33 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14224-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14224-70-fsPesvxfps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840
[Bug 19840] Patron note is not displayed on checkin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:43:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:43:42 +0000
Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove
	GetBiblioFromItemNumber
In-Reply-To: <bug-18276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18276-70-JqNGUrTByB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840
[Bug 19840] Patron note is not displayed on checkin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:43:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:43:42 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-Tq7XoqnbGH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18276

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This bug may have been caused by
  commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
    Bug 18276: Remove GetBiblioFromItemNumber - Easy ones


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276
[Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:49:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:49:30 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-ARWQzjwkeY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:49:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:49:34 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-JQaP4GZ2Af@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69923&action=edit
Bug 19840: Fix - display patron note on checkin

If a patron let a note on the checkout (AllowCheckoutNotes), it is
supposed to be displayed when checked in.

Test plan:
1/ Enable AllowCheckoutNotes
2/ Check an item out
3/ At the opac let a note on the checkout
4/ Check the item in
=> With this patch applied you should see the notes displayed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:49:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:49:38 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-Smb9AW7JL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69924&action=edit
Bug 19840: And avoid XSS...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:53:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:53:26 +0000
Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove
	GetBiblioFromItemNumber
In-Reply-To: <bug-18276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18276-70-EEyMpL9owE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19798


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798
[Bug 19798] Returns.pl doesn't define itemnumber for transfer-slip.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:53:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:53:26 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-yKqR6YwNxp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
         Depends on|                            |18276

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This bug may have been caused by
  commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
    Bug 18276: Remove GetBiblioFromItemNumber - Easy ones


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276
[Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:53:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:53:35 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-gXidPBaFjl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:54:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:54:39 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-JxfK7ItTQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69925&action=edit
Bug 19798: Fix print transfer slip

... and maybe other bugs as well
What happens here is that $itemnumber is no longer set when barcode is
passed.

Test plan:
1. Check in available/not on hold item at a non owning library.
2. Click print slip
3. Item's info must be displayed on the slip

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:54:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:54:35 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-XMJCzAb9EL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:54:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:54:54 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-IbegnJLTkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19840

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Related with bug 19840

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 19:54:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 18:54:54 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-vc0mqXZB8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19798

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:01:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:01:06 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-yuMnw4sDTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:27:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:27:32 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-X96sAd1ycE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
16:15 < oleonard> greenjimll: I was just testing that too but got interrupted.
Looks okay to me except that in the OPAC the comment labels don't look right
when there is no patron
16:15 < oleonard> Instead of "Added 2016-12-19 by John Smith" it says "Added"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:29:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:29:17 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-tLU8VIzMMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69926&action=edit
Bug 19808: Do not display 'Added' alone

It seems that reviews.datereviewed ends with NULL in DB.
It is caused by another issue that will be fixed on another bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:35:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:35:00 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-6tCXMjR3Ym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:36:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:36:23 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-t7iKDyu6rt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
It is Grubi, thanks Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:37:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:37:44 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-K5kHi6KM7a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> ---
Hi Jonathan

It is Mak

Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:38:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:38:50 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must raised an exception if
 called with dateformat => rfc3339 and > dateonly => 1
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-VI9TGpJq9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:42:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:42:26 +0000
Subject: [Koha-bugs] [Bug 19841] New: AddMember should raise an exception if
 categorycode is invalid
Message-ID: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

            Bug ID: 19841
           Summary: AddMember should raise an exception if categorycode is
                    invalid
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

This should be dealt with in a move to Koha::Patron. But in the meantime, we
need to handle this more gracefuly.

The thrown exception should be kept on moving to Koha::Patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:42:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:42:32 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-HuBhafZSfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:48:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:48:23 +0000
Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds
In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17978-70-30Zur0N6y8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:48:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:48:26 +0000
Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds
In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17978-70-8VRW3320Pr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69927&action=edit
Bug 17978 - Circ rules will not limit holds

The crux of this issue is that all those holds are unfilled record level holds.
The code that checks for the number of holds the user already has *always* uses
a branchcode of some form. Because of this, any open record level holds are
completely ignored for this purpose.

Test Plan:
1) Set ReservesControlBranch to "item's home library"
2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2
holds
3) Place 3 record level holds, you can but you should not be able to!
4) Delete the holds
5) Apply this patch
6) Attempt to place 3 record level holds
7) Note that you cannot!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:49:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:49:28 +0000
Subject: [Koha-bugs] [Bug 19842] New: help files on 17.05 point to http://
 manual.koha-community.org/,
 not https://koha-community.org/manual/17.05/  html/
Message-ID: <bug-19842-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19842

            Bug ID: 19842
           Summary: help files on 17.05 point to
                    http://manual.koha-community.org/, not
                    https://koha-community.org/manual/17.05/html/
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

We need to do the same thing for the help files in 17.05 that we did in bug
18817.

17.05 help files point to http://manual.koha-community.org/; that server
doesn't have the dependencies needed to install python3-sphinx, so we'll need
to update the links to point to https://koha-community.org/manual/.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:53:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:53:14 +0000
Subject: [Koha-bugs] [Bug 19843] New: reviews.datereviewed is not set
Message-ID: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

            Bug ID: 19843
           Summary: reviews.datereviewed is not set
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 15839

Caused by
  commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6
    Bug 15839: Koha::Reviews - Remove savereview

the datereviewed=now() part of the query has not been translated.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839
[Bug 15839] Move the reviews related code to Koha::Reviews
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:53:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:53:14 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-780QPHkwyz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19843


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843
[Bug 19843] reviews.datereviewed is not set
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:53:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:53:35 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-JchmQjBz28@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15839

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #20)
> Created attachment 69926 [details] [review]
> Bug 19808: Do not display 'Added' alone
> 
> It seems that reviews.datereviewed ends with NULL in DB.
> It is caused by another issue that will be fixed on another bug report.

See bug 15839

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:53:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:53:35 +0000
Subject: [Koha-bugs] [Bug 15839] Move the reviews related code to
	Koha::Reviews
In-Reply-To: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15839-70-4gFS66g9MI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15839

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19808

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:55:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:55:58 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-83NALnG5GR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69928&action=edit
Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is
made

Caused by
  commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6
    Bug 15839: Koha::Reviews - Remove savereview

the datereviewed=now() part of the query has not been translated.

Test plan:
Add a review from the OPAC
Confirm that the reviews.datereviewd has been correctly set. Without this patch
it is set to NULL.

I have no idea how we could update existing data :-/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:55:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:55:55 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-2cGXjqchJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:56:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:56:25 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-Lu9i2cBRqu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69741|0                           |1
        is obsolete|                            |

--- Comment #16 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 69929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69929&action=edit
Bug 17770: Counter patch - sleep till past midnight.

As per Jonathan's comment #14, added a wait_till_midnight
function to t::lib::Dates.

Running this test at 23:59 will trigger a sleep until after midnight
accumulated in 60 second intervals.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:56:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:56:35 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-PvUuBw5nwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69742|0                           |1
        is obsolete|                            |

--- Comment #17 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 69930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69930&action=edit
Bug 17770: Perlcritic improvements

before patch: perlcritic -3 noisy
after patch: perlcritic -3 ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:56:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:56:45 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-8ZKQ7e2oXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69743|0                           |1
        is obsolete|                            |

--- Comment #18 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 69931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69931&action=edit
Bug 17770: Perltidy

differences should only be whitespace

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:57:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:57:47 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-PDbMSVN6Q9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 20:58:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 19:58:34 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-Q4pBP4O9ax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #19 from M. Tompsett <mtompset at hotmail.com> ---
Here is the sleep only version that even provides a nice sleep function for
other tests which may need it too. As per Jonathan's comment #14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:05:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:05:29 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-TwlN5oG7vC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to M. Tompsett from comment #19)
> Here is the sleep only version that even provides a nice sleep function for
> other tests which may need it too. As per Jonathan's comment #14

Well, it meant to be taken as a second degree joke :)
Maybe I forgot a smiley...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:09:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:09:00 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-5aGQaF5Uoj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:09:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:09:03 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-qYnU6hAHGc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69705|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 69932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69932&action=edit
Bug 19796 - Fix doubled up subscription info on OPAC detail page

The info "Subscription from..." is showing twice on the subscription
tab on the OPAC detail page because of a bad merge. This patch removes
the doubled up information.

To test:
- Add a subscription
- Search for the record in the OPAC
- Switch to the subscription tab
- Verify that the 'Subscription from...' line is repeated
- Apply patch
- Verify only one line remains and nothing is missing

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:19:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:19:25 +0000
Subject: [Koha-bugs] [Bug 19797] Subscriptions to email notifications for
 new serial issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-Gw03bbTv2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not recreate what you describe for master. Make sure you have a surname
and a firstname:

MariaDB [koha_kohadev]> select surname, firstname from borrowers where
borrowernumber=51;
+---------+-----------+
| surname | firstname |
+---------+-----------+
| koha    | NULL      |
+---------+-----------+

MariaDB [koha_kohadev]> select concat(surname, firstname) from borrowers where
borrowernumber=51;
+----------------------------+
| concat(surname, firstname) |
+----------------------------+
| NULL                       |
+----------------------------+

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:22:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:22:33 +0000
Subject: [Koha-bugs] [Bug 19844] New: add new column in the authorities
 Z39.50 search result page
Message-ID: <bug-19844-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19844

            Bug ID: 19844
           Summary: add new column in the authorities Z39.50 search result
                    page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi,

It would be nice to have a new column for authorities Z39.50 search. It could
be a systeme preference like for the bug #12747. This column would appear in
the result's page of a z39.50 authorities search. 

We could be able to indicate in this preference systeme fields and subfields
that we would see in this new column. 

Patrick.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:28:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:28:21 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-gnPDrfTPQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69741|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:28:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:28:35 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-kY4vndcNHJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69742|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:29:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:29:02 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-f0zUGzTYFY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69929|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:28:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:28:49 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-9VtgHLWslP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69743|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:29:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:29:11 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-sZ9k3Ugnp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69930|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:29:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:29:47 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-pd7bbGTTp5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69931|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:30:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:30:30 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-U4CIL6Sta1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
Restored older version since Jonathan suggested the sleep was a joke in comment
#20.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:31:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:31:47 +0000
Subject: [Koha-bugs] [Bug 19797] Subscriptions to email notifications for
 new serial issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-HeLGOU459e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:31:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:31:51 +0000
Subject: [Koha-bugs] [Bug 19797] Subscriptions to email notifications for
 new serial issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-ysE5dIAfiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69933&action=edit
Bug 19797: [16.11.x] Restore alert subscribers

This patch fixes a bad conflict between bug 18726 and bug 10357.
The alerttype variable was not passed to the template on 16.11.x

Test plan:
- Add a subscription
- Make sure you set a notice template for 'notification' on the first page
- Go to the record in the OPAC
- Subscribe to email notifications from the Subscriptions tab > More detail
- Verify that the alert table in the database has the entry for the subscribed
patron
- Verify that in the OPAC it now asks you to cancel subscription

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:32:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:32:36 +0000
Subject: [Koha-bugs] [Bug 19797] Subscriptions to email notifications for
 new serial issues are broken
In-Reply-To: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19797-70-DUslY2MPdz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19797

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
            Version|master                      |16.11

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Setting to 16.11.x specific, please open another bug report if the behavior is
wrong on master as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 21:40:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 20:40:27 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-rMBycBdsO0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Interestingly the test fails without this patch

#   at t/db_dependent/Bookseller.t line 121.
#     Structures begin differing at:
#          $got->{discount} = '2'
#     $expected->{discount} = '2.0000'

Just in a different way. 

Ill try to fix both issues

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:07:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:07:06 +0000
Subject: [Koha-bugs] [Bug 8371] Add network level issuing rules
In-Reply-To: <bug-8371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8371-70-GnaocMaaU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:12:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:12:44 +0000
Subject: [Koha-bugs] [Bug 19593] [16.11.x] "Delete vendor" button is always
	set
In-Reply-To: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19593-70-8b8tA9eBGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19593

--- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> ---
Ok, discount is a float(6,4) .. and tax_rate is a decimal(6,4), 

$VAR1 = {
          'bookselleremail' => undef,
          'notes' => 'notes2',
          'address2' => 'address2-2',
          'booksellerurl' => undef,
          'booksellerfax' => undef,
          'url' => 'url2',
          'address1' => 'address1_2',
          'phone' => 'phone2',
          'listprice' => undef,
          'fax' => 'fax2',
          'id' => 44,
          'invoiceincgst' => 1,
          'currency' => '',
          'accountnumber' => 'accountnumber2',
          'name' => 'Name2',
          'deliverytime' => 2,
          'postal' => 'postal2',
          'tax_rate' => '2.0000',
          'gstreg' => 1,
          'listincgst' => 1,
          'invoiceprice' => undef,
          'address4' => 'address4_2',
          'discount' => '2',
          'othersupplier' => undef,
          'address3' => 'address3_2',
          'active' => 1
        };

It's handing back 2 instead of 2.0000 but fine for tax_rate, if I change the db
to be decimal, it works
Not to do with this bug, ill fix the basketcount thing, and push that, but this
test needs looking into more

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:25:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:25:15 +0000
Subject: [Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication
In-Reply-To: <bug-14319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14319-70-tTwYGTuzPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

--- Comment #1 from Mike <black23 at gmail.com> ---
I vote +1 for 2FA Authentication. It'll be very useful for GDPR.


My favorites solutions
Gluu/SuperGluu
https://super.gluu.org/

LinOTP
http://www.linotp.org/, https://github.com/LinOTP/LinOTP

PrivacyIdea
https://github.com/privacyidea/privacyidea


Some other solutions:
https://github.com/j256/perl-two-factor-auth/blob/master/totp.pl

https://debian-administration.org/article/729/Implementing_two_factor_authentication_with_perl


https://token2.com/?content=motpqr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:25:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:25:38 +0000
Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite
In-Reply-To: <bug-11916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11916-70-DaL4Txu7L4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com,
                   |                            |josef.moravec at gmail.com,
                   |                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:26:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:26:07 +0000
Subject: [Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication
In-Reply-To: <bug-14319-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14319-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14319-70-gmmx0AkW0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:26:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:26:41 +0000
Subject: [Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite
In-Reply-To: <bug-11916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11916-70-Mq33opHD21@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|josef.moravec at gmail.com,    |
                   |rbit at rbit.cz                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:36:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:36:25 +0000
Subject: [Koha-bugs] [Bug 19845] New: Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
Message-ID: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

            Bug ID: 19845
           Summary: Patron password is ignored during self-registration if
                    PatronSelfRegistrationVerifyByEmail is enabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: library at sll.texas.gov
        QA Contact: testopia at bugs.koha-community.org

Bug 15343 allows patrons to choose their own passwords during
self-registration. But this does not work if the
PatronSelfRegistrationVerifyByEmail preference is set to "Require." If e-mail
verification is required, whatever password the patron supplied in the form is
ignored, and they are given a randomly generated password once they click on
the verification link.

To test this behavior:

1. Make sure there is a valid e-mail stored in the KohaAdminEmailAddress
preference.
2. Set PatronSelfRegistration to Allow.
3. Set PatronSelfRegistrationVerifyByEmail to Require.
3. Be sure "password" is listed in PatronSelfRegistrationBorrowerMandatoryField
and NOT listed in PatronSelfRegistrationBorrowerUnwantedField.
4. Be sure there is a valid patron category in
PatronSelfRegistrationDefaultCategory.
5. Set PatronSelfRegistrationPrefillForm to "Display and prefill" so that you
can see the generated password.

Then fill out the self-registration form, include a valid e-mail address, and
select a password. Wait for the verification e-mail. Click on the link and
you'll see that the password you entered in the form is not used. Instead, Koha
will have generated a random password for the account.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:37:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:37:32 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-6YlSs3GBCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

Arturo <library at sll.texas.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |library at sll.texas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:37:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:37:36 +0000
Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging
	preferences
In-Reply-To: <bug-17505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17505-70-4FtE90pQ31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |tomascohen at gmail.com

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
I think the endpoint should be 
/patrons/<patron_id>/messaging_preferences

and somehow like
/categories/<category_id>/messaging_preferences

It seems more logical to me...

I am CCing to Tomas, to get his opinion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:41:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:41:10 +0000
Subject: [Koha-bugs] [Bug 19846] New: Incorrect number of holds showing on
 Receipt Page in Acquisitions
Message-ID: <bug-19846-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19846

            Bug ID: 19846
           Summary: Incorrect number of holds showing on Receipt Page in
                    Acquisitions
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When viewing a receipt page for an invoice, the incorrect number of holds is
showing for items.  In my example all titles are showing 0 holds and I can see
at least one title that there are 4 holds on the bib record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:55:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:55:11 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-HyZ2MGb4tu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #4 from Barton Chittenden <barton at bywatersolutions.com> ---
*** Bug 19846 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 22:55:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 21:55:11 +0000
Subject: [Koha-bugs] [Bug 19846] Incorrect number of holds showing on
 Receipt Page in Acquisitions
In-Reply-To: <bug-19846-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19846-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19846-70-auEVWzDBkW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19846

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |barton at bywatersolutions.com

--- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 19812 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:01:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:01:42 +0000
Subject: [Koha-bugs] [Bug 19842] help files on 17.05 point to
 http://manual.koha-community.org/ ,
 not https://koha-community.org/manual/17.05/html/
In-Reply-To: <bug-19842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19842-70-RGtwVM0qb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19842

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I thought we had decided to keep the old manual (pre-sphinx) for 17.05 - so the
links as long as they work should be alright pointing at the old server.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:09:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:09:48 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-4Mp4pWBnhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #15)
> Hum, so Koha::Acquisition::Vendor::Basket::Order? :)

Please, no :)
Not everything can be represented in a tree.
Where do you place basket groups in this hierarchy ? It could be
Koha::Acq::Vendor::Basketgroup::Basket, but not every basket belongs to a
basketgroup.
Also, there is a 1-n relationship between biblio and aqorders, but
Koha::Biblio::Orders does not make much sense IMHO.

If there was a vote, I'd vote for everything on one level

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:38:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:38:30 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-73MHQ03Dkx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:38:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:38:33 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-SgXpWVKsPm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69853|0                           |1
        is obsolete|                            |
  Attachment #69854|0                           |1
        is obsolete|                            |
  Attachment #69855|0                           |1
        is obsolete|                            |
  Attachment #69856|0                           |1
        is obsolete|                            |
  Attachment #69926|0                           |1
        is obsolete|                            |

--- Comment #22 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69934&action=edit
[SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully - opac-detail

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:38:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:38:36 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-VDryYIGQB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #23 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69935&action=edit
[SIGNED-OFF] Bug 19808: (follow-up) Handle deleted reviewers gracefully -
opac-detail

Make the tests easier to read

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:38:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:38:40 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-LghKBphNMS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #24 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69936&action=edit
[SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully - opac-showreview

Test plan:
- Create reviews
- Delete some reviewers
- Enable OpacShowRecentComments
- Go to opac/opac-showreviews.pl
- Go to opac-showreviews.pl?format=rss

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:38:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:38:43 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-Mmk30Sqljk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #25 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69937&action=edit
[SIGNED-OFF] Bug 19808: Handle deleted reviewers gracefully -
reviews/reviewswaiting.pl

Test plan:
- Create reviews
- Delete some reviewers
- Go to Home ? Tools ? Comments ? Comments awaiting moderation

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 19 23:38:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 22:38:46 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-dxWOGqRWNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #26 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69938&action=edit
[SIGNED-OFF] Bug 19808: Do not display 'Added' alone

It seems that reviews.datereviewed ends with NULL in DB.
It is caused by another issue that will be fixed on another bug report.

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 00:26:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 19 Dec 2017 23:26:13 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-RMt6f0Li2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

--- Comment #14 from Barton Chittenden <barton at bywatersolutions.com> ---
Katrin,

I believe that what's happening here is that when rows are deleted from the
letter table, there's a cascading delete on message_transports. There's a
foreign key relationship between letter and message_transports, but the keys
aren't entirely constrained... so deleting *any* row in the letter table will
delete the rows in the message_transports with that letter code.

At the time that this was discussed, this wasn't seen as a big deal, because
the only way this could happen through the GUI was to delete the entire
message, in which case the row would need to be removed from message_transports
anyway.

Unfortunately this didn't take upgradedatabase into account, and I think that
we've seen this happen a couple of times because of that.

--Barton

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 04:30:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 03:30:40 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-hAKPUdmeom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #22 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 69939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69939&action=edit
Bug 19243 - Amended Selenium test to add the creation of patron category and
authorised values

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 04:35:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 03:35:46 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-Esn8V2Oig5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68512|0                           |1
        is obsolete|                            |

--- Comment #55 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69940&action=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work
Update6: Merge conflicts and making sure export of default auth type
works
Update7: Fixing merge conflicts and updating buttons to bootstrap3

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) Import into your new authority type using the file you just exported
7) Confirm you are taken to auth_tag_structure.pl
8) Go back to Authority types
9) Export your new authority type. View the exported file and confirm
the authtypecode has been updated to match the code you set for the new
auth type
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Confirm Export and Import work for the Default authority type
12) Go to Admin -> MARC bibliographic framework
13) Confirm that the 'Export' and 'Import' functions still work here as well

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 04:35:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 03:35:52 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-0pKsjmBjlE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68513|0                           |1
        is obsolete|                            |

--- Comment #56 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69941&action=edit
Bug 13952: [FOLLOW-UP] Fixing authority type import

This patch fixes the comments from Comment 29 and the import
functionality. You should now be able to import an exported file without
editing the file at all and the authority type code will be overwritten
in the file (same behaviour as biblio frameworks).

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 04:35:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 03:35:57 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-hjXcImzLXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68514|0                           |1
        is obsolete|                            |

--- Comment #57 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69942&action=edit
Bug 13952: [FOLLOW-UP] Fixing import for default auth type

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 04:36:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 03:36:01 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-2hmLyj0H9R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68515|0                           |1
        is obsolete|                            |

--- Comment #58 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69943&action=edit
Bug 13952: [FOLLOW-UP] Fixing export on default biblio framework

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 04:36:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 03:36:06 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-7RtFCGP1XX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68556|0                           |1
        is obsolete|                            |

--- Comment #59 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69944&action=edit
Bug 13952: [FOLLOW-UP] Fixing JS error

Missing a bracket that stopped the export modal from closing after
clicking the button. Now fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 04:37:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 03:37:34 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-Cx9oLJ24Fm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #60 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #54)
> Hi Aleisha, want to retest and try to push this through QA, can you please
> rebase?

Rebased, ready for you to retest

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 05:16:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 04:16:09 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-KqWT8Gqg5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #23 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi Jonathan

I have just attached a patch which tests the creation of an authorised value
and a patron category. 

The difficulties I faced with adding these were that a modal box is displayed
when you delete authorised values. Trying to confirm the deletion with the
modal box is problematic and I have not been able to find a solution for that
yet. 

Additionally in the creation of patron categories you must select a value from
a dropdown box, I am still trying to find a solution for this. 

I will be away from my computer for the next 3.5 weeks whilst travelling in
Egypt and Jordan and will be able to return to this in mid Jan along with other
Koha development work I am working on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 07:52:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 06:52:53 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-fYnCbyded7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 07:52:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 06:52:56 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-lD0XI4AaQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69914|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69945&action=edit
Bug 19658: Style fix for staff client lists page

Patch applies with no issues and works as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Edit: Rebased.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:08:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:08:29 +0000
Subject: [Koha-bugs] [Bug 19848] New: Course module contents stuck to left
	side of page
Message-ID: <bug-19848-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19848

            Bug ID: 19848
           Summary: Course module contents stuck to left side of page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

On the pages of the Course module the tables and contents are stuck to the left
side of the pages without any padding.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:10:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:10:41 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-w2zuJtwBSG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67797|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69946&action=edit
Bug 19230: Preventing warn when deleting course

To test:
1) Ensure UseCourseReserves is enabled
2) Go to Course Reserves, create a course
3) Delete course
4) Notice warn
5) Apply patch
6) Create a course again and delete it
7) Notice no warn

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:10:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:10:37 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-8BjfDQoLK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:16:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:16:08 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-ArM4kvnt95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen, should we apply the same styling as on the other toolbars like tools?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:16:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:16:45 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-lRC391QjCH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69268|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69947&action=edit
Bug 19664: Reports sidebar menu should match list of reports on reports home
page

This patch makes the reports sidebar menu a little more consistent with
the reports home page menu by adding missing links to reports.

To test, observer the reports sidebar menu before and after the patch
and confirm that missing reports are linked in the update.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:16:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:16:42 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-h2qdESxMFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:18:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:18:21 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-7Z5q7VL4pm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |liz at catalyst.net.nz
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:44:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:44:22 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-sxsg5YGI5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761
Bug 19761 depends on bug 19766, which changed state.

Bug 19766 Summary: Preview routing slip is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:44:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:44:21 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-VkygFlCMLW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 19058 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:48:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:48:03 +0000
Subject: [Koha-bugs] [Bug 19683] Export.pl does not populate the Authority
 Types dropdown correctly
In-Reply-To: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19683-70-0Xu7qCBYe2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:51:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:51:44 +0000
Subject: [Koha-bugs] [Bug 19646] value_builder marc21_linking_section
	template is broken
In-Reply-To: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19646-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19646-70-hQQK5iSNU4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

--- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 08:52:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 07:52:34 +0000
Subject: [Koha-bugs] [Bug 19640] IdRef webservice display is broken
In-Reply-To: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19640-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19640-70-g13UgpjX5r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19640

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 09:12:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 08:12:38 +0000
Subject: [Koha-bugs] [Bug 19456] Some pages title tag contains html
In-Reply-To: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19456-70-qsKyKvajzY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I will push to next 17.05.x release because of string freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 09:13:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 08:13:42 +0000
Subject: [Koha-bugs] [Bug 18833] plugin unimarc_field_210c pagination error
In-Reply-To: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18833-70-c5AaqGy53o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18833

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 09:28:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 08:28:57 +0000
Subject: [Koha-bugs] [Bug 19533] Hold pulldown for itemtype is empty if hold
 placement needs override
In-Reply-To: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19533-70-DMFP2JHEfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19533

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

Looks like the same code is in if and else now, strange o_O

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 09:29:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 08:29:54 +0000
Subject: [Koha-bugs] [Bug 19692] Unclosed div in opac-shelves.tt
In-Reply-To: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19692-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19692-70-KBJSDgKfhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19692

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 09:35:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 08:35:37 +0000
Subject: [Koha-bugs] [Bug 19681] label-item-search.pl result count
 formatting error when there is only one page
In-Reply-To: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19681-70-FsafTXnZS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19681

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 09:49:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 08:49:48 +0000
Subject: [Koha-bugs] [Bug 19849] New: Rebase of bug 16621 partially reverted
	bug 12509
Message-ID: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849

            Bug ID: 19849
           Summary: Rebase of bug 16621 partially reverted bug 12509
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: victor.grousset at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Causing a string to become untranslatable again.

This is the first attachment that reverted the relevant part of bug 16621
See the first part of the diff.
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53252&action=diff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 11:21:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 10:21:21 +0000
Subject: [Koha-bugs] [Bug 19637] jsPrintSetup not supported in Firefox
	Quantum
In-Reply-To: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19637-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19637-70-pQOE0vJLeE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19637

--- Comment #5 from Mike <black23 at gmail.com> ---
On JSprint Github was debate about implemenation via nativeMessaging API. But
All was very skeptic about it.

So, I've made some researh and QZ library looks like aceptable solution. It's
very similar like JSprint on Koha side. He re is just one complication, because
Java app must be sef-signed and compilated for each Koha domain instalation.

More here:
https://medium.com/@buddhiv/how-to-directly-print-from-your-browser-using-qz-tray-6c86ccd7b3f9

So community, can we accept QZ as solution? Side effect is better support for
more browsers like Chrome.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 11:27:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 10:27:36 +0000
Subject: [Koha-bugs] [Bug 18719] Manage staged MARC records,
 the Job progress bar stuck at 0%
In-Reply-To: <bug-18719-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18719-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18719-70-cNBdmA6Eec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18719

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 11:55:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 10:55:09 +0000
Subject: [Koha-bugs] [Bug 19643] Pagination buttons on staged marc
 management are stacking instead of inline
In-Reply-To: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19643-70-kUj7PSlwZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19643

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:07:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:07:39 +0000
Subject: [Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS
	correctly
In-Reply-To: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18990-70-qY67S9Xyn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

Just had to change $patron->smsalertnumber into $member->{'smsalertnumber'}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:09:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:09:32 +0000
Subject: [Koha-bugs] [Bug 10222] Error when saving Demco label templates
In-Reply-To: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10222-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10222-70-R8hqPRgFDN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:12:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:12:53 +0000
Subject: [Koha-bugs] [Bug 19638] False positives for 'Update SQL' button
In-Reply-To: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19638-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19638-70-pVEF44TBRR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19638

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:13:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:13:40 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-asvgXjHXhz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17196
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196
[Bug 17196] Move marcxml out of the biblioitems table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:13:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:13:40 +0000
Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table
In-Reply-To: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17196-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17196-70-iQlgxKrAfg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19724


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724
[Bug 19724] Add timestamp to biblio_metadata and deletedbiblio_metadata
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:26:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:26:29 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-WmdtvqtGe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Nick Clemens from comment #7)
> Pushed to stable for 17.11.01, awesome work all!

Your commit in 17.11.x is missing the update of version in Koha.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:26:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:26:40 +0000
Subject: [Koha-bugs] [Bug 19724] Add timestamp to biblio_metadata and
 deletedbiblio_metadata
In-Reply-To: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19724-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19724-70-nfkaKsP25R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19724

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:34:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:34:12 +0000
Subject: [Koha-bugs] [Bug 19563] Generation of sort_fields uses incorrect
	condition
In-Reply-To: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19563-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19563-70-P1Cpfm4Mov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19563

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:34:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:34:31 +0000
Subject: [Koha-bugs] [Bug 3841] Add a Default ACQ framework
In-Reply-To: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3841-70-Troo0tipW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:34:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:34:49 +0000
Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl
In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19746-70-6sDelBOBCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:36:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:36:49 +0000
Subject: [Koha-bugs] [Bug 19542] Koha should display Elasticsearch
 information in the about page
In-Reply-To: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19542-70-Ho70OCs9zs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, skipping for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:09 +0000
Subject: [Koha-bugs] [Bug 19234] Add query parameters handling helpers
In-Reply-To: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19234-70-ewvFqECUXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, skipping for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:10 +0000
Subject: [Koha-bugs] [Bug 19369] Add a helper function for translating
 pagination params into SQL:: Abstract
In-Reply-To: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19369-70-ipbIgNJDUK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369
Bug 19369 depends on bug 19234, which changed state.

Bug 19234 Summary: Add query parameters handling helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:10 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-YrmqaV0dXK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370
Bug 19370 depends on bug 19234, which changed state.

Bug 19234 Summary: Add query parameters handling helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:09 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-3eqJ5PFSMm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
Bug 18731 depends on bug 19234, which changed state.

Bug 19234 Summary: Add query parameters handling helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:11 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-4vo6zTOAJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
Bug 19410 depends on bug 19234, which changed state.

Bug 19234 Summary: Add query parameters handling helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:59 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-dQEK5Eirfh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
Bug 18731 depends on bug 19369, which changed state.

Bug 19369 Summary: Add a helper function for translating pagination params into SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:59 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-OA30bfAIxK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278
Bug 19278 depends on bug 19369, which changed state.

Bug 19369 Summary: Add a helper function for translating pagination params into SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:41:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:41:00 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-URqvQtqfKk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
Bug 19410 depends on bug 19369, which changed state.

Bug 19369 Summary: Add a helper function for translating pagination params into SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:40:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:40:59 +0000
Subject: [Koha-bugs] [Bug 19369] Add a helper function for translating
 pagination params into SQL:: Abstract
In-Reply-To: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19369-70-isUjTfuwea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, won't be backported to 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:41:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:41:45 +0000
Subject: [Koha-bugs] [Bug 19278] Add a configurable default page size for
	endpoints
In-Reply-To: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19278-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19278-70-8xbCWA3APa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |RESOLVED

--- Comment #28 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, won't be backported for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:41:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:41:46 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-CvPBrXIf0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
Bug 19410 depends on bug 19278, which changed state.

Bug 19278 Summary: Add a configurable default page size for endpoints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:42:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:42:35 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-dEe4dZFd1j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
Bug 18731 depends on bug 19370, which changed state.

Bug 19370 Summary: Add a helper function for translating order_by params into SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:42:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:42:36 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-oz6h6mTY8H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
Bug 19410 depends on bug 19370, which changed state.

Bug 19370 Summary: Add a helper function for translating order_by params into SQL::Abstract
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:42:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:42:35 +0000
Subject: [Koha-bugs] [Bug 19370] Add a helper function for translating
 order_by params into SQL ::Abstract
In-Reply-To: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19370-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19370-70-Ydq5gdtXCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, won't backport for for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:43:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:43:12 +0000
Subject: [Koha-bugs] [Bug 19410] Add a helper function for generating object
 searches for the API
In-Reply-To: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19410-70-DAb99IbTG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #41 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:43:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:43:15 +0000
Subject: [Koha-bugs] [Bug 18731] CRUD for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-VA8jHTBRUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
Bug 18731 depends on bug 19410, which changed state.

Bug 19410 Summary: Add a helper function for generating object searches for the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:43:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:43:13 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-0LWcDjxbum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
Bug 16330 depends on bug 19410, which changed state.

Bug 19410 Summary: Add a helper function for generating object searches for the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:43:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:43:15 +0000
Subject: [Koha-bugs] [Bug 19686] objects.search helper needs a to_model param
In-Reply-To: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19686-70-o7Wrh9KwaF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19686
Bug 19686 depends on bug 19410, which changed state.

Bug 19410 Summary: Add a helper function for generating object searches for the API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:44:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:44:44 +0000
Subject: [Koha-bugs] [Bug 19776] Test failing randomly - fix categorycode vs
 category_type
In-Reply-To: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19776-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19776-70-PNvIWEhvY0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19776

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Skipping for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:48:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:48:33 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-B7mnJY6N3G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19758, which changed state.

Bug 19758 Summary: Move template JavaScript to the footer: Serials, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:48:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:48:33 +0000
Subject: [Koha-bugs] [Bug 19758] Move template JavaScript to the footer:
	Serials, part 1
In-Reply-To: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19758-70-VLdnbZ5oAp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19758

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:48:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:48:52 +0000
Subject: [Koha-bugs] [Bug 19761] Move template JavaScript to the footer:
	Serials, part 2
In-Reply-To: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19761-70-nCrafTii53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:48:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:48:52 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-2bv5VFxHzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19761, which changed state.

Bug 19761 Summary: Move template JavaScript to the footer: Serials, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19761

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:49:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:49:09 +0000
Subject: [Koha-bugs] [Bug 19777] Move template JavaScript to the footer:
	Serials, part 3
In-Reply-To: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19777-70-AeL5De3ErS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:49:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:49:09 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-16nBgPxZi1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19777, which changed state.

Bug 19777 Summary: Move template JavaScript to the footer: Serials, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19777

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:49:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:49:26 +0000
Subject: [Koha-bugs] [Bug 19778] Move template JavaScript to the footer:
	Serials, part 4
In-Reply-To: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19778-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19778-70-nF8fRn0Akm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:49:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:49:27 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-1ANoHA6qPz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19778, which changed state.

Bug 19778 Summary: Move template JavaScript to the footer: Serials, part 4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19778

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:49:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:49:58 +0000
Subject: [Koha-bugs] [Bug 19607] Move admin templates JavaScript to the
 footer: Basic parameters
In-Reply-To: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19607-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19607-70-SiPemERt1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:49:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:49:59 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-lJedhazCT4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19607, which changed state.

Bug 19607 Summary: Move admin templates JavaScript to the footer: Basic parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:49:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:49:59 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-8p3ELZY4sM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
Bug 19608 depends on bug 19607, which changed state.

Bug 19607 Summary: Move admin templates JavaScript to the footer: Basic parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:50:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:50:22 +0000
Subject: [Koha-bugs] [Bug 19627] Move patron clubs templates JS to the footer
In-Reply-To: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19627-70-QYijyk5ZSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:50:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:50:23 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-6XBHmUBAG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19627, which changed state.

Bug 19627 Summary: Move patron clubs templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:50:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:50:38 +0000
Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports
In-Reply-To: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19663-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19663-70-dXd2aqcUsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:50:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:50:39 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-q8w13R6ze3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19663, which changed state.

Bug 19663 Summary: Move JS to the footer: Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:51:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:51:26 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-ukJPDqenN0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
Bug 16330 depends on bug 18330, which changed state.

Bug 18330 Summary: REST API: Date-time handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:51:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:51:27 +0000
Subject: [Koha-bugs] [Bug 19816] output_pref must raised an exception if
 called with dateformat => rfc3339 and > dateonly => 1
In-Reply-To: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19816-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19816-70-CqwotK8fZk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19816
Bug 19816 depends on bug 18330, which changed state.

Bug 18330 Summary: REST API: Date-time handling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 12:51:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 11:51:25 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-QvIIDgSLRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED
                 CC|                            |nick at bywatersolutions.com

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 13:01:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 12:01:04 +0000
Subject: [Koha-bugs] [Bug 19554] The inventory table should jump to detail
 instead of MARCdetail
In-Reply-To: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19554-70-fhlSDkAQr1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19554

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |RESOLVED
           Severity|trivial                     |enhancement

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 13:03:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 12:03:26 +0000
Subject: [Koha-bugs] [Bug 19654] Move tools templates JavaScript to the
 footer: Batch MARC tools
In-Reply-To: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19654-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19654-70-gbZuJrGnPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to Master            |RESOLVED

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 13:03:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 12:03:27 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-UE9vlyq9b2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19654, which changed state.

Bug 19654 Summary: Move tools templates JavaScript to the footer: Batch MARC tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 13:08:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 12:08:00 +0000
Subject: [Koha-bugs] [Bug 19805] Add DataTables to Koha to MARC mapping page
In-Reply-To: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19805-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19805-70-gS1PkrMaAI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19805

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |nick at bywatersolutions.com

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Enhancement, not backporting for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 13:59:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 12:59:03 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-o0SP51bkXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 13:59:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 12:59:06 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-AeXg2DxpZB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69928|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69948&action=edit
Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is
made

Caused by
  commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6
    Bug 15839: Koha::Reviews - Remove savereview

the datereviewed=now() part of the query has not been translated.

Test plan:
Add a review from the OPAC
Confirm that the reviews.datereviewd has been correctly set. Without
this patch it is set to NULL.

I have no idea how we could update existing data :-/

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 13:59:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 12:59:31 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-nNEpJOU5RQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

--- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Fridolin SOMERS from comment #15)
> > Be careful that TT cache should not be enabled with Plack.
> 
> Could you be more specific?

Sorry, i was wrong. I have found something odd with Plack but it is not linked
to template_cache_dir. I will explain it in a mail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:01:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:01:27 +0000
Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug
	12509
In-Reply-To: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19849-70-wGWnUTIyS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:01:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:01:32 +0000
Subject: [Koha-bugs] [Bug 19769] 'Pickup library is different' message does
 not display library branch name when placing hold
In-Reply-To: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19769-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19769-70-aKpo96KGL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19769

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:01:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:01:46 +0000
Subject: [Koha-bugs] [Bug 17182] Allow Keyword to MARC mapping for
 acquisitions searches ( subtitle)
In-Reply-To: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17182-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17182-70-twDmx0gikR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17182

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:02:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:02:12 +0000
Subject: [Koha-bugs] [Bug 19767] serial-issues.pl is unused and should be
	removed
In-Reply-To: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19767-70-GcYmD4Vhzv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19767

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:01:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:01:59 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-3DvaYghYne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #29 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:02:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:02:43 +0000
Subject: [Koha-bugs] [Bug 19706] Item search: Unsupported format html
In-Reply-To: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19706-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19706-70-o9WYCmkIwR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19706

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:02:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:02:55 +0000
Subject: [Koha-bugs] [Bug 19759] TestBuilder generates too many decimals for
	float
In-Reply-To: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19759-70-2UKsHI8LUX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19759

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 14:03:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 13:03:07 +0000
Subject: [Koha-bugs] [Bug 19806] Add class to items.itemnotes_nonpublic
In-Reply-To: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19806-70-JLQ6HZRUXm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19806

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Awesome work all! Pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 15:49:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 14:49:02 +0000
Subject: [Koha-bugs] [Bug 19850] New: Enhance invoicing functionality for
	each line item
Message-ID: <bug-19850-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850

            Bug ID: 19850
           Summary: Enhance invoicing functionality for each line item
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: j.j.brown at lboro.ac.uk
        QA Contact: testopia at bugs.koha-community.org

Enhancement to the invoicing functionality: 
Currently when paying an invoice the accounting form for each line item just
has a Tax percentage field. This is inadequate for accounting purposes. We
would like to see 2 fields which allow you to input an amount (not based upon a
percentage) ? 1 for tax, 1 for additional costs. These fields should then be
added to the price of the book to give a total/actual cost of each book.

For example, a CD with a book and servicing may need 3 tax elements for a
single order line. That is Book 0%, CD 20%, Servicing 20%. This may be
achievable with a separate table of aqtaxamounts attached to aqinvoices? We
need to use amounts (rather than any sort of %). This would make it compatible
with EDI INVOIC which only sends a value. It would require changes to database
structure, UI and EDI code. Add a system preference to leave as it is now or
switch on ?advanced invoicing?.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 15:57:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 14:57:12 +0000
Subject: [Koha-bugs] [Bug 18893] The dateformat sys pref not used everywhere
In-Reply-To: <bug-18893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18893-70-SojZcIRcGj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18893

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 16:22:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 15:22:59 +0000
Subject: [Koha-bugs] [Bug 19850] Enhance invoicing functionality for each
	line item
In-Reply-To: <bug-19850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19850-70-72jEGW0btd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19850

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 16:29:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 15:29:01 +0000
Subject: [Koha-bugs] [Bug 15343] Allow patrons to choose their own password
 on self registration.
In-Reply-To: <bug-15343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15343-70-3collTDneL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19845


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845
[Bug 19845] Patron password is ignored during self-registration if
PatronSelfRegistrationVerifyByEmail is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 16:29:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 15:29:01 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-gruz94WyIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |15343
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343
[Bug 15343] Allow patrons to choose their own password on self registration.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 16:37:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 15:37:37 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-x9W9LsjANA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 16:37:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 15:37:41 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-nGPsOpbe8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69950&action=edit
Bug 19845: Do not generate a password if one is filled on selfreg

Bug 15343 allows patrons to choose their own passwords during
self-registration.
But this does not work if the PatronSelfRegistrationVerifyByEmail preference is
set to "Require." If e-mail verification is required, whatever password the
patron
supplied in the form is ignored, and they are given a randomly generated
password
once they click on the verification link.

Test plan:
1. Make sure there is a valid e-mail stored in the KohaAdminEmailAddress
preference.
2. Set PatronSelfRegistration to Allow.
3. Set PatronSelfRegistrationVerifyByEmail to Require.
3. Be sure "password" is listed in PatronSelfRegistrationBorrowerMandatoryField
and
NOT listed in PatronSelfRegistrationBorrowerUnwantedField.
4. Be sure there is a valid patron category in
PatronSelfRegistrationDefaultCategory.
5. Set PatronSelfRegistrationPrefillForm to "Display and prefill" so that you
can see
the generated password.

Then fill out the self-registration form, include a valid e-mail address, and
select
a password. Wait for the verification e-mail. Click on the link and you'll see
that
the password you entered in the form is used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:02:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:02:05 +0000
Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not
 populating itemtype correctly
In-Reply-To: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16760-70-4kcO4M44pF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19671

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:02:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:02:05 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-m7J5LBE13N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16760

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:02:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:02:52 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-Faq13y6vnt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I was going to submit the same patch, I am going to sign it off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:02:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:02:52 +0000
Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not
 populating itemtype correctly
In-Reply-To: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16760-70-j6kGDcfJsR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #10)
> (In reply to MetaBiblioteca Colombia from comment #9)
> > Hello, In Koha 17.X (0,1,2) This error still persists
> 
> Please open a new bug report and describe the problem.

See bug 19671

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:15:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:15:02 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-A2M5wAwrV2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|nick at bywatersolutions.com   |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
No it's wrong, the form now contains an empty dropdown list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:18:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:18:57 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-vrxVH8pt70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:19:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:19:02 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-8kR3iPT0Wn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69247|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69951&action=edit
Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl

To test:
1 - Run the circulation wizard with itemtypes as columns, shelving
locations as rows - display on screen
2 - Note all itemtype values are blank
3 - Switch rows/columns - same issue
4 - Apply patch
5 - Re-run reports
6 - Itemtypes should display correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:23:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:23:02 +0000
Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug
	12509
In-Reply-To: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19849-70-8zjdZ6krrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16621

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:23:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:23:02 +0000
Subject: [Koha-bugs] [Bug 16621] Translatability: Issues in opac-user.tt
 (sentence splitting)
In-Reply-To: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16621-70-g0rhzM8kXc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16621

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19849

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:23:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:23:24 +0000
Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug
	12509
In-Reply-To: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19849-70-dpFHhyw2V4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12509

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:23:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:23:24 +0000
Subject: [Koha-bugs] [Bug 12509] Untranslatable "Restriction added by
	overdues process"
In-Reply-To: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12509-70-SGZ616iRjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19849

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:33:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:33:47 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-2rpfn2YrFQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:44:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:44:49 +0000
Subject: [Koha-bugs] [Bug 19713] 2 occurrences of
 OpacShowLibrariesPulldownMobile have not been removed
In-Reply-To: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19713-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19713-70-JGUn89oP8v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to master for 18.05, congrats Priya for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:45:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:45:04 +0000
Subject: [Koha-bugs] [Bug 13676] OpacSuppression description says 'items'
 but means 'records'
In-Reply-To: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13676-70-meYmTZk4Fj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to master for 18.05, congrats Sherryn for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:45:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:45:14 +0000
Subject: [Koha-bugs] [Bug 18819] Correct "whereas UNIMARC tends to be used
 in Europe." in web installer files
In-Reply-To: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18819-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18819-70-frKOvVu0Eh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18819

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to master for 18.05, congrats Bonnie for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:45:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:45:30 +0000
Subject: [Koha-bugs] [Bug 18313] Remove Delicious icon from OPAC social
	network links
In-Reply-To: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18313-70-vbk0cNMF7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18313

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patch pushed to master for 18.05, congrats Isabel for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:46:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:46:18 +0000
Subject: [Koha-bugs] [Bug 19658] Style fix for staff client lists page
In-Reply-To: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19658-70-AFLKHZjZGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19658

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:46:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:46:24 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-K9fRhR2ugP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:46:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:46:13 +0000
Subject: [Koha-bugs] [Bug 19636] Hold priority changes incorrectly via
	dropdown select
In-Reply-To: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19636-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19636-70-jgRtH0EEOO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:46:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:46:29 +0000
Subject: [Koha-bugs] [Bug 19678] Clicking Cancel when adding New Course to
 course reserves shows message Invalid Course!
In-Reply-To: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19678-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19678-70-p2xvv1ArnG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19678

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:50:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:50:13 +0000
Subject: [Koha-bugs] [Bug 19851] New: Improve responsive layout handling of
 staff client menu bar
Message-ID: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

            Bug ID: 19851
           Summary: Improve responsive layout handling of staff client
                    menu bar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Created attachment 69952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69952&action=edit
Screenshot showing broken layout below 768 pixels wide

The built-in Bootstrap responsive layout makes the staff client's menu bar
behave badly at browser widths smaller than 768 pixels. I propose to add some
CSS to make it work somewhat better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:53:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:53:59 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-88zqsa3xnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #387 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69953&action=edit
Bug 7143: Update about page for new dev - Priya Patel

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:54:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:54:18 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-KpYDbG41DX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #388 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69954&action=edit
Bug 7143: Update about page for new dev - Sherryn Mak

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:54:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:54:32 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-SQQrqUtFlM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #389 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69955&action=edit
Bug 7143: Update about page for new dev - Bonnie Crawford

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:54:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:54:44 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-MWQFpfihWB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #390 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69956&action=edit
Bug 7143: Update about page for new dev - Isabel Grubi

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 17:55:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 16:55:20 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-lSLSevXdcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #391 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last four patches pushed to master for 18.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:00:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:00:17 +0000
Subject: [Koha-bugs] [Bug 19836] Make it possible to change the last pick-up
 date manually
In-Reply-To: <bug-19836-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19836-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19836-70-HOFj8GfDUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19836

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:00:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:00:37 +0000
Subject: [Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 24 + 25 (
 May and December 2017)
In-Reply-To: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19835-70-alxzn7t6Hd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:02:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:02:32 +0000
Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has
 been amended post receiving an order
In-Reply-To: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19780-70-3Azptmlgdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I applied this patch but in step 7 I still seem to have 14.00 shown in the
invoice.

I wonder if this patch would benefit from a test script too?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:04:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:04:06 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-GbHApCY6ll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 69957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69957&action=edit
Screenshot of the proposed updated interface

In the proposed revision, the logged-in user's name and branch would move to
the dropdown menu at lower screen widths.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:04:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:04:57 +0000
Subject: [Koha-bugs] [Bug 19852] New: Add message text box in circulation
 for patrons does not accept HTML tags
Message-ID: <bug-19852-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852

            Bug ID: 19852
           Summary: Add message text box in circulation for patrons does
                    not accept HTML tags
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: michael at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 69958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69958&action=edit
result after adding HTML tags for a patron message

Hi
  When you add a patron message in circulation.pl, the modal that appears has a
text box that does not accept HTML tags.  Some libraries use HTML tags in these
messages to link to information in Koha and to format the display of the
message (see attached).  Having this modal accept HTML would allow formatting
and linking in messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:13:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:13:07 +0000
Subject: [Koha-bugs] [Bug 19853] New: Limiting branch under authorized value
 categories REPORT_GROUP and REPORT_SUBGROUP does not hide reports on 'Saved
 Reports' page.
Message-ID: <bug-19853-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19853

            Bug ID: 19853
           Summary: Limiting branch under authorized value categories
                    REPORT_GROUP and REPORT_SUBGROUP does not hide reports
                    on 'Saved Reports' page.
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barton at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To replicate:

Prerequisites: Multi-branch system with branches 'A' and 'B'

1) Create a report with report group 'A Only' and sub-group 'No really, I mean
it, A only'.
2) Create authorised value under REPORT_SUBGROUP for 'No really, I mean it, A
only'. Limit this to branch A.
3) Log into the staff client and set the current branch to 'B'
4) Go to Home ? Reports ? Guided reports wizard ? Saved reports note that the
report shows in the list of saved reports.

Un-set the branch imit on the authorised value REPORT_SUBGROUP 'No really, I
mean it, A only', then go through steps 1-4 using REPORT_GROUP 'A Only'.

Note that the 'A Only' tab on 'Home ? Reports ? Guided reports wizard ? Saved
reports' will not display at library B, but the rows of reports themselves *do*
display.

This is a regression from 16.11.

Bug 10903 and Bug 16631 are slightly related, but these are talking about
limiting by borrower category, not branch; which is a feature that has never
been sponsored or implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:13:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:13:50 +0000
Subject: [Koha-bugs] [Bug 19853] Limiting branch under authorized value
 categories REPORT_GROUP and REPORT_SUBGROUP does not hide reports on 'Saved
 Reports' page.
In-Reply-To: <bug-19853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19853-70-IPVHo0godQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19853

Barton Chittenden <barton at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:18:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:18:23 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-zPFO7ZvdW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:18:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:18:26 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-vEagB89573@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67799|0                           |1
        is obsolete|                            |

--- Comment #5 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69959&action=edit
Bug 19200: Preventing warns when exporting a basket

To test:
1) Go to Tools -> CSV profiles -> New CSV Profile
2) Create a new CSV profile with any name of SQL fields. Ensure profile
type: SQL and usage: basket export in acquisition
3) Go to Acquisitions -> Find or create a vendor -> Use or create a
basket
4) Click the dropdown menu next to the 'Export as CSV' button. There
should be a 'Default' option and your new CSV profile (at least)
5) Click the 'Default' option. Notice warns
6) Click the 'Export as CSV' button. Notice warns
7) Click your new CSV profile option. Notice warns
8) Apply patch and refresh page
9) Repeat steps 5-7, confirm that warns do not show
10) Confirm export still works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:20:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:20:53 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-mkKzaMgebj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
That looks much better to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:28:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:28:20 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-8AJCztibaD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:28:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:28:23 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-1U95JwQRoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69702|0                           |1
        is obsolete|                            |

--- Comment #4 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69960&action=edit
Bug 19792 - Perf. boost for GetBudgetHierarchy

This patches reduces the number of SQL calls by combining multiple calls to the
recursive functions GetBudgetSpent(), GetBudgetOrdered(), etc. into 4 big
queries.
It also removes duplicate function calls from acqui-home.pl

Test plan:
0) Visit Acquisition home
0) Apply patch
1) Refresh page. It shoud look identical.
2) prove t/db_dependent/budgets.t

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:39:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:39:07 +0000
Subject: [Koha-bugs] [Bug 19854] New: dsfdfsd
Message-ID: <bug-19854-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19854

            Bug ID: 19854
           Summary: dsfdfsd
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard at myacpl.org
          Reporter: duitakeh002 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 69961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69961&action=edit
dsfsdfd

sdfsdf

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:41:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:41:50 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-d4IMSokDCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69922|0                           |1
        is obsolete|                            |

--- Comment #4 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 69962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69962&action=edit
Bug 19694: Force scalar context for output_pref called with billingdate

If no string is passed to output_pref, it needs to be called in scalar
context (to avoid a shift in the hash elements).
Here we have billingdate that is not defined yet (NULL)

Test plan:
- Search for an existing invoice
- Show details
- Changing shipping cost
- Save
- Verify the new amount is shown

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:41:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:41:48 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-biPe7SD794@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:43:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:43:18 +0000
Subject: [Koha-bugs] [Bug 19852] Add message text box in circulation for
 patrons does not accept HTML tags
In-Reply-To: <bug-19852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19852-70-kdIz3Ep55o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 18:50:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 17:50:57 +0000
Subject: [Koha-bugs] [Bug 19853] Limiting branch under authorized value
 categories REPORT_GROUP and REPORT_SUBGROUP does not hide reports on 'Saved
 Reports' page.
In-Reply-To: <bug-19853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19853-70-RTrsmk4Wmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19853

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:11:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:11:17 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-lQlnVNvaEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69907|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69963&action=edit
Bug 19828: Unit tests

This patch introduces unit tests for the changes this bug introduces to
Koha::Object->store.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests should fail because the changes are not implemented on this
patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:11:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:11:23 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-UzPvlfLc2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69908|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69964&action=edit
Bug 19828: Make Koha::Object->store translate DBIC exceptions into Koha
exceptions

This patch introduces a try/catch block in store() and parses the error
when an exceptional situation takes place.

It only deals with FK constraint violations and duplicate IDs. The rest of the
DBIC exceptions
are rethrown.

To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:11:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:11:36 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-VUoiBlh24Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69965&action=edit
Bug 19828: Fix tests that expect DBD errors instead of the exception message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:25:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:25:07 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-mloSViMjzq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69966&action=edit
Bug 19841: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:25:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:25:36 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-44YSrjQHr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:25:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:25:40 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-h2siceUudg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69967&action=edit
Bug 19841: Make AddMember raise an exception if categorycode is invalid

This patch makes C4::Members::AddMember raise a Koha::Exceptions::BadParameter
exception. The current behaviour is to just explode. Code calling
AddReturn should work as expected, unless they are looking for a
specific failure message.

It is just explodes in a way we know what happened, in the case the
categorycode is invalid.

To test:
- Apply the Unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> FAIL: Tests fail because AddReturn doesn't raise an exception
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:29:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:29:25 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-XEbTx2dl4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Note: 
- If the code is not catching problems, it is already failing, and it will now
fail in a different way. But no behaviour change.
- If the code is catching problems (either Try::Tiny or just eval) the thing to
test, is if the code handling the problem (in AddReturn) is expectig DBIC
specific exceptions, die, etc. I grepped the code and didn't find places in
which AddReturn is eval-ed and THEN the failure message is verified/inspected.

This means the behaviour is not changed by this patches. But another set of
eyes is welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:35:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:35:35 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-fePRjZEKti@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69967|0                           |1
        is obsolete|                            |

--- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 69968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69968&action=edit
Bug 19841: Make AddMember raise an exception if categorycode is invalid

This patch makes C4::Members::AddMember raise a Koha::Exceptions::BadParameter
exception. The current behaviour is to just explode. Code calling
AddReturn should work as expected, unless they are looking for a
specific failure message.

It is just explodes in a way we know what happened, in the case the
categorycode is invalid.

To test:
- Apply the Unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> FAIL: Tests fail because AddReturn doesn't raise an exception
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:38:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:38:32 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-YABMjvY6or@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:54:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:54:24 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-jZ53AL2XZq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69950|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:54:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:54:11 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-LW2MFXeAiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Arturo <alongoria at sll.texas.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:54:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:54:32 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-cOxfaAqmwu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 69969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69969&action=edit
Bug 19845: Do not generate a password if one is filled on selfreg

Bug 15343 allows patrons to choose their own passwords during
self-registration.
But this does not work if the PatronSelfRegistrationVerifyByEmail preference is
set to "Require." If e-mail verification is required, whatever password the
patron
supplied in the form is ignored, and they are given a randomly generated
password
once they click on the verification link.

Test plan:
1. Make sure there is a valid e-mail stored in the KohaAdminEmailAddress
preference.
2. Set PatronSelfRegistration to Allow.
3. Set PatronSelfRegistrationVerifyByEmail to Require.
3. Be sure "password" is listed in PatronSelfRegistrationBorrowerMandatoryField
and
NOT listed in PatronSelfRegistrationBorrowerUnwantedField.
4. Be sure there is a valid patron category in
PatronSelfRegistrationDefaultCategory.
5. Set PatronSelfRegistrationPrefillForm to "Display and prefill" so that you
can see
the generated password.

Then fill out the self-registration form, include a valid e-mail address, and
select
a password. Wait for the verification e-mail. Click on the link and you'll see
that
the password you entered in the form is used.

Signed-off-by: Arturo <alongoria at sll.texas.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:55:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:55:26 +0000
Subject: [Koha-bugs] [Bug 19854] dsfdfsd
In-Reply-To: <bug-19854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19854-70-C0RBBc69OS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19854

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69961|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:55:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:55:47 +0000
Subject: [Koha-bugs] [Bug 19854] spam
In-Reply-To: <bug-19854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19854-70-74l04dLqPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19854

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
            Summary|dsfdfsd                     |spam
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 20:58:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 19:58:41 +0000
Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records
In-Reply-To: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9302-70-QhZa3OrlHo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:03:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:03:21 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-UMnIEG9Ull@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

--- Comment #4 from Arturo <library at sll.texas.gov> ---
Wow, thank you for submitting a patch so quickly, Jonathan! You are awesome.

I just tested your patch and it worked like a charm. I tested it out with the
following preference configurations and they all were successful:

- Require e-mail verification and require user to select their own password
-- after verification, the user-supplied password was displayed and I was able
to log in with it

- Require e-mail verification but do not allow user to select their own
password
-- after verification, a random password was generated and displayed and I was
able to log in with it

- Don't require e-mail verification and require user to select their own
password
-- the user-supplied password was displayed and I was able to log in with it

- Don't require e-mail verification and do not allow user to select their own
password
-- a random password was generated and displayed and I was able to log in with
it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:04:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:04:04 +0000
Subject: [Koha-bugs] [Bug 19855] New: Move the "alert" code to
	Koha::Subscription
Message-ID: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

            Bug ID: 19855
           Summary: Move the "alert" code to Koha::Subscription
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

There are some weird subroutines in C4::Letters: addalert, getalert, delalert,
findrelatedto.
They have been designed to support different kind of alerts, but only emails
notification for new subscription issues is working correctly.

I suggest to clean, simplify and move this code to Koha::Subscription

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:12:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:12:23 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-wS6AXh39FW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

--- Comment #5 from Arturo <library at sll.texas.gov> ---
I also tested the scenario where a user can opt to select their own password
but it is not a required field. Regardless of whether the e-mail verification
preference is set to require, the expected behavior occurs. A random password
is generated if the user leaves the fields blank. The user-supplied password is
used if one is entered in the self-reg form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:20:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:20:23 +0000
Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
In-Reply-To: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19855-70-tPhXToEJLX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:20:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:20:27 +0000
Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
In-Reply-To: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19855-70-NxI2F74XaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69970&action=edit
Bug 19855: Remove getalert from moremember.pl

This is not used later and seems unused since:
commit b38997925f603dc9784c25d3db3501644c19e068
Date:   Wed Oct 26 09:11:02 2005 +0000
    big commit, still breaking things...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:20:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:20:32 +0000
Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
In-Reply-To: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19855-70-5e1E3tf5xn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69971&action=edit
Bug 19855: Remove getalert from opac-user.pl

This is not used later and seems unused since:
commit e61173aa8eb23c111a707eba2cfbd2003df709bf
Date:   Sun May 21 02:29:09 2006 +0000
    syncing dev-week and HEAD

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:20:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:20:35 +0000
Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
In-Reply-To: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19855-70-brH3sMPhhA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69972&action=edit
Bug 19855: Remove C4::Letters::findrelatedto

This subroutine is called only once. It only concat firstname and
surname for subscribers.
It can be easily replaced with Koha::Patron

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:20:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:20:39 +0000
Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
In-Reply-To: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19855-70-CQwhuhZLiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69973&action=edit
Bug 19855: Remove $type from the alerts

It looks like this feature has never been finished. It has been
developed with more flexibility in mind, but only 'issue' is used for
this parameter. Apparently it could have been 'virtual', for virtual shelves.

Let remove this parameter and clean the code a bit.
TODO: Remove the DB column

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:20:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:20:43 +0000
Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
In-Reply-To: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19855-70-GIUSXrpt7v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69974&action=edit
Bug 19855: Move getalert, addalert and delalert to Koha::Subscription

This patch removes 3 subroutines from C4::Letters:
- getalert
- addalert
- delalert

And add 3 methods to Koha::Subscription:
- subscribers
- add_subscriber
- remove_subscriber

It makes the code cleaner for future cleanup.
TODO - we should remove alert.alertid and alert.type, and rename
alert.externalid with alert.subscriptionid
That way alert will be renamed borrowers_subscriptions (or similar) and
will become a simple join table between borrowers and subscriptions.
We will need to deal with FK that could not be satisfied.
Let's do that after this patch is pushed.

Test plan:
Subscribe and unsubscribe to email notifications sent when a new issues
is available.
Make sure everything works as before and you receive the emails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:38:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:38:50 +0000
Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription
In-Reply-To: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19855-70-PrMPtW39fe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |15449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449
[Bug 15449] Move stuffs to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:38:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:38:50 +0000
Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace
In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15449-70-srT0QepEE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19855

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Bug 19855 - Move the "alert" code to Koha::Subscription


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855
[Bug 19855] Move the "alert" code to Koha::Subscription
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 21:46:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 20:46:55 +0000
Subject: [Koha-bugs] [Bug 19827] checkuniquemember is exported from C4::
 Members but has been removed
In-Reply-To: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19827-70-wCQtEhjSgp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19827

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 22:34:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 21:34:43 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-yt8hcLICJp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69010|0                           |1
        is obsolete|                            |

--- Comment #22 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69977&action=edit
Bug 17674 - Fix problem tabs

Signed-off-by: Sonia BOUIS <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 22:34:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 21:34:49 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-4iOMlQXkzz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69011|0                           |1
        is obsolete|                            |

--- Comment #23 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69978&action=edit
Bug 17674 - Add unit tests

https://bugs.koha-community.org/show_bug.cgi?id=17674

Signed-off-by: Sonia BOUIS <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 22:34:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 21:34:35 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-lfYTQ3qD59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69007|0                           |1
        is obsolete|                            |

--- Comment #21 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69976&action=edit
Bug 17674 - Allow UI to delete serials in batch

This new feature allows for batch deletion of serials through the UI.  The
current usage is a one-by-one long game.

Testing
- Have at least three serials, with items
- check the box to select two of them
- Press the Remove selected issues button
- Decide to delete their items as well or not
- Validate.

Sponsored by : CCSR

Signed-off-by: Sonia BOUIS <sonia.bouis at univ-lyon3.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 22:34:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 21:34:55 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-7wlFNxuNWe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69013|0                           |1
        is obsolete|                            |

--- Comment #24 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 69979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69979&action=edit
Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 22:37:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 21:37:51 +0000
Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17674-70-2DY8G6wqK8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #25 from Charles Farmer <charles.farmer at inlibro.com> ---
Had conflicting git apply, rebased the patch on the current master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 22:59:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 21:59:23 +0000
Subject: [Koha-bugs] [Bug 13793] The installer does not output the result of
 the update using Plack
In-Reply-To: <bug-13793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13793-70-UVZxpgME3Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19756


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756
[Bug 19756] Strange upgrade message from updatedatabase.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 22:59:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 21:59:23 +0000
Subject: [Koha-bugs] [Bug 19756] Strange upgrade message from
	updatedatabase.pl
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-oqV6oz0Ka5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13793
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(I am not sure about that I guess this has been added by bug 13793)


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13793
[Bug 13793] The installer does not output the result of the update using Plack
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:03:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:03:08 +0000
Subject: [Koha-bugs] [Bug 19756] Strange upgrade message from
	updatedatabase.pl
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-RKsTY3Aswj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:03:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:03:12 +0000
Subject: [Koha-bugs] [Bug 19756] Strange upgrade message from
	updatedatabase.pl
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-SAbbrkTeCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69980&action=edit
Bug 19756: Fix encoding issues during the update DB process

To display the output of the updatedatabase.pl under Plack, we redirect
the output to a temporary file, read it, then display it.
We need to open it specifying the correct encoding (utf-8).

Test plan:
1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000"
where variable="version";
2. restart plack
3. Login
4. Make the update from the interface
=> Without this patch you will see encoding issue:
Upgrade to 17.12.00.000 done (T? t?ia, t? haumatia)
=> With this patch applied you will see :
Upgrade to 17.12.00.000 done (T? t?ia, t? haumatia)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:03:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:03:45 +0000
Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from
	the interface
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-eUYVrb3Cnn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Strange upgrade message     |Encoding issues when update
                   |from updatedatabase.pl      |DB is run from the
                   |                            |interface

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:06:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:06:20 +0000
Subject: [Koha-bugs] [Bug 19712] Fix command line options of
	delete_records_via_leader.pl
In-Reply-To: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19712-70-MOIgJP3iOK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |11084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084
[Bug 11084] Delete biblios on Leader 05 =d
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:06:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:06:20 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-PA30WWsztj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19712


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712
[Bug 19712] Fix command line options of delete_records_via_leader.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:12:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:12:42 +0000
Subject: [Koha-bugs] [Bug 19712] Fix command line options of
	delete_records_via_leader.pl
In-Reply-To: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19712-70-IgJ1St8wAK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:13:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:13:08 +0000
Subject: [Koha-bugs] [Bug 19712] Fix command line options of
	delete_records_via_leader.pl
In-Reply-To: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19712-70-vTEW2qAhYw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69981&action=edit
Bug 19712: Fix test mode for delete_records_via_leader.pl

Test plan:
perl misc/cronjobs/delete_records_via_leader.pl
=> Should display a warning
perl misc/cronjobs/delete_records_via_leader.pl --test
=> Should not display a warning and script should not apply changes
perl misc/cronjobs/delete_records_via_leader.pl --confirm
=> Should not display a warning and script should apply changes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:13:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:13:17 +0000
Subject: [Koha-bugs] [Bug 19712] Fix command line options of
	delete_records_via_leader.pl
In-Reply-To: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19712-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19712-70-An8hkyRfhe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:17:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:17:05 +0000
Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers
In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15770-70-WqouLBquTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19711

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:17:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:17:05 +0000
Subject: [Koha-bugs] [Bug 19711] Too large a fine causes internal server
 error when viewing patron
In-Reply-To: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19711-70-R1Jsc3Lh5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19711

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15770

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 20 23:57:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 22:57:39 +0000
Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks
 when patron is searched for
In-Reply-To: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18474-70-6MJgKlhY7u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

NancyK. <nkeener at washoecounty.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nkeener at washoecounty.us

--- Comment #1 from NancyK. <nkeener at washoecounty.us> ---
I just had a staff member report this after our upgrade from 16.11 to 17.05
Looks like 17.05 broke a formerly good feature.
Anyone interested in fixing it back?  Please.

NancyK

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 00:33:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 23:33:07 +0000
Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers
In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15770-70-V9hRhxpBvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69982&action=edit
Bug 15770: Do not format numbers if too big

At several places we got the following error if we use numbers too big
for Number::Format
Template process failed: undef error - round() overflow. Try smaller
precision or use Math::BigFloat at /home/koha/src/Koha/Number/Price.pm line 44

It make the app explodes.
The goal here is to handle these errors gracefully and easily.

Test plan:
- Add a manual fine to a patron of 100000000000000
- Create a patron category with an enrolment fee of 123456789012345

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 00:33:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 23:33:02 +0000
Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers
In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15770-70-Jf2QTvzFOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 00:37:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 23:37:14 +0000
Subject: [Koha-bugs] [Bug 19711] Too large a fine causes internal server
 error when viewing patron
In-Reply-To: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19711-70-jhT0tanVDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19711

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 15770 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 00:37:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 23:37:14 +0000
Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers
In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15770-70-gIgOFmWliT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 19711 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 00:37:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 23:37:24 +0000
Subject: [Koha-bugs] [Bug 19711] Too large a fine causes internal server
 error when viewing patron
In-Reply-To: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19711-70-iE7NNCoQ0A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19711

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=15770                   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 00:37:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 23:37:24 +0000
Subject: [Koha-bugs] [Bug 15770] Number::Format issues with large numbers
In-Reply-To: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15770-70-kMLYB0tKzA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=19711                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 00:58:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Dec 2017 23:58:55 +0000
Subject: [Koha-bugs] [Bug 19698] "Add message" for patron don' t use OPAC
 description if message type is OPAC
In-Reply-To: <bug-19698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19698-70-oMnFbxl4L1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19698

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Sophie,

The "type" of the message can be either "L" or "B" (Librarian/staff and
Borrower/opac, I guess).
If you use "intranet", the message will be displayed on the patron's page,
staff-side.
If you pick "opac", it will be displayed on the patron's pages (opac-user and
sco).

Does it make sense?

Marking as invalid, please reopen if I misunderstood.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 01:14:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 00:14:39 +0000
Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from
	the interface
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-teBPJtQno7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 01:14:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 00:14:43 +0000
Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from
	the interface
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-bhdF0QH5zz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69980|0                           |1
        is obsolete|                            |

--- Comment #4 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 69983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69983&action=edit
Bug 19756: Fix encoding issues during the update DB process

To display the output of the updatedatabase.pl under Plack, we redirect
the output to a temporary file, read it, then display it.
We need to open it specifying the correct encoding (utf-8).

Test plan:
1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000"
where variable="version";
2. restart plack
3. Login
4. Make the update from the interface
=> Without this patch you will see encoding issue:
Upgrade to 17.12.00.000 done (T? t?ia, t? haumatia)
=> With this patch applied you will see :
Upgrade to 17.12.00.000 done (T? t?ia, t? haumatia)

Signed-off-by: Liz Rea <liz at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 01:40:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 00:40:21 +0000
Subject: [Koha-bugs] [Bug 19673] Patron batch modification tool cannot use
 authorised value "0"
In-Reply-To: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19673-70-UdlkwjT1rF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 69984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69984&action=edit
Bug 19673: Allow to set patron attributes to 0 with batch patron modification

This patch will have to be tested deeply to make sure it will not
introduce regression!

The idea is to display an empty option in the patron attributes select
and ignore it. That way we can deal with false values 0 and "" which
were skipped before.

Test plan:
Add several patron attributes
Use the batch patron modification tool to add/update/remove them
Play with empty "" and 0 values, as well as other values
Modify several attributes in a row

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 01:40:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 00:40:18 +0000
Subject: [Koha-bugs] [Bug 19673] Patron batch modification tool cannot use
 authorised value "0"
In-Reply-To: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19673-70-tNH023wUjV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 01:40:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 00:40:40 +0000
Subject: [Koha-bugs] [Bug 19673] Patron batch modification tool cannot use
 authorised value "0"
In-Reply-To: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19673-70-cq0a8F64U6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.05                       |master
           Severity|minor                       |normal
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 01:47:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 00:47:49 +0000
Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once
In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8179-70-Ktn8vfIf0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com
                   |                            |,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 02:10:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 01:10:07 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-ShwDvoIojy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #3)

> Would it make more sense?

hi Jonathan,
Yes I believe your fix makes more sense so I have implemented in the next
patch.

When I was testing, I also found a new warn when looking at a course with NO
course reserves in it (course_reserves/course-details.pl)
Argument "" isn't numeric in numeric gt (>) at
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
line 219.

Also, when deleting a course with no course reserves, the confirm message is
not triggered.

I've added a fix for this also in my next patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 02:11:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 01:11:46 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-i5u3jLkddE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69946|0                           |1
        is obsolete|                            |

--- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69985&action=edit
Bug 19230: Preventing warn when deleting course

To test:
1) Ensure UseCourseReserves is enabled
2) Go to Course Reserves, create a course
3) When you are taken to the course page, you should notice the
'Argument "" isn't numeric in numeric gt' warn
4) Delete course
5) Notice warn, and that no confirm message popped up
6) Apply patch
7) Create a course again. Confirm the 'Argument "" isn't numeric in
numeric gt' warn did not show
8) Delete the course
9) Notice no warn and the confirm message pops up

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 02:11:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 01:11:42 +0000
Subject: [Koha-bugs] [Bug 19230] Warn when deleting a course in course
	reserves
In-Reply-To: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19230-70-ri8IaUoCh6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 04:38:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 03:38:13 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-JDU3u4u930@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #65 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 69986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69986&action=edit
Bug 19532: POD fix, renaming methods

Tomas's comments:
- renaming 'Class methods' to 'internal methods'
- renaming 'borrower' and 'branch' methods to 'patron' and 'library'

other comments are out of date with current patches and do not need to
be actioned

when testing, confirm all data still shows as expected and nothing is
broken

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 08:15:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 07:15:26 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-ESxMuCv2Lu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |simon.pouchol at biblibre.com
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Simon, please make sure to assign the bug to yourself when you provide a
patch, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 08:15:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 07:15:55 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-ITj7mx0Jh6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|simon.pouchol at biblibre.com  |oleonard at myacpl.org

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah... misread, changing back and sorry. No more bugs before breakfast :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 08:24:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 07:24:52 +0000
Subject: [Koha-bugs] [Bug 19856] Improve styling of reports sidebar to match
 tools sidebar
In-Reply-To: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19856-70-DsqaKZGThc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19664


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664
[Bug 19664] Reports sidebar menu should match list of reports on reports home
page
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 08:24:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 07:24:52 +0000
Subject: [Koha-bugs] [Bug 19664] Reports sidebar menu should match list of
 reports on reports home page
In-Reply-To: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19664-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19664-70-zaghiqvzw4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19664

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19856


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856
[Bug 19856] Improve styling of reports sidebar to match tools sidebar
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 08:24:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 07:24:44 +0000
Subject: [Koha-bugs] [Bug 19856] New: Improve styling of reports sidebar to
 match tools sidebar
Message-ID: <bug-19856-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19856

            Bug ID: 19856
           Summary: Improve styling of reports sidebar to match tools
                    sidebar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Use styling from tools sidebar for reports sidebar as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 08:40:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 07:40:32 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-VHoclPRxHG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 08:40:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 07:40:35 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-UCg4iunwJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69081|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 69987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69987&action=edit
Bug 19573: Link to make a new list in masthead in OPAC only appears / works if
no other list already exists

This patch corrects the OPAC masthead include file so that the "New
list" link will appear whether or not the logged-in user has existing
private lists.

To test, apply the patch and log into the OPAC as both a user with
private lists and a user without private lists. The header's "Lists"
dropdown menu should include a "New list" link in both cases.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 09:04:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 08:04:12 +0000
Subject: [Koha-bugs] [Bug 19551] Cash register report has bad erroneous
 results from wrong order of operations
In-Reply-To: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19551-70-UmiaCtar6H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19551

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Code has changed a lot because of Bug 19061 that is not in 17.05.x.
If this is needed for 17.05.x, please provide a rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 09:05:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 08:05:30 +0000
Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date
 for serials in opac
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-0qAIFVkt7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com
         QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 09:08:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 08:08:26 +0000
Subject: [Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's
 date acquired field
In-Reply-To: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19595-70-uJi6xdu1Op@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 09:12:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 08:12:13 +0000
Subject: [Koha-bugs] [Bug 19674] Broken indicators of changed fields in
 manage staged MARC records template
In-Reply-To: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19674-70-gpFJNTRrOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 09:15:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 08:15:27 +0000
Subject: [Koha-bugs] [Bug 12497] Make OPAC search history feature accessible
 when it should
In-Reply-To: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12497-70-crKDf2eq1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12497

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 09:34:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 08:34:55 +0000
Subject: [Koha-bugs] [Bug 18907] Warning "dpkg-source: warning: relation <
 is deprecated: use < < or <="
In-Reply-To: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18907-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18907-70-xDWbJIxTYL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18907

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 10:50:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 09:50:46 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-afHU2pO66Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Patch does not apply to 17.05.x because it is still $member hash instead of
$patron object.
Rebase looks tricky, please provide rebased patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 10:54:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 09:54:56 +0000
Subject: [Koha-bugs] [Bug 19775] Search/History.t is failing randomly
In-Reply-To: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19775-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19775-70-fDENJaR9Vz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19775

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 10:55:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 09:55:33 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-wkl4xQEt6C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 10:58:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 09:58:54 +0000
Subject: [Koha-bugs] [Bug 19751] Holds awaiting pickup report should not be
	fixed-width
In-Reply-To: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19751-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19751-70-XBhTPYF4pH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Pushed to 17.05.x, will be in v17.05.07

This looks more bug than enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:00:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:00:02 +0000
Subject: [Koha-bugs] [Bug 19292] Add MARC code column on libraries list
In-Reply-To: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19292-70-Ok2GvSVSlU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Pushed to Stable            |RESOLVED

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 10132 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:00:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:00:18 +0000
Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date
 for serials in opac
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-PlhipnPi9B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69003|0                           |1
        is obsolete|                            |

--- Comment #22 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 69988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69988&action=edit
Bug 11976: Counter patch using Column Settings

As per Nick Clemen's suggestion from comment #6,
system preferences may not be the best way.

Using Home->Administration->Column Settings->OPAC->subscriptionst
the fields visibility can be toggled.

TEST PLAN
---------
1) Have a subscription where you have received at least once.
2) Look for it in OPAC and note the date is the received date, not the
publication date
3) Apply patch
4) Log in to staff client
5) Home->Administration->Column Settings->OPAC->subscriptionst
6) Set visibility as desired.
7) Refresh OPAC page
   -- everything should be as expected.
8) run koha qa test tools.

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:00:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:00:47 +0000
Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date
 for serials in opac
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-Q1xnGmosW8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:05:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:05:48 +0000
Subject: [Koha-bugs] [Bug 19439] Some error responses from opac/unapi get
	lost in eval
In-Reply-To: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19439-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19439-70-LHC7I854Ig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
         Resolution|---                         |FIXED

--- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Depends on Bug 17797 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:17:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:17:01 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-8SwXGygKIW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com
                   |y.org                       |
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:21:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:21:33 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-Yu8qFY1E0n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

--- Comment #6 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Is the if() else() statement still usefull? Why not just one call to
GetBasketAsCSV?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:35:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:35:09 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-4KgAphbFDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:35:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:35:22 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-gSGSdiXlLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com
                   |y.org                       |
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:46:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:46:06 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-bjL2Q4iu4d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69934|0                           |1
        is obsolete|                            |
  Attachment #69935|0                           |1
        is obsolete|                            |
  Attachment #69936|0                           |1
        is obsolete|                            |
  Attachment #69937|0                           |1
        is obsolete|                            |
  Attachment #69938|0                           |1
        is obsolete|                            |

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69989&action=edit
Bug 19808: Handle deleted reviewers gracefully - opac-detail

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:46:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:46:14 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-mKOgUvehoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69990&action=edit
Bug 19808: (follow-up) Handle deleted reviewers gracefully - opac-detail

Make the tests easier to read

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:46:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:46:16 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-6XRlyB53TY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69991&action=edit
Bug 19808: Handle deleted reviewers gracefully - opac-showreview

Test plan:
- Create reviews
- Delete some reviewers
- Enable OpacShowRecentComments
- Go to opac/opac-showreviews.pl
- Go to opac-showreviews.pl?format=rss

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:46:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:46:19 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-BayWAqPbp0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69992&action=edit
Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl

Test plan:
- Create reviews
- Delete some reviewers
- Go to Home ? Tools ? Comments ? Comments awaiting moderation

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:46:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:46:22 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-yKbWwT1txs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69993&action=edit
Bug 19808: Do not display 'Added' alone

It seems that reviews.datereviewed ends with NULL in DB.
It is caused by another issue that will be fixed on another bug report.

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:46:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:46:48 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-ar31W8sd89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:49:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:49:18 +0000
Subject: [Koha-bugs] [Bug 18231] Add the missing id-column to
 koha.issuingrules-table for DBIC fixtures
In-Reply-To: <bug-18231-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18231-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18231-70-0EyUCYIKWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18231

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:52:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:52:34 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-YVQnZHJSHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:54:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:54:18 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-jjrjgSTXnp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:54:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:54:21 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-HwKXTqp738@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67174|0                           |1
        is obsolete|                            |
  Attachment #67175|0                           |1
        is obsolete|                            |
  Attachment #67176|0                           |1
        is obsolete|                            |

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69994&action=edit
Bug 15752 - Automatically switch patron during circulation

With this syspref enabled scanning a patron barcode into the item
barcode field during circulation will redirect you to the patron's
circulation page.

This allows circulation with only a barcode scanner.

Testing:

- Enable the AutoSwitchPatron syspref
- Navigate to a patron's check out screen
- Enter a patron barcode into the "Enter item barcode" field

Result
- Browser should be redirected to the entered patron

Signed-off-by: Joel <aloi54 at live.fr>

Followed test plan, patch works as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:54:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:54:32 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-xJ2bu3fPud@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69996&action=edit
Bug 15752: QA followup - inform user that patron was automatically switched

Test plan:

1) Start checking out to some patron - there should be no message about
auto switching
2) read the another patrons card - note the patron is switched and there
is a message about it at top of the main page content

Followed test plan, patch worked as described. Passed QA test tool
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 11:54:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 10:54:29 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-7jJ0JgEQSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69995&action=edit
Bug 15752: QA followup - search for patrons only if param barcode is defined

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:04:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:04:56 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-srYB6NCCtt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #16 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello,
just for information, we apply it on the top of a koha 16.11.12 and test it
with our own marc file and our own model. 
We launch this command :
stage_file.pl --encoding UTF-8 --file export_201710031044.mrc --add-items
--marcmodtemplate "test"

It works as expected, the modification model is apllied but there's several
warnings :
ERROR occurred in SetUTF8Flag Field 020 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
ERROR occurred in SetUTF8Flag Field 245 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
ERROR occurred in SetUTF8Flag Field 020 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
ERROR occurred in SetUTF8Flag Field 245 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
ERROR occurred in SetUTF8Flag Field 020 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
ERROR occurred in SetUTF8Flag Field 245 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm
line 696.
ERROR occurred in SetUTF8Flag Field 020 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
ERROR occurred in SetUTF8Flag Field 245 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
Use of uninitialized value in join or string at /usr/share/perl5/MARC/Field.pm
line 696.
ERROR occurred in SetUTF8Flag Field 020 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.
ERROR occurred in SetUTF8Flag Field 245 must have at least one subfield at
/home/koha/src/C4/Charset.pm line 145.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:18:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:18:39 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-WlFRHXWmhN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:18:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:18:42 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-nSSQTdsbDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69627|0                           |1
        is obsolete|                            |
  Attachment #69628|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69997&action=edit
Bug 19725: Add failing test

Also fix tests for UNIMARC

Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it FAILS

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:19:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:19:21 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-Nc3BkC5zHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69998&action=edit
Bug 19725: OAI-PMH - Use biblio_metadata.timestamp

Since bug 17196, biblioitems.timestamp is not always updated after a
change in the MARC record.
Filtering should be based on biblio_metadata.timestamp instead.

Test plan:
1. prove t/db_dependent/OAI/Server.t
2. Verify that it SUCCEEDS

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:21:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:21:48 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-VL6ScHWFE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:23:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:23:03 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-XURZ5mcpx8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69860|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 69999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69999&action=edit
Bug 19599: Speed anonymise_issue_history up

The query generated by anonymise_issue_history is unecessary complex and
can be very slow on large DB.
With this patch we will execute one query per patron instead.

See patch "Bug 19599: Simplify the query" on the bug report for an
alternative.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:23:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:23:00 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-gq5ZKsreSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:29:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:29:22 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-capV6OaPQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
I don't think this is a complete enough solution. We have two choices:
A) Hide auto-calc if cardnumber is mandatory
B) Strip cardnumber from mandatory fields if auto calc is enabled

This patch does A, which is fine. But what I think either solution needs is
to display a warning to the library that autocalc and BorrowerMandatoryField
are in conflict with each other. Otherwise libraries won't understand why
autocalc isn't working even though it's enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:30:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:30:07 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-jlPI1I7Eth@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:30:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:30:38 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-BqpzibXZk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:30:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:30:41 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-1VkvUuv0eS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69948|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70000&action=edit
Bug 19843: (bug 15839 follow-up) Set reviews.datereviewed when the review is
made

Caused by
  commit 092ae340cef375cc66c8511fd34c1a4eec9c7ba6
    Bug 15839: Koha::Reviews - Remove savereview

the datereviewed=now() part of the query has not been translated.

Test plan:
Add a review from the OPAC
Confirm that the reviews.datereviewd has been correctly set. Without
this patch it is set to NULL.

I have no idea how we could update existing data :-/

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:32:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:32:00 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-dySTnAQKj4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:37:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:37:55 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-gcA4EjzPwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:38:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:38:00 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-6vXnQVydJO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69962|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70001&action=edit
Bug 19694: Force scalar context for output_pref called with billingdate

If no string is passed to output_pref, it needs to be called in scalar
context (to avoid a shift in the hash elements).
Here we have billingdate that is not defined yet (NULL)

Test plan:
- Search for an existing invoice
- Show details
- Changing shipping cost
- Save
- Verify the new amount is shown

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:41:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:41:07 +0000
Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items"
 option and add " Removes non-local records" option for existing
 functionality
In-Reply-To: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18201-70-FE9QADzu1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:41:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:41:10 +0000
Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items"
 option and add " Removes non-local records" option for existing
 functionality
In-Reply-To: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18201-70-Th7xuoJzaK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68499|0                           |1
        is obsolete|                            |
  Attachment #68500|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70002&action=edit
Bug 18201 - Export data -Fix "Remove non-local items" option and add "Removes
non-local records" option for existing functionality

It turns out the modules had the option expected  built in, we just didn't call
it. This patch set expands the options for passing to the export.

To test:
1 - Go to Tools->Export data
2 - Perform an export and check 'Remove non-local items'
3 - Note that file contains only 'local' records, but includes all items
on those records
4 - Apply patch
5 - Note Tools->Export data has a new option to remove records not owned
by logged in branch
6 - Export as before checking records option, file should be as before
7 - Now check 'Remove items not owned by logged in branch'
8 - File should now only have local items (may have empty records)
9 - Check both boxes and recieve only 'local' records and items

Signed-off-by: Scott Kehoe <scott at masslibsystem.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:41:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:41:17 +0000
Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items"
 option and add " Removes non-local records" option for existing
 functionality
In-Reply-To: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18201-70-ZT1N4dU2XI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70003&action=edit
Bug 18201 - Unit tests

To test:
1. prove -v t/db_dependent/Exporter/Record.t
2. Tests should pass/be green/make the day a little brighter

Signed-off-by: Scott Kehoe <scott at masslibsystem.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:48:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:48:41 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-l8oLSg8NrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:48:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:48:44 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-916g09vgsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69492|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70004&action=edit
Bug 19450: Fixed WebService::ILS bug upsteram

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:54:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:54:09 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-31SbLK8ZBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:56:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:56:07 +0000
Subject: [Koha-bugs] [Bug 19857] New: Optionally hide SMS provider field in
 patron modification screen
Message-ID: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

            Bug ID: 19857
           Summary: Optionally hide SMS provider field in patron
                    modification screen
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Optionally hide SMS provider field in patron modification screen with
BorrowerUnwantedField system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:56:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:56:30 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-kswrg4T6YA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |9021
           Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021
[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send
drivers
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:56:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:56:30 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS:: Send drivers
In-Reply-To: <bug-9021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-TtNB0vMDlW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19857


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857
[Bug 19857] Optionally hide SMS provider field in patron modification screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:57:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:57:17 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-mpt0KBgHxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:57:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:57:27 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-Lb4oLd5Ugi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70006&action=edit
Bug 17770: Improve perlcritic level

before patch: perlcritic -4 noisy
after patch: perlcritic -4 ok

Signed-off-by: Your Full Name <your_email>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:57:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:57:30 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-4ImmvjVmtz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70007&action=edit
Bug 17770: Perltidy

Signed-off-by: Your Full Name <your_email>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:57:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:57:20 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-aMszjKihaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69741|0                           |1
        is obsolete|                            |
  Attachment #69742|0                           |1
        is obsolete|                            |
  Attachment #69743|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70005&action=edit
Bug 17770: Sitemapper.t fails if date changes during test run

To compensate, DateTime->now is mocked to the current date.

Signed-off-by: Your Full Name <your_email>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:59:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:59:13 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-Dz1KqtjmFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 12:59:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 11:59:15 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-wn5A70qDy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

--- Comment #1 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 70008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70008&action=edit
Bug 19857: Use BorrowerUnwantedField system preference for SMS provider
selection

Optionally hide SMS provider field in patron modification screen with
BorrowerUnwantedField system preference.

To test:
1. Apply patch
2. Append BorrowerUnwantedField with sms_provider_id and save changes
3. Go to patron modification screen in staff client
4. Observe the SMS provider selection is now hidden

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 13:02:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 12:02:29 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-yRWan1N9Ai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Alex Arnaud <alex.arnaud at biblibre.com> ---
QA comments:

Please fix indentation (moremember.pl lines 341 342 and 343)

if ( $input->param('from') == "moremember" )
# Always true. Use eq instead of ==
# This cause deleting a message from checkout page redirects to moremembers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 13:14:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 12:14:55 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-6ZKmBGcEjE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 13:16:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 12:16:29 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-I7S4BeXGht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 13:16:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 12:16:31 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-iZHgLNmQ2S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69969|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70009&action=edit
Bug 19845: Do not generate a password if one is filled on selfreg

Bug 15343 allows patrons to choose their own passwords during
self-registration.
But this does not work if the PatronSelfRegistrationVerifyByEmail preference is
set to "Require." If e-mail verification is required, whatever password the
patron
supplied in the form is ignored, and they are given a randomly generated
password
once they click on the verification link.

Test plan:
1. Make sure there is a valid e-mail stored in the KohaAdminEmailAddress
preference.
2. Set PatronSelfRegistration to Allow.
3. Set PatronSelfRegistrationVerifyByEmail to Require.
3. Be sure "password" is listed in PatronSelfRegistrationBorrowerMandatoryField
and
NOT listed in PatronSelfRegistrationBorrowerUnwantedField.
4. Be sure there is a valid patron category in
PatronSelfRegistrationDefaultCategory.
5. Set PatronSelfRegistrationPrefillForm to "Display and prefill" so that you
can see
the generated password.

Then fill out the self-registration form, include a valid e-mail address, and
select
a password. Wait for the verification e-mail. Click on the link and you'll see
that
the password you entered in the form is used.

Signed-off-by: Arturo <alongoria at sll.texas.gov>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 13:21:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 12:21:59 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-2EyUQSJXAy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 13:43:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 12:43:31 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-8glF0jDF3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

--- Comment #17 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
OK, I'll take a look at this in a day or so.  Assigned back to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 13:52:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 12:52:54 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-uB1UHdSFy7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #18 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
I don't suppose you could upload a copy of "export_201710031044.mrc" so that I
can make sure that I'm playing with the same file.  Also are you using MARC 21
or UNIMARC?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:08:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:08:43 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-3Z88iM6Czs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #7)
> We could just add something like: If you are using a debian-based system you
> can use the koha-shell command otherwise you should check your permissions.

Maybe "Try running this again as the koha instance user (or use the koha-shell
command in debian)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:11:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:11:15 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-17XZPHVLVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69966|0                           |1
        is obsolete|                            |

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70010&action=edit
Bug 19841: Unit tests

This patch introduces unit tests for the new behaviour of AddMember
(raising an exception if the passed categorycode is not valid.

 To test:
 - Apply this patch
 - Run:
   $ kshell
  k$ prove t/db_dependent/Members.t
=> FAIL: It should fail because the feature is still not implemented.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:11:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:11:22 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-fuBQ6v5mtc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69968|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70011&action=edit
Bug 19841: Make AddMember raise an exception if categorycode is invalid

This patch makes C4::Members::AddMember raise a Koha::Exceptions::BadParameter
exception. The current behaviour is to just explode. Code calling
AddReturn should work as expected, unless they are looking for a
specific failure message.

It is just explodes in a way we know what happened, in the case the
categorycode is invalid.

To test:
- Apply the Unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> FAIL: Tests fail because AddReturn doesn't raise an exception
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> SUCCESS: Tests pass!
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:11:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:11:48 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-d5bVbBgGHI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70012&action=edit
Bug 19496: [17.05.x] Fixing to_address for patron notes

This patch ensures the patron note to_address is the branch email or the
Koha Admin email, and the from_address is the patron's email.

To test:
1) Ensure syspref 'allowcheckoutnotes' is turned on
2) Go to OPAC, leave a note on a checkout
3) Confirm that the note is received (in mysql message_queue) but the
to_address is the patron's email - this is wrong
4) Apply patch and refresh OPAC
5) Leave a note on a checkout
6) Confirm that the note is received in message queue
7) Confirm that the to_address is one of:
- branch email
- branch reply to
- syspref ReplytoDefault
- syspref KohaAdminEmailAddress
8) Confirm that the from_address is one of:
- patron email
- patron emailpro
- patron B_email

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:11:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:11:56 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-3y5CIo8uMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70013&action=edit
Bug 19496: [17.05.x] ReplytoDefault is a pref, not a C4::Context method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:12:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:12:43 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
 emailed as indicated
In-Reply-To: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19496-70-WPgZKHE2kZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Fridolin SOMERS from comment #9)
> Patch does not apply to 17.05.x because it is still $member hash instead of
> $patron object.
> Rebase looks tricky, please provide rebased patches.

Done, please test!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:23:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:23:00 +0000
Subject: [Koha-bugs] [Bug 19801] Internal note added to the detail's user
	page
In-Reply-To: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19801-70-9APluxkjxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
A quick note: we usually use the "messages" TT variables for warning or
information messages to display on the screen.
Maybe it would be good to rename it ("patron_messages"?) to avoid confusion
later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:25:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:25:55 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-gRIgdDFPHH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70014&action=edit
Bug 19760: Change wording

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:26:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:26:34 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-chn57EpQG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:26:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:26:41 +0000
Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice
 from invoice search
In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19429-70-C3mPKT8ezo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:27:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:27:36 +0000
Subject: [Koha-bugs] [Bug 19293] Internal server error when receiving
 shipment with order with deleted biblio
In-Reply-To: <bug-19293-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19293-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19293-70-89QVoirzra@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:28:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:28:09 +0000
Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
In-Reply-To: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2696-70-zqM17GMDdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
                   |ity.org                     |
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:28:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:28:42 +0000
Subject: [Koha-bugs] [Bug 19295] Add specific Marc handling for Czech
 National Authority File
In-Reply-To: <bug-19295-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19295-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19295-70-l9jluNKIAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19295

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
The Conspect method could be useful too (field 072 in biblio, 190 in authority)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:29:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:29:13 +0000
Subject: [Koha-bugs] [Bug 19293] Internal server error when receiving
 shipment with order with deleted biblio
In-Reply-To: <bug-19293-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19293-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19293-70-m1IEG29kjS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19293

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|Signed Off                  |RESOLVED

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Fixed already by bug 19596.

*** This bug has been marked as a duplicate of bug 19596 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:29:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:29:13 +0000
Subject: [Koha-bugs] [Bug 19596] Internal server error if open order with
 deleted biblio / null biblionumber
In-Reply-To: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19596-70-2IppE9aAG9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19596

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 19293 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:34:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:34:04 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-oc2nbLLi5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We seem to have the same problem in 16.11 - but the patch here doesn't apply
and the errors are different:

Can't call method "branchname" on an undefined value at
/home/vagrant/kohaclone/serials/routing-preview.pl line 69.

I will file a new bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:35:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:35:32 +0000
Subject: [Koha-bugs] [Bug 19858] New: [16.11] Routing list preview/printing
	broken
Message-ID: <bug-19858-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19858

            Bug ID: 19858
           Summary: [16.11] Routing list preview/printing broken
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

The routing list preview and print are broken in 16.11.x. The error from the
plack log is:

Can't call method "branchname" on an undefined value at
/home/vagrant/kohaclone/serials/routing-preview.pl line 69.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:37:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:37:14 +0000
Subject: [Koha-bugs] [Bug 19766] Preview routing slip is broken
In-Reply-To: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19766-70-uxYplyzfrC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19858

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:37:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:37:14 +0000
Subject: [Koha-bugs] [Bug 19858] [16.11] Routing list preview/printing broken
In-Reply-To: <bug-19858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19858-70-7xbZ6VL7VO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19858

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19766

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:38:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:38:59 +0000
Subject: [Koha-bugs] [Bug 19859] New: Add option to return to the search
 result in authorities
Message-ID: <bug-19859-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19859

            Bug ID: 19859
           Summary: Add option to return to the search result in
                    authorities
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi, 

It is imposible to return to hte result search when you edit an authorities in
a record. When we want to edit an authorities in a record, we can clic on the
tag editor. That option will open a search page. In this search page you can 
search authorities. If you clic on edit authorities that action will be open
into the authorities module. If you clic on save, you stay in authorities
module and you don't return on the search page of the tag editor. Because of
that, if you had made some changes in the authoritie, you can't clic on choose
for linking to the record.

To  recreate:

Go to a record

Edit an authoritie with tag editor

Search an authoritie with this plugin

Choose an authoritie and clic on edit authorities

Clic on Save 

Notice that you still in the authorities modul and you can?t link this
authoritie in your record. For make this link you have to "go back" two times
ank clic on choose or make this search another time.


Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:28 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-6Yp6TgWogN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:38 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-ceSy5KKePS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70016&action=edit
Bug 19522: Coding style: Fix alignement after previous patch

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:30 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-CsC04DAWZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68973|0                           |1
        is obsolete|                            |
  Attachment #68974|0                           |1
        is obsolete|                            |
  Attachment #68975|0                           |1
        is obsolete|                            |
  Attachment #68976|0                           |1
        is obsolete|                            |
  Attachment #68977|0                           |1
        is obsolete|                            |
  Attachment #68978|0                           |1
        is obsolete|                            |
  Attachment #68979|0                           |1
        is obsolete|                            |

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70015&action=edit
Bug 19522: Label creator - some strings are not translatable

Add missing case to make "Fields to print" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout
3. ensure that the list isn't empty
4. then you should see "Fields to print" in the table header
5. apply this patch
6. update the language
7. open misc/translator/po/fr-FR-staff-prog.po
8. translate the new string with something like "foobar"
   and remove the fuzzy flag
9. install the language
10. refresh the page
11. then you should see "foobar" instead of "Fields to print"

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:41 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-24s7Y9DtYP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70015|0                           |1
        is obsolete|                            |

--- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70017&action=edit
Bug 19522: Label creator - some strings are not translatable

Templates: new form:
Add hardcoded unit names to make them translatable.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new
3. then you should see the "Unit?s" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unit?s" dropdown with french units

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:44 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-f2PQkzdHAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70018&action=edit
Bug 19522: Coding style: Replace tabs with spaces

In Label creator: Templates: new/edit form

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:48 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-gCG4XoAjMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70019&action=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "cr?er un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "cr?er un nouveau lot ."

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:51 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-3Mc9GsVmt8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70020&action=edit
Bug 19522: Label creator: edit batch: make Call number translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. then you should see "Call number" in the column names
6. apply this patch
7. install the fr_FR locale
8. refresh the page
9. then you should see "Cote" in the column names

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:46:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:46:54 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-ZFg2LUmMP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70021&action=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des ?tiquettes"

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:50:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:50:02 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-Y7ugRFTnGY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70022&action=edit
Bug 19315: Prevent crash if no items and not library set for the subscription

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:51:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:51:14 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-JwncZGrkab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:51:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:51:16 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-BVSwZbLVwe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70023&action=edit
Bug 19851: Improve responsive layout handling of staff client menu bar

This patch modifies CSS and markup in the staff client header to
override the default responsive style of the menu bar. The changed
layout will keep the menu bar items in a horizontal line at lower screen
widths.

To test, apply the patch and clear your browser cache if necessary.

 - Log in to the staff client and confirm that the appearance of the
   menu bar at the top of the screen looks correct at various browser
   widths.
 - Confirm that the logged-in user menu label and help link expand and
   collapse according to browser width.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:54:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:54:01 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-NsPEBhHC02@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:54:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:54:07 +0000
Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice
 from invoice search
In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19429-70-LMsyZ5Gq82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:55:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:55:50 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-BqXAxJD58p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #12)
> Created attachment 70022 [details] [review]
> Bug 19315: Prevent crash if no items and not library set for the subscription
> 
> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

This patch has been pushed to master for 18.05

The first 2 patches have been pushed already to 17.11 and 17.05, this one must
be pushed as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:56:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:56:15 +0000
Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice
 from invoice search
In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19429-70-uak3fv1QsS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67968|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70024&action=edit
Bug 19429: Adding confirm message when deleting invoice from invoice search
page

To test:
To test:
1) Go to Acquisitions
2) Go to Invoices (left nav menu)
3) Click Search (no need to filter results)
4) Click dropdown menu for an invoice, click Delete
5) Notice invoice is deleted instantly
6) Apply patch and repeat steps 3 and 4
7) Confirm the confirm message shows and works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 14:56:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 13:56:12 +0000
Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice
 from invoice search
In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19429-70-X7yVP7TzPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:01:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:01:02 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-TkwFfue48o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:01:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:01:05 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-Jg9OomUH56@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67794|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70025&action=edit
Bug 19401: Add confirm message when deleting invoice

To test:
1) Go to Acquisitions
2) Go to Invoices (left nav menu)
3) Click Search (no need to filter results)
4) Click dropdown menu for an invoice, click Details
5) Click Delete
6) Notice invoice is deleted instantly
7) Apply patch and repeat steps 4 and 5
8) Confirm the confirm message shows and works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:03:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:03:18 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-gZXtw8NpZW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70026&action=edit
Bug 19315: [16.11.x] Use bibnum instead of biblionumber in routing-preview.pl
and add item check

To test:
 1 - Create a serial subscription attached to a record
 2 - Receive some issues
 3 - Edit the subscription
 4 - Go to serails collection
 5 - Try to print a routing list
 6 - You may or may not get the right serial
 7 - Additionally create a subscription attached to a bib with no items
 8 - Try to print a routing list for this serial
 9 - You will get 'Internal server error'
10 - Apply patch
11 - Print routing list for first serial
12 - You will always get the correct bib
13 - Print routing list for second serial
14 - You should no longer get an error

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:03:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:03:22 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-xSUPOumxx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70027&action=edit
Bug 19315: [16.11.x] [QA Follow-up] Trivial edits

Replace $subs->{bibnum} by $biblionumber on a following line.
The scalar in the boolean expression is not needed.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:03:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:03:26 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-U7mLsL1OrE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70028&action=edit
Bug 19315: [16.11.x] Prevent crash if no items and not library set for the
subscription

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:03:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:03:56 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-oKQY2cHn8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
And the last 3 patches are the 16.11.x version

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:04:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:04:59 +0000
Subject: [Koha-bugs] [Bug 19858] [16.11] Routing list preview/printing broken
In-Reply-To: <bug-19858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19858-70-4sMIb2sAUt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19858

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Must be fixed with the patches on bug 19315

*** This bug has been marked as a duplicate of bug 19315 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:04:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:04:59 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-DNKSvDVVuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 19858 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:10:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:10:53 +0000
Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive
In-Reply-To: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14546-70-nHa8Z4OAXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19851


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851
[Bug 19851] Improve responsive layout handling of staff client menu bar
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:10:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:10:53 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-5L4tQCK3qI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14546


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546
[Bug 14546] Make staff client templates responsive
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:13:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:13:08 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-QItoDN8uBb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:17:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:17:18 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-2HQWDxk64Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:17:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:17:21 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-fLuOZNj71y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69406|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70029&action=edit
Bug 19669: Remove deprecated checkouts by patron category report

Patch applies. Reports and general OPAC and staff client functionality is
intact.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:17:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:17:28 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-2y8H8CYivH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70030&action=edit
Bug 19669 [QA Followup] - Remove itemstypes.plugin

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:17:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:17:31 +0000
Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
In-Reply-To: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2696-70-E3HC8u3VFK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67479|0                           |1
        is obsolete|                            |

--- Comment #23 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70031&action=edit
[PATCH] Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

Rebased (2017-12-21): Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:17:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:17:33 +0000
Subject: [Koha-bugs] [Bug 19860] New: Make staff client home page responsive
Message-ID: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

            Bug ID: 19860
           Summary: Make staff client home page responsive
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 14546

The YUI grid on the staff client home page should be replaced with use of the
Bootstrap grid. This change will not affect the header search area, only the
body of the page.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546
[Bug 14546] Make staff client templates responsive
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:17:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:17:33 +0000
Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive
In-Reply-To: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14546-70-D9MXidaK0o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19860


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860
[Bug 19860] Make staff client home page responsive
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:17:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:17:48 +0000
Subject: [Koha-bugs] [Bug 19671] Circulation wizard / issues_stats.pl does
 not populate itemtype descriptions correctly
In-Reply-To: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19671-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19671-70-vAEjjmVJtf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19671

Chris Brown <chris at stayawake.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at stayawake.co.uk

--- Comment #6 from Chris Brown <chris at stayawake.co.uk> ---
I have applied the patch (on Koha 17.05) and can confirm that item types are
now displayed correctly in the report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:30:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:30:16 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-aJ1O5X5Vh2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:30:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:30:22 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-3EU8m2CatC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:30:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:30:31 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-RShFilazcv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:30:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:30:33 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-cu0dXZsyv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70032&action=edit
Bug 19860: Make staff client home page responsive

This patch rewrites the markup of the staff client home page to use the
Bootstrap grid instead of the YUI grid, taking advantage of Bootstrap's
built-in responsiveness.

This patch does not affect the logo and search form in the header. It
will be necessary to address search forms in another patch.

To test, apply the patch and clear your browser cache if necessary. For
better results, apply the patch for Bug 19851 as well.

- View the staff client home page and test the layout at various browser
  widths.
- Test with and without news items
- Test with and without content in IntranetmainUserblock

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:38:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:38:33 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-2Jfszeashd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #19 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hello,
yes I will upload the file.
We work in Unimarc but the file is in marc21. Actually, we want to use template
for changing key fields from marc21 fields in unimarc fields. It's only
temporary files for acquisitions.
I think you're on something.. the warnings are perhaps only because our
installation is in unimarc..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:40:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:40:20 +0000
Subject: [Koha-bugs] [Bug 19164] Allow MARC modification templates to be
 used in staged MARC imports
In-Reply-To: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19164-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19164-70-jWmzeu5jtp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #20 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 70033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70033&action=edit
marc_file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:42:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:42:10 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-fBX6PQsUve@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69762|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:42:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:42:22 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-u66mWvIyJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69764|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:42:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:42:30 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-OjdBoOXNfm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69765|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:42:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:42:16 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-VlQpagme8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69763|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:42:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:42:37 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-pHhlHfVoVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69766|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:42:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:42:43 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-YRveAFsz25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69767|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:42:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:42:50 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-5nGIlbMOJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69787|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:43:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:43:19 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-HgI4ulcF5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #81 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70034&action=edit
Bug 16330: Add routes to add, update and delete patrons

This patch adds support for add, edit and delete patrons via REST API.

GET  /api/v1/patrons                   Get patron list from params
GET  /api/v1/patrons/<borrowernumber>  Get single patron
POST /api/v1/patrons                   Create a new patron
PUT  /api/v1/patrons/<borrowernumber>  Update data about patron
DEL  /api/v1/patrons/<borrowernumber>  Delete a patron

Revised Test plan:
1) Apply this patch
2) Run tests perl t/db_dependent/api/v1/patrons.t
3) Add a user with proper rights to use the REST API
4) play with your favourite REST client (curl/httpie, etc.):
   Authenticate with the user created above and get a CGISESSION id.
   Use the CGISESSION to add, edit and delete patrons via the API.
5) Use PUT /patrons/<borrowernumber> for a patron without borrowers
   flag. This should go into pending patron modification status and
   needs to be accepted by a librarian.

Please note there is no validation of body input in PUT/POST other
than branchcode,category,userid,cardnumber.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:43:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:43:28 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-Wh06uSXdzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #82 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70035&action=edit
Bug 16330: Move patches to OpenAPI

This patch refactors the original work so it implements the controllers
and the spec using Mojolicious::Plugin::OpenAPI, and OpenAPI for the
specification.

It removes the ability for patrons without permissions to edit their own data
or their
guarantee's. This will be moved to a patron modification requests endpoint for
simplicity.

It makes use of bugs 19410 and 19686 and their dependencies to deal with
parameters handling,
query building and pagination.

Tests are adapted.

To test:
- Apply this patches and the dependencies
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:43:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:43:37 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-B7cON606FA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #83 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70036&action=edit
Bug 16330: (QA follow-up) Repect guidelines on plurals Patron > Patrons

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:43:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:43:47 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-po3hMQpnPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #84 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70037&action=edit
Bug 16330: (QA follow-up) ModMember requires borrowernumber

Works perfectly. Well done everyone!

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:43:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:43:54 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-IDqw1kvmvv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

--- Comment #85 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70038&action=edit
Bug 16330: Remove validation code from Koha::Patron

This patch removes previously added validation code from Koha::Patron
as we will rely on the DB structure and relationships to catch the same
problems. This is implemented on bug 19828.

This patch also adapts the API controller class to expect this behaviour
change from Koha::Patron. The expected exceptions are adjusted, and some
minor changes take place. The API tests are adjusted as well.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Patrons.t
 k$ prove t/db_dependent/api/v1/patrons.t
=> SUCCESS: Tests should still pass

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:46:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:46:34 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-AUZALDZoYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19841, 19828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828
[Bug 19828] Koha::Object->store should catch DBIC exceptions and raise
Koha::Exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841
[Bug 19841] AddMember should raise an exception if categorycode is invalid
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:46:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:46:34 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-ud6UpPeJVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:46:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:46:34 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-ouriaJL1w7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16330


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
[Bug 16330] REST API: add routes to add, update and delete patrons
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:48:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:48:27 +0000
Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For
In-Reply-To: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2696-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2696-70-QXMGTd9AIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #24 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Quick test gave me:

 - Error on accountline-details.pl:
     "GetMember" is not exported by the C4::Members module
     Can't continue after import errors at
/home/koha/src/members/accountline-details.pl line 26.
You could use Koha::Patron->find now.

  - On the same script after fixing the first error: 
    Template process failed: undef error - The method payment_type is not
covered by tests!

Also, i've rebased the patch: new account type ('PF', Processing fee),

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:48:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:48:59 +0000
Subject: [Koha-bugs] [Bug 19861] New: Add warn to About page if patron
 category in PatronSelfRegistrationDefaultCategory is invalid
Message-ID: <bug-19861-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19861

            Bug ID: 19861
           Summary: Add warn to About page if patron category in
                    PatronSelfRegistrationDefaultCategory is invalid
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Entering an invalid patron category into the
PatronSelfRegistrationDefaultCategory system preference currently results in an
'internal server error' or  
Can't call method "get_expiry_date" on an undefined value at
/usr/share/koha/lib/C4/Members.pm line 617 (16.11.13) in the plack logs.

It would be nice to warn about this misconfiguration on the About page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:49:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:49:47 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-bPBtCCd0Q8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:49:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:49:48 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-XVmdEJx3pf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:49:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:49:51 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-UHbOFFZFOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:49:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:49:49 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-Ld0IwKe66J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70008|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70039&action=edit
Bug 19857: Use BorrowerUnwantedField system preference for SMS provider
selection

Optionally hide SMS provider field in patron modification screen with
BorrowerUnwantedField system preference.

To test:
1. Apply patch
2. Append BorrowerUnwantedField with sms_provider_id and save changes
3. Go to patron modification screen in staff client
4. Observe the SMS provider selection is now hidden

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:49:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:49:59 +0000
Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from
	the interface
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-p4vrszT9ux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:53:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:53:02 +0000
Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from
	the interface
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-5KOSwJA8DA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:53:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:53:04 +0000
Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from
	the interface
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-zJdOhNlPi6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69983|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70040&action=edit
Bug 19756: Fix encoding issues during the update DB process

To display the output of the updatedatabase.pl under Plack, we redirect
the output to a temporary file, read it, then display it.
We need to open it specifying the correct encoding (utf-8).

Test plan:
1. MariaDB [koha_kohadev]> update systempreferences set value="17.1100000"
where variable="version";
2. restart plack
3. Login
4. Make the update from the interface
=> Without this patch you will see encoding issue:
Upgrade to 17.12.00.000 done (T? t?ia, t? haumatia)
=> With this patch applied you will see :
Upgrade to 17.12.00.000 done (T? t?ia, t? haumatia)

Signed-off-by: Liz Rea <liz at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:56:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:56:39 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-0c2u4fuHpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:56:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:56:42 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-dJAkcBwexO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69676|0                           |1
        is obsolete|                            |
  Attachment #69912|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70041&action=edit
Bug 19788 Local preference with uppercase

Fix a bug tranforming new local preference variable name in lowercase.

TO TEST:

1. Admin > System preferences > Local use
2. Button New preference. Fill variable field with 'TESTfoo'. Click
   Save.
3. The new variable is named: 'testfoo'.
4. Apply the patch.
5. Button New preference. Fill variable field with 'TESTfoo2'. Click
   Save.
6. The new variable is properly named: 'TESTfoo2'.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 15:56:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 14:56:49 +0000
Subject: [Koha-bugs] [Bug 19788] Local preference with uppercase
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-K1ElaDcxxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70042&action=edit
Bug 19788: Add a test

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:01:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:01:10 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-KEBcu7naqc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68296|0                           |1
        is obsolete|                            |

--- Comment #27 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70043&action=edit
Bug 11373: Add a "cash register" feature to the fine payment form.

Works as intended.

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:06:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:06:17 +0000
Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine
	payment form.
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-pfSaQBqYv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #28 from Charles Farmer <charles.farmer at inlibro.com> ---
Necessary rebase to apply on current master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:06:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:06:31 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-OEGgvQnXAQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70026|0                           |1
        is obsolete|                            |
  Attachment #70027|0                           |1
        is obsolete|                            |
  Attachment #70028|0                           |1
        is obsolete|                            |

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70044&action=edit
[SIGNED-OFF] Bug 19315: [16.11.x] Use bibnum instead of biblionumber in
routing-preview.pl and add item check

To test:
 1 - Create a serial subscription attached to a record
 2 - Receive some issues
 3 - Edit the subscription
 4 - Go to serails collection
 5 - Try to print a routing list
 6 - You may or may not get the right serial
 7 - Additionally create a subscription attached to a bib with no items
 8 - Try to print a routing list for this serial
 9 - You will get 'Internal server error'
10 - Apply patch
11 - Print routing list for first serial
12 - You will always get the correct bib
13 - Print routing list for second serial
14 - You should no longer get an error

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:06:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:06:51 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-YBx4hLjFxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70045&action=edit
[SIGNED-OFF] Bug 19315: [16.11.x] [QA Follow-up] Trivial edits

Replace $subs->{bibnum} by $biblionumber on a following line.
The scalar in the boolean expression is not needed.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:06:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:06:55 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-KsNEDtgs8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70046&action=edit
[SIGNED-OFF] Bug 19315: [16.11.x] Prevent crash if no items and not library set
for the subscription

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:07:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:07:14 +0000
Subject: [Koha-bugs] [Bug 7614] Branch transfer limit and holds
In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7614-70-XpjwoRtU4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614

--- Comment #17 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 70047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70047&action=edit
Bug 7614: (follow-up) If patron's home library is not a pickup library, let
them choose another one

This patch fixes an issue where patron is not allowed to place a hold in OPAC
while their home library is not a pickup library.

Instead, they should be presented with a list of other available pickup
locations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:07:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:07:36 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-QdNobvjiS0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:07:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:07:39 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-jDjGvLmS7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69963|0                           |1
        is obsolete|                            |
  Attachment #69964|0                           |1
        is obsolete|                            |
  Attachment #69965|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70048&action=edit
Bug 19828: Unit tests

This patch introduces unit tests for the changes this bug introduces to
Koha::Object->store.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests should fail because the changes are not implemented on this
patch

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:07:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:07:46 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-pP9Eppz96I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70049&action=edit
Bug 19828: Make Koha::Object->store translate DBIC exceptions into Koha
exceptions

This patch introduces a try/catch block in store() and parses the error
when an exceptional situation takes place.

It only deals with FK constraint violations and duplicate IDs. The rest of the
DBIC exceptions
are rethrown.

To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:07:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:07:49 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-ZRYdFKPWyN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70050&action=edit
Bug 19828: Fix tests that expect DBD errors instead of the exception message

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:12:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:12:14 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-mNQK56q0fY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67580|0                           |1
        is obsolete|                            |

--- Comment #15 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70051&action=edit
Bug 19368 - Ignore words when sorting serial search

This adds the 'SerialSortIgnoreWords' system preference.
It is empty by default, since words to ignore are very much language-specific.

The functionality is achieved by adding a hidden column to the table, and
sorting by this column by default. The downfall of this solution is that if the
user sorts by another column, they cannot go back to this sorting without
refreshing the page.

To test:
0) Apply patch
1) Run updatedatabase.pl
2) Add test subscriptions if you have none.
    Make sure to have subscriptions starting with "The An A" or similar
3) Go to system preferences and edit the SerialSortIgnoreWords pref
    Add the words "The An A" or the ones you used in your subscriptions
4) Go to Serials
5) Search serials (empty field will return all serials)
6) Result table should be sorted ignoring leading "The An A..."

Followed test plan, patch works as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:12:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:12:19 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-RVYqpNWwlV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67581|0                           |1
        is obsolete|                            |

--- Comment #16 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70052&action=edit
Bug 19368 - Correction on QA feedback

* I removed the IGNORE in the atomicupdate SQL. There is currently no other
systempreference by that name in Master so that should work fine
- Removed leftover test values from syspref.sql
- Removed extra $ in serial-search.tt
- Removed leftover warn in serial-search.pl

Passes QA test tool
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:12:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:12:24 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-oohwg8I6y0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69005|0                           |1
        is obsolete|                            |

--- Comment #17 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70053&action=edit
Bug 19368 - Syspref now "SortIgnoreArticles", used in datatables.inc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:19:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:19:08 +0000
Subject: [Koha-bugs] [Bug 19862] New: RoutingListAddReserves must be
	disabled by default
Message-ID: <bug-19862-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19862

            Bug ID: 19862
           Summary: RoutingListAddReserves must be disabled by default
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

It does not work, see bug 2894

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:19:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:19:08 +0000
Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken
In-Reply-To: <bug-2894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2894-70-MVxcL3swiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19862

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:19:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:19:34 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-7OHupiopAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:19:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:19:36 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-ZhM2BmqAG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69923|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70054&action=edit
Bug 19840: Fix - display patron note on checkin

If a patron let a note on the checkout (AllowCheckoutNotes), it is
supposed to be displayed when checked in.

Test plan:
1/ Enable AllowCheckoutNotes
2/ Check an item out
3/ At the opac let a note on the checkout
4/ Check the item in
   => With this patch applied you should see the notes displayed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:19:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:19:39 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-qm6tsfVBGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69924|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70055&action=edit
Bug 19840: And avoid XSS...

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:24:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:24:27 +0000
Subject: [Koha-bugs] [Bug 19863] New: Add more save options when edditing
	authorities
Message-ID: <bug-19863-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19863

            Bug ID: 19863
           Summary: Add more save options when edditing authorities
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: patrick.robitaille at collecto.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Hi, 

It would be great to have more options for save when you edit an authority. At
the moment we only have the option to save. when we edit a record, we have
three different option like the option to "save and continue editing". It would
be nice to have this option when we edit an authority. 

Patrick.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:25:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:25:29 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-nmz8jPKica@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Owen, what would be the best pattern to follow here?
I think id="delete" is not specific enough, it should be id="delete_invoice"
id or class? See bug 19429.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:37:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:37:07 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-NvQWMctsZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:37:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:37:10 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-014zVvNCir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69299|0                           |1
        is obsolete|                            |

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 70056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70056&action=edit
Bug 19466: Check if cardnumber is mandatory

Changes the appearance of the cardnumber entry field in memberentrygen.tt
The "Leave empty for autocalc" message has been moved to the hint div
under the input field. If AutoMemberNum and BorrowerMandatoryField
interfere with each other, the auto calc hint is replace by a warning
telling the user that auto calc has been disabled.

Cardnumber should now correctly appear as mandatory if marked as such
in BorrowerMandatoryField.

Test plan:
0] Apply patch
1} Disable AutoMemberNum, remove cardnumber from BorrowerMandatoryField
2) Edit or create a patron, scroll down to cardnumber input field
    Hint is some form of "Cardnumber must be this long"
    Cardnumber input is not marked as required
    There is no mention of auto calc

3> Enable AutoMemberNum
    Hint includes "Leave empty for auto calc" message

4~ Add cardnumber to BorrowerMandatoryField
    Hint warns you that your sysprefs are conflicting.
    Cardnumber input is marked as required

5: Disable AutoMemberNum
    Hint is some form of "Cardnumber must be this long"
    Cardnumber input is marked as required

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:38:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:38:10 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-SIsY7ebc7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
I think "delete_invoice" is better, but it's more a matter of style than
functionality. ids should always be unique, so if we're validating the markup
as we go we'll be warned about duplicates.

On this page an id is the right choice over a class because it will always be a
unique element. In Bug 19429 it must be a class because the element repeats for
each invoice in the table which can be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:40:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:40:12 +0000
Subject: [Koha-bugs] [Bug 19466] Cardnumber auto calc is broken because
	field is required
In-Reply-To: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19466-70-XQ5QOu3h8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19466

--- Comment #7 from David Bourgault <david.bourgault at inlibro.com> ---
(In reply to Kyle M Hall from comment #5)
> I don't think this is a complete enough solution. We have two choices:
> A) Hide auto-calc if cardnumber is mandatory
> B) Strip cardnumber from mandatory fields if auto calc is enabled

I don't think we should be changing SysPrefs without explicitly telling the
user, that would simply lead to more confusion.

I changed my patch to make the behavior more explicit to the user by warning
him if syspref are interfering with each other, and correctly marking the input
field as required. I think this is the most simple option for this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:42:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:42:31 +0000
Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice
 from invoice search
In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19429-70-MnwfdKCRb6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70057&action=edit
Bug 19429: Rename .delete to .delete_invoice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:43:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:43:16 +0000
Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items"
 option and add " Removes non-local records" option for existing
 functionality
In-Reply-To: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18201-70-l96nhnNv2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70058&action=edit
Bug 18201: Tidy tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:53:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:53:36 +0000
Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method
In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19830-70-An269vvitL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:53:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:53:38 +0000
Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method
In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19830-70-c8JJI4A4yZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69859|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70059&action=edit
Bug 19830: Add the Koha::Patron->old_checkouts method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
must return green

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:54:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:54:37 +0000
Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method
In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19830-70-uE42I1Ao2F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Passed QA

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Going directly to PQA. Reset back to signed-off if you feel this needs another
set of eyes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:58:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:58:25 +0000
Subject: [Koha-bugs] [Bug 19864] New: UNIMARC field 100 plugin broken
Message-ID: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864

            Bug ID: 19864
           Summary: UNIMARC field 100 plugin broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Undefined subroutine &Date::Calc::Today called at
cataloguing/value_builder/unimarc_field_100.pl line 75.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 16:58:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 15:58:28 +0000
Subject: [Koha-bugs] [Bug 11976] show issue date instead of received date
 for serials in opac
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-ovrLOtMmLN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70060&action=edit
Bug 11976: Fix sorting issues

The last column must be sortable, and dates must use title-string
I removed the class on the th (did not seem useful as we have an id
already)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:02:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:02:07 +0000
Subject: [Koha-bugs] [Bug 11976] Add column settings + new column
 "Publication date" to the subscription table
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-m8igkIWlZR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Templates                   |OPAC
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Summary|show issue date instead of  |Add column settings + new
                   |received date for serials   |column "Publication date"
                   |in opac                     |to the subscription table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:02:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:02:28 +0000
Subject: [Koha-bugs] [Bug 11976] Add column settings + new column
 "Publication date" to the subscription table
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-t17cN7WBie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:04:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:04:56 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-jxMJH9HyXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:04:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:04:59 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-N7OrK11zen@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69456|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70061&action=edit
Bug 19729: Adds link elements in HTML to lists pages breadcrumbs in OPAC

To match every other page in the OPAC and ease CSS styling, there should be
links to current page on last breadcrumbs in lists pages.

Test plan:
1-Go to /cgi-bin/koha/opac-shelves.pl
2-Notice that there are no links on the last breadcrumb in every page (my
lists, public lists, create list, individual list page)
3-Apply patch
4-Reload page, and notice there are now links, pointing to current page (#)

Signed-off-by: Dominic Pichette <dominic at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:06:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:06:44 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-8alXsodLVz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
"Sitemapper.t fails if date changes during test run" is the description of the
bug, not what the patch does.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:07:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:07:38 +0000
Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken
In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19864-70-BnZudv0rb1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:07:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:07:41 +0000
Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken
In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19864-70-0LxJr108ev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70062&action=edit
Bug 19864: UNIMARC field 100 plugin broken

Triggering the UNIMARC plugin for MARC tag 100 results in an error. This
patch corrects the error by including the missing subroutine.

To test, apply the patch and configure a MARC framework to use the
plugin 'unimarc_field_100.pl' for a field. It is not necessary to test
on a UNIMARC system.

- Open a record for editing.
- Click the link to trigger the plugin for the field you configured.
- The plugin popup window should load correctly.
- Make changes in the form and submit. The configured field should be
  filled with the correct data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:08:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:08:52 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-DewbLHHc5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:08:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:08:55 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-ekXqB4B6FT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69918|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70063&action=edit
Bug 19826: Add K::Acq::Budget(s) and K::Acq::Budget::Fund(s)

This patch introduces Koha::Object(s)-derived classes for budgets and funds
(aqbudgetperiods and aqbudgets respectively).

C4::Budgets already uses DBIC calls on those tables so transition should be
easy on top of this.

To test:
- Check the referenced schema files are the right ones.
- QA scripts shoudl be happy.
- Sign off :-D

Note: the POD coverage report throws a false negative result on singular
classes which is trivially wrong.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:08:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:08:58 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-zo5x0cXUIH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #9)
> Created attachment 70030 [details] [review]
> Bug 19669 [QA Followup] - Remove itemstypes.plugin
> 
> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Kyle, Are you sure about that?
If yes we should remove it on a specific bug report, as well as the
reports/manager.pl stuffs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:09:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:09:02 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-nQiY8Lq0jC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69919|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:09:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:09:04 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-KuxkmSTA1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70064&action=edit
Bug 19826: Unit test files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:13:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:13:12 +0000
Subject: [Koha-bugs] [Bug 19803] SQL report export can fail HTTP 414
 Request-URI Too Large
In-Reply-To: <bug-19803-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19803-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19803-70-15Z6j90HR4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19803

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor.grousset at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:15:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:15:25 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-zuoYkA42hZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Julian Maurice from comment #18)
> (In reply to Jonathan Druart from comment #15)
> > Hum, so Koha::Acquisition::Vendor::Basket::Order? :)
> 
> Please, no :)
> Not everything can be represented in a tree.
> Where do you place basket groups in this hierarchy ? It could be
> Koha::Acq::Vendor::Basketgroup::Basket, but not every basket belongs to a
> basketgroup.
> Also, there is a 1-n relationship between biblio and aqorders, but
> Koha::Biblio::Orders does not make much sense IMHO.
> 
> If there was a vote, I'd vote for everything on one level

Not everything, but I would prefer Koha::Acq::Budget[s] and Koha::Acq::fund[s]
too.
Setting to In Discussion to get more opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:18:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:18:43 +0000
Subject: [Koha-bugs] [Bug 19865] New: Side scroll bar in z39.50 MARC view
Message-ID: <bug-19865-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865

            Bug ID: 19865
           Summary: Side scroll bar in z39.50 MARC view
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Z39.50 / SRU / OpenSearch Servers
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jesse at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Created attachment 70065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70065&action=edit
ScreenShot

Prior to the 17.05 upgrade when you did a z39.50 search and then viewed the
MARC record prior to import, a side scroll bar would appear at the bottom of
the window, however, in 17.05 you have to scroll to the bottom of the window
before the side scroll bar appears.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:18:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:18:47 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-MKPSKBFE3w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:18:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:18:50 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-SppUuX6jAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68163|0                           |1
        is obsolete|                            |
  Attachment #68164|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70066&action=edit
Bug 17951: Make koha-create set template_cache_dir correctly

This patch makes koha-create (and friends) handle the template_cache_dir
config entry correctly.

It does so by:
- Adding a replaceable string to the template for koha-conf.xml
- Making koha-create-dirs create the needed directories (i.e.
 /var/cache/koha/instance and /var/cache/koha/instance/templates)
- Adding a --template-cache-dir switch to koha-create (so sysadmins can
  specify their favourite directory for the templates cache).
- koha-remove now takes care of the instance's *templates* dir.
- The install scripts now automatically create /var/cache/koha so it can
  be used later by koha-create and friends. It does so the same way it does
  for other install-created directories.

To test, you should ideally be able to build your own packages. This
instructions can be followed by people that doesn't have that ability
yet. But can be used on a custom packages setup too.

To test:
- Make sure you have the latest misc4dev in your kohadevbox (if it is a
  fresh box you have it already)
- Run:
  $ sudo perl misc4dev/cp_debian_files.pl
- Manually create the /var/cache/koha dir (skip if you have your own
        packages):
  $ sudo mkdir /var/cache/koha
- Create a new instance:
  $ sudo koha-create --create-db cachetest
=> SUCCESS:
    * /etc/koha/sites/cachetest/koha-conf.xml contains
    template_cache_dir and is populated with
/var/cache/koha/cachetest/templates
    * The directory /var/cache/koha/cachetest/templates exists!
- Create a new instance, pass your own cache dir:
  $ sudo koha-create --create-db --template-cache-dir /tmp cachetest2
=> SUCCESS: etc/koha/sites/cachetest2/koha-conf.xml contains template_cache_dir
   and is populated with /tmp
- Run:
  $ man koha-create
=> SUCCESS: The docs mention the --template-cache-dir option switch
    correctly.
- Sign off :-D!

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:18:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:18:57 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-htUbPSiXwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70067&action=edit
Bug 17951: (followup) Make Makefile.PL handle template_cache_dir config

This patch adds Makefile.PL the capability of handling the template_cache_dir
configuration entry.
To do so, it:
- Adds the --template-cache-dir option switch (consistency with koha-create)
- Sets a default value for template_cache_dir to '/tmp/koha'
- Adds a dialog requesting the path for the template cache dir to Makefile.PL
- It tweaks etc/koha-conf.xml so it is correctly changed by rewrite-config.PL

To test:
- Apply this patch
- Run:
  $ perl Makefile.PL --template-cache-dir your/favourite/dir
=> SUCCESS: The dialogs don't ask for template cache dir
=> SUCCESS: The resulting Makefile contains an entry for TEMPLATE_CACHE_DIR
which value
            matches what we passed to --template-cache-dir
- Run:
  $ perl Makefile.PL
- When prompted for a template cache dir, introduce whatever you want
=> SUCCESS: The default you are offered is /tmp/koha
=> SUCCESS: At the end of the process, Makefile contains what we put in there
- Run:
  $ sudo make install
=> SUCCESS: The resulting koha-conf.xml contains a <template_cache_dir> entry
containing
            whatever you picked for that purpose.
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:22:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:22:26 +0000
Subject: [Koha-bugs] [Bug 11976] Add column settings + new column
 "Publication date" to the subscription table
In-Reply-To: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11976-70-mqfqprqYSC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:22:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:22:38 +0000
Subject: [Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when
 date changes during test run
In-Reply-To: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17770-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17770-70-4tzXNazg6i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:23:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:23:07 +0000
Subject: [Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items"
 option and add " Removes non-local records" option for existing
 functionality
In-Reply-To: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18201-70-h39fgFy77N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:23:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:23:27 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-nAkZUDgMQ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:23:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:23:37 +0000
Subject: [Koha-bugs] [Bug 19429] No confirm message when deleting an invoice
 from invoice search
In-Reply-To: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19429-70-moV2jYJFQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:23:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:23:44 +0000
Subject: [Koha-bugs] [Bug 19450] OverDrive integration failing on missing
	method
In-Reply-To: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19450-70-VimECqIuSd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19450

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:23:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:23:59 +0000
Subject: [Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC
 only appears / works if no other list already exists
In-Reply-To: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19573-70-85Ljt1gt0V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:24:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:24:05 +0000
Subject: [Koha-bugs] [Bug 19599] anonymise_issue_history can be very slow on
 large systems
In-Reply-To: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19599-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19599-70-IzXA9K3J7z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19599

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:24:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:24:30 +0000
Subject: [Koha-bugs] [Bug 19694] Edited shipping cost in invoice doesn't save
In-Reply-To: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19694-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19694-70-szUk8KYZYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19694

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:24:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:24:15 +0000
Subject: [Koha-bugs] [Bug 19669] Remove deprecated checkouts by patron
	category report
In-Reply-To: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19669-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19669-70-v9XAFMFI27@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19669

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:24:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:24:46 +0000
Subject: [Koha-bugs] [Bug 19725] OAI-PMH ListRecords and ListIdentifiers
 should use biblio_metadata.timestamp
In-Reply-To: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19725-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19725-70-isgvpFxlAp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19725

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:24:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:24:54 +0000
Subject: [Koha-bugs] [Bug 19756] Encoding issues when update DB is run from
	the interface
In-Reply-To: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19756-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19756-70-l3PDg4GcbM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19756

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:25:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:25:00 +0000
Subject: [Koha-bugs] [Bug 19830] Add the Koha::Patron->old_checkout method
In-Reply-To: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19830-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19830-70-ux3a6JquIu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:25:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:25:08 +0000
Subject: [Koha-bugs] [Bug 19845] Patron password is ignored during
 self-registration if PatronSelfRegistrationVerifyByEmail is enabled
In-Reply-To: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19845-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19845-70-xd9THlrhrD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19845

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:51:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:51:41 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-Ej02SZFAFc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:51:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:51:45 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-4n5twSsKTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69794|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70068&action=edit
Bug 19744: Move template JavaScript to the footer: Offline circulation

This patch modifies the staff client offline circulation templates so
that JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Circulation -> Built-in offline circulation interface
  -> Synchronize
   -> Download records
  -> Check out
  -> Check in
    -> Synchronize
      -> Upload transactions
  -> Pending offline circulations
    -> Check all, uncheck all
    -> Delete
    -> Process

Circulation -> Upload offline circulation data
  -> Upload .koc file (gerated by the Koha Offline Circulation program,
     for instance).

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 17:52:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 16:52:07 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-tNnfvPanx1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:05:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:05:58 +0000
Subject: [Koha-bugs] [Bug 16497] Add routes to list libraries
In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16497-70-y15Q9ypfEt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #31 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Please:
- Implement using objects.search instead of manually crafting the DBIC query
- Please review the RFC I've just posted. If you add to it, add new column for
your proposals. I plan to have it voted in Dec 27th's dev meeting so we can
move on.

https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:14:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:14:37 +0000
Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken
In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19864-70-JFtT3fpzGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19866


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866
[Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:14:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:14:37 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-pFwrI9Na25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19866


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866
[Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:14:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:14:47 +0000
Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 1
In-Reply-To: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19866-70-4CSOaufOqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move template JavaScript to |Move template JavaScript to
                   |the footer: UNIMARC editor  |the footer: UNIMARC editor
                   |plugins                     |plugins, part 1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:14:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:14:37 +0000
Subject: [Koha-bugs] [Bug 19866] New: Move template JavaScript to the
 footer: UNIMARC editor plugins
Message-ID: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866

            Bug ID: 19866
           Summary: Move template JavaScript to the footer: UNIMARC editor
                    plugins
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19864
            Blocks: 17858

Most UNIMARC plugin templates already have JavaScript at the bottom of the
template instead of the top, but they should still be modified to be consistent
with other templates which have been updated as part of Bug 17858.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864
[Bug 19864] UNIMARC field 100 plugin broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:24:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:24:40 +0000
Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 1
In-Reply-To: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19866-70-bwNSXZjj8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:24:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:24:43 +0000
Subject: [Koha-bugs] [Bug 19866] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 1
In-Reply-To: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19866-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19866-70-Zb4y0bNxqp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70069&action=edit
Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part
1

This patch updates several UNIMARC plugin templates so that JavaScript
is included in the footer following the same pattern as other templates
which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_100.tt
- unimarc_field_100_authorities.tt
- unimarc_field_105.tt
- unimarc_field_106.tt
- unimarc_field_110.tt
- unimarc_field_115a.tt
- unimarc_field_115b.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:28:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:28:18 +0000
Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug
	12509
In-Reply-To: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19849-70-0K9pnBlVLk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849

--- Comment #1 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 70070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70070&action=edit
Bug 19849: Minor fixes & refactor of opac-reserve.tt & opac-user.tt

- make next patch easely reviewable.
- fix lone quote. (Replace by <strong>
- add forgotten condition for 9999-12-31

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:28:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:28:21 +0000
Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug
	12509
In-Reply-To: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19849-70-i5FLSXLwiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849

--- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 70071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70071&action=edit
Bug 19849: Make a string translatable again after a rebase error

Bug 16621 reverted part of bug 12509
1. Log in the OPAC and staff interface
2. Restrict the user logged in the OPAC (restricting yourself works)
   Staff interface ? Patron page ? Restrictions ? Add manual restriction
   Put this comment the "OVERDUES_PROCESS Give the books back or we're
comming!"
3. Install the fr_FR locale and switch the interface to it
4. Go to OPAC: /cgi-bin/koha/opac-user.pl
5. Then you should see the ugly comment with "OVERDUES_PROCESS"
6. Apply this patch
7. Update the translation: ./translate update or equivalent
8. Open misc/translator/po/fr-FR-opac-bootstrap.po
9. Find the string containing "Restriction added by overdues process"
10. Remove the fuzzy flag
11. Install the language
12. Refresh the page in the OPAC
13. Then you should see the translation + the comment instead of
"OVERDUES_PROCESS" + the comment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:28:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:28:55 +0000
Subject: [Koha-bugs] [Bug 19849] Rebase of bug 16621 partially reverted bug
	12509
In-Reply-To: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19849-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19849-70-WdaGAnBVSF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19849

Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:35:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:35:13 +0000
Subject: [Koha-bugs] [Bug 19867] New: HouseboundRoles.t is failing randomly
Message-ID: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

            Bug ID: 19867
           Summary: HouseboundRoles.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

https://jenkins.koha-community.org/job/Koha_Master_D8/321/console

#   Failed test 'Correct count of choosers.'
#   at t/db_dependent/Patron/HouseboundRoles.t line 79.
#          got: '2'
#     expected: '1'
# Looks like you failed 1 test of 6.
[16:35:39] t/db_dependent/Patron/HouseboundRoles.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:44:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:44:24 +0000
Subject: [Koha-bugs] [Bug 19868] New: Move template JavaScript to the
 footer: UNIMARC editor plugins, part 2
Message-ID: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868

            Bug ID: 19868
           Summary: Move template JavaScript to the footer: UNIMARC editor
                    plugins, part 2
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 19864
            Blocks: 17858

Most UNIMARC plugin templates already have JavaScript at the bottom of the
template instead of the top, but they should still be modified to be consistent
with other templates which have been updated as part of Bug 17858.

This patch modifies several more UNIMARC editor plugins.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864
[Bug 19864] UNIMARC field 100 plugin broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:44:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:44:24 +0000
Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken
In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19864-70-JJvCvfpb3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868
[Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins,
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:44:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:44:24 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-lLNdA187lV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868
[Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins,
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:47:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:47:33 +0000
Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly
In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19867-70-fV4DTprCpH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70072&action=edit
Bug 19867: Prevent HouseboundRoles.t to fail randomly

Here is just a guess but we need to tell TestBuilder the values of
housebound_deliverer and housebound_chooser to make sure it will not be
1

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:47:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:47:25 +0000
Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly
In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19867-70-E3Uzwqczn8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:47:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:47:56 +0000
Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly
In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19867-70-G5MKRijW9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:59:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:59:47 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-SDJLaTtGAV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69664|0                           |1
        is obsolete|                            |
  Attachment #69665|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70073&action=edit
Bug 15492: Add the SelfCheckInModule syspref

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:59:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:59:54 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-r7zIlr4t0v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70074&action=edit
Bug 15492: Add SCI module

This patch adds the SCI module, and adapts C4::Auth to know about it.

The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
  to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link

To test:
- Apply this patches
- Make sure you upgrade:
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Click the 'Help' link
=> SUCCESS: A help text is displayed on a modal
- Sign off :-D

- Bonus points:
  $ kshell
 k$ qa -c 2 -v 2
=> SUCCESS: All tests green

[1] Adjust to your dev's OPAC setup

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:59:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:59:57 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-QFCWhtJU4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 70075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70075&action=edit
Bug 15492 [QA Followup] - Reset SCI if idle for 30 seconds

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 18:59:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 17:59:44 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-KJkySFuEE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:02:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:02:07 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-EKvHb2Wnuq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |oleonard at myacpl.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
on href="#" we need to call preventDefault() or the scrollback will hit the top
of the page.
Apparently other pages have the same problem.

Owen, do we need to take care of that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:08:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:08:28 +0000
Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly
In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19867-70-oSawAKio97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:08:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:08:32 +0000
Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly
In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19867-70-nBfYOfpsDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70072|0                           |1
        is obsolete|                            |

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70076&action=edit
Bug 19867: Prevent HouseboundRoles.t to fail randomly

Here is just a guess but we need to tell TestBuilder the values of
housebound_deliverer and housebound_chooser to make sure it will not be
1

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
I manually tested setting to the opposite values in the tests, and
verified those values made the tests fail due to count problems.
The fix is valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:14:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:14:55 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-4oCBA143e3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70077&action=edit
Bug 15752: Remove unecessary redirect

We are on circulation.pl, no need to redirect.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:15:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:15:47 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-O7v5S88G3M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We should not need to redirect, we are on circulation.pl. Could someone take a
look and retest quickly?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:32:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:32:26 +0000
Subject: [Koha-bugs] [Bug 19729] Lists pages in OPAC are missing an HTML
 link element in last breadcrumb
In-Reply-To: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19729-70-6JVDRBSJhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19729

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
To be perfectly honest I'm not sure why the last breadcrumb was ever a link.
How is it useful to make it a dummy link? That seems very confusing. I don't
know why 2013 me did that.

I would prefer to remove all the links, and perhaps wrap the inactive last
breadcrumb in a <span> with a consistent class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:39:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:39:18 +0000
Subject: [Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken
In-Reply-To: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19864-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19864-70-Mqcc8gLDnf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19868                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868
[Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins,
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:39:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:39:18 +0000
Subject: [Koha-bugs] [Bug 19868] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 2
In-Reply-To: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19868-70-JTCStY04P0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|19864                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864
[Bug 19864] UNIMARC field 100 plugin broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:39:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:39:45 +0000
Subject: [Koha-bugs] [Bug 19868] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 2
In-Reply-To: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19868-70-UF8XOGvdbw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:39:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:39:48 +0000
Subject: [Koha-bugs] [Bug 19868] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 2
In-Reply-To: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19868-70-cs3G4bMB2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70078&action=edit
Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part
2

This patch updates several more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_116.tt
- unimarc_field_117.tt
- unimarc_field_120.tt
- unimarc_field_121a.tt
- unimarc_field_121b.tt
- unimarc_field_122.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:41:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:41:16 +0000
Subject: [Koha-bugs] [Bug 19869] New: Move template JavaScript to the
 footer: UNIMARC editor plugins, part 3
Message-ID: <bug-19869-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869

            Bug ID: 19869
           Summary: Move template JavaScript to the footer: UNIMARC editor
                    plugins, part 3
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

Most UNIMARC plugin templates already have JavaScript at the bottom of the
template instead of the top, but they should still be modified to be consistent
with other templates which have been updated as part of Bug 17858.

This patch modifies even more UNIMARC editor plugins.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:41:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:41:16 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-iEiabNiOss@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19869


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869
[Bug 19869] Move template JavaScript to the footer: UNIMARC editor plugins,
part 3
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 19:41:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 18:41:27 +0000
Subject: [Koha-bugs] [Bug 19867] HouseboundRoles.t is failing randomly
In-Reply-To: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19867-70-0jo0fc5FjX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19867

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks Tomas for the quick review!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:00:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:00:02 +0000
Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks
 when patron is searched for
In-Reply-To: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18474-70-WbG2YmrUKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:02:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:02:17 +0000
Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks
 when patron is searched for
In-Reply-To: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18474-70-ejle4iMlA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:02:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:02:21 +0000
Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks
 when patron is searched for
In-Reply-To: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18474-70-ph1nt2nQED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70079&action=edit
Bug 18474: Restore multiple holds when patron is searched for

We lost the ability to place multiple holds when we are searching for
patrons. The multi_holds parameter is lost and not handled correctly in
the template.

Test plan:
- Make sure you can place multiple holds for a patron you will search for
- Same for simple hold

TODO the multiple holds view should not be displayed if only 1 record
has been selected from the search result.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:03:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:03:16 +0000
Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks
 when patron is searched for
In-Reply-To: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18474-70-G7xLNmqLdj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I'd say that it is broken in all our supported branches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:15:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:15:14 +0000
Subject: [Koha-bugs] [Bug 19869] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 3
In-Reply-To: <bug-19869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19869-70-xMy0xrFHH2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70080&action=edit
Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part
3

This patch updates even more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_123a.tt
- unimarc_field_123d.tt
- unimarc_field_123e.tt
- unimarc_field_123f.tt
  - This template has been modified, but doesn't appear to be used. The
    unimarc_field_1234.pl script uses unimarc_field_123g.tt as its
    template.
- unimarc_field_123g.tt
- unimarc_field_123i_j.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:15:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:15:11 +0000
Subject: [Koha-bugs] [Bug 19869] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 3
In-Reply-To: <bug-19869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19869-70-GfeSo9vNFE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:18:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:18:21 +0000
Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents
In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18975-70-8RMGHBBXxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Severity|normal                      |major
            Version|16.11                       |master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It affects master as well

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:53:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:53:33 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-um77njxv0A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:53:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:53:40 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-fsaad9vGR0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69795|0                           |1
        is obsolete|                            |

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70081&action=edit
Bug 19753: Move template JavaScript to the footer: Acquisitions

This patch modifies some staff client acquisitions templates so that
JavaScript is included in the footer instead of the header.

This patch adds a JavaScript file, acquisitions-menu.js, which controls
the highlighting of the current page in the sidebar. Highlighting will
be temporarily broken for pages which have not been modified to include
this file

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Acquisitions home page
  - Datatable, Inactive budget controls
- Vendor search results
  - Acquisitions -> Vendor search
    - Datatables, "Show all" links
- Basket
  - Acquisitions -> Vendor -> Basket
    - Datatables, button controls, add managing user
- Add to basket from a staged file
  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - Datatables, tabs, selection controls
- Edit basket
  - Acquisitions -> Vendor -> Edit basket
    - Form validation
- EDIFACT messages
  - Acquisitions -> EDIFACT messages
    - Datatables, message preview
- Orders search
  - Acquisitions -> Order search
    - Full orders search form
      - Patron autocomplete in "Basket created by" field
      - Datepickers
    - Orders search results
      - Datatables, column visibility
- Invoices
  - Acquisitions -> Vendor -> Invoices -> Invoice
    - Form validation, datepickers, datatables
  - Invoice files (enable AcqEnableFiles preference)
    - Manage invoice files
      - File list datatable

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:53:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:53:45 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-xQ9rMp7u5h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70082&action=edit
Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice
page

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 20:54:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 19:54:19 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-1qW5x6xpmw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 21:07:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 20:07:31 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-Vsj54N4sa1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 21:07:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 20:07:35 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-R3jpSd8bQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70083&action=edit
Bug 19702: Correct cookie path in Basket.js

This corrects the cookie path in bootstrap/js/basket.js. It used to take
the default value (current page path), but will now be "/"

Test plan:
0) Visit the OPAC, add a book to your basket
1) Navigate to the OPAC's homepage (www.domain.com, without the
    /cgi-bin/koha)
    -> The basket will display as empty
    2) Apply patch
    3) Clear your cookies and your cache
    4) Redo step 1)
        -> Basket will display correctly

Patch applies without issue and functions as descibed.
Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 21:08:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 20:08:11 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-QvCWqe1llD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
  Attachment #69407|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 21:08:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 20:08:52 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-XBcoeZlpTN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 21:17:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 20:17:40 +0000
Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents
In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18975-70-Xj4FFArhsv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70084&action=edit
Bug 18975: Retrieve up-to-date CGISESSID when just logged in

If a user is asked to login before sending a card, the wrong (old)
CGISESSID cookie is used.
We need to retrieve the one that has just been created.

This will certainly need more work, I guess other scripts are affected
too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 21:18:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 20:18:02 +0000
Subject: [Koha-bugs] [Bug 18975] Wrong CSRF token when emailing cart contents
In-Reply-To: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18975-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18975-70-EMhZaWh03G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18975

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 21:53:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 20:53:57 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-l3MncgYfqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #18 from Charles Farmer <charles.farmer at inlibro.com> ---
Necessary rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:00:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:00:14 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-7DvAlAdSnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #32 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70085&action=edit
Bug 15752: Remove unecessary redirect (follow-up)

If the borrowernumber is defined in query, it starts to get information
about previous borrower and the new one is taken into account fully on
second page reload

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:02:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:02:19 +0000
Subject: [Koha-bugs] [Bug 15752] Automatically switch from circulation to
 new patron when a cardnumber is scanned
In-Reply-To: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15752-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15752-70-xo6mqUGR45@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15752

--- Comment #33 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #31)
> We should not need to redirect, we are on circulation.pl. Could someone take
> a look and retest quickly?

True, but probably not so easy... I tested your patch and added followup - now
it is working for me... but I am not sure if it is enough in all situations...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:03:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:03:20 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-PsmWKU7C1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67155|0                           |1
        is obsolete|                            |

--- Comment #126 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70086&action=edit
Bug 8000 - Redirect all emails to SendAllEmailsTo

Koha/Email.pm

Test plan:

1) Apply path
2) Clear all SendAllEmailsTo system preference
3) Send mail to a patron of your choosing, email will go to patron's
   email address as usual.
4) Set SendAllEmailsTo to a test email address
5) Send mail to the patron, email will be redirected to the email set
   in the systempreference.

It does not affect messages in the message_queue.

This patch obsoletes previous patches, because it achieves the same
functionality in a much more centralized way. (4 lines of code!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:04:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:04:26 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-eFHaJSaDDG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #127 from Charles Farmer <charles.farmer at inlibro.com> ---
With the latest patch reworked by David, I feel like this bug can be placed
once again in "Needs Signoff".

Rebased on the current master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:07:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:07:39 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-3VW7ArT282@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70086|0                           |1
        is obsolete|                            |

--- Comment #128 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70087&action=edit
Bug 8000 - Redirect all emails to SendAllEmailsTo

Koha/Email.pm

Test plan:

1) Apply path
2) Run updatedatabase.pl
3) Clear all SendAllEmailsTo system preference
4) Send mail to a patron of your choosing, email will go to patron's
   email address as usual.
5) Set SendAllEmailsTo to a test email address
6) Send mail to the patron, email will be redirected to the email set
   in the systempreference.
7) Run prove -v t/db_dependent/Letters.t

It does not affect messages in the message_queue.

This patch obsoletes previous patches, because it achieves the same
functionality in a much more centralized way. (4 lines of code!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:33:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:33:27 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-Wh4tJC4Rad@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:35:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:35:45 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-MGZNhF7h5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:35:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:35:49 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-kzdoZC7sFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70054|0                           |1
        is obsolete|                            |
  Attachment #70055|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70088&action=edit
Bug 19840: Fix - display patron note on checkin

If a patron let a note on the checkout (AllowCheckoutNotes), it is
supposed to be displayed when checked in.

Test plan:
1/ Enable AllowCheckoutNotes
2/ Check an item out
3/ At the opac let a note on the checkout
4/ Check the item in
   => With this patch applied you should see the notes displayed

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:35:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:35:54 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-Aieocv4Gzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70089&action=edit
Bug 19840: And avoid XSS...

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 21 22:36:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 21:36:38 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-vV0ofWjaR4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 00:09:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 23:09:52 +0000
Subject: [Koha-bugs] [Bug 16764] Update printers administration page
In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16764-70-ITBHBnU9Sq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 00:09:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 23:09:55 +0000
Subject: [Koha-bugs] [Bug 16764] Update printers administration page
In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16764-70-8QQ2ZeOMKd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69141|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70090&action=edit
Bug 16764 - Update printers administration page

This patch updates the template for printers administration according to
current interface guidelines.

- Custom JavaScript form validation is removed in favor of the built-in
  form validation plugin.
- Printer-specific header search form is removed, along with server-side
  pagination code. The functionality of both is now taken care of the
  adding DataTables sorting and pagination to the table.
- Edit and delete links are styled as Boostrap buttons with Font Awesome
  icons.
- Confirmation dialogs are updated to use Font Awesome icons.

To test properly you will need to add multiple printers.

- Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no
  menu link for the page).
- When no printers exist you should see a message dialog saying so.
- Add a new printer. Confirm that printer name and queue are required
  fields.
- After adding multiple printers, confirm that the table of printers is
  correctly sorted and searched by the DataTables plugin.
- Delete a printer and verify that the confirmation dialog is correctly
  styled.

Signed-off-by: Marc V?ron <veron at veron.ch>

Update: rebased and updated Bootstrap 3 classes

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=16765

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 00:13:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 23:13:50 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-BfkWal2Ggv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
With this patch applied, the Z39.50 search window remains empty. 
Owen, can you please check? Tested on kohadevbox with the sample data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 00:19:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 23:19:54 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-EBeH3mwo1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Dependency still needs sign-off - moving to BLOCKED for now. Please move it
back once the dependency is ready for QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 00:21:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 23:21:29 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the
	footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-cpRhs39yHu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
One of the dependencies is not in the QA queue yet, moving to BLOCKED for now,
please move back once dependencies have been sorted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 00:22:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 23:22:26 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-bvFaNaHUFj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |BLOCKED

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
One of the dependencies is not in the QA queue yet, moving to BLOCKED for now,
please move back once dependencies have been sorted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 00:41:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Dec 2017 23:41:03 +0000
Subject: [Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for
	staff and OPAC
In-Reply-To: <bug-9495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9495-70-jx3TwOqQO4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am in doubt about adding a new routine to C4::GetOPACMarcNotes

- We are missing tests, but tests are required for any new routine or a change
to an existing one.
- I think it might make more sense to use improve GetMarcNotes to take an
interface parameter, like we do in other cases. Duplicating the code will
create problems, such as with bug 18198.

--

Some other small things:
- Database update should be in an atomicupdate file (see database update
instructions on the wiki)
- Please use INSERT IGNORE
- It might be a bit more consistent with other prefs to have
OPACNotesBlackList. Examples: (OPAC)ISBD,(OPAC)AmazonCoverImages,
(OPAC)LocalCoverImages, ...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:08:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:08:47 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-et3v6t5CJQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree with Nick - inconsistent behaviour, you don't expect for menu items to
go missing when changing the tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:10:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:10:20 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-tEjlix81UD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:10:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:10:23 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-OOVSoftiEt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69171|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70091&action=edit
Bug 19621 - Use preference check on template side to display/not display
Routing lists tab

Patch applies without issue and functions as described.

Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:16:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:16:17 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-BaKjPCydpc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Marcel,

I think <th>Reserve date</th> sould be "Hold date" or "Date hold placed" or
similar, as we don't use reserve in the GUI. Also I think you need to add
class="title-string" to ensure proper sorting of the date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:34:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:34:42 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-2RYPYsFlYT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:34:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:34:46 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-gFEKKjXpjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70039|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70092&action=edit
Bug 19857: Use BorrowerUnwantedField system preference for SMS provider
selection

Optionally hide SMS provider field in patron modification screen with
BorrowerUnwantedField system preference.

To test:
1. Apply patch
2. Append BorrowerUnwantedField with sms_provider_id and save changes
3. Go to patron modification screen in staff client
4. Observe the SMS provider selection is now hidden

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:41:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:41:15 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-4lgwH0gM70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.bourgault at inlibro.com
                   |ity.org                     |
            Summary|Add a column for note,      |Add columns for note, order
                   |order number ans ISBN in    |number and ISBN to late
                   |late order page             |orders page

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
David, don't forget to add you as Assignee when you plan to provide patches for
a bug!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 01:47:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 00:47:25 +0000
Subject: [Koha-bugs] [Bug 19870] New: Loaned items show as available unless
	logged in
Message-ID: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

            Bug ID: 19870
           Summary: Loaned items show as available unless logged in
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: jb.australian at gmail.com
        QA Contact: testopia at bugs.koha-community.org

On the OPAC search results page issued (checked out) items still show as
"Availability: Items available: (1)," when not logged in. When logged in they
displays correctly as " Availability: No items available: Issued (1),".
The items show correctly as issued in the details page regardless of whether
the user is logged in or not and display correctly in the staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 02:03:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 01:03:28 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-zSXJ38xfYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #66 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 70093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70093&action=edit
Bug 19532: Extra fixes

This patch addresses some of Liz's comments in Comment 37

- shows new due date on opac-recall.pl when the recall is requested
- shows new due date on opac-recalls.pl recalls history
- shows new due date on circ/recalls_queue.pl
- syspref is default off
- recalls tab on catalogue/detail.pl
- show that there is a recall on an item on catalogue/detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 02:06:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 01:06:01 +0000
Subject: [Koha-bugs] [Bug 19532] Recalls for Koha
In-Reply-To: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19532-70-gmtIXbXl26@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #67 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Liz Rea from comment #37)
> These are functionality notes for Aleisha
> 
> OPAC client view:
> 
> We probably want to show the borrower when the book is now expected to be
> returned by on /cgi-bin/koha/opac-recalls.pl

done

> 
> Staff views:
> 
> - syspref needs to be defaulted to off please :)

done

> 
> /cgi-bin/koha/circ/recalls_queue.pl
> - probably want to see the new due date here as well

done

> 
> /cgi-bin/koha/catalogue/detail.pl?biblionumber=16
> - do we want to see what the old due date was here? (to think about, not
> required)

i think having the old and the new due date might cause some confusion

> - Probably want to show somewhere in the item table that there is a recall,
> and for whom (kinda like we do with holds)

done

> - do we want a tab on the detail page that shows all of the recalls for this
> biblio, and who they are for?

done 

> 
> General questions: 
> 
> - If we add an item with the same item type to a biblio that has a recall,
> should checking in this newly available item trigger the recall to be filled?

i'm not too sure about this. recalls are item-level not record-level so i
haven't quite thought about how other available items could fill the recall.
perhaps a future cronjob? maybe after this base feature gets through?

> 
> I'm out of time for this run at it, but honestly what a great first whack at
> it.

i've now implemented all of the discussed comments etc and i believe this is
ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 02:34:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 01:34:47 +0000
Subject: [Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to
	Koha::Patron
In-Reply-To: <bug-17556-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17556-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17556-70-5LlaXdio7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19870

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 02:34:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 01:34:47 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-lHMsyKqKGz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17556

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
(In reply to James from comment #0)
> On the OPAC search results page issued (checked out) items still show as
> "Availability: Items available: (1)," when not logged in. When logged in
> they displays correctly as " Availability: No items available: Issued (1),".
> The items show correctly as issued in the details page regardless of whether
> the user is logged in or not and display correctly in the staff client.

hmm.. i think this problem was caused by bug 17556 ?

there seems to be an odd logic error that says an item can only have an
'onloan' status.. if a user is logged in


2094             my $userenv = C4::Context->userenv;
2095             if ( $item->{onloan}
2096                 && $userenv
2097                 && $userenv->{number}
2098                 && !(
Koha::Patrons->find($userenv->{number})->category->hidelostitems &&
$item->{itemlost} ) )
2099             {

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 02:35:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 01:35:39 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-kbFEM66dwX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #2 from Mason James <mtj at kohaaloha.com> ---
i'll upload a quick patch for this soon...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 02:52:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 01:52:47 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-ipTLTKSv5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
Created attachment 70094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70094&action=edit
pic

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 02:53:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 01:53:45 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-H5Zg9qjOIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---
(In reply to James from comment #0)
> On the OPAC search results page issued (checked out) items still show as
> "Availability: Items available: (1)," when not logged in. When logged in
> they displays correctly as " Availability: No items available: Issued (1),".

the workaround until a patch is pushed, is to set the following sysprefs to
'default' , (ie: use XSLT)

 - OPACXSLTResultsDisplay 
 - XSLTResultsDisplay 


pic attached

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 04:38:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 03:38:58 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-m7PJQ1l6Xz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #5 from Mason James <mtj at kohaaloha.com> ---
Created attachment 70095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70095&action=edit
Bug 19870: Loaned items show as available unless logged in

here's a quick fix to the problem (on 17.05.00 and up)

1/ set OPACXSLTResultsDisplay = '';
2/ log out from opac

3/ search for a title in opac, see item is available in search results
4/ check out item
5/ search for a title in opac, see item is still available?1

6/ apply patch
7/ search for an title in opac, see item is now unavailable

we still need a .t/test file for resultsSearch(), but that might be a job for
another day...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 04:41:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 03:41:24 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-NDLKB37ofu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 04:43:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 03:43:34 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-wQmv7SU8ig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:26:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:26:41 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-z2vwTqmRl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:26:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:26:44 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-7EnsGH5lNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70096&action=edit
Bug 19494: (QA follow-up) Rename column and apply title-string

As requested by Katrin, the column should not refer to Reserve but Hold.
Sorting should be the same as Waiting since-column.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:36:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:36:41 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-da9spDWUu9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:36:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:36:50 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-ZZaMDynooS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:39:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:39:06 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-AdNuqikBFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here now too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:42:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:42:04 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-RAGznnw9Yv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
require C4::Reserves;
Did I really see that ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:46:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:46:29 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-gVdoAZmBik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:46:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:46:33 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-mrGoHAjia5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70048|0                           |1
        is obsolete|                            |
  Attachment #70049|0                           |1
        is obsolete|                            |
  Attachment #70050|0                           |1
        is obsolete|                            |

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70097&action=edit
Bug 19828: Unit tests

This patch introduces unit tests for the changes this bug introduces to
Koha::Object->store.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests should fail because the changes are not implemented on this
patch

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:46:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:46:36 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-vBqHpn2PJC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70098&action=edit
Bug 19828: Make Koha::Object->store translate DBIC exceptions into Koha
exceptions

This patch introduces a try/catch block in store() and parses the error
when an exceptional situation takes place.

It only deals with FK constraint violations and duplicate IDs. The rest of the
DBIC exceptions
are rethrown.

To test:

- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:46:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:46:39 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-QGP4GNoWnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70099&action=edit
Bug 19828: Fix tests that expect DBD errors instead of the exception message

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:46:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:46:43 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-SrihEf7FXk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

--- Comment #15 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70100&action=edit
Bug 19828: (QA follow-up) Fix rethrowing exception and move rethrowing out of
'if' statement just in case the exception does not came from DBIx::Class

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:47:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:47:17 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-mYdhY6u0m0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:50:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:50:46 +0000
Subject: [Koha-bugs] [Bug 19871] New: Use new exceptions
 Koha::Exceptions::Object:: DuplicateID and FKConstraint
Message-ID: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871

            Bug ID: 19871
           Summary: Use new exceptions
                    Koha::Exceptions::Object::DuplicateID and FKConstraint
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There are some reference of DBIx::Class:Exception in our code, they should be
updated to use new Koha::Exceptions from bug 19828.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:51:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:51:08 +0000
Subject: [Koha-bugs] [Bug 19871] Use new exceptions
 Koha::Exceptions::Object:: DuplicateID and FKConstraint
In-Reply-To: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19871-70-VcaQwbSnEO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828
[Bug 19828] Koha::Object->store should catch DBIC exceptions and raise
Koha::Exceptions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:51:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:51:08 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-5O6666irL6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19871


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871
[Bug 19871] Use new exceptions Koha::Exceptions::Object::DuplicateID and
FKConstraint
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:51:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:51:31 +0000
Subject: [Koha-bugs] [Bug 19871] Use new exceptions
 Koha::Exceptions::Object:: DuplicateID and FKConstraint
In-Reply-To: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19871-70-sNKXuUfXVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871

--- Comment #1 from Josef Moravec <josef.moravec at gmail.com> ---
Affected files:

Koha/Patron/Modification.pm
Koha/REST/V1/Acquisitions/Vendors.pm
Koha/REST/V1/Cities.pm
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:56:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:56:42 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-gegcgKkFT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:56:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:56:44 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-Aeh0XpP0aG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67388|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70101&action=edit
Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests

This patch proves that we will not introduce trivial regression.
With the same tests, we will execute the existing code and the new code.

Test plan:
With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t
should return green

Followed test plan, patches worked as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:56:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:56:48 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-5j4QrOBiYg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67389|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70102&action=edit
Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed

This patchset move The OPACItemHoldsAllowed logic
(issuingrules.opacitemholds) to a new class method of
Koha::IssuingRules: get_opacitemholds_policy

On the way, this patch will certainly fix the same problem as bug
19298 with onshelfholds.

Test plan:
Make sure the opacitemholds policy is correct when placing a hold at the
OPAC or the staff interface.

Followed test plan which worked as described
Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:56:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:56:55 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-tf7urBxHAA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67390|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70103&action=edit
Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine

At this point the subroutine is not longer in use, we can remove it

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 08:57:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 07:57:10 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-VHtjXASWEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:06:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:06:26 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-UUYvTaxqjZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69637|0                           |1
        is obsolete|                            |
  Attachment #69638|0                           |1
        is obsolete|                            |

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70104&action=edit
Bug 18458: Add a subtest in Merge.t

This test illustrates the problem we have if you run it without the
second patch. And it serves to demonstrate that we resolved the
situation if you run it after the second patch.

Test plan:
[1] Without the second patch: The last subtest should fail.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:06:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:06:29 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-kyeu7Rztqv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70105&action=edit
Bug 18458: Merging authority record incorrectly orders subfields

While doing a merge, if a subfield(s) precedes the controlled subfields
(like $i before $a in 7XX, which comes before $a -- rare but will
become more and more usual) after merging will be moved to the end.
This is not right.

The patch (with AuthorityMergeMode == loose) make merge consider the
subfields order: all subfields which originally were found before
the first controlled subfield (e.g. $i before $a in 7XX / MARC 21)
will remain in the front, the rest of not controlled subfields that
should remain in the field will come after the subfields copied
from authority rec.

As a bonus, $9 will be placed at the end.

To test:
0) Have AuthorityMergeMode == loose;
1) Have some field in bibliorecord, controlled by an authority, with
extra subfield(s) (i.e. not present in authority rec.) placed at the
beginning of the field;
2) Open (not necessarily edit) and save the connected authority;
3) See that the extra subfieds were moved to the end of the field
   (and $9 is in the front);
4) Apply the patch;
5) Reorder subfields in biblio field;
6) Open (not necessarily edit) and save the connected authority;
7) See that the order has been conserved, additionally $9 the last
   subfield in the field.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended:
Moved field creation to its original place. Changed $9 handling. Simplified the
following add_subfields for loop. Edited comments.
Restored the append_fields_ordered call (see comment6).

With this patch, the Merge.t test now passes.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:08:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:08:21 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-a06GcvaEE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

--- Comment #13 from Josef Moravec <josef.moravec at gmail.com> ---
Looks good

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:34:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:34:01 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-9jq8VVJEoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69846|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70106&action=edit
Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy

Following the pattern introduced by bug 19300, we are going to move the
OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy

Test plan:
Make sure the onshelfholds policy is correct when placing a hold

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:34:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:34:05 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-YLjP0xzJSM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69847|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70107&action=edit
Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed

At this point the subroutine is not used anymore

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:33:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:33:58 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-ZNVSGMkI58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:34:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:34:09 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-ZBnLBv7RdJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70108&action=edit
Bug 19301: (QA follow-up) Add POD, use statements and correct typo

Add POD for new sub in Koha/IssuingRules.pm.
Adding use Koha::IssuingRules to opac-detail and opac-MARCdetail.
Adding use Koha::Items to opac-detail and opac-MARCdetail.
Correct typo $items => $item in opac-MARCdetail.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:34:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:34:13 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-IJDssD26gc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70109&action=edit
Bug 19301: (QA follow-up) Add a few simple tests

We removed tests from Reserves.t, but would be nice to test the new
sub in IssuingRules.t too.
Adding a subtest there.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:34:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:34:33 +0000
Subject: [Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19301-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19301-70-NK8ZPIwa7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 10:42:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 09:42:07 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-t8AtB2kcTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:03:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:03:33 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-b0DvBVNmKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:03:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:03:35 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-AEJQCpKXXl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69830|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70110&action=edit
Bug 19813 - MarcItemFieldsToOrder cannot handle a tag not existing

MarcItemFieldsToOrder defines how Koha looks at tags in order records to
generate item data.

Let's look at a simplified case:
homebranch: 955$a
holdingbranch: 956$a

So, here we are looking at 955 for the home branch, and 956 for the holding
branch. So, it should make sense that Koha requires that these fields exist in
equal number in the record. That is, for each 955, there should be a
corresponding 956.

Let's look at a different case:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a

In this case, we are using the fallback behavior. VendorA stores the branch
data in 946, and VendorB stores it in 975. This seems like it would work, but
it won't! That's because Koha is expecting there to be the same number of 946's
as there are 975's! In reality, the VendorA records will have a number of
946's, and *zero* 975's. The inverse will be true for VendorB.

Koha should be able to skip those tags that simply don't exist in the record.

Test Plan:
1) Set MarcItemFieldsToOrder to something like:
homebranch: 946$a|975$a
holdingbranch: 946$a|975$a
budget_code: 946$f|975$f
itype: 946$y|975$y
notforloan: 946$l|975$l
ccode: 946$t|975$c
quantity: 946$q|975$q
price: 946$p|975$p
itemcallnumber: 946$n|975$n
loc: 946$c|975$t
2) Create a record using only the 975 tag for item building data
3) Import the record into Koha
4) Create a basket
5) Attempt to add the record to the basket
6) Note the unequal fields error
7) Apply this patch
8) Reload the page
9) No error!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Marci Chen <mchen at mckinneytexas.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Fix typo occurrance and theses.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:05:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:05:00 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-3OPdzGFXp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Resuming here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:05:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:05:08 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-6o7hUmiKmF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|alex.arnaud at biblibre.com    |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:15:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:15:00 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-imru9B6tm8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69738|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70111&action=edit
Bug 19494: Add reservedate to Holds awaiting pickup

Add reservedate to report.
Change label "Available since" to "Waiting since".

Note: The table (already) crosses the boundaries of its container. Also
the vertical spacing for the first column (already) is not the same as the
others. (Adding the second date only makes it more visible.) These minor
design issues should be solved on another report.

Test plan:
[1] Go to Circulation, Holds awaiting pickup
[2] Note the additional column for reservedate.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:15:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:15:04 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-ZpDuqT5PCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70096|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70112&action=edit
Bug 19494: (QA follow-up) Rename column and apply title-string

As requested by Katrin, the column should not refer to Reserve but Hold.
Sorting should be the same as Waiting since-column.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:15:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:15:25 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-SqCYnT7mzh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:25:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:25:26 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-VpSX4VJ9P2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Aleisha Amohia from comment #4)
> (In reply to Marcel de Rooy from comment #3)
> > This looks like a change in behavior. When the cgi param is default, no
> > profile id was passed.
> > I guess what you wanted to do was just if( $param && $param eq ... ) ?
> 
> Hi Marcel,
> 
> there is no change in behaviour in my patch. It looks like there's
> originally a bug here, because the original code says "if
> $query->param('csv_profile') eq 'default'", but the word 'default' is never
> passed through that param, based on acqui/basket.tt. this means that when
> the Default option was selected, the $query->param('csv_profile') is not
> actually set to 'default' so an uninitialised value is sent to the
> GetBasketAsCSV method and the 'if' condition is never true. (I hope that
> makes sense. If you put a warn inside the if statement under where
> $query->param('csv_profile') eq default, you'll see that it never enters
> here and never prints the warn.)
> 
> my patch checks if the $query->param('csv_profile') has been defined. if it
> has, then it uses one of the library-made csv profiles. if it hasn't been
> defined then it must be using the default profile and no ID is passed, as
> intended, with no warns.
> 
> setting back to needs signoff as I believe this is still a valid patch.

You are right that the compare with 'default' makes no sense. It may have been
a leftover from the past.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:25:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:25:43 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-1EScR6bZiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Alex Arnaud from comment #6)
> Is the if() else() statement still usefull? Why not just one call to
> GetBasketAsCSV?

Yes. Adding a follow-up for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:26:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:26:06 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-tQFh1ptccW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:26:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:26:08 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-MOnsuji5gs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69959|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70113&action=edit
Bug 19200: Preventing warns when exporting a basket

To test:
1) Go to Tools -> CSV profiles -> New CSV Profile
2) Create a new CSV profile with any name of SQL fields. Ensure profile
type: SQL and usage: basket export in acquisition
3) Go to Acquisitions -> Find or create a vendor -> Use or create a
basket
4) Click the dropdown menu next to the 'Export as CSV' button. There
should be a 'Default' option and your new CSV profile (at least)
5) Click the 'Default' option. Notice warns
6) Click the 'Export as CSV' button. Notice warns
7) Click your new CSV profile option. Notice warns
8) Apply patch and refresh page
9) Repeat steps 5-7, confirm that warns do not show
10) Confirm export still works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:26:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:26:12 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-2kUyVHUC6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70114&action=edit
Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV

If no profile_id is passed, GetBasketAsCSV will fallback to default itself.
No need to make the distinction in basket.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:28:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:28:55 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-jJE4y98kPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:54:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:54:40 +0000
Subject: [Koha-bugs] [Bug 19315] Routing preview may use wrong biblionumber
In-Reply-To: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19315-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19315-70-1mLLSQPI7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19315

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Patch in comment 12 has been pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:55:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:55:11 +0000
Subject: [Koha-bugs] [Bug 19808] Reviews from deleted patrons make few
	scripts to explode
In-Reply-To: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19808-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19808-70-BK2OUobvfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |nick at bywatersolutions.com

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
All but last patch (translation) have been pushed to stable for 17.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 11:56:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 10:56:08 +0000
Subject: [Koha-bugs] [Bug 19843] reviews.datereviewed is not set
In-Reply-To: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19843-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19843-70-VW6dJGoAAj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19843

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Pushed to stable for 17.11.01, awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:03:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:03:51 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-Gk7aQokGfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:03:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:03:53 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-5o8IKBq3uB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69829|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70115&action=edit
Bug 19812 - Holds count in "Already received" table has confusing and
unexpected values

In acqui/parcel.pl both the "Pending orders" and "Already received" tables show
how many holds there are for the given record. However, the count of holds in
the "Pending orders" table confuses librarians because it only lists holds for
the particular items in the orderline. Due to that, the holds column may show 0
holds even if there are a dozen record level holds for that bib! This is not
what librarians seem to expect, instead it seems that the same total holds in
the "Pending orders" table would be preferred.

Test Plan:
1) Find an invoice with an item in the "Already received" table
2) Add one or more record level holds to the record
3) Note the holds column does not count those holds
4) Apply this patch
5) Note the holds column now shows total holds and holds for just those ordered
items

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Nancy Keener <nkeener at washoecounty.us>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:04:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:04:56 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-7Tbe5keJwB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:13:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:13:43 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-AW3fkBWF8R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jon Knight from comment #2)
> 3) sudo chmod a+rx /etc/koha/sites/kohadev/koha-conf.xml

chmod 640 might be better ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:15:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:15:23 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-42lcfj1OOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:15:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:15:26 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-b788ASVqoW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69571|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70116&action=edit
Bug 19760: Die if koha-conf is not accessible

We got a lot of support questions because scripts are executed without
the correct environment/user.
We could die and provide more useful information

Tested on my kohadevbox VM by:

1) sudo chmod a-rx /etc/koha/sites/kohadev/koha-conf.xml
2) run help.pl from the command line to produce the desired die message
3) sudo chmod a+rx /etc/koha/sites/kohadev/koha-conf.xml
4) rerun help.pl successfully

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:15:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:15:31 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-0y9UTPwU96@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70014|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 70117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70117&action=edit
Bug 19760: Change wording

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:15:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:15:52 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-CsWqHOsZVi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:18:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:18:05 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-yPf2EZcJZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looks good to me. Moving to Stable status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:18:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:18:15 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-OiTHW8zeXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 12:18:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 11:18:22 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-Os8mZnyNqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 13:06:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 12:06:00 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-10kEsD4N0B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I like the idea of such a performance boost.
Could you move the anonymous sub out of GetBudgetHierarchy? Can it be tested
separately? Or do you think that the current code in Budgets.t sufficiently
covers your changes (including processing a budget tree) ?

Changing status to reflect need for some adjustments/feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 14:04:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 13:04:52 +0000
Subject: [Koha-bugs] [Bug 17672] Items table should have a damaged_on column
In-Reply-To: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17672-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17672-70-1K24ocN6ZJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 14:15:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 13:15:19 +0000
Subject: [Koha-bugs] [Bug 19300] Move C4::Reserves::OPACItemHoldsAllowed to
 the Koha namespace
In-Reply-To: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19300-70-69L7IuGcM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #8)
> require C4::Reserves;
> Did I really see that ?

It is removed in the next patch. The goal was to prove that the same tests were
passing with the current code and the new code :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 14:42:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 13:42:49 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-iEFgbJHxGl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 14:42:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 13:42:52 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-OYmWN6Kypp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70118&action=edit
Bug 19623: (Follow-up) Correct footer include in pop-up windows

This patch corrects the footer include in two templates for Z39.50
pop-up windows. popup-bottom.inc shouldn't be used because it doesn't
have the JavaScript embed code in it.

To test, perform a Z39.50 search from both the MARC bibliographic editor
and the MARC authority editor. In both cases the Z39.50 popup window
should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 14:51:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 13:51:20 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-n98UfWNZaj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19872


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872
[Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins,
part 4
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 14:51:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 13:51:20 +0000
Subject: [Koha-bugs] [Bug 19872] New: Move template JavaScript to the
 footer: UNIMARC editor plugins, part 4
Message-ID: <bug-19872-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872

            Bug ID: 19872
           Summary: Move template JavaScript to the footer: UNIMARC editor
                    plugins, part 4
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

Most UNIMARC plugin templates already have JavaScript at the bottom of the
template instead of the top, but they should still be modified to be consistent
with other templates which have been updated as part of Bug 17858.

This patch modifies more and more UNIMARC editor plugins.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:12:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:12:49 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-3QlyO9CSbH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19401
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Patch doesn't apply

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please rebase on top of bug 19401.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401
[Bug 19401] No confirm message when deleting an invoice from invoice detail
page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:12:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:12:49 +0000
Subject: [Koha-bugs] [Bug 19401] No confirm message when deleting an invoice
 from invoice detail page
In-Reply-To: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19401-70-K8WdwEq14U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19753


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753
[Bug 19753] Move template JavaScript to the footer: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:13:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:13:14 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-w6kx52eEQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70063|0                           |1
        is obsolete|                            |

--- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70119&action=edit
Bug 19826: Add K::Acq::Budget(s) and K::Acq::Fund(s)

This patch introduces Koha::Object(s)-derived classes for budgets and funds
(aqbudgetperiods and aqbudgets respectively).

C4::Budgets already uses DBIC calls on those tables so transition should be
easy on top of this.

To test:
- Check the referenced schema files are the right ones.
- QA scripts shoudl be happy.
- Sign off :-D

Note: the POD coverage report throws a false negative result on singular
classes which is trivially wrong.

Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:13:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:13:27 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-CBFTeUvj7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70064|0                           |1
        is obsolete|                            |

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70120&action=edit
Bug 19826: Unit test files

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:13:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:13:50 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-byiKmRh6OH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:16:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:16:11 +0000
Subject: [Koha-bugs] [Bug 19872] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 4
In-Reply-To: <bug-19872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19872-70-298OnNUZC9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:16:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:16:13 +0000
Subject: [Koha-bugs] [Bug 19872] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 4
In-Reply-To: <bug-19872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19872-70-s5OgAO7Wuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70121&action=edit
Bug 19872: Move template JavaScript to the footer: UNIMARC editor plugins, part
4

This patch updates more and more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_124a.tt
- unimarc_field_124b.tt
- unimarc_field_124c.tt
- unimarc_field_124d.tt
- unimarc_field_124e.tt
- unimarc_field_124f.tt
- unimarc_field_124g.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:17:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:17:22 +0000
Subject: [Koha-bugs] [Bug 19873] New: Make it possible to search on value 0
Message-ID: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

            Bug ID: 19873
           Summary: Make it possible to search on value 0
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gaetan.boisson at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

The current code considers a value of 0 in a search query as an empty string,
that is, it won't search on it.

If a library wants to search for records that specifically have the value "0"
in a given field, it will not be possible.

This patch aims to correct this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:17:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:17:33 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-PdBXsurdmP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #21)
> (In reply to Julian Maurice from comment #18)
> > (In reply to Jonathan Druart from comment #15)
> > > Hum, so Koha::Acquisition::Vendor::Basket::Order? :)
> > 
> > Please, no :)
> > Not everything can be represented in a tree.
> > Where do you place basket groups in this hierarchy ? It could be
> > Koha::Acq::Vendor::Basketgroup::Basket, but not every basket belongs to a
> > basketgroup.
> > Also, there is a 1-n relationship between biblio and aqorders, but
> > Koha::Biblio::Orders does not make much sense IMHO.
> > 
> > If there was a vote, I'd vote for everything on one level
> 
> Not everything, but I would prefer Koha::Acq::Budget[s] and
> Koha::Acq::fund[s] too.
> Setting to In Discussion to get more opinions.

I don't really care, really. I've moved Fund(s).pm one level up, and marked PQA
so Matthias can code the funds endpoint on top of this. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:19:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:19:51 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-1OwMBMVX06@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am ok with this approach - I think our relations could get confusing fast.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:21:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:21:36 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-jp3WzNM0bg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
If there are no holds, should not we display "0" instead of "0 / 0"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:21:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:21:42 +0000
Subject: [Koha-bugs] [Bug 19874] New: Move template JavaScript to the
 footer: UNIMARC editor plugins, part 5
Message-ID: <bug-19874-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874

            Bug ID: 19874
           Summary: Move template JavaScript to the footer: UNIMARC editor
                    plugins, part 5
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

Most UNIMARC plugin templates already have JavaScript at the bottom of the
template instead of the top, but they should still be modified to be consistent
with other templates which have been updated as part of Bug 17858.

This patch modifies yet more UNIMARC editor plugins.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:21:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:21:42 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-2cc6IVCDDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19874


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874
[Bug 19874] Move template JavaScript to the footer: UNIMARC editor plugins,
part 5
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:25:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:25:07 +0000
Subject: [Koha-bugs] [Bug 19792] Reduce number of SQL calls in
	GetBudgetHierarchy
In-Reply-To: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19792-70-8ET36JCJjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

David Bourgault <david.bourgault at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #6 from David Bourgault <david.bourgault at inlibro.com> ---
I don't think I can move the recursive sub out of GetBudgetHierarchy, since it
calls variables local to that function. If it were moved out it would need to
either rebuild them everytime, which voids the perf boost, or receive them as
parameters, which would make the code less readable, and requires the dev to
know the exact SQL query result to pass.

In this case I strongly believe an anonymous inner function is the best way to
go. As for tests, the current test to budgets.t should be sufficient as this
does not (should not!) change behavior. It is supposed to replace the inner
workings of the function with no impact on input or output.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:28:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:28:25 +0000
Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0
In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19873-70-lU9suLw4zS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

--- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70122&action=edit
Bug 19873 - Ability to search on 0 value

Test plan:
  - create a st-numeric index in zebra conf related to
    a numeric field
    i.e:
    yourindex 1=yourindex 4=109
  - fill a field with 0 in a biblio,
  - reindex your biblios,
  - search yourindex=0,
  - should not work,
  - apply this patch,
  - test again,
  - should work

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:29:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:29:04 +0000
Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0
In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19873-70-l6W2Vy5e0Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |alex.arnaud at biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:29:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:29:17 +0000
Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0
In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19873-70-FEDE960uZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:30:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:30:32 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-mX6Go1Ql2r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70081|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70123&action=edit
Bug 19753: Move template JavaScript to the footer: Acquisitions

This patch modifies some staff client acquisitions templates so that
JavaScript is included in the footer instead of the header.

This patch adds a JavaScript file, acquisitions-menu.js, which controls
the highlighting of the current page in the sidebar. Highlighting will
be temporarily broken for pages which have not been modified to include
this file

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Acquisitions home page
  - Datatable, Inactive budget controls
- Vendor search results
  - Acquisitions -> Vendor search
    - Datatables, "Show all" links
- Basket
  - Acquisitions -> Vendor -> Basket
    - Datatables, button controls, add managing user
- Add to basket from a staged file
  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - Datatables, tabs, selection controls
- Edit basket
  - Acquisitions -> Vendor -> Edit basket
    - Form validation
- EDIFACT messages
  - Acquisitions -> EDIFACT messages
    - Datatables, message preview
- Orders search
  - Acquisitions -> Order search
    - Full orders search form
      - Patron autocomplete in "Basket created by" field
      - Datepickers
    - Orders search results
      - Datatables, column visibility
- Invoices
  - Acquisitions -> Vendor -> Invoices -> Invoice
    - Form validation, datepickers, datatables
  - Invoice files (enable AcqEnableFiles preference)
    - Manage invoice files
      - File list datatable

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:30:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:30:34 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-tSfOtxkF0U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70082|0                           |1
        is obsolete|                            |

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70124&action=edit
Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice
page

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:30:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:30:47 +0000
Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0
In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19873-70-vAnLXWbUS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:30:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:30:57 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-aaNelFnvyS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:32:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:32:04 +0000
Subject: [Koha-bugs] [Bug 19875] New: When & is in the title of a search
 result, subscribing via rss can be broken
Message-ID: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875

            Bug ID: 19875
           Summary: When & is in the title of a search result, subscribing
                    via rss can be broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: christophe.croullebois at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

This issue is not in all cases (depend on many factors).
It is due to the xml syntax where the use of "&" is forbidden and must be
"&amp;"
Koha do the job in this line :
<title>[% SEARCH_RESULT.title |html %].......
With the use of "|html"
But not in this line :
Place Hold on <i>[% SEARCH_RESULT.title %]</i>......
The patch is very light just adds "|html" in the line above.
#################
Test Plan :
1? in opac do a search where you can find "&" in the title
2? in the result page click on the rss button on the right of "Your search
returned n results." (Subscribe to this search)
3? if your subscribe is ok you can not perform the test :o(
4? if your subscribe is nok you can apply the patch
5? test the same work flow with the patch the subscribe must be ok.
Thx

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:32:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:32:31 +0000
Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0
In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19873-70-eqMOp1wc1B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:35:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:35:35 +0000
Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0
In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19873-70-qi5qzStcou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
+ original_operand => ($operands[$i] ne '') ? $operands[$i] : '',

I think it could be more pretty :

+ original_operand => $operands[$i] // '',

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:36:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:36:27 +0000
Subject: [Koha-bugs] [Bug 19873] Make it possible to search on value 0
In-Reply-To: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19873-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19873-70-WyW3ItIskN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:37:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:37:52 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-lTGsrEgSUD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #19 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70125&action=edit
Bug 19368 - Removed the old preference 'SerialSortIgnoreWords' that was left
hanging in serials.pref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:43:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:43:18 +0000
Subject: [Koha-bugs] [Bug 11291] Change the behavior of any index in DOM
	indexing
In-Reply-To: <bug-11291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11291-70-eGVjQQ8GWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11291

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I will work on Bug 8962 so I set this one as duplicate

*** This bug has been marked as a duplicate of bug 8962 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:43:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:43:18 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "  any"
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-xD2wDfXMbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #49 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
*** Bug 11291 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:43:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:43:27 +0000
Subject: [Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting
	serials
In-Reply-To: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19368-70-7FF5Uzt8FX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

--- Comment #20 from Charles Farmer <charles.farmer at inlibro.com> ---
(In reply to Katrin Fischer from comment #14)
> As this now not only works for Serials, but for datatables in general, I
> think maybe it would better fit on the 'staff client' tab? Hope I didn't
> misunderstand the change.

The preference was recently moved from serials.pref to searching.pref to
account, as you said, for the more 'global' impact the change has on
datatables.

I have no qualms moving it though, if admin/preferences/searching.pref is not
where you feel it should be.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:43:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:43:50 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "  any"
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-in1myFAiWQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |fridolin.somers at biblibre.co
                   |                            |m
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:46:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:46:00 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "  any"
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-UO13NlZTh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25673|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:46:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:46:22 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "  any"
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-E8t0f5bXJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25674|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:46:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:46:49 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "  any"
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-EMzTMr0ESv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25675|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:53:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:53:18 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "  any"
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-yZm5i7PAAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED

--- Comment #50 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
I found this exact bug and found an easy way to propose a solution.

I set GRS1 patches has invalid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:57:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:57:56 +0000
Subject: [Koha-bugs] [Bug 19874] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 5
In-Reply-To: <bug-19874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19874-70-N00AwG6Ujs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70126&action=edit
Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part
5

This patch updates yet more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_125a.tt
- unimarc_field_125b.tt
- unimarc_field_126a.tt
- unimarc_field_126b.tt
- unimarc_field_127.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:57:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:57:53 +0000
Subject: [Koha-bugs] [Bug 19874] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 5
In-Reply-To: <bug-19874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19874-70-e18TbsaizD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 15:59:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 14:59:55 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-3DpUiN9Dla@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:00:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:00:03 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-RmyaNZNQ96@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:01:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:01:06 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-FVj6zmeBFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Create a new index for OPAC |Restore Any index behavior
                   |simple search, more         |and add Anywhere index
                   |specific than "any"         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:03:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:03:56 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-3czqvOX4x9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #51 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
> 
> The "Any" index/register should contains all the data contained in all the
> other indexes/registers (e.g. Title, Author, Subject, etc). 
> 
> The "Anywhere" index/register should contain the entire record including
> fields/subfields that aren't indexed anywhere else. 
> 

This is what I want to do so I changed the bug description.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:10:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:10:41 +0000
Subject: [Koha-bugs] [Bug 19876] New: Koha::Account->pay() does not exit
 specific fine loop when balance is used up
Message-ID: <bug-19876-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

            Bug ID: 19876
           Summary: Koha::Account->pay() does not exit specific fine loop
                    when balance is used up
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If a patron selects specific fines to pay and enters an amount less than all of
those fines the loop will continue through all fines. This can be problematic
for lost fines which are not paid or not paid fully as they will be marked
'Paid for...' and returned

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:22:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:22:19 +0000
Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet
In-Reply-To: <bug-11317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11317-70-F9tS1YombP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

--- Comment #116 from Josef Moravec <josef.moravec at gmail.com> ---
Sorry, I see it is long process to get this to Koha, but I have one more
concern:

If there are files with the same name in multiple directories, they have the
same hash! Than only one of them is always downloaded, although both (or more)
are listed.

The path of each file should be presented in the table too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:22:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:22:46 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-kDLSRThRhh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Failed QA

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
All works great, few concerns:
1. Code in C4::Auth must be simplify and merged with existing one (you c/p 25 
lines)
2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we should
apply the same behaviour as self-checkout (no?)
3. Description (and name) of the permission self_checkout must be adapted
4. I do not know how SCOMainUserBlock is used, but it may be wrong to display
it for SCI (?)
5. "Data corruption detected" => Are we sure we want to display that at the
OPAC?
6. If error code is not known, we should display it instead of ignore it (BLOCK
error_message)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:24:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:24:35 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-vuFTDmCMcQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #52 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 70127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70127&action=edit
Bug 8962: Restore Any index behavior and add Anywhere index

The "Any" index/register should contains all the data contained in all the
other indexes/registers (e.g. Title, Author, Subject, etc).

The "Anywhere" index/register should contain the entire record including
fields/subfields that aren't indexed anywhere else.

In GRS1 indexing the Any index was indeed only on fields defined as indexed.
This has changed in DOM where all data in MARC is indexed with Any.
This generates a lot of results when no index is defined in search.

This patch changes the DOM xsl config generation to add Any to each indexed
data and add Anywhere to keep a way of searching on all data.

Test plan :
- Add a data on a field that is not indexed : for example "toto" in 998$z
- Add same data as the title of another record
- Index the records
- Search on toto without index (uses Any) => you get the 2 records
- Search on toto with title index => you get the record with "toto" as title
- Apply patch
- Update DOM xsl config files
- Reindex
- Search on toto without index (uses Any) => you get the record with "toto" as
title
- Search on toto with title index => you get the record with "toto" as title
- Search on toto with Anywhere index => you get the 2 records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:27:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:27:56 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-Mwmeb6Yir8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #53 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Once validated, we will patch the DOM XSL config files.

Maybe first patch needs some changes, let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:29:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:29:40 +0000
Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI
	GetRecords response
In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19380-70-pWNIqpRuNw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 67577
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67577
Bug 19380: Add transfer informations in ILS-DI GetRecords response

Review of attachment 67577:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19380&attachment=67577)
-----------------------------------------------------------------

::: C4/ILSDI/Services.pm
@@ +239,5 @@
>              my $holding_library = Koha::Libraries->find( $item->{holdingbranch} );
>              $item->{'homebranchname'}    = $home_library    ? $home_library->branchname    : '';
>              $item->{'holdingbranchname'} = $holding_library ? $holding_library->branchname : '';
> +
> +            my ($transferDate, $transferFrom, $transferTo) = GetTransfers($item->{itemnumber});

You should use Koha::Item->get_transfer instead

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:30:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:30:18 +0000
Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI
	GetRecords response
In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19380-70-nB1XFAnhOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:31:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:31:24 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-QnzZCEZYfM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70081|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:31:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:31:29 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-qSs0ruokGK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70082|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:31:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:31:39 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-QJeKCkUXyD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70123|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:31:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:31:43 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-9cmHHAVfOl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70124|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:38:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:38:50 +0000
Subject: [Koha-bugs] [Bug 9495] Split NotesBlacklist in to two prefs for
	staff and OPAC
In-Reply-To: <bug-9495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9495-70-D80YDceHUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|split NotesBlacklist in to  |Split NotesBlacklist in to
                   |two prefs for staff and     |two prefs for staff and
                   |OPAC                        |OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:40:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:40:09 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-CJiDDBiUbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70082|0                           |1
        is obsolete|                            |

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70128&action=edit
Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice
page

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:40:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:40:53 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-Ml0au6F2pQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70128|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:40:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:40:56 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-Q4PPK1DWKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70081|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:41:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:41:11 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-mP7EADPjqA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70129&action=edit
Bug 19753: Move template JavaScript to the footer: Acquisitions

This patch modifies some staff client acquisitions templates so that
JavaScript is included in the footer instead of the header.

This patch adds a JavaScript file, acquisitions-menu.js, which controls
the highlighting of the current page in the sidebar. Highlighting will
be temporarily broken for pages which have not been modified to include
this file

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

- Acquisitions home page
  - Datatable, Inactive budget controls
- Vendor search results
  - Acquisitions -> Vendor search
    - Datatables, "Show all" links
- Basket
  - Acquisitions -> Vendor -> Basket
    - Datatables, button controls, add managing user
- Add to basket from a staged file
  - Acquisitions -> Vendor -> Basket -> Add to basket from a staged file
    - Datatables, tabs, selection controls
- Edit basket
  - Acquisitions -> Vendor -> Edit basket
    - Form validation
- EDIFACT messages
  - Acquisitions -> EDIFACT messages
    - Datatables, message preview
- Orders search
  - Acquisitions -> Order search
    - Full orders search form
      - Patron autocomplete in "Basket created by" field
      - Datepickers
    - Orders search results
      - Datatables, column visibility
- Invoices
  - Acquisitions -> Vendor -> Invoices -> Invoice
    - Form validation, datepickers, datatables
  - Invoice files (enable AcqEnableFiles preference)
    - Manage invoice files
      - File list datatable

Signed-off-by: Simon Pouchol <simon.pouchol at biblibre.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:41:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:41:14 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-frpIN8loXg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70130&action=edit
Bug 19753: (QA follow-up) Style invoices menu item when on individual invoice
page

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:52:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:52:45 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-3oaCXppLmr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19877


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877
[Bug 19877] Move template JavaScript to the footer: UNIMARC editor plugins,
part 6
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 16:52:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 15:52:45 +0000
Subject: [Koha-bugs] [Bug 19877] New: Move template JavaScript to the
 footer: UNIMARC editor plugins, part 6
Message-ID: <bug-19877-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877

            Bug ID: 19877
           Summary: Move template JavaScript to the footer: UNIMARC editor
                    plugins, part 6
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

Most UNIMARC plugin templates already have JavaScript at the bottom of the
template instead of the top, but they should still be modified to be consistent
with other templates which have been updated as part of Bug 17858.

This patch modifies more UNIMARC editor plugins than ever before.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:03:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:03:01 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-pLcfLiyaRB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
"Holds count in "Already received" table has confusing and unexpected values"
Does not describe what the patch does.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:08:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:08:48 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
 confusing and unexpected values
In-Reply-To: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19812-70-xxCG5ByT3K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There is an access to the removed variable "holds" in the template
loop_order.holds

That means we now see "Can't delete catalog record, see constraints below", but
without anything below...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:09:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:09:33 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-vLuXtttJDO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
"MarcItemFieldsToOrder cannot handle a tag not existing": This commit message
does not describe what the patch does

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:14:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:14:02 +0000
Subject: [Koha-bugs] [Bug 19360] Give items URL a link text
In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19360-70-6VlHQcvnzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Failed QA

--- Comment #14 from Josef Moravec <josef.moravec at gmail.com> ---
Alex,
please make the changes to Koha::Schema namespace a separate patch. It always
should be done this way and generated by misc/devel/update_dbix_class_files.pl.

Also the patches need rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:13:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:13:58 +0000
Subject: [Koha-bugs] [Bug 19788] Case sensitivity is not preserved when
 creating local system preferences
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-0xJbnQfRMg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Local preference with       |Case sensitivity is not
                   |uppercase                   |preserved when creating
                   |                            |local system preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:16:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:16:32 +0000
Subject: [Koha-bugs] [Bug 17951] koha-create should create the template
 cache dir and configure it in koha-conf.xml
In-Reply-To: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17951-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17951-70-a0rA3QG4p6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:16:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:16:38 +0000
Subject: [Koha-bugs] [Bug 18458] Merging authority record incorrectly orders
	subfields
In-Reply-To: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18458-70-iSHscBYGrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:16:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:16:26 +0000
Subject: [Koha-bugs] [Bug 16764] Update printers administration page
In-Reply-To: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16764-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16764-70-OLRvrOVyxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:16:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:16:44 +0000
Subject: [Koha-bugs] [Bug 19200] Warns when exporting a basket
In-Reply-To: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19200-70-mKTWzlQnfc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:16:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:16:49 +0000
Subject: [Koha-bugs] [Bug 19494] Add reservedate to Holds awaiting pickup
In-Reply-To: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19494-70-W4naHPRu5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19494

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:16:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:16:55 +0000
Subject: [Koha-bugs] [Bug 19621] Routing lists tab not present when viewing
 'Holds history' tab for a patron
In-Reply-To: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19621-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19621-70-uiJce4kgcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19621

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:00 +0000
Subject: [Koha-bugs] [Bug 19702] Basket not displaying correctly on home page
In-Reply-To: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19702-70-oqxOv4m52h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19702

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:07 +0000
Subject: [Koha-bugs] [Bug 19744] Move template JavaScript to the footer:
 Offline circulation
In-Reply-To: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19744-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19744-70-RyEKMtxv7x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19744

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:14 +0000
Subject: [Koha-bugs] [Bug 19753] Move template JavaScript to the footer:
	Acquisitions
In-Reply-To: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19753-70-qOsX2pznbm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:19 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-qYkfXqHKV6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:25 +0000
Subject: [Koha-bugs] [Bug 19788] Case sensitivity is not preserved when
 creating local system preferences
In-Reply-To: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19788-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19788-70-EqCHJ4V5tW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19788

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:30 +0000
Subject: [Koha-bugs] [Bug 19813] MarcItemFieldsToOrder cannot handle a tag
	not existing
In-Reply-To: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19813-70-ksosNG7QSa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19813

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:35 +0000
Subject: [Koha-bugs] [Bug 19828] Koha::Object-> store should catch DBIC
 exceptions and raise Koha::Exceptions
In-Reply-To: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19828-70-yZ8QZgbmLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19828

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:42 +0000
Subject: [Koha-bugs] [Bug 19840] Patron note is not displayed on checkin
In-Reply-To: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19840-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19840-70-fOMIFLY7ET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:17:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:17:47 +0000
Subject: [Koha-bugs] [Bug 19857] Optionally hide SMS provider field in
 patron modification screen
In-Reply-To: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19857-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19857-70-WnsxsPm0Gx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19857

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:18:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:18:52 +0000
Subject: [Koha-bugs] [Bug 19522] Label creator - some strings are not
	translatable
In-Reply-To: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19522-70-2gpsHjf05O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Patch doesn't apply

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:35:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:35:39 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-vuk3tppEey@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70131&action=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:36:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:36:07 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-MlrFtgSJ2m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70132&action=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:36:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:36:21 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-zRMXuzD6AP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70133&action=edit
Bug 19817: Add new permission edit_help

Change in existing behaviour!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:37:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:37:02 +0000
Subject: [Koha-bugs] [Bug 19877] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 6
In-Reply-To: <bug-19877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19877-70-W8mOlMSPD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:37:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:37:04 +0000
Subject: [Koha-bugs] [Bug 19877] Move template JavaScript to the footer:
 UNIMARC editor plugins , part 6
In-Reply-To: <bug-19877-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19877-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19877-70-1vRO1wlkWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 70134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70134&action=edit
Bug 19877: Move template JavaScript to the footer: UNIMARC editor plugins, part
6

This patch updates more UNIMARC plugin templates than ever before, so
that JavaScript is included in the footer following the same pattern as
other templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_128a.tt
- unimarc_field_128b.tt
- unimarc_field_128c.tt
- unimarc_field_130.tt
- unimarc_field_135a.tt
- unimarc_field_140.tt
- unimarc_field_141.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:43:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:43:21 +0000
Subject: [Koha-bugs] [Bug 19360] Give items URL a link text
In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19360-70-MlkBA6HXns@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:45:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:45:08 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-0SPKJ7vjFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |laurence.rault at biblibre.com
                   |                            |, ldjamison at marywood.edu,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |oleonard at myacpl.org,
                   |                            |veron at veron.ch

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Next step is to re-add the ability to "edit the manual".
I would suggest to remove the possibility to edit the manual, but allow to
create new pages (which will not be erased on update).

I need to know what are the different use cases and needs.

We need also to think about an ergonomic way to manage these additional help
files.
For instance: in the top right of the staff pages we will have a "Help" group
buttons with
  Link to the official manual | Add a new page
And when new pages are created:
  Link to the official manual | Additional pages 1..N | Add a new page

The additional pages would be linked to a specific page of the staff interface
(see the mapping in Koha::Manual)

Does it make sense? Other ideas/opinions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:45:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:45:19 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19817-70-VHKU4B9QCO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 17:54:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 16:54:21 +0000
Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result,
 subscribing via rss can be broken
In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19875-70-XScDtWIQw9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Christophe, do you plan to attach a patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 18:05:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 17:05:29 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-0PsX6SMPxR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70135&action=edit
Bug 19760: Fix Config.t test

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 18:06:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 17:06:07 +0000
Subject: [Koha-bugs] [Bug 19760] Die instead of warn if koha-conf is not
	accessible
In-Reply-To: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19760-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19760-70-RROUvcM09v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19760

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last patch pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 18:57:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 17:57:42 +0000
Subject: [Koha-bugs] [Bug 19579] PatronSelfRegistrationEmailMustBeUnique
 does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail
In-Reply-To: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19579-70-JENvCTplRq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 18:57:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 17:57:45 +0000
Subject: [Koha-bugs] [Bug 19579] PatronSelfRegistrationEmailMustBeUnique
 does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail
In-Reply-To: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19579-70-namjMHdqOh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70136&action=edit
Bug 19579: Do not confirm the registration if email already used -
PatronSelfRegistrationEmailMustBeUnique

If PatronSelfRegistrationVerifyByEmail and
PatronSelfRegistrationEmailMustBeUnique are set, it should not be
possible to register twice with the same email.
However the test is made on already created patron cards when the
registration is done.
Which means it is possible to register several times with the same
email address and click on the registration link to finalise the
registration.

This patch adds a test when the registration link is clicked and display
the "Registration invalid" generic message if the same email is used

Test plan:
1. Patron submits self registration form using the same email address 3
times
2. Patron receives 3 verification emails
3. Patron clicks on 3 verify token URLs
=> Only the first registration should succeed, the 2 others must fail

Maybe we should display a more specific message?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 18:57:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 17:57:57 +0000
Subject: [Koha-bugs] [Bug 19579] PatronSelfRegistrationEmailMustBeUnique
 does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail
In-Reply-To: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19579-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19579-70-aQhNtQuxhP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|16.05                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 19:04:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 18:04:13 +0000
Subject: [Koha-bugs] [Bug 19878] New: Move template JavaScript to the
 footer: UNIMARC editor plugins, part 7
Message-ID: <bug-19878-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878

            Bug ID: 19878
           Summary: Move template JavaScript to the footer: UNIMARC editor
                    plugins, part 7
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
            Blocks: 17858

Most UNIMARC plugin templates already have JavaScript at the bottom of the
template instead of the top, but they should still be modified to be consistent
with other templates which have been updated as part of Bug 17858.

This patch modifies the last of the UNIMARC editor plugins.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 19:04:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 18:04:13 +0000
Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to
	the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-oj4Pp5Mqq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19878


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878
[Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins,
part 7
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 19:23:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 18:23:33 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-Xx82azDoZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70137&action=edit
Bug 19564: Add tests for _convert_sort_fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 19:24:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 18:24:16 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-bgN1cDObIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nice ascii art

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 19:24:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 18:24:30 +0000
Subject: [Koha-bugs] [Bug 19564] Fix extraction of sort order from sort
	condition name
In-Reply-To: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19564-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19564-70-4o9UQTEXaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19564

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 20:19:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 19:19:41 +0000
Subject: [Koha-bugs] [Bug 19796] [16.11] Subscription info appears doubled
 up on OPAC detail page
In-Reply-To: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19796-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19796-70-VzJNjEqQS2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19796

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 16.11.x will be in 16.11.15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 21:48:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 20:48:12 +0000
Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning
 before leaving page if there are unsaved modifications
In-Reply-To: <bug-19267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19267-70-BhRsXceZDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Failed QA

--- Comment #3 from Josef Moravec <josef.moravec at gmail.com> ---
Sorry, but this is wrong.

You need to return 'undefined' in case there are no changes, this patch just
fires the question dialog everytime.

See this page for more:
https://stackoverflow.com/questions/7317273/warn-user-before-leaving-web-page-with-unsaved-changes

We could also consider to add this functionality to all Koha pages (or almost
all) through some existing plugin like http://plugins.jquery.com/are-you-sure/
but thats definitely out of scope of this bug, as Rancor is a special case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 21:48:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 20:48:25 +0000
Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning
 before leaving page if there are unsaved modifications
In-Reply-To: <bug-19267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19267-70-7P9mIEgGre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 21:51:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 20:51:47 +0000
Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning
 before leaving page if there are unsaved modifications
In-Reply-To: <bug-19267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19267-70-m2Awcx1LXr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
One more thing: You even don't need jquery this should be enough:

window.onbeforeunload = function() { ... };

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:09:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:09:20 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-hWhmXLbPQL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:16:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:16:13 +0000
Subject: [Koha-bugs] [Bug 19870] Loaned items show as available unless
	logged in
In-Reply-To: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19870-70-KBVb1WCQWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

--- Comment #6 from Dominic Pichette <dominic.pichette at inlibro.com> ---
I got this after applying patch and searching for an item:
syntax error at /inlibro/git/koha-v1605-dev-inlibro/C4/Search.pm line 2128,
near "}"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:25:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:25:09 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-6fzUZytk6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70011|0                           |1
        is obsolete|                            |

--- Comment #7 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 70138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70138&action=edit
Bug 19841: Make AddMember raise an exception if categorycode is invalid

This patch makes C4::Members::AddMember raise a Koha::Exceptions::BadParameter
exception. The current behaviour is to just explode. Code calling
AddReturn should work as expected, unless they are looking for a
specific failure message.

It is just explodes in a way we know what happened, in the case the
categorycode is invalid.

To test:
- Apply the Unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> FAIL: Tests fail because AddReturn doesn't raise an exception
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: dom <dominic.pichette at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:25:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:25:25 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-c5vsPDd8Nj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:36:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:36:10 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-bLNcG6qCLD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70023|0                           |1
        is obsolete|                            |

--- Comment #4 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 70139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70139&action=edit
Bug 19851: Improve responsive layout handling of staff client menu bar

This patch modifies CSS and markup in the staff client header to
override the default responsive style of the menu bar. The changed
layout will keep the menu bar items in a horizontal line at lower screen
widths.

To test, apply the patch and clear your browser cache if necessary.

 - Log in to the staff client and confirm that the appearance of the
   menu bar at the top of the screen looks correct at various browser
   widths.
 - Confirm that the logged-in user menu label and help link expand and
   collapse according to browser width.

Signed-off-by: dom <dominic.pichette at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:36:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:36:43 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-SNRsyT3B6k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:39:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:39:17 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-9T0XPF8mxe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70032|0                           |1
        is obsolete|                            |

--- Comment #2 from Dominic Pichette <dominic.pichette at inlibro.com> ---
Created attachment 70140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70140&action=edit
Bug 19860: Make staff client home page responsive

This patch rewrites the markup of the staff client home page to use the
Bootstrap grid instead of the YUI grid, taking advantage of Bootstrap's
built-in responsiveness.

This patch does not affect the logo and search form in the header. It
will be necessary to address search forms in another patch.

To test, apply the patch and clear your browser cache if necessary. For
better results, apply the patch for Bug 19851 as well.

- View the staff client home page and test the layout at various browser
  widths.
- Test with and without news items
- Test with and without content in IntranetmainUserblock

Signed-off-by: dom <dominic.pichette at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 22 22:40:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Dec 2017 21:40:11 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-rxpw8pUfL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Dominic Pichette <dominic.pichette at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dominic.pichette at inlibro.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:31:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:31:02 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-mhqxpNRtLW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70142&action=edit
Bug 19608: (QA follow-up) Fix redirect on localization modal

This patch makes two minor corrections:

1. The item types localization modal redirect problem has been fixed by
   excluding the anti-clickjack code from executing in the footer.
2. The sidebar menu highlighting script has been modified to correctly
   handle the clone-rules page.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:31:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:31:08 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-9mKPahKiCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70143&action=edit
Bug 19608: (QA follow-up) Fix menu item styling for clone-rules

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:30:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:30:56 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-Zo0qUexy6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69308|0                           |1
        is obsolete|                            |
  Attachment #69802|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70141&action=edit
Bug 19608: Move admin templates JavaScript to the footer: The rest

This patch modifies the staff client administration templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

To test the changes to localization.tt you must have more than one
translation installed. Go to admin/itemtypes.pl, edit an itemtype, and
click the 'Translate into other languages' link.

To test the changes to sur_modmapping.tt, go to admin/z3950servers.pl
and create a new SRU server. Click the 'Modify' button next to 'SRU
Search fields mapping'

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:34:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:34:34 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-d64YZVKfS6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:53:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:53:30 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-2W3DbTVYSp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70145&action=edit
Bug 19623: (Follow-up) Correct footer include in pop-up windows

This patch corrects the footer include in two templates for Z39.50
pop-up windows. popup-bottom.inc shouldn't be used because it doesn't
have the JavaScript embed code in it.

To test, perform a Z39.50 search from both the MARC bibliographic editor
and the MARC authority editor. In both cases the Z39.50 popup window
should work correctly.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:53:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:53:36 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-2erSh3Fn0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70146&action=edit
Bug 19623: (QA follow-up) Add missing footerjs variable in merge.tt

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:53:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:53:23 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-WOrtNciWax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69163|0                           |1
        is obsolete|                            |
  Attachment #70118|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70144&action=edit
Bug 19623 - Move template JavaScript to the footer: Cataloging

This patch modifies some staff client cataloging templates so that
JavaScript is included in the footer instead of the header.

Several cataloging templates are excluded because they require
significant structural changes: addbiblio.tt, additem.tt, and editor.tt

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Note that z350_auth_search.tt is tested by performing a Z39.50 search
from the Authorities module.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:54:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:54:06 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-g41ckjDm1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 08:56:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 07:56:39 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-8eGHUW2R6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Dominic, I notice your sign-off line is:
Signed-off-by: dom <dominic.pichette at inlibro.com>

Do you want to fix it to have your full name? We pull from the messages when
generating the release notes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:01:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:01:04 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-U3GY0JjwUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70010|0                           |1
        is obsolete|                            |
  Attachment #70138|0                           |1
        is obsolete|                            |

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70147&action=edit
Bug 19841: Unit tests

This patch introduces unit tests for the new behaviour of AddMember
(raising an exception if the passed categorycode is not valid.

 To test:
 - Apply this patch
 - Run:
   $ kshell
  k$ prove t/db_dependent/Members.t
=> FAIL: It should fail because the feature is still not implemented.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:01:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:01:11 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-iJPqZCbw5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70148&action=edit
Bug 19841: Make AddMember raise an exception if categorycode is invalid

This patch makes C4::Members::AddMember raise a Koha::Exceptions::BadParameter
exception. The current behaviour is to just explode. Code calling
AddReturn should work as expected, unless they are looking for a
specific failure message.

It is just explodes in a way we know what happened, in the case the
categorycode is invalid.

To test:
- Apply the Unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> FAIL: Tests fail because AddReturn doesn't raise an exception
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: dom <dominic.pichette at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:01:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:01:53 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-sHn70ORjzR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:02:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:02:17 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-Wuae6pVmjz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:02:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:02:30 +0000
Subject: [Koha-bugs] [Bug 19641] Move patron templates JavaScript to the
	footer
In-Reply-To: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19641-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19641-70-JVZsgo4C9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:03:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:03:38 +0000
Subject: [Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related
	tools
In-Reply-To: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19682-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19682-70-jhSWz9A2uu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:08:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:08:17 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-ohoNFmjdUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70139|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70149&action=edit
Bug 19851: Improve responsive layout handling of staff client menu bar

This patch modifies CSS and markup in the staff client header to
override the default responsive style of the menu bar. The changed
layout will keep the menu bar items in a horizontal line at lower screen
widths.

To test, apply the patch and clear your browser cache if necessary.

 - Log in to the staff client and confirm that the appearance of the
   menu bar at the top of the screen looks correct at various browser
   widths.
 - Confirm that the logged-in user menu label and help link expand and
   collapse according to browser width.

Signed-off-by: dom <dominic.pichette at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:09:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:09:07 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-xjNDzgFT08@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
             Status|Signed Off                  |Passed QA

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Nice job Owen ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:17:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:17:00 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-iPC4pAklTL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi,

I like what this is trying to do, but at the moment it doesn't work and will
need more work in order to make it in.

1) This patch adds a new routine ModNotesOrder to the C4 namespace.
You should add it to the Koha namespace instead, for example:
Koha::Acq::Order->add_note. It also needs to be covered by unit tests.

2) You change the CSV header, but only add the 2 notes fields. Why not the
ISBN?

3) Entering/saving notes does currently not work for me at all. I think the
input fields in the table take up a lot of space and are not easy to handle. I
suggest taking a look at how adding messages in the patron account works
(button in the toolbar). The change should show immediately (Ajax) or the page
should reload automatically after entering a note (no need to F5).

4) Tiny: The order search uses 'order line' for 'Order no.' - I suggest to also
use order line here to make it consistent.

5) The late orders table can be configured using the column visibility
settings.  The new columns need to be added there as well so you can control
when and where they are visible.

6) Last is just an idea/question: If we are showing ISBN, should we show ISSN
too? Maybe a combined column?

1) and 5) are the biggest issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:20:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:20:04 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-IG115btfwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:20:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:20:10 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-evH4Ptq9xt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70140|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70150&action=edit
Bug 19860: Make staff client home page responsive

This patch rewrites the markup of the staff client home page to use the
Bootstrap grid instead of the YUI grid, taking advantage of Bootstrap's
built-in responsiveness.

This patch does not affect the logo and search form in the header. It
will be necessary to address search forms in another patch.

To test, apply the patch and clear your browser cache if necessary. For
better results, apply the patch for Bug 19851 as well.

- View the staff client home page and test the layout at various browser
  widths.
- Test with and without news items
- Test with and without content in IntranetmainUserblock

Signed-off-by: dom <dominic.pichette at inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 09:20:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 08:20:30 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-3nwkuFZGFt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 16:43:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 15:43:46 +0000
Subject: [Koha-bugs] [Bug 19879] New: awewa
Message-ID: <bug-19879-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19879

            Bug ID: 19879
           Summary: awewa
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Browser compatibility
          Assignee: oleonard at myacpl.org
          Reporter: singgihea at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 70151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70151&action=edit
awewae

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 20:51:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 19:51:46 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-qp5FKTFpRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 20:51:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 19:51:50 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-HKjoLdQ9VA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69734|0                           |1
        is obsolete|                            |

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70152&action=edit
Bug 19603: Move admin templates JavaScript to the footer: Patrons and
circulation

This patch modifies the staff client patrons and circulation-related
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de>

Edit: Rebased

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 20:51:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 19:51:57 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-aaYL59uT6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 70153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70153&action=edit
Bug 19603: (QA follow-up) Remove unused message

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 23 20:52:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Dec 2017 19:52:11 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-kTZspBA327@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Dec 25 16:05:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Dec 2017 15:05:36 +0000
Subject: [Koha-bugs] [Bug 19550] Add links to related authorities for UNIMARC
In-Reply-To: <bug-19550-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19550-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19550-70-N7KlKq0QMH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550

acovaliov at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acovaliov at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 02:55:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 01:55:59 +0000
Subject: [Koha-bugs] [Bug 19879] awewa
In-Reply-To: <bug-19879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19879-70-5AEROaHD4W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19879

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 02:56:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 01:56:18 +0000
Subject: [Koha-bugs] [Bug 19879] SPAM
In-Reply-To: <bug-19879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19879-70-0NkGitzKdD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19879

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
            Summary|awewa                       |SPAM

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 12:49:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 11:49:11 +0000
Subject: [Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt
In-Reply-To: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19338-70-4MlSu7z2qe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67801|0                           |1
        is obsolete|                            |

--- Comment #6 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70154&action=edit
Bug 19338 - Dates sorting incorrectly in opac-account.tt

To test:
Find an account with lots of fines/payments
load up the borrower's account in the OPAC
note that the sort on the dates sorts by day, and not by date.
apply this patch
reload the page, note that the sort on the dates is now correct.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 12:49:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 11:49:44 +0000
Subject: [Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt
In-Reply-To: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19338-70-OVevveMbOZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 15:01:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 14:01:39 +0000
Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result,
 subscribing via rss can be broken
In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19875-70-HBujTVg4IC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875

Christophe Croullebois <christophe.croullebois at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christophe.croullebois at bibl
                   |                            |ibre.com
           Assignee|oleonard at myacpl.org         |christophe.croullebois at bibl
                   |                            |ibre.com
             Status|NEW                         |Needs Signoff

--- Comment #2 from Christophe Croullebois <christophe.croullebois at biblibre.com> ---
Created attachment 70155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70155&action=edit
patch

thx to test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 15:03:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 14:03:05 +0000
Subject: [Koha-bugs] [Bug 19875] When & is in the title of a search result,
 subscribing via rss can be broken
In-Reply-To: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19875-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19875-70-PQuQMnL4hy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875

--- Comment #3 from Christophe Croullebois <christophe.croullebois at biblibre.com> ---
(In reply to Jonathan Druart from comment #1)
> Hi Christophe, do you plan to attach a patch?

Hi Jonathan, done, thx

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:34:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:34:54 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-E20N4XeKAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70120|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70156&action=edit
Bug 19826: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:37:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:37:58 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-k13wgozRdJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
If you are going to reuse these new modules, I expect that you will replace the
different subroutines using DBIC directly in C4::Budgets

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:43:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:43:44 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-Ixnx4hvrKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

--- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #27)
> If you are going to reuse these new modules, I expect that you will replace
> the different subroutines using DBIC directly in C4::Budgets

I will :-D. Matthias is the one using this on the funds endpoint, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:46:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:46:21 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-tHRTGKA5oI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Josef Moravec from comment #9)
> Signed-off-by: dom <dominic.pichette at inlibro.com>

Dominic, please fix you git alias!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:52:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:52:23 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-Rk8vVxLFET@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70156|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70157&action=edit
Bug 19826: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:53:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:53:28 +0000
Subject: [Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt
In-Reply-To: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19338-70-rAoHXJisWC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:53:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:53:34 +0000
Subject: [Koha-bugs] [Bug 19603] Move admin templates JavaScript to the
 footer: Patrons and circulation
In-Reply-To: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19603-70-PCGt7O6oE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:53:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:53:40 +0000
Subject: [Koha-bugs] [Bug 19608] Move admin templates JavaScript to the
	footer: The rest
In-Reply-To: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19608-70-WJORGvteE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:53:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:53:46 +0000
Subject: [Koha-bugs] [Bug 19623] Move template JavaScript to the footer:
	Cataloging
In-Reply-To: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19623-70-JwgNEHCe3z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19623

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:53:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:53:51 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-VLQlkAdsHN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:53:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:53:57 +0000
Subject: [Koha-bugs] [Bug 19841] AddMember should raise an exception if
 categorycode is invalid
In-Reply-To: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19841-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19841-70-YHjXBDawru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19841

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:54:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:54:03 +0000
Subject: [Koha-bugs] [Bug 19851] Improve responsive layout handling of staff
 client menu bar
In-Reply-To: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19851-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19851-70-N6dTL0UpFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 16:54:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 15:54:08 +0000
Subject: [Koha-bugs] [Bug 19860] Make staff client home page responsive
In-Reply-To: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19860-70-vvRID3NWJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19860

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 17:03:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 16:03:22 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-OoJvmXZJVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19826
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should we move this out of the queue until 19826 is ready and this can be
redone on top?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826
[Bug 19826] Introduce Koha::Acquisition::Budget(s) and
Koha::Acquisition::Fund(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 17:03:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 16:03:22 +0000
Subject: [Koha-bugs] [Bug 19826] Introduce Koha::Acquisition::Budget(s) and
 Koha::Acquisition:: Fund(s)
In-Reply-To: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19826-70-HGynNrZ4qD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19661


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661
[Bug 19661] Funds endpoint
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 18:31:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 17:31:34 +0000
Subject: [Koha-bugs] [Bug 19560] Unable to delete library when branchcode
 contains special characters
In-Reply-To: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19560-70-lO0JxWOlqv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Owen, you modified the original patch to use a POST (form) instead of a GET
(link), could you explain why?
It makes the button hard to locate from selenium tests and hide the url to the
user.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 18:43:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 17:43:35 +0000
Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module
In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19802-70-sqceng0EZm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70158&action=edit
Bug 19802: Add stack trace to ease debugging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 18:43:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 17:43:40 +0000
Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module
In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19802-70-SCOj4UZAfA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70159&action=edit
Bug 19802: [DO NOT PUSH] Generate screentshots

This needs to be improved, but let as it for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 18:45:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 17:45:51 +0000
Subject: [Koha-bugs] [Bug 19802] Move Selenium code to its own module
In-Reply-To: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19802-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19802-70-EspgfIXPdU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70159|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 19:51:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 18:51:02 +0000
Subject: [Koha-bugs] [Bug 19852] Add message text box in circulation for
 patrons does not accept HTML tags
In-Reply-To: <bug-19852-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19852-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19852-70-epiL6b2WF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19852

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:25:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:25:05 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-WCOVWf9jiV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70160&action=edit
Bug 19243: fix urls - do not use /cgi-bin/koha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:25:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:25:22 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-nsA3EoqfLb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70162&action=edit
Bug 19243: Temporary comment failing test - see bug 19560 comment 30

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:25:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:25:15 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-7Ggl9RC91J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70161&action=edit
Bug 19243: Fix for bug 19860

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:25:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:25:34 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-10nniU4PhH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70163&action=edit
Bug 19243: Fix tests for AV

The tricky part here was to find an alternative for ends-with in Xpath
version 1
Indeed there are 2  button with
"/admin/authorised_values.pl?op=add_form", and the first one was picked
(/admin/authorised_values.pl?op=add_form&category=Asort1)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:25:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:25:42 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-VJdxre6qUI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70164&action=edit
Bug 19243: Fix tests for patron categories

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:29:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:29:56 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-6ItbecOkil@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Alex Buckley from comment #23)
> Hi Jonathan

Hi Alex,

> I have just attached a patch which tests the creation of an authorised value
> and a patron category. 
> 
> The difficulties I faced with adding these were that a modal box is
> displayed when you delete authorised values. Trying to confirm the deletion
> with the modal box is problematic and I have not been able to find a
> solution for that yet. 
> 
There were some issues in your patch. You must keep in mind than the tests have
to pass on other installations and your tests must not modify the DB (so you
must cleanup).
Take a look at the last 2 patches, they fix the different problems.
To confirm a modal, you need to call $driver->accept_alert;

> Additionally in the creation of patron categories you must select a value
> from a dropdown box, I am still trying to find a solution for this. 

You just need to specify the id of the select and the value of the option you
want to select.

> I will be away from my computer for the next 3.5 weeks whilst travelling in
> Egypt and Jordan and will be able to return to this in mid Jan along with
> other Koha development work I am working on.

Enjoy your holidays then :)

I am going to open another bug report for the pages we do not test in these
patches and let this one moving on.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:30:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:30:09 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality - part 1
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-VOWKrp0cVV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Selenium test for testing   |Selenium test for testing
                   |the administration module   |the administration module
                   |functionality               |functionality - part 1
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:32:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:32:04 +0000
Subject: [Koha-bugs] [Bug 19880] New: Selenium test for testing the
 administration module functionality - part 2
Message-ID: <bug-19880-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19880

            Bug ID: 19880
           Summary: Selenium test for testing the administration module
                    functionality - part 2
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 19243

On bug 19243 we tested:
* Add item type
* Add library
* Add authorised values
* Add patron category

Here we need to improve:
* Add circulation rule
* Modify frameworks

And write the tests for:
* Add patron attribute type
* Add Z39.50 target server
* Add item circulation alert
* Add city


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243
[Bug 19243] Selenium test for testing the administration module functionality -
part 1
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 20:32:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 19:32:04 +0000
Subject: [Koha-bugs] [Bug 19243] Selenium test for testing the
 administration module functionality - part 1
In-Reply-To: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19243-70-LqkXWGk4FG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19880


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19880
[Bug 19880] Selenium test for testing the administration module functionality -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:36:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:36:46 +0000
Subject: [Koha-bugs] [Bug 11512] Forced holds that violate issuing rules
 will never be filled
In-Reply-To: <bug-11512-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11512-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11512-70-GprR0wSTEI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:44:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:44:51 +0000
Subject: [Koha-bugs] [Bug 19585] Inventory: Allow additional separators in a
	barcode file
In-Reply-To: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19585-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19585-70-LiIva72zZS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19585

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:45:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:45:13 +0000
Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific
	IP addresses
In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14407-70-O2ZI8j6vca@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:47:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:47:16 +0000
Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline
 circulation file, "  apply directly" option fails
In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16603-70-XfanBiAvQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:47:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:47:52 +0000
Subject: [Koha-bugs] [Bug 16603] When processing uploaded offline
 circulation file, "  apply directly" option fails
In-Reply-To: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16603-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16603-70-vJoBAtYd6h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16603

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:55:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:55:37 +0000
Subject: [Koha-bugs] [Bug 19743] Header and Footer should be updated on each
 item for checkin / checkout / renewal notices
In-Reply-To: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19743-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19743-70-cAbx9EPSiu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:56:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:56:09 +0000
Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and
	renewal limits
In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18450-70-cqylaDrrZD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:57:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:57:29 +0000
Subject: [Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements
In-Reply-To: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19584-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19584-70-FiunJVmLJx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:58:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:58:51 +0000
Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine
 charging interval'
In-Reply-To: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19804-70-DmOKNTES9k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Suspension calcultation     |Suspension calculation
                   |doesn't honour 'Fine        |doesn't honour 'Fine
                   |charging interval'          |charging interval'
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:58:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:58:35 +0000
Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket'
	without explanation
In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10032-70-XPXgWoRFr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jon, could you add a step-by-step test plan to this? Then this might make a
good 'Academy' bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Dec 26 23:59:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 22:59:21 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-9sk6sMqQSU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 00:00:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 23:00:54 +0000
Subject: [Koha-bugs] [Bug 19787] Adding system preferences to configure the
 screen messages for SIP checkout flags in Self-Checkout
In-Reply-To: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19787-70-rvBpQ9wK2d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Adding system preferences   |Adding system preferences
                   |to disable the screen       |to configure the screen
                   |messages for SIP flags in   |messages for SIP checkout
                   |Self-Checkout               |flags in Self-Checkout

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 00:01:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 23:01:05 +0000
Subject: [Koha-bugs] [Bug 19825] List of pending offline operations does not
 links to biblio
In-Reply-To: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19825-70-43lDwItonP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19825

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 00:01:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 23:01:19 +0000
Subject: [Koha-bugs] [Bug 19677] Angle brackets in enumchron do not display
 in opac or staff side
In-Reply-To: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19677-70-S0kHsczCq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19677

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 00:01:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Dec 2017 23:01:52 +0000
Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by barcode
In-Reply-To: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19837-70-gUBQPDquZM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 01:05:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 00:05:37 +0000
Subject: [Koha-bugs] [Bug 19661] Funds endpoint
In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19661-70-KqdxtaK3xZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 07:46:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 06:46:23 +0000
Subject: [Koha-bugs] [Bug 7425] Export Bibliographic Holdings fails if no
 item records attached
In-Reply-To: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7425-70-krZgEfEmab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #7 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
Um, so what is the solution? We need to export records that we are about to
delete, and by definition they won't have items attached, so this is a big
problem for us. 

Is the only current workaround to ensure all bibs have an item type in the 942?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 07:53:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 06:53:44 +0000
Subject: [Koha-bugs] [Bug 7425] Export Bibliographic Holdings fails if no
 item records attached
In-Reply-To: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7425-70-K5uiPijp2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

Maybe generating a list of biblionumbers with a report and using this as your
base for exporting could work for you? Make sure all branches are unchecked.
Using a biblionumber range with branches unchecked also seems to work for me. 

There have been fixes to the export tool since this bug was filed, maybe one of
it improved behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 07:56:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 06:56:13 +0000
Subject: [Koha-bugs] [Bug 13171] Check box for email is missing for hold
 notifications in patron messaging preferences.
In-Reply-To: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13171-70-T1i2NUMnMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Barton, can you reproduce the issue? HOLD can't be deleted from the GUI atm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 12:02:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 11:02:11 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-ab7GLpX1gk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 12:02:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 11:02:26 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-iE2nsSAWNx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69925|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 12:02:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 11:02:34 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-L8icCvoBJH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 70169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70169&action=edit
Bug 19798: Fix print transfer slip

... and maybe other bugs as well
What happens here is that $itemnumber is no longer set when barcode is
passed.

Test plan:
1. Check in available/not on hold item at a non owning library.
2. Click print slip
3. Item's info must be displayed on the slip

Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 12:41:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 11:41:05 +0000
Subject: [Koha-bugs] [Bug 15428] Different timeout preference for opac and
	intranet
In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15428-70-KLcwhhyDOZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428

BASE Library Consortium <baselibrary.consortium at nhs.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baselibrary.consortium at nhs.
                   |                            |net

--- Comment #2 from BASE Library Consortium <baselibrary.consortium at nhs.net> ---
Our libraries would also like this to be developed. Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 13:45:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 12:45:04 +0000
Subject: [Koha-bugs] [Bug 19882] New: Add Novelist Select staff client
	profile
Message-ID: <bug-19882-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882

            Bug ID: 19882
           Summary: Add Novelist Select staff client profile
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The novelist in the staff client doesn't form links correctly as the profile
refers to the OPAC. Novelist has suggested a separate profile for the staff
side would allow better styling and correct linking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:01:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:01:19 +0000
Subject: [Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests
In-Reply-To: <bug-19384-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19384-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19384-70-JNlWsiDDq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19883


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883
[Bug 19883] Add a selenium script to hit all the pages
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:01:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:01:19 +0000
Subject: [Koha-bugs] [Bug 19883] New: Add a selenium script to hit all the
	pages
Message-ID: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883

            Bug ID: 19883
           Summary: Add a selenium script to hit all the pages
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
            Blocks: 19384


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384
[Bug 19384] [OMNIBUS] Add Selenium tests
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:05:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:05:45 +0000
Subject: [Koha-bugs] [Bug 19883] Add a selenium script to hit all the pages
In-Reply-To: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19883-70-rKoHnNEY5N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 70170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70170&action=edit
Bug 19883: Add a selenium script to hit all the pages

The idea here would be to catch possible hidden issues, and especially
when the requested data do not exist (for instance hit
circulation.pl?borrowernumber=42 without borrowernumber=42 in your DB).
All these pages must not return 500.

This is not ready at all for inclusion for several reasons:
- Based on existing data (id=1 most of the time)
- DB will be modified
- Not idempotent
- All pages are not covered (TODO)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:08:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:08:50 +0000
Subject: [Koha-bugs] [Bug 19883] Add a selenium script to hit all the pages
In-Reply-To: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19883-70-0GCdieGTgb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl,
                   |                            |tomascohen at gmail.com
             Status|ASSIGNED                    |In Discussion

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Even if not included it could be useful for QA or RM
Marcel and Tomas, what do you think?
It could be a nice goal to see all these scripts handling non-existing data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:22:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:22:37 +0000
Subject: [Koha-bugs] [Bug 19882] Add Novelist Select staff client profile
In-Reply-To: <bug-19882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19882-70-cdWMMELW57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11606
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606
[Bug 11606] Novelist Select in Staff Client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:22:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:22:37 +0000
Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client
In-Reply-To: <bug-11606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11606-70-K6SX4Qq7zc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19882


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882
[Bug 19882] Add Novelist Select staff client profile
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:22:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:22:39 +0000
Subject: [Koha-bugs] [Bug 19882] Add Novelist Select staff client profile
In-Reply-To: <bug-19882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19882-70-8MDdHEvOjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19882

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70171&action=edit
Bug 19882 - Add Novelist Select staff client profile

This patchset allows for use of a separate Novelist profile for the
staff client and opac. This allows Novelist to determine links and
special styling for each. Testing is best with novelist credentials,
however, confirming that values are set and used correctly and nothing
is broken should suffice.

To test:
1 - Apply patches
2 - Update database
3 - View detail pages for some records on opac and staff client and ensure no
changes have been
made
4 - Enable NovelistSelectStaffEnabled (and enter or have info in the Profile
and password)
5 - Set NovelistSelectStaffView to 'above'
6 - View detail pages for some records, verify that if novelist info is
available it is displayed and nothing is displayed if not
7 - Repeat with all staff view options

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:34:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:34:51 +0000
Subject: [Koha-bugs] [Bug 19883] Add a selenium script to hit all the pages
In-Reply-To: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19883-70-JvSyzUKTef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Nice goal on itself. Protecting the database is obviously needed.
Do several scripts need basic parameters at the beginning already (not only
what is filled on a form)? So the script needs to know these; could be a
maintenance headache?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 14:39:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 13:39:44 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-2ZYW3HZGSb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |nick at bywatersolutions.com

--- Comment #178 from Nick Clemens <nick at bywatersolutions.com> ---
Can you rebase please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 15:47:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 14:47:12 +0000
Subject: [Koha-bugs] [Bug 19884] New: Improve performance of GetItem
Message-ID: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

            Bug ID: 19884
           Summary: Improve performance of GetItem
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com
        QA Contact: testopia at bugs.koha-community.org

While benchmarking Koha trying to improve indexing speed
DBIx::Class::ResultSet->find() in C4::Koha::Getitem stood out as a major
bottleneck. I looked through the code, and it's only when 'item-level_itypes'
is enabled when the actual item object is needed, if not the function can be
optimized by only fetching the the data through the much faster low-level DBI
interface. This is of course a bit of a kludge, and I would normally avoid this
type of micro-optimization, but with this fix we managed to shave a couple of
hours of a full re-indexing, and get it done during closing hours. I have also
added some more tests to try to catch any possible future issues this change
might cause. If more stuff needs to be fetched through the Item-object there
could be issues, but this should be clearly pointed out in the code. I also
removed an extra call to GetItem() in GetMarcItem() by making it accept an item
object or item id as argument, and only fetch the item if needed, cutting the
actual calls to GetItem by about half.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 16:13:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 15:13:54 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-v1EzdtqWMi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70172&action=edit
Bug 19884 - Improve performance of GetItem

Provide optimized search_unblessed method for Koha::Items to increase
performance of GetItem. Also extend GetMarcItem() to also accept an item
record as second parameter. This way an extra call to GetItem() can be
avoided by passing an item record directly instead of an item number.

Also add new function GetItems() making it possible to load multiple
items at once, which is more efficient than loading them one by one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 16:15:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 15:15:18 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-ftfOruZFEa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 16:22:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 15:22:52 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-P55nzI7JEz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
Forgot to add an how to test. Will fix this, will also provide a test script to
illustrate performance difference, might not have time to do so today, but
latest tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 16:29:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 15:29:24 +0000
Subject: [Koha-bugs] [Bug 6685] circ rules by groups of items
In-Reply-To: <bug-6685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6685-70-wRdJZdQP6I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 16:34:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 15:34:12 +0000
Subject: [Koha-bugs] [Bug 19885] New: Allow MaxOpenSuggestions to be set by
	patron type
Message-ID: <bug-19885-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19885

            Bug ID: 19885
           Summary: Allow MaxOpenSuggestions to be set by patron type
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lisetteslatah at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be nice if we could set MaxOpenSuggestions by patron type/library.
This would allow each library in a consortium to use the suggestions in the way
that was most efficient for each library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 16:47:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 15:47:11 +0000
Subject: [Koha-bugs] [Bug 18593] Suggestions aren' t updated when one biblio
 is merged with another
In-Reply-To: <bug-18593-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18593-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18593-70-z6uf2FoDxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18593

Lisette <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 16:59:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 15:59:04 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-BuLthwlFU2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
And a correction: "it's only when 'item-level_itypes' is enabled when the
actual item object is needed" in the first comment should be the other way
around: "it's only when 'item-level_itypes' is _disabled_ the actual item
object is needed"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:08:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:08:27 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-eGOgLsqPKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70073|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:08:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:08:30 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-8ZuZ3MJlIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70074|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:08:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:08:33 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-1K6JXNqMrx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70075|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:08:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:08:51 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-OXKS7RUll8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70173&action=edit
Bug 15492: Add the SelfCheckInModule syspref

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:08:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:08:56 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-XYaVIfc12J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70174&action=edit
Bug 15492: Add SCI module

This patch adds the SCI module, and adapts C4::Auth to know about it.

The current behaviour is:
- Requires admin user initialization/login
- Uses the logged users' library
- A form allows to scan multiple barcodes
- A button sends the barcode list to the controller
  to batch perform the checkins
- Successful and failed checkins are sent to the template
- Results are displayed
- Logout link

To test:
- Apply this patches
- Make sure you upgrade:
  $ kshell
 k$ perl installer/data/mysql/updatedatabase.pl
- Have 'SelfCheckInModule' disabled
- Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1]
=> SUCCESS: You are rejected because the feature is disabled
- Enable 'SelfCheckInModule'
- Go to the previous URL
=> SUCCESS: You are required to login
- Login with a user WITHOUT self_checkout permissions
=> SUCCESS: You are not allowed to log into the Self check-in module.
- Login with a user WITH self_checkour permissions
=> SUCCESS: You gain access, and are presented the UI
- Go through the several options
=> SUCCESS: All works as it should
- Click the 'Help' link
=> SUCCESS: A help text is displayed on a modal
- Sign off :-D

- Bonus points:
  $ kshell
 k$ qa -c 2 -v 2
=> SUCCESS: All tests green

[1] Adjust to your dev's OPAC setup

Signed-off-by: David Bourgault <david.bourgault at inlibro.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:09:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:09:00 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-8V4kfS5WBY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70175&action=edit
Bug 15492: (QA follow-up) Reset SCI if idle for 30 seconds

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:09:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:09:04 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-Bbotv3BMr7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70176&action=edit
Bug 15492: New sysprefs and permissions

In order to make this module unrelated to the SCO module, this
patch introduces the following sysprefs:

- SelfCheckInMainUserBlock
- SelfCheckInModuleUserID
- SelfCheckInTimeout
- SelfCheckInUserCSS
- SelfCheckInUserJS

It also adds a new user flag and sub-permission:

- self_check => self_checkin_module

and moves the circulate => self_checkout permission into

- self_check => self_checkout_module

Descriptions are adjusted accordingly.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:09:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:09:08 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-Ktyj5gFYxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70177&action=edit
Bug 15492: Make existing code aware of new self_check* permissions

This patch makes the existing code for SCO use the new permissions schema
for self check modules. Specifically addresses this change:

  circulate  => self_checkout
becomes
  slef_check => self_checkout_module

about.pl checks are dejusted too.

get_template_and_user gets refactored to avoid code duplication and the
conditions are adjusted for the new permissions.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:09:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:09:12 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-MUjvIbVQr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70178&action=edit
Bug 15492: Make SCI use its own sysprefs and CSS file

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:09:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:09:15 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-381WHmsjCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 70179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70179&action=edit
Bug 15492: Display nicer message on data corruption

This patch hides scary messages and changes the wording for a more
idiomatic approach. Thanks to Nick :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:09:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:09:35 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-0FV0pbBiYN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:13:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:13:08 +0000
Subject: [Koha-bugs] [Bug 11606] Novelist Select in Staff Client
In-Reply-To: <bug-11606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11606-70-vSwe8mAVcl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|gwilliams at nekls.org         |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:16:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:16:08 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-c5P1NrXkX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #14)
> All works great, few concerns:
> 1. Code in C4::Auth must be simplify and merged with existing one (you c/p
> 25  lines)

Done.

> 2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we
> should apply the same behaviour as self-checkout (no?)

The behaviour for SCI is different. Users with SCI permission can only access
SCI in the OPAC. This should be carefully documented in the manual (it is
explicitly mentioned in the permissions page).

> 3. Description (and name) of the permission self_checkout must be adapted

Done. I've moved self check-related sysprefs like this:

- selc_check
  * self_checkin_module
  * self_checkout_module

Existing code has been adjusted. This needs to be tested just in case, that's
why I moved it back to NSO (it is a trivial change, though).

> 4. I do not know how SCOMainUserBlock is used, but it may be wrong to
> display it for SCI (?)

I did what I planned for a followup bug: making SCI have its own set of
sysprefs. I was going to do it anyway, but cleaner on the same patchset. Good
catch.

> 5. "Data corruption detected" => Are we sure we want to display that at the
> OPAC?
> 6. If error code is not known, we should display it instead of ignore it
> (BLOCK error_message)

Both addessed with Nick's idiomatic aid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 17:23:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 16:23:40 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-setyoTDqbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #14)
> All works great, few concerns:
> 2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we
> should apply the same behaviour as self-checkout (no?)

FTR, self check users should be 'marked' by a flag somewhere (hardcoded
category types, a flag in the patron category, on the borrowers table, etc)
instead of doing complex tricks. This way we would just do

 if ( $patron->is_self_check_user ) {
     # handle it
 }

instead. Just my 2 cents.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 20:45:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 19:45:11 +0000
Subject: [Koha-bugs] [Bug 19525] Bulk-add patrons to a list
In-Reply-To: <bug-19525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19525-70-JSs40k7eJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19525

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Currently you can only search for patrons individually, it would be nice to be
able to add a list of barcodes/cardnumbers from a report etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 21:01:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 20:01:49 +0000
Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket'
	without explanation
In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10032-70-5aVZV1MOYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032

--- Comment #4 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
OK, how about this for a test plan:

1) Before applying the patch, go to staff UI, and select Acquisitions, pick one
of your existing vendors (or create a new one) and then open a new basket (call
it anything you want).

2) Add a new (empty) record order to the basket.

3) Give the new record a made up title, add a single item (no need to fill in
any details), set a price of 10.00 and check the "Uncertain price" checkbox
before saving the record.

4) Confirm that the resulting summary page has a button bar that does NOT
include any button for closing the basket.

5) Modify the record and remove the check mark from the "Uncertain price"
checkbox before saving.

6) Confirm that the resulting basket summary page button bar now does have a
"Close this basket" button (as the basket no longer has uncertain prices).

7) Apply the patch.

8) Modify the record again to check the "Uncertain price" checkbox again, then
save it.

9) Confirm that the resulting summary page has a button bar that does include a
"Close this basket" button but that this button is greyed out and inoperative.

10) Modify the record again to remove the check mark in the "Uncertain price"
checkbox, then save the record.

11) Confirm that the resulting summary page has a button bar that does include
a "Close this basket" button which is now active (as the order no longer has an
uncertain price).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 21:19:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 20:19:44 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-P8373h8OKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 21:19:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 20:19:47 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-CQn4aHjGVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69782|0                           |1
        is obsolete|                            |

--- Comment #2 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 70180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70180&action=edit
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase

This patch
- fixes callnum and sn
- Removes unecessary syspref transmission to the template.
  As the template directly reads the syspref

Test plan:
1. Set sysprefs IntranetCatalogSearchPulldown and
   IntranetNumbersPreferPhrase to true
2. Go to staff:/cgi-bin/koha/catalogue/search.pl
3. "search for" ? "call number" and write anything that won't match a
   call number in the field
4. Then you should see
   ?No results match your search for 'callnum,phr: [...]?
5. Go to the staff homepage
6. Click on "Search the catalog"
7. Do the same search as previouly
8. Then you should see
   ?No results match your search for 'callnum,wrdl: [...]?
   This shows that IntranetNumbersPreferPhrase isn't honored
9. Apply this patch
10. Redo the same two searches and see that phr will now be always used.
    So IntranetNumbersPreferPhrase is honored

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 21:31:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 20:31:34 +0000
Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket'
	without explanation
In-Reply-To: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10032-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10032-70-VzVnymQQjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Jon!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:14:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:14:22 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-DGvd5QqiuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70169|0                           |1
        is obsolete|                            |

--- Comment #6 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Created attachment 70181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70181&action=edit
Bug 19798: Fix print transfer slip

... and maybe other bugs as well
What happens here is that $itemnumber is no longer set when barcode is
passed.

Test plan:
1. Check in available/not on hold item at a non owning library.
2. Click print slip
3. Item's info must be displayed on the slip

Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:15:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:15:13 +0000
Subject: [Koha-bugs] [Bug 7425] Export Bibliographic Holdings fails if no
 item records attached
In-Reply-To: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7425-70-a6SpqqHQcx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425

--- Comment #9 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
Thanks Katrin! This is the key:

"Make sure all branches are unchecked."

Perfectly logical, but I hadn't thought to try it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:16:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:16:55 +0000
Subject: [Koha-bugs] [Bug 7425] Export Bibliographic Holdings fails if no
 item records attached
In-Reply-To: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7425-70-IG5AklBysU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7425

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Glad I could help!

Closing, please reopen if still needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:54:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:54:24 +0000
Subject: [Koha-bugs] [Bug 15492] Stand alone self check-in tool
In-Reply-To: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15492-70-xC2ywPOIFm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Setting as signed-off so another QA round takes place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:54:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:54:42 +0000
Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber
In-Reply-To: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19837-70-4Gk8M0HieJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add multiple patrons to a   |Add multiple patrons to a
                   |list by barcode             |list by cardnumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:54:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:54:47 +0000
Subject: [Koha-bugs] [Bug 16330] REST API: add routes to add,
	update and delete patrons
In-Reply-To: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16330-70-LzEIw0WsDm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:55:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:55:27 +0000
Subject: [Koha-bugs] [Bug 19837] Add multiple patrons to a list by cardnumber
In-Reply-To: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19837-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19837-70-XRzrX9xlHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19837

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19525 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:55:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:55:33 +0000
Subject: [Koha-bugs] [Bug 19871] Use new exceptions
 Koha::Exceptions::Object:: DuplicateID and FKConstraint
In-Reply-To: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19871-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19871-70-x5pGvw5h9v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19871

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 22:55:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 21:55:27 +0000
Subject: [Koha-bugs] [Bug 19525] Bulk-add patrons to a list
In-Reply-To: <bug-19525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19525-70-8IN99Ksuvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19525

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this is a possible duplicate to bug 19837 :)

*** This bug has been marked as a duplicate of bug 19837 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 23:32:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 22:32:08 +0000
Subject: [Koha-bugs] [Bug 19886] New: Two Factor Authentication: Yubikey
Message-ID: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886

            Bug ID: 19886
           Summary: Two Factor Authentication: Yubikey
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: black23 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

We need to add support for  Two Factor Authentication, because password isn't
enough against hackers or unathorised acess.

Yubikey is USB hardware
    FIDO U2F
    Secure Static Passwords
    smart card (PIV)
    Yubico OTP
    Code Signing
    OpenPGP
    OATH-TOTP
    OATH-HOTP
    Challenge-Response

https://www.yubico.com/product/yubikey-4-series/

Yubikey Perl support
https://developers.yubico.com/yubico-perl-client/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 23:32:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 22:32:28 +0000
Subject: [Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey
In-Reply-To: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19886-70-GvJXhXFN5M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 23:37:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 22:37:36 +0000
Subject: [Koha-bugs] [Bug 19887] New: Two Factor Authentication: Google
	Authenticator
Message-ID: <bug-19887-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19887

            Bug ID: 19887
           Summary: Two Factor Authentication: Google Authenticator
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: black23 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Easy two-factor solution for users with smartphones.

Google Authenticator and Perl:
https://blog.darkpan.com/article/6/Perl-and-Google-Authenticator.html
https://debian-administration.org/article/729/Implementing_two_factor_authentication_with_perl
https://github.com/j256/perl-two-factor-auth

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 23:37:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 22:37:52 +0000
Subject: [Koha-bugs] [Bug 19887] Two Factor Authentication: Google
	Authenticator
In-Reply-To: <bug-19887-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19887-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19887-70-h5kVBwiQ6O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19887

Mike <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com,
                   |                            |rbit at rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 23:43:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 22:43:23 +0000
Subject: [Koha-bugs] [Bug 13613] Don' t allow digest to be selected without
 a digest-able transport selected
In-Reply-To: <bug-13613-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13613-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13613-70-92pCTczltZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Dec 27 23:51:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Dec 2017 22:51:33 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-Aa8AifQfjN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |tomascohen at gmail.com

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just noting: item-level_itypes ON is used in most libraries as it's a common
use case to have multiple items on a record with different item types. (See:
https://hea.koha-community.org/systempreferences to get an idea of use of
systempreferences)

I am not sure use of SQL in Koha::Items is ok - CC'ing some QA team members and
RM.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 07:52:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 06:52:18 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-kfAbqRb78g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, I still have the problem with the modal not closing. I have used
'restart_all' and shift-reloaded the page a couple of times. Could you take
another look please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:05:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:05:42 +0000
Subject: [Koha-bugs] [Bug 19594] Move admin templates JavaScript to the
 footer: MARC-related
In-Reply-To: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19594-70-oXhI7ZrN1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952
[Bug 13952] Import and export of authority types
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:05:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:05:42 +0000
Subject: [Koha-bugs] [Bug 13952] Import and export of authority types
In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13952-70-PfJsDSjrFV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19594

--- Comment #62 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are a few JavaScript errors on the page, I think the patches need to be
adjusted for the changes made moving the JavaScript to the bottom recently:

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=7c5c516844625592ed68ca91be5a76852b4bfdb6


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:09:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:09:08 +0000
Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of
	location on checkin
In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14576-70-duiagyYzHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
         Depends on|                            |19726

--- Comment #74 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, can you please rebase? JavaScript on the preferences template has
since be moved to the bottom. Thx!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726
[Bug 19726] Move admin templates JavaScript to the footer: Preferences
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:09:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:09:08 +0000
Subject: [Koha-bugs] [Bug 19726] Move admin templates JavaScript to the
 footer: Preferences
In-Reply-To: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19726-70-BUPi9p8yxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19726

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14576


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
[Bug 14576] Allow arbitrary automatic update of location on checkin
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:11:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:11:16 +0000
Subject: [Koha-bugs] [Bug 15486] Restrict number of holds placed by day
In-Reply-To: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15486-70-agYbi2dp9m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Tomas, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15486: DB structure change
Applying: Bug 15486: DBIC update
Applying: Bug 15486: Make circ rules UI handle holds_per_day
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 15486: Make circ rules UI handle holds_per_day
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15486-Make-circ-rules-UI-handle-holdsperday-_6c76R.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:15:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:15:38 +0000
Subject: [Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt
In-Reply-To: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19818-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19818-70-RaD8vvWW3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi, you can still change the labels, but it's not as easy. Try using
:contains('...') on the page with the text of the label. But using ids would
make this easier - marking this patch for Academy.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:20:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:20:45 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-UMnqkhyYUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Same for me, I have applied the dependencies 16330 and 19686 (both apply
cleanly) - but this one gives me a lot of trouble.

I feel like we should wait for this patch to QA the dependencies - probably
needs an update now too with the discussion at the last meeting / RFC on the
wiki?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16330: Add routes to add, update and delete patrons
Using index info to reconstruct a base tree...
M       Koha/Exceptions.pm
M       Koha/Patron.pm
A       Koha/REST/V1/Patron.pm
M       api/v1/swagger/definitions/patron.json
M       api/v1/swagger/paths/patrons.json
M       t/db_dependent/Koha/Patrons.t
M       t/db_dependent/api/v1/patrons.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/api/v1/patrons.t
CONFLICT (content): Merge conflict in t/db_dependent/api/v1/patrons.t
Auto-merging t/db_dependent/Koha/Patrons.t
CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patrons.t
Auto-merging api/v1/swagger/paths/patrons.json
CONFLICT (content): Merge conflict in api/v1/swagger/paths/patrons.json
Auto-merging Koha/SMS/Provider.pm
CONFLICT (content): Merge conflict in Koha/SMS/Provider.pm
Auto-merging Koha/Patron.pm
CONFLICT (content): Merge conflict in Koha/Patron.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 16330: Add routes to add, update and delete patrons
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-16330-Add-routes-to-add-update-and-delete-patr-hbLRSU.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 08:22:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 07:22:39 +0000
Subject: [Koha-bugs] [Bug 18791] Add the ability for librarians to easily
 copy, download or print DataTables based tables in Koha
In-Reply-To: <bug-18791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18791-70-qSpjYUaf3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking failed QA for my comments #2 and #4 - Kyle, can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 11:12:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 10:12:08 +0000
Subject: [Koha-bugs] [Bug 19784] Adapt /v1/patrons to new naming guidelines
In-Reply-To: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19784-70-OBWsJDy47T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19784

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED

--- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
16330 got big changes. This is not supposed to apply nor up to date with the
voted RFC. I'll fix it today.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 11:28:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 10:28:42 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-lGduMRT9xs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #54 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Fridolin SOMERS from comment #51)
> > 
> > The "Any" index/register should contains all the data contained in all the
> > other indexes/registers (e.g. Title, Author, Subject, etc). 
> > 
> > The "Anywhere" index/register should contain the entire record including
> > fields/subfields that aren't indexed anywhere else. 
> > 
> 
> This is what I want to do so I changed the bug description.

Which index will be used for the default/simple search from the OPAC front
page? 

One of my least favourite "features" of search in Koha is that the
default/simple search includes "Place of publication" (MARC21: 260$a). If you
have a Norwegian catalogue, a lot of the books in it will have Oslo as Place of
publication. This means that if you do a simple search for "oslo", because you
want to find books about Oslo, you will get *a lot* of noise, because you not
only find the books about Oslo, but also all the books published in Oslo. 

Any chance of fixing this as part of this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 13:43:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 12:43:58 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-EIa9Qx79OV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #5 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70182&action=edit
GetMarcBiblio master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 13:44:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 12:44:44 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-W4BjSJwNb3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #6 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70183&action=edit
GetMarcBiblio with patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 14:00:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 13:00:03 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-AWv8JQ1y1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #7 from David Gustafsson <glasklas at gmail.com> ---
I added two profiling results obtained by running this script
https://gist.github.com/gnucifer/a86feeac08dac9bc1bb699f52b95f8b2 with and
without the patch to illustrate the difference. As can be seen by the
flamegraph Koha::Objects::find takes up half of the total time, and with the
patch applied this overhead is gone.

This shows the performance difference of just calling GetItem:
https://gist.github.com/gnucifer/113b033d211add58fe7e6ebfc257726a

Without patch the calls to GetItem takes about 100s to execute on my machine.
With patch applied 3.26s, so about 31 times faster.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 14:21:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 13:21:07 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-P5bq3hxinx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70172|0                           |1
        is obsolete|                            |

--- Comment #8 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70184&action=edit
Bug 19884 - Improve performance of GetItem

Provide optimized search_unblessed method for Koha::Items to increase
performance of GetItem. Also extend GetMarcItem() to also accept an item
record as second parameter. This way an extra call to GetItem() can be
avoided by passing an item record directly instead of an item number.

Also add new function GetItems() making it possible to load multiple
items at once, which is more efficient than loading them one by one.

How to test:
1) Run tests in t/db_dependent/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 14:25:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 13:25:49 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-jKcUSkZxbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70184|0                           |1
        is obsolete|                            |

--- Comment #9 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70185&action=edit
Bug 19884 - Improve performance of GetItem

Provide optimized search_unblessed method for Koha::Items to increase
performance of GetItem. Also extend GetMarcItem() to also accept an item
record as second parameter. This way an extra call to GetItem() can be
avoided by passing an item record directly instead of an item number.

Also add new function GetItems() making it possible to load multiple
items at once, which is more efficient than loading them one by one.

How to test:
1) Run tests in t/db_dependent/Items.t

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 15:04:16 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 14:04:16 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-IkvVywLmGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David, did you see my last comment? 

I think using SQL instead of Koha::Object in a module in the Koha namespace is
not valid. - So maybe wait before putting more work into this until we can give
you some more feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 15:19:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 14:19:14 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-kqKHQVL7Tp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #11 from David Gustafsson <glasklas at gmail.com> ---
Hi! Yes I read the comment. As I wrote in the first comment I usually frown
upon this kind of optimization myself, but since the speedup is so substantial,
and we (at our library) really need to get indexing done during the night, this
patch is a requirement for our needs. The search_unblessed code is placed in
the Koha::Items for clarity, since it approximates the behaviour of
Koha::Items::search. DBIx also uses DBI internally, so in my opinion this
communicates the purpose of this optimization in more obvious way than if the
SQL would reside in GetItems for example. Also, one might want to use this
method in other places where item objects are fetched (through ->search for
example) and unblessed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 15:33:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 14:33:28 +0000
Subject: [Koha-bugs] [Bug 19534] Adding collection code attribute to cover
	image div
In-Reply-To: <bug-19534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19534-70-7V7NqcDZK7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19534

--- Comment #1 from Michael Cabus <michael at bywatersolutions.com> ---
Created attachment 70186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70186&action=edit
Bug [19534] - [Adding collection code attribute to cover image div] Adds
collection code value to cover image class, so specific collection code icons
can be assigned to search results

Test plan

1.) Do a search on OPAC
2.) Inspect element to confirm collection code is not present
3.) Apply patch
4.) Do a search on OPAC to confirm collection code is present as a class

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 15:35:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 14:35:30 +0000
Subject: [Koha-bugs] [Bug 19888] New: "Overdue Notices" email sent to
 KohaAdminEmailAddress is useless
Message-ID: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888

            Bug ID: 19888
           Summary: "Overdue Notices" email sent to KohaAdminEmailAddress
                    is useless
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

If a patron does not have any email address, a print notification is generated
instead of an email, so sending notification to Koha Admin is useless and
should be removed.

At least it should be possible to choose if we want it or not with a script
parameter

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 15:42:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 14:42:30 +0000
Subject: [Koha-bugs] [Bug 13854] XSLT result list doesn't show 'on order'
 when itemtype is not for loan
In-Reply-To: <bug-13854-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13854-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13854-70-8vLEQgK1dd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this requires a change, maybe resorting of conditions, in the XSLT file
f?r the result list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 16:03:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 15:03:10 +0000
Subject: [Koha-bugs] [Bug 17786] Date filter on circulation statistics not
 working correctly
In-Reply-To: <bug-17786-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17786-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17786-70-FYxDfxWVbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17786

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 16:31:02 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 15:31:02 +0000
Subject: [Koha-bugs] [Bug 13812] Facet links broken because double-quotes
 are not URL encoded
In-Reply-To: <bug-13812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13812-70-KR9SK1gq72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Facet links broken because  |Facet links broken because
                   |double-quotes are not URL   |double-quotes are not URL
                   |encoded.                    |encoded

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 16:36:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 15:36:54 +0000
Subject: [Koha-bugs] [Bug 18885] Onsite Checkout has a weird behaviour
 concerning sticky due date
In-Reply-To: <bug-18885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18885-70-p1X3kB2UU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m
           Assignee|baptiste.wojtkowski at biblibr |fridolin.somers at biblibre.co
                   |e.com                       |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 16:44:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 15:44:37 +0000
Subject: [Koha-bugs] [Bug 18065] Initials are not generated correctly by
 LDAP when firstname or surname start with umlauts
In-Reply-To: <bug-18065-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18065-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18065-70-jw6Y3eSTQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18065

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org
          Component|Patrons                     |Authentication

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:29:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:29:06 +0000
Subject: [Koha-bugs] [Bug 15461] Add staff equivalent to
 OpacLocationBranchToDisplayShelving
In-Reply-To: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15461-70-CFdnhMlzuA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could also be solved with colvis column configuration maybe.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:38:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:38:11 +0000
Subject: [Koha-bugs] [Bug 16722] Display internal note for late orders
In-Reply-To: <bug-16722-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16722-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16722-70-b5bVLPK2zS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16722

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 12502 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:38:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:38:11 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-K6k6U94WXC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16722 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:40:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:40:32 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-4s8PSTyQgK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:40:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:40:35 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-Lw260eF1YU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64061|0                           |1
        is obsolete|                            |
  Attachment #64065|0                           |1
        is obsolete|                            |

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70187&action=edit
Bug 18736 - Add OrerPriceRounding syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:40:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:40:39 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-V7NVUfa6fq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70188&action=edit
Bug 18736 - Use rounding syspref to determine correct prices in calculations

To test:
Place an order (no tax just for simplicity)
 listprice/rrp = 16.99
 discount = 42%
 quantity = 8
 estimated calculated at 9.85
 but order total is 78.83, but 8 times 9.85 = 78.80
Apply patches, set OrderPriceRounding syspref to 'Nearest cent'
Not order total is now as expected
View ordered.pl and confirm values are correct
Complete order, view invoice and confirm values
View spent.pl and confirm values
Go through acquisitions module and confirm prices throughout are
correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:40:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:40:42 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-ebvQNhTJN1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70189&action=edit
Bug 18736 - Unit tests for rounding

Unit tests to highlight the issue

To test:
Prove t/db_dependent/Budgets.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:42:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:42:08 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-FF9hLnIutD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 17:43:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 16:43:24 +0000
Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding
	errors)
In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18736-70-2cr0TDKyUH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
This is an attempt to repair the calculations here by providing a system
preference. I only add a 'nearest_cent' option, but I tried to leave things
open for further options to be added later.

Please test thouroughly and let me know any feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 18:04:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 17:04:35 +0000
Subject: [Koha-bugs] [Bug 19416] Make it possible to hide "Show checkouts to
 guarantor" on patron's detail page in staff
In-Reply-To: <bug-19416-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19416-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19416-70-DSIT8nv1zm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19416

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 18:06:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 17:06:38 +0000
Subject: [Koha-bugs] [Bug 18878] Improve item form display / labels too far
 from input fields
In-Reply-To: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18878-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18878-70-pHU9m6mi3A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18878

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 18:34:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 17:34:31 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-FY4YyAzKTT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #12 from David Gustafsson <glasklas at gmail.com> ---
Just to clarify: with "this patch is a requirement for us" I'm of course not
implying it's a requirement it gets committed, just that if it doesn't we will
maintain this patch against koha-master indefinitely (or at least as long as we
are using Koha) since without it indexing takes too long :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 19:39:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 18:39:47 +0000
Subject: [Koha-bugs] [Bug 19889] New: localholdspriority needs exclusions
Message-ID: <bug-19889-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

            Bug ID: 19889
           Summary: localholdspriority needs exclusions
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

localholdspriority is great, unless you have a unique or rare collection that
is popular.  If you have such a collection, and ongoing holds are being placed
on it to be picked up at several locations, only the patrons at that library
will ever get their hands on it unless a patron is smart enough and willing to
pickup the item at that location.

I would propose an exclusion preference, that would exclude listed patron
categories, item types, formats, or specific items.  Any other item criteria or
factors that I missed could be added to this list.

Currently we have patrons at other libraries that will never get the items they
have requested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 19:40:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 18:40:17 +0000
Subject: [Koha-bugs] [Bug 19889] localholdspriority needs exclusions
In-Reply-To: <bug-19889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19889-70-0sbgF3B52M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 20:28:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 19:28:11 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-a91YeNHxMp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #38 from Charles Farmer <charles.farmer at inlibro.com> ---
Is there any consensus on how to move this bug forward?

One of the implementation touches on SIP, the other does not. Are we sure
they're really duplicates?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:30:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:30:57 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-yfaYxUn2dw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:31:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:31:01 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-q80FLDA36m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #48 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70190&action=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:55:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:55:53 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-SQCUUDznrt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #49 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70191&action=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port     : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
    Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
    @attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

        modified:   C4/Breeding.pm
        modified:   Koha/Schema/Result/Z3950server.pm
        modified:   admin/z3950servers.pl
        new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
        modified:   installer/data/mysql/kohastructure.sql
        modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

New sign-off, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:56:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:56:06 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-4yCFCZV8xh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70190|0                           |1
        is obsolete|                            |

--- Comment #51 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70193&action=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:56:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:56:01 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-e2NbvKnrsj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #50 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70192&action=edit
Bug 11297: QA follow-up - Some fixes

- Makes Attributes only show up when adding a new Z39.50 server,
  not for SRU
- Fixes typo in db documentation
- Fixes sorting of table columns

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:59:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:59:25 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-h8eSpria3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62938|0                           |1
        is obsolete|                            |
  Attachment #62939|0                           |1
        is obsolete|                            |
  Attachment #70191|0                           |1
        is obsolete|                            |

--- Comment #52 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70194&action=edit
Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches.

Adds the "Attributes" field to z3950 servers.

The feature here is not quite de same.

In the old patches, the attributes were applied to individual query parts if
the part already contains "@attr" and the additionnal attribute is not already
in the query part.

Here, the content of the new field is prepended to all PQF queries sent to the
server.

This new way of doing is simpler and works for the sponsor.

Test plan:
 I) Apply the patch
II) Run updatedatabase.pl

1) Add a new z3950 server with the following parameters:
Hostname : catalogue.banq.qc.ca
Port     : 210
Database : IRIS
Syntax   : Marc21

2) Perform a z3950 search on that server.
    Keyword (Any) : egypt
2.1) Nothing Found.

3) Add attributes on the server administration page
    @attr 4=1

4) Perform the same z3950 search
4.1) A lot of results

        modified:   C4/Breeding.pm
        modified:   Koha/Schema/Result/Z3950server.pm
        modified:   admin/z3950servers.pl
        new file:  
installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql
        modified:   installer/data/mysql/kohastructure.sql
        modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt

Followed test plan, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

New sign-off, works as expected.
Signed-off-by: Marc V?ron <veron at veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:59:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:59:35 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-Bu7QLHodGv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70192|0                           |1
        is obsolete|                            |

--- Comment #53 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70195&action=edit
Bug 11297: QA follow-up - Some fixes

- Makes Attributes only show up when adding a new Z39.50 server,
  not for SRU
- Fixes typo in db documentation
- Fixes sorting of table columns

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 21:59:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 20:59:43 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-QVglQB5cym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70193|0                           |1
        is obsolete|                            |

--- Comment #54 from Charles Farmer <charles.farmer at inlibro.com> ---
Created attachment 70196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70196&action=edit
Bug 11297: QA follow-up - Avoid carrying server attributes

As it was pointed out, concatenating server attributes on a variable above the
foreach loop meant carrying those attributes through every other queries.

With a variable local to the loop, we can now send each server its specific
zquery.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 22:03:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 21:03:37 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
 Z39.50 server searches
In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11297-70-ACxq2FONoo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Charles Farmer <charles.farmer at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charles.farmer at inlibro.com

--- Comment #55 from Charles Farmer <charles.farmer at inlibro.com> ---
Some rebasing on the new master was necessary.

Submitted a third patch to follow-up on Marcel's observation.

Had to obsolete the [SIGNED-OFF] patches, but didn't have the stomach to remove
the sign off from the commit messages themselves. Patch back at needs sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 22:50:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 21:50:27 +0000
Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to
 KohaAdminEmailAddress is useless
In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19888-70-ScD9MsYIY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As there is no nice way to print the print notices at the moment we are still
relying on the email - it's not useless to us :) Making it optional makes a lot
of sense tho - if you have automated your printing somehow, you will no longer
need the emails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 22:51:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 21:51:00 +0000
Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to
 KohaAdminEmailAddress should be optional
In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19888-70-dkEba7SbNJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|"Overdue Notices" email     |"Overdue Notices" email
                   |sent to                     |sent to
                   |KohaAdminEmailAddress is    |KohaAdminEmailAddress
                   |useless                     |should be optional

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 22:55:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 21:55:48 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-9ZBrQPeuou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Magnus, I think this is out of scope if this aims to restore the former
behaviour - you'd have to remove the place of publication from indexes.
Maybe a next step could be a configurable Any index?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Dec 28 22:57:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 21:57:44 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-KdD7vuec4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #56 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As this would be a change of behavior now after a long time of dom indexing...
should we make it possible to switch the one that is used in the GUI when
selecting 'keyword'?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 00:59:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Dec 2017 23:59:06 +0000
Subject: [Koha-bugs] [Bug 9834] Should reverting a waiting hold keep the
	item number?
In-Reply-To: <bug-9834-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9834-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9834-70-Ot6whaDQ4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9834

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #5 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
Definitely needed for all the reasons mentioned: if holds are 'next available'
(which is nearly always the case for us) then turning it into an item-level
hold on allocation isn't ideal. Also, usually if you're reverting the waiting
status it's because the item has gone missing, so the only way to fix this is
actually to cancel the hold and then place a new hold and push the borrower to
the top of the list again, which is ...suboptimal.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 01:15:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 00:15:45 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-RQCiz7oJsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 01:23:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 00:23:26 +0000
Subject: [Koha-bugs] [Bug 19883] Add a selenium script to hit all the pages
In-Reply-To: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19883-70-Kas5nA9QVG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19883

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 01:24:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 00:24:03 +0000
Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a
 more granular level
In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8367-70-fm7nV3K6tb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #99 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
Is anyone still working on this? Being able to provide extended hold dates
(e.g. for items set aside for our housebound patrons) would be very useful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 03:04:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 02:04:42 +0000
Subject: [Koha-bugs] [Bug 19890] New: authorised value branches is not
 visible from dropdown in Admin
Message-ID: <bug-19890-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19890

            Bug ID: 19890
           Summary: authorised value branches is not visible from dropdown
                    in Admin
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hughr at brimbank.vic.gov.au
        QA Contact: testopia at bugs.koha-community.org

branches is an authorised value category in the database, but is not visible in
the 'Show category' dropdown list in Administration - Authorised Values.

This is confusing if a librarian tries to create an authorised value category
called 'branches' because it will fail, since it already exists. It should
appear in the authorised value category dropdown, though perhaps should not be
editable from that screen, since branches should be created under
Administration - Libraries and groups.

Problem in 16.11, presumably in later versions too but I can't test that.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 03:33:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 02:33:46 +0000
Subject: [Koha-bugs] [Bug 6685] circ rules by groups of items
In-Reply-To: <bug-6685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6685-70-hq8jmqn30j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

Hugh Rundle <hughr at brimbank.vic.gov.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #12 from Hugh Rundle <hughr at brimbank.vic.gov.au> ---
Great idea, and would resolve a problem for us too. We have different itemtypes
for games for adults vs games for children because we fine adults but not
children, but we want to maintain a limit on the number of games you can borrow
on a single card, regardless of item type. Definitely should use itemtypecat.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 03:40:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 02:40:36 +0000
Subject: [Koha-bugs] [Bug 19891] New: itemtypecat should show categories in
 refine search ( facets) and item details, not itypes
Message-ID: <bug-19891-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19891

            Bug ID: 19891
           Summary: itemtypecat should show categories in refine search
                    (facets) and item details, not itypes
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: hughr at brimbank.vic.gov.au
        QA Contact: testopia at bugs.koha-community.org

If using itemtypecat, the itemtypes are grouped into categories for Advanced
Search. However, in Refine Search, the item types listed are actual item types
rather than the item type categories. The same seems to be the case in
opac-detail. Either showing the category instead of the itemtype if itemtypecat
is being used, or providing a toggle to allow it, would be more consistent and
allow libraries to use fine-grained itemtypes without having to present them
all to library patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 07:45:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 06:45:37 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-vV2caAaBSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 07:45:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 06:45:41 +0000
Subject: [Koha-bugs] [Bug 19807] IntranetCatalogSearchPulldown doesn' t
 honor IntranetNumbersPreferPhrase
In-Reply-To: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19807-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19807-70-pgEmaP466r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19807

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70180|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70197&action=edit
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase

This patch
- fixes callnum and sn
- Removes unecessary syspref transmission to the template.
  As the template directly reads the syspref

Test plan:
1. Set sysprefs IntranetCatalogSearchPulldown and
   IntranetNumbersPreferPhrase to true
2. Go to staff:/cgi-bin/koha/catalogue/search.pl
3. "search for" ? "call number" and write anything that won't match a
   call number in the field
4. Then you should see
   ?No results match your search for 'callnum,phr: [...]?
5. Go to the staff homepage
6. Click on "Search the catalog"
7. Do the same search as previouly
8. Then you should see
   ?No results match your search for 'callnum,wrdl: [...]?
   This shows that IntranetNumbersPreferPhrase isn't honored
9. Apply this patch
10. Redo the same two searches and see that phr will now be always used.
    So IntranetNumbersPreferPhrase is honored

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 07:53:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 06:53:37 +0000
Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with
 Koha.Preference(' OPACNumbersPreferPhrase') in OPAC
In-Reply-To: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19892-70-nDskyyy2ZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 07:53:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 06:53:22 +0000
Subject: [Koha-bugs] [Bug 19892] New: Replace numbersphr variable with
 Koha.Preference(' OPACNumbersPreferPhrase') in OPAC
Message-ID: <bug-19892-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892

            Bug ID: 19892
           Summary: Replace numbersphr variable with
                    Koha.Preference('OPACNumbersPreferPhrase') in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

This was just done in intranet with bug 19807 to fix a bug and I think it would
be good to do the same for the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 08:10:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 07:10:18 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-Bbqlqk3ILO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) If you leave the preference empty, the default will show. The default
doesn't include cardnumber, I think it might be good to include it on top.

2) When using the preference, the default will still show, so there is no way
to remove fields. Wouldn't it make more sense to use the non-empty pref instead
of the default? For example a lot of libraries don't use the sort fields and
could remove them from the list this way. 

The current behaviour seems especially confusing since the preference is not
empty by default but includes a list of values. Deleting one of them will have
no effect as long as the value is in the list of default.

Failing for 2).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 08:14:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 07:14:03 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-TtNwhQ2ody@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 08:14:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 07:14:06 +0000
Subject: [Koha-bugs] [Bug 19798] Returns.pl doesn't define itemnumber for
	transfer-slip.
In-Reply-To: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19798-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19798-70-aTETijVwfl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19798

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70181|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 70198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70198&action=edit
Bug 19798: Fix print transfer slip

... and maybe other bugs as well
What happens here is that $itemnumber is no longer set when barcode is
passed.

Test plan:
1. Check in available/not on hold item at a non owning library.
2. Click print slip
3. Item's info must be displayed on the slip

Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se>
Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 08:28:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 07:28:01 +0000
Subject: [Koha-bugs] [Bug 19716] Add option to send header line for CSV
 output with runreport.pl
In-Reply-To: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19716-70-IaqfEErShA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Add option to send header   |Add option to send header
                   |line for CSV output         |line for CSV output with
                   |                            |runreport.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 11:29:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 10:29:23 +0000
Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere
	index
In-Reply-To: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-h94nFLHqVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #57 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Katrin Fischer from comment #55)
> Hi Magnus, I think this is out of scope if this aims to restore the former
> behaviour - you'd have to remove the place of publication from indexes.
> Maybe a next step could be a configurable Any index?

Sounds good!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 14:27:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 13:27:10 +0000
Subject: [Koha-bugs] [Bug 19893] New: Alternative optimized indexing for
	Elasticsearch
Message-ID: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

            Bug ID: 19893
           Summary: Alternative optimized indexing for Elasticsearch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: glasklas at gmail.com

At our library perhaps owning to a larger than average number of biblios a full
re-index takes an unacceptable amount of time complete (> 24h). We also had an
issue with indexing becoming increasingly slower when new mappings are added.
After some profiling using NYTProf it became clear most of this overhead is in
Catmandu::Store::ElasticSearch and Catmandu::MARC. After giving it some thought
the simplest way to resolve this issue actually seemed to be to replace these
libraries with Koha-specific code, since the functionality provided is actually
not that hard to re-implement in a more efficient manner. Due to the complexity
of Catmandu optimizing these libraries would most likely be more challenging
(and some parts are not actually possible to optimize because of limitations
owing to the architecture of Catmandu/Fix). Main benefits include:

1) Increased indexing performance (about twice as fast, six times as fast if
comparing time spent in update_index()), due to more efficient json-conversion
and fewer Elasticsearch requests.
2) With Catmandu indexing speed decreases as more mappings are added, with the
alternative algorithm indexing is kept more or less constant no matter how many
mappings you add.
3) Neglectable indexing start-up time. For example we have an issue with the
book drop machine, each return taking a couple of seconds because of the
catmandu start-up overhead.
4) More transparent code and less complexity compared with Catmandu.

With this patch the largest bottleneck is instead Marc::Record::as_xml_record,
to use marc21 as serialization format would probably be a lot faster but still
chose marc-xml because of the binary format length limitation (which could be
exceeded with many items). Still, I will probably try to look into faster
marc-xml serialization options in the future to address this.

I also attach profiling results with and without the patch applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 14:28:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 13:28:20 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-GZhm2AR9Iu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #1 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70199&action=edit
master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 14:28:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 13:28:40 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-zsHz7vhPLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #2 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70200&action=edit
patched

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 14:28:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 13:28:47 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-c6YJbEvQMA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |glasklas at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 14:41:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 13:41:38 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-wP92JqNzGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #3 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70201&action=edit
Bug 19893 - Alternative optimized indexing for Elasticsearch

Add alternative optimized indexing for Elasticsearch

How to test:
1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl
   with the -d flag: `koha-shell <instance_name> -c "time
rebuild_elastic_search.pl -d"`.
2) Enable ExperimentalElasticSearchIndexing system preference
   (found under Global System preferences -> Administration -> Search Engine).
3) Time a full re-index again, it should be about twice at fast (for a
   couple of thousand biblios, with fewer biblios results may be more
   unpredictable).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:20:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:20:19 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-E3ycFRYCfW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70201|0                           |1
        is obsolete|                            |

--- Comment #4 from David Gustafsson <glasklas at gmail.com> ---
Created attachment 70202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70202&action=edit
Bug 19893 - Alternative optimized indexing for Elasticsearch

Add alternative optimized indexing for Elasticsearch

How to test:
1) Time a full elasticsearch re-index by running the rebuild_elastic_search.pl
   with the -d flag: `koha-shell <instance_name> -c "time
rebuild_elastic_search.pl -d"`.
2) Enable ExperimentalElasticSearchIndexing system preference
   (found under Global System preferences -> Administration -> Search Engine).
3) Time a full re-index again, it should be about twice at fast (for a
   couple of thousand biblios, with fewer biblios results may be more
   unpredictable).

Sponsored-by: Gothenburg University Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:24:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:24:24 +0000
Subject: [Koha-bugs] [Bug 19893] Alternative optimized indexing for
	Elasticsearch
In-Reply-To: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19893-70-QMZ87qg5yS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:39:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:39:07 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-EDnurK5256@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69034|0                           |1
        is obsolete|                            |

--- Comment #179 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70203&action=edit
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:39:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:39:20 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-qj0UPgN7ps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69035|0                           |1
        is obsolete|                            |

--- Comment #180 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70204&action=edit
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:39:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:39:35 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Z8iNqfqvyV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69036|0                           |1
        is obsolete|                            |

--- Comment #181 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70205&action=edit
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up
next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate
it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos
with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by
number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to
explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will
then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of
a resource
    - no hardcoding for resources in the code of api (api needs to be called
with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you
anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a
Share button)
- Try to create a new subscription for serial #1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana-KB for more results, enter a few word from title, notes, type of the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake &
comment why you report: click on report mistake. You only can chose "other"
because there's no comment in Mana-KB [if there are comments, you'll get other
values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:39:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:39:50 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-Ve8WQW4CWO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69037|0                           |1
        is obsolete|                            |

--- Comment #182 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70206&action=edit
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to
prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your
e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any
crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the
test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't
show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there
must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should
appear when you click on "next", click on "use", the fields should automaticaly
appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again
on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the
action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search
on Mana-KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a
mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security
token, to send nothing: it should show a correct warning message.

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:39:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:39:55 +0000
Subject: [Koha-bugs] [Bug 19894] New: adadadada
Message-ID: <bug-19894-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19894

            Bug ID: 19894
           Summary: adadadada
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyuzenxmarch1 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 70207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70207&action=edit
adada

ad

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:40:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:40:04 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-5nAzhU8JuQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69038|0                           |1
        is obsolete|                            |

--- Comment #183 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70208&action=edit
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from
Mana.
- Error messages are displayed in case of fail
- Correct the display of sql reports containing "'"
- Importing a report from Mana now opens the edit page
- You don't get message after a successful import from mana (you simply get
redirected)
- Fix an error when cretaing subscription
- Fix mana search
- Correct encoding issues

Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:40:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:40:27 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-9Q8ihcxaji@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69039|0                           |1
        is obsolete|                            |

--- Comment #184 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70209&action=edit
Bug 17047 [QA Followup] - Fix misc koha-qa.pl failures - Fix up database schema
change, add to kohastructure.sql - Update schema files - Remove javascript
debugger call

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:40:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:40:44 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-J8dkjWEUry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69041|0                           |1
        is obsolete|                            |

--- Comment #185 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70210&action=edit
Bug 17047 - [QA Followup] - Fix untranslatable strings - Remove onclick html
attribute - Remove useless passing of mana_id variable in serials-toolbar.inc -
Remove using CGI::param in list context - remove new subs from
serials/subscription-add.pl - remov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:40:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:40:59 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-VrjbX9Iv8a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69091|0                           |1
        is obsolete|                            |

--- Comment #186 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 70211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70211&action=edit
Bug 17047 - Move ability to comment mana entities from search results table to
report/subscription detail page

+ code refactoring

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:41:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:41:36 +0000
Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data
In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17047-70-tFg7duAvLN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 15:42:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 14:42:32 +0000
Subject: [Koha-bugs] [Bug 19895] New: adadadada
Message-ID: <bug-19895-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19895

            Bug ID: 19895
           Summary: adadadada
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyuzenxmarch1 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

ad

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 16:00:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 15:00:18 +0000
Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve
	aliased fields
In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19575-70-K4BJStWUy9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #30 from David Gustafsson <glasklas at gmail.com> ---
Just a caveat, just discovered that some field names hard coded in
xsl-templates have names that differer in case from mappings.yaml.
(control-number for example). Zebra has case-insensitive field names, but this
will cause problems with elasticsearch. So this patch, while correcting some
links, might also break some that worked before. I'm planning on writing a fix
to make Elasticseach field names non case sensitive, but until that issue is
resolved this patch might causee issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 16:27:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 15:27:21 +0000
Subject: [Koha-bugs] [Bug 19897] New: Make status 'on hold' more specific
Message-ID: <bug-19897-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19897

            Bug ID: 19897
           Summary: Make status 'on hold' more specific
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In some cases 'on hold' can mean the item is waiting (item detail page in
OPAC), in other cases it just means that someone has placed a hold (no renewal
possible because...). It would be nice if we could be more clear about this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:34:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:34:47 +0000
Subject: [Koha-bugs] [Bug 19888] "Overdue Notices" email sent to
 KohaAdminEmailAddress should be optional
In-Reply-To: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19888-70-QURyDgiDdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19888

Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:36:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:36:14 +0000
Subject: [Koha-bugs] [Bug 19884] Improve performance of GetItem
In-Reply-To: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19884-70-WzgmZz5rpZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

David Gustafsson <glasklas at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:52:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:52:05 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-rqsMWYYY1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:52:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:52:08 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-KWomaXm4dI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70213&action=edit
Bug 18639 - Add replacementprice field to aqorders

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:52:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:52:11 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-XeqW0jXpFx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70214&action=edit
Bug 18639 - Schema updates (DO NOT PUSH)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:52:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:52:15 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-sw7krPP3zD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70215&action=edit
Bug 18639 - Add replacementprice field to acquisitions workflow

To test:
 0 - Apply patches and updatedatabase
 1 - Add an order to a basket
 2 - You should note new 'Retail price field'
 3 - You should have a separate 'Replacement price' field
 4 - Enter values and ensure they are saved as expected
 5 - In the basket you should see the replacement price
 6 - Modify order and ensure value is loaded and saved correctly
 7 - Add and cancle an order and esure replacement price shows/saves
 8 - Close basket
 9 - Receive an order
10 - You should be able to edit replacement price
11 - 'retail price' field is not editable
12 - Check associated item, replacement price in item should be updated
13 - Cancel receipt, check item. receive again with new replacement
price, check item
14 - Price should be correctly updated
15 - Finish receipt, value should show in table
16 - Test with receive from file

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:52:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:52:17 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-kcXM3CTXZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 70216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70216&action=edit
Bug 18639 - Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:54:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:54:17 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-vFqd2LNN82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Couple things:
3b - Not so much possible - retail price is calculated from listprice and is
converted. Changing this field doesn't actually save either. I think we can
just make this not editable - but that is for another bug report

5 - I need an EDI person to look at the scripts and update as needed

Otherwise I think this should work as expected

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 17:54:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 16:54:43 +0000
Subject: [Koha-bugs] [Bug 18639] Separate replacement cost and retail price
 fields in acquisitions
In-Reply-To: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18639-70-87iqMkNIBe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Dec 29 19:41:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Dec 2017 18:41:34 +0000
Subject: [Koha-bugs] [Bug 19898] New: Koha 17.11 - Upload Local Cover Image
 Failed - " Cannot process file as an image"
Message-ID: <bug-19898-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898

            Bug ID: 19898
           Summary: Koha 17.11 - Upload Local Cover Image Failed - "Cannot
                    process file as an image"
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbutosi at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In Koha 17.11, I am trying to upload a .jpg image to a bibliographic record (as
a local cover image). After uploading, then clicking "Process Images", I get
the following error:

"Cannot process file as an image. Cannot process file as an image.
Please ensure you only upload GIF, JPEG, PNG, or XPM images."

I've tried to upload the file as a .jpg, .png, and .gif. The error persists. 
I've also tried to upload a different .jpg file. The error still persists.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 30 12:08:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Dec 2017 11:08:18 +0000
Subject: [Koha-bugs] [Bug 19895] SPAM
In-Reply-To: <bug-19895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19895-70-ZseogtwNFX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19895

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|adadadada                   |SPAM
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 30 12:08:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Dec 2017 11:08:38 +0000
Subject: [Koha-bugs] [Bug 19894] SPAM
In-Reply-To: <bug-19894-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19894-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19894-70-yVftAxypVF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19894

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|adadadada                   |SPAM
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Dec 30 17:24:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Dec 2017 16:24:19 +0000
Subject: [Koha-bugs] [Bug 19898] Koha 17.11 - Upload Local Cover Image
 Failed - " Cannot process file as an image"
In-Reply-To: <bug-19898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19898-70-pMuE6s7jxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19898

--- Comment #1 from Craig <cbutosi at gmail.com> ---
Checking the intranet error log, it reads:

"[Fri Dec 29 13:52:20.972923 2017] [cgi:error] [pid 5805] [client
142.116.112.216:50322] AH01215: [Fri Dec 29 13:52:20 2017]
upload-cover-image.pl: Use of uninitialized value $domain in regexp compilation
at /usr/share/koha/lib/C4/Auth.pm line 1090.:
/usr/share/koha/intranet/cgi-bin/tools/upload-cover-image.pl, referer:
http://library.craigbutosi.ca:8080/cgi-bin/koha/tools/upload-cover-image.pl"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 31 14:49:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Dec 2017 13:49:00 +0000
Subject: [Koha-bugs] [Bug 19899] New: Software error while check in,
 The method noreturn is not covered by tests!
Message-ID: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

            Bug ID: 19899
           Summary: Software error while check in, The method noreturn is
                    not covered by tests!
 Change sponsored?: ---
           Product: Koha
           Version: 17.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mhby87 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 70217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70217&action=edit
The method noreturn is not covered by tests!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 31 14:51:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Dec 2017 13:51:07 +0000
Subject: [Koha-bugs] [Bug 19899] Software error while check in,
 The method noreturn is not covered by tests!
In-Reply-To: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19899-70-lQe2XViSHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

--- Comment #1 from Mohd Hafiz Yusoff <mhby87 at gmail.com> ---
Software Error while upgrade from KOHA 16.05 to 17.11. This error while check
in and I got error message "The method noreturn is not covered by tests!"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Dec 31 14:53:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 31 Dec 2017 13:53:58 +0000
Subject: [Koha-bugs] [Bug 19899] Software error while check in,
 The method noreturn is not covered by tests! after upgrade from
 16.05 to 17.11
In-Reply-To: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19899-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19899-70-S1fsXY9mDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

Mohd Hafiz Yusoff <mhby87 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Software error while check  |Software error while check
                   |in, The method noreturn is  |in, The method noreturn is
                   |not covered by tests!       |not covered by tests! after
                   |                            |upgrade from 16.05 to 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.