[Koha-bugs] [Bug 7046] subscription renewal period should be a pull down

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 69408
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69408
Bug 7046 - Implemented dropdown sub length element

Review of attachment 69408:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7046&attachment=69408)
-----------------------------------------------------------------

::: C4/Serials.pm
@@ +1509,5 @@
> +          $subtype eq 'issues' ? $length : 0,
> +          $subtype eq 'weeks'   ? $length : 0,
> +          $subtype eq 'months'  ? $length : 0,
> +    );
> +}

Now it is not internal subroutine so the name should not start with
underscores.

Tests are needed for new subroutines in modules.

Some refactoring using objects would be nice, but it is out of the scope of
this bug report IMO, so no blocker.

::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
@@ +32,4 @@
>              </li>
>  		<li><fieldset>
>  		<legend>Subscription length:</legend>
> +		<select name="subtype" id="subtype">

Here are tabs at beginning, need to be removed

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.