[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #23 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 69700
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69700
Bug 19560: Correctly escape branchcode in admin/branches.pl

Review of attachment 69700:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19560&attachment=69700)
-----------------------------------------------------------------

Just a quick look at the code:

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
@@ +5,4 @@
>  [% ELSIF op == 'delete_confirm_category' %]
>      › Confirm deletion of group [% category.categorycode %]
>  [% ELSIF op == 'add_form' %]
> +    ›[% IF library %]Modify library[% ELSE %]New library [% library.branchcode | html %][% END %]

Shouldn't it be?

›[% IF library %]Modify library [% library.branchcode | html %][% ELSE
%]New library[% END %]

looks like this is bug in current master...

@@ +67,4 @@
>  [% ELSIF op == 'delete_confirm_category' %]
>  › Confirm deletion of group [% category.categorycode %]
>  [% ELSIF op == 'add_form'  %]
> +› [% IF library %]Modify library[% ELSE %]New library [% library.branchcode | html %][% END %]

The same

-- 
You are receiving this mail because:
You are watching all bug changes.