[Koha-bugs] [Bug 16330] REST API: add routes to add, update and delete patrons
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Dec 12 12:07:43 CET 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330
--- Comment #66 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
One thing that needs to be fixed:
PUT endpoint uses C4::ModMember (which I think is plain wrong, but thats
another issue and I understand why...) and this requires borrowernumber as
param due to some internal lookups, categorycode e.g.)
tests pass since entire patron object is passed in, but that's a false
positive, since borrowernumber shouldn't be passed in body, its already a path
param. since path param must be authoritative, I suggest just overwriting body
param in the helper method already used.
Otherwise great work!
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list