[Koha-bugs] [Bug 3717] staffClientBaseURL and OPACBaseURL should be used

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3717

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk

--- Comment #5 from Jon Knight <J.P.Knight at lboro.ac.uk> ---
Now that we've had things like Bug 16401 push to master which is most
definitely using staffClientBaseURL (and indeed including the protocol details
now) it looks like we're actively using staffClientBaseURL alot more. Its in
svc/import_bib, the CAS authentication, several test suites, and (if it gets
unblocked) bug 12027 will use it for Shibboleth too.

I guess the question at this point is where else in the Koha codebase does
staffClientBaseURL need to appear? Having a look at some pages returned by the
staff client at the moment we have a lot of "path-absolute" (in RFC 3986 terms)
URIs in there.  For example "/intranet-tmpl/prog/css/mainpage.css",
"/cgi-bin/koha/catalogue/search.pl", "/intranet-tmpl/prog/js/basket.js". Those
look to be hard coded in the templates (eg
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt), so to change them
will mean a large number of templates will need to be altered.  

One option might be to drop the leading slash on the path in these URLs the
templates and include a BASE element in the head of the HTML output that
specified the staffClientBaseURL? That would mean that people could put the
Koha staff client under any base path they liked then (which I think is the
major thrust of this bug report?).  Opinions?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.