[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Dec 13 07:48:38 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #107 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Owen Leonard from comment #105)
> Testing functionality goes without any problem, but running "prove
> t/db_dependent/Koha/Items.t t/db_dependent/Circu lation.t" gave this result:
> 
> t/db_dependent/Circulation.t (Wstat: 65280 Tests: 42 Failed: 1)
>   Failed test:  41
>   Non-zero exit status: 255
>   Parse errors: Bad plan.  You planned 112 tests but ran 42.
> 
> Also, running the QA tool highlighted some issues.

Thanks for testing!

I added a followup, test are passing now and QA tools return just one "warning"
about pod coverage on Koha/RotatingCollection/Tracking.pm, but that is new file
with no added methods, so there is nothing more to add to pod IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list