[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

Thu Dec 14 12:21:14 CET 2017

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #23 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 69461
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69461
Bug 18308 - Added step to onboarding tool to set minPasswordLength

Review of attachment 69461:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18308&attachment=69461)
-----------------------------------------------------------------

I would like to see the setting of min password length before creating the
superlibrarian user account, because now you first use the limit a then set the
limit - it is not very logical IMO

::: installer/onboarding.pl
@@ +313,1 @@
>      $template_params->{all_done} = 1;    # If step 5 is complete, we are done!

The comment should be changed too, 5 => 6

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep6.tt
@@ +2,5 @@
> +<title>Koha › Web installer ›
> +    [% IF all_done %]
> +        Complete
> +    [% ELSE %]
> +        Create circulation rule

Should be "Set minPasswordLength system preference"

@@ +8,5 @@
> +</title>
> +[% INCLUDE 'installer-doc-head-close.inc' %]
> +[% INCLUDE 'validator-strings.inc' %]
> +[% INCLUDE 'installer-strings.inc' %]
> +<script type="text/javascript" src="[% interface %]/[% theme %]/js/onboarding.js"></script>

Javascript should be at the end - see bug 17418

@@ +14,5 @@
> +
> +<body id="installer" class="installer">
> +    <div class="container-fluid">
> +        <div class="row">
> +            <div id="onboarding-step5" class="installer-main col-sm-8 col-sm-offset-2 col-md-8 col-md-offset-2">

This is actually step6

-- 
You are receiving this mail because:
You are watching all bug changes.