[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #73 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Thanks Alex for your perseverance. I am addressing your question from comment60
here too.
Putting this on top of sec report 19319 which does some changes to
Koha::Biblios->find in detail scripts.

IsItemOnHoldAndFound is only used in CanBookBeRenewed and
IsAvailableForItemLevelRequest; unfortunately it is not tested specifically.
I think it should be moved to Koha::Item. And it should not call DBIx directly
but use your search. The condition != undef is in practice the same as [W,T]
since F is only used when the reserve is filled (finished) and moved to
oldreserves.
For the same reason I remove this test (using F in the reserves table does not
reflect current use).
Koha::Holds->find($hold->{reserve_id})->found('F')->store;
$is = IsAvailableForItemLevelRequest( $item3, $borrower1);
is( $is, 0, "Item is neither waiting nor in transit." );
See the followup patches.

Rename hasItemswaitingOrInTransit => hasItemsWaitingOrInTransit ? No blocker.
The POD statement is adjusted. Imo the POD should get some more attention. No
blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.