[Koha-bugs] [Bug 19808] Reviews from deleted patrons make opac-detail explode

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19808

--- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> ---
Created attachment 69824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69824&action=edit
Fix opac-detail being broken by a review from a deleted patron

And other display issues when the patron was NULL.
Which allows to keep the review even if it has no patron.
Because it might be useful.

For example when disconnected, the borrowernumber is null. So the
comments from deleted patrons were displayed as if the disconnected
user wrote them. So it had the edit button...

And fix borrowernumber not being passed to the template when
OpacStarRatings was false.

Test plan
1. Log in as a patron
2. Leave a comment/review on a record
3. Librarian: approve this comment
4. Delete the borrower
5. See the record
(opac:/cgi-bin/koha/opac-detail.pl?biblionumber=RELEVANT_BIB_NUMBER)
6. Then you should see an error
7. Apply this patch
8. Refresh the page
9. Then you should see the record page with the comment

-- 
You are receiving this mail because:
You are watching all bug changes.