[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #12 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to M. Tompsett from comment #8)
> ::: installer/data/mysql/updatedatabase.pl
> @@ +14308,4 @@
> >  
> >      $dbh->do(q|
> >          INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`)
> > +        VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');
> 
> I don't think updatedatabase should be modified like this. This is already
> done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE,
> if this is correct logic.

I thought this change was necessary for fresh installs. If the atomic update is
enough then I'm happy to take this out.

> 
> ::: opac/svc/patron_notes
> @@ +82,4 @@
> >                  my $biblionumber = $issue->item->biblionumber;
> >                  my $letter = C4::Letters::GetPreparedLetter (
> >                      module => 'circulation',
> > +                    letter_code => 'CHECKOUT_NOTE',
> 
> Why even change the letter code, given that you aren't changing the svc name?

Mostly so that the name of the note is consistent with the name of the syspref
(AllowCheckoutNotes), therefore, the name of the feature. The filename should
also be changed as checkout note is more appropriate than patron note anyway -
I think this was just a missed case from the original bug.

-- 
You are receiving this mail because:
You are watching all bug changes.