[Koha-bugs] [Bug 19200] Warns when exporting a basket

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Marcel de Rooy from comment #3)
> This looks like a change in behavior. When the cgi param is default, no
> profile id was passed.
> I guess what you wanted to do was just if( $param && $param eq ... ) ?

Hi Marcel,

there is no change in behaviour in my patch. It looks like there's originally a
bug here, because the original code says "if $query->param('csv_profile') eq
'default'", but the word 'default' is never passed through that param, based on
acqui/basket.tt. this means that when the Default option was selected, the
$query->param('csv_profile') is not actually set to 'default' so an
uninitialised value is sent to the GetBasketAsCSV method and the 'if' condition
is never true. (I hope that makes sense. If you put a warn inside the if
statement under where $query->param('csv_profile') eq default, you'll see that
it never enters here and never prints the warn.)

my patch checks if the $query->param('csv_profile') has been defined. if it
has, then it uses one of the library-made csv profiles. if it hasn't been
defined then it must be using the default profile and no ID is passed, as
intended, with no warns.

setting back to needs signoff as I believe this is still a valid patch.

-- 
You are receiving this mail because:
You are watching all bug changes.