[Koha-bugs] [Bug 19832] New: SIP checkout removes extra hold on same biblio

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

            Bug ID: 19832
           Summary: SIP checkout removes extra hold on same biblio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: boutrosboutrosboutros at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

C4/SIP/ILS/Transaction/Checkout.pm includes the following bit of code which
remove any hold that that matches the biblio and bilbionumber in checkout:

# Fill any reserves the patron had on the item.  
    # TODO: this logic should be pulled internal to AddIssue for all Koha. 
    $debug and warn "pending_queue: " . (@$pending) ? Dumper($pending) : '[]';
    foreach (grep {$_->{borrowernumber} eq $self->{patron}->{borrowernumber}}
@$pending) {
        $debug and warn "Filling reserve
(borrowernumber,biblionumber,reservedate): "
            .
sprintf("(%s,%s,%s)\n",$_->{borrowernumber},$_->{biblionumber},$_->{reservedate});
        ModReserveFill($_);
        # TODO: adjust representation in $self->item
    }


As far as I can tell, this code is completely unnecessary, since
C4::Circulation::AddIssue allread calls C4::Reserves::MoveReserve which
fullfills the hold. What's more, if the borrower has multiple holds on the same
biblio, all of them will be removed. This is clearly wrong.

I purpose to remove the code above, unless someone can explain why SIP checkout
should behave different than normal checkout in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.