[Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am in doubt about adding a new routine to C4::GetOPACMarcNotes

- We are missing tests, but tests are required for any new routine or a change
to an existing one.
- I think it might make more sense to use improve GetMarcNotes to take an
interface parameter, like we do in other cases. Duplicating the code will
create problems, such as with bug 18198.

--

Some other small things:
- Database update should be in an atomicupdate file (see database update
instructions on the wiki)
- Please use INSERT IGNORE
- It might be a bit more consistent with other prefs to have
OPACNotesBlackList. Examples: (OPAC)ISBD,(OPAC)AmazonCoverImages,
(OPAC)LocalCoverImages, ...)

-- 
You are receiving this mail because:
You are watching all bug changes.