Add a patron category

From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 00:35:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 23:35:23 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #122 from M. Tompsett --- If you want to have this signed off, I don't want to see: Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: 'anyunavailable' for column 'onshelfholds' at row 1 at /home/mtompset/kohaclone/Koha/Object.pm line 120 For help, please send mail to the webmaster (webmaster at ubuntu), giving this error message and the time and date of the error. When I attempt a Xenial install. The other possibility is completely remove onshelfholds and just default it to something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 01:16:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 00:16:34 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #123 from M. Tompsett --- Created attachment 59703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59703&action=edit Bug 17855: Follow up - Fix onshelfholds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 01:16:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 00:16:24 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:00:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:00:38 +0000 Subject: [Koha-bugs] [Bug 18026] New: URL to database columns link in system preferences is incorrect Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Bug ID: 18026 Summary: URL to database columns link in system preferences is incorrect Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: dilan at calyx.net.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 59704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59704&action=edit Picture of the URL link Under the Acquisitions tab in Global system preferences, the link to the Koha items table URL is broken. The link should be: http://schema.koha-community.org/16_05/tables/items.html but the link instead is: http://schema.koha-community.org/tables/items.html Note the "16_05" missing in the latter. This causes a 404 "not found" error to result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:02:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:02:47 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #124 from Alex Buckley --- Created attachment 59705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59705&action=edit Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script Replaced all sql code in onboarding.pl script with DBIx Changed the logic of the onshelfholds if statement in onboarding.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:04:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:04:04 +0000 Subject: [Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:12:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:12:45 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:12:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:12:48 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59705|0 |1 is obsolete| | --- Comment #125 from Alex Buckley --- Created attachment 59706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59706&action=edit Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script Replaced all sql code in onboarding.pl script with DBIx Changed the logic of the onshelfholds if statement in onboarding.pl https://bugs.koha-community.org/show_bug.cgi?id=17855 Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:29:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:29:06 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #126 from Alex Buckley --- Created attachment 59707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59707&action=edit bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged several commits - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script - Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' - Added the use CGI qw ( -utf8 ); - Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt - Fixed typo in summary.tt - Made consistent single space before and after -> in all onboarding .tt and summary.tt files. - Made single
tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) - Changed button and link names in web installer and onboarding tool - Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. - Fixed the errors from the koha qa test - Removed use:C4/Auth from the onboarding.pl - Moved the "select all options" button down to just above the selectable options in the basic setup, and positioned at the top of the page for the advanced setup. - Removed the "there is nothing to do because the sample data is already installed" page so if the user has install sample data in the web installer then the step to create that object in the onboarding tool is skipped altogether. - Removed the "We're just going to setup a few more things" page - Changed the title of the 'Create patron page' - Added clarifying information to the "Add a patron category" page - Added clarifying information to the "Create item type" page - Fixed the capitalization in the onboarding tool - Removed the BackupStep3.tt file which was un-used - Changed the redirect time displayed to user in step3.tt to 10 - Changed the cardnumber on the create patron administrator page so that it is only populated when the user installed sample patrons. Also changed the regex so that it allows letters and number. - Used the HTMl validator to identify errors in the template and have corrected all possible in the onboarding templates. Signed-off-by: Mark Tompsett Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:47:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:47:04 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:47:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:47:01 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #52 from Nick Clemens --- This is looking very good - the one issue I see remaining is the content in the OverDrive tab has a lot of html tags showing etc - can that be processed correctly? -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:56:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:56:18 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59703|0 |1 is obsolete| | --- Comment #127 from Alex Buckley --- Created attachment 59708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59708&action=edit Bug 17855: Follow up - Fix onshelfholds Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 02:58:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 01:58:04 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59706|0 |1 is obsolete| | --- Comment #128 from Alex Buckley --- Created attachment 59709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59709&action=edit Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script Replaced all sql code in onboarding.pl script with DBIx Changed the logic of the onshelfholds if statement in onboarding.pl https://bugs.koha-community.org/show_bug.cgi?id=17855 Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:02:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:02:51 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59628|0 |1 is obsolete| | --- Comment #129 from M. Tompsett --- Created attachment 59710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59710&action=edit Bug 17855 - Implemented a retrieval of patron category enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron accounts created with the onboarding tool. Set address and city variables to "" in onboarding.pl Fixed the creation/filling of the $firstpassword, $secondpassword and $op variables in the onboarding.pl so they don't cause uninitialised variable errors. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:03:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:03:18 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59709|0 |1 is obsolete| | --- Comment #130 from M. Tompsett --- Created attachment 59711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59711&action=edit Bug 17855 - Follow up: code clean up Removed unnecessary use pragmas in the onboarding.pl script Replaced all sql code in onboarding.pl script with DBIx Changed the logic of the onshelfholds if statement in onboarding.pl Signed-off-by: Alex Buckley NOTE: Initially came from 17955 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:03:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:03:27 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59708|0 |1 is obsolete| | --- Comment #131 from M. Tompsett --- Created attachment 59712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59712&action=edit Bug 17855: Follow up - Fix onshelfholds Signed-off-by: Alex Buckley Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:06:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:06:03 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #59639|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Comment on attachment 59639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59639 Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script Patch was moved to bug 17855. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:06:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:06:57 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from M. Tompsett --- Moved back to assigned, so Alex can reuse this or close it as deemed fit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:17:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:17:14 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #4 from M. Tompsett --- Comment on attachment 59630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59630 Bug 17982: Fix the use of uniq in sub themelanguage Review of attachment 59630: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17982&attachment=59630) ----------------------------------------------------------------- ::: C4/Templates.pm @@ +256,4 @@ > my $where = $tmpl =~ /xsl$/ ? 'xslt' : 'modules'; > for my $theme (@themes) { > if ( -e "$htdocs/$theme/$lang/$where/$tmpl" ) { > + return ( $theme, $lang, [ uniq(@themes) ] ); I'm not sure the parenthesis for uniq are necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:58:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:58:15 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #132 from Alex Buckley --- *** Bug 17955 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:58:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:58:15 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #8 from Alex Buckley --- The commit that was in bug 17955 has been attached to bug 17855. Meaning the changes required by bug 17955 have been implemented by bug 17855. *** This bug has been marked as a duplicate of bug 17855 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 03:59:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 02:59:42 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #21 from M. Tompsett --- (In reply to Owen Leonard from comment #20) > (In reply to M. Tompsett from comment #14) > > There, screen shots of what I was talking about. Explain the reasons for the > > difference. > > This is rude. I apologize for the shortness. I'm sorry. I was wrong. > (In reply to M. Tompsett from comment #19) > "Superlibrarian" is red because it is highlighted for visibility in a page > which is structured with sections topped by headings. There is nothing in > that section other than text. I think its appropriate to provide a little > more visibility to that text to help show that it is the focus of that > section. > > "Staff" is plain black because it is informational text being displayed as > part of a form. As in other places in Koha, when a line in a form displays > information instead of some kind of input, plain text is paired with class="label">Label: to preserve the structure and flow of the > form. > The plain text fits with the structure of the form and does not need to be > highlighted. Thank you for the explanation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 04:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 03:04:12 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #22 from M. Tompsett --- (In reply to Josef Moravec from comment #18) > > In English it's OK I can confirm this. Though, OK is so bland. It is quite pretty. Did you get it working in Czech, Josef? If so, would you like to sign off, or shall I? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 04:31:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 03:31:28 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59394|0 |1 is obsolete| | --- Comment #53 from Srdjan Jankovic --- Created attachment 59713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59713&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 04:31:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 03:31:55 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59395|0 |1 is obsolete| | --- Comment #54 from Srdjan Jankovic --- Created attachment 59714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59714&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 05:05:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 04:05:54 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #16 from Alex Buckley --- Created attachment 59715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59715&action=edit Bug 17944 - Moved the DBIx code into the ItemType.pm file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 05:07:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 04:07:56 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 05:20:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 04:20:35 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #17 from M. Tompsett --- Comment on attachment 59715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59715 Bug 17944 - Moved the DBIx code into the ItemType.pm file Review of attachment 59715: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17944&attachment=59715) ----------------------------------------------------------------- ::: admin/itemtypes.pl @@ +140,4 @@ > > } elsif ( $op eq 'delete_confirm' ) { > > + my $overalltotal = Koha::ItemType->get_items_and_biblioitems($itemtype_code); This is what was asked for in comment #15. @@ +151,4 @@ > > } elsif ( $op eq 'delete_confirmed' ) { > > + my $itemtype = Koha::ItemType->get_items_and_biblioitems($itemtype_code); This change confuses me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 05:23:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 04:23:09 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 05:29:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 04:29:21 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #18 from Alex Buckley --- Created attachment 59716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59716&action=edit Bug 17955 - removed incorrect function call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 05:29:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 04:29:41 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 05:47:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 04:47:47 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #19 from Alex Buckley --- Created attachment 59717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59717&action=edit Bug 17944 - Added additional USE pragma -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 06:02:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 05:02:39 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 06:02:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 05:02:42 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59715|0 |1 is obsolete| | Attachment #59716|0 |1 is obsolete| | Attachment #59717|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 59718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59718&action=edit Bug 17944 - Moved the DBIx code into the ItemType.pm file Created get_items_and_biblioitems in Koha::ItemType using DBIx coding style. Changed itemtypes.pl to use that method This addresses comment #15. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 06:12:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 05:12:04 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59549|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 59719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59719&action=edit Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 06:12:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 05:12:09 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59550|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 59720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59720&action=edit Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 06:13:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 05:13:17 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |In Discussion --- Comment #5 from M. Tompsett --- Missed a spot: opac-tags.pl Is that fixed elsewhere, or should it be fixed here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 06:30:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 05:30:41 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #8 from M. Tompsett --- (In reply to Owen Leonard from comment #7) > (In reply to M. Tompsett from comment #5) > > > I believe this is the wrong solution. It is much simpler. > > Since you're obsoleting a patch from an Academy student in favor of your own > I think it's worthwhile to give a detailed explanation of your reasoning. Sorry for taking so long to notice this. Valid point, Owen. The problem is not the 'Add To' heading section (as hinted at by the 3rd obsolete patch). The problem is not around line 40ish (as hinted at by the 1st two obsolete patches). The problem is when there are no lists, it makes no sense to show that you can select a list. The problem is the code correctly checks the count method of the two shelf types, but fails to do so on the third on line 26. By simplying adding .count to the third shelf type, the options available are properly shown. There is no need to add a condition. The existing condition was broken. Though, what I do miss about the first two patches are corrections in indentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 07:10:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 06:10:20 +0000 Subject: [Koha-bugs] [Bug 18027] New: Added a new item which does not appear in catalogue search but appears in acquisition report. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18027 Bug ID: 18027 Summary: Added a new item which does not appear in catalogue search but appears in acquisition report. Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: clouca at cpl.org.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Added the item three times (with different barcodes)and these show in report but cannot be found in catalogue search or by a patron on their platform. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 07:18:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 06:18:59 +0000 Subject: [Koha-bugs] [Bug 18027] Added a new item which does not appear in catalogue search but appears in acquisition report. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18027 Christalla changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 08:53:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 07:53:30 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Jonathan Druart --- Alex, There are some wrong things here: 1/ No tests are provided 2/ You do not instanciate a Koha::ItemType object but using get_items_and_biblioitems as a class method. 3/ get_items_and_biblioitems is badly named, it does not return the items and the biblioitems, but the number of item and biblioitems. That's why I suggested ->is_used, which would return true or false. 4/ There is no POD for this new method 5/ Why do not you want to use Koha::Items and Koha::Biblioitems? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:03:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:03:41 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59623|0 |1 is obsolete| | --- Comment #23 from Josef Moravec --- Created attachment 59721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59721&action=edit [SIGNED-OFF] Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:03:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:03:34 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:05:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:05:14 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #24 from Josef Moravec --- (In reply to M. Tompsett from comment #22) > (In reply to Josef Moravec from comment #18) > > > In English it's OK > > I can confirm this. Though, OK is so bland. It is quite pretty. Did you get > it working in Czech, Josef? If so, would you like to sign off, or shall I? Yes, after regenerating templates everything is OK, so my mistake... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:06:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:06:38 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #25 from Josef Moravec --- Signed off, has to say it looks really nice! Good job Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:13:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:13:52 +0000 Subject: [Koha-bugs] [Bug 18022] Empty barcode causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major --- Comment #1 from Jonathan Druart --- https://lists.katipo.co.nz/pipermail/koha/2017-January/047102.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:14:33 +0000 Subject: [Koha-bugs] [Bug 18022] Empty barcode causes internal server error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 --- Comment #2 from Jonathan Druart --- Note, from the mailing list: I am not able to recreate this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:17:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:17:30 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 09:17:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 08:17:41 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59662|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 59722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59722&action=edit Bug 17775 - Add new user with LDAP not works under Plack This patch fixes internal server error: Undefined subroutine &C4::Auth_with_ldap::AddMember called at /srv/koha_ffzg/C4/Auth_with_ldap.pm line 213. It occurs only under plack, and it's strange since C4::Members does EXPORT AddMember and we are importing it into Auth_with_ldap.pm (and it does work under CGI). Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart I did not test but trust author and signoffer. The change cannot hurt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:01:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:01:07 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #133 from Jonathan Druart --- Alex, Few more remarks: 1/ There is something wrong with the sql sample files for translated languages. The mandatory and optional files for the other languages have to be moved to the default directory as well. We will have to be meticulous to avoid regressions. 2/ You should also adapt xt/sample_notices.t, tests are failing after your patches 3/ Could you double check the module you use in installer/onboarding.pl, some are uselessly used. 4/ Double check the copyright lines you have added (+# Copyright (C) YEAR YOURNAME-OR-YOUREMPLOYER) 5/ You copied some existing javascript functions to onboardingstep2.tt. Do not duplicate existing code. You should also have a look at this template, the indentation in the javascript portion is weird. 6/ Same as 5 for onboardingstep3.tt 7/ summary.tt - you should not use
tag, our translation tool does not handle sentences when they are split by html tag. That make the job really hard (and sometimes impossible) for translators. 8/ Copyright of summary.pl sounds totally wrong. 9/ Is this Summary info really useful? To me it looks like it should be moved to the help part. I am not sure it worth a new entry in the "More" menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:08:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:08:15 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:08:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:08:20 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59671|0 |1 is obsolete| | Attachment #59672|0 |1 is obsolete| | Attachment #59673|0 |1 is obsolete| | Attachment #59674|0 |1 is obsolete| | --- Comment #43 from Josef Moravec --- Created attachment 59723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59723&action=edit [SIGNED-OFF] Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:08:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:08:56 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #44 from Josef Moravec --- Created attachment 59724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59724&action=edit [SIGNED-OFF] Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying with each new edit, losing the previous effort. Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:09:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:09:16 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #45 from Josef Moravec --- Created attachment 59725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59725&action=edit [SIGNED-OFF] Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:09:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:09:29 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #46 from Josef Moravec --- Created attachment 59726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59726&action=edit [SIGNED-OFF] Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:13:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:13:42 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- Hi Aleisha, Here are a few remarks: 1/ in the preferences.pl file, I think it would be better to affect the patron category list to $chunk->{'CHOICES'} if the type of the syspref is patron-categories, and not depending on its name. That way it will be reusable more easily. 2/ There is type=PatronCategories"in the DB, choices:patron-categories in the opac.pref, then choices eq 'patron-categories' in preferences.pl How is useful this type=PatronCategories? 3/ There are 2 problematic cases: a. The field is not filled yet: it's not visible on the interface, there is no blank entry b. A bit more tricky: if the patron category has been removed, it will not be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:15:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:15:12 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.22 |16.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:37:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:37:33 +0000 Subject: [Koha-bugs] [Bug 18016] C4::Auth_with_ldap:: ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016 --- Comment #3 from Jonathan Druart --- (In reply to Dobrica Pavlinusic from comment #2) > Seems good, but would it better to do dt_from_string on them to verify they > are also valid? It should not happen I think. If that happened, I guess some people would have raised this problem before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:40:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:40:09 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:40:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:40:13 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59695|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59727&action=edit Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59 to test patch... 1/ set date between 00:00 and 00:59 $ sudo date -s 'Sun Jan 29 00:41:55 NZDT 2017' 2/ run prove, see fail $ prove -v t/db_dependent/Members/IssueSlip.t ... t/db_dependent/Members/IssueSlip.t (Wstat: 65280 Tests: 1 Failed: 0) Result: FAIL 3/ apply patch 4/ run prove, see pass $ prove -v t/db_dependent/Members/IssueSlip.t ... All tests successful. Result: PASS NOTE: for code obscurity you could have also done a modulus 24. ;) Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 10:48:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 09:48:36 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #30 from Jonathan Druart --- Mirko, do you know what is the install_misc/debian.packages file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:08:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:08:03 +0000 Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #18 from Alex Arnaud --- Created attachment 59728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59728&action=edit Bug 17047 - Don't create numberpattern if the same exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:08:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:08:11 +0000 Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #19 from Alex Arnaud --- Created attachment 59729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59729&action=edit Bug 17047 - Remove action column from mana search result table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:09:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:09:19 +0000 Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:09:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:09:47 +0000 Subject: [Koha-bugs] [Bug 17047] Mana webservice : share and use common information between Kohas In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #20 from Alex Arnaud --- Remember, test plan is here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047#c16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:15:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:15:30 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #6 from Jonathan Druart --- One test is failing after this patch: # Failed test 'Columns is nullable in DB, not in swagger file for hold: timestamp' # at t/db_dependent/api/v1/swagger/definitions.t line 71. I also think that we should add tests to check data types, don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:35:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:35:36 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |josef.moravec at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:37:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:37:45 +0000 Subject: [Koha-bugs] [Bug 18028] New: install_dir/*.packages are outdated and must be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Bug ID: 18028 Summary: install_dir/*.packages are outdated and must be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org It seems that the install_dir/*.packages files are no longer maintained and not really useful. I would suggest to remove them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:38:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:38:00 +0000 Subject: [Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17626 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:38:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:38:00 +0000 Subject: [Koha-bugs] [Bug 17626] INSTALL files are outdated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17626 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18028 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:39:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:39:16 +0000 Subject: [Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:39:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:39:16 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 [Bug 18028] install_dir/*.packages are outdated and must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:44:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:44:53 +0000 Subject: [Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:44:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:44:59 +0000 Subject: [Koha-bugs] [Bug 18028] install_dir/*.packages are outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 --- Comment #1 from Jonathan Druart --- Created attachment 59730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59730&action=edit Bug 18028: Remove outdated install_misc directory This directory is no longer maintained and contain outdated information on how to install Koha. On the Internet there are tutos using them and that can create confusion to new user (yes it could be confusing as well to execute a file that does no longer exist). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:45:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:45:19 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|install_dir/*.packages are |install_misc directory is |outdated and must be |outdated and must be |removed |removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:49:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:49:21 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18028 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #30) > Mirko, do you know what is the install_misc/debian.packages file? Opened bug 18028 to talk about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:49:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:49:21 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17111 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 12:51:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 11:51:10 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:01:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:01:05 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #14 from Marcel de Rooy --- Thanks, Nick. You beat me in signing off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:03:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:03:01 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #14 from Marcel de Rooy --- (In reply to M. Tompsett from comment #13) > Didn't test just the first patch by itself, but tested 1&2 together and all > three together. That's why I commented like I dd in comment #8 and comment > #9. But the end product is good. :) Thanks for your feedback and signoff ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:07:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:07:01 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #5 from Marcel de Rooy --- (In reply to M. Tompsett from comment #4) > Comment on attachment 59630 [details] [review] > Bug 17982: Fix the use of uniq in sub themelanguage > > Review of attachment 59630 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Templates.pm > @@ +256,4 @@ > > my $where = $tmpl =~ /xsl$/ ? 'xslt' : 'modules'; > > for my $theme (@themes) { > > if ( -e "$htdocs/$theme/$lang/$where/$tmpl" ) { > > + return ( $theme, $lang, [ uniq(@themes) ] ); > > I'm not sure the parenthesis for uniq are necessary. Seems to be a more a matter of taste. My personal preference is parentheses, only omitting them with builtins like open or print. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:08:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:08:53 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:08:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:08:59 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59694|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59731&action=edit Bug 18018 - WWW:CSRF is missing in PerlDependencies.pm WWW:CSRF is missing in PerlDependencies.pm and so libwww-csrf-perl is missing in PerlDependencies.pm missing in debian/control. This patch adds both. NOTE: Tested on top of 17111. Checked ./koha_perl_deps.pl -m -u before and after. Control file eyeballs well. git diff origin/master -- debian/control does not differ in this change. :) Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:15:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:15:12 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > One test is failing after this patch: > > # Failed test 'Columns is nullable in DB, not in swagger file for > hold: timestamp' > # at t/db_dependent/api/v1/swagger/definitions.t line 71. > > I also think that we should add tests to check data types, don't you think? I think we might better get rid of definitions.t as there's no obvious reason why the swagger definition should match the DB. I can take care of adding 'null' as a valid type for 'timestamp' but I think we should better move that to another bug as the tests are failing without this patches too. See comment #5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:16:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:16:05 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > One test is failing after this patch: > > # Failed test 'Columns is nullable in DB, not in swagger file for > hold: timestamp' > # at t/db_dependent/api/v1/swagger/definitions.t line 71. > > I also think that we should add tests to check data types, don't you think? Also, are you sure you tested this along with bug 17932? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:17:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:17:11 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59691|0 |1 is obsolete| | --- Comment #32 from Mirko Tietgen --- Created attachment 59732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59732&action=edit Bug 17111: Update control file for 16.05 https://bugs.koha-community.org/show_bug.cgi?id=17111 NOTE: Correctly adds/removes dependencies in debian/control Signed-off-by: Mark Tompsett Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:25:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:25:05 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 --- Comment #9 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #7) > I think we might better get rid of definitions.t as there's no obvious > reason why the swagger definition should match the DB. I can take care of > adding 'null' as a valid type for 'timestamp' but I think we should better > move that to another bug as the tests are failing without this patches too. No, they pass on master. (In reply to Tom?s Cohen Arazi from comment #8) > Also, are you sure you tested this along with bug 17932? Yes I did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:50:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:50:08 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59194|0 |1 is obsolete| | Attachment #59214|0 |1 is obsolete| | Attachment #59215|0 |1 is obsolete| | --- Comment #12 from Dobrica Pavlinusic --- Created attachment 59733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59733&action=edit Bug 17933: Do not instanciate a patron if not needed Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:51:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:51:53 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59733|0 |1 is obsolete| | --- Comment #13 from Dobrica Pavlinusic --- Created attachment 59734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59734&action=edit Bug 17933 - Internal software error when searching patron without birth date When patrons don't have date of birth (which is not required) patron search results on moremember page produce internal server error since we can't convert MySQL invalid date 0000-00-00 to datetime object and call strfdate on it. Additionally, since we assign dates to template variables and after than assign whole $data hash to template, later assigment overrides previous one, so we see birth date field even for patrons which don't have one. This patch fixes both of those problems. Test: 1. edit patron and remove it's birth date 2. try to search for it, and verify server error 3. apply patch 4. repeat search for patron and verify that it works and doesn't have enpty birth date field Signed-off-by: Grace McKenzie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:52:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:52:09 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #15 from Dobrica Pavlinusic --- Created attachment 59736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59736&action=edit Bug 17933: Do not instanciate a patron if not needed Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 13:52:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 12:52:04 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #14 from Dobrica Pavlinusic --- Created attachment 59735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59735&action=edit Bug 17933: Add test and return unless defined dob Without this patch get_age return actually 0 instead of Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:01:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:01:06 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #134 from Owen Leonard --- (In reply to Jonathan Druart from comment #133) > 9/ Is this Summary info really useful? To me it looks like it should be > moved to the help part. I am not sure it worth a new entry in the "More" > menu. I agree. I wonder if we could add a persistent shortcut of some kind to the global help system? I suggest this feature be discussed in a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:09:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:09:49 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #72 from Tom?s Cohen Arazi --- Created attachment 59738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59738&action=edit Bug 13757: Make Koha::Patron::Modification->store del empty attrs This patch makes Koha::Patron::Modification->store delete the passed attributes that contain empty values. This is the way it currently works, as all opac-editable attributes are presented to the end-user and they are allowed to delete them, and the best way I found to represent the deletion on the modification request is by setting it to the empty string. I chose this way because it is how the staff interface handles it, so it is consistent. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: This time tests pass! - Verify comment #70 on the bug is fixed now - Sign off :-D Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=13737 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:09:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:09:57 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #73 from Tom?s Cohen Arazi --- Created attachment 59739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59739&action=edit Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion The original code on this bug skipped empty-valued attributes. But emptying attributes is the only way to tell the controller script that the user wants to delete them. This patch makes opac-memberentry.pl check the existence of attributes sharing the code of the empty for the given patron, and it stores the deletion on the Koha::Patron::Modification as needed. Otherwise deletions got skipped. To test: - Verify setting/deleting attributes that are opac-editable and verify the results are sound. https://bugs.koha-community.org/show_bug.cgi?id=13737 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:12:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:12:05 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Hi Petter, I'd be interested to recreate the perf issue. I have written this quick script, it generates 20 items, 200 patrons and generate a hold for each patron. On the second run, I comment everything but the last 2 lines and execute again the script. It is executed in 1.5s -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:13:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:13:37 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #6 from Colin Campbell --- Other uses of sprintf in C4::Circulation no loger have the superfluous 0 - can we fix the bug now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:24:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:24:14 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Wrong bug for attaching this patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:24:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:24:17 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:24:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:24:19 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:10:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:10:12 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #1 from Jonathan Druart --- Created attachment 59740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59740&action=edit Try to recreate CanBookBeRenewed perf issue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:24:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:24:22 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:09:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:09:42 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #71 from Tom?s Cohen Arazi --- Created attachment 59737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59737&action=edit Bug 13757: (regression tests) Empty attributes should delete existing This patch introduces tests for the required functionality. To test: - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: The current code doesn't work like that Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=13737 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:54:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:54:28 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #7 from M. Tompsett --- (In reply to Colin Campbell from comment #6) > Other uses of sprintf in C4::Circulation no loger have the superfluous 0 - > can we fix the bug now Valid counter point. Okay. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 14:58:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 13:58:48 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #3 from Petter Goks?yr ?sen --- Hi Jonathan. Thanks for looking into this! We were actually working on this problem right now, so I have some information. The code in question is quite complicated, so I'm not sure I understand it, but it seems that the pathological cases are when most of the items are checked out, so it needs to check every permutation of item, hold, and borrower to check if it can be renewed. But I'm not 100% sure about it. Rather than trying to understand how all the holds logic work in order to fix this properly, we have made a patch now, that greatly improves the speed. This is done by memoizing idempotent DB calls (GetItem, GetMembers and so on), during the scope of CanBookBeRenewed. It helps a lot, because sometimes the same item is fetched again and again, 100s to even 1000s of times from the DB! In one case, by using the patch, the display of checkout tab with 5 items goes from around 20 seconds to 3 seconds, We do belive this patch is a good step forward, but we will test it extensivly in staging environment before we submit it. I'll try see if I can get some interesting result from your script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:04:12 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #74 from Jonathan Druart --- I do not know if it comes from the last patches but I found something else. if I do not make any changes to the editable attrs, they will appear as modified anyway (entry in borrower_modifications). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:07:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:07:06 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #75 from Jonathan Druart --- Another one: 1/ Set an attr as displayed at the OPAC but not editable 2/ At the OPAC, fill the edit patron form but miss a mandatory field, submit 3/ You get the form again but the attr is not displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:07:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:07:46 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:07:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:07:49 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49907|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 59741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59741&action=edit Bug 16202: GetIssuingCharges should return a collectable amount Charges should not include elements less than a penny/cent they are not displayed but can be saved to the database causing "odd" behaviour down the line Make the routine round the resultant charge to nearest cent, so consistent values are returned. Removed the one case where it was rounded post call. Although the main danger is values generated by the discount calculation apply the rounding to all returned charges in case the item charge is defined using the 3rd or 4th decimal places. NOTE: prove -v t/db_dependent/Circulation.t triggers the change. Though, all the returned amounts are 0.00 only. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:11:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:11:35 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #4 from Jonathan Druart --- (In reply to Petter Goks?yr ?sen from comment #3) > We do belive this patch is a good step forward, but we will test it > extensivly in staging environment before we submit it. No do not wait, release as soon as you can :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:22:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:22:07 +0000 Subject: [Koha-bugs] [Bug 18024] Adding a "genres and kinds" search in Authorities module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18024 --- Comment #1 from Alexandre --- A little correction, according to my partner Marjorie, the exact search term is "genre / form term". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:24:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:24:40 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #5 from Petter Goks?yr ?sen --- (In reply to Jonathan Druart from comment #4) > No do not wait, release as soon as you can :) OK, for the adventurous: https://gist.github.com/boutros/c3a63904c788d0a6336023042ce22cde We recently hired a very experienced Perl guy, so he's behind this, not me:) But it's very simple actually: just by decorating subroutines with ": PureFunction" - you get memoization for free! The actuall PureFunctions module is maybe not for the faint of heart, but it's very small, and I do belive it works out very beautifull. And as this is not a persistent cache, but only valid during the scope of the request, we don't have to deal with cache invalidation and such problems. The solution can easily be extended to other Getter-methods, as long as they are idempotent (which they should be). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:27:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:27:08 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #135 from M. Tompsett --- (In reply to Owen Leonard from comment #134) > I wonder if we could add a persistent shortcut of some kind to the > global help system? I suggest this feature be discussed in a separate bug. Yes, points 7-9 are valid issues, but probably removing summary from this, and discussing perhaps a simplified basics help page on another bug might be in order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:29:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:29:36 +0000 Subject: [Koha-bugs] [Bug 18024] Adding a "genres and kinds" search in Authorities module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18024 --- Comment #2 from Alexandre --- Marc reference marc http://www.loc.gov/marc/authority/ad155.html In the Koha of Bywater : http://catalog.bywatersolutions.com/cgi-bin/koha/opac-authorities-home.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:33:50 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #136 from M. Tompsett --- Created attachment 59742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59742&action=edit Bug 17855: Follow-up on broken xt test Apologies for missing that. Here is a patch for point 2 in comment #133. TEST PLAN --------- 1) apply all except this patch 2) prove xt -- a failure 3) apply this patch 4) prove xt -- no failures 5) prove t -- only prices fails on master, and is unrelated to this patch. 6) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:35:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:35:03 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #137 from M. Tompsett --- (In reply to M. Tompsett from comment #136) > Created attachment 59742 [details] [review] > Bug 17855: Follow-up on broken xt test > > Apologies for missing that. Here is a patch for point 2 in > comment #133. Though, this will need to be modified further to address point 1 in comment #133. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 15:50:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 14:50:59 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #6 from Jonathan Druart --- Hum, are you sure this is Plack-compatible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:33:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:33:56 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use templates for |Use templates for |generating pagination |generating pagination in | |intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:34:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:34:54 +0000 Subject: [Koha-bugs] [Bug 18029] New: Use templates for generating pagination in opac Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029 Bug ID: 18029 Summary: Use templates for generating pagination in opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:35:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:35:21 +0000 Subject: [Koha-bugs] [Bug 18029] Use templates for generating pagination in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |josef.moravec at gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:35:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:35:21 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18029 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:35:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:35:59 +0000 Subject: [Koha-bugs] [Bug 18030] New: Get rid of pagination_bar sub in C4::Output Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18030 Bug ID: 18030 Summary: Get rid of pagination_bar sub in C4::Output Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:36:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:36:25 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18030 [Bug 18030] Get rid of pagination_bar sub in C4::Output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:36:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:36:25 +0000 Subject: [Koha-bugs] [Bug 18029] Use templates for generating pagination in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18030 [Bug 18030] Get rid of pagination_bar sub in C4::Output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:36:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:36:25 +0000 Subject: [Koha-bugs] [Bug 18030] Get rid of pagination_bar sub in C4::Output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18030 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18008, 18029 Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 [Bug 18008] Use templates for generating pagination in intranet https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029 [Bug 18029] Use templates for generating pagination in opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:37:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:37:34 +0000 Subject: [Koha-bugs] [Bug 18031] New: Update bootstrap in opac Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18031 Bug ID: 18031 Summary: Update bootstrap in opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:38:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:38:01 +0000 Subject: [Koha-bugs] [Bug 18029] Use templates for generating pagination in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18031 [Bug 18031] Update bootstrap in opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 16:38:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 15:38:01 +0000 Subject: [Koha-bugs] [Bug 18031] Update bootstrap in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18031 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029 [Bug 18029] Use templates for generating pagination in opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:36:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 16:36:53 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:36:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 16:36:56 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59392|0 |1 is obsolete| | Attachment #59393|0 |1 is obsolete| | Attachment #59713|0 |1 is obsolete| | Attachment #59714|0 |1 is obsolete| | --- Comment #55 from Nick Clemens --- Created attachment 59743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59743&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:37:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 16:37:02 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #56 from Nick Clemens --- Created attachment 59744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59744&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:37:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 16:37:08 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #57 from Nick Clemens --- Created attachment 59745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59745&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:37:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 16:37:14 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #58 from Nick Clemens --- Created attachment 59746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59746&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 17:38:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 16:38:28 +0000 Subject: [Koha-bugs] [Bug 17717] process_message_queue.pl: Can't locate Authen/CAS/Client/ Response/Failure.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 alfre69 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alfre at ibdinternet.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 18:39:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 17:39:37 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #7 from Petter Goks?yr ?sen --- (In reply to Jonathan Druart from comment #6) > Hum, are you sure this is Plack-compatible? It should be. I've been testing under Plack today without experiencing any issues, and it certainly seems to work fine. But I haven't profiled for memory leaks yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:34:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 18:34:35 +0000 Subject: [Koha-bugs] [Bug 18032] New: make test fail 'DBIx::Class::Storage::DBI' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18032 Bug ID: 18032 Summary: make test fail 'DBIx::Class::Storage::DBI' Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: jane.chang at cwts.edu QA Contact: testopia at bugs.koha-community.org root at debian-w01:/home/kohasysusr/Downloads/koha-16.05.09# make test PERL_DL_NONLAZY=1 KOHA_CONF=blib/KOHA_CONF_DIR/koha-conf.xml "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/PERL_MODULE_DIR', 'blib/arch')" t/*.t t/00-checkdatabase-version.t ........ ok t/00-deprecated.t ................... ok t/00-load.t ......................... 1/? DBIx::Class::ResultSet::find(): Your storage class (DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI' . at /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR/Koha/Objects.pm line 83 t/00-load.t ......................... 196/? # Failed test 'use Koha::Token;' # at t/00-load.t line 64. # Tried to use 'Koha::Token'. # Error: Can't locate WWW/CSRF.pm in @INC (@INC contains: /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR /home/kohasysusr/Downloads/koha-16.05.09/blib/arch /usr/share/koha/lib /usr/share/koha/lib /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl . /var/lib/koha/plugins /var/lib/koha/plugins) at /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR/Koha/Token.pm line 53. # BEGIN failed--compilation aborted at /home/kohasysusr/Downloads/koha-16.05.09/blib/PERL_MODULE_DIR/Koha/Token.pm line 53. # Compilation failed in require at t/00-load.t line 64. # BEGIN failed--compilation aborted at t/00-load.t line 64. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Token' FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Token' make: *** [test_dynamic] Error 255 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:34:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 18:34:49 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #6 from M. Tompsett --- Created attachment 59747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59747&action=edit Bug 17982: Improve test coverage This test triggers the three cases that were modified. prove -v t/db_dependent/Templates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:39:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 18:39:39 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59747|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 59748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59748&action=edit Bug 17982: Improve test coverage This test triggers the three cases that were modified. prove -v t/db_dependent/Templates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:40:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 18:40:57 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59630|0 |1 is obsolete| | --- Comment #8 from M. Tompsett --- Created attachment 59749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59749&action=edit Bug 17982: Fix the use of uniq in sub themelanguage Doing uniq( \@themes ) is useless. It will just return to you the only reference you gave it. List::MoreUtils::uniq requires a list instead of an arrayref. So it is a trivial fix that makes sub themelanguage return one theme instead of three themes like [ 'prog', 'prog', 'prog' ]. Note that Template->new inserts one or two include paths to TT for each of these three identical themes. Note: Removed a overcomplete unit test that basically tested uniq with uniq in order to remove a dependency for a more important bug report. Test plan: [1] Run t/db_dependent/Auth.t (triggering themelanguage) [2] Open a page on OPAC or intranet. (Did you restart Plack?) Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 19:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 18:48:53 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59748|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Created attachment 59750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59750&action=edit Bug 17982: Improve test coverage This test triggers the three cases that were modified. prove -v t/db_dependent/Templates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:45:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:45:20 +0000 Subject: [Koha-bugs] [Bug 18033] New: If/ else sometimes does not make sense after koha account system refactoring Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Bug ID: 18033 Summary: If/else sometimes does not make sense after koha account system refactoring Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Patch folowing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:46:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:46:10 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15894 Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 [Bug 15894] Unify all account fine payment functions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:46:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:46:10 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18033 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 [Bug 18033] If/else sometimes does not make sense after koha account system refactoring -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:51:52 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59730|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 59751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59751&action=edit Bug 18028: Remove outdated install_misc directory This directory is no longer maintained and contain outdated information on how to install Koha. On the Internet there are tutos using them and that can create confusion to new user (yes it could be confusing as well to execute a file that does no longer exist). NOTE: last tweak was mid 2016, but before that 2015. So I agree with the deletion. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:51:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:51:49 +0000 Subject: [Koha-bugs] [Bug 18028] install_misc directory is outdated and must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18028 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:52:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:52:18 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 --- Comment #1 from Josef Moravec --- Created attachment 59752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59752&action=edit Bug 18033: Remove duplicate code in paycollect.pl Test plan: 0) apply the patch 1) try to pay individual fee, with full amount and partial amount it should work the same as before patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:52:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:52:55 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 20:53:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 19:53:26 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:08:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:08:44 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #22 from Alex Buckley --- (in reply to Jonathan Druart in comment 21) 1/ What tests specifically do you want? 3/ I tried '->is_used' but it threw a strict refs error (as this is my first time writing perl subroutines I tried a different subroutine name (get_items_and_biblioitems) which worked successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:14:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:14:44 +0000 Subject: [Koha-bugs] [Bug 17802] Hea - Add geolocation information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17802 Nate changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nate at bywatersolutions.com --- Comment #1 from Nate --- I think this is a great idea! The only thing we need to be sure of is that the interface to add this location information is user friendly enough so that the librarians and/or support companies can easily add that info in. Great thinking! >From a technical standpoint, I cannot comment on the feasibility of this so hopefully someone else can! -Nate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:19:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:19:50 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #23 from Alex Buckley --- (in reply to Jonathan Druart in comment 21) 1/ Presumably you mean test plan rather than the output of a qa test? If so the test plan is slightly modified from comment 5) Test plan: 1. In the staff interface, stage and manage MARC records for import 2. Try to delete an itemtype. If there are items of that itemtype in the database then a message telling you the number of items of that itemtype there are will be displayed. 3. Record that number 4. View the admin/itemtpes.pl script and confirm that there is sql code written in this file. 5. Apply this patch 6. View the admin/itemtypes.pl script and observe that there is no sql in this file. Confirm there is a module call my $overalltotal = Koha::ItemType->get_items_and_biblioitems($itemtype_code) 7. Go to Koha/ItemType.pm and confirm that there is a function named get_items_and_biblioitems 8. In the staff interface try to delete the same itemtype 9. Record the number of items there are with that itemtype in the resulting message 10. The numbers recorded in steps 3 and 9 should match showing that the DBIx code in the get_items_and_biblioitems subroutine is working as intended -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:23:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:23:14 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #10 from Marcel de Rooy --- Mark, Thx for signoff but please explain what the second test has to do with the first patch? You are testing language, but the change is about not duplicating themes by proper use of uniq. Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:24:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:24:42 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #138 from Alex Buckley --- (in reply to Jonathan Druart and Owen Leonard in comment 133 and 134) Just to clarify a few of your points: Re: point 5: "5/ You copied some existing javascript functions to onboardingstep2.tt. Do not duplicate existing code." Do you want me to remove the JavaScript functions and or will fixing the indentation be sufficient to pass QA? Re: point 9: What is the final decision on summary info. To get this signed off and through QA are both of you happy for me to remove summary.pl and summary.tt. And they can be added in a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:25:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:25:34 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #11 from Marcel de Rooy --- Apart from that, it fails too: # Subtest: Test C4::Templates::themelanguage 1..4 not ok 1 - Expected language: non-en # Failed test 'Expected language: non-en' # at t/db_dependent/Templates.t line 68. # got: 'en' # expected: 'fr-FR' ok 2 - Expected language: default en ok 3 - Expected language: unset ok 4 - Expected language: not coded for # Looks like you failed 1 test of 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:26:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:26:05 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #12 from Marcel de Rooy --- Do not assume that fr-FR exists. I dont have it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:27:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:27:18 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #13 from Marcel de Rooy --- Mock::FileSystem ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:31:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:31:54 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #139 from Alex Buckley --- (in reply to Jonathan Druart and M.Tompsett in comment 133, 136 and 137 and 17855) As I am still learning Koha can I please have a more specific explanation of the issue(s) which you addressed in points 1 and 2? And possible solutions thereof -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:37:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:37:23 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #14 from M. Tompsett --- (In reply to Marcel de Rooy from comment #10) > Thx for signoff but please explain what the second test has to do with the > first patch? You are testing language, but the change is about not > duplicating themes by proper use of uniq. You changed 3 lines of code, this test triggers those three lines of code. However, you rightly pointed out fr-FR might not exist. Shoot. :( If it does exist, it triggers the three cases you changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:38:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:38:53 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #15 from M. Tompsett --- (In reply to Marcel de Rooy from comment #13) > Mock::FileSystem ? That looks promising. I'll try something in about 2 hours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:41:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:41:37 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:47:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:47:53 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59173|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 59753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59753&action=edit [SIGNED-OFF] Bug 17934: Make t/db_dependent/www/auth_values_input_www.t awesome There were two lines of code which declared unused variables. They were removed. Next, the issue of double planning encountered on bug 17540 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540#c3) was encountered. So this corrects that and adds a little more error handling into the whole C4::Context using process so that perlcritic -4 is achieved. Also typo on Korean in a comment. TEST PLAN --------- 2) follow these commands: $ mv C4/Context.pm C4/Context_backup.pm $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ mv C4/Context_backup.pm C4/Context.pm $ sudo koha-shell -c "export PERL5LIB=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ sudo koha-shell -c "export KOHA_CONF=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"http://localhost:8080/\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should work. $ perlcritic -4 t/db_dependent/www/auth_values_input_www.t -- This should be OK 2) apply patch 3) follow these commands: $ mv C4/Context.pm C4/Context_backup.pm $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should trigger the C4::Context not working message $ mv C4/Context_backup.pm C4/Context.pm $ sudo koha-shell -c "export PERL5LIB=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should trigger the C4::Contxt not loading message $ sudo koha-shell -c "export KOHA_CONF=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should trigger the KOHA_CONF not set message $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- These should both trigger the KOHA_INTRANET_URL not set message $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"http://localhost:8080/\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should work. $ perlcritic -4 t/db_dependent/www/auth_values_input_www.t -- This should be OK 3) run koha qa test tools Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 21:47:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 20:47:50 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:02:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:02:43 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Barton Chittenden --- I believe that this may also cause fragmenting of CHECKOUT, RENEWAL and CHECKIN messages. These are digest messages, which should accumulate detail about their respective circ action in message_queue.metadata until process_message_queue.pl runs. We have seen evidence of multiple RENEWAL messages going out in very short order... it would be normal for process_message_queue.pl to be running while items are being checked in our out, causing two messages to be sent, but we have had evidence of 3 messages sent at the same time, which isn't possible unless the message_queue is being processed by two separate instances of process_message_queue.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:03:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:03:10 +0000 Subject: [Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #1 from Josef Moravec --- References to schema website are in these 3 files: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:07:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:07:22 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #24 from Alex Buckley --- (in reply to Jonathan Druart in comment 21) Please disregard comment 22, I have fixed the strict refs error issue. In the commit I am currently working on I have addressed your following points 2, and 3. Could you please explain what you mean in your point 5? Are you asking why I havent put the is_used subroutine in the Koha::Items and Koha::Biblioitems files? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:08:49 +0000 Subject: [Koha-bugs] [Bug 18034] New: Pseudonym records not found in a research by author Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18034 Bug ID: 18034 Summary: Pseudonym records not found in a research by author Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Created attachment 59754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59754&action=edit Page with "see also" links ("Voir aussi :") It's probably a minor bug. If you make a search with this author, your search will normally give you the records linked to the pseudonyms of the name. But in our searches, these pseudonyms records don't appear in the results of an author search even if the links "see also" were created previously. I will take an example that almost all of us will know. The author of Harry Potter wrote under many names : Robert Galbraith, Newt Scamander and Kennilworthy Whisp. All these names are normally linked between them by a "see also" mention. (The link must be done previously during cataloging. Sadly, not so many of us did all this up here.) Here is the way to check if you have links "see also" already created. 1) In an OPAC, make a search with J. K. Rowling 2) Observe that all results are directly related to J. K. Rowling 3) Clic on a book writen by this author (not a movie) 4) Just under the title of the record, you have the mention "author" with a magnifying glass, clic on the magnifying glass 5) You will see all forms the name can take and under we have the "see also" mentions (if created) 6) If they are created, you can clic normally on these names. 7) A page appears with a mention something like "Authorities search results" (we have it in french) 8) In the third column of the board, it's indicated "Bibliographic records", you can clic on the results just under ("x documents") 9) In my particulary case, I took Robert Galbraith for which we have 3 records (maybe they are more) : Career of evil, Silkworm and Cuckoo's calling. 10) If I return to my first results for J. K. Rowling, I cannot see these three books anywhere... Records with a pseudonym name (in the "see also" links) should appear in the record results of an author. Some people here suggest to create a system preference like "IncludeSeeFromInSearches" to find the records in the "see also" links. Thanks, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:15:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:15:08 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:15:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:15:12 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54532|0 |1 is obsolete| | Attachment #58559|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 59755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59755&action=edit [SIGNED-OFF] Bug 17138 - UpdateFine() modyfies existing fine records even when there is no need In C4/Overdues.pm: 574: # we're updating an existing fine. Only modify if amount changed 577: if ( $data->{'amount'} != $amount ) { for some numbers (e.g. 5.60) the comparison in line 577 fails ($data->{'amount'} is decimal(28,6) i.e. a string, and $amount may be a floating point number with no exact binary representation). E.g. when the fine amounts are multiple of 0.20, it fails for the 33.3% of the amounts (on average). Depending on the fine charging settings, this may trigger unnecessary database writes (and a lot of them). If 'Fine Charging Interval' is 1 day, this has very little practical consequences (misc/cronjobs/fines.pl script is usually run once per day, and all fines need an increase anyway). But if the charging interval is longer, e.g. 7 days, in a given day amount changes only for the 1/7 of the fines (again, on average), and over 60% of the database writes would be redundant. To reproduce: 1) run misc/cronjobs/fines.pl 2) add warn "AMOUNT ".$data->{'amount'}." vs $amount"; below line 577 in C4/Overdues.pm 3) run misc/cronjobs/fines.pl again 4) you'll see some warnings like 'AMOUNT 5.600000 vs 5.6' or: dump accountlines table after step 1), run the script 2nd time, dump the table again and compare the contents - some of the records would have a different timestamp. To test: 1) apply patch 2) redo steps 1) - 4) above 3) no more warnings in step 4 4) 2nd run of misc/cronjobs/fines.pl should be noticeably faster Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:15:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:15:24 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 --- Comment #13 from Josef Moravec --- Created attachment 59756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59756&action=edit [SIGNED-OFF] Bug 17138: Add and use comparison function and tests Added C4::Koha::compareNumbers($n1,$n2,$accuracy). Added corresponding tests to t/Koha.t Tweaked C4/Overdues to use the new function. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:24:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:24:01 +0000 Subject: [Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oha at oha.it --- Comment #8 from Francesco Rivetti --- Hi! I can't think of any issue with plack or apache. The only problem I had implementing it is the race with Exporter: Attribute::Handlers apply attributes at CHECK time, while Exporter at BEGIN time. I found a easy way to convince A::H to replace the methods at BEGIN time, but I believe the order in the @ISA must be preserved. But I don't consider this a proper fix, I just lack the experience to understand the whole logic behind it yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:39:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:39:10 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58985|0 |1 is obsolete| | Attachment #58986|0 |1 is obsolete| | Attachment #58987|0 |1 is obsolete| | Attachment #58988|0 |1 is obsolete| | Attachment #58989|0 |1 is obsolete| | Attachment #58990|0 |1 is obsolete| | Attachment #58991|0 |1 is obsolete| | Attachment #58992|0 |1 is obsolete| | --- Comment #66 from Josef Moravec --- Created attachment 59757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59757&action=edit Bug 8612: Use CSV profile for exporting basket This patch allows the user to use a CSV export profile to create the fields to export the basket as CSV in a basket page. Test plan: 1) Apply the patch 2) Go to Tools ? CSV export profiles and create a profile of type "SQL for basket export in acquisition" example: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) In acquisition module, create a new basket and add an order to the basket 4) On basket detail page, there should be the split button labelled "Export to CSV" 5) Try to use the button and export CSV with your CSV profile you defined in step 2 6) Validate the CSV file. 7) Repeat 4-6 with a closed basket. a) close the basket b) View the basket c) validate that there is an export button d) test it with an export 8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t t/db_dependent/Koha/CsvProfiles.t Initial work: Sponsored by: CCSR Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:40:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:40:42 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #67 from Josef Moravec --- (In reply to Blou from comment #65) > Josef, > I'd be happy to have someone in our team test and sign this, but right now I > get a > Applying: Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug > 15451) > fatal: sha1 information is lacking or useless (C4/Acquisition.pm). > > Damn sha1... > Making one big patch out of it would probably limit future rebases, btw, > since a lot of these do-undo-redo the same code... > > Reminder for the initial work: > > **** > Sponsored by : CCSR > **** I squashed the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:59:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:59:51 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 22:59:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 21:59:55 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59543|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 59758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59758&action=edit [SIGNED-OFF] Bug 17988 - Select2 prevents correct tag expand/minimize functionality Overview: Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. Because of that, expanding fields to show all hidden subfields does not work properly. Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Try to minimize or expand fields, that have among subfields the following: ? Thesaurus driven subfield ? subfield with Select2 ? Hidden subfield. Actual Results: ?? some fields become hidden, some not, and vice versa ?? in the console, you'll see ?Uncaught TypeError: Cannot read property 'match' of null? Expected Results: ?? all subfields should minimize/maximize completely Additional Information: This happens because Select2 adds some divs, that do not have ID property. The following patch adds check for the needed attribute existance. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:00:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 22:00:41 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec --- I was able to reproduce the problem with field 942, with this patch it is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:08:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 22:08:28 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #51 from Katrin Fischer --- (In reply to Jonathan Druart from comment #50) > I'd like to get feedbacks about these few questions: > 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes? I think the initial devs might not have been aware of our terminology: https://wiki.koha-community.org/wiki/Terminology Could we fix this later on in a separate patch later on? This has been taking a long time already. > 2. Does everybody think that "PATRON_NOTE" template code is meaningful > enough? Don't have a better idea right now - it matches how it's called in the GUI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:23:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 22:23:30 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #7 from Josef Moravec --- There is missing content in opac-maint.tt, nad intranet-main.tt see git grep koha_new.new -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:37:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 22:37:26 +0000 Subject: [Koha-bugs] [Bug 17512] Improve handling dates in C4::Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:37:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 22:37:30 +0000 Subject: [Koha-bugs] [Bug 17512] Improve handling dates in C4::Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56920|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 59759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59759&action=edit [SIGNED-OFF] Bug 17512: Improve handling dates in C4::Items This is a follow-up on the internal server error on 0000-00-00 in the items column onloan. This patch deals with preventing to have such dates at all in the date fields of items. It is accomplished by: [1] Adding a (private) subroutine _mod_item_dates. It takes an item hash and replaces date values if needed. [2] AddItem and ModItem call _koha_new_item resp. koha_modify_item. In these routines a call to the new _mod_item_dates is inserted. [3] Although the routine is actually private, I have added some unit tests to Items.t. Test plan: [1] Add a new item. Fill a correct date in dateaccessioned and an invalid date in Price effective from (=replacementpricedate). [2] Verify that dateaccessioned is saved correctly and replacementpricedate is still null (does not contain 0000-00-00). [3] Edit the item again. Fill some text in dateaccessioned and put a correct date in replacementpricedate. Verify the results. [4] Run t/db_dependent/Items.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:56:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 22:56:17 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59750|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Comment on attachment 59750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59750 Bug 17982: Improve test coverage Because there is no easy way to mock the file system. I'll just forget this, and sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Feb 1 23:56:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 22:56:51 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 00:12:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 23:12:15 +0000 Subject: [Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 00:12:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 Feb 2017 23:12:19 +0000 Subject: [Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025 --- Comment #1 from Liz Rea --- Created attachment 59760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59760&action=edit Bug 18025 - Expired password recovery links cause sql crash When a user gets an email, but doesn't act or visit it within two days, attempting to create a new one causes a collision. We should just delete the old one, assuming they still want to reset their password. To test: create yourself a borrower with a userid and password. Attempt a password recovery on the OPAC update the entry in the database for that user to have an expired token e.g. update borrower_password_recovery set valid_until = '2017-01-25 03:25:26' where borrowernumber = 12; Attempt another password recovery operation - should error apply the patch Try it again - no error, new token is generated and additional email with new link is sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:16:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 01:16:40 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I'm not sure I understand this bug, but I'm very much in favour of creating more standardized ways of paginating in Koha, especially in the staff client... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 02:45:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 01:45:27 +0000 Subject: [Koha-bugs] [Bug 14536] PageObject-pattern base implementation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #23 from Aleisha Amohia --- Please provide a test plan so someone can test this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 03:58:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 02:58:53 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59641|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia --- Created attachment 59761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59761&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:00:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:00:54 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #53 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #50) > (In reply to Jonathan Druart from comment #41) > > Aleisha, it seems that your last patch kept the 2 subroutines in C4::Items. > > Since you are not using them, you can remove them. > > Note that this is still valid, C4::Circulation::GetItemIssues is readded by > your patch whereas it has been removed by bug 17679. Fixed in the latest patch. (In reply to Katrin Fischer from comment #51) > (In reply to Jonathan Druart from comment #50) > > I'd like to get feedbacks about these few questions: > > 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes? > > I think the initial devs might not have been aware of our terminology: > https://wiki.koha-community.org/wiki/Terminology > Could we fix this later on in a separate patch later on? This has been > taking a long time already. I agree with Katrin - any other additional comments about language etc. can be fixed once this has passed, but would really like to get this through. Reattached patch removes the GetItemIssues from the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:09:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:09:18 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:09:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:09:21 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59638|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 59762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59762&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:26:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:26:31 +0000 Subject: [Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #19 from Liz Rea --- Hi Julian, It seems patches 2 and 3 have snuck back into 3.22.15, have a look please? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:43:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:43:43 +0000 Subject: [Koha-bugs] [Bug 18035] New: Front-end changes to serials -> Claims Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Bug ID: 18035 Summary: Front-end changes to serials -> Claims Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Some small enhancements for the user experience - datatable - use of breadcrumbs for adding/modifying form - bootstrap 3 buttons on adding/modifying form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:47:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:47:50 +0000 Subject: [Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:47:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:47:53 +0000 Subject: [Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 --- Comment #1 from Aleisha Amohia --- Created attachment 59763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59763&action=edit Bug 18035: Front-end changes to serials -> Claims This patch: 1) Uses datatables functionality on numbering patterns table 2) Shows breadcrumbs when using the form to add or modify numbering patterns 3) Updates the Save, Reset, and Test Pattern buttons in the form to be bootstrap 3 buttons To test: 1) Confirm that datatable sorting works on all columns EXCEPT Actions column 2) Click 'New numbering pattern' 3) Confirm breadcrumbs reads 'New numbering pattern' 4) Go back to numbering patterns and Edit an existing one 5) Confirm breadcrumbs reads 'Modifying number pattern '' 6) Confirm Save, Reset and Test pattern buttons now show as bootstrap3 buttons 7) Confirm all buttons work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:48:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:48:00 +0000 Subject: [Koha-bugs] [Bug 18035] Front-end changes to serials -> Claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18035 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 04:54:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 03:54:11 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #140 from M. Tompsett --- (In reply to Alex Buckley from comment #139) > (in reply to Jonathan Druart and M.Tompsett in comment 133, 136 and 137 and > 17855) > > As I am still learning Koha can I please have a more specific explanation of > the issue(s) which you addressed in points 1 and 2? > > And possible solutions thereof Non-English template files are generated from the English ones. When you moved the English ones, did you check (sorry, I forgot to check) if you could generate another language and run through the onboarding tool? This is not necessarily related, but I thought I'd mention it. Too often, English speakers (myself included) fail to test other languages as well. In fact, we need to test for all the languages that we do have. Also, you've modified the mandatory/optional directory structure and locations of the English files. It is probably a good idea to keep the structures aligned across all languages. Again, we'll need to test for all the languages that we do have. My follow up on the broken xt test makes the broken test pass. However, any changes as triggered above, may required further changes to the same test. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:18:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 04:18:28 +0000 Subject: [Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:18:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 04:18:31 +0000 Subject: [Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 --- Comment #1 from Aleisha Amohia --- Created attachment 59764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59764&action=edit Bug 14405: Add datatables to fines table in OPAC To test: 1) Apply patch 2) Go to OPAC -> Your account 3) Confirm you can now sort on all columns Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:18:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 04:18:39 +0000 Subject: [Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 04:41:15 +0000 Subject: [Koha-bugs] [Bug 18032] make test fail 'DBIx::Class::Storage::DBI' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18032 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #1 from Mason James --- hi Jane if you are try to 'make test' a Koha, you will need all it's required packages too to pass some tests you can get all packages with the following command... $ sudo apt-get install koha-deps koha-perldeps -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 05:41:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 04:41:34 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #141 from Alex Buckley --- (in reply to M.Tompsett in comment 133 and M.Tompsett in comment 140) Yes thanks, I also asked elsewhere. I am currently working through the issues in comment 133 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:25:06 +0000 Subject: [Koha-bugs] [Bug 17512] Improve handling dates in C4::Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 --- Comment #5 from Marcel de Rooy --- Thanks Josef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:30:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:30:59 +0000 Subject: [Koha-bugs] [Bug 17802] Hea - Add geolocation information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17802 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec --- I am for it, it could be useful. I think if libraries could set their position just by clicking on the map, many of then do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:53:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:53:17 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #17 from Marcel de Rooy --- Created attachment 59765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59765&action=edit Bug 17982: Expose wrong use of uniq This test should fail without the patch fixing the uniq calls. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:53:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:53:21 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59749|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 59766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59766&action=edit Bug 17982: Fix the use of uniq in sub themelanguage Doing uniq( \@themes ) is useless. It will just return to you the only reference you gave it. List::MoreUtils::uniq requires a list instead of an arrayref. So it is a trivial fix that makes sub themelanguage return one theme instead of three themes like [ 'prog', 'prog', 'prog' ]. Note that Template->new inserts one or two include paths to TT for each of these three identical themes. Test plan: [1] Run t/db_dependent/Templates.t (should no longer fail) [2] Run t/db_dependent/Auth.t (triggering themelanguage) [3] Open a page on OPAC or intranet. (Did you restart Plack?) Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett EDIT (Marcel): Amended test plan for additional unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:54:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:54:27 +0000 Subject: [Koha-bugs] [Bug 18036] New: Improve test coverage for themelanguage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Bug ID: 18036 Summary: Improve test coverage for themelanguage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com See bug 17982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:54:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:54:48 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:54:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:54:56 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #25 from Jonathan Druart --- (In reply to Alex Buckley from comment #22) > (in reply to Jonathan Druart in comment 21) > > 1/ What tests specifically do you want? When a subroutine or a method is added or updated, we need to provide tests ("unit tests") in the t directory. For a method like "Koha::ItemType->is_used" you will want to add tests to t/db_dependent/Koha/ItemTypes.t. Create a new subtest per method is a good idea (`git grep subtest t` to see examples) In your case you want to test that this new method returns true if at least 1 item and/or 1 biblioitem is using it. Otherwise it returns false. (In reply to Alex Buckley from comment #24) > (in reply to Jonathan Druart in comment 21) > Could you please explain what you mean in your point 5? Are you asking why I > havent put the is_used subroutine in the Koha::Items and Koha::Biblioitems > files? Instead of using $schema->resultset('Item')->search you can use Koha::Items->search We have Koha objects to represent our data model, so when they exist (Koha::Items and Koha::Biblioitems do exist) it's better to use them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:55:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:55:05 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 [Bug 17982] Fix the use of uniq in sub themelanguage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:55:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:55:05 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18036 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 [Bug 18036] Improve test coverage for themelanguage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 08:55:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 07:55:15 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:13:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:13:49 +0000 Subject: [Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 --- Comment #20 from Julian Maurice --- (In reply to Liz Rea from comment #19) > It seems patches 2 and 3 have snuck back into 3.22.15, have a look please? Yes, they are. They were reverted just after the 3.22.15 release, so it should be ok in 3.22.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:18:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:18:46 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #1 from Marcel de Rooy --- Created attachment 59767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59767&action=edit Bug 18036: Improve test coverage for themelanguage This test triggers the three cases that were modified. prove -v t/db_dependent/Templates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:19:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:19:29 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- (In reply to Josef Moravec from comment #13) > Created attachment 59756 [details] [review] > [SIGNED-OFF] Bug 17138: Add and use comparison function and tests I think you should use Number::Format instead of creating a new subroutine. In any cases I am pretty sure that C4::Koha is the wrong place to put it in :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:19:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:19:32 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #2 from Marcel de Rooy --- Saved a kitten for you, Mark. But still needs some polishing.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:19:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:19:39 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:22:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:22:53 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #8 from Jonathan Druart --- Created attachment 59768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59768&action=edit Bug 17960: Replace missing occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:23:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:23:18 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:47:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:47:02 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:47:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:47:07 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 --- Comment #2 from Josef Moravec --- Created attachment 59769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59769&action=edit Bug 18008: Make pagination generated in templates It generates pagination in bootstrap style (as bug 18005 also do) Modified pages: acqui/neworderbiblio.pl authorities/authorities-home.pl catalogue/itemsearch.pl cataloguing/addbooks.pl cataloguing/value_builder/marc21_linking_section.pl cataloguing/value_builder/unimarc_field_210c.pl cataloguing/value_builder/unimarc_field_4XX.pl reports/guided_reports.pl reviews/reviewswaiting.pl tags/review.pl virtualshelves/shelves.pl note, that on itemsearch.pl, this pagination is used just as fallback when the javascript is off Test plan: 0) Apply the patch 1) go through pages from the list above/use cataloguing plugins, and make the data to be big enough for pagination 2) confirm that pagination looks nice and behave correctly 3) git grep pagination_bar should return just C4/Output.pm and opac templates (I'll deal with it on another bugs) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:49:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:49:43 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jane.chang at cwts.edu --- Comment #4 from Jonathan Druart --- *** Bug 18032 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:49:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:49:43 +0000 Subject: [Koha-bugs] [Bug 18032] make test fail 'DBIx::Class::Storage::DBI' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 18018 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:52:17 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 --- Comment #3 from Josef Moravec --- (In reply to David Cook from comment #1) > I'm not sure I understand this bug, but I'm very much in favour of creating > more standardized ways of paginating in Koha, especially in the staff > client... Thank for your interest, any feedback is appreciated, of course ;) Here is my first attempt to make pagination a bit more usable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:52:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:52:30 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #10 from Jonathan Druart --- Chris, do you know if this circ-hlt class is still useful? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 09:56:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 08:56:24 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #39 from Jonathan Druart --- Liz: Is this: if (defined $input->param('branch') and length $input->param('branch')) { $homebranch = $input->param('branch'); } if (C4::Context->userenv and defined $input->param('branch') and length $input->param('branch') == 0 ){ $homebranch = ""; } could actually be: if (defined $input->param('branch') and length $input->param('branch')) { $homebranch = $input->param('branch'); } elsif (C4::Context->userenv and defined $input->param('branch') ) { $homebranch = ""; } ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:09:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:09:33 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to M. Tompsett from comment #8) > NOTE: prove -v t/db_dependent/Circulation.t triggers the change. > Though, all the returned amounts are 0.00 only. Where? I did not find it. I am not sure this is the correct way to fix it, but definitely the quicker and more efficient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:10:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:10:09 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #10 from Jonathan Druart --- Should not we rephrase the comment without "penny", to make it more international? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:19:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:19:45 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 --- Comment #4 from Jonathan Druart --- Comment on attachment 59753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59753 [SIGNED-OFF] Bug 17934: Make t/db_dependent/www/auth_values_input_www.t awesome Review of attachment 59753: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17934&attachment=59753) ----------------------------------------------------------------- ::: t/db_dependent/www/auth_values_input_www.t @@ +167,4 @@ > $add_form_link_exists = 0; > $delete_form_link_exists = 0; > for my $link ( $agent->links() ) { > + if ( $link->url =~ m/authorised_values.pl\x3Fop=add_form&category=$category/xsm ) { Really? This is terrible. I do not see the point to follow perlcritic -1 if it's to introduce such things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:29:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:29:11 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59758|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 59770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59770&action=edit Bug 17988 - Select2 prevents correct tag expand/minimize functionality Overview: Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. Because of that, expanding fields to show all hidden subfields does not work properly. Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Try to minimize or expand fields, that have among subfields the following: ? Thesaurus driven subfield ? subfield with Select2 ? Hidden subfield. Actual Results: ?? some fields become hidden, some not, and vice versa ?? in the console, you'll see ?Uncaught TypeError: Cannot read property 'match' of null? Expected Results: ?? all subfields should minimize/maximize completely Additional Information: This happens because Select2 adds some divs, that do not have ID property. The following patch adds check for the needed attribute existance. Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:29:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:29:07 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:29:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:29:15 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 --- Comment #5 from Jonathan Druart --- Created attachment 59771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59771&action=edit Bug 17988: Add a comment to explain the line Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:33:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:33:30 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:33:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:33:57 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:46:14 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:46:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:46:19 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59406|0 |1 is obsolete| | Attachment #59407|0 |1 is obsolete| | Attachment #59408|0 |1 is obsolete| | Attachment #59409|0 |1 is obsolete| | Attachment #59488|0 |1 is obsolete| | Attachment #59768|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 59772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59772&action=edit [SIGNED-OFF] Bug 17960: Add a test to highlight the issue With only this patch applied, proving t/db_dependent/Koha/News.t will return "Attempt to bless into a reference at /home/vagrant/kohaclone/Koha/Object.pm line 78." Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:46:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:46:26 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #10 from Josef Moravec --- Created attachment 59773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59773&action=edit [SIGNED-OFF] Bug 17960: Rename opac_news.new with opac_news.content The field opac_news.new is very confusing and should be renamed. If you want to access it via Koha::NewsItem you will have trouble: use Koha::News; my $news_item = Koha::News->next; say $news_item->new; => Attempt to bless into a reference at /home/vagrant/kohaclone/Koha/Object.pm line 78. This patchset is going to rename this DB field to opac_news_content instead. Since the opac_news.new can be used in notice templates, we need to warn the user during the update DB process that some templates must be updated. Test plan: 0/ Apply the first patch "Add a test to highlight the issue" and confirm that the test fail 1/ Apply this second patch 2/ Execute the DB entry 3/ Confirm that you get a warning if at least one of your notice templates is using opac_news.new 4/ Confirm that the test new pass 5/ Add/update and delete a news 6/ Confirm that the RSS new feed still works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:46:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:46:33 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #11 from Josef Moravec --- Created attachment 59774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59774&action=edit [SIGNED-OFF] Bug 17960: Update installed files git grep opac_news.new installer should not return any occurrences in sql files Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:46:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:46:38 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #12 from Josef Moravec --- Created attachment 59775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59775&action=edit [SIGNED-OFF] Bug 17960: DBIC Schema changes for opac_news.content Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:46:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:46:43 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #13 from Josef Moravec --- Created attachment 59776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59776&action=edit [SIGNED-OFF] Bug 17960: Add opac_news.content values in tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 10:46:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 09:46:50 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #14 from Josef Moravec --- Created attachment 59777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59777&action=edit [SIGNED-OFF] Bug 17960: Replace missing occurrences Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:00:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:00:22 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:00:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:00:25 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59762|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 59778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59778&action=edit [SIGNED-OFF] Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:40:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:40:51 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59761|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart --- Created attachment 59779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59779&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:40:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:40:58 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #55 from Jonathan Druart --- Created attachment 59780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59780&action=edit Bug 14224: Check if the columns do not exist before creating them Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:41:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:41:04 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #56 from Jonathan Druart --- Created attachment 59781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59781&action=edit Bug 14224: Do not reintroduce GetItemIssue, it's dying Bug 17680 is removing it. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:41:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:41:10 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #57 from Jonathan Druart --- Created attachment 59782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59782&action=edit Bug 14224: Reintroduce previous copyright Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:41:15 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #58 from Jonathan Druart --- Created attachment 59783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59783&action=edit Bug 14224: Remove SQL query in svc script Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:41:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:41:20 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #59 from Jonathan Druart --- Created attachment 59784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59784&action=edit Bug 14224: Fix prevent submit That did not work, the form was submitted anyway Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:41:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:41:27 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #60 from Jonathan Druart --- Created attachment 59785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59785&action=edit Bug 14224: Make strings translatable The strings should be translatable. This patch also removes the error as it appears that we only have 1 error. To improve we could surround the store with an eval. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:41:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:41:33 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #61 from Jonathan Druart --- Created attachment 59786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59786&action=edit Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:42:29 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #62 from Jonathan Druart --- I'd like either a signoff on these follow-ups or someone else to QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:51:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:51:26 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #63 from Jonathan Druart --- Created attachment 59787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59787&action=edit Bug 14224: Update Copyright Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:51:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:51:31 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #64 from Jonathan Druart --- Created attachment 59788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59788&action=edit Bug 14224: Improve escaped characters To recreate the problem, submit a note like doh"doh Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:53:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:53:17 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #65 from Jonathan Druart --- And 2 more. I do not really care about the number of patches, someone can squashed them. I think that makes the changes more readable and separate the different problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 11:58:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 10:58:10 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #66 from Josef Moravec --- (In reply to Jonathan Druart from comment #55) > Created attachment 59780 [details] [review] > Bug 14224: Check if the columns do not exist before creating them > > Signed-off-by: Jonathan Druart Probably better to ommit "IGNORE" when using column_exists function, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:10:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:10:13 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #67 from Josef Moravec --- (In reply to Josef Moravec from comment #66) > (In reply to Jonathan Druart from comment #55) > > Created attachment 59780 [details] [review] [review] > > Bug 14224: Check if the columns do not exist before creating them > > > > Signed-off-by: Jonathan Druart > > Probably better to ommit "IGNORE" when using column_exists function, what do > you think? But it's only think, otherwise everything looks good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:11:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:11:15 +0000 Subject: [Koha-bugs] [Bug 17512] Improve handling dates in C4::Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:11:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:11:19 +0000 Subject: [Koha-bugs] [Bug 17512] Improve handling dates in C4::Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59759|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 59789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59789&action=edit Bug 17512: Improve handling dates in C4::Items This is a follow-up on the internal server error on 0000-00-00 in the items column onloan. This patch deals with preventing to have such dates at all in the date fields of items. It is accomplished by: [1] Adding a (private) subroutine _mod_item_dates. It takes an item hash and replaces date values if needed. [2] AddItem and ModItem call _koha_new_item resp. koha_modify_item. In these routines a call to the new _mod_item_dates is inserted. [3] Although the routine is actually private, I have added some unit tests to Items.t. Test plan: [1] Add a new item. Fill a correct date in dateaccessioned and an invalid date in Price effective from (=replacementpricedate). [2] Verify that dateaccessioned is saved correctly and replacementpricedate is still null (does not contain 0000-00-00). [3] Edit the item again. Fill some text in dateaccessioned and put a correct date in replacementpricedate. Verify the results. [4] Run t/db_dependent/Items.t Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:13:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:13:29 +0000 Subject: [Koha-bugs] [Bug 13169] C4::Templates::themelanguage fails if the DB is not populated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 [Bug 17982] Fix the use of uniq in sub themelanguage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:13:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:13:29 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13169 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13169 [Bug 13169] C4::Templates::themelanguage fails if the DB is not populated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:15:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:15:03 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:15:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:15:09 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59765|0 |1 is obsolete| | Attachment #59766|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 59790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59790&action=edit Bug 17982: Expose wrong use of uniq This test should fail without the patch fixing the uniq calls. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:15:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:15:16 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #20 from Jonathan Druart --- Created attachment 59791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59791&action=edit Bug 17982: Fix the use of uniq in sub themelanguage Doing uniq( \@themes ) is useless. It will just return to you the only reference you gave it. List::MoreUtils::uniq requires a list instead of an arrayref. So it is a trivial fix that makes sub themelanguage return one theme instead of three themes like [ 'prog', 'prog', 'prog' ]. Note that Template->new inserts one or two include paths to TT for each of these three identical themes. Test plan: [1] Run t/db_dependent/Templates.t (should no longer fail) [2] Run t/db_dependent/Auth.t (triggering themelanguage) [3] Open a page on OPAC or intranet. (Did you restart Plack?) Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett EDIT (Marcel): Amended test plan for additional unit test. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:20:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:20:47 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Jonathan Druart --- Ha, something else: 1/ OpacNewsLibrarySelect is not correctly placed in sysprefs.sql 2/ In opac.pref, "Policy:" seems wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:22:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:22:50 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #47 from Jonathan Druart --- Created attachment 59792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59792&action=edit Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:22:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:22:55 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #48 from Jonathan Druart --- Created attachment 59793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59793&action=edit Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying with each new edit, losing the previous effort. Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:23:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:23:02 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #49 from Jonathan Druart --- Created attachment 59794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59794&action=edit Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:23:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:23:07 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #50 from Jonathan Druart --- Created attachment 59795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59795&action=edit Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. Signed-off-by: Nick Clemens Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:23:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:23:30 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:24:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:24:45 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59780|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart --- Created attachment 59796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59796&action=edit Bug 14224: Check if the columns do not exist before creating them Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:25:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:25:39 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #69 from Jonathan Druart --- (In reply to Josef Moravec from comment #66) > (In reply to Jonathan Druart from comment #55) > > Created attachment 59780 [details] [review] [review] > > Bug 14224: Check if the columns do not exist before creating them > > > > Signed-off-by: Jonathan Druart > > Probably better to ommit "IGNORE" when using column_exists function, what do > you think? Yes definitely, especially because bug 17234. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:36:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:36:27 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:36:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:36:30 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59752|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 59797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59797&action=edit Bug 18033: Remove duplicate code in paycollect.pl Test plan: 0) apply the patch 1) try to pay individual fee, with full amount and partial amount it should work the same as before patch Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:43:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:43:18 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59781|0 |1 is obsolete| | --- Comment #70 from Josef Moravec --- Created attachment 59798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59798&action=edit Bug 14224: Do not reintroduce GetItemIssue, it's dying Bug 17680 is removing it. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:43:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:43:31 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59782|0 |1 is obsolete| | --- Comment #71 from Josef Moravec --- Created attachment 59799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59799&action=edit Bug 14224: Reintroduce previous copyright Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:43:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:43:46 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59783|0 |1 is obsolete| | --- Comment #72 from Josef Moravec --- Created attachment 59800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59800&action=edit Bug 14224: Remove SQL query in svc script Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:44:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:44:04 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59784|0 |1 is obsolete| | --- Comment #73 from Josef Moravec --- Created attachment 59801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59801&action=edit Bug 14224: Fix prevent submit That did not work, the form was submitted anyway Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:44:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:44:15 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59785|0 |1 is obsolete| | --- Comment #74 from Josef Moravec --- Created attachment 59802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59802&action=edit Bug 14224: Make strings translatable The strings should be translatable. This patch also removes the error as it appears that we only have 1 error. To improve we could surround the store with an eval. Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:44:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:44:24 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59786|0 |1 is obsolete| | --- Comment #75 from Josef Moravec --- Created attachment 59803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59803&action=edit Bug 14224: Replace AllowIssueNotes with AllowCheckoutNotes Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:44:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:44:37 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59787|0 |1 is obsolete| | --- Comment #76 from Josef Moravec --- Created attachment 59804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59804&action=edit Bug 14224: Update Copyright Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:44:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:44:46 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59788|0 |1 is obsolete| | --- Comment #77 from Josef Moravec --- Created attachment 59805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59805&action=edit Bug 14224: Improve escaped characters To recreate the problem, submit a note like doh"doh Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:44:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:44:59 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59796|0 |1 is obsolete| | --- Comment #78 from Josef Moravec --- Created attachment 59806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59806&action=edit Bug 14224: Check if the columns do not exist before creating them Signed-off-by: Jonathan Druart Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:46:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:46:54 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #79 from Josef Moravec --- (In reply to Jonathan Druart from comment #62) > I'd like either a signoff on these follow-ups or someone else to QA. Signed your followups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:47:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:47:25 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:47:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:47:31 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57901|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 59807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59807&action=edit Bug 16530: Adding a circ sidebar navigation menu and circSidebar syspref to activate/deactivate Edit: Fast cataloging link should now show on all pages, removed offline circulation links Edit 2: Creates the syspref to activate or deactivate the sidebar Edit 3: Fixing merge conflicts, using Koha::BiblioFrameworks to find FA framework and adding sidebar to on-site checkouts This adds a sidebar to circ/branchoverdues.tt circ/circulation.tt (I also fixed up some of the indentation in this file to make it easier to see where the divs started and ended) circ/renew.tt circ/returns.tt circ/selectbranchprinter.tt circ/transferstoreceive.tt circ/view_holdsqueue.tt circ/waitingreserves.tt circ/branchtransfers.tt circ/on-site_checkouts.tt To test: 1) Confirm syspref CircSidebar is activated 2) Go to all of the above pages and confirm the sidebar menu shows up 3) Confirm fast cataloguing link and transfer link are there 4) Trigger any error messages you can possibly think of (i.e. on renew.pl: barcode does not exist). Confirm that this does not mess up the layout of the page 5) Go to a user account page, Check out tab. (Since this is a circ/circulation.pl page). Ensure the circ nav sidebar doesn't show up (confirm it looks as it usually does) 6) Deactivate circSidebar 7) Confirm pages all look normal Sponsored-by: Catalyst IT Signed-off-by: Jan Kissig Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:47:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:47:37 +0000 Subject: [Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 --- Comment #17 from Jonathan Druart --- Created attachment 59808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59808&action=edit Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p We should do the same for the other check (FA exists), but cannot find a good and quick way to implement. Doing it this way will avoid regression later, we will no have to check if the variable is correctly passed to the template. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:51:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:51:14 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #11 from Colin Campbell --- (In reply to Jonathan Druart from comment #9) > (In reply to M. Tompsett from comment #8) > > NOTE: prove -v t/db_dependent/Circulation.t triggers the change. > > Though, all the returned amounts are 0.00 only. > > Where? I did not find it. > > I am not sure this is the correct way to fix it, but definitely the quicker > and more efficient. perldoc -q round sprintf behaves as expected in normal round (i.e) to closest integer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:54:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:54:24 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #80 from Jonathan Druart --- Thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:55:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:55:13 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #12 from Colin Campbell --- (In reply to Jonathan Druart from comment #10) > Should not we rephrase the comment without "penny", to make it more > international? I think penny is fairly universal in US, Commonwealth, and Irish English although most are more formally cent. both are in the commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:56:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:56:29 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #13 from Jonathan Druart --- Yes, but I was more referring to arbitrarily force the number of decimals. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 12:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 11:57:29 +0000 Subject: [Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202 --- Comment #14 from Jonathan Druart --- (In reply to Colin Campbell from comment #12) > (In reply to Jonathan Druart from comment #10) > > Should not we rephrase the comment without "penny", to make it more > > international? > > I think penny is fairly universal in US, Commonwealth, and Irish English > although most are more formally cent. both are in the commit message Ho yes sorry, I thought it was from UK only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:07:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:07:24 +0000 Subject: [Koha-bugs] [Bug 17989] Allow templates from plugin directories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:10:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:10:45 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59778|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 59809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59809&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:14:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:14:31 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- Aleisha, I have rebased your patch on top of the ones I have submitted on bug 14224. You should take a look to apply some changes, for instance: 1/ Return a to_json 2/ Check the existence of the DB columns before inserting them 3/ Use "AFTER" in the ADD column sql query (to enforce fields order) 4/ I do not think checkout_notes should be a new module. I'd say it should go to circ 5/ Make sure the strings are translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:26:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:26:37 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #13 from Jonathan Druart --- Something important: In svc/issue_notes you are not testing that the logged in user is allowed to call this script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:28:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:28:34 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59797|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59810&action=edit Bug 18033: Remove duplicate code in paycollect.pl Test plan: 0) apply the patch 1) try to pay individual fee, with full amount and partial amount it should work the same as before patch Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:28:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:28:30 +0000 Subject: [Koha-bugs] [Bug 18033] If/ else sometimes does not make sense after koha account system refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18033 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:44:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:44:21 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57114|0 |1 is obsolete| | Attachment #57115|0 |1 is obsolete| | Attachment #57116|0 |1 is obsolete| | Attachment #57117|0 |1 is obsolete| | Attachment #57118|0 |1 is obsolete| | Attachment #57119|0 |1 is obsolete| | CC| |glasklas at gmail.com --- Comment #33 from David Gustafsson --- Created attachment 59811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59811&action=edit Rule based permission for MARC fields Rebased against master as single patch. Behaviour of filter modules slightly tweaked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:46:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:46:58 +0000 Subject: [Koha-bugs] [Bug 18037] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Bug ID: 18037 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 13:49:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 12:49:03 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59811|0 |1 is obsolete| | --- Comment #34 from David Gustafsson --- Created attachment 59812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59812&action=edit Rule based permission for MARC fields Oops, forgot to remove some temporary comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:10:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:10:51 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #35 from David Gustafsson --- The previously posted version of this patch at least for me did not apply cleanly. Rebased against current HEAD of master, and also slightly altered the behavior of "GetMarcPermissionsAction". The previous behaviour struck me as odd since a module with a higher specificity will always override modules with lower, even for the case when a filter argument for a module with lower specificity has an exact match. So for example, if we have a rule with filter 'source' => 'bulkmarcimport', and another for 'borrower' => '*', the later rule will always have precedence, even when source is matching 'bulkmarcimport'. I seems more flexible to have the option to override on a more specific filter match. Generally I think this patch is great, and almost exactly what we need, but the whole filter-system I think is in need of some revamping. It would be nice if the modules where more like separate namespaces, so that one set of rules (belonging to a certain module) was applied at once. Right now rules from several modules might be mixed in, and field-specificity has precedence in rules selection. The code could be simplified and optimized if rules where grouped by module instead (and also easier to admin from a user perspective I would believe, since rules precedence would be more obvious. But have made no such changes in the current patch, as wanted to bring this up for discussion before make any large breaking changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:15:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:15:21 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #3 from M. Tompsett --- (In reply to Marcel de Rooy from comment #2) > Saved a kitten for you, Mark. But still needs some polishing.. Thanks, I'll wait for bug 17982 to get pushed, then rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:16:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:16:35 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #76 from Tom?s Cohen Arazi --- Created attachment 59813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59813&action=edit Bug 13757: (QA followup) Fix non-editable attrs on failed save When a field is not editable but displayable in the OPAC, and you submit an incomplete/wrong update, those attributes are displayed as empty. This patch fixes that. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:21:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:21:41 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #142 from Owen Leonard --- (In reply to Alex Buckley from comment #138) > Re: point 9: What is the final decision on summary info. To get this signed > off and through QA are both of you happy for me to remove summary.pl and > summary.tt. And they can be added in a separate bug? I think this is the right thing to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:24:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:24:11 +0000 Subject: [Koha-bugs] [Bug 18037] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:24:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:24:13 +0000 Subject: [Koha-bugs] [Bug 18037] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 --- Comment #1 from Marcel de Rooy --- Created attachment 59814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59814&action=edit Bug 18037: Hold notes template cleanup (from 15545) >From the second patch of bug 15545: Removing some unused template code related to a former approach. Adding some changes for future extension by bug 15545. This patch was tested by Liz Rea when the routine IsHoldNoteRequired was called by opac-reserve.pl. The only change here is that we do not yet call this routine; so leaving her original signoff. Test plan: [1] Enable OPACHoldNotes. [2] Place a hold on a serial record. No behavior change. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:24:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:24:33 +0000 Subject: [Koha-bugs] [Bug 18037] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:25:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:25:08 +0000 Subject: [Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Summary|Working title |Hold notes template cleanup | |(from 15545) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:25:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:25:45 +0000 Subject: [Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:27:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:27:41 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #41 from Marcel de Rooy --- Blocked (temporarily) in favor of bug 18037. Actually splitting the patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:28:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:28:05 +0000 Subject: [Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 [Bug 15545] Optionally make hold notes required when placing a hold (via Koha::Plugin) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:28:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:28:05 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18037 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 [Bug 18037] Hold notes template cleanup (from 15545) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:30:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:30:35 +0000 Subject: [Koha-bugs] [Bug 18037] Hold notes template cleanup (from 15545) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59814|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 59815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59815&action=edit Bug 18037: Hold notes template cleanup (from 15545) >From the second patch of bug 15545: Removing some unused template code related to a former approach. Adding some changes for future extension by bug 15545. This patch was tested by Liz Rea when the routine IsHoldNoteRequired was called by opac-reserve.pl. The only change here is that we do not yet call this routine; so leaving her original signoff. Test plan: [1] Enable OPACHoldNotes. [2] Place a hold on a serial record. No behavior change. Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 14:39:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 13:39:12 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 --- Comment #3 from Baptiste --- Created attachment 59816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59816&action=edit Bug 17937 deleting space around TwitterSummary in OPAC details template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:18:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 14:18:02 +0000 Subject: [Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 --- Comment #7 from David Gustafsson --- Ok! Sorry, I was being very unclear, I was referring to biblios as well. I'm quite new to Koha and marc, so I might be completely wrong, but I don't understand why the handling of 001 and 035a should be handled differently between the two. When importing a bibliographic record into Koha I would expect 001 to be replaced with the Koha local id, and the previous 001 moved to 035a. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:23:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 14:23:55 +0000 Subject: [Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 --- Comment #8 from Marcel de Rooy --- (In reply to David Gustafsson from comment #7) > Ok! Sorry, I was being very unclear, I was referring to biblios as well. I'm > quite new to Koha and marc, so I might be completely wrong, but I don't > understand why the handling of 001 and 035a should be handled differently > between the two. When importing a bibliographic record into Koha I would > expect 001 to be replaced with the Koha local id, and the previous 001 moved > to 035a. Yeah, we were talking authorities. On several reports there was indeed discussion about the biblionumber in 001. Until now no results yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 15:48:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 14:48:04 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59816|0 |1 is obsolete| | --- Comment #4 from Baptiste --- Created attachment 59817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59817&action=edit Bug 17937 deleting space around TwitterSummary in OPAC details template and add twitter image in metatag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:19:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 17:19:58 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #4 from M. Tompsett --- Created attachment 59818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59818&action=edit Bug 18036: Perlcritic improve t/db_dependent/Templates.t TEST PLAN --------- 1) apply 17982 2) perlcritic -3 t/db_dependent/Templates.t -- messages 3) apply this patch 4) perlcritic -3 t/db_dependent/Templates.t -- OK 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:20:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 17:20:10 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59767|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 59819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59819&action=edit Bug 18036: All 4 cases tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:20:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 17:20:28 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #6 from M. Tompsett --- Created attachment 59820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59820&action=edit Proof that all 4 cases are triggered. Do not push! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 18:23:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 17:23:05 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from M. Tompsett --- Thanks for the rescue, Marcel, but I was so focused on non-en, that I forgot I was just trying to trigger the first case. Why complicate things, when simple works? DO NOT PUSH the proof patch. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:15:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 18:15:52 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- Generates the meta data, but can't figure out how to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:29:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 18:29:05 +0000 Subject: [Koha-bugs] [Bug 18038] New: Generate fees per month for all patrons with a particular category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18038 Bug ID: 18038 Summary: Generate fees per month for all patrons with a particular category Change sponsored?: --- Product: Koha Version: 3.22 Hardware: PC OS: Linux Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: ing.lucianac at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries collect fees every month from patrons. By now there is no possibility to generate a fee but manually one by one. I think maybe you can put an option where we can click it and automatically generate the fees for the actual month for a particulary category that we can select. Thank you. Regards, Luciana. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 18:35:20 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #8 from Marcel de Rooy --- Why not leave this test: cmp_deeply( ( C4::Templates::themelanguage( C4::Context->config('intrahtdocs'), 'about.tt' , 'intranet', 'fake_cgi' ) )[2], [ 'prog' ], 'We only expect one prog here' ); The other tests do not touch the returned themes,, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 19:58:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 18:58:17 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #9 from M. Tompsett --- (In reply to Marcel de Rooy from comment #8) > Why not leave this test: > cmp_deeply( ( C4::Templates::themelanguage( > C4::Context->config('intrahtdocs'), 'about.tt' , 'intranet', 'fake_cgi' ) > )[2], [ 'prog' ], 'We only expect one prog here' ); > > The other tests do not touch the returned themes,, Oops... Good point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 19:05:38 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #10 from M. Tompsett --- Created attachment 59821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59821&action=edit Bug 18036: Replace accidentally deleted test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:16:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 19:16:29 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #11 from M. Tompsett --- Created attachment 59822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59822&action=edit Bug 18036: Full complement of testing Added theme, lang, and availablethemes tests for all 4 cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:19:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 19:19:48 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59819|0 |1 is obsolete| | Attachment #59821|0 |1 is obsolete| | Attachment #59822|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 59823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59823&action=edit Bug 18036: All 4 cases tested Added theme, lang, and availablethemes tests for all 4 cases. Previously just availablethemes was tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:19:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 19:19:58 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59820|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 59824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59824&action=edit Proof that all 4 cases are triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 20:25:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 19:25:10 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 --- Comment #5 from Mirko Tietgen --- Just had it again. The XML file is created with Catmandu. When I convert it to mrc (with Catmandu) it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:02:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 20:02:28 +0000 Subject: [Koha-bugs] [Bug 18039] New: Move the mandatory and optional files for non-english languages into ' default' directory so bug 17855 permits use of other languages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039 Bug ID: 18039 Summary: Move the mandatory and optional files for non-english languages into 'default' directory so bug 17855 permits use of other languages Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 17855 At the moment after applying bug 17855 (updated web installer and onboarding tool) users can only use Koha in English. This bug requires the moving of mandatory and optional files into default directories for all other non-English languages. The rationale for placing the work for this in a bug separate to bug 17855 is that it is going to take a lot of testing to confirm all files have been moved and Koha with the updated web installer and onboarding tool works with other languages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:02:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 20:02:28 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039 [Bug 18039] Move the mandatory and optional files for non-english languages into 'default' directory so bug 17855 permits use of other languages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:05:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 20:05:34 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 --- Comment #14 from M. Tompsett --- Created attachment 59825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59825&action=edit Bug 18036: Followup If you have the proof applied, do not apply this. If you do not have the proof applied, apply this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 21:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 20:52:06 +0000 Subject: [Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 --- Comment #21 from Liz Rea --- Cool thank you very much. Just made building a package trickier than necessary. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:17:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:17:59 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #143 from Alex Buckley --- In the commit I have just finished (soon to be attached to bug 17855) the following points have been addressed: 1/ I have made a new bug 18039 (assigned to myself but if someone else wants to take it on they are more than welcome to). This bug requires the movement of the mandatory and optional files of other languages into default directories. Because this is a complex job it is going to take significant testing and so I have placed the work for this in a new bug report to keep bug 17855 moving forwards. 2/ M.Tompsetts patch has addressed this issue as the xt test now returns a successful result of: xt/sample_notices.t ......... ok xt/single_quotes.t .......... ok xt/tt_valid.t ............... ok xt/verify-debian-docbook.t .. ok xt/yaml_valid.t ............. ok All tests successful. Files=5, Tests=90, 5 wallclock secs ( 0.05 usr 0.00 sys + 4.19 cusr 0.06 csys = 4.30 CPU) Result: PASS 3/ I assume you mean the use pragmas at the top of the onboarding tool. If this is the case in my most recent commit I have removed 7 more unused use pragmas. 4. I've fixed the copyright notice 5. I now include the js from categories.js, removing the duplicate js code in onboardingstep2.tt except for the assignment of the message variables and the enrollment_period function which is different for the onboarding tool to that in the categories.js 6. I've fixed the indentation of js in onboardingstep3.tt. Due to my password_match js function being slightly different to the one in members.js I have left that in onboardingstep3.tt additionally I have left the form validation js code in onboardingstep3.tt as there are different fields to validate than the memberentrygen.tt. Making the js form validation in members.js work for both the onboardingstep3.tt and memberentrygen.tt can be done in a later bug as a lot of testing would be required. 7. I have now removed summary.tt which can be added in a later bug 8. Removed summary.pl same reason as above 9. Removed summary info same reason as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:30:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:30:44 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:30:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:30:47 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59742|0 |1 is obsolete| | --- Comment #144 from Alex Buckley --- Created attachment 59826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59826&action=edit Bug 17855: Follow-up on broken xt test Apologies for missing that. Here is a patch for point 2 in comment #133. TEST PLAN --------- 1) apply all except this patch 2) prove xt -- a failure 3) apply this patch 4) prove xt -- no failures 5) prove t -- only prices fails on master, and is unrelated to this patch. 6) run koha qa test tools Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:31:34 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:35:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:35:52 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:35:56 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #41 from Liz Rea --- Created attachment 59827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59827&action=edit Bug 14764 - [followup] Addressing QA concerns * removed Policy: * put the syspref in alpha order with the others * added els to the if. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:40:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:40:37 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:40:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:40:41 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59809|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia --- Created attachment 59828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59828&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:42:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:42:48 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59828|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia --- Created attachment 59829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59829&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:43:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:43:41 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #16 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #12) > Aleisha, > I have rebased your patch on top of the ones I have submitted on bug 14224. > You should take a look to apply some changes, for instance: > 1/ Return a to_json > 2/ Check the existence of the DB columns before inserting them > 3/ Use "AFTER" in the ADD column sql query (to enforce fields order) > 4/ I do not think checkout_notes should be a new module. I'd say it should > go to circ > 5/ Make sure the strings are translatable (In reply to Jonathan Druart from comment #13) > Something important: In svc/issue_notes you are not testing that the logged > in user is allowed to call this script. I have applied all of these changes and changed all instances (I think) of 'issue note' to 'checkout note'. This is ready to sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:44:27 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #145 from Alex Buckley --- Created attachment 59830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830&action=edit Bug 17855 - Follow up on copyright text, removal of summary info, removal of duplicate js and improved js indentation, removed useless use pragmas Tets plan: Same as outlined in previous comments: Go to and go through the web installer and onboarding tool: https://koha-community.org/manual/installation/html/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 22:45:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 21:45:11 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:10:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 22:10:27 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57873|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia --- Created attachment 59831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59831&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) IMPORTANT STEP: Before you import, make sure that the authtypecode of the file you are going to import matches the Code of your new authority type. Use Vim or something similar to do a search and replace and change the codes in your file - do NOT use LibreOffice etc. because it tries to be too helpful and messes with the formatting of the file (this is what has broken the Import function in previous testing of this patch) 7) Import into your new authority type using the file you just exported (make sure you've done Step 6) 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:14:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 22:14:05 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #3 from Aleisha Amohia --- (In reply to M. Tompsett from comment #2) > Why not just subscriptionsnumber? > See line 796ish where it puts it in the sentence. > There is no need for || 0, because subscriptions.size should be equal to > subscriptionsnumber. I think maybe the code that creates subscriptionsnumber is unnecessary since template toolkit provides the .size method. I will attach a patch that removes this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:16:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 22:16:23 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #4 from Aleisha Amohia --- (In reply to Aleisha Amohia from comment #3) > I think maybe the code that creates subscriptionsnumber is unnecessary since > template toolkit provides the .size method. I will attach a patch that > removes this Classic case of "should've looked at the code before making a comment"... subscriptions number is actually used for a few things in the code so I will change my patch to use it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:18:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 22:18:45 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:18:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 22:18:48 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59288|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 59832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59832&action=edit Bug 17946: Show number of subscriptions on tab in OPAC record details This patch removes some duplicate code. To test: 1) Edit at least one subscription (or add a new one) to have a record 2) Find that record on the OPAC 3) Confirm that the Subscriptions tab reads the correct number of subscriptions attached to the record Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Feb 2 23:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 22:58:42 +0000 Subject: [Koha-bugs] [Bug 18040] New: Updating buttons on Tools->Upload Local Cover Image Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040 Bug ID: 18040 Summary: Updating buttons on Tools->Upload Local Cover Image Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org There are two buttons on this page - Upload file, Process images - and they have different styling and look ugly. Should use bootstrap3 styling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:01:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:01:06 +0000 Subject: [Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:01:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:01:09 +0000 Subject: [Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040 --- Comment #1 from Aleisha Amohia --- Created attachment 59833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59833&action=edit Bug 18040: Updating buttons in Tools -> Upload local cover image To test: 1) Go to Tools -> Upload local cover image 2) Select an image and click Upload file 3) Notice Process images button looks different to Upload file button 4) Apply patch and refresh page 5) Follow steps 1-3 again and notice the changed styling of the buttons Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:01:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:01:19 +0000 Subject: [Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:08:49 +0000 Subject: [Koha-bugs] [Bug 18041] New: Updating buttons in Batch Item Mod and Deletion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041 Bug ID: 18041 Summary: Updating buttons in Batch Item Mod and Deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org The buttons in the whole process are styled differently for both modification and deletion. They should use bootstrap 3 styling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:23:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:23:32 +0000 Subject: [Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041 --- Comment #1 from Aleisha Amohia --- Created attachment 59834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59834&action=edit Bug 18041: Updating buttons in Batch Item modification and deletion To test: 1) Go to Tools -> Batch item modification 2) Put a barcode in and click Continue (notice ugly button) 3) Scroll to the bottom of the page and click Save (you don't have to make any changes) (Notice ugly button) 4) I am leaving the Return button as is 5) Go to Tools -> Batch item deletion 6) Put a barcode in and click Continue (notice ugly button) 7) Uncheck the selected item (so you don't actually delete anything) and click Delete selected items (Notice ugly button) 8) I am leaving the Return button as is 9) Apply patch and repeat steps 1-8. Notice changes to buttons Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:23:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:23:28 +0000 Subject: [Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:24:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:24:29 +0000 Subject: [Koha-bugs] [Bug 18041] Updating buttons in Batch Item Mod and Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18041 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:34:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:34:02 +0000 Subject: [Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932 --- Comment #1 from Aleisha Amohia --- Created attachment 59835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59835&action=edit Bug 11932: Move delete checkbox on patron modification to right To test: 1) Go to Tools -> Batch patron modification 2) Put in a user cardnumber and click Continue 3) Notice checkboxes on the left of the input fields 4) Apply patch and refresh page (resend information if prompted) 5) Notice checkboxes on the right of the input fields 6) Confirm they still work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:33:58 +0000 Subject: [Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:34:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:34:09 +0000 Subject: [Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:43:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:43:10 +0000 Subject: [Koha-bugs] [Bug 18042] New: Update buttons in batch record modification and deletion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042 Bug ID: 18042 Summary: Update buttons in batch record modification and deletion Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Buttons should use bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:44:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:44:43 +0000 Subject: [Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042 --- Comment #1 from Aleisha Amohia --- Created attachment 59836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59836&action=edit Bug 18042: Updating buttons in batch record modification and deletion To test: Create a test record that you can edit and delete. Go through each process of modifying the record, then deleting the record - once before applying the patch, and after apply the patch. Notice the difference in buttons and confirm they all still work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:44:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:44:40 +0000 Subject: [Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:44:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:44:57 +0000 Subject: [Koha-bugs] [Bug 18042] Update buttons in batch record modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18042 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 00:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Feb 2017 23:57:58 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 00:02:46 +0000 Subject: [Koha-bugs] [Bug 18043] New: Updating buttons for z39.50 cataloguing search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Bug ID: 18043 Summary: Updating buttons for z39.50 cataloguing search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Buttons that need to use bootstrap 3/font awesome icons: - Search - MARC (fa) - Card (fa) - Import (fa) - Previous page/Next page - Go - Try another search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:04:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 00:04:52 +0000 Subject: [Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:04:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 00:04:55 +0000 Subject: [Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 --- Comment #1 from Aleisha Amohia --- Created attachment 59837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59837&action=edit Bug 18043: Updating buttons for z39.50 cataloguing search 1) Go to Cataloguing -> New from Z39.50 2) Do a search, noticing the ugly buttons from Comment 1 3) Apply patch and go back to a new search 4) Do a search again, noticing the new, nicer buttons 5) Confirm they still work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:05:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 00:05:17 +0000 Subject: [Koha-bugs] [Bug 18043] Updating buttons for z39.50 cataloguing search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18043 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 01:08:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 00:08:53 +0000 Subject: [Koha-bugs] [Bug 8355] "save" button on the result list doesn't have a clear function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8355 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #3 from Aleisha Amohia --- Can we mark this as resolved? I don't know how this function looked in 2012 but in the latest version it is quite clear, with an 'Add to:' label and the lists marked clearly from the Cart. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 02:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 01:02:14 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59823|0 |1 is obsolete| | Attachment #59825|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 59838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59838&action=edit Bug 18036: All 4 cases tested Added theme, lang, and availablethemes tests for all 4 cases. Previously just availablethemes was tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 02:02:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 01:02:22 +0000 Subject: [Koha-bugs] [Bug 18036] Improve test coverage for themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59824|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 59839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59839&action=edit [DO NOT PUSH] Proof that all 4 cases are triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Feb 3 04:36:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Feb 2017 03:36:15 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #146 from M. Tompsett --- Comment on attachment 59830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830 Bug 17855 - Follow up on copyright text, removal of summary info, removal of duplicate js and improved js indentation, removed useless use pragmas Review of attachment 59830: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=59830) ----------------------------------------------------------------- Quick eyeball. If it behaves as before, I'll sign off. ::: installer/onboarding.pl @@ +2,4 @@ > > # This file is part of Koha. > # > +# Copyright (C) 2017 Catalyst IT Addresses point 4 in comment #133. @@ -30,5 @@ > -use C4::Members::Attributes; > -use C4::Members::AttributeTypes; > -use C4::Log; > -use Koha::AuthorisedValues; > -use Koha::Patron::Debarments; Addresses point 3 in comment #133. @@ -39,5 @@ > use Koha::DateUtils; > use Koha::Patron::Categories; > use Koha::Patron::Category; > -use Koha::Patron::HouseboundRole; > -use Koha::Patron::HouseboundRoles; Addresses point 3 in comment #133. @@ -44,4 @@ > use Koha::ItemTypes; > use Koha::IssuingRule; > use Koha::IssuingRules; > -use Data::Dumper; Addresses point 3 in comment #133. ::: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc @@ -42,5 @@ >
Administration
> [% END %] >
About Koha
> -
Summary
> - Removal deals with point 7-9 in comment #133. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt @@ +5,5 @@ > Add a patron category > [% INCLUDE 'installer-doc-head-close.inc' %] > [% INCLUDE 'calendar.inc' %] > +[% INCLUDE 'js_includes.inc' %] > +[% INCLUDE 'datatables.inc' %] Good simplification to address point 5 in comment #133. @@ +20,4 @@ > } else { > return true; > } > + }, MSG_ONE_ENROLLMENTPERIOD Because of using included javascripts, variable name changed. Related to point 5 in comment #133. @@ +25,2 @@ > > + Addresses point 5 in comment #133. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt @@ +7,4 @@ > [% INCLUDE 'installer-doc-head-close.inc' %] > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'datatables.inc' %] > +[% INCLUDE 'js_includes.inc' %] Point 6 in comment #133. @@ -21,5 @@ > - > - > -