[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Alex,
There are some wrong things here:
1/ No tests are provided
2/ You do not instanciate a Koha::ItemType object but using
get_items_and_biblioitems as a class method.
3/ get_items_and_biblioitems is badly named, it does not return the items and
the biblioitems, but the number of item and biblioitems.
That's why I suggested ->is_used, which would return true or false.
4/ There is no POD for this new method
5/ Why do not you want to use Koha::Items and Koha::Biblioitems?

-- 
You are receiving this mail because:
You are watching all bug changes.