[Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Aleisha,

Here are a few remarks:
1/ in the preferences.pl file, I think it would be better to affect the patron
category list to $chunk->{'CHOICES'} if the type of the syspref is
patron-categories, and not depending on its name. That way it will be reusable
more easily.

2/ There is type=PatronCategories"in the DB, choices:patron-categories in the
opac.pref, then choices eq 'patron-categories' in preferences.pl
How is useful this type=PatronCategories?

3/ There are 2 problematic cases:
a. The field is not filled yet: it's not visible on the interface, there is no
blank entry
b. A bit more tricky: if the patron category has been removed, it will not be
displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.