[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 59630 [details] [review]
> Bug 17982: Fix the use of uniq in sub themelanguage
> 
> Review of attachment 59630 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Templates.pm
> @@ +256,4 @@
> >      my $where = $tmpl =~ /xsl$/ ? 'xslt' : 'modules';
> >      for my $theme (@themes) {
> >          if ( -e "$htdocs/$theme/$lang/$where/$tmpl" ) {
> > +            return ( $theme, $lang, [ uniq(@themes) ] );
> 
> I'm not sure the parenthesis for uniq are necessary.

Seems to be a more a matter of taste.
My personal preference is parentheses, only omitting them with builtins like
open or print.

-- 
You are receiving this mail because:
You are watching all bug changes.