[Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> One test is failing after this patch:
> 
>     #   Failed test 'Columns is nullable in DB, not in swagger file for
> hold: timestamp'
>     #   at t/db_dependent/api/v1/swagger/definitions.t line 71.
> 
> I also think that we should add tests to check data types, don't you think?

I think we might better get rid of definitions.t as there's no obvious reason
why the swagger definition should match the DB. I can take care of adding
'null' as a valid type for 'timestamp' but I think we should better move that
to another bug as the tests are failing without this patches too. See comment
#5

-- 
You are receiving this mail because:
You are watching all bug changes.