[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Feb 1 14:09:49 CET 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757
--- Comment #72 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 59738
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59738&action=edit
Bug 13757: Make Koha::Patron::Modification->store del empty attrs
This patch makes Koha::Patron::Modification->store delete the passed
attributes that contain empty values.
This is the way it currently works, as all opac-editable attributes are
presented to the end-user and they are allowed to delete them, and the
best way I found to represent the deletion on the modification request
is by setting it to the empty string. I chose this way because it is how
the staff interface handles it, so it is consistent.
To test:
- Apply this patch
- Run:
$ prove t/db_dependent/Koha/Patron/Modifications.t
=> SUCCESS: This time tests pass!
- Verify comment #70 on the bug is fixed now
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
https://bugs.koha-community.org/show_bug.cgi?id=13737
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list