[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

--- Comment #23 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(in reply to Jonathan Druart in comment 21)

1/ Presumably you mean test plan rather than the output of a qa test? If so the
test plan is slightly modified from comment 5)

Test plan:
1. In the staff interface, stage and manage MARC records for import

2. Try to delete an itemtype. If there are items of that itemtype in the
   database then a message telling you the number of items of that
   itemtype there are will be displayed.

3. Record that number

4. View the admin/itemtpes.pl script and confirm that there is sql code
   written in this file.

5. Apply this patch

6. View the admin/itemtypes.pl script and observe that there is no sql
   in this file. Confirm there is a module call 
my $overalltotal = Koha::ItemType->get_items_and_biblioitems($itemtype_code)

7. Go to Koha/ItemType.pm and confirm that there is a function named
get_items_and_biblioitems

8. In the staff interface try to delete the same itemtype

9. Record the number of items there are with that itemtype in the
   resulting message

10. The numbers recorded in steps 3 and 9 should match showing that the
   DBIx code in the get_items_and_biblioitems subroutine is working as intended

-- 
You are receiving this mail because:
You are watching all bug changes.